Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13102/
---

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-3969


Repository: cloudstack-git


Description
---

CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 
KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded 
during 3.0.3 setup 

This is due to mysql version conflict with '=' and 'LIKE'.
Changing to '=' while searching for new system template.


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 

Diff: https://reviews.apache.org/r/13102/diff/


Testing
---


Thanks,

Harikrishna Patnala

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[Likitha Shetty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24330
---


Since you have changed the vnet range separator from ';' to ',' 
PhysicalNetworkVO -> getVnet needs to be updated.
This method is referenced in quite a few places.

If not already done, please open a bug to track the UI changes that will be 
needed once this change is checked in. 

- Likitha Shetty


On July 31, 2013, 2:46 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 31, 2013, 2:46 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: [GSoC] Generate API doc

[Prasanna Santhanam]

On Wed, Jul 31, 2013 at 01:45:22PM +0700, Nguyen Anh Tu wrote:
> Hi guys,
> 
> I need your help about generating api document for some new API I added.
> Without this, building failed:
> 
> Traceback (most recent call last):
>   File
> "/home/mint/cloudstack/gsoc/gre/sdnextension/cloudstack/tools/apidoc/gen_toc.py",
> line 189, in 
> category = choose_category(fn)
>   File
> "/home/mint/cloudstack/gsoc/gre/sdnextension/cloudstack/tools/apidoc/gen_toc.py",
> line 169, in choose_category
> (fn, __file__))
> Exception: Need to add a category for listOvsElements.xml to
> /home/mint/cloudstack/gsoc/gre/sdnextension/cloudstack/tools/apidoc/gen_toc.py:known_categories
> 
> I can bypass it with a tricky by declaring the new APIs to known_categories
> but it's an unofficial way.
> 
Simply add a common substring in your API to the most logical category
you find or include a new category if unsuitable.

listOvsElements
createOvsElement
deleteOvsElement

can go into 'OvsElement' : 'NetworkElement'

> Thanks,
> 
> -- 
> 
> N.g.U.y.e.N.A.n.H.t.U

-- 
Prasanna.,


Powered by BigRock.com

RE: Master not running

[Donal Lafferty]

All issues resolved.

DL

> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: 29 July 2013 10:45 PM
> To: dev@cloudstack.apache.org
> Subject: Master not running
> 
> Build master from scratch using pull from this morning.
> 
> Master builds, but does not run using 'mvn -pl :cloud-client-ui jetty:run' due
> using to the following issues:
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3919
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3918  (work around:
> delete "UcsManager" entry
> from  ./client/tomcatconf/applicationContext.xml.in)
> 
> http://markmail.org/message/7l4w4jiqyznzrc6g
> 
> I would be especially grateful for a workaround to the SQL issue in
> https://issues.apache.org/jira/browse/CLOUDSTACK-3919
> 
> 
> DL
> 
> 

Re: Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13102/#review24331
---


Review 13102 PASSED the build test
The url of build cloudstack-master-with-patch #91 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/91/

- Jenkins Cloudstack.org


On July 31, 2013, 7:15 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13102/
> ---
> 
> (Updated July 31, 2013, 7:15 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3969
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 
> 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is 
> uploaded during 3.0.3 setup 
> 
> This is due to mysql version conflict with '=' and 'LIKE'.
> Changing to '=' while searching for new system template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
> 
> Diff: https://reviews.apache.org/r/13102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[bharat kumar]

> On July 31, 2013, 7:35 a.m., Likitha Shetty wrote:
> > Since you have changed the vnet range separator from ';' to ',' 
> > PhysicalNetworkVO -> getVnet needs to be updated.
> > This method is referenced in quite a few places.
> > 
> > If not already done, please open a bug to track the UI changes that will be 
> > needed once this change is checked in.

sure Likitha will check if i have done this and update the patch. Thank you for 
the comment.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24330
---


On July 31, 2013, 2:46 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 31, 2013, 2:46 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: [GSoC] (Screencast/Demo) LDAP user provisioning

[Ian Duffy]

Moving along faster than expected with this.

The pending patches do the following:

 - Disable UI password changes when LDAP is enabled.
 - Disable API password changes when LDAP is enabled.
 - Add support for the memberof filter.

Hope to get SSL done before the week is out.

On 26 July 2013 18:39, Ian Duffy  wrote:
> Its all good :-) just don't want to make promises. Can't trust my home
> internet at all.
>
> Cool will keep an eye out for it. I'd imagine it'd be fairly easy to
> implement.
>
> On 26 Jul 2013 18:25, "Musayev, Ilya"  wrote:
>>
>> I understand, I guess do the best you can, sorry you are losing office
>> space, if would've have been in NYC, we could have helped you with it :)
>>
>> I've also sent an email asking for help with scheduled tasks, perhaps
>> someone can respond.
>>
>> Regards
>> ilya
>>
>> > -Original Message-
>> > From: Ian Duffy [mailto:i...@ianduffy.ie]
>> > Sent: Friday, July 26, 2013 1:10 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [GSoC] (Screencast/Demo) LDAP user provisioning
>> >
>> > Hi llya,
>> >
>> > Apologies in advanced for lack of formatting, currently replying from
>> > mobile.
>> >
>> > Those UI features are present in 4.2 under LDAP configuration within
>> > global
>> > settings as far as I am aware. They are buggy if I remember correctly.
>> >
>> > For deactivating users I haven't looked into it yet and have not sent
>> > out an
>> > email asking for help on creating a scheduled task. It is not included
>> > within
>> > the project proposal so I was leaving it as a 'if I have time at the
>> > end' type of
>> > thing. I lose office space and a decent internet connection come august
>> > 20th
>> > so I'm pushing to get all proposed features done before then.
>> >
>> > Check out 1:25 such messages exist.
>> >
>> > Yes has been tested against Apache DS, openldap and active directory.
>> > I'm a
>> > little worried about implementing a member of filter, I've yet to figure
>> > out
>> > how to enable that in openldap, active directory has it by default
>> > thankfully.
>> > You'll need to set your LDAP attributes for active directory within
>> > global
>> > settings, by default they are at POSIX compliant ones... So..
>> > User object to user username to samAccountName.
>> > On 26 Jul 2013 17:20, "Musayev, Ilya"  wrote:
>> >
>> > > Ian
>> > >
>> > > Watched screencast and you did an amazing job! I want to backport this
>> > > into my customized 4.1 cloudstack edition called cloudsand. CloudSand
>> > > is a hybrid of CloudStack stable version with some urgently needed
>> > > features pulled from master to speed up cloudstack adoption by
>> > > enterprises. The work you do on LDAP will be a great addition!
>> > >
>> > > With that said, I have few questions:
>> > >
>> > > Back several months aqgo, I recall some work done on LDAP where a
>> > > patch was introduced to configure LDAP through UI. Not in Global
>> > > Settings like you did for basedn, but in separate window where you
>> > > defined hostname and port. Would you know what happened to that?
>> > > Where do you stand with scheduled task on checking which ldap users
>> > > have been deactivated and deactivate them in CS as well?
>> > > Also, it would be nice to mention "User XYZ could not be added due to
>> > > missing email (or whatever else is missing)".
>> > > Have you tried testing this on Windows AD, unfortunately, many
>> > > enterprises use Microsoft Active Directory.
>> > >
>> > > Thank again for improving CloudStack,
>> > >
>> > > Regards
>> > > -ilya
>> > >
>> > >
>> > > > -Original Message-
>> > > > From: Ian Duffy [mailto:i...@ianduffy.ie]
>> > > > Sent: Friday, July 26, 2013 11:52 AM
>> > > > To: Sebastien Goasguen; Abhinandan Prateek; CloudStack Dev
>> > > > Subject: [GSoC] (Screencast/Demo) LDAP user provisioning
>> > > >
>> > > > Hi Guys,
>> > > >
>> > > > The latest patch I uploaded to review board (
>> > > > https://reviews.apache.org/r/12969/ ) brings the "LDAP user
>> > > provisioning"
>> > > > project to a "prototype" stage.
>> > > >
>> > > > If anybody wants to give feedback the ldapplugin branch should have
>> > > > all features shown in the screencast once the above patch is
>> > > > shipped.
>> > > > Support still needs to be added for ldap over SSL, memberof filters
>> > > > and
>> > > only
>> > > > show users that exist within ldap but not cloudstack on the add user
>> > > screen.
>> > > >
>> > > > This includes:
>> > > >  - A new plugin for configuring ldap, authenticating against LDAP
>> > > > and
>> > > getting a
>> > > > list of users from LDAP.
>> > > >  - Modified UI
>> > > >- Global Settings - Global LDAP configuration options.
>> > > > BaseDN,
>> > > Bind
>> > > > username, Bind password, etc.
>> > > >- Global settings -> LDAP Configuration. Lets you add
>> > > > multiple
>> > > LDAP
>> > > > servers for failover support.
>> > > >- Accounts -> Add Account. Brings up a table of LDAP users,
>> > > > lets
>> > > you select
>> > 

Re: Review Request 13062: Disable password change on UI when ldap is enabled

[Ian Duffy]

> On July 30, 2013, 1:59 p.m., Jenkins Cloudstack.org wrote:
> > Review 13062 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #83 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/83/

Please note jenkins attempted to apply this to the master branch and not the 
ldapplugin branch resulting in a fail.


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13062/#review24231
---


On July 30, 2013, 8:44 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13062/
> ---
> 
> (Updated July 30, 2013, 8:44 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> General clean up 
> +
> Disable password change on UI when ldap is enabled
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 3e775e0 
>   client/tomcatconf/commands.properties.in b275017 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java
>  01aebce 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java
>  98c9fcf 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy
>  27f3dfc 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy
>  PRE-CREATION 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy
>  PRE-CREATION 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy
>  f4d185b 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy
>  2756e92 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy
>  cf2f9ec 
>   plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 
>   ui/dictionary.jsp eec0264 
>   ui/scripts/accounts.js 43b242d 
>   ui/scripts/ui-custom/accountsWizard.js 7951553 
> 
> Diff: https://reviews.apache.org/r/13062/diff/
> 
> 
> Testing
> ---
> 
> Unit tests, ran + looked at.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 13063: Disables password changing from the API when LDAP is enabled.

[Ian Duffy]

> On July 30, 2013, 3:43 p.m., Jenkins Cloudstack.org wrote:
> > Review 13063 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #85 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/85/

Please note jenkins attempted to apply this to the master branch and not the 
ldapplugin branch resulting in a fail.


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13063/#review24241
---


On July 30, 2013, 3:20 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13063/
> ---
> 
> (Updated July 30, 2013, 3:20 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Disables password changing from the API when LDAP is enabled.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/LdapValidator.java PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> 60d1a97 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java 
> 52ec2ab 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
>  b6fb3e8 
> 
> Diff: https://reviews.apache.org/r/13063/diff/
> 
> 
> Testing
> ---
> 
> Compiled... unit tests passed.
> 
> Enabled LDAP... attempted to change password, failed as expected.
> Disabled LDAP... attempted to change password, success as expected.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 13065: Add support for memberof filter i.e. groups within LDAP.

[Ian Duffy]

> On July 30, 2013, 5:30 p.m., Jenkins Cloudstack.org wrote:
> > Review 13065 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #87 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/87/

Please note jenkins attempted to apply this to the master branch and not the 
ldapplugin branch resulting in a fail.


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13065/#review24255
---


On July 30, 2013, 5:06 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13065/
> ---
> 
> (Updated July 30, 2013, 5:06 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add support for memberof filter i.e. groups within LDAP.
> 
> 
> Diffs
> -
> 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
>  d0ae4d2 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
>  f255752 
>   server/src/com/cloud/configuration/Config.java 1ec0576 
>   setup/db/db/schema-410to420.sql f4cd1b1 
> 
> Diff: https://reviews.apache.org/r/13065/diff/
> 
> 
> Testing
> ---
> 
> Tested against active directory, worked successfully.
> 
> If the value is left empty its not applied.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Generating truststore for LDAPS

[Ian Duffy]

Hi,

Can anybody instruct me on how I can go about enabling LDAPS on active
directory and creating a truststore?

Re: Open up ports beyond 80/443/8080 for downloading templates

[Prasanna Santhanam]

What can be done is to include into validateUrl the port provided in
the endpoint.url from addImageStore API . That will satisfy both
objectstore and NFS based storage. The unorthodox port that comes from
object store will anyway be closed on the SSVM so it will return a
connection-refused.

Would that solve the problem albeit in a hacky way?

In the future we could dissociate the dependency of the ports for
download from the validity of the url generated itself.  

On Wed, Jul 31, 2013 at 02:58:43PM +0900, Thomas O'Dowd wrote:
> I guess what I still don't understand is why restrict urls to certain
> ports? If the ports are not open it will cause an error. If the ports
> are open it will work (assuming the protocol is implemented on that
> port). For example, for register template if I choose a closed port then
> give me a connection error and ask me to try again. Even a currently
> valid port such as 8080 may be closed so it's the same thing really.
> Anyway, if I read Prasanna's mail correctly, it seems like there used to
> be a reason but its probably no harm to open things up?
> 
> Tom.
> 
> On Tue, 2013-07-30 at 16:41 +, Min Chen wrote:
> > Prasanna,
> > Based on your comment, what will happen if we remove that check and 
> > still
> > NFS as secondary storage? In that case, register template is still done
> > through
> > SSVM. Any side effect? I had the same question as Tom when I was doing
> > object store refactoring, but hesitated to remove it because of not
> > knowing the history of it.
> > 
> > Thanks
> > -min
> > 
> > On 7/29/13 11:45 PM, "Prasanna Santhanam"  wrote:
> > 
> > >On Tue, Jul 30, 2013 at 03:37:39PM +0900, Thomas O'Dowd wrote:
> > >> Thanks Ian. I had a look at this file. It's an easy fix to remove the
> > >> check from here but it's a general utility function so will also affect
> > >> other uris... If there is no reason to limit any uri to those ports then
> > >> I'd like to remove this check and open them up.
> > >> 
> > >> Interested to hear opinions,
> > >
> > >This is probably because earlier one would interact only with the SSVM
> > >to download any images off of secondary storage. With 4.2 that ability
> > >is transferred to the image store like say s3/cloudian and one can get
> > >direct http access to the image on the object store. The code in
> > >validateUrl assumes that the url check goes always to the SSVM on
> > >which only 80/443/8080 are open by default.
> > >
> > >-- 
> > >Prasanna.,
> > >
> > >
> > >Powered by BigRock.com
> > >
> > 
> 
> -- 
> Cloudian KK - http://www.cloudian.com/get-started.html
> Fancy 100TB of full featured S3 Storage?
> Checkout the Cloudian?? Community Edition!

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13102/#review24337
---


Commit 9939d094558f59ec2c97ccebaa46e32319f8786d in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9939d09 ]

CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 
KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded 
during 3.0.3 setup

This is due to mysql version conflict with '=' and 'LIKE'.
Changing to '=' while searching for new system template.


- ASF Subversion and Git Services


On July 31, 2013, 7:15 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13102/
> ---
> 
> (Updated July 31, 2013, 7:15 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3969
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 
> 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is 
> uploaded during 3.0.3 setup 
> 
> This is due to mysql version conflict with '=' and 'LIKE'.
> Changing to '=' while searching for new system template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
> 
> Diff: https://reviews.apache.org/r/13102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/#review24338
---


Commit 2c53ede1de1aae2f919e6235975e3342026a134a in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2c53ede ]

CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM


- ASF Subversion and Git Services


On July 30, 2013, 12:47 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13016/
> ---
> 
> (Updated July 30, 2013, 12:47 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3848
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   
> api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
>  a077e24 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
>   server/src/com/cloud/server/ManagementServerImpl.java 996c693 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 
> 
> Diff: https://reviews.apache.org/r/13016/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13102/#review24339
---

Ship it!


commit 28f04c8ecc26b67b07d21a2ed66edb66a4fef603

- Kishan Kavala


On July 31, 2013, 12:45 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13102/
> ---
> 
> (Updated July 31, 2013, 12:45 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3969
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 
> 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is 
> uploaded during 3.0.3 setup 
> 
> This is due to mysql version conflict with '=' and 'LIKE'.
> Changing to '=' while searching for new system template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
> 
> Diff: https://reviews.apache.org/r/13102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13102/#review24336
---


Commit 28f04c8ecc26b67b07d21a2ed66edb66a4fef603 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=28f04c8 ]

CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 
KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded 
during 3.0.3 setup

This is due to mysql version conflict with '=' and 'LIKE'.
Changing to '=' while searching for new system template.


- ASF Subversion and Git Services


On July 31, 2013, 7:15 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13102/
> ---
> 
> (Updated July 31, 2013, 7:15 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3969
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 
> 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is 
> uploaded during 3.0.3 setup 
> 
> This is due to mysql version conflict with '=' and 'LIKE'.
> Changing to '=' while searching for new system template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
> 
> Diff: https://reviews.apache.org/r/13102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12967/
---

(Updated July 31, 2013, 9:49 a.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
---

rebased the patch with 4.2


Bugs: Cloudstack-1695


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-1695
Not enough cpu avialable in cluster according to new overcommit ratio but all 
stopped Vms can be started without any failure(required cpu for stopped vm is 
>> available cpu )


Diffs (updated)
-

  server/src/com/cloud/capacity/CapacityManagerImpl.java 56c3b71 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 31bae47 

Diff: https://reviews.apache.org/r/12967/diff/


Testing
---

Tested on old master.
This happened because we were not recalculating the used and the reserved 
capacities based on the new overcommit ratio. 

Now used and reserved capacities of all the hosts in a overcommited cluster 
will be recalculated on overcommit change by the capacity checker. However this 
will happen only when capacity checker runs meaning the change in capacities 
due to updated overcommit values will not be instantaneous.
  


Thanks,

bharat kumar

Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12967/
---

(Updated July 31, 2013, 9:54 a.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
---

revision 3 is for 4.2 revision 4 is for master.


Bugs: Cloudstack-1695


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-1695
Not enough cpu avialable in cluster according to new overcommit ratio but all 
stopped Vms can be started without any failure(required cpu for stopped vm is 
>> available cpu )


Diffs (updated)
-

  server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 

Diff: https://reviews.apache.org/r/12967/diff/


Testing
---

Tested on old master.
This happened because we were not recalculating the used and the reserved 
capacities based on the new overcommit ratio. 

Now used and reserved capacities of all the hosts in a overcommited cluster 
will be recalculated on overcommit change by the capacity checker. However this 
will happen only when capacity checker runs meaning the change in capacities 
due to updated overcommit values will not be instantaneous.
  


Thanks,

bharat kumar

Re: Generating truststore for LDAPS

[Ian Duffy]

So far I installed the "Active Directory Certificate Services"

Confirmed Domain Controller authentication was present in both
Certificate Templates and CA -> Certificate templates.

I created a new cert in MMC under personal, exported this and used
keytool to create a keystore

keytool -import -file ldapcert.der -keystore ldap.truststore

Is this all that is required?

Re: Generating truststore for LDAPS

[Abhinandan Prateek]

For creating trusted connections to LDAP you need to do the following:

1. Generate a test certificate using javatools that come with JDK.
2. Import this certificate in your AD.
2. Now you need to add this certificate(private key) to your truststore
from where you will run the LDAP client. This is your cloudstack system,
the directory should be visible to management server.
keytool -import -file test.cer -alias test -keystore trusted.ks -storepass
secret

3. The certificate is now in the trust store trusted.ks. Combined with the
storepass you can instruct ldap client (jndi) to make a ssl connection to
LDAP.

Sadhu,
  Can you add more as you have worked on AD ?


-abhi



On Wed, Jul 31, 2013 at 3:26 PM, Ian Duffy  wrote:

> So far I installed the "Active Directory Certificate Services"
>
> Confirmed Domain Controller authentication was present in both
> Certificate Templates and CA -> Certificate templates.
>
> I created a new cert in MMC under personal, exported this and used
> keytool to create a keystore
>
> keytool -import -file ldapcert.der -keystore ldap.truststore
>
> Is this all that is required?
>

Re: Generating truststore for LDAPS

[Abhinandan Prateek]

Ian,
  You are already done with the steps. You just need the path to truststore
and password to create the SSL connection to LDAP.

-abhi


On Wed, Jul 31, 2013 at 3:33 PM, Abhinandan Prateek  wrote:

>
> For creating trusted connections to LDAP you need to do the following:
>
> 1. Generate a test certificate using javatools that come with JDK.
> 2. Import this certificate in your AD.
> 2. Now you need to add this certificate(private key) to your truststore
> from where you will run the LDAP client. This is your cloudstack system,
> the directory should be visible to management server.
>  keytool -import -file test.cer -alias test -keystore trusted.ks
> -storepass secret
>
> 3. The certificate is now in the trust store trusted.ks. Combined with the
> storepass you can instruct ldap client (jndi) to make a ssl connection to
> LDAP.
>
> Sadhu,
>   Can you add more as you have worked on AD ?
>
>
> -abhi
>
>
>
> On Wed, Jul 31, 2013 at 3:26 PM, Ian Duffy  wrote:
>
>> So far I installed the "Active Directory Certificate Services"
>>
>> Confirmed Domain Controller authentication was present in both
>> Certificate Templates and CA -> Certificate templates.
>>
>> I created a new cert in MMC under personal, exported this and used
>> keytool to create a keystore
>>
>> keytool -import -file ldapcert.der -keystore ldap.truststore
>>
>> Is this all that is required?
>>
>
>

Re: Generating truststore for LDAPS

[Ian Duffy]

Hi Abhi,

Cool thanks for confirming that.

Simpler than expected...

On 31 July 2013 11:04, Abhinandan Prateek  wrote:
> Ian,
>   You are already done with the steps. You just need the path to truststore
> and password to create the SSL connection to LDAP.
>
> -abhi
>
>
> On Wed, Jul 31, 2013 at 3:33 PM, Abhinandan Prateek > wrote:
>
>>
>> For creating trusted connections to LDAP you need to do the following:
>>
>> 1. Generate a test certificate using javatools that come with JDK.
>> 2. Import this certificate in your AD.
>> 2. Now you need to add this certificate(private key) to your truststore
>> from where you will run the LDAP client. This is your cloudstack system,
>> the directory should be visible to management server.
>>  keytool -import -file test.cer -alias test -keystore trusted.ks
>> -storepass secret
>>
>> 3. The certificate is now in the trust store trusted.ks. Combined with the
>> storepass you can instruct ldap client (jndi) to make a ssl connection to
>> LDAP.
>>
>> Sadhu,
>>   Can you add more as you have worked on AD ?
>>
>>
>> -abhi
>>
>>
>>
>> On Wed, Jul 31, 2013 at 3:26 PM, Ian Duffy  wrote:
>>
>>> So far I installed the "Active Directory Certificate Services"
>>>
>>> Confirmed Domain Controller authentication was present in both
>>> Certificate Templates and CA -> Certificate templates.
>>>
>>> I created a new cert in MMC under personal, exported this and used
>>> keytool to create a keystore
>>>
>>> keytool -import -file ldapcert.der -keystore ldap.truststore
>>>
>>> Is this all that is required?
>>>
>>
>>

Update .gitignore

[Ian Duffy]

Hi,

Can we add 'engine/storage/integration-test/test-output' to .gitignore?

I find it gets generated on compile and then git thinks I want to add
it to my repo.

Thanks,
Ian

Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/
---

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-2717


Repository: cloudstack-git


Description
---

CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

This is to fix allow.public.user.templates configuration parameter to get the 
value at account level.


Diffs
-

  
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java 
a30e26c 
  api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0 
  server/src/com/cloud/server/ManagementServerImpl.java 26efa10 

Diff: https://reviews.apache.org/r/13107/diff/


Testing
---

Tested locally by firing listcapabilities API call for Admin/user


Thanks,

Harikrishna Patnala

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24340
---



api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java


no need for account id, user context should have that. We dont follow this 
convention.


- Nitin Mehta


On July 31, 2013, 10:40 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> ---
> 
> (Updated July 31, 2013, 10:40 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2717
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
> 
> This is to fix allow.public.user.templates configuration parameter to get the 
> value at account level.
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java
>  a30e26c 
>   api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java 
> c2996f0 
>   server/src/com/cloud/server/ManagementServerImpl.java 26efa10 
> 
> Diff: https://reviews.apache.org/r/13107/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by firing listcapabilities API call for Admin/user
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/
---

(Updated July 31, 2013, 11:19 a.m.)


Review request for cloudstack and Nitin Mehta.


Changes
---

updated patch


Bugs: CLOUDSTACK-2717


Repository: cloudstack-git


Description
---

CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

This is to fix allow.public.user.templates configuration parameter to get the 
value at account level.


Diffs (updated)
-

  server/src/com/cloud/server/ManagementServerImpl.java 26efa10 

Diff: https://reviews.apache.org/r/13107/diff/


Testing
---

Tested locally by firing listcapabilities API call for Admin/user


Thanks,

Harikrishna Patnala

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24341
---

Ship it!


Ship It!

- Nitin Mehta


On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> ---
> 
> (Updated July 31, 2013, 11:19 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2717
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
> 
> This is to fix allow.public.user.templates configuration parameter to get the 
> value at account level.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/server/ManagementServerImpl.java 26efa10 
> 
> Diff: https://reviews.apache.org/r/13107/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by firing listcapabilities API call for Admin/user
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24342
---


Commit 798c507c7d9a0241fbaaddb3348eaa3313b4f9a3 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=798c507 ]

CLOUDSTACK-2717: listCapabilities API to return
 allow.public.user.templates configuration parameter value
 defined at account level.
Signed by - Nitin Mehta


- ASF Subversion and Git Services


On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> ---
> 
> (Updated July 31, 2013, 11:19 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2717
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
> 
> This is to fix allow.public.user.templates configuration parameter to get the 
> value at account level.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/server/ManagementServerImpl.java 26efa10 
> 
> Diff: https://reviews.apache.org/r/13107/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by firing listcapabilities API call for Admin/user
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24343
---


Commit 3d9fc3dbc0e5c19635392593caa61776da02b2b6 in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3d9fc3d ]

CLOUDSTACK-2717: listCapabilities API to return
 allow.public.user.templates configuration parameter value
 defined at account level.
Signed by - Nitin Mehta


- ASF Subversion and Git Services


On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> ---
> 
> (Updated July 31, 2013, 11:19 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2717
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
> 
> This is to fix allow.public.user.templates configuration parameter to get the 
> value at account level.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/server/ManagementServerImpl.java 26efa10 
> 
> Diff: https://reviews.apache.org/r/13107/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by firing listcapabilities API call for Admin/user
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Regarding the hypervisor tools in new system vm templates

[Rajesh Battala]

Hi All,

For 4.2 we had started using new system vm template.
And the generated system vm template for each target hypervisor don't have 
hypervisor specific guest tools installed in it.
It has open-vm tools not hypervisor specific.
I think it would be good to have xentools installed in Xenserver specific 
system vm temapltes, vmware-tools in vmware specific system vm templates.

AFAIK Hypervisor specific tools installed in system vm will give good 
performance.

Thanks
Rajesh Battala

RE: Regarding the hypervisor tools in new system vm templates

[Sudha Ponnaganti]

Any changes to system VM templates require considerable testing. Pl do not make 
changes at this time for System VM templates unless there is a defect fix 
needed. 

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Wednesday, July 31, 2013 4:35 AM
To: dev@cloudstack.apache.org
Subject: Regarding the hypervisor tools in new system vm templates

Hi All,

For 4.2 we had started using new system vm template.
And the generated system vm template for each target hypervisor don't have 
hypervisor specific guest tools installed in it.
It has open-vm tools not hypervisor specific.
I think it would be good to have xentools installed in Xenserver specific 
system vm temapltes, vmware-tools in vmware specific system vm templates.

AFAIK Hypervisor specific tools installed in system vm will give good 
performance.

Thanks
Rajesh Battala

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13107/#review24344
---


Review 13107 PASSED the build test
The url of build cloudstack-master-with-patch #92 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/92/

- Jenkins Cloudstack.org


On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13107/
> ---
> 
> (Updated July 31, 2013, 11:19 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2717
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
> 
> This is to fix allow.public.user.templates configuration parameter to get the 
> value at account level.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/server/ManagementServerImpl.java 26efa10 
> 
> Diff: https://reviews.apache.org/r/13107/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by firing listcapabilities API call for Admin/user
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/
---

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Fixed test case issues mentioned in issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-3594

Radom-ized affinity group name to avoid cascading test case failures stating 
"unable to create affinity group due to affinity group with the same name 
exists".

Included following 2 test suites which were not run in last build because there 
was no decorator for the test cases.
1. TestListAffinityGroups
2. TestUpdateVMAffinityGroups

One test case in TestUpdateVMAffinityGroups is skipped, it's failing right now. 
Will be fixed shortly.


Diffs
-

  test/integration/component/test_affinity_groups.py 3ecab6f 
  tools/marvin/marvin/integration/lib/base.py b552aba 

Diff: https://reviews.apache.org/r/13109/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12967/#review24345
---

Ship it!


commit ba619ec112170b916f69a7466a779196f74bef7c

- Kishan Kavala


On July 31, 2013, 3:24 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12967/
> ---
> 
> (Updated July 31, 2013, 3:24 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-1695
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1695
> Not enough cpu avialable in cluster according to new overcommit ratio but all 
> stopped Vms can be started without any failure(required cpu for stopped vm is 
> >> available cpu )
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
> 
> Diff: https://reviews.apache.org/r/12967/diff/
> 
> 
> Testing
> ---
> 
> Tested on old master.
> This happened because we were not recalculating the used and the reserved 
> capacities based on the new overcommit ratio. 
> 
> Now used and reserved capacities of all the hosts in a overcommited cluster 
> will be recalculated on overcommit change by the capacity checker. However 
> this will happen only when capacity checker runs meaning the change in 
> capacities due to updated overcommit values will not be instantaneous.
>   
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Network Problem

[Thomas Schneider]

I disabled it.

Le 30/07/2013 17:58, Ahmad Emneina a écrit :
> guest os firewall?
>
>
> On Tue, Jul 30, 2013 at 8:14 AM, Thomas Schneider <
> thomas.schnei...@euskill.com> wrote:
>
>> Hi,
>>
>> I created a Security Group that allow all traffic by default in both way.
>> I can ssh to a VM, but when I install LAMP I can't reach the web server.
>> Do you have an idea of the problem ?
>>
>> Regards
>>
>>
>> Le 30/07/2013 03:11, Jijun a écrit :
>>> Hi ,
>>> Basic Network will setup the security group, and it will deny all the
>>> inbound traffic and allow outbound traffic.
>>>
>>> you should manually add some ingress rules.
>>>
>>> offical document:
>>>
>>>
>> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/security-groups.html
>>>
>>>
>>> On 07/30/2013 01:34 AM, Thomas Schneider wrote:
 Hello,

 I have setup cloudstack and it work fine, I can launch VM etc...
 But the problem is I can only SSH to the VM from the host on which she
 is running.
 When I am in the vm I can ping exernal network and download package to
 setup lamp for example.

 I'm in basic network mode
 My config is:

 mgmt srv: 10.10.10.20
 host1: 10.10.10.30
 host2: 10.10.10.31
 nfs for storage 10.10.10.100

 pod pool 10.10.10.110 - 150
 guest pool 10.10.10.200 -250

 and my network config on the host in /etc/init.d/networking/interface
 is:
 ---
 auto p49p1
 iface p49p1 inet manual

 auto cloudbr0
 iface cloudbr0 inet static
  bridge_ports p49p1
  address 10.10.10.31
  netmask 255.255.255.0
  network 10.10.10.0
  broadcast 10.10.10.255
  gateway 10.10.10.254
  # dns-* options are implemented by the resolvconf package, if
 installed
  dns-nameservers 10.1.1.2
 ---

 I also with to use OpenVSwitch but I didn't found a lot of documentation
 for configuring in basic nework mode on ubuntu.

 Tkanks for your Help.

 Best Regards,

>>>
>>
>> --
>> *Thomas Schneider*
>>
>>


-- 
*Thomas Schneider*
Directeur des Opérations
Euskill SARL
Web: www.euskill.com
Mobile: +33 (0)6 19 26 47 76
Mail: thomas.schnei...@euskill.com
5 rue de Phalsbourg
F-67000 Strasbourg

Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24346
---


Review 13109 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #93 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/93/

- Jenkins Cloudstack.org


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13109/
> ---
> 
> (Updated July 31, 2013, 12:13 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed test case issues mentioned in issue 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3594
> 
> Radom-ized affinity group name to avoid cascading test case failures stating 
> "unable to create affinity group due to affinity group with the same name 
> exists".
> 
> Included following 2 test suites which were not run in last build because 
> there was no decorator for the test cases.
> 1. TestListAffinityGroups
> 2. TestUpdateVMAffinityGroups
> 
> One test case in TestUpdateVMAffinityGroups is skipped, it's failing right 
> now. Will be fixed shortly.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_affinity_groups.py 3ecab6f 
>   tools/marvin/marvin/integration/lib/base.py b552aba 
> 
> Diff: https://reviews.apache.org/r/13109/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

[Chip Childers]

On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi wrote:
> > 
> > 
> > > -Original Message-
> > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [ACS42] Release Status Update: After Code Freeze Next Steps
> > > 
> > > > The best type of commit for keeping things clean is a cherry-pick.
> > > > Merging into the release branch is messy to track as the RM.
> > > >
> > > 
> > > That should be a rule for release branches after code freeze.
> > > 
> > > --Alex
> > [Animesh>] Thanks for clarifying, we will follow that for 4.2
> 
> Also can we do a git cherry-pick -x? It lists the original commit from
> which the cherry was picked. Without it git branch --contains on a
> commit id returns the wrong branch the commit was brought in from.

Ah...  smart idea!

[VOTE][RESULTS] Apache Cloudstack 4.1.1 (Second Round)

[Chip Childers]

On Thu, Jul 25, 2013 at 06:04:27PM +, Musayev, Ilya wrote:
> Hi All,
> 
> I've created a 4.1.1 release, with the following artifacts up for a vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1
> Commit: d2c646f0a434831bd5aef88b5692c108fe26e718
> 
> Release notes:
> 
> http://jenkins.cloudstack.org/view/4.1/job/docs-4.1-releasenotes/23/
> 
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.1/
> 
> PGP release keys (signed using B7B5E7FD):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> Vote will be open for 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to indicate 
> "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> d2c646f0a434831bd5aef88b5692c108fe26e718

All,

Ilya contacted me off list, and let me know that he's offline for a bit.

I'm going to close down this vote now.

Results:

+1 binding: chip, marcus, wido, alex, / non-binding: simon
-1 non-binding: ove, nicolas

Based on those results, I'll move forward with publishing the release
now.

-chip

Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e 
  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
  server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
  server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
  server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
  setup/db/db/schema-410to420.sql 9cdf837 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar

Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24349
---


Review 13112 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #94 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/94/

- Jenkins Cloudstack.org


On July 31, 2013, 2:53 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13112/
> ---
> 
> (Updated July 31, 2013, 2:53 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-3836
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
> Setup - Table "volumes"
> https://issues.apache.org/jira/browse/CLOUDSTACK-3836
> 
> This extra column is because of the fix 
> Parent id of template incorrectly recorded as last ISO attached to VM.
> 
> when a template is created form the snapshot the sourcetemplateid is recorded 
> as the iso attached to the VM at thee time of creation. 
> 
> we fix this by adding a iso_id column to the volume table. when a template is 
> created from the snapshot we fetch the iso_id form the parent volume and set 
> it as the sourcetemplated id of the newly created template.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
>   engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
>   server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
>   server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
>   server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
>   setup/db/db/schema-410to420.sql 9cdf837 
> 
> Diff: https://reviews.apache.org/r/13112/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/
---

(Updated July 31, 2013, 3:07 p.m.)


Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Changes
---

changed the function getvnets to use coma instead of semicolon.


Bugs: Cloudstack-3753


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-3753
Multiple VLAN range API need to accept a list rather than "add" or "remove" per 
command


Diffs (updated)
-

  api/src/com/cloud/network/NetworkService.java 59ccdbf 
  
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
 333564e 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
  engine/schema/src/com/cloud/network/dao/PhysicalNetworkVO.java f68eee1 
  server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
  server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 

Diff: https://reviews.apache.org/r/12905/diff/


Testing
---

Tested on master.
removed the removevlan parameter.
vlan parameter can be used for both addition and removal of valns.
instead of passing only a vlan range. user has to pass all the vlan ranges that 
he wants to keep.
the vlan ranges missing in the input and present in the db (not allocated) will 
be removed.


Thanks,

bharat kumar

Re: Update .gitignore

[Chip Childers]

On Wed, Jul 31, 2013 at 11:35:32AM +0100, Ian Duffy wrote:
> Hi,
> 
> Can we add 'engine/storage/integration-test/test-output' to .gitignore?
> 
> I find it gets generated on compile and then git thinks I want to add
> it to my repo.
> 
> Thanks,
> Ian
>

Done in ldapplugin branch.

UI Plugin Feature Discussion

[SuichII, Christopher]

I have a couple UI Plugin related features I'm close to wrapping up and I'd 
like to throw them out to take some feedback:

(I realize this is bad form to discuss the feature after implementation, so I 
apologize for that. However, everything here provides an optional feature for 
plugin developers and shouldn't pose any problem to the existing UI.)

UI Internationalization:
This would allow UI Plugins to contribute their own internationalized strings 
to the global js dictionary. Each plugin would define a dictionary.js and 
several dictionary_.js files. As each plugin is loaded, the appropriate 
plugin dictionary is loaded into the global js dictionary (with the global 
dictionary taking precedence in the event of a conflict).

Re-usable Zone Chart:
I have extended some functions in zoneChart.js to allow plugins to create 
charts by simply defining their own function which assembles the chart itself 
rather than having to define the chart in zoneChart.js

Dialog value field:
Currently, the identifying value of json objects is assumed to be 'id' or 
'name' (if 'id' doesn't exist). I have added the option of allowing fields to 
specify which json property should be the identifying value of an object.

Default value functions:
Currently, the default value for a UI field must be a constant. I have extended 
the dialog forms to allow default value functions which are given the standard 
'args' allowing default values to be determined at run time.

has_units field:
I have added a new dialog field type called 'has_units'. This field has an 
input box side by side with a select box. The select box is populated with 
predefined units (MB, GB, TB, for example) and uses (also predefined) 
conversion functions to allow automatic updating of the input box value when 
the units select box is changed.

Please let me know what the proper course of action is from here. Should I go 
ahead and submit diffs to reviewers or is there any discussion to be had before 
I do that?

Thanks,
Chris

Re: [DISCUSS] Should we be releasing -beta releases?

[Chip Childers]

On Wed, Jul 31, 2013 at 12:04:50AM +0100, Nux! wrote:
> On 14.05.2013 15:41, Chip Childers wrote:
> >As a way to get more user feedback on our major feature releases, what
> >does everyone think about releasing one or two -beta releases for each
> >major feature release?
> 
> Hi,
> 
> What has been decided? Will we see any 4.2 betas?
> 
> Lucian
> 
> -- 
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
>

I think that we realized that the upgrade support problems are
significant enough to make this difficult right now.  Consider it an
aspiration for the future.

Re: Noisy ASFBot

[Chip Childers]

On Wed, Jul 31, 2013 at 11:14:58AM +0530, Prasanna Santhanam wrote:
> On Tue, Jul 30, 2013 at 03:17:22PM +0530, Prasanna Santhanam wrote:
> > On Sat, Jul 20, 2013 at 12:15:33PM +0200, Daan Hoogland wrote:
> > > I agree,
> > > 
> > > @Prasanna, can we make ignore default and /activate ASFBot? That would 
> > > have
> > > my preference.
> > > 
> > 
> > I got annoyed about this today myself. 
> > 
> > infrabot:
> > Prasanna Santhanam [Created] (INFRA-6605) Turn off git2jira reports coming 
> > from ASFBot
> > 
> 
> Bot will be less chatty and only report on created bugs. Other bot
> commands are still available. Thanks to Humbeedoh for fixing this.
> 
> Will I see more Citrix folks on IRC now? :)

Would be nice to...  ;-)

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

[Go Chiba]

Does it already fixed all 4.2 docs?
If yes, I'd like to update it to transifex to go ahead doc globalization...


On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
wrote:

> On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> > On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi wrote:
> > >
> > >
> > > > -Original Message-
> > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: RE: [ACS42] Release Status Update: After Code Freeze Next
> Steps
> > > >
> > > > > The best type of commit for keeping things clean is a cherry-pick.
> > > > > Merging into the release branch is messy to track as the RM.
> > > > >
> > > >
> > > > That should be a rule for release branches after code freeze.
> > > >
> > > > --Alex
> > > [Animesh>] Thanks for clarifying, we will follow that for 4.2
> >
> > Also can we do a git cherry-pick -x? It lists the original commit from
> > which the cherry was picked. Without it git branch --contains on a
> > commit id returns the wrong branch the commit was brought in from.
>
> Ah...  smart idea!
>



-- 
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

[Chip Childers]

On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:
> Does it already fixed all 4.2 docs?
> If yes, I'd like to update it to transifex to go ahead doc globalization...

I'm not sure.

Animesh? Docs team?

> 
> 
> On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
> wrote:
> 
> > On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> > > On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi wrote:
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > > > To: dev@cloudstack.apache.org
> > > > > Subject: RE: [ACS42] Release Status Update: After Code Freeze Next
> > Steps
> > > > >
> > > > > > The best type of commit for keeping things clean is a cherry-pick.
> > > > > > Merging into the release branch is messy to track as the RM.
> > > > > >
> > > > >
> > > > > That should be a rule for release branches after code freeze.
> > > > >
> > > > > --Alex
> > > > [Animesh>] Thanks for clarifying, we will follow that for 4.2
> > >
> > > Also can we do a git cherry-pick -x? It lists the original commit from
> > > which the cherry was picked. Without it git branch --contains on a
> > > commit id returns the wrong branch the commit was brought in from.
> >
> > Ah...  smart idea!
> >
> 
> 
> 
> -- 
> 千葉 豪  Go Chiba
> E-mail:go.ch...@gmail.com

RE: [DISCUSS] Should we be releasing -beta releases?

[Musayev, Ilya]

I run my own hybrid version of 4.1 and with some features of 4.2 in production, 
since - I needed to backport some features of 4.2 into 4.1

Since this version was not officially released under ACS, I branded it as 
CloudSand (powered by Apache CloudStack).

You can see the code here: http://www.guthub.com/serverchief.com/cloudsand | 
www. Cloudsand.com

At some point, I would like to release a "RC/beta" of CloudSand 4.2 on my own, 
if anyone wants to join the effort, please ping me :)

Thanks
Ilya



> -Original Message-
> From: Nux! [mailto:n...@li.nux.ro]
> Sent: Thursday, June 27, 2013 8:06 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> 
> On 14.05.2013 15:41, Chip Childers wrote:
> > As a way to get more user feedback on our major feature releases, what
> > does everyone think about releasing one or two -beta releases for each
> > major feature release?
> >
> > This might fall in line with some of the stated concerns about our
> > release schedule (see [1]).  I've stated a desire to be quicker about
> > our releases (my vote was 4 months).  I've also been saying quite
> > publicly that we should never release if we know about upgrade issues
> > (that's the cost of having actual users of our project, which I'm more
> > than willing for us to pay).
> >
> > Perhaps -betaX releases would be helpful to get attention from the
> > users to test the release (including upgrade paths).  The stated
> > assumption could be: -beta releases are not releases that can be
> > upgraded *from*, but are intended to help support testing by end users
> > that want to check the upcoming release against their expected feature
> > set and upgrade path.
> >
> > I would see the first -beta-1 being released about 1 month after
> > feature freeze.  For example, for 4.2.0, it would be on 2013-06-30.  I
> > would only do a -beta-2 (or later) beta release if required due to
> > testing results.  I would also suggest that the -beta-* releases would
> > *not* have any particular quality criteria (well...  perhaps minimal,
> > like blocking on issues that fundamentally make the software
> > unstable).
> >
> > I'm not sure about my own proposal here, but I wanted to throw it out
> > and see if any of you have feedback / thoughts.
> >
> > -chip
> >
> > [1] http://markmail.org/message/3ctdwor5hfbpa3vx
> 
> +1 for beta releases, I was actually thinking of building some RPMS
> from source, want to get a flavour of 4.2 features, but not sure if I can be
> bothered with that. If I had some nightlies or betas available on
> cloudstack.apt-get.eu I'd definitely give it a go.
> 
> Lucian
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro

RE: [DISCUSS] Should we be releasing -beta releases?

[Musayev, Ilya]

Oops, wrong url for github, correct url is:

http://www.guthub.com/serverchief/cloudsand

> -Original Message-
> From: Musayev, Ilya [mailto:imusa...@webmd.net]
> Sent: Wednesday, July 31, 2013 11:52 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] Should we be releasing -beta releases?
> 
> I run my own hybrid version of 4.1 and with some features of 4.2 in
> production, since - I needed to backport some features of 4.2 into 4.1
> 
> Since this version was not officially released under ACS, I branded it as
> CloudSand (powered by Apache CloudStack).
> 
> You can see the code here:
> http://www.guthub.com/serverchief.com/cloudsand | www.
> Cloudsand.com
> 
> At some point, I would like to release a "RC/beta" of CloudSand 4.2 on my
> own, if anyone wants to join the effort, please ping me :)
> 
> Thanks
> Ilya
> 
> 
> 
> > -Original Message-
> > From: Nux! [mailto:n...@li.nux.ro]
> > Sent: Thursday, June 27, 2013 8:06 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> >
> > On 14.05.2013 15:41, Chip Childers wrote:
> > > As a way to get more user feedback on our major feature releases,
> > > what does everyone think about releasing one or two -beta releases
> > > for each major feature release?
> > >
> > > This might fall in line with some of the stated concerns about our
> > > release schedule (see [1]).  I've stated a desire to be quicker
> > > about our releases (my vote was 4 months).  I've also been saying
> > > quite publicly that we should never release if we know about upgrade
> > > issues (that's the cost of having actual users of our project, which
> > > I'm more than willing for us to pay).
> > >
> > > Perhaps -betaX releases would be helpful to get attention from the
> > > users to test the release (including upgrade paths).  The stated
> > > assumption could be: -beta releases are not releases that can be
> > > upgraded *from*, but are intended to help support testing by end
> > > users that want to check the upcoming release against their expected
> > > feature set and upgrade path.
> > >
> > > I would see the first -beta-1 being released about 1 month after
> > > feature freeze.  For example, for 4.2.0, it would be on 2013-06-30.
> > > I would only do a -beta-2 (or later) beta release if required due to
> > > testing results.  I would also suggest that the -beta-* releases
> > > would
> > > *not* have any particular quality criteria (well...  perhaps
> > > minimal, like blocking on issues that fundamentally make the
> > > software unstable).
> > >
> > > I'm not sure about my own proposal here, but I wanted to throw it
> > > out and see if any of you have feedback / thoughts.
> > >
> > > -chip
> > >
> > > [1] http://markmail.org/message/3ctdwor5hfbpa3vx
> >
> > +1 for beta releases, I was actually thinking of building some RPMS
> > from source, want to get a flavour of 4.2 features, but not sure if I
> > can be bothered with that. If I had some nightlies or betas available
> > on cloudstack.apt-get.eu I'd definitely give it a go.
> >
> > Lucian
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro

Re: Open up ports beyond 80/443/8080 for downloading templates

[Min Chen]

Hi Prasanna,

I think what Tom and I mentioned is the url provided in registering a
template, which is totally different from the endpoint.url for the object
store. I still could not understand your suggestion.

Thanks
-min

On 7/31/13 2:47 AM, "Prasanna Santhanam"  wrote:

>What can be done is to include into validateUrl the port provided in
>the endpoint.url from addImageStore API . That will satisfy both
>objectstore and NFS based storage. The unorthodox port that comes from
>object store will anyway be closed on the SSVM so it will return a
>connection-refused.
>
>Would that solve the problem albeit in a hacky way?
>
>In the future we could dissociate the dependency of the ports for
>download from the validity of the url generated itself.
>
>On Wed, Jul 31, 2013 at 02:58:43PM +0900, Thomas O'Dowd wrote:
>> I guess what I still don't understand is why restrict urls to certain
>> ports? If the ports are not open it will cause an error. If the ports
>> are open it will work (assuming the protocol is implemented on that
>> port). For example, for register template if I choose a closed port then
>> give me a connection error and ask me to try again. Even a currently
>> valid port such as 8080 may be closed so it's the same thing really.
>> Anyway, if I read Prasanna's mail correctly, it seems like there used to
>> be a reason but its probably no harm to open things up?
>> 
>> Tom.
>> 
>> On Tue, 2013-07-30 at 16:41 +, Min Chen wrote:
>> > Prasanna,
>> >Based on your comment, what will happen if we remove that check and
>>still
>> > NFS as secondary storage? In that case, register template is still
>>done
>> > through
>> > SSVM. Any side effect? I had the same question as Tom when I was doing
>> > object store refactoring, but hesitated to remove it because of not
>> > knowing the history of it.
>> > 
>> >Thanks
>> >-min
>> > 
>> > On 7/29/13 11:45 PM, "Prasanna Santhanam"  wrote:
>> > 
>> > >On Tue, Jul 30, 2013 at 03:37:39PM +0900, Thomas O'Dowd wrote:
>> > >> Thanks Ian. I had a look at this file. It's an easy fix to remove
>>the
>> > >> check from here but it's a general utility function so will also
>>affect
>> > >> other uris... If there is no reason to limit any uri to those
>>ports then
>> > >> I'd like to remove this check and open them up.
>> > >> 
>> > >> Interested to hear opinions,
>> > >
>> > >This is probably because earlier one would interact only with the
>>SSVM
>> > >to download any images off of secondary storage. With 4.2 that
>>ability
>> > >is transferred to the image store like say s3/cloudian and one can
>>get
>> > >direct http access to the image on the object store. The code in
>> > >validateUrl assumes that the url check goes always to the SSVM on
>> > >which only 80/443/8080 are open by default.
>> > >
>> > >-- 
>> > >Prasanna.,
>> > >
>> > >
>> > >Powered by BigRock.com
>> > >
>> > 
>> 
>> -- 
>> Cloudian KK - http://www.cloudian.com/get-started.html
>> Fancy 100TB of full featured S3 Storage?
>> Checkout the Cloudian?? Community Edition!
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>

Re: UI Plugin Feature Discussion

[Pranav Saxena]

Hey Chris ,

I think whatever proposals you have mentioned here make a lot of sense and
should help in a better user experience. I would suggest that you submit a
patch/multiple patches as per your convenience for the above mentioned
categories and then we can take it forward from there . I would suggest you
to submit multiple patches for each category because that way it will be
easier to review and merge your changes. A little explanation of the
functionality with each patch you submit would be much appreciated.

Copying Brian and Jessica to further help in facilitating this process
quickly . Thanks for your work.


On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
chris.su...@netapp.com> wrote:

> I have a couple UI Plugin related features I'm close to wrapping up and
> I'd like to throw them out to take some feedback:
>
> (I realize this is bad form to discuss the feature after implementation,
> so I apologize for that. However, everything here provides an optional
> feature for plugin developers and shouldn't pose any problem to the
> existing UI.)
>
> UI Internationalization:
> This would allow UI Plugins to contribute their own internationalized
> strings to the global js dictionary. Each plugin would define a
> dictionary.js and several dictionary_.js files. As each plugin is
> loaded, the appropriate plugin dictionary is loaded into the global js
> dictionary (with the global dictionary taking precedence in the event of a
> conflict).
>
> Re-usable Zone Chart:
> I have extended some functions in zoneChart.js to allow plugins to create
> charts by simply defining their own function which assembles the chart
> itself rather than having to define the chart in zoneChart.js
>
> Dialog value field:
> Currently, the identifying value of json objects is assumed to be 'id' or
> 'name' (if 'id' doesn't exist). I have added the option of allowing fields
> to specify which json property should be the identifying value of an object.
>
> Default value functions:
> Currently, the default value for a UI field must be a constant. I have
> extended the dialog forms to allow default value functions which are given
> the standard 'args' allowing default values to be determined at run time.
>
> has_units field:
> I have added a new dialog field type called 'has_units'. This field has an
> input box side by side with a select box. The select box is populated with
> predefined units (MB, GB, TB, for example) and uses (also predefined)
> conversion functions to allow automatic updating of the input box value
> when the units select box is changed.
>
> Please let me know what the proper course of action is from here. Should I
> go ahead and submit diffs to reviewers or is there any discussion to be had
> before I do that?
>
> Thanks,
> Chris
>

RE: [ACS42] Release Status Update: After Code Freeze Next Steps

[Animesh Chaturvedi]

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, July 31, 2013 8:44 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Release Status Update: After Code Freeze Next Steps
> 
> On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:
> > Does it already fixed all 4.2 docs?
> > If yes, I'd like to update it to transifex to go ahead doc
> globalization...
> 
> I'm not sure.
> 
> Animesh? Docs team?
[Animesh>] I am  following up with doc team I see a bunch of doc sub tasks 
still open.
> 
> >
> >
> > On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
> > wrote:
> >
> > > On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
> > > > On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi
> wrote:
> > > > >
> > > > >
> > > > > > -Original Message-
> > > > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > > > Sent: Tuesday, July 30, 2013 2:06 PM
> > > > > > To: dev@cloudstack.apache.org
> > > > > > Subject: RE: [ACS42] Release Status Update: After Code Freeze
> > > > > > Next
> > > Steps
> > > > > >
> > > > > > > The best type of commit for keeping things clean is a
> cherry-pick.
> > > > > > > Merging into the release branch is messy to track as the RM.
> > > > > > >
> > > > > >
> > > > > > That should be a rule for release branches after code freeze.
> > > > > >
> > > > > > --Alex
> > > > > [Animesh>] Thanks for clarifying, we will follow that for 4.2
> > > >
> > > > Also can we do a git cherry-pick -x? It lists the original commit
> > > > from which the cherry was picked. Without it git branch --contains
> > > > on a commit id returns the wrong branch the commit was brought in
> from.
> > >
> > > Ah...  smart idea!
> > >
> >
> >
> >
> > --
> > 千葉 豪  Go Chiba
> > E-mail:go.ch...@gmail.com

Re: UI Plugin Feature Discussion

[SuichII, Christopher]

I'll work on the patches and get them into ReviewBoard shortly. There is, 
however, a Jira issue open for the UI Plugin Internationalization. Could 
someone please grant me access to assign that issue to me. My Jira username is 
'csuich2'.

Thanks,
Chris

On Jul 31, 2013, at 1:30 PM, Pranav Saxena  wrote:

> Hey Chris ,
> 
> I think whatever proposals you have mentioned here make a lot of sense and
> should help in a better user experience. I would suggest that you submit a
> patch/multiple patches as per your convenience for the above mentioned
> categories and then we can take it forward from there . I would suggest you
> to submit multiple patches for each category because that way it will be
> easier to review and merge your changes. A little explanation of the
> functionality with each patch you submit would be much appreciated.
> 
> Copying Brian and Jessica to further help in facilitating this process
> quickly . Thanks for your work.
> 
> 
> On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
> chris.su...@netapp.com> wrote:
> 
>> I have a couple UI Plugin related features I'm close to wrapping up and
>> I'd like to throw them out to take some feedback:
>> 
>> (I realize this is bad form to discuss the feature after implementation,
>> so I apologize for that. However, everything here provides an optional
>> feature for plugin developers and shouldn't pose any problem to the
>> existing UI.)
>> 
>> UI Internationalization:
>> This would allow UI Plugins to contribute their own internationalized
>> strings to the global js dictionary. Each plugin would define a
>> dictionary.js and several dictionary_.js files. As each plugin is
>> loaded, the appropriate plugin dictionary is loaded into the global js
>> dictionary (with the global dictionary taking precedence in the event of a
>> conflict).
>> 
>> Re-usable Zone Chart:
>> I have extended some functions in zoneChart.js to allow plugins to create
>> charts by simply defining their own function which assembles the chart
>> itself rather than having to define the chart in zoneChart.js
>> 
>> Dialog value field:
>> Currently, the identifying value of json objects is assumed to be 'id' or
>> 'name' (if 'id' doesn't exist). I have added the option of allowing fields
>> to specify which json property should be the identifying value of an object.
>> 
>> Default value functions:
>> Currently, the default value for a UI field must be a constant. I have
>> extended the dialog forms to allow default value functions which are given
>> the standard 'args' allowing default values to be determined at run time.
>> 
>> has_units field:
>> I have added a new dialog field type called 'has_units'. This field has an
>> input box side by side with a select box. The select box is populated with
>> predefined units (MB, GB, TB, for example) and uses (also predefined)
>> conversion functions to allow automatic updating of the input box value
>> when the units select box is changed.
>> 
>> Please let me know what the proper course of action is from here. Should I
>> go ahead and submit diffs to reviewers or is there any discussion to be had
>> before I do that?
>> 
>> Thanks,
>> Chris
>> 

FW: CS 4.1.0 - this will help a number of people who struggle with Advanced Networking

[Edison Su]

The KVM installation guide at 
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html
 , is unnecessary complicated and inaccurate. 
For example, we don't need to configure vlan on kvm host by users themselves, 
cloudstack-agent will create vlans automatically.
All users need to do is to create bridges(if the default bridge created by 
cloudstack-agent is not enough), then add these bridge names from cloudstack 
mgt server UI during the zone creation.  

-Original Message-
From: Noel Kendall [mailto:noeldkend...@hotmail.com] 
Sent: Wednesday, July 31, 2013 9:49 AM
To: us...@cloudstack.apache.org
Subject: CS 4.1.0 - this will help a number of people who struggle with 
Advanced Networking

The documentation for installation in a KVM environment is utterly misleading.
The documentation reads as though one can set up the bridge for the public 
network with any name one chooses, the default being cloudbr0.
You cannot use just any old name. That simply will not work.
Let's suppose I have a public network that I isolate on VLAN 5, which is 
interfaced on ethernet adapter eth4. I will need to define an adapter eth4.5 
with VLAN set to yes.
So far, so good.
Next, for the bridge...
By enabling debugging output in the log, I was able to see that the code looks 
for a bridge with the name cloudVirBr5 for my public network.
I had tried several different approaches, none would work if I did not name my 
bridge cloudVirBr5, and set my traffic label on the network configurationto the 
same.
I have seen numerous posts in the mailing lists, blog entries, you name it, 
representing frustrations of throngs of users trying to validate a CS setup.
The documentation is utterly wrong and misleading.
Summary:
does not work:traffic label: cloudbr0 with eth4.5 pointing to cloudbr0 - code 
still tries to create a breth4.5 and enlist eth4.5 to it but cannot because it 
is already enlisted to cloudbr0.
Good luck everyone with advanced networking with VLAN isolation on CentOS KVM 
hosts.
  

Re: UI Plugin Feature Discussion

[Pranav Saxena]

Hi Chip ,

Just a reminder in case you didn't happen to see this thread . Could you
please help out Chris here by granting him access to JIRA ?

Thanks,
Pranav


On Wed, Jul 31, 2013 at 11:31 PM, SuichII, Christopher <
chris.su...@netapp.com> wrote:

> I'll work on the patches and get them into ReviewBoard shortly. There is,
> however, a Jira issue open for the UI Plugin Internationalization. Could
> someone please grant me access to assign that issue to me. My Jira username
> is 'csuich2'.
>
> Thanks,
> Chris
>
> On Jul 31, 2013, at 1:30 PM, Pranav Saxena  wrote:
>
> > Hey Chris ,
> >
> > I think whatever proposals you have mentioned here make a lot of sense
> and
> > should help in a better user experience. I would suggest that you submit
> a
> > patch/multiple patches as per your convenience for the above mentioned
> > categories and then we can take it forward from there . I would suggest
> you
> > to submit multiple patches for each category because that way it will be
> > easier to review and merge your changes. A little explanation of the
> > functionality with each patch you submit would be much appreciated.
> >
> > Copying Brian and Jessica to further help in facilitating this process
> > quickly . Thanks for your work.
> >
> >
> > On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
> > chris.su...@netapp.com> wrote:
> >
> >> I have a couple UI Plugin related features I'm close to wrapping up and
> >> I'd like to throw them out to take some feedback:
> >>
> >> (I realize this is bad form to discuss the feature after implementation,
> >> so I apologize for that. However, everything here provides an optional
> >> feature for plugin developers and shouldn't pose any problem to the
> >> existing UI.)
> >>
> >> UI Internationalization:
> >> This would allow UI Plugins to contribute their own internationalized
> >> strings to the global js dictionary. Each plugin would define a
> >> dictionary.js and several dictionary_.js files. As each plugin
> is
> >> loaded, the appropriate plugin dictionary is loaded into the global js
> >> dictionary (with the global dictionary taking precedence in the event
> of a
> >> conflict).
> >>
> >> Re-usable Zone Chart:
> >> I have extended some functions in zoneChart.js to allow plugins to
> create
> >> charts by simply defining their own function which assembles the chart
> >> itself rather than having to define the chart in zoneChart.js
> >>
> >> Dialog value field:
> >> Currently, the identifying value of json objects is assumed to be 'id'
> or
> >> 'name' (if 'id' doesn't exist). I have added the option of allowing
> fields
> >> to specify which json property should be the identifying value of an
> object.
> >>
> >> Default value functions:
> >> Currently, the default value for a UI field must be a constant. I have
> >> extended the dialog forms to allow default value functions which are
> given
> >> the standard 'args' allowing default values to be determined at run
> time.
> >>
> >> has_units field:
> >> I have added a new dialog field type called 'has_units'. This field has
> an
> >> input box side by side with a select box. The select box is populated
> with
> >> predefined units (MB, GB, TB, for example) and uses (also predefined)
> >> conversion functions to allow automatic updating of the input box value
> >> when the units select box is changed.
> >>
> >> Please let me know what the proper course of action is from here.
> Should I
> >> go ahead and submit diffs to reviewers or is there any discussion to be
> had
> >> before I do that?
> >>
> >> Thanks,
> >> Chris
> >>
>
>

Re: Regarding the variable names in the VOs.

[Min Chen]

You can read Alex's tutorial regarding this:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Data+Access+Layer
VO fieldname and its getter/setter method have to follow java convention.

Thanks
-min



On 7/29/13 3:47 AM, "Bharat Kumar"  wrote:

>Hi all, 
>
>I am came across a bug which was caused because of using underscore in
>the variable name in the VO.
>
> @Column(name = "concurrent_connections")
>Integer concurrent_connections;
>
>because of this the call to update dose not update the VO and if the API
>is used only with this parameter the API server throws an error.
>
>but if i change it to
>
>
>@Column(name = "concurrent_connections")
>Integer concurrentConnections;
>
>(remove the underscore)  it works.
>
>Dose any one know why this dependency is there.
>
>Regards,
>Bharat.
>

Re: FW: CS 4.1.0 - this will help a number of people who struggle with Advanced Networking

[Marcus Sorensen]

Yes, that's correct. I think we need to update the documentation. The
user simply needs to create a bridge where 'public' traffic will work,
and then set that bridge name as the traffic label for public traffic.
Then it will create the vlan device and the bridge necessary for
public based on the physical ethernet device of that bridge.

Note, in this example, it is only looking for cloudVirBr for
compatibility, if there are existing cloudVirBr bridges then the agent
will continue to create cloudVirBr bridges, otherwise, it will create
breth bridges, which allow the same vlan number on different physical
interfaces.

We can easily create some concrete examples for this... such as the
one represented in devcloud-kvm by
tools/devcloud-kvm/devcloud-kvm-advanced.cfg

On Wed, Jul 31, 2013 at 12:06 PM, Edison Su  wrote:
> The KVM installation guide at 
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html
>  , is unnecessary complicated and inaccurate.
> For example, we don't need to configure vlan on kvm host by users themselves, 
> cloudstack-agent will create vlans automatically.
> All users need to do is to create bridges(if the default bridge created by 
> cloudstack-agent is not enough), then add these bridge names from cloudstack 
> mgt server UI during the zone creation.
>
> -Original Message-
> From: Noel Kendall [mailto:noeldkend...@hotmail.com]
> Sent: Wednesday, July 31, 2013 9:49 AM
> To: us...@cloudstack.apache.org
> Subject: CS 4.1.0 - this will help a number of people who struggle with 
> Advanced Networking
>
> The documentation for installation in a KVM environment is utterly misleading.
> The documentation reads as though one can set up the bridge for the public 
> network with any name one chooses, the default being cloudbr0.
> You cannot use just any old name. That simply will not work.
> Let's suppose I have a public network that I isolate on VLAN 5, which is 
> interfaced on ethernet adapter eth4. I will need to define an adapter eth4.5 
> with VLAN set to yes.
> So far, so good.
> Next, for the bridge...
> By enabling debugging output in the log, I was able to see that the code 
> looks for a bridge with the name cloudVirBr5 for my public network.
> I had tried several different approaches, none would work if I did not name 
> my bridge cloudVirBr5, and set my traffic label on the network 
> configurationto the same.
> I have seen numerous posts in the mailing lists, blog entries, you name it, 
> representing frustrations of throngs of users trying to validate a CS setup.
> The documentation is utterly wrong and misleading.
> Summary:
> does not work:traffic label: cloudbr0 with eth4.5 pointing to cloudbr0 - code 
> still tries to create a breth4.5 and enlist eth4.5 to it but cannot because 
> it is already enlisted to cloudbr0.
> Good luck everyone with advanced networking with VLAN isolation on CentOS KVM 
> hosts.
>

RE: UI Plugin Feature Discussion

[Alex Huang]

Done.

--alex

> -Original Message-
> From: Pranav Saxena [mailto:psb...@gmail.com]
> Sent: Wednesday, July 31, 2013 11:27 AM
> To: dev@cloudstack.apache.org; chip.child...@sungard.com
> Cc: Brian Federle; Jessica Wang; Sonny Chhen
> Subject: Re: UI Plugin Feature Discussion
> 
> Hi Chip ,
> 
> Just a reminder in case you didn't happen to see this thread . Could you
> please help out Chris here by granting him access to JIRA ?
> 
> Thanks,
> Pranav
> 
> 
> On Wed, Jul 31, 2013 at 11:31 PM, SuichII, Christopher <
> chris.su...@netapp.com> wrote:
> 
> > I'll work on the patches and get them into ReviewBoard shortly. There
> > is, however, a Jira issue open for the UI Plugin Internationalization.
> > Could someone please grant me access to assign that issue to me. My
> > Jira username is 'csuich2'.
> >
> > Thanks,
> > Chris
> >
> > On Jul 31, 2013, at 1:30 PM, Pranav Saxena  wrote:
> >
> > > Hey Chris ,
> > >
> > > I think whatever proposals you have mentioned here make a lot of
> > > sense
> > and
> > > should help in a better user experience. I would suggest that you
> > > submit
> > a
> > > patch/multiple patches as per your convenience for the above
> > > mentioned categories and then we can take it forward from there . I
> > > would suggest
> > you
> > > to submit multiple patches for each category because that way it
> > > will be easier to review and merge your changes. A little
> > > explanation of the functionality with each patch you submit would be
> much appreciated.
> > >
> > > Copying Brian and Jessica to further help in facilitating this
> > > process quickly . Thanks for your work.
> > >
> > >
> > > On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
> > > chris.su...@netapp.com> wrote:
> > >
> > >> I have a couple UI Plugin related features I'm close to wrapping up
> > >> and I'd like to throw them out to take some feedback:
> > >>
> > >> (I realize this is bad form to discuss the feature after
> > >> implementation, so I apologize for that. However, everything here
> > >> provides an optional feature for plugin developers and shouldn't
> > >> pose any problem to the existing UI.)
> > >>
> > >> UI Internationalization:
> > >> This would allow UI Plugins to contribute their own
> > >> internationalized strings to the global js dictionary. Each plugin
> > >> would define a dictionary.js and several dictionary_.js
> > >> files. As each plugin
> > is
> > >> loaded, the appropriate plugin dictionary is loaded into the global
> > >> js dictionary (with the global dictionary taking precedence in the
> > >> event
> > of a
> > >> conflict).
> > >>
> > >> Re-usable Zone Chart:
> > >> I have extended some functions in zoneChart.js to allow plugins to
> > create
> > >> charts by simply defining their own function which assembles the
> > >> chart itself rather than having to define the chart in zoneChart.js
> > >>
> > >> Dialog value field:
> > >> Currently, the identifying value of json objects is assumed to be 'id'
> > or
> > >> 'name' (if 'id' doesn't exist). I have added the option of allowing
> > fields
> > >> to specify which json property should be the identifying value of
> > >> an
> > object.
> > >>
> > >> Default value functions:
> > >> Currently, the default value for a UI field must be a constant. I
> > >> have extended the dialog forms to allow default value functions
> > >> which are
> > given
> > >> the standard 'args' allowing default values to be determined at run
> > time.
> > >>
> > >> has_units field:
> > >> I have added a new dialog field type called 'has_units'. This field
> > >> has
> > an
> > >> input box side by side with a select box. The select box is
> > >> populated
> > with
> > >> predefined units (MB, GB, TB, for example) and uses (also
> > >> predefined) conversion functions to allow automatic updating of the
> > >> input box value when the units select box is changed.
> > >>
> > >> Please let me know what the proper course of action is from here.
> > Should I
> > >> go ahead and submit diffs to reviewers or is there any discussion
> > >> to be
> > had
> > >> before I do that?
> > >>
> > >> Thanks,
> > >> Chris
> > >>
> >
> >

Re: Review Request 13112: upgrade to ASF 4.2 "cloud" Database Schema Inconsistencies on the Upgraded Setup - Table "volumes"

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated July 31, 2013, 7:17 p.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

Chaged the way we handle upgrade. now we remove the column iso_id in 
schema307-401 and 
add iso_id in schema401-402.


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  "cloud" Database Schema Inconsistencies on the Upgraded 
Setup - Table "volumes"
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e 
  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf 
  server/src/com/cloud/storage/VolumeManager.java 2e44a3c 
  server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 
  server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 9cdf837 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar

Re: [DISCUSS] Should we be releasing -beta releases?

[Daan Hoogland]

H Ilya,

I am working on a paralel track. At Schuberg Philis we have a version
that contains some code from 4.2 and a patch that I cannot get
committed to master. I don't want to release this in the open, but am
interested in your considerations on the subject.

regards,
Daan

On Wed, Jul 31, 2013 at 5:55 PM, Musayev, Ilya  wrote:
> Oops, wrong url for github, correct url is:
>
> http://www.guthub.com/serverchief/cloudsand
>
>> -Original Message-
>> From: Musayev, Ilya [mailto:imusa...@webmd.net]
>> Sent: Wednesday, July 31, 2013 11:52 AM
>> To: dev@cloudstack.apache.org
>> Subject: RE: [DISCUSS] Should we be releasing -beta releases?
>>
>> I run my own hybrid version of 4.1 and with some features of 4.2 in
>> production, since - I needed to backport some features of 4.2 into 4.1
>>
>> Since this version was not officially released under ACS, I branded it as
>> CloudSand (powered by Apache CloudStack).
>>
>> You can see the code here:
>> http://www.guthub.com/serverchief.com/cloudsand | www.
>> Cloudsand.com
>>
>> At some point, I would like to release a "RC/beta" of CloudSand 4.2 on my
>> own, if anyone wants to join the effort, please ping me :)
>>
>> Thanks
>> Ilya
>>
>>
>>
>> > -Original Message-
>> > From: Nux! [mailto:n...@li.nux.ro]
>> > Sent: Thursday, June 27, 2013 8:06 AM
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: [DISCUSS] Should we be releasing -beta releases?
>> >
>> > On 14.05.2013 15:41, Chip Childers wrote:
>> > > As a way to get more user feedback on our major feature releases,
>> > > what does everyone think about releasing one or two -beta releases
>> > > for each major feature release?
>> > >
>> > > This might fall in line with some of the stated concerns about our
>> > > release schedule (see [1]).  I've stated a desire to be quicker
>> > > about our releases (my vote was 4 months).  I've also been saying
>> > > quite publicly that we should never release if we know about upgrade
>> > > issues (that's the cost of having actual users of our project, which
>> > > I'm more than willing for us to pay).
>> > >
>> > > Perhaps -betaX releases would be helpful to get attention from the
>> > > users to test the release (including upgrade paths).  The stated
>> > > assumption could be: -beta releases are not releases that can be
>> > > upgraded *from*, but are intended to help support testing by end
>> > > users that want to check the upcoming release against their expected
>> > > feature set and upgrade path.
>> > >
>> > > I would see the first -beta-1 being released about 1 month after
>> > > feature freeze.  For example, for 4.2.0, it would be on 2013-06-30.
>> > > I would only do a -beta-2 (or later) beta release if required due to
>> > > testing results.  I would also suggest that the -beta-* releases
>> > > would
>> > > *not* have any particular quality criteria (well...  perhaps
>> > > minimal, like blocking on issues that fundamentally make the
>> > > software unstable).
>> > >
>> > > I'm not sure about my own proposal here, but I wanted to throw it
>> > > out and see if any of you have feedback / thoughts.
>> > >
>> > > -chip
>> > >
>> > > [1] http://markmail.org/message/3ctdwor5hfbpa3vx
>> >
>> > +1 for beta releases, I was actually thinking of building some RPMS
>> > from source, want to get a flavour of 4.2 features, but not sure if I
>> > can be bothered with that. If I had some nightlies or betas available
>> > on cloudstack.apt-get.eu I'd definitely give it a go.
>> >
>> > Lucian
>> >
>> > --
>> > Sent from the Delta quadrant using Borg technology!
>> >
>> > Nux!
>> > www.nux.ro
>

Re: UI Plugin Feature Discussion

[Chip Childers]

Chris,

It doesn't appear that that account exists.  What email address does
your account use?

On Wed, Jul 31, 2013 at 11:57:18PM +0530, Pranav Saxena wrote:
> Hi Chip ,
> 
> Just a reminder in case you didn't happen to see this thread . Could you
> please help out Chris here by granting him access to JIRA ?
> 
> Thanks,
> Pranav
> 
> 
> On Wed, Jul 31, 2013 at 11:31 PM, SuichII, Christopher <
> chris.su...@netapp.com> wrote:
> 
> > I'll work on the patches and get them into ReviewBoard shortly. There is,
> > however, a Jira issue open for the UI Plugin Internationalization. Could
> > someone please grant me access to assign that issue to me. My Jira username
> > is 'csuich2'.
> >
> > Thanks,
> > Chris
> >
> > On Jul 31, 2013, at 1:30 PM, Pranav Saxena  wrote:
> >
> > > Hey Chris ,
> > >
> > > I think whatever proposals you have mentioned here make a lot of sense
> > and
> > > should help in a better user experience. I would suggest that you submit
> > a
> > > patch/multiple patches as per your convenience for the above mentioned
> > > categories and then we can take it forward from there . I would suggest
> > you
> > > to submit multiple patches for each category because that way it will be
> > > easier to review and merge your changes. A little explanation of the
> > > functionality with each patch you submit would be much appreciated.
> > >
> > > Copying Brian and Jessica to further help in facilitating this process
> > > quickly . Thanks for your work.
> > >
> > >
> > > On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
> > > chris.su...@netapp.com> wrote:
> > >
> > >> I have a couple UI Plugin related features I'm close to wrapping up and
> > >> I'd like to throw them out to take some feedback:
> > >>
> > >> (I realize this is bad form to discuss the feature after implementation,
> > >> so I apologize for that. However, everything here provides an optional
> > >> feature for plugin developers and shouldn't pose any problem to the
> > >> existing UI.)
> > >>
> > >> UI Internationalization:
> > >> This would allow UI Plugins to contribute their own internationalized
> > >> strings to the global js dictionary. Each plugin would define a
> > >> dictionary.js and several dictionary_.js files. As each plugin
> > is
> > >> loaded, the appropriate plugin dictionary is loaded into the global js
> > >> dictionary (with the global dictionary taking precedence in the event
> > of a
> > >> conflict).
> > >>
> > >> Re-usable Zone Chart:
> > >> I have extended some functions in zoneChart.js to allow plugins to
> > create
> > >> charts by simply defining their own function which assembles the chart
> > >> itself rather than having to define the chart in zoneChart.js
> > >>
> > >> Dialog value field:
> > >> Currently, the identifying value of json objects is assumed to be 'id'
> > or
> > >> 'name' (if 'id' doesn't exist). I have added the option of allowing
> > fields
> > >> to specify which json property should be the identifying value of an
> > object.
> > >>
> > >> Default value functions:
> > >> Currently, the default value for a UI field must be a constant. I have
> > >> extended the dialog forms to allow default value functions which are
> > given
> > >> the standard 'args' allowing default values to be determined at run
> > time.
> > >>
> > >> has_units field:
> > >> I have added a new dialog field type called 'has_units'. This field has
> > an
> > >> input box side by side with a select box. The select box is populated
> > with
> > >> predefined units (MB, GB, TB, for example) and uses (also predefined)
> > >> conversion functions to allow automatic updating of the input box value
> > >> when the units select box is changed.
> > >>
> > >> Please let me know what the proper course of action is from here.
> > Should I
> > >> go ahead and submit diffs to reviewers or is there any discussion to be
> > had
> > >> before I do that?
> > >>
> > >> Thanks,
> > >> Chris
> > >>
> >
> >

Re: UI Plugin Feature Discussion

[Chip Childers]

Never mind - Alex handled it.

On Wed, Jul 31, 2013 at 03:41:06PM -0400, Chip Childers wrote:
> Chris,
> 
> It doesn't appear that that account exists.  What email address does
> your account use?
> 
> On Wed, Jul 31, 2013 at 11:57:18PM +0530, Pranav Saxena wrote:
> > Hi Chip ,
> > 
> > Just a reminder in case you didn't happen to see this thread . Could you
> > please help out Chris here by granting him access to JIRA ?
> > 
> > Thanks,
> > Pranav
> > 
> > 
> > On Wed, Jul 31, 2013 at 11:31 PM, SuichII, Christopher <
> > chris.su...@netapp.com> wrote:
> > 
> > > I'll work on the patches and get them into ReviewBoard shortly. There is,
> > > however, a Jira issue open for the UI Plugin Internationalization. Could
> > > someone please grant me access to assign that issue to me. My Jira 
> > > username
> > > is 'csuich2'.
> > >
> > > Thanks,
> > > Chris
> > >
> > > On Jul 31, 2013, at 1:30 PM, Pranav Saxena  wrote:
> > >
> > > > Hey Chris ,
> > > >
> > > > I think whatever proposals you have mentioned here make a lot of sense
> > > and
> > > > should help in a better user experience. I would suggest that you submit
> > > a
> > > > patch/multiple patches as per your convenience for the above mentioned
> > > > categories and then we can take it forward from there . I would suggest
> > > you
> > > > to submit multiple patches for each category because that way it will be
> > > > easier to review and merge your changes. A little explanation of the
> > > > functionality with each patch you submit would be much appreciated.
> > > >
> > > > Copying Brian and Jessica to further help in facilitating this process
> > > > quickly . Thanks for your work.
> > > >
> > > >
> > > > On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
> > > > chris.su...@netapp.com> wrote:
> > > >
> > > >> I have a couple UI Plugin related features I'm close to wrapping up and
> > > >> I'd like to throw them out to take some feedback:
> > > >>
> > > >> (I realize this is bad form to discuss the feature after 
> > > >> implementation,
> > > >> so I apologize for that. However, everything here provides an optional
> > > >> feature for plugin developers and shouldn't pose any problem to the
> > > >> existing UI.)
> > > >>
> > > >> UI Internationalization:
> > > >> This would allow UI Plugins to contribute their own internationalized
> > > >> strings to the global js dictionary. Each plugin would define a
> > > >> dictionary.js and several dictionary_.js files. As each plugin
> > > is
> > > >> loaded, the appropriate plugin dictionary is loaded into the global js
> > > >> dictionary (with the global dictionary taking precedence in the event
> > > of a
> > > >> conflict).
> > > >>
> > > >> Re-usable Zone Chart:
> > > >> I have extended some functions in zoneChart.js to allow plugins to
> > > create
> > > >> charts by simply defining their own function which assembles the chart
> > > >> itself rather than having to define the chart in zoneChart.js
> > > >>
> > > >> Dialog value field:
> > > >> Currently, the identifying value of json objects is assumed to be 'id'
> > > or
> > > >> 'name' (if 'id' doesn't exist). I have added the option of allowing
> > > fields
> > > >> to specify which json property should be the identifying value of an
> > > object.
> > > >>
> > > >> Default value functions:
> > > >> Currently, the default value for a UI field must be a constant. I have
> > > >> extended the dialog forms to allow default value functions which are
> > > given
> > > >> the standard 'args' allowing default values to be determined at run
> > > time.
> > > >>
> > > >> has_units field:
> > > >> I have added a new dialog field type called 'has_units'. This field has
> > > an
> > > >> input box side by side with a select box. The select box is populated
> > > with
> > > >> predefined units (MB, GB, TB, for example) and uses (also predefined)
> > > >> conversion functions to allow automatic updating of the input box value
> > > >> when the units select box is changed.
> > > >>
> > > >> Please let me know what the proper course of action is from here.
> > > Should I
> > > >> go ahead and submit diffs to reviewers or is there any discussion to be
> > > had
> > > >> before I do that?
> > > >>
> > > >> Thanks,
> > > >> Chris
> > > >>
> > >
> > >

[Publican] What version to use?

[Musayev, Ilya]

What version of publican do we use?

I recently rendered all docs for ACS 4.1.1 release and notices minor background 
inconsistencies along with many warning.

Eventually, it all builds and very much similar to what we have online, but 
perhaps some is different in my version that causes this issue. I'm using 
latest publican from epel for centos6.

Thanks
ilya

Re: [Publican] What version to use?

[David Nalley]

On Wed, Jul 31, 2013 at 4:43 PM, Musayev, Ilya  wrote:

> What version of publican do we use?
>
> I recently rendered all docs for ACS 4.1.1 release and notices minor
> background inconsistencies along with many warning.
>
> Eventually, it all builds and very much similar to what we have online,
> but perhaps some is different in my version that causes this issue. I'm
> using latest publican from epel for centos6.
>
> Thanks
> ilya
>

I am using 2.8.2 - no idea what version is in el6.

--David

Re: [4.1] getVMPassword > how to decrypt

[Chiradeep Vittal]

Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

From: Antonio Petrocelli 
mailto:a.petroce...@netsons.com>>
Reply-To: mailto:dev@cloudstack.apache.org>>
Date: Tuesday, July 30, 2013 2:46 AM
To: mailto:dev@cloudstack.apache.org>>
Subject: [4.1] getVMPassword > how to decrypt

Hello,

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

after retrieved the password i'm unable to decrypt the encryptedpassword.

Suggestions?

Thanks.

Regards.
--

[cid:part1.04090505.09090704@netsons.com]

Supernova s.r.l.
Via G. Misiticoni, 3
65126 - Pescara
ITALY

www.netsons.com
Antonio Petrocelli
Software Engineer


t. (+39) 085 45 100 52
e. a.petroce...@netsons.com


[View Antonio Petrocelli's profile on 
LinkedIn]


Netsons® è un marchio registrato dalla Supernova s.r.l.

Le informazioni trasmesse sono riservate alla persona o alla società indicata 
come destinatario, e possono includere contenuti considerati confidenziali. 
Ogni elaborazione, comunicazione, trasmissione o altro utilizzo, anche azioni 
conseguenti alla conoscenza di queste informazioni da parte di chiunque non sia 
espressamente indicato come destinatario è proibita. Nel caso abbiate ricevuto 
per errore questa comunicazione, siete pregati di darne avviso a info [at] 
netsons.com ed eliminare ogni stampa ed ogni traccia informatica. Il ricevente 
dovrà inoltre accertarsi che gli eventuali allegati non contengano virus prima 
di aprirli. Qualunque opinione o affermazione presentata in questo messaggio è 
da ritenersi propria dell'autore e non rappresenta necessariamente la posizione 
della Società.

The information transmitted is intended only for the person or entity to which 
it is addressed and may contain confidential material. Any review, 
retransmission, dissemination or other use of, or taking of any action in 
reliance upon this information by persons or entities other than the intended 
recipient is prohibited. If you received this in error, please contact: info 
[at] netsons.com and delete the material from any computer. If this email 
contains attachments you should ensure they are checked for viruses before 
opening them. Any views or opinions presented are solely those of the author 
and do not necessarily represent those of the company.

Re: Open up ports beyond 80/443/8080 for downloading templates

[Chiradeep Vittal]

Just a security measure, AFAIK. Since this is user-provided input, it
causes CloudStack to blindly (CloudStack does not have any blacklists for
example) to contact the supplied server. Presumably if the supplied server
has the standard ports open, it has a WAF to defend itself.


On 7/30/13 10:58 PM, "Thomas O'Dowd"  wrote:

>I guess what I still don't understand is why restrict urls to certain
>ports? If the ports are not open it will cause an error. If the ports
>are open it will work (assuming the protocol is implemented on that
>port). For example, for register template if I choose a closed port then
>give me a connection error and ask me to try again. Even a currently
>valid port such as 8080 may be closed so it's the same thing really.
>Anyway, if I read Prasanna's mail correctly, it seems like there used to
>be a reason but its probably no harm to open things up?
>
>Tom.
>
>On Tue, 2013-07-30 at 16:41 +, Min Chen wrote:
>> Prasanna,
>>  Based on your comment, what will happen if we remove that check and
>>still
>> NFS as secondary storage? In that case, register template is still done
>> through
>> SSVM. Any side effect? I had the same question as Tom when I was doing
>> object store refactoring, but hesitated to remove it because of not
>> knowing the history of it.
>> 
>>  Thanks
>>  -min
>> 
>> On 7/29/13 11:45 PM, "Prasanna Santhanam"  wrote:
>> 
>> >On Tue, Jul 30, 2013 at 03:37:39PM +0900, Thomas O'Dowd wrote:
>> >> Thanks Ian. I had a look at this file. It's an easy fix to remove the
>> >> check from here but it's a general utility function so will also
>>affect
>> >> other uris... If there is no reason to limit any uri to those ports
>>then
>> >> I'd like to remove this check and open them up.
>> >> 
>> >> Interested to hear opinions,
>> >
>> >This is probably because earlier one would interact only with the SSVM
>> >to download any images off of secondary storage. With 4.2 that ability
>> >is transferred to the image store like say s3/cloudian and one can get
>> >direct http access to the image on the object store. The code in
>> >validateUrl assumes that the url check goes always to the SSVM on
>> >which only 80/443/8080 are open by default.
>> >
>> >-- 
>> >Prasanna.,
>> >
>> >
>> >Powered by BigRock.com
>> >
>> 
>
>-- 
>Cloudian KK - http://www.cloudian.com/get-started.html
>Fancy 100TB of full featured S3 Storage?
>Checkout the Cloudian® Community Edition!
>

RE: UI Plugin Feature Discussion

[Jessica Wang]

Chris,

> UI Internationalization:
> This would allow UI Plugins to contribute their own internationalized strings 
> to the global js dictionary. Each plugin would define a dictionary.js and 
> several dictionary_.js files. 

So, the translation will be done on client-side?


> Default value functions:
> Currently, the default value for a UI field must be a constant. I have 
> extended the dialog forms to allow default value functions which are given 
> the standard 'args' allowing default values to be determined at run time.

sounds good

> has_units field:
> I have added a new dialog field type called 'has_units'. This field has an 
> input box side by side with a select box. The select box is populated with 
> predefined units (MB, GB, TB, for example) and uses (also predefined) 
> conversion functions to allow automatic updating of the input box value when 
> the units select box is changed.

Cool


Jessica

-Original Message-
From: SuichII, Christopher [mailto:chris.su...@netapp.com] 
Sent: Wednesday, July 31, 2013 8:27 AM
To: 
Subject: UI Plugin Feature Discussion

I have a couple UI Plugin related features I'm close to wrapping up and I'd 
like to throw them out to take some feedback:

(I realize this is bad form to discuss the feature after implementation, so I 
apologize for that. However, everything here provides an optional feature for 
plugin developers and shouldn't pose any problem to the existing UI.)

UI Internationalization:
This would allow UI Plugins to contribute their own internationalized strings 
to the global js dictionary. Each plugin would define a dictionary.js and 
several dictionary_.js files. As each plugin is loaded, the appropriate 
plugin dictionary is loaded into the global js dictionary (with the global 
dictionary taking precedence in the event of a conflict).

Re-usable Zone Chart:
I have extended some functions in zoneChart.js to allow plugins to create 
charts by simply defining their own function which assembles the chart itself 
rather than having to define the chart in zoneChart.js

Dialog value field:
Currently, the identifying value of json objects is assumed to be 'id' or 
'name' (if 'id' doesn't exist). I have added the option of allowing fields to 
specify which json property should be the identifying value of an object.

Default value functions:
Currently, the default value for a UI field must be a constant. I have extended 
the dialog forms to allow default value functions which are given the standard 
'args' allowing default values to be determined at run time.

has_units field:
I have added a new dialog field type called 'has_units'. This field has an 
input box side by side with a select box. The select box is populated with 
predefined units (MB, GB, TB, for example) and uses (also predefined) 
conversion functions to allow automatic updating of the input box value when 
the units select box is changed.

Please let me know what the proper course of action is from here. Should I go 
ahead and submit diffs to reviewers or is there any discussion to be had before 
I do that?

Thanks,
Chris

RE: UI Plugin Feature Discussion

[Jessica Wang]

> I would suggest you to submit multiple patches for each category because that 
> way it will be easier to review and merge your changes.

+1 


-Original Message-
From: Pranav Saxena [mailto:psb...@gmail.com] 
Sent: Wednesday, July 31, 2013 10:30 AM
To: dev@cloudstack.apache.org; Brian Federle; Jessica Wang; Sonny Chhen
Subject: Re: UI Plugin Feature Discussion

Hey Chris ,

I think whatever proposals you have mentioned here make a lot of sense and
should help in a better user experience. I would suggest that you submit a
patch/multiple patches as per your convenience for the above mentioned
categories and then we can take it forward from there . I would suggest you
to submit multiple patches for each category because that way it will be
easier to review and merge your changes. A little explanation of the
functionality with each patch you submit would be much appreciated.

Copying Brian and Jessica to further help in facilitating this process
quickly . Thanks for your work.


On Wed, Jul 31, 2013 at 8:56 PM, SuichII, Christopher <
chris.su...@netapp.com> wrote:

> I have a couple UI Plugin related features I'm close to wrapping up and
> I'd like to throw them out to take some feedback:
>
> (I realize this is bad form to discuss the feature after implementation,
> so I apologize for that. However, everything here provides an optional
> feature for plugin developers and shouldn't pose any problem to the
> existing UI.)
>
> UI Internationalization:
> This would allow UI Plugins to contribute their own internationalized
> strings to the global js dictionary. Each plugin would define a
> dictionary.js and several dictionary_.js files. As each plugin is
> loaded, the appropriate plugin dictionary is loaded into the global js
> dictionary (with the global dictionary taking precedence in the event of a
> conflict).
>
> Re-usable Zone Chart:
> I have extended some functions in zoneChart.js to allow plugins to create
> charts by simply defining their own function which assembles the chart
> itself rather than having to define the chart in zoneChart.js
>
> Dialog value field:
> Currently, the identifying value of json objects is assumed to be 'id' or
> 'name' (if 'id' doesn't exist). I have added the option of allowing fields
> to specify which json property should be the identifying value of an object.
>
> Default value functions:
> Currently, the default value for a UI field must be a constant. I have
> extended the dialog forms to allow default value functions which are given
> the standard 'args' allowing default values to be determined at run time.
>
> has_units field:
> I have added a new dialog field type called 'has_units'. This field has an
> input box side by side with a select box. The select box is populated with
> predefined units (MB, GB, TB, for example) and uses (also predefined)
> conversion functions to allow automatic updating of the input box value
> when the units select box is changed.
>
> Please let me know what the proper course of action is from here. Should I
> go ahead and submit diffs to reviewers or is there any discussion to be had
> before I do that?
>
> Thanks,
> Chris
>

Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer

[Fang Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12958/
---

(Updated July 31, 2013, 10:10 p.m.)


Review request for cloudstack, edison su and Prasanna Santhanam.


Changes
---

Hi Edison, PRasanna, would you review it? I did built and test. Thanks.


Bugs: CLOUDSTACK-3759


Repository: cloudstack-git


Description
---

When the new VM is created and put in stopped state, the volume and pool is not 
allocated. Hence the NPE. 


Diffs
-

  server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 

Diff: https://reviews.apache.org/r/12958/diff/


Testing
---


Thanks,

Fang Wang

RE: [DISCUSS] Should we be releasing -beta releases?

[Musayev, Ilya]

Daan,

Why can't the patch be committed to master?

The reason why CloudSand was created, was to bring in urgently needed features 
into stable version, such that on the next major upgrade to ACS, all features 
work as expected and nothing should break.

Example, if I have a feature in CloudSand 4.1 that was backported from  ACS 
4.2, when end user upgrades to stable release of ACS4.2 - it should all 
function as expected.

So backward compatibility is one of the main focuses for CloudSand release. 

What features are we talking about?

Regards
ilya


> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Wednesday, July 31, 2013 3:20 PM
> To: dev
> Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> 
> H Ilya,
> 
> I am working on a paralel track. At Schuberg Philis we have a version that
> contains some code from 4.2 and a patch that I cannot get committed to
> master. I don't want to release this in the open, but am interested in your
> considerations on the subject.
> 
> regards,
> Daan
> 
> On Wed, Jul 31, 2013 at 5:55 PM, Musayev, Ilya 
> wrote:
> > Oops, wrong url for github, correct url is:
> >
> > http://www.guthub.com/serverchief/cloudsand
> >
> >> -Original Message-
> >> From: Musayev, Ilya [mailto:imusa...@webmd.net]
> >> Sent: Wednesday, July 31, 2013 11:52 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: [DISCUSS] Should we be releasing -beta releases?
> >>
> >> I run my own hybrid version of 4.1 and with some features of 4.2 in
> >> production, since - I needed to backport some features of 4.2 into
> >> 4.1
> >>
> >> Since this version was not officially released under ACS, I branded
> >> it as CloudSand (powered by Apache CloudStack).
> >>
> >> You can see the code here:
> >> http://www.guthub.com/serverchief.com/cloudsand | www.
> >> Cloudsand.com
> >>
> >> At some point, I would like to release a "RC/beta" of CloudSand 4.2
> >> on my own, if anyone wants to join the effort, please ping me :)
> >>
> >> Thanks
> >> Ilya
> >>
> >>
> >>
> >> > -Original Message-
> >> > From: Nux! [mailto:n...@li.nux.ro]
> >> > Sent: Thursday, June 27, 2013 8:06 AM
> >> > To: dev@cloudstack.apache.org
> >> > Subject: Re: [DISCUSS] Should we be releasing -beta releases?
> >> >
> >> > On 14.05.2013 15:41, Chip Childers wrote:
> >> > > As a way to get more user feedback on our major feature releases,
> >> > > what does everyone think about releasing one or two -beta
> >> > > releases for each major feature release?
> >> > >
> >> > > This might fall in line with some of the stated concerns about
> >> > > our release schedule (see [1]).  I've stated a desire to be
> >> > > quicker about our releases (my vote was 4 months).  I've also
> >> > > been saying quite publicly that we should never release if we
> >> > > know about upgrade issues (that's the cost of having actual users
> >> > > of our project, which I'm more than willing for us to pay).
> >> > >
> >> > > Perhaps -betaX releases would be helpful to get attention from
> >> > > the users to test the release (including upgrade paths).  The
> >> > > stated assumption could be: -beta releases are not releases that
> >> > > can be upgraded *from*, but are intended to help support testing
> >> > > by end users that want to check the upcoming release against
> >> > > their expected feature set and upgrade path.
> >> > >
> >> > > I would see the first -beta-1 being released about 1 month after
> >> > > feature freeze.  For example, for 4.2.0, it would be on 2013-06-30.
> >> > > I would only do a -beta-2 (or later) beta release if required due
> >> > > to testing results.  I would also suggest that the -beta-*
> >> > > releases would
> >> > > *not* have any particular quality criteria (well...  perhaps
> >> > > minimal, like blocking on issues that fundamentally make the
> >> > > software unstable).
> >> > >
> >> > > I'm not sure about my own proposal here, but I wanted to throw it
> >> > > out and see if any of you have feedback / thoughts.
> >> > >
> >> > > -chip
> >> > >
> >> > > [1] http://markmail.org/message/3ctdwor5hfbpa3vx
> >> >
> >> > +1 for beta releases, I was actually thinking of building some RPMS
> >> > from source, want to get a flavour of 4.2 features, but not sure if
> >> > I can be bothered with that. If I had some nightlies or betas
> >> > available on cloudstack.apt-get.eu I'd definitely give it a go.
> >> >
> >> > Lucian
> >> >
> >> > --
> >> > Sent from the Delta quadrant using Borg technology!
> >> >
> >> > Nux!
> >> > www.nux.ro
> >

RE: [Publican] What version to use?

[Musayev, Ilya]

David,

El6 is using 2.1.0, let me try out 2.8.2

Thanks
ilya


> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Wednesday, July 31, 2013 5:42 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [Publican] What version to use?
> 
> On Wed, Jul 31, 2013 at 4:43 PM, Musayev, Ilya 
> wrote:
> 
> > What version of publican do we use?
> >
> > I recently rendered all docs for ACS 4.1.1 release and notices minor
> > background inconsistencies along with many warning.
> >
> > Eventually, it all builds and very much similar to what we have
> > online, but perhaps some is different in my version that causes this
> > issue. I'm using latest publican from epel for centos6.
> >
> > Thanks
> > ilya
> >
> 
> I am using 2.8.2 - no idea what version is in el6.
> 
> --David

[ACS42][Request] CLOUDSTACK-1191

[Wido den Hollander]

Hi,

I'd like to request a cherry-pick for 
b611394cca1bfb3e655212701562ca8b24a61034 into 4.2


This RBD code should have already been in there, but I completely forgot 
to do so.


It changes code how the KVM Agent handles the RBD integration and it 
will enable snapshotting for RBD.


Some time ago I layed the groundwork for this with 
bef3a2edb7f23035a7d397d2d68caf6cecc0f497 with the intention to merge 
this code in earlier.


The problem is that without this new commit the RBD code will already in 
4.2 will become a problem since it creates RBD images in two different 
formats which will cause problems on the longer run.


This is part of CLOUDSTACK-1191

Wido

Re: Review Request 13093: Put retry logic to check existence/non-existence of created/deleted files even though vSphere returns successful completion on wait for asynchronous task.

[Venkata Siva Vijayendra Bhamidipati]

> On July 31, 2013, 1:49 a.m., Jenkins Cloudstack.org wrote:
> > Review 13093 PASSED the build test
> > The url of build cloudstack-master-with-patch #90 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/90/

When speaking with Kelven regarding a different bug, Kelven pointed out that 
waitForTask() is a cloudstack wrapper and its implementation may be causing the 
premature return of success for the API - this is more plausible since many 
places in the code are now running into this issue. Will look into this and 
reupload the patch.


- Venkata Siva Vijayendra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13093/#review24312
---


On July 31, 2013, 12:41 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13093/
> ---
> 
> (Updated July 31, 2013, 12:41 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Chip Childers, Kelven Yang, 
> and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3568
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> When a large number of VMs are created in parallel in vmware deployments, 
> vSphere can slow down and return wrong results for its APIs. For example, the 
> mgmt server correctly waits on the results of asynchronous tasks like 
> deletion/moving of VM root volume files, but vSphere is returning success for 
> those APIs even when the underlying files aren't yet removed/created from/on 
> the actual storage. So we need to work around this using retry logic. This 
> fix puts that in when creating VMs.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  112a0cb 
> 
> Diff: https://reviews.apache.org/r/13093/diff/
> 
> 
> Testing
> ---
> 
> The fix has been tested with parallel creation of ~15 VMs on vmware and the 
> described issues have not been seen. There seem to be some other exceptions 
> with some VMs, but they are not related to this code path.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: UI Plugin Feature Discussion

[SuichII, Christopher]

require.js only requires the appropriate dictionary, depending on the locale, 
so…kind of =)

I have submitted one review request for each of these features on ReviewBoard. 
Let me know if anything isn't right (this is my first time using ReviewBoard).

Chris

On Jul 31, 2013, at 6:03 PM, Jessica Wang  wrote:

> Chris,
> 
>> UI Internationalization:
>> This would allow UI Plugins to contribute their own internationalized 
>> strings to the global js dictionary. Each plugin would define a 
>> dictionary.js and several dictionary_.js files. 
> 
> So, the translation will be done on client-side?
> 
> 
>> Default value functions:
>> Currently, the default value for a UI field must be a constant. I have 
>> extended the dialog forms to allow default value functions which are given 
>> the standard 'args' allowing default values to be determined at run time.
> 
> sounds good
> 
>> has_units field:
>> I have added a new dialog field type called 'has_units'. This field has an 
>> input box side by side with a select box. The select box is populated with 
>> predefined units (MB, GB, TB, for example) and uses (also predefined) 
>> conversion functions to allow automatic updating of the input box value when 
>> the units select box is changed.
> 
> Cool
> 
> 
> Jessica
> 
> -Original Message-
> From: SuichII, Christopher [mailto:chris.su...@netapp.com] 
> Sent: Wednesday, July 31, 2013 8:27 AM
> To: 
> Subject: UI Plugin Feature Discussion
> 
> I have a couple UI Plugin related features I'm close to wrapping up and I'd 
> like to throw them out to take some feedback:
> 
> (I realize this is bad form to discuss the feature after implementation, so I 
> apologize for that. However, everything here provides an optional feature for 
> plugin developers and shouldn't pose any problem to the existing UI.)
> 
> UI Internationalization:
> This would allow UI Plugins to contribute their own internationalized strings 
> to the global js dictionary. Each plugin would define a dictionary.js and 
> several dictionary_.js files. As each plugin is loaded, the 
> appropriate plugin dictionary is loaded into the global js dictionary (with 
> the global dictionary taking precedence in the event of a conflict).
> 
> Re-usable Zone Chart:
> I have extended some functions in zoneChart.js to allow plugins to create 
> charts by simply defining their own function which assembles the chart itself 
> rather than having to define the chart in zoneChart.js
> 
> Dialog value field:
> Currently, the identifying value of json objects is assumed to be 'id' or 
> 'name' (if 'id' doesn't exist). I have added the option of allowing fields to 
> specify which json property should be the identifying value of an object.
> 
> Default value functions:
> Currently, the default value for a UI field must be a constant. I have 
> extended the dialog forms to allow default value functions which are given 
> the standard 'args' allowing default values to be determined at run time.
> 
> has_units field:
> I have added a new dialog field type called 'has_units'. This field has an 
> input box side by side with a select box. The select box is populated with 
> predefined units (MB, GB, TB, for example) and uses (also predefined) 
> conversion functions to allow automatic updating of the input box value when 
> the units select box is changed.
> 
> Please let me know what the proper course of action is from here. Should I go 
> ahead and submit diffs to reviewers or is there any discussion to be had 
> before I do that?
> 
> Thanks,
> Chris

Re: [GSoC] (Screencast/Demo) LDAP user provisioning

[Ian Duffy]

Hi Ilya,

SSL is now done. Still need to do more testing on it but it appears to
be working.

>  I want to backport this into my customized 4.1 cloudstack edition called 
> cloudsand. CloudSand is a hybrid of> CloudStack stable version with some 
> urgently needed features pulled from master to speed up cloudstack> 
> adoption by enterprises. The work you do on LDAP will be a great addition!

Cool. I didn't realise you had the project on github until I seen your
earlier emails on another subject today, love what you have done with
it. I have forked your repo and added in the features to date along
with making modifications to the code where necessary to support 4.1.1

Enjoy: https://github.com/imduffy15/cloudsand

Will send you a merge request in [a|few] week(s).

Ian

On 31 July 2013 09:49, Ian Duffy  wrote:
> Moving along faster than expected with this.
>
> The pending patches do the following:
>
>  - Disable UI password changes when LDAP is enabled.
>  - Disable API password changes when LDAP is enabled.
>  - Add support for the memberof filter.
>
> Hope to get SSL done before the week is out.
>
> On 26 July 2013 18:39, Ian Duffy  wrote:
>> Its all good :-) just don't want to make promises. Can't trust my home
>> internet at all.
>>
>> Cool will keep an eye out for it. I'd imagine it'd be fairly easy to
>> implement.
>>
>> On 26 Jul 2013 18:25, "Musayev, Ilya"  wrote:
>>>
>>> I understand, I guess do the best you can, sorry you are losing office
>>> space, if would've have been in NYC, we could have helped you with it :)
>>>
>>> I've also sent an email asking for help with scheduled tasks, perhaps
>>> someone can respond.
>>>
>>> Regards
>>> ilya
>>>
>>> > -Original Message-
>>> > From: Ian Duffy [mailto:i...@ianduffy.ie]
>>> > Sent: Friday, July 26, 2013 1:10 PM
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [GSoC] (Screencast/Demo) LDAP user provisioning
>>> >
>>> > Hi llya,
>>> >
>>> > Apologies in advanced for lack of formatting, currently replying from
>>> > mobile.
>>> >
>>> > Those UI features are present in 4.2 under LDAP configuration within
>>> > global
>>> > settings as far as I am aware. They are buggy if I remember correctly.
>>> >
>>> > For deactivating users I haven't looked into it yet and have not sent
>>> > out an
>>> > email asking for help on creating a scheduled task. It is not included
>>> > within
>>> > the project proposal so I was leaving it as a 'if I have time at the
>>> > end' type of
>>> > thing. I lose office space and a decent internet connection come august
>>> > 20th
>>> > so I'm pushing to get all proposed features done before then.
>>> >
>>> > Check out 1:25 such messages exist.
>>> >
>>> > Yes has been tested against Apache DS, openldap and active directory.
>>> > I'm a
>>> > little worried about implementing a member of filter, I've yet to figure
>>> > out
>>> > how to enable that in openldap, active directory has it by default
>>> > thankfully.
>>> > You'll need to set your LDAP attributes for active directory within
>>> > global
>>> > settings, by default they are at POSIX compliant ones... So..
>>> > User object to user username to samAccountName.
>>> > On 26 Jul 2013 17:20, "Musayev, Ilya"  wrote:
>>> >
>>> > > Ian
>>> > >
>>> > > Watched screencast and you did an amazing job! I want to backport this
>>> > > into my customized 4.1 cloudstack edition called cloudsand. CloudSand
>>> > > is a hybrid of CloudStack stable version with some urgently needed
>>> > > features pulled from master to speed up cloudstack adoption by
>>> > > enterprises. The work you do on LDAP will be a great addition!
>>> > >
>>> > > With that said, I have few questions:
>>> > >
>>> > > Back several months aqgo, I recall some work done on LDAP where a
>>> > > patch was introduced to configure LDAP through UI. Not in Global
>>> > > Settings like you did for basedn, but in separate window where you
>>> > > defined hostname and port. Would you know what happened to that?
>>> > > Where do you stand with scheduled task on checking which ldap users
>>> > > have been deactivated and deactivate them in CS as well?
>>> > > Also, it would be nice to mention "User XYZ could not be added due to
>>> > > missing email (or whatever else is missing)".
>>> > > Have you tried testing this on Windows AD, unfortunately, many
>>> > > enterprises use Microsoft Active Directory.
>>> > >
>>> > > Thank again for improving CloudStack,
>>> > >
>>> > > Regards
>>> > > -ilya
>>> > >
>>> > >
>>> > > > -Original Message-
>>> > > > From: Ian Duffy [mailto:i...@ianduffy.ie]
>>> > > > Sent: Friday, July 26, 2013 11:52 AM
>>> > > > To: Sebastien Goasguen; Abhinandan Prateek; CloudStack Dev
>>> > > > Subject: [GSoC] (Screencast/Demo) LDAP user provisioning
>>> > > >
>>> > > > Hi Guys,
>>> > > >
>>> > > > The latest patch I uploaded to review board (
>>> > > > https://reviews.apache.org/r/12969/ ) brings the "LDAP user
>>> > > provisioning"
>>> > > > project to a "prototype" stage.
>>> > > >

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

[Dave Brosius]

> On July 2, 2013, 8:50 a.m., daan Hoogland wrote:
> > Ship It!
> 
> Animesh Chaturvedi wrote:
> Has this been committed?

no


- Dave


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12185/#review22654
---


On June 29, 2013, 2:34 a.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12185/
> ---
> 
> (Updated June 29, 2013, 2:34 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code relies on classes in backport-util-concurrent, when these classes are 
> now available in the jdk supported by cloudstack.
> 
> Just switch the imports to the built in classes.
> 
> 
> Diffs
> -
> 
>   api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 
> 90759fe 
>   api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 
>   engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
>  362f7a6 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java
>  d46048e 
>   
> plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
>  0e4f8fd 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 
>   server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d 
>   server/src/com/cloud/server/ManagementServerImpl.java 40bc437 
>   tools/whisker/descriptor-for-packaging.xml 66099ae 
>   utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 
>   utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 
>   utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> cf5ffde 
> 
> Diff: https://reviews.apache.org/r/12185/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

[Dave Brosius]

> On July 2, 2013, 7:11 a.m., daan Hoogland wrote:
> > Your change seems fine.
> > 
> > Did you regression test it? Or did you solve a problem with it?

Just noticed during code inspection


- Dave


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review22650
---


On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> ---
> 
> (Updated June 29, 2013, 9:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code checks the parameter 'state' and if null, set it to Allocated, even 
> though that parameter is never accessed. Meant to set the field 'state'.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 
> 
> Diff: https://reviews.apache.org/r/12192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

Re: Review Request 12941: [GSoC] refactor gre controller

[tuna]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/
---

(Updated Aug. 1, 2013, 1:41 a.m.)


Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.


Changes
---

I made an update to refactor gre controller:

+ fix errors on preview patch
+ add OvsProvider to configPhysicalNetwork phase when deploying zone
+ remove sdn.ovs.controller to Global Setting
+ fix getLabel() //also work for multiNic servers


Repository: cloudstack-git


Description
---

I made an update to refactor gre controller:

+ remove ovs_devices table, because we'll have an ODL plugin separately.
+ move command/answer to new package: com.cloud.agent.api
+ add Connectivity service checking
+ add new NetworkProvider: Ovs
+ add L3 services to Ovs Capabilities
+ add L3 services prototype code.

Next step:
+ L3 services implement with VirtualRouter
+ ODL plugin


Diffs (updated)
-

  api/src/com/cloud/network/Network.java a06208b 
  api/src/com/cloud/network/OvsProvider.java PRE-CREATION 
  api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8 
  api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb 
  
api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java
 PRE-CREATION 
  
api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java 
PRE-CREATION 
  api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java 
PRE-CREATION 
  client/tomcatconf/applicationContext.xml.in 60f1e30 
  client/tomcatconf/commands.properties.in 6ec4d92 
  engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION 
  engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION 
  engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 30b0521 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java 
PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java 
PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
 PRE-CREATION 
  
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java 
PRE-CREATION 
  plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java 
PRE-CREATION 
  plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 
0ea6b52 
  
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
 b55fe6b 
  
plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
 bbdf110 
  
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
 b1ecaac 
  scripts/vm/hypervisor/xenserver/ovstunnel a4760b2 
  server/src/com/cloud/api/ApiResponseHelper.java 090d9c2 
  server/src/com/cloud/network/NetworkServiceImpl.java d4f9030 
  server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 
  server/src/com/cloud/server/ManagementServerImpl.java 36b3879 
  setup/db/create-schema.sql 143023a 
  setup/db/db/schema-410to420.sql b48ae6a 
  tools/apidoc/gen_toc.py 33a7e75 
  ui/scripts/zoneWizard.js e2ad910 

Diff: https://reviews.apache.org/r/12941/diff/


Testing (updated)
---

Test done with following cases:

+ choose GRE method, VLAN range when deploy advanced zone
+ create new Network Offering and choose Ovs for VirtualNetworking service, 
VirtualRouter for other services.
+ create a new Guest network using this new NetworkOffering
+ deploy VMs on this Guest network
+ stop, restart, destroy VMs
+ deploy, stop, restart, destroy VMs on two hosts.


Thanks,

tuna

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review24405
---


Review 12192 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #97 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/97/

- Jenkins Cloudstack.org


On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> ---
> 
> (Updated June 29, 2013, 9:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code checks the parameter 'state' and if null, set it to Allocated, even 
> though that parameter is never accessed. Meant to set the field 'state'.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 
> 
> Diff: https://reviews.apache.org/r/12192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

2013-08-01 Japanese CloudStack Community Weekly Update

[Kimihiko Kitase]

We started to post Japanese CloudStack Community Weekly Update. 

# # #

# New board member
Tadashi Mishima: He was the member of Open Source Conference committee. 
And now he works for cloud implementation at major SIer in Japan. He helped 
CloudStack community at LinuxCon and CloudOpen Japan and had a ZABBIX and 
CloudStack session at OSS Monitoring study group.

# Next board meeting
8/9 18:00 at Creationline

# Projects
## Globalization (L10n / i18n) (led by Chiba san and Shimazaki san)
Chiba san is mainly working for 4.2 localization

## Develop OSS Cloud Certification
LPI Japan is very positive to build new certification, OSS Cloud based 
on Apache CloudStack. LPI Japan almost agreed. Final decision will be done by 
the beginning of August.

## 4.1 / 4.2 evaluation project (led by Oge san from JCSUG))
# Project page: http://180.37.182.53/projects/cloudstack4-1-pj 
# Theme
1 : VM Snapshots, FS Investigate and add back KVM snapshot 
support
2 : Resize Data Volumes, CPU and RAM Overcommit
3 : AWS-Style Regions, S3-based secondary Storage
4 : Site-to-Site VPN 2.0
5 : IPv6 support, Add Remove Networks to VMs, Persistent 
Networks
6 : API Request Throttling
7 : Cloudstack Ceph RBD Setup
Nakajima san, Shimazaki san and Kimi worked with 
Fujitsu storage team for this validation.
8 : AutoScaling
9 : Upgrade from old version to 4.1
# Media communications / Books
# CloudStack book (from Shoueisha): Published on 2013/01/29 
Printed: 1st: 3000, 2nd: 2500
Books sold by 2013/06/04 since 2013/01/29: 3087
Electric version: http://goo.gl/xISJj 
Created CloudStack Book digest video: 
http://cloudstack.jp/cloudstack%E5%BE%B9%E5%BA%95%E5%85%A5%E9%96%80 
# Another CloudStack book covered 4.1(from Impress): 
Oge san is writing now.
# CloudStack serialization at IT Media
Creationline has posted 12 articles since 
http://www.atmarkit.co.jp/ait/kw/cloudstack_privatecloud.html since 

## Event
[7/14] July Tech Festa: JCSUG will have a session. 
http://www.techfesta.jp/ 
Koshimizu san had a session, 
http://www.slideshare.net/samemoon/20130714julytechfesta. She has selected best 
speaker in this events.
[8/2] 13th Japan CloudStack User Group Meeting in Osaka: 
http://atnd.org/events/40712 
1. CCC13 report
2. Snapshot deep dive
3. Autoscale deep dive
4. CloudStack + Ceph/RBD
5. Other 4.1 new feature deep dive
6. CloudStack LXC
7. CloudStack + Scalr / CloudStack API
8. CloudStack + Nicira
9. KDDI session TBD
[8/2, 3] OSC Kyoto: JCSUG will have a session and booth. 
http://www.ospn.jp/osc2013-kyoto/ Created new banner and flyer.
[8/E] 14th Japan CloudStack User Group Meeting in Tokoyo: Under 
consideration.
[9/3] Cloud Show Japan: JCSUG will have a session. http://cloudshow.jp/
[9/14] OSC Hokkaido: JCSUG will have a session and booth.
[10/19, 20]: OSC Tokyo: JCSUG will have a session and booth.
[11/16] OSC Fukuoka: JCSUG may have a session and booth.
[2014/2/E] CloudStack Day: JCSUG started to consider CloudStack 1 day 
event on Feb, 2014. Not decided yet.

If you have any comment, please let ad...@cloudstack.jp know.

Thanks,
JCSUG (Japan CloudStack User Group)

Web: http://cloudstack.jp
Ustream http://www.ustream.tv/channel/cloudstackja
YouTube: http://www.youtube.com/channel/UCB_l4yMR2rE6VWa_H-THPWQ
Twitter: @cloudstackja
Facebook: https://www.facebook.com/cloudstackjapan
Admin ML: ad...@cloudstack.jp
User ML: us...@cloudstack.jp

RE: [GSoC] (Screencast/Demo) LDAP user provisioning

[Musayev, Ilya]

Ian,

Much appreciated,

Can't wait to put this into real world QA :)

Thanks
ilya

> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Wednesday, July 31, 2013 8:58 PM
> To: Musayev, Ilya
> Cc: dev@cloudstack.apache.org
> Subject: Re: [GSoC] (Screencast/Demo) LDAP user provisioning
> 
> Hi Ilya,
> 
> SSL is now done. Still need to do more testing on it but it appears to be
> working.
> 
> >  I want to backport this into my customized 4.1 cloudstack edition called
> cloudsand. CloudSand is a hybrid of> CloudStack stable version with some
> urgently needed features pulled from master to speed up cloudstack>
> adoption by enterprises. The work you do on LDAP will be a great addition!
> 
> Cool. I didn't realise you had the project on github until I seen your earlier
> emails on another subject today, love what you have done with it. I have
> forked your repo and added in the features to date along with making
> modifications to the code where necessary to support 4.1.1
> 
> Enjoy: https://github.com/imduffy15/cloudsand
> 
> Will send you a merge request in [a|few] week(s).
> 
> Ian
> 
> On 31 July 2013 09:49, Ian Duffy  wrote:
> > Moving along faster than expected with this.
> >
> > The pending patches do the following:
> >
> >  - Disable UI password changes when LDAP is enabled.
> >  - Disable API password changes when LDAP is enabled.
> >  - Add support for the memberof filter.
> >
> > Hope to get SSL done before the week is out.
> >
> > On 26 July 2013 18:39, Ian Duffy  wrote:
> >> Its all good :-) just don't want to make promises. Can't trust my
> >> home internet at all.
> >>
> >> Cool will keep an eye out for it. I'd imagine it'd be fairly easy to
> >> implement.
> >>
> >> On 26 Jul 2013 18:25, "Musayev, Ilya"  wrote:
> >>>
> >>> I understand, I guess do the best you can, sorry you are losing
> >>> office space, if would've have been in NYC, we could have helped you
> >>> with it :)
> >>>
> >>> I've also sent an email asking for help with scheduled tasks,
> >>> perhaps someone can respond.
> >>>
> >>> Regards
> >>> ilya
> >>>
> >>> > -Original Message-
> >>> > From: Ian Duffy [mailto:i...@ianduffy.ie]
> >>> > Sent: Friday, July 26, 2013 1:10 PM
> >>> > To: dev@cloudstack.apache.org
> >>> > Subject: RE: [GSoC] (Screencast/Demo) LDAP user provisioning
> >>> >
> >>> > Hi llya,
> >>> >
> >>> > Apologies in advanced for lack of formatting, currently replying
> >>> > from mobile.
> >>> >
> >>> > Those UI features are present in 4.2 under LDAP configuration
> >>> > within global settings as far as I am aware. They are buggy if I
> >>> > remember correctly.
> >>> >
> >>> > For deactivating users I haven't looked into it yet and have not
> >>> > sent out an email asking for help on creating a scheduled task. It
> >>> > is not included within the project proposal so I was leaving it as
> >>> > a 'if I have time at the end' type of thing. I lose office space
> >>> > and a decent internet connection come august 20th so I'm pushing
> >>> > to get all proposed features done before then.
> >>> >
> >>> > Check out 1:25 such messages exist.
> >>> >
> >>> > Yes has been tested against Apache DS, openldap and active directory.
> >>> > I'm a
> >>> > little worried about implementing a member of filter, I've yet to
> >>> > figure out how to enable that in openldap, active directory has it
> >>> > by default thankfully.
> >>> > You'll need to set your LDAP attributes for active directory
> >>> > within global settings, by default they are at POSIX compliant
> >>> > ones... So..
> >>> > User object to user username to samAccountName.
> >>> > On 26 Jul 2013 17:20, "Musayev, Ilya"  wrote:
> >>> >
> >>> > > Ian
> >>> > >
> >>> > > Watched screencast and you did an amazing job! I want to
> >>> > > backport this into my customized 4.1 cloudstack edition called
> >>> > > cloudsand. CloudSand is a hybrid of CloudStack stable version
> >>> > > with some urgently needed features pulled from master to speed
> >>> > > up cloudstack adoption by enterprises. The work you do on LDAP will
> be a great addition!
> >>> > >
> >>> > > With that said, I have few questions:
> >>> > >
> >>> > > Back several months aqgo, I recall some work done on LDAP where
> >>> > > a patch was introduced to configure LDAP through UI. Not in
> >>> > > Global Settings like you did for basedn, but in separate window
> >>> > > where you defined hostname and port. Would you know what
> happened to that?
> >>> > > Where do you stand with scheduled task on checking which ldap
> >>> > > users have been deactivated and deactivate them in CS as well?
> >>> > > Also, it would be nice to mention "User XYZ could not be added
> >>> > > due to missing email (or whatever else is missing)".
> >>> > > Have you tried testing this on Windows AD, unfortunately, many
> >>> > > enterprises use Microsoft Active Directory.
> >>> > >
> >>> > > Thank again for improving CloudStack,
> >>> > >
> >>> > > Regards
> >>> > > -ilya
> >>> > >
> >>

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12185/#review24407
---


Review 12185 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #98 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/98/

- Jenkins Cloudstack.org


On June 29, 2013, 2:34 a.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12185/
> ---
> 
> (Updated June 29, 2013, 2:34 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code relies on classes in backport-util-concurrent, when these classes are 
> now available in the jdk supported by cloudstack.
> 
> Just switch the imports to the built in classes.
> 
> 
> Diffs
> -
> 
>   api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 
> 90759fe 
>   api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 
>   engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
>  362f7a6 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java
>  d46048e 
>   
> plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
>  0e4f8fd 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 
>   server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d 
>   server/src/com/cloud/server/ManagementServerImpl.java 40bc437 
>   tools/whisker/descriptor-for-packaging.xml 66099ae 
>   utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 
>   utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 
>   utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> cf5ffde 
> 
> Diff: https://reviews.apache.org/r/12185/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

RE: [ACS42][Request] CLOUDSTACK-1191

[Animesh Chaturvedi]

> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Wednesday, July 31, 2013 4:23 PM
> To: dev@cloudstack.apache.org
> Subject: [ACS42][Request] CLOUDSTACK-1191
> 
> Hi,
> 
> I'd like to request a cherry-pick for
> b611394cca1bfb3e655212701562ca8b24a61034 into 4.2
> 
> This RBD code should have already been in there, but I completely forgot
> to do so.
> 
[Animesh>] Wido thanks for bringing it to the list. You are a committer and 
until the RC date you can check-in blocker and critical issues. If this fix is 
critical for RBD support in 4.2 you can check it in. Let's just wait to see if 
there are any objections.

> It changes code how the KVM Agent handles the RBD integration and it
> will enable snapshotting for RBD.
> 
> Some time ago I layed the groundwork for this with
> bef3a2edb7f23035a7d397d2d68caf6cecc0f497 with the intention to merge
> this code in earlier.
> 
> The problem is that without this new commit the RBD code will already in
> 4.2 will become a problem since it creates RBD images in two different
> formats which will cause problems on the longer run.
> 
> This is part of CLOUDSTACK-1191
> 
> Wido

Re: Review Request 12934: Tests for egress firewall rules for advance zone

[Ashutosh Kelkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/
---

(Updated Aug. 1, 2013, 6:19 a.m.)


Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
Santhanam.


Changes
---

As per discussion with Jaypal on GTM added following Tests.
1) Tests to cover egress_policy = true/false
2) Skipping tests for egress_policy = true. We can relabel these test once we 
get confirmed response from QA and Jayapal.


Repository: cloudstack-git


Description
---

Tests for egress firewall rules for advance zone.


Diffs (updated)
-

  test/integration/component/test_egress_fw_rules.py PRE-CREATION 

Diff: https://reviews.apache.org/r/12934/diff/


Testing
---


Thanks,

Ashutosh Kelkar

Re: Review Request 12934: Tests for egress firewall rules for advance zone

[Ashutosh Kelkar]

> On July 29, 2013, 12:32 p.m., Jayapal Reddy wrote:
> > test/integration/component/test_egress_fw_rules.py, line 374
> > 
> >
> > I think you are not clear with the default egress policy. 
> > 
> >  - egress policy true
> >All the guest network traffic to public n/w is allowed by default. 
> > Adding egress rule blocks only the rule specific traffic.
> >
> > -egress policy false
> > By default guest network traffic to public n/w is block. if you add 
> > egress rule  then only egress rule specific traffic is allowed.
> > 
> > When egress policy is true, by default the guest network traffic is 
> > allow.
> > 
> > public network should be reachable

As per your last email, and discussion over GTM. I have put in the tests for 
egress_policy = true. Currently all those tests are skipped from test run.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24101
---


On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> ---
> 
> (Updated Aug. 1, 2013, 6:19 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
> Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13188/
---

Review request for cloudstack and Nitin Mehta.


Bugs: CLOUDSTACK-3042


Repository: cloudstack-git


Description
---

CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
presence of tools in the template


Diffs
-

  server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
3ee8a1c 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
6859b0b 

Diff: https://reviews.apache.org/r/13188/diff/


Testing
---

Tested locally


Thanks,

Harikrishna Patnala

Re: Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13188/#review24418
---

Ship it!



server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java


Ideally we should make it part of the constructor. 


- Nitin Mehta


On Aug. 1, 2013, 6:35 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13188/
> ---
> 
> (Updated Aug. 1, 2013, 6:35 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3042
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
> presence of tools in the template
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 3ee8a1c 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 6859b0b 
> 
> Diff: https://reviews.apache.org/r/13188/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13188/#review24420
---


Commit 381318928348289f5dacd9d482302a9be561f6bd in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3813189 ]

CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
presence of tools in the template
Signed off by : Nitin Mehta


- ASF Subversion and Git Services


On Aug. 1, 2013, 6:35 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13188/
> ---
> 
> (Updated Aug. 1, 2013, 6:35 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3042
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
> presence of tools in the template
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 3ee8a1c 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 6859b0b 
> 
> Diff: https://reviews.apache.org/r/13188/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

[Nitin Mehta]

> On Aug. 1, 2013, 6:42 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java, 
> > line 581
> > 
> >
> > Ideally we should make it part of the constructor.

On master you need to resolve the conflicts

# On branch master
# Changes to be committed:
#
#   modified:   
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
#
# Unmerged paths:
#   (use "git add/rm ..." as appropriate to mark resolution)
#
#   both modified:  
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
#   both modified:  
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
#
Nitins-MacBook-Air:cloudstack nitinmehta$ 
Nitins-MacBook-Air:cloudstack nitinmehta$ git reset --hard
HEAD is now at 8672e0f - CLOUDSTACK-3229: Removes String format method call 
that is not
Nitins-MacBook-Air:cloudstack nitinmehta$ git status
# On branch master
nothing to commit (working directory clean)
Nitins-MacBook-Air:cloudstack nitinmehta$ git cherry-pick 
381318928348289f5dacd9d482302a9be561f6bd
error: could not apply 3813189... CLOUDSTACK-3042: handle System VM Scaling up 
of memory/CPU based on the presence of tools in the template
hint: after resolving the conflicts, mark the corrected paths


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13188/#review24418
---


On Aug. 1, 2013, 6:35 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13188/
> ---
> 
> (Updated Aug. 1, 2013, 6:35 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3042
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
> presence of tools in the template
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 3ee8a1c 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 6859b0b 
> 
> Diff: https://reviews.apache.org/r/13188/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13188/#review24422
---


Commit f12adfff8a7b51c53466ab556d5efe2c1961fe3e in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f12adff ]

CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
presence of tools in the template
Signed off by : Nitin Mehta


- ASF Subversion and Git Services


On Aug. 1, 2013, 6:35 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13188/
> ---
> 
> (Updated Aug. 1, 2013, 6:35 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3042
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the 
> presence of tools in the template
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 3ee8a1c 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 6859b0b 
> 
> Diff: https://reviews.apache.org/r/13188/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>