Create Affinity Group API

[Girish Shilamkar]

Hello,

While testing Affinity Groups feature I found that createAffinityGroups API 
does not return "id" in response. 

2013-07-29 12:17:16,641 INFO  [cloud.api.ApiServer] (catalina-exec-24:null) 
(userId=2 accountId=2 sessionId=72E8E1EE5D2EC61E90BE7F944D3EA4FC) 
192.168.100.53 -- GET 
command=createAffinityGroup&response=json&sessionkey=Hdq5ogh%2Fc2A5PXXrJDNd2SkwBvU%3D&name=Test_g&type=host+anti-affinity&_=1375080436560
 200 { "createaffinitygroupresponse" : 
{"id":"366e51ce-ce6d-41d9-9ea1-dfd932962bdc","jobid":"fba998cc-9285-421b-9a57-8fd3f9fae7a4"}
 }
2013-07-29 12:17:19,668 INFO  [cloud.api.ApiServer] (catalina-exec-21:null) 
(userId=2 accountId=2 sessionId=72E8E1EE5D2EC61E90BE7F944D3EA4FC) 
192.168.100.53 -- GET 
command=queryAsyncJobResult&jobId=fba998cc-9285-421b-9a57-8fd3f9fae7a4&response=json&sessionkey=Hdq5ogh%2Fc2A5PXXrJDNd2SkwBvU%3D&_=1375080439598
 200 { "queryasyncjobresultresponse" : 
{"accountid":"4bc23192-f4f5-11e2-bf57-005056860002","userid":"4bc28d0e-f4f5-11e2-bf57-005056860002","cmd":"org.apache.cloudstack.api.command.user.affinitygroup.CreateAffinityGroupCmd","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"affinitygroup":{"name":"Test_g","account":"admin","domainid":"3d051818-f4f5-11e2-bf57-005056860002","domain":"ROOT","type":"host
 
anti-affinity"}},"created":"2013-07-29T12:17:16+0530","jobid":"fba998cc-9285-421b-9a57-8fd3f9fae7a4"}
 }

I have filed a defect for it.  
https://issues.apache.org/jira/browse/CLOUDSTACK-3889

Regards,
Girish

Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/#review24093
---


Review 13009 PASSED the build test
The url of build cloudstack-master-with-patch #66 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/66/

- Jenkins Cloudstack.org


On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13009/
> ---
> 
> (Updated July 29, 2013, 4:12 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3744
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_netscaler_nw_off.py 5fd2195 
> 
> Diff: https://reviews.apache.org/r/13009/diff/
> 
> 
> Testing
> ---
> 
> Tested locally. Script is now passing and cleanup of all accounts done.
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: Apache MESOS and CloudStack

[Sebastien Goasguen]

On Jul 26, 2013, at 5:23 PM, Kelcey Jamison Damage  wrote:

> Hi,
> 
> Is there anyone running MESOS on a pool of CloudStack guests?
> 
> This is something I am interested in, and am wondering if anyone is doing it?
> 
> Thanks
> 
> -Kelcey

Kelcey, technically we have a GSoC project on this, but there has been no 
progress.

-sebastien

Re: Review Request 12991: GSOC2013 meng midterm report

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12991/#review24094
---


Meng, can you send the patch to me via email directly. Review board is messing 
up the patch

thanks

- Sebastien Goasguen


On July 27, 2013, 1:37 a.m., meng han wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12991/
> ---
> 
> (Updated July 27, 2013, 1:37 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is meng's midterm report for GSOC 2013!
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-meng.xml 1ab07cb 
>   docs/en-US/images/clusterDefinition.png PRE-CREATION 
>   docs/en-US/images/launchHadoopClusterApi.png PRE-CREATION 
>   docs/en-US/images/launchHadoopClusterCmd.png PRE-CREATION 
>   docs/en-US/images/whirrDependency.png PRE-CREATION 
>   docs/en-US/images/whirrOutput.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12991/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> meng han
> 
>

Re: Review Request 12995: [GSoC] Add midterm report to docs

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12995/#review24095
---


Shiva, send me the patch via email directly. Review board is munching it

thanks

- Sebastien Goasguen


On July 27, 2013, 1:11 p.m., Shiva Teja Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12995/
> ---
> 
> (Updated July 27, 2013, 1:11 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> GSoC - Add midterm review
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-shiva.xml 67755c4 
>   docs/en-US/images/add-account-screen.png PRE-CREATION 
>   docs/en-US/images/async-calls.png PRE-CREATION 
>   docs/en-US/images/configuration-edit-success.png PRE-CREATION 
>   docs/en-US/images/configurations-screen.png PRE-CREATION 
>   docs/en-US/images/create-account-post.png PRE-CREATION 
>   docs/en-US/images/create-account-request.png PRE-CREATION 
>   docs/en-US/images/edit-configuration.png PRE-CREATION 
>   docs/en-US/images/instances-screen.png PRE-CREATION 
>   docs/en-US/images/list-domain-vms.png PRE-CREATION 
>   docs/en-US/images/list-specific-vm.png PRE-CREATION 
>   docs/en-US/images/list-virtualmachines.png PRE-CREATION 
>   docs/en-US/images/start-vm-screen.png PRE-CREATION 
>   docs/en-US/images/vm-running.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12995/diff/
> 
> 
> Testing
> ---
> 
> Build was successful with publican
> 
> 
> Thanks,
> 
> Shiva Teja Reddy
> 
>

Re: [DISCUSS] vlan uri format change

[Wei ZHOU]

Daan,

Please review patch: https://reviews.apache.org/r/13004/
Thanks. I can not add you as a reviewer.

-Wei


2013/7/27 Daan Hoogland 

> The original patch was committed under Alex' account. Work on the networks
> enums is far from done with https://reviews.apache.org/r/12849/. I
> commented on the one you are mentioning, Prasanna.
>
> regards,
> Daan
>
> On Sat, Jul 27, 2013 at 12:41 PM, Koushik Das 
> wrote:
> > I raised this in a separate thread. Daan created a new patch
> https://reviews.apache.org/r/12849/ to address backward compat.
> >
> >> -Original Message-
> >> From: Prasanna Santhanam [mailto:t...@apache.org]
> >> Sent: Saturday, July 27, 2013 11:12 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: [DISCUSS] vlan uri format change
> >>
> >> Daan,
> >>
> >> This broke the KVM setups last week on master. I couldn't find your
> commit-
> >> id for this change scanning the git logs. Toshiaki-san was looking at
> >> CLOUDSTACK-3682 regarding this change [1] where he makes the scheme
> >> backwards compatible to work with KVM agents of the past.
> >> Could you please have a look at the changeset?
> >>
> >> [1] https://reviews.apache.org/r/12985/
> >>
> >> On Mon, Jul 01, 2013 at 10:28:57AM +0200, Daan Hoogland wrote:
> >> > The gain is that enums like BroadcastDomainType and IsolationType do
> >> > not have to check for different formats in the presented uri. It also
> >> > makes it more intiutive what the parts in the uri mean; vlan://
> >> > would inmply that id is a hostname instead of a scheme specific
> identifier.
> >> >
> >> > I think I am reducing complexity, not introducing any. The present use
> >> > of uri for vlans is abuse of the construct, i don't think my proposed
> >> > new use is.
> >> >
> >> >
> >> > On Mon, Jul 1, 2013 at 10:17 AM, Hiroaki KAWAI
> >> wrote:
> >> >
> >> > > Daan, I'm curious about what is the improvement of changing the vlan
> >> > > String format in URI?
> >> > >
> >> > > I'm -1 on pushing more complexity in URI, because that's abuse of
> >> > > URI class and sounds it's time to get rid of URI.
> >> > >
> >> > >
> >> > >
> >> > > (2013/07/01 16:47), Daan Hoogland wrote:
> >> > >
> >> > >> H,
> >> > >>
> >> > >> I've been trying to get a patch accepted and had some discussions
> >> > >> to do it in parts as well. I would like to refresh the first part:
> >> > >>
> >> > >> vlans are now referred as vlan://. I would like to change this
> >> > >> to vlan:. This will changee addressing the id as a scheme
> >> > >> specific part instead of as a host. As a result it will be easier
> >> > >> to fix the code to use Nicira NVP and other sdn networks whereever
> >> > >> vlans are used now. Doing this will result in a patch that is a
> >> > >> subset of my earlier patch. It touches a lot of core code and tests
> >> > >> but has been tested  thoroughly for VPC gateways with both vlans
> >> > >> and Nicira NVP.
> >> > >>
> >> > >> regards,
> >> > >> Daan
> >> > >>
> >> > >>
> >> > >
> >>
> >> --
> >> Prasanna.,
> >>
> >> 
> >> Powered by BigRock.com
> >
>

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

[Wei Zhou]

> On July 28, 2013, 12:46 p.m., Jenkins Cloudstack.org wrote:
> > Review 13004 PASSED the build test
> > The url of build cloudstack-master-with-patch #64 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/64/

Jijun,

Could you add dahn(Daan Hoogland) as a reviewer?


- Wei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13004/#review24059
---


On July 28, 2013, 11:49 a.m., Jijun wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13004/
> ---
> 
> (Updated July 28, 2013, 11:49 a.m.)
> 
> 
> Review request for cloudstack, edison su and Wei Zhou.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>  In lastest CS 4.2 code, I  create advance zone  with hypervisor vmware esxi,
> create public Network with vlan id 509 specified and  label vSwitch0, when cs 
> create systemvm(cpvm,ssvm),
> a new portgroup with  name  cloud.public.untagged.0.1-vSwitch0 was created, 
> not a portgroup cloud.public.509.0.1-vSwitch0 as expected. 
> in database table nics, the field broadcast_uri for new systemvm  is vlan:509 
>  , and should be vlan://509
> debug the code and found it is a syntax error in Networks.java for new 
> instance java.net.URI.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
> 
> Diff: https://reviews.apache.org/r/13004/diff/
> 
> 
> Testing
> ---
> 
> recreate the system vm or create a new advance zone , public network with vlan
> 
> 
> Thanks,
> 
> Jijun
> 
>

Re: Review Request 13010: rb-jenkins-integration test patch

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13010/#review24097
---


Review 13010 PASSED the build test
The url of build cloudstack-master-with-patch #67 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/67/

- Jenkins Cloudstack.org


On July 29, 2013, 6:34 a.m., Prasanna Santhanam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13010/
> ---
> 
> (Updated July 29, 2013, 6:34 a.m.)
> 
> 
> Review request for cloudstack, Hugo Trippaers and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Test patch request for rb-jenkins integration. Do not merge
> 
> https://github.com/CloudStack-extras/reviewboard-tools/issues/2
> 
> 
> Diffs
> -
> 
>   INSTALL.md b0e1a761 
> 
> Diff: https://reviews.apache.org/r/13010/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Prasanna Santhanam
> 
>

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13004/#review24098
---


Jijun, please make sure your adjusted call to URI() only gets called when 
BroadcastDomainType is Vlan, Storage or Mido and not when it is for instance 
Lswitch.

- daan Hoogland


On July 28, 2013, 11:49 a.m., Jijun wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13004/
> ---
> 
> (Updated July 28, 2013, 11:49 a.m.)
> 
> 
> Review request for cloudstack, edison su and Wei Zhou.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>  In lastest CS 4.2 code, I  create advance zone  with hypervisor vmware esxi,
> create public Network with vlan id 509 specified and  label vSwitch0, when cs 
> create systemvm(cpvm,ssvm),
> a new portgroup with  name  cloud.public.untagged.0.1-vSwitch0 was created, 
> not a portgroup cloud.public.509.0.1-vSwitch0 as expected. 
> in database table nics, the field broadcast_uri for new systemvm  is vlan:509 
>  , and should be vlan://509
> debug the code and found it is a syntax error in Networks.java for new 
> instance java.net.URI.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
> 
> Diff: https://reviews.apache.org/r/13004/diff/
> 
> 
> Testing
> ---
> 
> recreate the system vm or create a new advance zone , public network with vlan
> 
> 
> Thanks,
> 
> Jijun
> 
>

[GSoC] Unable create systemvm

[Nguyen Anh Tu]

Hi guys,

I re-deploy ACS (sdnextensions branch, same same with 4.1 I think) with XCP
1.6 and get an error on create systemvm. I also re-copy vhd-util to Host
(/opt/xensource/bin/) but still error. Log here:

INFO  [cloud.secstorage.PremiumSecondaryStorageManagerImpl] (secstorage-1:)
No running secondary storage vms found in datacenter id=1, starting one
INFO  [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) No
stopped secondary storage vm is available, need to allocate a new secondary
storage vm
INFO  [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) No
stopped console proxy is available, need to allocate a new console proxy
WARN  [xen.resource.CitrixResourceBase] (DirectAgent-8:) kill_copy_process
failed
WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) can not
create vdi in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) Catch
Exception com.cloud.utils.exception.CloudRuntimeException for template +
 due to com.cloud.utils.exception.CloudRuntimeException: can not create vdi
in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
1e7b078a-322e-8d95-f712-eed1dc824aa8
at
com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:792)
at
com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:863)
at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:70)
at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:49)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:625)
at
com.cloud.hypervisor.xen.resource.XcpServerResource.executeRequest(XcpServerResource.java:53)
at
com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:722)
INFO  [cloud.vm.VirtualMachineManagerImpl] (secstorage-1:) Unable to
contact resource.
com.cloud.exception.StorageUnavailableException: Resource [StoragePool:1]
is unreachable: Unable to create Vol[3|vm=3|ROOT]:Catch Exception
com.cloud.utils.exception.CloudRuntimeException for template +  due to
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
1e7b078a-322e-8d95-f712-eed1dc824aa8
at
com.cloud.storage.VolumeManagerImpl.recreateVolume(VolumeManagerImpl.java:2490)
at com.cloud.storage.VolumeManagerImpl.prepare(VolumeManagerImpl.java:2539)
at
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:852)
at
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:557)
at
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:550)
at
com.cloud.storage.secondary.SecondaryStorageManagerImpl.startSecStorageVm(SecondaryStorageManagerImpl.java:265)
at
com.cloud.storage.secondary.SecondaryStorageManagerImpl.allocCapacity(SecondaryStorageManagerImpl.java:690)
at
com.cloud.storage.secondary.SecondaryStorageManagerImpl.expandPool(SecondaryStorageManagerImpl.java:1297)
at
com.cloud.secstorage.PremiumSecondaryStorageManagerImpl.scanPool(PremiumSecondaryStorageManagerImpl.java:123)
at
com.cloud.secstorage.PremiumSecondaryStorageManagerImpl.scanPool(PremiumSecondaryStorageManagerImpl.java:50)
at com.cloud.vm.SystemVmLoadScanner.loadScan(SystemVmLoadScanner.java:104)
at com.cloud.vm.SystemVmLoadScanner.access$100(SystemVmLoadScanner.java:33)
at com.cloud.vm.SystemVmLoadScanner$1.reallyRun(SystemVmLoadScanner.java:81)
at com.cloud.vm.SystemVmLoadScanner$1.run(SystemVmLoadScanner.java:72)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.T

Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review24099
---


Commit 2b42a271771860add43705bb64c2296179091455 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2b42a27 ]

CLOUDSTACK-3669:  Bringing down the dynamic scalable check (for VM whether it 
has xstools or vmware tools in it) to the management layer.


- ASF Subversion and Git Services


On July 29, 2013, 6:38 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> ---
> 
> (Updated July 29, 2013, 6:38 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3669
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3669:  Bringing down the dynamic scalable check (for VM whether it 
> has xstools or vmware tools in it) to the management layer. 
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  7173f0b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 34f3de2 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd 
> 
> Diff: https://reviews.apache.org/r/12759/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12941: [GSoC] refactor gre controller

[Nguyen Anh Tu]

Hi,

Following Hugo's review, I already changed and created an updated patch.
Now I'm re-deploying system for final-testing before submitting the update
patch. But getting an error on creating systemvm. Let me fix them first,
make final-test and then submit the updated patch.

Cheers,


2013/7/26 Nguyen Anh Tu 

> Hi Hugo,
>
> I saw your review. But I have to concentrate to finish my report today.
> Will comeback to review tomorrow :-)
>
>
> 2013/7/25 Jenkins Cloudstack.org 
>
>This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/12941/
>>
>> Review 12941 failed the build test : FAILURE
>> The url of build cloudstack-master-with-patch #37 is : 
>> http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
>>
>>
>> - Jenkins Cloudstack.org
>>
>> On July 25th, 2013, 9:05 a.m. UTC, tuna wrote:
>>   Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>> By tuna.
>>
>> *Updated July 25, 2013, 9:05 a.m.*
>>  *Repository: * cloudstack-git
>> Description
>>
>> I made an update to refactor gre controller:
>>
>> + remove ovs_devices table, because we'll have an ODL plugin separately.
>> + move command/answer to new package: com.cloud.agent.api
>> + add Connectivity service checking
>> + add new NetworkProvider: Ovs
>> + add L3 services to Ovs Capabilities
>> + add L3 services prototype code.
>>
>> Next step:
>> + L3 services implement with VirtualRouter
>> + ODL plugin
>>
>>   Diffs
>>
>>- api/src/com/cloud/network/Network.java (a06208b)
>>- client/tomcatconf/applicationContext.xml.in (60f1e30)
>>- 
>> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>>(30b0521)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java
>>(PRE-CREATION)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java
>>(c0901b2)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java
>>(1abc324)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java
>>(87eedfb)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java
>>(2adb33a)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
>>(0ea6b52)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
>>(b55fe6b)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
>>(bbdf110)
>>- plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java
>>(b533312)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java
>>(20603e0)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java
>>(5f0f8c1)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java
>>(e2cd2d8)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java
>>(fc2eb8a)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java
>>(1ececa0)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java
>>(2a6d5d7)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java
>>(8be5586)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java
>>(4594d99)
>>- 
>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchIn

Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24100
---


Commit 4d35d92208c9b63ca27c794508d4c534fa773078 in branch refs/heads/4.2 from 
Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d35d92 ]

CLOUDSTACK-3779: Support System vm scaling on VMWare

Marked the system template new system template as dynamicallyScalable
   - handled upgrade case
   - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details 
to support dynamic scaling of system vm
Signed off by : Nitin Mehta


- ASF Subversion and Git Services


On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> ---
> 
> (Updated July 26, 2013, 8:41 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3779: Support System vm scaling on VMWare
> 
> Marked the system template new system template as dynamicallyScalable
>- handled upgrade case
>- moved "dynamicallyScalable" flag to vm_instance table from 
> user_vm_details to support dynamic scaling of system vm
> 
> This patch depends on previous review request 
> https://reviews.apache.org/r/12759/ . please review and commit accordingly
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 
>   engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  2cc592d 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd 
>   server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 
>   server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d 
>   setup/db/db/schema-410to420.sql 82ca403 
> 
> Diff: https://reviews.apache.org/r/12937/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up

[Sowmya Krishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/
---

(Updated July 29, 2013, 9:31 a.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
---

Offering cleanup removed


Bugs: CLOUDSTACK-3744


Repository: cloudstack-git


Description
---

Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.


Diffs (updated)
-

  test/integration/component/test_netscaler_nw_off.py 5fd2195 

Diff: https://reviews.apache.org/r/13009/diff/


Testing
---

Tested locally. Script is now passing and cleanup of all accounts done.


Thanks,

Sowmya Krishnan

Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review24103
---


Commit 8ef097ef6e73134c09b05c967ece6b795d857581 in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ef097e ]

CLOUDSTACK-3669:  Bringing down the dynamic scalable check (for VM whether it 
has xstools or vmware tools in it) to the management layer.
Signed off by : Nitin Mehta 


- ASF Subversion and Git Services


On July 29, 2013, 6:38 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> ---
> 
> (Updated July 29, 2013, 6:38 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3669
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3669:  Bringing down the dynamic scalable check (for VM whether it 
> has xstools or vmware tools in it) to the management layer. 
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  7173f0b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 34f3de2 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd 
> 
> Diff: https://reviews.apache.org/r/12759/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12937/#review24104
---


Commit 2f369973e22441dbebabf8d0683ddec866bef72f in branch refs/heads/master 
from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f36997 ]

CLOUDSTACK-3779: Support System vm scaling on VMWare

Marked the system template new system template as dynamicallyScalable
   - handled upgrade case
   - moved "dynamicallyScalable" flag to vm_instance table from user_vm_details 
to support dynamic scaling of system vm
Signed off by : Nitin Mehta


- ASF Subversion and Git Services


On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12937/
> ---
> 
> (Updated July 26, 2013, 8:41 a.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3779: Support System vm scaling on VMWare
> 
> Marked the system template new system template as dynamicallyScalable
>- handled upgrade case
>- moved "dynamicallyScalable" flag to vm_instance table from 
> user_vm_details to support dynamic scaling of system vm
> 
> This patch depends on previous review request 
> https://reviews.apache.org/r/12759/ . please review and commit accordingly
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 
>   engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  2cc592d 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd 
>   server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 
>   server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d 
>   setup/db/db/schema-410to420.sql 82ca403 
> 
> Diff: https://reviews.apache.org/r/12937/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: [GSoC] Unable create systemvm

[Nguyen Anh Tu]

I debug and get error starting from here:

protected void createBaseImageAsync(VolumeInfo volume, PrimaryDataStore
dataStore, TemplateInfo template,
AsyncCallFuture future) {
...
*motionSrv.copyAsync(template, templateOnPrimaryStoreObj, caller);*
...
}


Exeption here:

WARN  [xen.resource.CitrixResourceBase] (DirectAgent-37:) kill_copy_process
failed
WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-37:) can not
create vdi in sr a36311b4-ff2c-141a-4191-047c9c3a2c48
WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-37:) Catch
Exception com.cloud.utils.exception.CloudRuntimeException for template +
 due to com.cloud.utils.exception.CloudRuntimeException: can not create vdi
in sr a36311b4-ff2c-141a-4191-047c9c3a2c48
com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
a36311b4-ff2c-141a-4191-047c9c3a2c48
at
com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:792)
at
com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:863)
at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:70)
at
com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:49)
at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:625)
at
com.cloud.hypervisor.xen.resource.XcpServerResource.executeRequest(XcpServerResource.java:53)
at
com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:722)

Any idea?


2013/7/29 Nguyen Anh Tu 

> Hi guys,
>
> I re-deploy ACS (sdnextensions branch, same same with 4.1 I think) with
> XCP 1.6 and get an error on create systemvm. I also re-copy vhd-util to
> Host (/opt/xensource/bin/) but still error. Log here:
>
> INFO  [cloud.secstorage.PremiumSecondaryStorageManagerImpl]
> (secstorage-1:) No running secondary storage vms found in datacenter id=1,
> starting one
> INFO  [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) No
> stopped secondary storage vm is available, need to allocate a new secondary
> storage vm
> INFO  [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) No
> stopped console proxy is available, need to allocate a new console proxy
> WARN  [xen.resource.CitrixResourceBase] (DirectAgent-8:) kill_copy_process
> failed
> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) can not
> create vdi in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) Catch
> Exception com.cloud.utils.exception.CloudRuntimeException for template +
>  due to com.cloud.utils.exception.CloudRuntimeException: can not create vdi
> in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
> com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
> 1e7b078a-322e-8d95-f712-eed1dc824aa8
> at
> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:792)
>  at
> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:863)
> at
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:70)
>  at
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:49)
> at
> com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:625)
>  at
> com.cloud.hypervisor.xen.resource.XcpServerResource.executeRequest(XcpServerResource.java:53)
> at
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
>  at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>  at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
>  at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>  at

Re: Review Request 12969: Complete LDAP user provisioning UI.

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12969/#review24105
---

Ship it!


shipped to ldapplugin ec064b307734dcb1d4304454de466d6e70e019fb
close as submitted

- Sebastien Goasguen


On July 26, 2013, 4:13 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12969/
> ---
> 
> (Updated July 26, 2013, 4:13 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and 
> Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Completes the task for adding LDAP user provisioning UI features. 
> 
> This inlcudes:
> Add accounts -> add account
> Table of user accounts within LDAP appears.
> Admin selects user and can add.
> An admin has the ability to select multiple users. 
> 
> This add screen will only appear when ldap is enabled.
> 
> 
> Diffs
> -
> 
>   plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81 
>   ui/css/cloudstack3.css 93658db 
>   ui/index.jsp 813dbcb 
>   ui/scripts/accounts.js e3e28e4 
>   ui/scripts/accountsWizard.js a350085 
>   ui/scripts/sharedFunctions.js 6c1b009 
>   ui/scripts/ui-custom/accountsWizard.js 4037788 
> 
> Diff: https://reviews.apache.org/r/12969/diff/
> 
> 
> Testing
> ---
> 
> All testing was done manually
> 
> Create a single account when ldap is enabled. 
> create multiple accounts when ldap is enabled.
> 
> create a single account when ldap is disabled.
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/#review24106
---


Commit eae874918d717ba06d0ab18ece6e4a7a2f28471b in branch refs/heads/master 
from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eae8749 ]

CLOUDSTACK-3744 Fixed order of cleanup objects, removed offerings cleanup

Signed-off-by: Prasanna Santhanam 
(cherry picked from commit 08c82883f6bcc18804c88633c9c85764c5d22417)


- ASF Subversion and Git Services


On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13009/
> ---
> 
> (Updated July 29, 2013, 9:31 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3744
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_netscaler_nw_off.py 5fd2195 
> 
> Diff: https://reviews.apache.org/r/13009/diff/
> 
> 
> Testing
> ---
> 
> Tested locally. Script is now passing and cleanup of all accounts done.
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/#review24107
---


Commit 08c82883f6bcc18804c88633c9c85764c5d22417 in branch refs/heads/4.2 from 
Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08c8288 ]

CLOUDSTACK-3744 Fixed order of cleanup objects, removed offerings cleanup

Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13009/
> ---
> 
> (Updated July 29, 2013, 9:31 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3744
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_netscaler_nw_off.py 5fd2195 
> 
> Diff: https://reviews.apache.org/r/13009/diff/
> 
> 
> Testing
> ---
> 
> Tested locally. Script is now passing and cleanup of all accounts done.
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13009/#review24108
---

Ship it!


Ship It!

- Prasanna Santhanam


On July 29, 2013, 9:31 a.m., Sowmya Krishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13009/
> ---
> 
> (Updated July 29, 2013, 9:31 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3744
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_netscaler_nw_off.py 5fd2195 
> 
> Diff: https://reviews.apache.org/r/13009/diff/
> 
> 
> Testing
> ---
> 
> Tested locally. Script is now passing and cleanup of all accounts done.
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: [GSoC] Unable create systemvm

[Nguyen Anh Tu]

Got it. Because I have 2 vhd files in secondary/template/1/1 so vhd-util
catch both of them. So copy_vhd_from_secondarystorage script throws error


2013/7/29 Nguyen Anh Tu 

> I debug and get error starting from here:
>
> protected void createBaseImageAsync(VolumeInfo volume, PrimaryDataStore
> dataStore, TemplateInfo template,
> AsyncCallFuture future) {
> ...
> *motionSrv.copyAsync(template, templateOnPrimaryStoreObj, caller);*
> ...
> }
>
>
> Exeption here:
>
> WARN  [xen.resource.CitrixResourceBase] (DirectAgent-37:)
> kill_copy_process failed
> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-37:) can not
> create vdi in sr a36311b4-ff2c-141a-4191-047c9c3a2c48
> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-37:) Catch
> Exception com.cloud.utils.exception.CloudRuntimeException for template +
>  due to com.cloud.utils.exception.CloudRuntimeException: can not create vdi
> in sr a36311b4-ff2c-141a-4191-047c9c3a2c48
> com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
> a36311b4-ff2c-141a-4191-047c9c3a2c48
> at
> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:792)
>  at
> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:863)
> at
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:70)
>  at
> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:49)
> at
> com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:625)
>  at
> com.cloud.hypervisor.xen.resource.XcpServerResource.executeRequest(XcpServerResource.java:53)
> at
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
>  at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>  at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
>  at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>  at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)
>
> Any idea?
>
>
> 2013/7/29 Nguyen Anh Tu 
>
>> Hi guys,
>>
>> I re-deploy ACS (sdnextensions branch, same same with 4.1 I think) with
>> XCP 1.6 and get an error on create systemvm. I also re-copy vhd-util to
>> Host (/opt/xensource/bin/) but still error. Log here:
>>
>> INFO  [cloud.secstorage.PremiumSecondaryStorageManagerImpl]
>> (secstorage-1:) No running secondary storage vms found in datacenter id=1,
>> starting one
>> INFO  [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) No
>> stopped secondary storage vm is available, need to allocate a new secondary
>> storage vm
>> INFO  [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) No
>> stopped console proxy is available, need to allocate a new console proxy
>> WARN  [xen.resource.CitrixResourceBase] (DirectAgent-8:)
>> kill_copy_process failed
>> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) can not
>> create vdi in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
>> WARN  [xen.resource.XenServerStorageProcessor] (DirectAgent-8:) Catch
>> Exception com.cloud.utils.exception.CloudRuntimeException for template +
>>  due to com.cloud.utils.exception.CloudRuntimeException: can not create vdi
>> in sr 1e7b078a-322e-8d95-f712-eed1dc824aa8
>> com.cloud.utils.exception.CloudRuntimeException: can not create vdi in sr
>> 1e7b078a-322e-8d95-f712-eed1dc824aa8
>> at
>> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copy_vhd_from_secondarystorage(XenServerStorageProcessor.java:792)
>>  at
>> com.cloud.hypervisor.xen.resource.XenServerStorageProcessor.copyTemplateToPrimaryStorage(XenServerStorageProcessor.java:863)
>> at
>> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.execute(StorageSubsystemCommandHandlerBase.java:70)
>>  at
>> com.cloud.storage.resource.StorageSubsystemCommandHandlerBase.handleStorageCommands(StorageSubsystemCommandHandlerBase.java:49)
>> at
>> com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:625)
>>  at
>> com.cloud.hypervisor.xen.resource.XcpServerResource.executeRequest(XcpServerResource.java:53)
>> at
>> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
>>  at
>> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
>>  at java.util.concurrent.FutureTask.run(FutureTask.java:166)
>> at
>> 

Regarding the variable names in the VOs.

[Bharat Kumar]

Hi all, 

I am came across a bug which was caused because of using underscore in the 
variable name in the VO. 

 @Column(name = "concurrent_connections")
Integer concurrent_connections;

because of this the call to update dose not update the VO and if the API is 
used only with this parameter the API server throws an error.

but if i change it to 


@Column(name = "concurrent_connections")
Integer concurrentConnections;

(remove the underscore)  it works. 

Dose any one know why this dependency is there. 

Regards,
Bharat.

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

[Jijun]

> On July 29, 2013, 8:30 a.m., daan Hoogland wrote:
> > Jijun, please make sure your adjusted call to URI() only gets called when 
> > BroadcastDomainType is Vlan, Storage or Mido and not when it is for 
> > instance Lswitch.

when scheme is vlan, some code will invoke URI.getHost(), but it will return 
null, and should be vlan id.
in fact , it is the issue of IsolationType. but i find BroadcastDomainType has 
the same logic,so i change it too. maybe i should check the scheme in function 
toURI().  


- Jijun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13004/#review24098
---


On July 28, 2013, 11:49 a.m., Jijun wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13004/
> ---
> 
> (Updated July 28, 2013, 11:49 a.m.)
> 
> 
> Review request for cloudstack, edison su and Wei Zhou.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
>  In lastest CS 4.2 code, I  create advance zone  with hypervisor vmware esxi,
> create public Network with vlan id 509 specified and  label vSwitch0, when cs 
> create systemvm(cpvm,ssvm),
> a new portgroup with  name  cloud.public.untagged.0.1-vSwitch0 was created, 
> not a portgroup cloud.public.509.0.1-vSwitch0 as expected. 
> in database table nics, the field broadcast_uri for new systemvm  is vlan:509 
>  , and should be vlan://509
> debug the code and found it is a syntax error in Networks.java for new 
> instance java.net.URI.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
> 
> Diff: https://reviews.apache.org/r/13004/diff/
> 
> 
> Testing
> ---
> 
> recreate the system vm or create a new advance zone , public network with vlan
> 
> 
> Thanks,
> 
> Jijun
> 
>

Re: Regarding the variable names in the VOs.

[Wei ZHOU]

AFAIK, The @Colume should be same to the column in database.
The variable concurrentConnections/concurrent_connections should be same to
the responding *DaoImpl.java


2013/7/29 Bharat Kumar 

> Hi all,
>
> I am came across a bug which was caused because of using underscore in the
> variable name in the VO.
>
>  @Column(name = "concurrent_connections")
> Integer concurrent_connections;
>
> because of this the call to update dose not update the VO and if the API
> is used only with this parameter the API server throws an error.
>
> but if i change it to
>
>
> @Column(name = "concurrent_connections")
> Integer concurrentConnections;
>
> (remove the underscore)  it works.
>
> Dose any one know why this dependency is there.
>
> Regards,
> Bharat.
>
>

Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0

[Jijun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13004/
---

(Updated July 29, 2013, 11:07 a.m.)


Review request for cloudstack, daan Hoogland, edison su, and Wei Zhou.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883


Repository: cloudstack-git


Description
---

 In lastest CS 4.2 code, I  create advance zone  with hypervisor vmware esxi,
create public Network with vlan id 509 specified and  label vSwitch0, when cs 
create systemvm(cpvm,ssvm),
a new portgroup with  name  cloud.public.untagged.0.1-vSwitch0 was created, not 
a portgroup cloud.public.509.0.1-vSwitch0 as expected. 
in database table nics, the field broadcast_uri for new systemvm  is vlan:509  
, and should be vlan://509
debug the code and found it is a syntax error in Networks.java for new instance 
java.net.URI.


Diffs
-

  api/src/com/cloud/network/Networks.java c76c3d4 

Diff: https://reviews.apache.org/r/13004/diff/


Testing
---

recreate the system vm or create a new advance zone , public network with vlan


Thanks,

Jijun

Review Request 13012: createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13012/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-2622


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-2622
createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest 
Networks


Diffs
-

  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
2a8a6e2 

Diff: https://reviews.apache.org/r/13012/diff/


Testing
---

Tested with 4.2


Thanks,

bharat kumar

Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13013/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-3882


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-3882
remove the duplicate entries of the data-server from the /etc/hosts


Diffs
-

  patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 

Diff: https://reviews.apache.org/r/13013/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar

Re: Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13013/#review24111
---

Ship it!


Ship It!

- Abhinandan Prateek


On July 29, 2013, 11:39 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13013/
> ---
> 
> (Updated July 29, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-3882
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3882
> remove the duplicate entries of the data-server from the /etc/hosts
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 
> 
> Diff: https://reviews.apache.org/r/13013/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13013/
---

(Updated July 29, 2013, 12:17 p.m.)


Review request for cloudstack and Abhinandan Prateek.


Changes
---

Made the regex tighter.


Bugs: Cloudstack-3882


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-3882
remove the duplicate entries of the data-server from the /etc/hosts


Diffs (updated)
-

  patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 

Diff: https://reviews.apache.org/r/13013/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar

Checking grep/sed commands in shell and python script files

[Wei ZHOU]

Guys,

There are many shell/python script files in cloudstack which contain grep
or sed commands (which may return greedy results) . Some issues are because
of these files, for instance CLOUDSTACK-3540, CLOUDSTACK-3533,
CLOUDSATCK-3843.

We need to check all the script files in patches/ and scripts/ directory,
and fix the potential issues.


[root@centos master]# grep -rl -E "grep|sed" scripts/ | grep -v xml
scripts/.pydevproject
scripts/storage/checkchildren.sh
scripts/storage/installIso.sh
scripts/storage/qcow2/create_private_template.sh
scripts/storage/qcow2/createtmplt.sh
scripts/storage/qcow2/get_domr_kernel.sh
scripts/storage/qcow2/listvmtmplt.sh
scripts/storage/qcow2/listvolume.sh
scripts/storage/qcow2/importmpl.sh
scripts/storage/qcow2/createvolume.sh
scripts/storage/qcow2/resizevolume.sh
scripts/storage/qcow2/createvm.sh
scripts/storage/qcow2/listvmdisk.sh
scripts/storage/qcow2/managesnapshot.sh
scripts/storage/qcow2/listvmdisksize.sh
scripts/storage/qcow2/managevolume.sh
scripts/storage/qcow2/delvm.sh
scripts/storage/qcow2/get_iqn.sh
scripts/storage/secondary/installIso.sh
scripts/storage/secondary/createtmplt.sh
scripts/storage/secondary/listvmtmplt.sh
scripts/storage/secondary/cloud-install-sys-tmplt
scripts/storage/secondary/listvolume.sh
scripts/storage/secondary/create_privatetemplate_from_snapshot_xen.sh
scripts/storage/secondary/swift
scripts/storage/secondary/createvolume.sh
scripts/vm/systemvm/injectkeys.sh
scripts/vm/pingtest.sh
scripts/vm/hypervisor/versions.sh
scripts/vm/hypervisor/kvm/setup_agent.sh
scripts/vm/hypervisor/kvm/patchviasocket.pl
scripts/vm/hypervisor/kvm/kvmheartbeat.sh
scripts/vm/hypervisor/xenserver/mockxcpplugin.py
scripts/vm/hypervisor/xenserver/launch_hb.sh
scripts/vm/hypervisor/xenserver/copy_vhd_from_secondarystorage.sh
scripts/vm/hypervisor/xenserver/upgrade_vnc_config.sh
scripts/vm/hypervisor/xenserver/upgrade_snapshot.sh
scripts/vm/hypervisor/xenserver/make_migratable.sh
scripts/vm/hypervisor/xenserver/vmopspremium
scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
scripts/vm/hypervisor/xenserver/xenserver56fp1/NFSSR.py
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch
scripts/vm/hypervisor/xenserver/add_to_vcpus_params_live.sh
scripts/vm/hypervisor/xenserver/create_privatetemplate_from_snapshot.sh
scripts/vm/hypervisor/xenserver/cloud-propagate-vlan.sh
scripts/vm/hypervisor/xenserver/xs_cleanup.sh
scripts/vm/hypervisor/xenserver/swift
scripts/vm/hypervisor/xenserver/hostvmstats.py
scripts/vm/hypervisor/xenserver/cloud-clean-vlan.sh
scripts/vm/hypervisor/xenserver/xcposs/copy_vhd_from_secondarystorage.sh
scripts/vm/hypervisor/xenserver/xcposs/vmopspremium
scripts/vm/hypervisor/xenserver/xcposs/create_privatetemplate_from_snapshot.sh
scripts/vm/hypervisor/xenserver/xcposs/copy_vhd_to_secondarystorage.sh
scripts/vm/hypervisor/xenserver/xcposs/vmopsSnapshot
scripts/vm/hypervisor/xenserver/xcposs/vmops
scripts/vm/hypervisor/xenserver/xcposs/NFSSR.py
scripts/vm/hypervisor/xenserver/xcposs/patch
scripts/vm/hypervisor/xenserver/copy_vhd_to_secondarystorage.sh
scripts/vm/hypervisor/xenserver/xen-ovs-vif-flows.rules

[root@weizhou-centos master]# grep -rl -E "grep|sed" patches/systemvm/
patches/systemvm/debian/systemvm.xml
patches/systemvm/debian/xe/xe-linux-distribution
patches/systemvm/debian/xe/xe-update-guest-attrs
patches/systemvm/debian/xe/xe-daemon
patches/systemvm/debian/convert.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_staticroute.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_staticnat.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_guestnw.sh
patches/systemvm/debian/config/opt/cloud/bin/checks2svpn.sh
patches/systemvm/debian/config/opt/cloud/bin/patchsystemvm.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_passwd_server
patches/systemvm/debian/config/opt/cloud/bin/vpc_func.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_ipassoc.sh
patches/systemvm/debian/config/opt/cloud/bin/ipsectunnel.sh
patches/systemvm/debian/config/opt/cloud/bin/checkbatchs2svpn.sh
patches/systemvm/debian/config/opt/cloud/bin/get_template_version.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_snat.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_netusage.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_acl.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_loadbalancer.sh
patches/systemvm/debian/config/opt/cloud/bin/ilb.sh
patches/systemvm/debian/config/opt/cloud/bin/cloud-nic.sh
patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh
patches/systemvm/debian/config/opt/cloud/bin/serve_password.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_privateGateway.sh
patches/systemvm/debian/config/opt/cloud/bin/netusage.sh
patches/systemvm/debian/config/opt/cloud/bin/vpc_portforwarding.sh
patches/systemvm/debian/config/opt/cloud/bin/passwd_server
patches/systemvm/debian/config/opt/cloud/bin/passwd_server_ip
patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py
patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh
patches/systemvm

Re: Review Request 12999: [GSoC] Add mid-term report

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12999/#review24112
---

Ship it!


applied to master with fd32c33d6d278ec5913bb62b6828adb945036a28

mark review as submitted

- Sebastien Goasguen


On July 28, 2013, 5:38 p.m., tuna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12999/
> ---
> 
> (Updated July 28, 2013, 5:38 p.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> I add the mid-term report for my GSoC project
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-nguyen.xml 96c2de1 
>   docs/en-US/images/l3_services.png PRE-CREATION 
>   docs/en-US/images/network_service.png PRE-CREATION 
>   docs/en-US/images/odl_structure.jpg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12999/diff/
> 
> 
> Testing
> ---
> 
> Built successfully with publican.
> 
> 
> Thanks,
> 
> tuna
> 
>

Re: Review Request 12934: Tests for egress firewall rules for advance zone

[Jayapal Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24101
---



test/integration/component/test_egress_fw_rules.py


I think you are not clear with the default egress policy. 

 - egress policy true
   All the guest network traffic to public n/w is allowed by default. 
Adding egress rule blocks only the rule specific traffic.
   
-egress policy false
By default guest network traffic to public n/w is block. if you add 
egress rule  then only egress rule specific traffic is allowed.

When egress policy is true, by default the guest network traffic is allow.

public network should be reachable



test/integration/component/test_egress_fw_rules.py


here ping google.com should success.



test/integration/component/test_egress_fw_rules.py


Please update all the comments in this file, network offering with egress 
policy .
# deploy vm with network offering egress policy true 



test/integration/component/test_egress_fw_rules.py


Please understand the basics and update the test cases.

ping should be blocked. 100% packet loss



test/integration/component/test_egress_fw_rules.py


mention the network offering with egress policy=false



test/integration/component/test_egress_fw_rules.py


Here ping is success. 
I did not get why 100% packet loss ?



test/integration/component/test_egress_fw_rules.py


In egress CIDR is not destination/public CIDR.
CIDR is guest network/source CIDR.

Please change the comments



test/integration/component/test_egress_fw_rules.py


if 10.2.2.2 exists then ping will be success. 

You test case should be like.
give CIDR 10.1.1.120/32 and try to access wget from the vm 10.1.1.100. Then 
ping should fail from the 10.1.1.100 and pass from the vm with ip 10.1.1.120



test/integration/component/test_egress_fw_rules.py


The purpose of the test is not correct.

The CIDR is source cidr, so testing public network is not needed.



test/integration/component/test_egress_fw_rules.py



wget will be success.Why we get failed here ?



test/integration/component/test_egress_fw_rules.py


here egress default policy is true. 
created egress rule for icmp , the icmp traffic is BLOCKED and other 
traffic is allowed.





test/integration/component/test_egress_fw_rules.py


connection to public should be allowed



test/integration/component/test_egress_fw_rules.py


do we need second vm here ?



test/integration/component/test_egress_fw_rules.py


here ping should fail here



test/integration/component/test_egress_fw_rules.py


ping should success here



test/integration/component/test_egress_fw_rules.py


Here you are passing valid CIDR.
The comment should be updated to 
'create egress rule with other than guest cidr'



test/integration/component/test_egress_fw_rules.py


remove this comment



test/integration/component/test_egress_fw_rules.py


Remove this comment


- Jayapal Reddy


On July 29, 2013, 4:57 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12934/
> ---
> 
> (Updated July 29, 2013, 4:57 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
> Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Tests for egress firewall rules for advance zone.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12934/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 12131: CLOUDSTACK-3215 Cannot Deploy VM when using S3 object store without NFS Cache

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/#review24113
---


Commit 50fe9e1cbf1a25cfe6b9d0760cb14d23d1cfbc72 in branch refs/heads/4.2 from 
Rajesh Battala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50fe9e1 ]

CLOUDSTACK-3215 Logs in the Software router are not being rotated


- ASF Subversion and Git Services


On June 28, 2013, 7:46 p.m., Donal Lafferty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12131/
> ---
> 
> (Updated June 28, 2013, 7:46 p.m.)
> 
> 
> Review request for cloudstack, edison su and Min Chen.
> 
> 
> Bugs: CLOUDSTACK-3215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to 
> not use a cache for image transfer if one can't be found.  Previously, the 
> management server entered a failure state.
> Also, added addition debug logging.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
>  4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  631de6a47a3eff510c84aa275fd87f8fa2f7780b 
> 
> Diff: https://reviews.apache.org/r/12131/diff/
> 
> 
> Testing
> ---
> 
> Code executed on deployement using S3 and no NFS cache.  Did not have 
> facilities to test on S3 with a cache. 
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>

Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/
---

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

The exception raised is valid behavior. It attempts to delete security group 
without destroying vm in it, hence expecting exception in the operation.
Added self.assertRaises for the security group delete operation. Works fin now.


Diffs
-

  test/integration/component/test_security_groups.py 3c25e25 

Diff: https://reviews.apache.org/r/13014/diff/


Testing
---

Tested on KVM basic setup.


Thanks,

Gaurav Aradhye

Re: Review Request 13012: createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13012/#review24114
---

Ship it!


Ship It!

- Abhinandan Prateek


On July 29, 2013, 11:21 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13012/
> ---
> 
> (Updated July 29, 2013, 11:21 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2622
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2622
> createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest 
> Networks
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 2a8a6e2 
> 
> Diff: https://reviews.apache.org/r/13012/diff/
> 
> 
> Testing
> ---
> 
> Tested with 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/
---

Review request for cloudstack, Devdeep Singh and Fang Wang.


Bugs: CLOUDSTACK-1961


Repository: cloudstack-git


Description
---

CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.


Diffs
-

  services/console-proxy/server/js/ajaxviewer.js a6e1eda 

Diff: https://reviews.apache.org/r/13015/diff/


Testing
---

Tested the fix on windows 7 guestOS and Xenserver hypervisor.


Thanks,

Sanjay Tripathi

Re: Review Request 12131: CLOUDSTACK-3215 Cannot Deploy VM when using S3 object store without NFS Cache

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/#review24115
---


Commit 8edf6b346789f826847245472977913b56bce17e in branch refs/heads/master 
from Rajesh Battala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8edf6b3 ]

CLOUDSTACK-3215 Logs in the Software router are not being rotated


- ASF Subversion and Git Services


On June 28, 2013, 7:46 p.m., Donal Lafferty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12131/
> ---
> 
> (Updated June 28, 2013, 7:46 p.m.)
> 
> 
> Review request for cloudstack, edison su and Min Chen.
> 
> 
> Bugs: CLOUDSTACK-3215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to 
> not use a cache for image transfer if one can't be found.  Previously, the 
> management server entered a failure state.
> Also, added addition debug logging.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
>  4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  631de6a47a3eff510c84aa275fd87f8fa2f7780b 
> 
> Diff: https://reviews.apache.org/r/12131/diff/
> 
> 
> Testing
> ---
> 
> Code executed on deployement using S3 and no NFS cache.  Did not have 
> facilities to test on S3 with a cache. 
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>

Re: Review Request 12996: Unable to Resize Volume (kvm, vmware)

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12996/#review24118
---

Ship it!


Committed to 4.2 and master. Kindly close the request.

- Devdeep Singh


On July 27, 2013, 3:05 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12996/
> ---
> 
> (Updated July 27, 2013, 3:05 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram 
> Ganesh.
> 
> 
> Bugs: 3877
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> =
> this issue is with the way we extract the hypevisor type from the sql 
> 
> 
> mysql> SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, 
> cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21;
> ++-+
> | hypervisor | hypervisor_type |
> ++-+
> | NULL | KVM |
> ++-+
> 
> 
> first column value will be not null if the storage pool is Zone wide else it 
> will be NULL. 
> but in the code always first column is considering to figure out the 
> hypervisor type which causing the hpervisor type to be NONE and hence failing 
> to resize the volume
> 
> 
> this issue is happening while determining the hypervisor type for a volume. 
> for ZWPS, it will return the hypervisor because, in storage pool we store the 
> hypervisor type if the pool is added of scoe ZONE. 
> if the pool is of scope Cluster hypervisor type will be NULL
> 
> we support volume resize when the volume is present on ZONE scope and Cluster 
> scope. 
> they way of hypervisor type extraction from the sql query result should be 
> change which will resolve this blocker.
> 
> 
> Fix:
> =
> 
> depending on the scope type of storage pool, the sql result is passed to 
> determined the hypervisor type.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc 
> 
> Diff: https://reviews.apache.org/r/12996/diff/
> 
> 
> Testing
> ---
> 
> 1. Able to resize the volume successfully
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip

[Murali Reddy]

> On July 25, 2013, 1:28 p.m., Jenkins Cloudstack.org wrote:
> > Review 12942 failed the build test : UNSTABLE
> > The url of build cloudstack-master-with-patch #38 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/38/

test changes are fine. but looks like there is assumption that first IP 
associated with a network is always used for source NAT. Please open a bug, i 
will fix the issue.


- Murali


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12942/#review23838
---


On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12942/
> ---
> 
> (Updated July 25, 2013, 12:50 p.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3454
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added isportable param to associateIP API. Fixed base class
> for PortableIP tio call portableip APIs.
> Removed test_createPortablePublicIPAcquire from basic zone run
> requires additional network creation handling which can be done
> in component tests.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_portable_publicip.py 9a3a398 
>   tools/marvin/marvin/integration/lib/base.py 0f6fdc5 
> 
> Diff: https://reviews.apache.org/r/12942/diff/
> 
> 
> Testing
> ---
> 
> Yes, but disassociating ip address fails. Maybe a product defect, yet to 
> investigate.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12997: usage event is not generated for volume resize

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12997/#review24119
---

Ship it!


Committed to 4.2 and master. Kindly close the request.

- Devdeep Singh


On July 27, 2013, 3:11 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12997/
> ---
> 
> (Updated July 27, 2013, 3:11 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> issue:
> 
> when resize volume is requested and action is successfuly usage event is not 
> recorded. Code is not present for recording the resize volume usage event.
> 
> fix:
> Added the code to record the usage event when the resize volume is requested.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 
> 
> Diff: https://reviews.apache.org/r/12997/diff/
> 
> 
> Testing
> ---
> 
> Environment:
> kvm, with cluster scope storage pool.
> default centos instance.
> 
> 1. created a volume and tried to resize the volume.
> volume resize is successful
> 
> usage event is registered in usage_event table now.
> 
>   | 0 | NULL |
> | 27 | VOLUME.RESIZE   |  2 | 2013-07-27 14:54:51 |   1 | 
>  21 | TestVol  |   6 |
> NULL |  5368709120 | NULL   | 0 | NULL |
> ++-++-+-+-+--+-+-+-++---+--+
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12994/#review24116
---

Ship it!


Committed to 4.2 and master. Kindly close the request.

- Devdeep Singh


On July 27, 2013, 1:09 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12994/
> ---
> 
> (Updated July 27, 2013, 1:09 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and 
> Hugo Trippaers.
> 
> 
> Bugs: 3216
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue:
> ==
> logrotate.conf and logrotate config files in logrotate.d folder are having 
> "x" permission. 
> hence logrotate daemon not able to use this config 
> logrotate reports the error as 
> /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf
> reading config file /etc/logrotate.conf
> including /etc/logrotate.d
> Ignoring apache2 because of bad file mode.
> reading config file apt
> reading config file aptitude
> reading config file conntrackd
> Ignoring dnsmasq because of bad file mode.
> reading config file dpkg
> Ignoring haproxy because of bad file mode.
> reading config file monit
> Ignoring ppp because of bad file mode.
> Ignoring rsyslog because of bad file mode.
> ==
> 
> Fix:
> ===
> while generating the cloudscripts.tgz file, I had modified to include the 
> logrotate.conf and logrotate config files under logrotate.d with 644 
> permission which will fix the issue. 
> this is will fix the "bad file mode" error. 
> 
> 
> Diffs
> -
> 
>   patches/pom.xml 00eec02 
> 
> Diff: https://reviews.apache.org/r/12994/diff/
> 
> 
> Testing
> ---
> 
> 1. after generating new systemvm.iso tested the new router/ssvm/console proxy.
> 
> logrotate -d -v /etc/logrotate.conf
> reading config file /etc/logrotate.conf
> including /etc/logrotate.d
> reading config file apache2
> reading config file apt
> reading config file aptitude
> reading config file conntrackd
> reading config file dnsmasq
> reading config file dpkg
> reading config file haproxy
> reading config file monit
> reading config file ppp
> reading config file rsyslog
> 
> 
> 2. Verified after launching the VR, new instances are getting IP and hostname 
> properly.
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 12997: usage event is not generated for volume resize

[Kishan Kavala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12997/#review24120
---


UsageServer also has to support volume resize event. It is not sufficient to 
generate the event. In UsageManager, resize event should end the usage volume 
helper event and create a new entry with updated size.

- Kishan Kavala


On July 27, 2013, 8:41 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12997/
> ---
> 
> (Updated July 27, 2013, 8:41 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> issue:
> 
> when resize volume is requested and action is successfuly usage event is not 
> recorded. Code is not present for recording the resize volume usage event.
> 
> fix:
> Added the code to record the usage event when the resize volume is requested.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 
> 
> Diff: https://reviews.apache.org/r/12997/diff/
> 
> 
> Testing
> ---
> 
> Environment:
> kvm, with cluster scope storage pool.
> default centos instance.
> 
> 1. created a volume and tried to resize the volume.
> volume resize is successful
> 
> usage event is registered in usage_event table now.
> 
>   | 0 | NULL |
> | 27 | VOLUME.RESIZE   |  2 | 2013-07-27 14:54:51 |   1 | 
>  21 | TestVol  |   6 |
> NULL |  5368709120 | NULL   | 0 | NULL |
> ++-++-+-+-+--+-+-+-++---+--+
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24121
---


Cannot apply the patch because of whitespace errors. Can you fix it and give an 
updated patch.

- Devdeep Singh


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> ---
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard 
> Keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> ---
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Harikrishna Patnala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/
---

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-3848


Repository: cloudstack-git


Description
---

CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM


Diffs
-

  api/src/com/cloud/event/EventTypes.java 6f1eed6 
  api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
  server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
  usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 

Diff: https://reviews.apache.org/r/13016/diff/


Testing
---

Tested locally


Thanks,

Harikrishna Patnala

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Nitin Mehta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/#review24123
---



server/src/com/cloud/vm/UserVmManagerImpl.java


what if its not a dynamic scale ? Even then this would be registered right ?


- Nitin Mehta


On July 29, 2013, 1:46 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13016/
> ---
> 
> (Updated July 29, 2013, 1:46 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3848
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 
> 
> Diff: https://reviews.apache.org/r/13016/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24125
---


Commit 67c96d419d08f5a2702eee0aa64958e486f74703 in branch refs/heads/4.2 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=67c96d4 ]

CLOUDSTACK-3841: Fixed test case issue. The exception raised earlier was valid 
behaviour, added missing assertRaiss statement

Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> ---
> 
> (Updated July 29, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The exception raised is valid behavior. It attempts to delete security group 
> without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin 
> now.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_security_groups.py 3c25e25 
> 
> Diff: https://reviews.apache.org/r/13014/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM basic setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24126
---

Ship it!


Ship It!

- Prasanna Santhanam


On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> ---
> 
> (Updated July 29, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The exception raised is valid behavior. It attempts to delete security group 
> without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin 
> now.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_security_groups.py 3c25e25 
> 
> Diff: https://reviews.apache.org/r/13014/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM basic setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24124
---


Commit 3a3145507d8b68b13d4320847511aaacc25475e5 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3a31455 ]

CLOUDSTACK-3841: Fixed test case issue. The exception raised earlier was valid 
behaviour, added missing assertRaiss statement

Signed-off-by: Prasanna Santhanam 
(cherry picked from commit 67c96d419d08f5a2702eee0aa64958e486f74703)


- ASF Subversion and Git Services


On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> ---
> 
> (Updated July 29, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The exception raised is valid behavior. It attempts to delete security group 
> without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin 
> now.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_security_groups.py 3c25e25 
> 
> Diff: https://reviews.apache.org/r/13014/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM basic setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12942/#review24127
---


Commit 8be9a47542e0ae0f481733ac4ddb6476d0e20a18 in branch refs/heads/4.2 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8be9a47 ]

CLOUDSTACK-3454: Fix test_portable_publicip

Added isportable param to associateIP API. Fixed base class
for PortableIP tio call portableip APIs.
Removed test_createPortablePublicIPAcquire from basic zone run
requires additional network creation handling which can be done
in component tests.

Signed-off-by: Prasanna Santhanam 
(cherry picked from commit 4054a8e2ac91eee6cbc0c63094016068bdbe62b8)


- ASF Subversion and Git Services


On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12942/
> ---
> 
> (Updated July 25, 2013, 12:50 p.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3454
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added isportable param to associateIP API. Fixed base class
> for PortableIP tio call portableip APIs.
> Removed test_createPortablePublicIPAcquire from basic zone run
> requires additional network creation handling which can be done
> in component tests.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_portable_publicip.py 9a3a398 
>   tools/marvin/marvin/integration/lib/base.py 0f6fdc5 
> 
> Diff: https://reviews.apache.org/r/12942/diff/
> 
> 
> Testing
> ---
> 
> Yes, but disassociating ip address fails. Maybe a product defect, yet to 
> investigate.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12942/#review24128
---


Commit 4054a8e2ac91eee6cbc0c63094016068bdbe62b8 in branch refs/heads/master 
from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4054a8e ]

CLOUDSTACK-3454: Fix test_portable_publicip

Added isportable param to associateIP API. Fixed base class
for PortableIP tio call portableip APIs.
Removed test_createPortablePublicIPAcquire from basic zone run
requires additional network creation handling which can be done
in component tests.

Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12942/
> ---
> 
> (Updated July 25, 2013, 12:50 p.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3454
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added isportable param to associateIP API. Fixed base class
> for PortableIP tio call portableip APIs.
> Removed test_createPortablePublicIPAcquire from basic zone run
> requires additional network creation handling which can be done
> in component tests.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_portable_publicip.py 9a3a398 
>   tools/marvin/marvin/integration/lib/base.py 0f6fdc5 
> 
> Diff: https://reviews.apache.org/r/12942/diff/
> 
> 
> Testing
> ---
> 
> Yes, but disassociating ip address fails. Maybe a product defect, yet to 
> investigate.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12942/#review24129
---

Ship it!


- Prasanna Santhanam


On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12942/
> ---
> 
> (Updated July 25, 2013, 12:50 p.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3454
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added isportable param to associateIP API. Fixed base class
> for PortableIP tio call portableip APIs.
> Removed test_createPortablePublicIPAcquire from basic zone run
> requires additional network creation handling which can be done
> in component tests.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_portable_publicip.py 9a3a398 
>   tools/marvin/marvin/integration/lib/base.py 0f6fdc5 
> 
> Diff: https://reviews.apache.org/r/12942/diff/
> 
> 
> Testing
> ---
> 
> Yes, but disassociating ip address fails. Maybe a product defect, yet to 
> investigate.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13015/#review24130
---


Review 13015 PASSED the build test
The url of build cloudstack-master-with-patch #68 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/68/

- Jenkins Cloudstack.org


On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13015/
> ---
> 
> (Updated July 29, 2013, 1:04 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Bugs: CLOUDSTACK-1961
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1961: Common issues found in English OS with EN-US standard 
> Keyboard.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxviewer.js a6e1eda 
> 
> Diff: https://reviews.apache.org/r/13015/diff/
> 
> 
> Testing
> ---
> 
> Tested the fix on windows 7 guestOS and Xenserver hypervisor.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13012: createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13012/#review24131
---


Review 13012 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #69 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/69/

- Jenkins Cloudstack.org


On July 29, 2013, 11:21 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13012/
> ---
> 
> (Updated July 29, 2013, 11:21 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2622
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-2622
> createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest 
> Networks
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 2a8a6e2 
> 
> Diff: https://reviews.apache.org/r/13012/diff/
> 
> 
> Testing
> ---
> 
> Tested with 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24132
---


Review 13014 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #70 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/70/

- Jenkins Cloudstack.org


On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> ---
> 
> (Updated July 29, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The exception raised is valid behavior. It attempts to delete security group 
> without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin 
> now.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_security_groups.py 3c25e25 
> 
> Diff: https://reviews.apache.org/r/13014/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM basic setup.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13013/#review24134
---


Review 13013 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #71 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/71/

- Jenkins Cloudstack.org


On July 29, 2013, 12:17 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13013/
> ---
> 
> (Updated July 29, 2013, 12:17 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-3882
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3882
> remove the duplicate entries of the data-server from the /etc/hosts
> 
> 
> Diffs
> -
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 
> 
> Diff: https://reviews.apache.org/r/13013/diff/
> 
> 
> Testing
> ---
> 
> Tested on 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---

(Updated July 29, 2013, 2:54 p.m.)


Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.


Changes
---

Updated patch. Removed "Skip" for project tests. These tests are working now. 
Updated few comment in other files.


Repository: cloudstack-git


Description
---

Adding test cases for CPU limits from Limit Resources.
Marvin changes have to be picked up from Memory Limits patch 
(https://reviews.apache.org/r/11626/). Those are not included in this patch.


Diffs (updated)
-

  test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION 
  test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION 

Diff: https://reviews.apache.org/r/13001/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13016/#review24137
---


Review 13016 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #72 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/72/

- Jenkins Cloudstack.org


On July 29, 2013, 1:46 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13016/
> ---
> 
> (Updated July 29, 2013, 1:46 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3848
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
>   usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd 
> 
> Diff: https://reviews.apache.org/r/13016/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12991: GSOC2013 meng midterm report

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12991/#review24138
---

Ship it!


commited to master with 2238e2bbc5863ce926341b2d91fd4bc8bca1c873

please mark as submitted , thanks

- Sebastien Goasguen


On July 27, 2013, 1:37 a.m., meng han wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12991/
> ---
> 
> (Updated July 27, 2013, 1:37 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is meng's midterm report for GSOC 2013!
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-meng.xml 1ab07cb 
>   docs/en-US/images/clusterDefinition.png PRE-CREATION 
>   docs/en-US/images/launchHadoopClusterApi.png PRE-CREATION 
>   docs/en-US/images/launchHadoopClusterCmd.png PRE-CREATION 
>   docs/en-US/images/whirrDependency.png PRE-CREATION 
>   docs/en-US/images/whirrOutput.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12991/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> meng han
> 
>

Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/
---

Review request for cloudstack, Devdeep Singh and Kishan Kavala.


Bugs: 3252


Repository: cloudstack-git


Description
---

If an instance is deployed using explicit or implicit dedication, or neither of 
them a usage event isn't generated. 
Added 2 new usage_events : 
EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
generated when VMs are deployed using corresponding dedications.


Diffs
-

  api/src/com/cloud/event/EventTypes.java 6f1eed6 
  server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 

Diff: https://reviews.apache.org/r/13020/diff/


Testing
---

usage_events table has now entries for new types:
select * from usage_event where type like "VM%CREATE%"
   id: 25
 type: VM.CREATE.IMPLICIT
   account_id: 2
  created: 2013-07-29 15:46:36
  zone_id: 1
  resource_id: 7
resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
  offering_id: 15
  template_id: 5
 size: NULL
resource_type: XenServer
processed: 0
 virtual_size: NULL


Build passed.
Patch applies cleanly.


Thanks,

Saksham Srivastava

Re: Review Request 12995: [GSoC] Add midterm report to docs

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12995/#review24142
---

Ship it!


committed to master 79419d43736d49a86c2f7595bc8c62ddc1f9931f

close review as 'submitted' thanks

- Sebastien Goasguen


On July 27, 2013, 1:11 p.m., Shiva Teja Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12995/
> ---
> 
> (Updated July 27, 2013, 1:11 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> GSoC - Add midterm review
> 
> 
> Diffs
> -
> 
>   docs/en-US/gsoc-midsummer-shiva.xml 67755c4 
>   docs/en-US/images/add-account-screen.png PRE-CREATION 
>   docs/en-US/images/async-calls.png PRE-CREATION 
>   docs/en-US/images/configuration-edit-success.png PRE-CREATION 
>   docs/en-US/images/configurations-screen.png PRE-CREATION 
>   docs/en-US/images/create-account-post.png PRE-CREATION 
>   docs/en-US/images/create-account-request.png PRE-CREATION 
>   docs/en-US/images/edit-configuration.png PRE-CREATION 
>   docs/en-US/images/instances-screen.png PRE-CREATION 
>   docs/en-US/images/list-domain-vms.png PRE-CREATION 
>   docs/en-US/images/list-specific-vm.png PRE-CREATION 
>   docs/en-US/images/list-virtualmachines.png PRE-CREATION 
>   docs/en-US/images/start-vm-screen.png PRE-CREATION 
>   docs/en-US/images/vm-running.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12995/diff/
> 
> 
> Testing
> ---
> 
> Build was successful with publican
> 
> 
> Thanks,
> 
> Shiva Teja Reddy
> 
>

Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

[Venkata Siva Vijayendra Bhamidipati]

> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote:
> > Review 13008 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #65 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/

This patch is for 4.2 and has been tested on 4.2 as described - the patch will 
not apply on the master branch. The above failure message is for master branch. 
Requesting reviewers to review patch for 4.2.


- Venkata Siva Vijayendra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24078
---


On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13008/
> ---
> 
> (Updated July 29, 2013, 1:55 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, 
> Sateesh Chodapuneedi, and William Chan.
> 
> 
> Bugs: CLOUDSTACK-3886
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The vminstancename flag has been incorrectly used to simply append the 
> displayname to the internal VM name that shows up on vCenter in vmware 
> deployments. It was intended to show the actual name supplied as hostname, on 
> the hypervisor. This helps admins and deployers to quickly identify VMs and 
> resolve issues related to those VMs. Its usage is very limited as it stands 
> now. This fix corrects it to ensure that the name of the VM on the hypervisor 
> matches the hostname if it is supplied, and if the vm.instancename.flag is 
> set to true.
> 
> 
> Diffs
> -
> 
>   
> engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
>  96fb1d9 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
> d1392c4 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
>  e5c33cc 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  439163a 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  02e4e64 
>   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> dd0f889 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> e2dd789 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
> ac14328 
> 
> Diff: https://reviews.apache.org/r/13008/diff/
> 
> 
> Testing
> ---
> 
> Post this change, all major VM operations, namely 
> creation/destruction/expunging/start/stop/reboot of the VM have been tested 
> and observed to work correctly. Part of this patch also puts in a fix for 
> VMSync operations where the CS mgmt server doesn't detect that a guest VM is 
> down, if the guest VM has been shut down/powered off in vCenter. Other 
> operations such as VM snapshot, volume snapshots of disks belonging to the 
> VM, volume migration across primaries, volume attach/detach have also been 
> tested and they are working as expected. This is a functional change, and 
> completely transparent to any of cloudstack's existing functionalities and 
> all the test cases that cover the above code paths and APIs - all existing 
> tests should and do pass - no new tests are necessary.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request 12941: [GSoC] refactor gre controller

[Nguyen Anh Tu]

Hi Hugo,

Do you want to keep sdn.ovs.controller param in configuration? I have
already replaced it by checking whether physical-network-isolation-type is
GRE or not. But I just see two threads using this param and I don't know
what they run for. It's placed at configure() method of OvsTunnelManager.

_isEnabled =
Boolean.parseBoolean(_configDao.getValue(Config.OvsTunnelNetwork.key()));
//sdn.ovs.controller=true
 if (_isEnabled) {
_executorPool = Executors.newScheduledThreadPool(10, new
NamedThreadFactory("OVS"));
_cleanupExecutor = Executors.newScheduledThreadPool(1, new
NamedThreadFactory("OVS-Cleanup"));
}

Cheers,


2013/7/29 Nguyen Anh Tu 

> Hi,
>
> Following Hugo's review, I already changed and created an updated patch.
> Now I'm re-deploying system for final-testing before submitting the update
> patch. But getting an error on creating systemvm. Let me fix them first,
> make final-test and then submit the updated patch.
>
> Cheers,
>
>
> 2013/7/26 Nguyen Anh Tu 
>
>> Hi Hugo,
>>
>> I saw your review. But I have to concentrate to finish my report today.
>> Will comeback to review tomorrow :-)
>>
>>
>> 2013/7/25 Jenkins Cloudstack.org 
>>
>>This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/12941/
>>>
>>> Review 12941 failed the build test : FAILURE
>>> The url of build cloudstack-master-with-patch #37 is : 
>>> http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
>>>
>>>
>>> - Jenkins Cloudstack.org
>>>
>>> On July 25th, 2013, 9:05 a.m. UTC, tuna wrote:
>>>   Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>>> By tuna.
>>>
>>> *Updated July 25, 2013, 9:05 a.m.*
>>>  *Repository: * cloudstack-git
>>> Description
>>>
>>> I made an update to refactor gre controller:
>>>
>>> + remove ovs_devices table, because we'll have an ODL plugin separately.
>>> + move command/answer to new package: com.cloud.agent.api
>>> + add Connectivity service checking
>>> + add new NetworkProvider: Ovs
>>> + add L3 services to Ovs Capabilities
>>> + add L3 services prototype code.
>>>
>>> Next step:
>>> + L3 services implement with VirtualRouter
>>> + ODL plugin
>>>
>>>   Diffs
>>>
>>>- api/src/com/cloud/network/Network.java (a06208b)
>>>- client/tomcatconf/applicationContext.xml.in (60f1e30)
>>>- 
>>> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>>>(30b0521)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java
>>>(PRE-CREATION)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java
>>>(c0901b2)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java
>>>(1abc324)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java
>>>(87eedfb)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java
>>>(2adb33a)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
>>>(0ea6b52)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
>>>(b55fe6b)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
>>>(bbdf110)
>>>- plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java
>>>(b533312)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java
>>>(20603e0)
>>>- 
>>> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCr

Becareful when cherry-picking from any branch to master...

[Alex Huang]

I've been working on master to place compilation boundaries between our 
components.  Fixes include changes in pom.xml to include specific and accurate 
project dependencies.  When cherry-picking to master, please do not assume your 
code will just work.  Always compile before checking in.  Also if you're faced 
with conflicts, do not ignore the changes on master. 

>From here on, all CloudStack related dependency changes in pom.xml and 
>placement of new files in which package must be carefully considered.  I'm 
>trying to finish this up and post a wiki about it.  If it's not clear to you, 
>please post a question to me.

Thanks.

--Alex

Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/
---

Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Bugs: Cloustack-3910


Repository: cloudstack-git


Description
---

Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
https://issues.apache.org/jira/browse/CLOUDSTACK-3910


Diffs
-

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 
  setup/db/db/schema-410to420.sql 7377cbd 

Diff: https://reviews.apache.org/r/13022/diff/


Testing
---

Tested upgrade from 3.0.6 to 4.2


Thanks,

bharat kumar

uuid lost on xenserver?

[Daan Hoogland]

LS,

while trying an update path from 4.0.2 to 4.1.1 I get the appended
exceptions. It does not seem to have to do with the upgrade itself as
after starting a 4.0 management server with the old database the
problem persists. Can anyone tell me what this means?

thanks,
Daan

2013-07-29 18:59:43,114 DEBUG [xen.resource.CitrixResourceBase]
(DirectAgent-17:null) 1. The VM r-3-VM is in Starting state.
2013-07-29 18:59:43,328 WARN  [xen.resource.CitrixResourceBase]
(DirectAgent-17:null) Catch Exception: class
com.xensource.xenapi.Types$UuidInvalid due to The uuid you supplied
was invalid.
The uuid you supplied was invalid.
at com.xensource.xenapi.Types.checkResponse(Types.java:927)
at com.xensource.xenapi.Connection.dispatch(Connection.java:368)
at 
com.cloud.hypervisor.xen.resource.XenServerConnectionPool$XenServerConnection.dispatch(XenServerConnectionPool.java:909)
at com.xensource.xenapi.VDI.getByUuid(VDI.java:326)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.mount(CitrixResourceBase.java:936)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.createVbd(CitrixResourceBase.java:943)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:1302)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:517)
at 
com.cloud.hypervisor.xen.resource.XenServer56Resource.executeRequest(XenServer56Resource.java:73)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown
Source)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown
Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
2013-07-29 18:59:43,329 WARN  [xen.resource.CitrixResourceBase]
(DirectAgent-17:null) Unable to start r-3-VM due to
The uuid you supplied was invalid.
at com.xensource.xenapi.Types.checkResponse(Types.java:927)
at com.xensource.xenapi.Connection.dispatch(Connection.java:368)
at 
com.cloud.hypervisor.xen.resource.XenServerConnectionPool$XenServerConnection.dispatch(XenServerConnectionPool.java:909)
at com.xensource.xenapi.VDI.getByUuid(VDI.java:326)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.mount(CitrixResourceBase.java:936)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.createVbd(CitrixResourceBase.java:943)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:1302)
at 
com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:517)
at 
com.cloud.hypervisor.xen.resource.XenServer56Resource.executeRequest(XenServer56Resource.java:73)
at 
com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown
Source)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown
Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
2013-07-29 18:59:43,418 DEBUG [xen.resource.CitrixResourceBase]
(DirectAgent-17:null) The VM is in stopped state, detected problem
during startup : r-3-VM

Network Problem

[Thomas Schneider]

Hello,

I have setup cloudstack and it work fine, I can launch VM etc...
But the problem is I can only SSH to the VM from the host on which she
is running.
When I am in the vm I can ping exernal network and download package to
setup lamp for example.

I'm in basic network mode
My config is:

mgmt srv: 10.10.10.20
host1: 10.10.10.30
host2: 10.10.10.31
nfs for storage 10.10.10.100

pod pool 10.10.10.110 - 150
guest pool 10.10.10.200 -250

and my network config on the host in /etc/init.d/networking/interface is:
---
auto p49p1
iface p49p1 inet manual

auto cloudbr0
iface cloudbr0 inet static
bridge_ports p49p1
address 10.10.10.31
netmask 255.255.255.0
network 10.10.10.0
broadcast 10.10.10.255
gateway 10.10.10.254
# dns-* options are implemented by the resolvconf package, if installed
dns-nameservers 10.1.1.2
---

I also with to use OpenVSwitch but I didn't found a lot of documentation
for configuring in basic nework mode on ubuntu.

Tkanks for your Help.

Best Regards,

-- 
*Thomas Schneider*

RE: [DISCUSS] maven dependencies...

[Donal Lafferty]

Is it correct for dependencies to appear twice in the base pom.xml?

E.g. mysql-connector-java

> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: 26 July 2013 11:10 PM
> To: dev@cloudstack.apache.org
> Subject: [DISCUSS] maven dependencies...
> 
> Everyone,
> 
> After looking around in the maven documentation, I realized the way we are
> specifying dependencies is not quite right for a large project such as ours.
> 
> Currently, almost every project declare their own dependencies and version
> number of the dependent jar.  For those of us who are conscious of the
> version number properties declared in the cloudstack pom file, we follow
> that example but in many places, the version numbers are actually hard
> coded, probably because the writer is not aware of this.
> 
> Maven actually has a way to do this.  In the master pom file, we can declare
> in the  tags all of the third party dependencies we
> need and their version numbers.  And then each individual module can
> declare their dependency without version number, which defaults to the
> version declared by CloudStack's master pom.  If a version number is
> declared in the module's pom, it overrides the master's version number but
> there's a warning about this override.
> 
> Sounds good?  If so I'll do a quick change to move it over.
> 
> --Alex

RE: [DISCUSS] maven dependencies...

[Alex Huang]

Thanks for pointing that out.  I think the latest fixed this.

--Alex

> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: Monday, July 29, 2013 10:45 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] maven dependencies...
> 
> Is it correct for dependencies to appear twice in the base pom.xml?
> 
> E.g. mysql-connector-java
> 
> > -Original Message-
> > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > Sent: 26 July 2013 11:10 PM
> > To: dev@cloudstack.apache.org
> > Subject: [DISCUSS] maven dependencies...
> >
> > Everyone,
> >
> > After looking around in the maven documentation, I realized the way we
> > are specifying dependencies is not quite right for a large project such as
> ours.
> >
> > Currently, almost every project declare their own dependencies and
> > version number of the dependent jar.  For those of us who are
> > conscious of the version number properties declared in the cloudstack
> > pom file, we follow that example but in many places, the version
> > numbers are actually hard coded, probably because the writer is not aware
> of this.
> >
> > Maven actually has a way to do this.  In the master pom file, we can
> > declare in the  tags all of the third party
> > dependencies we need and their version numbers.  And then each
> > individual module can declare their dependency without version number,
> > which defaults to the version declared by CloudStack's master pom.  If
> > a version number is declared in the module's pom, it overrides the
> > master's version number but there's a warning about this override.
> >
> > Sounds good?  If so I'll do a quick change to move it over.
> >
> > --Alex

Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13022/#review24151
---


Review 13022 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #73 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/73/

- Jenkins Cloudstack.org


On July 29, 2013, 5:14 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13022/
> ---
> 
> (Updated July 29, 2013, 5:14 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: Cloustack-3910
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
> https://issues.apache.org/jira/browse/CLOUDSTACK-3910
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 
>   setup/db/db/schema-410to420.sql 7377cbd 
> 
> Diff: https://reviews.apache.org/r/13022/diff/
> 
> 
> Testing
> ---
> 
> Tested upgrade from 3.0.6 to 4.2
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/#review24152
---


Review 13020 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #74 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/74/

- Jenkins Cloudstack.org


On July 29, 2013, 3:58 p.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13020/
> ---
> 
> (Updated July 29, 2013, 3:58 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Kishan Kavala.
> 
> 
> Bugs: 3252
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> If an instance is deployed using explicit or implicit dedication, or neither 
> of them a usage event isn't generated. 
> Added 2 new usage_events : 
> EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
> generated when VMs are deployed using corresponding dedications.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/event/EventTypes.java 6f1eed6 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e 
> 
> Diff: https://reviews.apache.org/r/13020/diff/
> 
> 
> Testing
> ---
> 
> usage_events table has now entries for new types:
> select * from usage_event where type like "VM%CREATE%"
>id: 25
>  type: VM.CREATE.IMPLICIT
>account_id: 2
>   created: 2013-07-29 15:46:36
>   zone_id: 1
>   resource_id: 7
> resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
>   offering_id: 15
>   template_id: 5
>  size: NULL
> resource_type: XenServer
> processed: 0
>  virtual_size: NULL
> 
> 
> Build passed.
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

4.2 and 4.1 non-oss

[Ian Duffy]

Hi,

Just wondering, is there a reason we don't have non-oss
packages(deb,rpm) building of 4.1 and 4.2 on jenkins?

RE: Create Affinity Group API

[Prachi Damle]

I cannot reproduce this using latest 4.2. Updated the bug with details of tests.

Is this only seen when using automation tests?

Prachi

From: Girish Shilamkar [mailto:gir...@clogeny.com]
Sent: Monday, July 29, 2013 12:04 AM
To: dev@cloudstack.apache.org; Prachi Damle
Cc: Prasanna Santhanam
Subject: Create Affinity Group API

Hello,

While testing Affinity Groups feature I found that createAffinityGroups API 
does not return "id" in response.

2013-07-29 12:17:16,641 INFO  [cloud.api.ApiServer] (catalina-exec-24:null) 
(userId=2 accountId=2 sessionId=72E8E1EE5D2EC61E90BE7F944D3EA4FC) 
192.168.100.53 -- GET 
command=createAffinityGroup&response=json&sessionkey=Hdq5ogh%2Fc2A5PXXrJDNd2SkwBvU%3D&name=Test_g&type=host+anti-affinity&_=1375080436560
 200 { "createaffinitygroupresponse" : 
{"id":"366e51ce-ce6d-41d9-9ea1-dfd932962bdc","jobid":"fba998cc-9285-421b-9a57-8fd3f9fae7a4"}
 }
2013-07-29 12:17:19,668 INFO  [cloud.api.ApiServer] (catalina-exec-21:null) 
(userId=2 accountId=2 sessionId=72E8E1EE5D2EC61E90BE7F944D3EA4FC) 
192.168.100.53 -- GET 
command=queryAsyncJobResult&jobId=fba998cc-9285-421b-9a57-8fd3f9fae7a4&response=json&sessionkey=Hdq5ogh%2Fc2A5PXXrJDNd2SkwBvU%3D&_=1375080439598
 200 { "queryasyncjobresultresponse" : 
{"accountid":"4bc23192-f4f5-11e2-bf57-005056860002","userid":"4bc28d0e-f4f5-11e2-bf57-005056860002","cmd":"org.apache.cloudstack.api.command.user.affinitygroup.CreateAffinityGroupCmd","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"affinitygroup":{"name":"Test_g","account":"admin","domainid":"3d051818-f4f5-11e2-bf57-005056860002","domain":"ROOT","type":"host
 
anti-affinity"}},"created":"2013-07-29T12:17:16+0530","jobid":"fba998cc-9285-421b-9a57-8fd3f9fae7a4"}
 }

I have filed a defect for it.  
https://issues.apache.org/jira/browse/CLOUDSTACK-3889

Regards,
Girish

Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/
---

(Updated July 29, 2013, 6:19 p.m.)


Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den 
Hollander.


Changes
---

Folowup fix for CLOUDSTACK-2133


Bugs: CLOUDSTACK-2133


Repository: cloudstack-git


Description
---

The Cisco VNMC xml files are present under 
plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files 
present there needs to be included in the build package.


Diffs
-

  packaging/centos63/cloud.spec 61e00bd 

Diff: https://reviews.apache.org/r/12912/diff/


Testing
---

Tested 


File Attachments (updated)


updated with file permission from agent to common
  
https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch


Thanks,

Rayees Namathponnan

Can you take a look at CLOUDSTACK-3229?

[Min Chen]

Hi John,

Tom filed a blocker defect 
https://issues.apache.org/jira/browse/CLOUDSTACK-3229 related to s3xen plugin? 
It is related to https://issues.apache.org/jira/browse/CLOUDSTACK-2583 you 
recently fixed. Can you please take a look at the bug? I am not clear about any 
extra step required for setting up s3xen plugin on devcloud, on his system, it 
complained about s3xen is missing.

Thanks
-min

Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24157
---


Review 12912 PASSED the build test
The url of build cloudstack-master-with-patch #75 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/75/

- Jenkins Cloudstack.org


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> ---
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den 
> Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The Cisco VNMC xml files are present under 
> plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files 
> present there needs to be included in the build package.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> updated with file permission from agent to common
>   
> https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: 4.2 and 4.1 non-oss

[David Nalley]

Not that I am aware of. Feel free to male it so.
On Jul 29, 2013 2:11 PM, "Ian Duffy"  wrote:

> Hi,
>
> Just wondering, is there a reason we don't have non-oss
> packages(deb,rpm) building of 4.1 and 4.2 on jenkins?
>

Re: 4.2 and 4.1 non-oss

[David Nalley]

Bah. Autocorrect. Make.
On Jul 29, 2013 3:15 PM, "David Nalley"  wrote:

> Not that I am aware of. Feel free to male it so.
> On Jul 29, 2013 2:11 PM, "Ian Duffy"  wrote:
>
>> Hi,
>>
>> Just wondering, is there a reason we don't have non-oss
>> packages(deb,rpm) building of 4.1 and 4.2 on jenkins?
>>
>

Review Request 13025: Creating is mis-spelled in CreateFirewallRuleCmd

[Jonathan Creasy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-3915


Repository: cloudstack-git


Description
---

Fixing a typo in the firewall creation rule script.


Diffs
-

  
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
 ff8e283 

Diff: https://reviews.apache.org/r/13025/diff/


Testing
---

Ran it, seems to work.


Thanks,

Jonathan Creasy

Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in CreateFirewallRuleCmd

[Jonathan Creasy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/
---

(Updated July 29, 2013, 7:20 p.m.)


Review request for cloudstack.


Summary (updated)
-

Bugfix CLOUDSTACK-3915: Creating is mis-spelled in CreateFirewallRuleCmd


Bugs: CLOUDSTACK-3915


Repository: cloudstack-git


Description
---

Fixing a typo in the firewall creation rule script.


Diffs
-

  
api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
 ff8e283 

Diff: https://reviews.apache.org/r/13025/diff/


Testing
---

Ran it, seems to work.


Thanks,

Jonathan Creasy

deploydb jdbc/mysql connector error?

[Vijayendra Bhamidipati]

After rebasing my code against the latest master/4.2, I'm running into this 
error when doing a " mvn -e -P developer -pl developer -Ddeploydb " across 
master and 4.2 :

> WARNING: Provided file does not exist: 
/root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-prefill.sql.override
> Initializing database=cloud with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `cloud`
SQL exception in trying initDB: java.sql.SQLException: No suitable driver found 
for jdbc:mysql://localhost:3306/
[root@vijay-vm1 cloudstack]#


Is anyone else also seeing this? If not, has anyone seen this and can suggest a 
resolution??

I tried the operation on a clean new workspace and still see this error. I 
don't think it has anything to do with any recent checkin - something must've 
changed in my setup, but again I didn't do anything out of the ordinary.

Thanks!
Regards,
Vijay

RE: Review Request 13025: Creating is mis-spelled in CreateFirewallRuleCmd

[Donal Lafferty]

Ironically, there's no hyphen in 'misspelled'  :)

> -Original Message-
> From: Jonathan Creasy [mailto:nore...@reviews.apache.org] On Behalf Of
> Jonathan Creasy
> Sent: 29 July 2013 8:19 PM
> To: cloudstack; Jonathan Creasy
> Subject: Review Request 13025: Creating is mis-spelled in
> CreateFirewallRuleCmd
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> ---
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3915
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing a typo in the firewall creation rule script.
> 
> 
> Diffs
> -
> 
> 
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallR
> uleCmd.java ff8e283
> 
> Diff: https://reviews.apache.org/r/13025/diff/
> 
> 
> Testing
> ---
> 
> Ran it, seems to work.
> 
> 
> Thanks,
> 
> Jonathan Creasy

RE: deploydb jdbc/mysql connector error?

[Vijayendra Bhamidipati]

Prachi and I had a look at this, I should have pasted the entire output of the 
deploydb command - in Prachi's env we see that the mysql-connector.jar is 
getting copied over to the deps/ directory, but I see this warning in the 
beginning when I run deploydb:


[WARNING] Some problems were encountered while building the effective model for 
org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
[WARNING] 
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
version ${cs.mysql.version} @ org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
/root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, column 19
[WARNING]
[WARNING] Some problems were encountered while building the effective model for 
org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
[WARNING] 
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
version ${cs.mysql.version} @ line 278, column 19
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten 
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.
[WARNING]


Any idea why this is happening?


The complete output is pasted below:

[root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer -Ddeploydb
Listening for transport dt_socket at address: 8787
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for 
org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
[WARNING] 
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
version ${cs.mysql.version} @ org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
/root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, column 19
[WARNING]
[WARNING] Some problems were encountered while building the effective model for 
org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
[WARNING] 
'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
version ${cs.mysql.version} @ line 278, column 19
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten 
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.
[WARNING]
[INFO]
[INFO] 
[INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT
[INFO] 
[INFO]
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
(default) @ cloud-developer ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-developer ---
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO]
[INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer >>>
[INFO]
[INFO] <<< exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer <<<
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer ---
log4j:WARN No appenders could be found for logger 
(org.springframework.core.env.StandardEnvironment).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
> WARNING: Provided file does not exist: 
/root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-prefill.sql.override
> Initializing database=cloud with host=localhost port=3306 
username=cloud password=cloud
> Running query: drop database if exists `cloud`
SQL exception in trying initDB: java.sql.SQLException: No suitable driver found 
for jdbc:mysql://localhost:3306/
[root@vijay-vm1 cloudstack]#


Regards,
Vijay





-Original Message-
From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com] 
Sent: Monday, July 29, 2013 12:32 PM
To: dev@cloudstack.apache.org
Subject: deploydb jdbc/mysql connector error?

After rebasing my code against the latest master/4.2, I'm running into this 
error when doing a " mvn -e -P developer -pl developer -Ddeploydb " across 
master and 4.2 :

> WARNING: Provided file does not exist: 
/root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-prefill.sql.override
> Initializing database=cloud with host=localhost port=3306 
username=cloud password=cloud > Running query: drop database if 
exists `cloud` SQL exception in trying initDB: java.sql.SQLException: No 
suitable driver found for jdbc:mysql://localh

Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in CreateFirewallRuleCmd

[Jenkins Cloudstack.org]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13025/#review24160
---


Review 13025 PASSED the build test
The url of build cloudstack-master-with-patch #76 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/76/

- Jenkins Cloudstack.org


On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> ---
> 
> (Updated July 29, 2013, 7:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3915
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing a typo in the firewall creation rule script.
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
>  ff8e283 
> 
> Diff: https://reviews.apache.org/r/13025/diff/
> 
> 
> Testing
> ---
> 
> Ran it, seems to work.
> 
> 
> Thanks,
> 
> Jonathan Creasy
> 
>

Re: Review Request 13025: Creating is mis-spelled in CreateFirewallRuleCmd

[Jonathan Creasy]

Indeed. :) 

- Original Message -
From: "Donal Lafferty" 
To: "dev@cloudstack.apache.org" , "Jonathan Creasy" 
, "cloudstack" 
Sent: Monday, July 29, 2013 2:34:59 PM
Subject: RE: Review Request 13025: Creating is mis-spelled in 
CreateFirewallRuleCmd

Ironically, there's no hyphen in 'misspelled'  :)

> -Original Message-
> From: Jonathan Creasy [mailto:nore...@reviews.apache.org] On Behalf Of
> Jonathan Creasy
> Sent: 29 July 2013 8:19 PM
> To: cloudstack; Jonathan Creasy
> Subject: Review Request 13025: Creating is mis-spelled in
> CreateFirewallRuleCmd
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13025/
> ---
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3915
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing a typo in the firewall creation rule script.
> 
> 
> Diffs
> -
> 
> 
> api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallR
> uleCmd.java ff8e283
> 
> Diff: https://reviews.apache.org/r/13025/diff/
> 
> 
> Testing
> ---
> 
> Ran it, seems to work.
> 
> 
> Thanks,
> 
> Jonathan Creasy

Re: Review Request 12849: added backwards compatibility code to Networks enums

[Toshiaki Hatano]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24161
---


I tested this patch locally, VLAN isolated advanced zone with 1 KVM hypervisor. 
Confirmed this patch resolve bug 
https://issues.apache.org/jira/browse/CLOUDSTACK-3682

Thanks!

- Toshiaki Hatano


On July 23, 2013, 10:02 a.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12849/
> ---
> 
> (Updated July 23, 2013, 10:02 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Both BroadcastDomainType and IsolationType needed some extra code for 
> backwards compatibility
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Networks.java c76c3d4 
>   
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
>  6fafa3e 
> 
> Diff: https://reviews.apache.org/r/12849/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

RE: CloudStack Compile Error

[Donal Lafferty]

FYI, this happens when you accidentally install different versions of Java for 
compile and runtime.  

E.g.

Compile with javac...

root@mgmtserver:~/github/cshv3/tools/apidoc# which javac
/usr/bin/javac
root@mgmtserver:~/github/cshv3/tools/apidoc# ls -al /usr/bin/javac
lrwxrwxrwx 1 root root 23 Jul 16 19:58 /usr/bin/javac -> /etc/alternatives/javac
root@mgmtserver:~/github/cshv3/tools/apidoc# ls -al /etc/alternatives/javac
lrwxrwxrwx 1 root root 43 Jul 16 19:58 /etc/alternatives/javac -> 
/usr/lib/jvm/java-7-openjdk-amd64/bin/javac


Run with java...

root@mgmtserver:~/github/cshv3/tools/apidoc# which java
/usr/bin/java
root@mgmtserver:~/github/cshv3/tools/apidoc# ls -al /usr/bin/java
lrwxrwxrwx 1 root root 22 Jul 16 17:15 /usr/bin/java -> /etc/alternatives/java
root@mgmtserver:~/github/cshv3/tools/apidoc# ls -al /etc/alternatives/java
lrwxrwxrwx 1 root root 46 Jul 16 17:15 /etc/alternatives/java -> 
/usr/lib/jvm/java-6-openjdk-amd64/jre/bin/java



Fix?

In my case, I wanted to try out the version 7 JRE.

 sudo apt-get install openjdk-7-jre

This wasn't enough.  I also had to purge the version 6 JRE

 apt-get purge openjdk-6-*

Sources:  

http://stackoverflow.com/questions/11239086/java-lang-unsupportedclassversionerror-unsupported-major-minor-version-51-0
http://openjdk.java.net/install/
http://askubuntu.com/questions/64329/how-to-replace-openjdk-6-with-openjdk-7

> -Original Message-
> From: MEHDI ALI SOLTANI [mailto:mehdi_alisolt...@yahoo.com]
> Sent: 10 May 2013 5:01 PM
> To: dev@cloudstack.apache.org
> Subject: CloudStack Compile Error
> 
> Hi
> I used mvn clean install -P developer,systemvm according to
> https://cwiki.apache.org/CLOUDSTACK/how-to-build-on-master-
> branch.html
> but i got this error
> .
> .
> .
> Exception in thread "main" java.lang.UnsupportedClassVersionError:
> XmlToHtmlConverter : Unsupported major.minor version 51.0 at
> java.lang.ClassLoader.defineClass1(Native Method) at
> java.lang.ClassLoader.defineClass(ClassLoader.java:634)
> at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
> at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
> at java.security.AccessController.doPrivileged(Native Method) at
> java.net.URLClassLoader.findClass(URLClassLoader.java:205)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:321)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:266)
> Could not find the main class: XmlToHtmlConverter. Program will exit.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache CloudStack . SUCCESS [6.625s] 
> [INFO]
> Apache CloudStack Utils ... SUCCESS [27.954s] [INFO] 
> Apache
> CloudStack API . SUCCESS [25.212s] [INFO] Apache
> CloudStack Framework ... SUCCESS [0.163s] 
> 
> ...
> INFO] Apache CloudStack Developer Tools . SUCCESS [0.159s]
> [INFO] Apache CloudStack apidocs . FAILURE [16.577s] 
> [INFO]
> Apache CloudStack marvin .. SKIPPED [INFO] Apache
> CloudStack cloudmonkey cli . SKIPPED [INFO] Apache CloudStack
> DevCloud  SKIPPED [INFO] Apache CloudStack DevCloud-
> KVM  SKIPPED [INFO] 
> ---
> -
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 10:53.864s
> [INFO] Finished at: Fri May 10 20:21:00 IRDT 2013 [INFO] Final Memory:
> 47M/329M [INFO] 
> ---
> -
> [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-
> plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution
> failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1] [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionExcepti
> on
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command [ERROR]   mvn  -rf :cloud-apidoc
> 
> I tested it without developer    mvn clean install -P systemvm
> 
> but, again i got the same error.
> please tell me how I can fix this error.
> 
> Sincerely
> Mehdi Ali Soltani

Re: deploydb jdbc/mysql connector error?

[Ian Duffy]

I'm having this issue too when trying to do deploydb on master. Its
working fine on a slightly older branch.

On 29 July 2013 20:53, Vijayendra Bhamidipati
 wrote:
> Prachi and I had a look at this, I should have pasted the entire output of 
> the deploydb command - in Prachi's env we see that the mysql-connector.jar is 
> getting copied over to the deps/ directory, but I see this warning in the 
> beginning when I run deploydb:
>
>
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
>  must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
> version ${cs.mysql.version} @ 
> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, column 19
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
>  must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
> version ${cs.mysql.version} @ line 278, column 19
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
>
>
> Any idea why this is happening?
>
>
> The complete output is pasted below:
>
> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer -Ddeploydb
> Listening for transport dt_socket at address: 8787
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
>  must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
> version ${cs.mysql.version} @ 
> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, column 19
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
>  must be unique: mysql:mysql-connector-java:jar -> duplicate declaration of 
> version ${cs.mysql.version} @ line 278, column 19
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO]
> [INFO] 
> 
> [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT
> [INFO] 
> 
> [INFO]
> [INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (default) @ cloud-developer ---
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
> cloud-developer ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ cloud-developer ---
> [INFO] Executing tasks
>
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer >>>
> [INFO]
> [INFO] <<< exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer <<<
> [INFO]
> [INFO] --- exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer ---
> log4j:WARN No appenders could be found for logger 
> (org.springframework.core.env.StandardEnvironment).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
> info.
> > WARNING: Provided file does not exist: 
> /root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-prefill.sql.override
> > Initializing database=cloud with host=localhost port=3306 
> username=cloud password=cloud
> > Running query: drop database if exists `cloud`
> SQL exception in trying initDB: java.sql.SQLException: No suitable driver 
> found for jdbc:mysql://localhost:3306/
> [root@vijay-vm1 cloudstack]#
>
>
> Regards,
> Vijay
>
>
>
>
>
> -Original Message-
> From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com]
> Sent: Monday, July 29, 2013 12:32 PM
> To: dev@cloudstack.apache.org
> Subject: deploydb jdbc/mysql connector error?
>
> After rebasing my code against the latest master/4.2, I'm running into this 
> error when doing a " mvn -e -P developer -pl developer -Ddeploydb " across 
> master and 4.2 :
>
> > WARN

RE: deploydb jdbc/mysql connector error?

[Vijayendra Bhamidipati]

I see! What commit # are you on? I'd rather use the same one to get by for now 
until this is fixed.

Regards,
Vijay

-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie] 
Sent: Monday, July 29, 2013 1:16 PM
To: dev@cloudstack.apache.org
Subject: Re: deploydb jdbc/mysql connector error?

I'm having this issue too when trying to do deploydb on master. Its working 
fine on a slightly older branch.

On 29 July 2013 20:53, Vijayendra Bhamidipati 
 wrote:
> Prachi and I had a look at this, I should have pasted the entire output of 
> the deploydb command - in Prachi's env we see that the mysql-connector.jar is 
> getting copied over to the deps/ directory, but I see this warning in the 
> beginning when I run deploydb:
>
>
> [WARNING] Some problems were encountered while building the effective 
> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
> :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
> duplicate declaration of version ${cs.mysql.version} @ 
> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, 
> column 19 [WARNING] [WARNING] Some problems were encountered while 
> building the effective model for 
> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
> :classifier)' must be unique: mysql:mysql-connector-java:jar -> duplicate 
> declaration of version ${cs.mysql.version} @ line 278, column 19 [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
>
>
> Any idea why this is happening?
>
>
> The complete output is pasted below:
>
> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer 
> -Ddeploydb Listening for transport dt_socket at address: 8787 [INFO] 
> Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective 
> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
> :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
> duplicate declaration of version ${cs.mysql.version} @ 
> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT, 
> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, 
> column 19 [WARNING] [WARNING] Some problems were encountered while 
> building the effective model for 
> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
> [WARNING] 
> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
> :classifier)' must be unique: mysql:mysql-connector-java:jar -> duplicate 
> declaration of version ${cs.mysql.version} @ line 278, column 19 [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING]
> [INFO]
> [INFO] 
> --
> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT 
> [INFO] 
> --
> --
> [INFO]
> [INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (default) @ cloud-developer --- [INFO] [INFO] --- 
> maven-remote-resources-plugin:1.3:process (default) @ cloud-developer 
> --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (default) @ 
> cloud-developer --- [INFO] Executing tasks
>
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @ 
> cloud-developer >>> [INFO] [INFO] <<< exec-maven-plugin:1.2.1:java 
> (create-schema) @ cloud-developer <<< [INFO] [INFO] --- 
> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer --- 
> log4j:WARN No appenders could be found for logger 
> (org.springframework.core.env.StandardEnvironment).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
> info.
> > WARNING: Provided file does not exist: 
> /root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-pref
> ill.sql.override > Initializing database=cloud with 
> host=localhost port=3306 username=cloud password=cloud > 
> Running query: drop database if exists `cloud` SQL exception in trying 
> initDB: java.sql.SQLException: No suitable driver found for 
> jdbc:mysql://localhost:3306/
> [root@vijay-vm1 cloudstack]#
>
>
> Regards,
> Vijay
>
>
>
>
>
> -Original Message-
> From: Vijayendra Bhamidipati 
> [mailto:vijayendra.bhamidip...@citrix.

Re: deploydb jdbc/mysql connector error?

[Ian Duffy]

1f64354ec830db6e30c17ec6e4a6d8c33f2e10da few days old.

On 29 July 2013 21:20, Vijayendra Bhamidipati
 wrote:
> I see! What commit # are you on? I'd rather use the same one to get by for 
> now until this is fixed.
>
> Regards,
> Vijay
>
> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Monday, July 29, 2013 1:16 PM
> To: dev@cloudstack.apache.org
> Subject: Re: deploydb jdbc/mysql connector error?
>
> I'm having this issue too when trying to do deploydb on master. Its working 
> fine on a slightly older branch.
>
> On 29 July 2013 20:53, Vijayendra Bhamidipati 
>  wrote:
>> Prachi and I had a look at this, I should have pasted the entire output of 
>> the deploydb command - in Prachi's env we see that the mysql-connector.jar 
>> is getting copied over to the deps/ directory, but I see this warning in the 
>> beginning when I run deploydb:
>>
>>
>> [WARNING] Some problems were encountered while building the effective
>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
>> :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>> duplicate declaration of version ${cs.mysql.version} @
>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
>> column 19 [WARNING] [WARNING] Some problems were encountered while
>> building the effective model for
>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
>> :classifier)' must be unique: mysql:mysql-connector-java:jar -> duplicate 
>> declaration of version ${cs.mysql.version} @ line 278, column 19 [WARNING] 
>> [WARNING] It is highly recommended to fix these problems because they 
>> threaten the stability of your build.
>> [WARNING]
>> [WARNING] For this reason, future Maven versions might no longer support 
>> building such malformed projects.
>> [WARNING]
>>
>>
>> Any idea why this is happening?
>>
>>
>> The complete output is pasted below:
>>
>> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer
>> -Ddeploydb Listening for transport dt_socket at address: 8787 [INFO]
>> Error stacktraces are turned on.
>> [INFO] Scanning for projects...
>> [WARNING]
>> [WARNING] Some problems were encountered while building the effective
>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
>> :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>> duplicate declaration of version ${cs.mysql.version} @
>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
>> column 19 [WARNING] [WARNING] Some problems were encountered while
>> building the effective model for
>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type
>> :classifier)' must be unique: mysql:mysql-connector-java:jar -> duplicate 
>> declaration of version ${cs.mysql.version} @ line 278, column 19 [WARNING] 
>> [WARNING] It is highly recommended to fix these problems because they 
>> threaten the stability of your build.
>> [WARNING]
>> [WARNING] For this reason, future Maven versions might no longer support 
>> building such malformed projects.
>> [WARNING]
>> [INFO]
>> [INFO]
>> --
>> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT
>> [INFO]
>> --
>> --
>> [INFO]
>> [INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties
>> (default) @ cloud-developer --- [INFO] [INFO] ---
>> maven-remote-resources-plugin:1.3:process (default) @ cloud-developer
>> --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (default) @
>> cloud-developer --- [INFO] Executing tasks
>>
>> main:
>> [INFO] Executed tasks
>> [INFO]
>> [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @
>> cloud-developer >>> [INFO] [INFO] <<< exec-maven-plugin:1.2.1:java
>> (create-schema) @ cloud-developer <<< [INFO] [INFO] ---
>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer ---
>> log4j:WARN No appenders could be found for logger 
>> (org.springframework.core.env.StandardEnvironment).
>> log4j:WARN Please initialize the log4j system properly.
>> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
>> more info.
>> > WARNING: Provided file does not exist:
>> /root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-pref
>> ill.sql.override > Initializing database=cloud with
>> host=localhost port=3306 username=cloud password=cloud >
>> Running query: drop database if exists `cloud` SQL exception in trying
>> initDB: java.sql.SQLException: No suitable driver found for
>

Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24166
---


Commit a5d17c8dc76ee10de0e74bcd668e135579cb630e in branch refs/heads/master 
from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a5d17c8 ]

CLOUDSTACK-2133 - Cisco VNMC xml need copy to 
plugins/network-elements/cisco-vnmc/scripts/network/cisco during installation


- ASF Subversion and Git Services


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> ---
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den 
> Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The Cisco VNMC xml files are present under 
> plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files 
> present there needs to be included in the build package.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> updated with file permission from agent to common
>   
> https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request 13003: Adding packaging support for RHEL 5 and 6.2

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13003/#review24167
---

Ship it!


Ship It!

- edison su


On July 28, 2013, 1:14 a.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13003/
> ---
> 
> (Updated July 28, 2013, 1:14 a.m.)
> 
> 
> Review request for cloudstack, edison su, Frank Zhang, Hugo Trippaers, and 
> Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> There are hard coded values for python version in cloud.spec;  it need to be 
> generic to support RHEL 5, since RHEL 5  having Python 2.4 not 2.6
> 
> 
> Packaging.sh updated to support RHEL 6.2 and 5,  
> 
> RPM  build failing rhel6.2 and 5, since -D_topdir pointing to 
> /usr/src/redhat/SOURCES; fixed this also 
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
>   packaging/centos63/package.sh c466f58 
> 
> Diff: https://reviews.apache.org/r/13003/diff/
> 
> 
> Testing
> ---
> 
> Tested with RHEL 6.3 and RHEL 5.4
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24168
---

Ship it!


Ship It!

- edison su


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> ---
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den 
> Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The Cisco VNMC xml files are present under 
> plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files 
> present there needs to be included in the build package.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> updated with file permission from agent to common
>   
> https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12912/#review24169
---


Commit 97c9a9664f0a62101f022ef5a25de1c7082ff669 in branch refs/heads/4.2 from 
rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97c9a96 ]

CLOUDSTACK-2133 - Cisco VNMC xml need copy to 
plugins/network-elements/cisco-vnmc/scripts/network/cisco during installation


- ASF Subversion and Git Services


On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12912/
> ---
> 
> (Updated July 29, 2013, 6:19 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den 
> Hollander.
> 
> 
> Bugs: CLOUDSTACK-2133
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The Cisco VNMC xml files are present under 
> plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files 
> present there needs to be included in the build package.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 61e00bd 
> 
> Diff: https://reviews.apache.org/r/12912/diff/
> 
> 
> Testing
> ---
> 
> Tested 
> 
> 
> File Attachments
> 
> 
> updated with file permission from agent to common
>   
> https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

RE: [DISCUSS] maven dependencies...

[Donal Lafferty]

Could you also have a look at ./client/tomcatconf/log4j-cloud.xml.in?

It looks like it was updated in the refactor.

AFAIK, in '', {1.} should be {1}.

See "Conversion Character" chart under 
http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html 

There's a lot of paper work for me to make the update :(

DL



> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: 29 July 2013 6:56 PM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] maven dependencies...
> 
> Thanks for pointing that out.  I think the latest fixed this.
> 
> --Alex
> 
> > -Original Message-
> > From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> > Sent: Monday, July 29, 2013 10:45 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [DISCUSS] maven dependencies...
> >
> > Is it correct for dependencies to appear twice in the base pom.xml?
> >
> > E.g. mysql-connector-java
> >
> > > -Original Message-
> > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > Sent: 26 July 2013 11:10 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: [DISCUSS] maven dependencies...
> > >
> > > Everyone,
> > >
> > > After looking around in the maven documentation, I realized the way
> > > we are specifying dependencies is not quite right for a large
> > > project such as
> > ours.
> > >
> > > Currently, almost every project declare their own dependencies and
> > > version number of the dependent jar.  For those of us who are
> > > conscious of the version number properties declared in the
> > > cloudstack pom file, we follow that example but in many places, the
> > > version numbers are actually hard coded, probably because the writer
> > > is not aware
> > of this.
> > >
> > > Maven actually has a way to do this.  In the master pom file, we can
> > > declare in the  tags all of the third party
> > > dependencies we need and their version numbers.  And then each
> > > individual module can declare their dependency without version
> > > number, which defaults to the version declared by CloudStack's
> > > master pom.  If a version number is declared in the module's pom, it
> > > overrides the master's version number but there's a warning about this
> override.
> > >
> > > Sounds good?  If so I'll do a quick change to move it over.
> > >
> > > --Alex

RE: deploydb jdbc/mysql connector error?

[Vijayendra Bhamidipati]

Thanks Ian! I'll give that a try.

Regards,
Vijay

-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie] 
Sent: Monday, July 29, 2013 1:27 PM
To: dev@cloudstack.apache.org
Subject: Re: deploydb jdbc/mysql connector error?

1f64354ec830db6e30c17ec6e4a6d8c33f2e10da few days old.

On 29 July 2013 21:20, Vijayendra Bhamidipati 
 wrote:
> I see! What commit # are you on? I'd rather use the same one to get by for 
> now until this is fixed.
>
> Regards,
> Vijay
>
> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Monday, July 29, 2013 1:16 PM
> To: dev@cloudstack.apache.org
> Subject: Re: deploydb jdbc/mysql connector error?
>
> I'm having this issue too when trying to do deploydb on master. Its working 
> fine on a slightly older branch.
>
> On 29 July 2013 20:53, Vijayendra Bhamidipati 
>  wrote:
>> Prachi and I had a look at this, I should have pasted the entire output of 
>> the deploydb command - in Prachi's env we see that the mysql-connector.jar 
>> is getting copied over to the deps/ directory, but I see this warning in the 
>> beginning when I run deploydb:
>>
>>
>> [WARNING] Some problems were encountered while building the effective 
>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>> e :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
>> duplicate declaration of version ${cs.mysql.version} @ 
>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, 
>> column 19 [WARNING] [WARNING] Some problems were encountered while 
>> building the effective model for 
>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>> e :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 19 
>> [WARNING] [WARNING] It is highly recommended to fix these problems because 
>> they threaten the stability of your build.
>> [WARNING]
>> [WARNING] For this reason, future Maven versions might no longer support 
>> building such malformed projects.
>> [WARNING]
>>
>>
>> Any idea why this is happening?
>>
>>
>> The complete output is pasted below:
>>
>> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer 
>> -Ddeploydb Listening for transport dt_socket at address: 8787 [INFO] 
>> Error stacktraces are turned on.
>> [INFO] Scanning for projects...
>> [WARNING]
>> [WARNING] Some problems were encountered while building the effective 
>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>> e :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
>> duplicate declaration of version ${cs.mysql.version} @ 
>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278, 
>> column 19 [WARNING] [WARNING] Some problems were encountered while 
>> building the effective model for 
>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>> [WARNING]
>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>> e :classifier)' must be unique: mysql:mysql-connector-java:jar -> 
>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 19 
>> [WARNING] [WARNING] It is highly recommended to fix these problems because 
>> they threaten the stability of your build.
>> [WARNING]
>> [WARNING] For this reason, future Maven versions might no longer support 
>> building such malformed projects.
>> [WARNING]
>> [INFO]
>> [INFO]
>> -
>> -
>> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT 
>> [INFO]
>> -
>> -
>> --
>> [INFO]
>> [INFO] --- 
>> properties-maven-plugin:1.0-alpha-2:read-project-properties
>> (default) @ cloud-developer --- [INFO] [INFO] --- 
>> maven-remote-resources-plugin:1.3:process (default) @ cloud-developer
>> --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (default) @ 
>> cloud-developer --- [INFO] Executing tasks
>>
>> main:
>> [INFO] Executed tasks
>> [INFO]
>> [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @ 
>> cloud-developer >>> [INFO] [INFO] <<< exec-maven-plugin:1.2.1:java
>> (create-schema) @ cloud-developer <<< [INFO] [INFO] --- 
>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer --- 
>> log4j:WARN No appenders could be found for logger 
>> (org.springframework.core.env.StandardEnvironment).
>> log4j:WARN Please initialize the log4j system properly.
>> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
>> more info.
>> > WARNING: Provided file does not exist:
>> /root/mywork/cloudstack/asf/latest/cloudstack/developer/developer-pre

Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

[Kelven Yang]

> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote:
> > Review 13008 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #65 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/
> 
> Venkata Siva Vijayendra Bhamidipati wrote:
> This patch is for 4.2 and has been tested on 4.2 as described - the patch 
> will not apply on the master branch. The above failure message is for master 
> branch. Requesting reviewers to review patch for 4.2.

It would be better to use existing custom field facility to tag attributes to 
vCenter objects. Since content of object annotation in vCenter is plain string 
leterals, we can't store information there in a structural way, which will lead 
us to add additional logic to enable sharing annotation field from mulitple 
sources.

Another problem with using annotation is that since the field in vCenter is 
designed to allow vCenter administrators to label object with custom comments, 
it is editable in vCenter UI, if we use it for special control purpose, it will 
open a door for people to mess up CloudStack meta information stored in vCenter.

I would suggest to change to custom field facility


- Kelven


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24078
---


On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13008/
> ---
> 
> (Updated July 29, 2013, 1:55 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, 
> Sateesh Chodapuneedi, and William Chan.
> 
> 
> Bugs: CLOUDSTACK-3886
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The vminstancename flag has been incorrectly used to simply append the 
> displayname to the internal VM name that shows up on vCenter in vmware 
> deployments. It was intended to show the actual name supplied as hostname, on 
> the hypervisor. This helps admins and deployers to quickly identify VMs and 
> resolve issues related to those VMs. Its usage is very limited as it stands 
> now. This fix corrects it to ensure that the name of the VM on the hypervisor 
> matches the hostname if it is supplied, and if the vm.instancename.flag is 
> set to true.
> 
> 
> Diffs
> -
> 
>   
> engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
>  96fb1d9 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
> d1392c4 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
>  e5c33cc 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  439163a 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  02e4e64 
>   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> dd0f889 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> e2dd789 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
> ac14328 
> 
> Diff: https://reviews.apache.org/r/13008/diff/
> 
> 
> Testing
> ---
> 
> Post this change, all major VM operations, namely 
> creation/destruction/expunging/start/stop/reboot of the VM have been tested 
> and observed to work correctly. Part of this patch also puts in a fix for 
> VMSync operations where the CS mgmt server doesn't detect that a guest VM is 
> down, if the guest VM has been shut down/powered off in vCenter. Other 
> operations such as VM snapshot, volume snapshots of disks belonging to the 
> VM, volume migration across primaries, volume attach/detach have also been 
> tested and they are working as expected. This is a functional change, and 
> completely transparent to any of cloudstack's existing functionalities and 
> all the test cases that cover the above code paths and APIs - all existing 
> tests should and do pass - no new tests are necessary.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than "add" or "remove" per command

[Alena Prokharchyk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12905/#review24171
---


1) DataCenterVnetDaoImpl.java

deleteRange method.

List vnets - this type is very ambigous. How is it represented? 
100-200? 100,101,102,103? People are going to use this method, you either have 
to document it well, or use diff datastructure.

2) Not able to re-set the range back to NULL

3) The main concern:

createPhysicalNetwork should work just as updatePhysicalNetwork. Right now it 
fails:

http://localhost:8096/?command=createPhysicalNetwork&name=200&vlan=1-2,6-100&zoneId=1


431
4350
Please specify valid integers for the vlan range.


- Alena Prokharchyk


On July 26, 2013, 4:17 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12905/
> ---
> 
> (Updated July 26, 2013, 4:17 a.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
> 
> 
> Bugs: Cloudstack-3753
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3753
> Multiple VLAN range API need to accept a list rather than "add" or "remove" 
> per command
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/NetworkService.java 59ccdbf 
>   
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java
>  333564e 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 
>   server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a 
>   server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 
> 
> Diff: https://reviews.apache.org/r/12905/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> removed the removevlan parameter.
> vlan parameter can be used for both addition and removal of valns.
> instead of passing only a vlan range. user has to pass all the vlan ranges 
> that he wants to keep.
> the vlan ranges missing in the input and present in the db (not allocated) 
> will be removed.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: deploydb jdbc/mysql connector error?

[Ian Duffy]

Removing the scope line from 183 of the root pom.xml also seemed to
get it going again.

On 29 July 2013 21:41, Vijayendra Bhamidipati
 wrote:
> Thanks Ian! I'll give that a try.
>
> Regards,
> Vijay
>
> -Original Message-
> From: Ian Duffy [mailto:i...@ianduffy.ie]
> Sent: Monday, July 29, 2013 1:27 PM
> To: dev@cloudstack.apache.org
> Subject: Re: deploydb jdbc/mysql connector error?
>
> 1f64354ec830db6e30c17ec6e4a6d8c33f2e10da few days old.
>
> On 29 July 2013 21:20, Vijayendra Bhamidipati 
>  wrote:
>> I see! What commit # are you on? I'd rather use the same one to get by for 
>> now until this is fixed.
>>
>> Regards,
>> Vijay
>>
>> -Original Message-
>> From: Ian Duffy [mailto:i...@ianduffy.ie]
>> Sent: Monday, July 29, 2013 1:16 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: deploydb jdbc/mysql connector error?
>>
>> I'm having this issue too when trying to do deploydb on master. Its working 
>> fine on a slightly older branch.
>>
>> On 29 July 2013 20:53, Vijayendra Bhamidipati 
>>  wrote:
>>> Prachi and I had a look at this, I should have pasted the entire output of 
>>> the deploydb command - in Prachi's env we see that the mysql-connector.jar 
>>> is getting copied over to the deps/ directory, but I see this warning in 
>>> the beginning when I run deploydb:
>>>
>>>
>>> [WARNING] Some problems were encountered while building the effective
>>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>>> [WARNING]
>>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>>> duplicate declaration of version ${cs.mysql.version} @
>>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
>>> column 19 [WARNING] [WARNING] Some problems were encountered while
>>> building the effective model for
>>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>>> [WARNING]
>>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 19 
>>> [WARNING] [WARNING] It is highly recommended to fix these problems because 
>>> they threaten the stability of your build.
>>> [WARNING]
>>> [WARNING] For this reason, future Maven versions might no longer support 
>>> building such malformed projects.
>>> [WARNING]
>>>
>>>
>>> Any idea why this is happening?
>>>
>>>
>>> The complete output is pasted below:
>>>
>>> [root@vijay-vm1 cloudstack]# mvn -e -P developer -pl developer
>>> -Ddeploydb Listening for transport dt_socket at address: 8787 [INFO]
>>> Error stacktraces are turned on.
>>> [INFO] Scanning for projects...
>>> [WARNING]
>>> [WARNING] Some problems were encountered while building the effective
>>> model for org.apache.cloudstack:cloud-api:jar:4.2.0-SNAPSHOT
>>> [WARNING]
>>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>>> duplicate declaration of version ${cs.mysql.version} @
>>> org.apache.cloudstack:cloudstack:4.2.0-SNAPSHOT,
>>> /root/mywork/cloudstack/asf/latest/cloudstack/pom.xml, line 278,
>>> column 19 [WARNING] [WARNING] Some problems were encountered while
>>> building the effective model for
>>> org.apache.cloudstack:cloudstack:pom:4.2.0-SNAPSHOT
>>> [WARNING]
>>> 'dependencyManagement.dependencies.dependency.(groupId:artifactId:typ
>>> e :classifier)' must be unique: mysql:mysql-connector-java:jar ->
>>> duplicate declaration of version ${cs.mysql.version} @ line 278, column 19 
>>> [WARNING] [WARNING] It is highly recommended to fix these problems because 
>>> they threaten the stability of your build.
>>> [WARNING]
>>> [WARNING] For this reason, future Maven versions might no longer support 
>>> building such malformed projects.
>>> [WARNING]
>>> [INFO]
>>> [INFO]
>>> -
>>> -
>>> -- [INFO] Building Apache CloudStack Developer Mode 4.2.0-SNAPSHOT
>>> [INFO]
>>> -
>>> -
>>> --
>>> [INFO]
>>> [INFO] ---
>>> properties-maven-plugin:1.0-alpha-2:read-project-properties
>>> (default) @ cloud-developer --- [INFO] [INFO] ---
>>> maven-remote-resources-plugin:1.3:process (default) @ cloud-developer
>>> --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (default) @
>>> cloud-developer --- [INFO] Executing tasks
>>>
>>> main:
>>> [INFO] Executed tasks
>>> [INFO]
>>> [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema) @
>>> cloud-developer >>> [INFO] [INFO] <<< exec-maven-plugin:1.2.1:java
>>> (create-schema) @ cloud-developer <<< [INFO] [INFO] ---
>>> exec-maven-plugin:1.2.1:java (create-schema) @ cloud-developer ---
>>> log4j:WARN No appenders could be found for logger 
>>> (org.springframework.core.env.StandardEnvironment).
>>> log4j:WARN Please init

Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

[Venkata Siva Vijayendra Bhamidipati]

> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote:
> > Review 13008 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #65 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/
> 
> Venkata Siva Vijayendra Bhamidipati wrote:
> This patch is for 4.2 and has been tested on 4.2 as described - the patch 
> will not apply on the master branch. The above failure message is for master 
> branch. Requesting reviewers to review patch for 4.2.
> 
> Kelven Yang wrote:
> It would be better to use existing custom field facility to tag 
> attributes to vCenter objects. Since content of object annotation in vCenter 
> is plain string leterals, we can't store information there in a structural 
> way, which will lead us to add additional logic to enable sharing annotation 
> field from mulitple sources.
> 
> Another problem with using annotation is that since the field in vCenter 
> is designed to allow vCenter administrators to label object with custom 
> comments, it is editable in vCenter UI, if we use it for special control 
> purpose, it will open a door for people to mess up CloudStack meta 
> information stored in vCenter.
> 
> I would suggest to change to custom field facility
> 
> 
>

Thanks for the review Kelven! I'll try out the custom field instead of the 
annotation field and update the request with the new diffs.

Regards,
Vijay


- Venkata Siva Vijayendra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24078
---


On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13008/
> ---
> 
> (Updated July 29, 2013, 1:55 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, 
> Sateesh Chodapuneedi, and William Chan.
> 
> 
> Bugs: CLOUDSTACK-3886
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The vminstancename flag has been incorrectly used to simply append the 
> displayname to the internal VM name that shows up on vCenter in vmware 
> deployments. It was intended to show the actual name supplied as hostname, on 
> the hypervisor. This helps admins and deployers to quickly identify VMs and 
> resolve issues related to those VMs. Its usage is very limited as it stands 
> now. This fix corrects it to ensure that the name of the VM on the hypervisor 
> matches the hostname if it is supplied, and if the vm.instancename.flag is 
> set to true.
> 
> 
> Diffs
> -
> 
>   
> engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
>  96fb1d9 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
> d1392c4 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
>  e5c33cc 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  439163a 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  02e4e64 
>   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> dd0f889 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> e2dd789 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
> ac14328 
> 
> Diff: https://reviews.apache.org/r/13008/diff/
> 
> 
> Testing
> ---
> 
> Post this change, all major VM operations, namely 
> creation/destruction/expunging/start/stop/reboot of the VM have been tested 
> and observed to work correctly. Part of this patch also puts in a fix for 
> VMSync operations where the CS mgmt server doesn't detect that a guest VM is 
> down, if the guest VM has been shut down/powered off in vCenter. Other 
> operations such as VM snapshot, volume snapshots of disks belonging to the 
> VM, volume migration across primaries, volume attach/detach have also been 
> tested and they are working as expected. This is a functional change, and 
> completely transparent to any of cloudstack's existing functionalities and 
> all the test cases that cover the above code paths and APIs - all existing 
> tests should and do pass - no new tests are necessary.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidi