Re: Master broken on systemVM start

[Prasanna Santhanam]

On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
> On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
> > Json deserialization issue is caused by out-of-dated systemvm.iso on your
> > hypervisor host. You need rebuilding systemvm.iso and deployed to your
> > hypervisor host.
> > 
> 
> CLOUDSTACK-3137 exists and seems to be a problem with HA and
> systemVMs. The JSON serialization also exists for me despite
> rebuidling the systemvm with -Dsystemvm.

Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.

> 
> I see the deserialization error when the ssvm agent sends this to
> management server:
> 
> 2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent] (Agent-Handler-1:) Sending 
> Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags: 101, 
> [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-1-VM","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.168.56.144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00:00:42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84:00:00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.56.217","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:00:00:12","resourceName":"NfsSecondaryStorageResource","wait":0}}]
>  }
> 
> This happens both when I have a s3 store added and a regular nfs storage 
> added.
> Is the startupcommand still reqd?
> 
> -- 
> Prasanna.,
> 
> 
> Powered by BigRock.com

-- 
Prasanna.,


Powered by BigRock.com

Re: CloudStack SSL on 4.1.0

[France]

If you use a different location for your ssl certificate or different 
type, you must set it in tomcat6 configuration also.


On 28/6/13 2:28 AM, Musayev, Ilya wrote:

Thanks Marcus, it was a problem between the keyboard and the chair!


-Original Message-
From: Marcus Sorensen [mailto:shadow...@gmail.com]
Sent: Thursday, June 27, 2013 8:00 PM
To: dev@cloudstack.apache.org
Subject: Re: CloudStack SSL on 4.1.0

I'm running SSL, I opened server.xml and added the "Connector" section
pointing to my keystore with the password:


 


 
 

On Thu, Jun 27, 2013 at 5:45 PM, Musayev, Ilya 
wrote:

I will file this as a bug If I get no response :(


-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: Thursday, June 27, 2013 6:58 PM
To: dev@cloudstack.apache.org
Subject: CloudStack SSL on 4.1.0

Has anyone been able to get CloudStack 4.1.0 to work with SSL on 8443?

I cannot, no matter what I tried. I was able to get 4.0 to work, but
4.1.0 would not. Nothing useful at logs :(

Thanks
ilya

Re: apache libcloud

[Sebastien Goasguen]

On Jun 27, 2013, at 10:56 AM, Andrew Bayer  wrote:

> For what it's worth, so does jclouds - a good number may be a bit stale,
> but you can find the responses we use currently at
> https://github.com/jclouds/jclouds/tree/master/apis/cloudstack/src/test/resources

Cool, I might take a few from there and send you a couple more :)

> 
> A.
> 
> On Thu, Jun 27, 2013 at 6:57 AM, Sebastien Goasguen wrote:
> 
>> 
>> 
>> On 27 Jun 2013, at 02:39, Rohit Yadav  wrote:
>> 
>>> Nice work Sebastien! Now I know why you needed to have the raw json
>> output
>>> in the cli ;)
>>> 
>> Yes i should have explained. Libcloud unitests use json examples of api
>> responses, using a fake http request.
>> 
>> 
>> 
>>> Cheers.
>>> 
>>> On Thu, Jun 27, 2013 at 2:13 AM, Sebastien Goasguen >> wrote:
>>> 
 Hi folks,
 
 libcloud 0.13 RC is up for vote. There is much better support for
 CloudStack in it.
 Check it out:
 
>> http://buildacloud.org/blog/268-cloudstack-support-in-apache-libcloud.html
 
 -sebastien
>> 

[Merge] SolidFire Plug-in

[Mike Tutkowski]

Hi,

I updated from master and began to reconcile its code with what I have in
my local branch.

After a couple hours of making it all make sense again, I have two merge
issues I need to address later today:

1) The way we send attach- and detach-volume commands has been changed and
I need to get my code to work with it.

2) Available bytes has been changed to Used bytes for storage and I need to
get my code to understand this change.

How do we handle these late merges? My code needs to be tested again after
I finish this super-long merge. Do we have the weekend?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Suggestion needed for CLOUDSTACK-212

[Sebastien Goasguen]

On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia  wrote:

> Hi,
> 
> I misunderstood the feature freeze. This has been assigned to fix in
> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?

Dharmesh, can you give us the pointer to github where you put the latest 
changes on this ?

Did you rebase against the latest master lately ?

-sebastien

> 
> Thanks,
> Dharmesh
> 
> 
> On Sat, May 11, 2013 at 10:13 AM, Dharmesh Kakadia wrote:
> 
>> ok. great.
>> 
>> Thanks,
>> Dharmesh
>> 
>> 
>> On Sat, May 11, 2013 at 5:53 AM, David Nalley  wrote:
>> 
>>> Dharmesh:
>>> 
>>> Thanks for tackling this - I imagine there might be a little bit of churn,
>>> as features finally land in master, but shouldn't be much - I may pull
>>> this
>>> into a feature branch, and we can routinely rebase and see where we stand.
>>> 
>>> Thanks for being patient and flexible.
>>> 
>>> --David
>>> 
>>> On Friday, May 10, 2013, Dharmesh Kakadia wrote:
>>> 
 Just saw this. I have done the refactoring and code is available at
 
 
>>> https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
 try. In case we want to do it after 4.2-freeze, I am ready to redo it.
 
 Thanks,
 Dharmesh
 
 
 On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
 animesh.chaturv...@citrix.com > wrote:
 
> 
> 
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, May 08, 2013 6:31 AM
>> To: dev@cloudstack.apache.org 
>> Subject: Re: Suggestion needed for CLOUDSTACK-212
>> 
>> Dharmesh,
>> 
>> I'd also suggest that you actually plan on submitting this after the
 4.2
> feature
>> freeze, to be included in 4.3.  This is the type of change that has
> bitten us
>> with almost every release...  and doing it close to the end of the
 merge
>> window may not be a good idea.  Our general preference is to do
>>> these
> types
>> of changes in master right *after* the latest feature release has
>>> it's
> branch
>> cut.
>> 
>> -chip
> [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
> master in early June
>> 
>> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>>> ok. I will go with that.
>>> 
>>> Thanks,
>>> Dharmesh
>>> 
>>> On Wed, May 8, 2013 at 1:08 AM, Chip Childers
>> >wrote:
>>> 
 On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia
>>> wrote:
> Hi,
> 
> I am trying to move java package structure from com.cloud to
> org.apache (
> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
>> thinking of doing it the following way (Totally newbie), needed
 feedback
> on
>> that.
> 
> 1. grep "com.cloud" on the entire repo.
> 2. update all package declarations using eclipse.
> 3. Update scripts etc found in 1 manually.
> 
> Will it be a good way to do it ? Any better suggestion ?
> 
> Thanks,
> Dharmesh
 
 That seems like a reasonable approach.  We will probably want to
 create a branch when you submit a patch for this, and apply it
 there...  just to spend some time ensuring that the changes
>>> work.
 
 -chip
 
> 
 
>>> 
>> 
>> 

Re: Review Request 10366: Documentation changes for VMware dvSwitch and Nexus dvSwitch

[Radhika PC]

> On June 17, 2013, 1:07 p.m., Chip Childers wrote:
> > Radhika,
> > 
> > Was this committed?  If so, can you please close this review?  If not, 
> > what's needed to help get it done?

Hi Chip, 

There are many question unanswered. You can check the comments section of this 
review request.

I shall work with the QA point of contact for 4.2 release, then close this 
item. 


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10366/#review21979
---


On April 10, 2013, 7:05 a.m., Radhika PC wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10366/
> ---
> 
> (Updated April 10, 2013, 7:05 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Jessica Tomechak, David Nalley, 
> Pranav Saxena, Sateesh Chodapuneedi, and ilya musayev.
> 
> 
> Bugs: CLOUDSTACK-772
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Documentation on Distributed Switches: nexus and dvSwitch.
> Prerequisites part of VMware dvSwitch is still unclear. Please provide 
> necessary suggestions.
> 
> 
> Diffs
> -
> 
>   docs/en-US/Book_Info.xml c125ab8 
>   docs/en-US/add-clusters-vsphere.xml 6b2dff2 
>   docs/en-US/images/add-cluster.png 383f375ebedd62d9b294a56f777ed4b8c0d92e10 
>   docs/en-US/images/dvswitch-config.png PRE-CREATION 
>   docs/en-US/images/dvswitchconfig.png PRE-CREATION 
>   docs/en-US/vmware-cluster-config-dvswitch.xml PRE-CREATION 
>   docs/en-US/vmware-install.xml 467e135 
> 
> Diff: https://reviews.apache.org/r/10366/diff/
> 
> 
> Testing
> ---
> 
> Publican builds, patch applies.
> 
> 
> File Attachments
> 
> 
> section 8.3.7. Configuring a vSphere Cluster with VMware Distributed Virtual 
> Switch (page 110)
>   
> https://reviews.apache.org/media/uploaded/files/2013/04/10/Apache_CloudStack-4.1-Installation_Guide-en-US.pdf
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

[Saksham Srivastava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11627/
---

(Updated June 28, 2013, 8:24 a.m.)


Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-1012


Repository: cloudstack-git


Description
---

Encrypt system.vm.password and make the configuration as Secure.


Diffs (updated)
-

  server/src/com/cloud/upgrade/dao/Upgrade410to411.java 5b25620 

Diff: https://reviews.apache.org/r/11627/diff/


Testing
---

Tested on local setup.
Build successful.


Thanks,

Saksham Srivastava

Re: [DISCUSS] Java 7, tomcat 7 and further upgrades

[Wido den Hollander]

Hi,

On 06/27/2013 12:36 AM, Hugo Trippaers wrote:

Hey everyone,

Back in February 2013 Oracle announced the end of public support for java 1.6 
already. Today we are still using java 1.6 as our supported platform. I've been 
looking at the next generation of linux distributions (well mainly at Fedora 
18, which will probably become RHEL 7) and those platforms ship with java 1.7 
by default.

Next to that several core components are also upgraded with affect our 
installation. RHEL 7 will most likely use tomcat 7 as the default tomcat 
platform for example.

If we want to start shipping for those platform we will have to start testing 
with these versions of the software as well. I'm already working on some things 
that need to be done, like replacing the existing init scripts with systemd 
versions and adapting the spec file for the new OS, but there is more to it 
than that.



Don't forget the Deb packaging ;) I'll take care of that.


I'm wondering what we need to do on the source side of things. My proposal 
would be to at least configure maven to set the source version to 1.7. This 
requires developers to use the java 7 versions of the jdk. We can leave the 
target to 1.6 for the time being to ensure that the packages could still run on 
a 1.6 jdk.



In favour of setting source to 1.7, but target 1.6 and that should at 
least stay so until 4.5 I think?



However at a certain point we should start to advice people to run CloudStack 
on java 1.7 as there are no more public security updates to java 1.6.


True, but that doesn't change the fact that some people might need to 
run 1.6 for some other reason we can't come up with right now.




So summarized proposal, make 4.2 the last version to support 1.6 and switch 
maven source version to 1.7 after we cut the release branch for 4.2. The new 
reference platform for the next release would be jdk 1.7 and tomcat7 (meaning 
packaging will be tested on those platforms).



Doesn't tomcat7 imply that target is also 1.6?


So what do you all think of this? If we are ok to do this i would like to start 
with this right after the release branch cut. This constitutes a major 
architecture change so i would want this to be in as early as possible in the 
release cycle.

And as a side note, are there any other version updates we would like to see in 
that release. We depend on several ancient libraries if i'm looking through the 
pom files. Maybe we should consider upgrading a few dependencies to more recent 
versions?



That should be a ongoing process, since dependencies indeed get newer 
versions and that could bit if we don't keep up.


Wido


Cheers,

Hugo

On git 4.1 (4.1.1-SNAPSHOT), jetty:run fails because of database version errors

[Ryan Lei]

Hi all,
I was trying to use the git 4.1 branch to run non-OSS CloudStack from
source. My commands were:

(1) Put the neccessary jars in deps
(2) Run deps/install-non-oss.sh with success
(3) $ mvn clean install -DskipTests=true -Dnonoss
(4) $ mvn -P developer -pl developer -Ddeploydb
(5) $ mvn -pl :cloud-client-ui jetty:run

Then I got these DB version errors which made the jetty quit:
INFO  [utils.component.ComponentContext] (Timer-2:) Running
SystemIntegrityChecker encryptionSecretKeyChecker
INFO  [utils.component.ComponentContext] (Timer-2:) Running
SystemIntegrityChecker databaseIntegrityChecker
INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Grabbing lock to
check for database integrity.
INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Performing
database integrity check
INFO  [utils.component.ComponentContext] (Timer-2:) Running
SystemIntegrityChecker managementServerNode
INFO  [utils.component.ComponentContext] (Timer-2:) Running
SystemIntegrityChecker premiumDatabaseUpgradeChecker
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Grabbing lock to
check for database upgrade.
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) DB version = 4.0.0
Code Version = 4.1.1-SNAPSHOT
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Database upgrade
must be performed from 4.0.0 to 4.1.1-SNAPSHOT
ERROR [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) The end upgrade
version is actually at 4.1.0 but our management server code version is at
4.1.1-SNAPSHOT
ERROR [utils.component.ComponentContext] (Timer-2:) System integrity check
failed. Refuse to startup


In MySQL, I found the table in 'version' has only one entry whose value is
4.0.0.
Manually modifying the value to 4.1.1 led to other exceptions. Looks like
4.1 git "forgets" to upgrade the database.

Is this a bug in the current 4.1 branch?

---
Yu-Heng (Ryan) Lei, Associate Reasearcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw
or
ryanlei750...@gmail.com

Re: BVT failure - CLOUDSTACK-3167

[Prasanna Santhanam]

On Tue, Jun 25, 2013 at 11:27:42AM +0530, Prasanna Santhanam wrote:
> On Tue, Jun 25, 2013 at 05:25:08AM +, Rayees Namathponnan wrote:
> > 
> > List VLAN range API call failed with null pointer exception in
> > latest build from master and master-6-17-stable branch build,
> > 
> > SSVM and router test cases failed due this from BVT
> > 
> > http://jenkins.cloudstack.org/view/cloudstack-qa/job/test-smoke-matrix/suite=test_ssvm/lastCompletedBuild/testReport/
> > http://jenkins.cloudstack.org/view/cloudstack-qa/job/test-smoke-matrix/suite=test_routers/524/testReport/junit/
> > 
> 
> Here's some more:
>CLOUDSTACK-3176 KVM DeployVM fails with unable to get answer that is of 
> type StartAnswer (blocker)
Kawai-san fixed this

Following are still looking for a fix. They're related to the
object_store merge.

>CLOUDSTACK-3175 DetachVolume command fails with Internal Server Error
>CLOUDSTACK-3146 Extract Template command fails with Unsupported Command: 
> storage.CreateEntityDownloadURLCommand on SSVM
>CLOUDSTACK-3145 StorageManager-Scavenger NPEs when cleaning up templates
>CLOUDSTACK-3144 [Automation] Deletion of templates failing. Fails to find 
> image store housing template

Edison/Min - can you guys help with the above?

Thanks,

 
-- 
Prasanna.,


Powered by BigRock.com

Review Request 12156: CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12156/
---

Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-3189


Repository: cloudstack-git


Description
---

CLOUDSTACK-3189: Primary storage usage is not getting decremented after 
deleting the DATA volumes.

https://issues.apache.org/jira/browse/CLOUDSTACK-3189


Diffs
-

  server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 

Diff: https://reviews.apache.org/r/12156/diff/


Testing
---

Tests:

1. Create a volume from a user account.
2. Verify the increment in primaryStorageTotal count using listAccount API.
3. Delete volume.
4. Verify the decrement in primaryStorageTotal count.


Thanks,

Sanjay Tripathi

Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias.

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
---

(Updated June 28, 2013, 9:13 a.m.)


Review request for cloudstack and Abhinandan Prateek.


Changes
---

rebased with master-stable.


Bugs: Cloudstack-3106


Repository: cloudstack-git


Description
---

Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106


Diffs (updated)
-

  engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc 
  engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a 
  engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
4b29eab 

Diff: https://reviews.apache.org/r/12110/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 12110: Cloudstack-3106 Delete all the ips except for the ip alias. Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12110/
---

(Updated June 28, 2013, 9:14 a.m.)


Review request for cloudstack and Abhinandan Prateek.


Summary (updated)
-

Cloudstack-3106 Delete all the ips except for the ip alias. Cloudstack-3119 
Shared network removal doesn't cleanup corresponding IP ranges


Bugs: Cloudstack-3106


Repository: cloudstack-git


Description (updated)
---

Cloudstack-3106 Delete all the ips except for the ip alias.
https://issues.apache.org/jira/browse/CLOUDSTACK-3106

Cloudstack-3119 Shared network removal doesn't cleanup corresponding IP ranges
https://issues.apache.org/jira/browse/CLOUDSTACK-3119


Diffs
-

  engine/schema/src/com/cloud/dc/VlanVO.java af6b5fc 
  engine/schema/src/com/cloud/network/dao/IPAddressDao.java fecd44a 
  engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 886011e 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java cb4f76b 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
4b29eab 

Diff: https://reviews.apache.org/r/12110/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On June 27, 2013, 6:05 p.m., edison su wrote:
> > server/src/com/cloud/storage/StoragePoolAutomationImpl.java, line 355
> > 
> >
> > What am trying to say is to move the following codee to 
> > storagepoolautomationimpl:
> > 
> > List spes = 
> > _storagePoolDao.listBy(primaryStorage.getDataCenterId(), 
> > primaryStorage.getPodId(), primaryStorage.getClusterId(),
> > ScopeType.CLUSTER);
> > for (StoragePoolVO sp : spes) {
> > if (sp.getStatus() == 
> > StoragePoolStatus.PrepareForMaintenance) {
> > throw new CloudRuntimeException("Only one storage pool 
> > in a cluster can be in PrepareForMaintenance mode, " + sp.getId()
> > + " is already in  PrepareForMaintenance mode 
> > ");
> > }
> > }
> > 
> >

moved the code to StoreagePoolAutomationImpl in the latest patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22473
---


On June 27, 2013, 12:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 27, 2013, 12:39 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  99b7b9c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/
---

(Updated June 28, 2013, 9:18 a.m.)


Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
Chodapuneedi.


Changes
---

incorporated review comments.
This patch will resolve only issues with "Enable Maintenance" of ZWPS.
Regarding issues with cancelling maintenance, I had created one more review 
request.


Bugs: CLOUDSTACK-2571


Repository: cloudstack-git


Description
---

Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
maintenance.

Fixed:
1. Added ZONE scope storage handling in StorageManagerImpl and 
StoragePoolAutomationImpl 
2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper class 
of long instead of primitive. Modified associated DaoImpl.
3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
handled the case for ZONE wide scope of storage. 
   if the storage is zone wide, get all the hosts(kvm, vmware) in zone and send 
the ModifyStoragePool command (with false)
4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
storage pool.
5. Once the Storage is in maintenance, Deletion of the Storage will remove the 
mount points from all the hosts.

This patch will solve all the issues pertaining to keeping/cancelling the ZONE 
wide primary storage.


Diffs (updated)
-

  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
 99b7b9c 
  
engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
 8f7826f 
  server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 

Diff: https://reviews.apache.org/r/11992/diff/


Testing
---

Manual Testing
= 
1. Enable maintenance mode of Zone wide storage , There were no NPE's happening 
and successfully kept the storage in maintenance mode. Verified DB status.
2. Cancel maintenance mode of Zone wide storage, There were no NPE's happening 
and successfully kept the storage in UP state.
3. Enable maintenance mode of zone wide, once successful then Delete the 
storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
unmounted and verified the DB status.
Addition Tests (As the common code path is modified):
1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
storage in both clusters is successful.
kvm specific:

2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
the storage in maintenance state. 
3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
enabled the storage in UP state.
4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
Storage got successfully deleted, unmounted from hosts and from db.

Xenserver specific:
===
5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in maintenance state. 
6. Cancel the Maintenance Mode of cluster scope Xenserver storage. Successfully 
enabled the storage in UP state.
7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
storage. Storage got successfully deleted, unmounted from hosts and from db.

ZWPS is supported in KVM and VMware, the common code is modified. It should 
work of VMWare as well without any issues


Thanks,

Rajesh Battala

Re: Review Request 11992: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

[Rajesh Battala]

> On June 27, 2013, 6:05 p.m., edison su wrote:
> > server/src/com/cloud/storage/StoragePoolAutomationImpl.java, line 355
> > 
> >
> > What am trying to say is to move the following codee to 
> > storagepoolautomationimpl:
> > 
> > List spes = 
> > _storagePoolDao.listBy(primaryStorage.getDataCenterId(), 
> > primaryStorage.getPodId(), primaryStorage.getClusterId(),
> > ScopeType.CLUSTER);
> > for (StoragePoolVO sp : spes) {
> > if (sp.getStatus() == 
> > StoragePoolStatus.PrepareForMaintenance) {
> > throw new CloudRuntimeException("Only one storage pool 
> > in a cluster can be in PrepareForMaintenance mode, " + sp.getId()
> > + " is already in  PrepareForMaintenance mode 
> > ");
> > }
> > }
> > 
> >
> 
> Rajesh Battala wrote:
> moved the code to StoreagePoolAutomationImpl in the latest patch

Thank Edison for the review. I had incorporated the suggestions provided in the 
latest uploaded patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11992/#review22473
---


On June 28, 2013, 9:18 a.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11992/
> ---
> 
> (Updated June 28, 2013, 9:18 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, edison su, Ram Ganesh, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2571
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Issue : NPE's are happening when ZWPS is put in maintenance, removed from 
> maintenance.
> 
> Fixed:
> 1. Added ZONE scope storage handling in StorageManagerImpl and 
> StoragePoolAutomationImpl 
> 2. Modified PrimaryDataStoreDao, listBy method to take poolid to Wrapper 
> class of long instead of primitive. Modified associated DaoImpl.
> 3. StoragePoolAutomationImpl, when storage is setting to Maintenance mode, 
> handled the case for ZONE wide scope of storage. 
>if the storage is zone wide, get all the hosts(kvm, vmware) in zone and 
> send the ModifyStoragePool command (with false)
> 4. When users, cancels maintenance mode, the handled the ZONE wide scope of 
> storage pool.
> 5. Once the Storage is in maintenance, Deletion of the Storage will remove 
> the mount points from all the hosts.
> 
> This patch will solve all the issues pertaining to keeping/cancelling the 
> ZONE wide primary storage.
> 
> 
> Diffs
> -
> 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  99b7b9c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  8f7826f 
>   server/src/com/cloud/storage/StorageManagerImpl.java b3e8b96 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 
> 
> Diff: https://reviews.apache.org/r/11992/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> = 
> 1. Enable maintenance mode of Zone wide storage , There were no NPE's 
> happening and successfully kept the storage in maintenance mode. Verified DB 
> status.
> 2. Cancel maintenance mode of Zone wide storage, There were no NPE's 
> happening and successfully kept the storage in UP state.
> 3. Enable maintenance mode of zone wide, once successful then Delete the 
> storage, Storage got deleted successfuly. Verify the hosts,  Storage got 
> unmounted and verified the DB status.
> Addition Tests (As the common code path is modified):
> 1. Add the Cluster scope of primary storage (kvm , xenserver). Adding the 
> storage in both clusters is successful.
> kvm specific:
> 
> 2. Enable Maintenance Mode of cluster scope kvm storage. Successfully enabled 
> the storage in maintenance state. 
> 3. Cancel the Maintenance Mode of cluster scope kvm storage. Successfully 
> enabled the storage in UP state.
> 4. Enable Maintenance Mode of cluster scope kvm storage. Delete the storage. 
> Storage got successfully deleted, unmounted from hosts and from db.
> 
> Xenserver specific:
> ===
> 5. Enable Maintenance Mode of cluster scope Xenserver storage. Successfully 
> enabled the storage in maintenance state. 
> 6. Cancel the Maintenance Mode of cluster scope Xenserver storage. 
> Successfully enabled the storage in UP state.
> 7. Enable Maintenance Mode of cluster scope Xenserver storage. Delete the 
> storage. Storage got successfully deleted, unmounted from hosts and from db.
> 
> ZWPS is supported in KVM and VMware, the common code is modified. It should 
> work of VMWare as well without any issues
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>

Re: Review Request 12107: Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries. Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results

[Abhinandan Prateek]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12107/#review22501
---

Ship it!


Ship It!

- Abhinandan Prateek


On June 27, 2013, 9:26 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12107/
> ---
> 
> (Updated June 27, 2013, 9:26 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2150 and Cloudstack-2980
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Cloudstack-2150 DB table entries of phisical network is not proper.Shows 
> Duplicate entries.
> https://issues.apache.org/jira/browse/CLOUDSTACK-2980
> Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges 
> results in inconsistent DB entries
> https://issues.apache.org/jira/browse/CLOUDSTACK-2980
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5e900bb 
> 
> Diff: https://reviews.apache.org/r/12107/diff/
> 
> 
> Testing
> ---
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 12158: CLOUDSTACK-3089-[ZWPS]-NPE-while-cancelling-the-Storage-Maintenance

[Rajesh Battala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12158/
---

Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

fixes the issues with ZWPS while cancelling maintenance state.


Diffs
-

  server/src/com/cloud/storage/StoragePoolAutomationImpl.java 4001775 

Diff: https://reviews.apache.org/r/12158/diff/


Testing
---

done the testing specified in https://reviews.apache.org/r/11992/


Thanks,

Rajesh Battala

Re: Review Request 10366: Documentation changes for VMware dvSwitch and Nexus dvSwitch

[Sateesh Chodapuneedi]

> On June 17, 2013, 1:07 p.m., Chip Childers wrote:
> > Radhika,
> > 
> > Was this committed?  If so, can you please close this review?  If not, 
> > what's needed to help get it done?
> 
> Radhika PC wrote:
> Hi Chip, 
> 
> There are many question unanswered. You can check the comments section of 
> this review request.
> 
> I shall work with the QA point of contact for 4.2 release, then close 
> this item.

Radhika,
I did answer as many questions as I could on 18th April.
Since then I have been waiting for feedback over the answers provided to 
following questions. Please do provide inputs.

Sateesh Chodapuneedi 2 months, 1 week ago (April 18, 2013, 5:52 p.m.)

>do we have to note down any parameters, that could be later used in 
CloudStack ? Please confirm.

User might want to specify name of dvSwitch in following places,
1) traffic label in physical network page of zone configuration wizard - 
This setting dictates name of vSwitch/dvSwitch to be used for virtual network 
orchestration later.
2) public/guest virtual switch na,e - This setting overrides the 
vSwitch/dvSwitch name in zone level configuration setting for traffic label. 
See (1) above.

>Is deleting/creating/modifying dvPortGroup similar to deleting dvSwitch ? 
Could you please clarify.
No.

>All the host/cluster resources should be added to dvSwitch before adding 
the cluster to CloudStack's pod cluster. (it is not clear this step need to be 
done on vCenter or CloudStack). It is very difficult to document such a complex 
feature without a setup.

This step is to be done on vCenter. Its part of dvSwitch deployment & out 
of CloudStack's scope.
Complete documentation of feature like this should be done after with a 
setup. Otherwise, first draft can be made with content from FS & improve the 
document once setup is available or handover the documentation task to 
interested people with setup. Content in FS is good enough to start with 
because FS contains all key details which are implemented in the feature.

>(what is the specific number here ?)

It's fixed number of dvports which is any where from 1 to maximum number of 
dvports allowed by a dvportgroup.

>(Is this a limitation? should it be mentioned?) 

No.

>Question: From where do you pick up/ specify a name for the traffic ? Is 
this something that we get from vCenter setup ? Or are we saying to mention 
what type of switch to be used ?

Its name of dvSwitch. Can be observed in vCenter setup.
Yes, good to follow terminology from 
http://blogs.vmware.com/vsphere/tag/distributed-switch


- Sateesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10366/#review21979
---


On April 10, 2013, 7:05 a.m., Radhika PC wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10366/
> ---
> 
> (Updated April 10, 2013, 7:05 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Jessica Tomechak, David Nalley, 
> Pranav Saxena, Sateesh Chodapuneedi, and ilya musayev.
> 
> 
> Bugs: CLOUDSTACK-772
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Documentation on Distributed Switches: nexus and dvSwitch.
> Prerequisites part of VMware dvSwitch is still unclear. Please provide 
> necessary suggestions.
> 
> 
> Diffs
> -
> 
>   docs/en-US/Book_Info.xml c125ab8 
>   docs/en-US/add-clusters-vsphere.xml 6b2dff2 
>   docs/en-US/images/add-cluster.png 383f375ebedd62d9b294a56f777ed4b8c0d92e10 
>   docs/en-US/images/dvswitch-config.png PRE-CREATION 
>   docs/en-US/images/dvswitchconfig.png PRE-CREATION 
>   docs/en-US/vmware-cluster-config-dvswitch.xml PRE-CREATION 
>   docs/en-US/vmware-install.xml 467e135 
> 
> Diff: https://reviews.apache.org/r/10366/diff/
> 
> 
> Testing
> ---
> 
> Publican builds, patch applies.
> 
> 
> File Attachments
> 
> 
> section 8.3.7. Configuring a vSphere Cluster with VMware Distributed Virtual 
> Switch (page 110)
>   
> https://reviews.apache.org/media/uploaded/files/2013/04/10/Apache_CloudStack-4.1-Installation_Guide-en-US.pdf
> 
> 
> Thanks,
> 
> Radhika PC
> 
>

Re: CloudStack API Development

[Sebastien Goasguen]

On Jun 27, 2013, at 7:13 AM, Ian Duffy  wrote:

> Post made as requested:
> http://imduffy15.blogspot.co.uk/2013/06/creating-cloudstack-plugin.html

Ian, if the pdf you link to in that post was created with publican, please 
submit a patch for the developer's guide, so we can get it in there.

thanks, great work.


> 
> On 27 June 2013 07:29, Ian Duffy  wrote:
>>> Thanks, a quick blog on this would be great.
>> 
>> Will hopefully get this done later today. Need to document it for my
>> own reference purposes as well. Those slides I linked above by
>> solidfire were great!

Re: CloudStack API Development

[Ian Duffy]

> Ian, if the pdf you link to in that post was created with publican

It wasn't, just an export from a confluence wiki. I'll convert it and
submit it as a patch to the review board at some stage(tomorrow
maybe...)

Re: Advanced Network Errors

[Ahmad Emneina]

can you resend the link, the paste id is broken.


On Fri, Jun 28, 2013 at 4:01 AM, Maurice Lawler wrote:

> Hello gang, I appreciate the help I've had thus far; I am toying with
> advanced network on my test server, however; setting it up, to what I
> believe is correct, I am presented with the errors you'll find here:
> http://pastebin.com/mspH3fZ9
>
> Anyone know how to resolve this?
>
> - M.
>

Re: Review Request 12111: [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12111/
---

(Updated June 28, 2013, 11:26 a.m.)


Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-2732


Repository: cloudstack-git


Description
---

[Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message 
to user while the ip addresses are being used
https://issues.apache.org/jira/browse/CLOUDSTACK-2732


Diffs (updated)
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java c19f401 

Diff: https://reviews.apache.org/r/12111/diff/


Testing
---

Tested on master.


Thanks,

bharat kumar

Re: Review Request 12111: [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error message to user while the ip addresses are being used

[Jayapal Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12111/#review22503
---

Ship it!


Ship It!

- Jayapal Reddy


On June 28, 2013, 11:26 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12111/
> ---
> 
> (Updated June 28, 2013, 11:26 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: Cloudstack-2732
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> [Multiple_IP_Ranges] Deleting guest IP range is not throwing any error 
> message to user while the ip addresses are being used
> https://issues.apache.org/jira/browse/CLOUDSTACK-2732
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java c19f401 
> 
> Diff: https://reviews.apache.org/r/12111/diff/
> 
> 
> Testing
> ---
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Test case execution issue: connect to remote db

[Gaurav Aradhye]

Hi all,

I am using a management server and hence db server on remote host which is
not local.
While running test cases, Whenever I try to get the dbclient, it throws
error " Access denied for user 'username@ip' (using password: YES)"

While I have kept the Db server ip, username and password values in config
file, still in the error message it shows that it's trying to connect
localhost only.
Is there any method to tell marvin lib to explicitly use remote host by
passing its ip and other values? It seems that the values are defaulted to
"localhost" in all the library functions.

Any directions on this?

Regards,
Gaurav

Re: Test case execution issue: connect to remote db

[Prasanna Santhanam]

On Fri, Jun 28, 2013 at 05:26:31PM +0530, Gaurav Aradhye wrote:
> Hi all,
> 
> I am using a management server and hence db server on remote host which is
> not local.
> While running test cases, Whenever I try to get the dbclient, it throws
> error " Access denied for user 'username@ip' (using password: YES)"

Is the 'ip' of localhost or the remote machine where the mysql-server
is running? Can you show the snippet of config where the dbSvr is
configured?

> 
> While I have kept the Db server ip, username and password values in config
> file, still in the error message it shows that it's trying to connect
> localhost only.
>From what I can see, it should be connecting to the remote host only.

> Is there any method to tell marvin lib to explicitly use remote host by
> passing its ip and other values? It seems that the values are defaulted to
> "localhost" in all the library functions.

marvin connects to the db provided in the config file. The values are
defaulted to localhost only if no remote host information is given.

> 
> Any directions on this?
> 
> Regards,
> Gaurav

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 12162: Add documents on plugin development

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12162/
---

(Updated June 28, 2013, 12:37 p.m.)


Review request for cloudstack and Sebastien Goasguen.


Changes
---

Fix typo


Repository: cloudstack-git


Description
---

Add documentation on creating a simple "helloWorld" API command plugin. 


Diffs
-

  docs/en-US/creating-a-plugin.xml PRE-CREATION 
  docs/en-US/creating-my-first-plugin.xml PRE-CREATION 
  docs/en-US/plugin-development.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/12162/diff/


Testing (updated)
---

Built with publican, reviewed the build pdf in adobe reader.
There was funky text indentation between pages... this seems to be a global 
problem though.  


Thanks,

Ian Duffy

Re: event bus details

[Murali Reddy]

On 28/06/13 4:28 AM, "Ryan Dietrich"  wrote:

>> For every api command, pretty much there is an action event generated
>>that
>> gets published on to event bus as well. CLOUDSTACK-3190 is open bug that
>> needs to be fixed so that entity type being operated and UUID details of
>> entity are published. It just tedious job to fix all the places action
>> events are generated. Good pick for CloudStack newbie to fix it though.
>
>Yes, my assumption is you'd have to add another abstract method on
>BaseAsyncCmd to allow you to query for the UUID being modified.
>The problem with this is, many of the UUID's passed into commands are
>transformed into their internal ID (long) via the "Parameter" annotation.
>It would seem sort of ugly to have to re-query the UUID out of the
>database so it would be available when the job details needed to be
>published.
>
>Is there any way to get raw access to the parameters sent to a command?
>
>> This should be doable with a quick fix. I opened CLOUDSTACK-3233 for
>>this.
>> Would you mind take a look at this bug and see if you can fix it? I left
>> details on what needs to be done in the bug.
>
>Ok, I'm working on this now.
>
>> There is RESOURCE_STATE_CHANGE_EVENT's that get published on resource
>> state change of critical entities VM, network, volume, snapshot. But
>>there
>> is entity type and entity UUID details only. If you feel user/domain
>> details are needed as well please go ahead and fix message body.
>
>I will, I planned on using a configuration option to allow you to
>show/hide this extra information.  I'll need it, but I understand that
>others might see this as bloat.  (I'm making it default to "false").
>
>> Event message body is key-value pair in JSON format. Body format may
>> differ depending on the event category (action event, usage event,
>> resource state change, alert). Can you please check if for a event
>> category message are consistent? If its not please open bug.
>
>Sure, here's a couple quick examples.
>
>management-server.AlertEvent.ALERT-USAGE.*.*   {"event":"ALERT.USAGE"}
>management-server.ResourceStateEvent.OperationSucceeded.Volume.bb213f8b-d7
>c8-4f7d-82bd-8e4ed230eb66
>{"id":"bb213f8b-d7c8-4f7d-82bd-8e4ed230eb66","old-state":"Snapshotting","n
>ew-state":"Ready","resource":"Volume"}
>management-server.ActionEvent.VM-CREATE.VirtualMachine.*
>{"status":"Scheduled","event":"VM.CREATE","account":"f66d4d60-bbdf-11e2-8b
>b5-52540014c04d","user":"f66f14d8-bbdf-11e2-8bb5-52540014c04d"}
>management-server.UsageEvent.VOLUME-DELETE.com-cloud-storage-Volume.dc802b
>ce-15f5-4694-be44-096d6aefca80
>{"id":"dc802bce-15f5-4694-be44-096d6aefca80","event":"VOLUME.DELETE","reso
>urce":"com.cloud.storage.Volume","account":"f66d4d60-bbdf-11e2-8bb5-525400
>14c04d","zone":"5e5f35d3-acb1-4142-84c2-e7f0ea7a36f4"}
>
>So, within each EventCategory, things are consistent, but between them
>they are totally different.  When using say, GSON as the parsing routine
>you're force to do one of two things when receiving messages.
>
>1. Look at the routing key with a regex or "indexOf" call to figure out
>what kind of message you're receiving.
>2. Create a superset object that has all of the possible keys that
>compose all of the messages, and then use GSON to slurp everything in.
>Then you'd have to just check which fields were NULL to figure out what
>type of message you're dealing with.
>
>Both of these solutions seem poor.

Okay. When I designed I did not think of somebody consuming the message
directly. Since it was framework to both publish and subscribe, I sort of
added the necessary details in the payload
(framework/events/src/org/apache/cloudstack/framework/events/Event.java)
that a callback ( registered through subscribe in
framework/events/src/org/apache/cloudstack/framework/events/EventBus.java).
 Please go ahead and add the details to message body.


>  Obviously a resource event is different than a usage event, but if they
>were at least consistent at some level I wouldn't have to have super
>explicit code paths for every type of message being sent.  If I had to
>choose from any of the existing formats, I like the ResourceStateEvent
>the best.  It clearly shows you what the type of the UUID (volume in the
>example) as well as the state change.  ActionEvent, AlertEvent need some
>help.  

You are right, since ResourceStateEvent is newly added its built up on
EventBus, but legacy events definitely need help.

>
>Lastly, UsageEvent.  I'm almost confused what this means.  Here's an
>example from my logs.
>
>management-server.ResourceStateEvent.DestroyRequested.Volume.ed51b63b-a63b
>-4e6a-8c36-45f32c29988d
>{"id":"ed51b63b-a63b-4e6a-8c36-45f32c29988d","old-state":"Ready","new-stat
>e":"Destroy","resource":"Volume"}
>management-server.UsageEvent.VOLUME-DELETE.com-cloud-storage-Volume.ed51b6
>3b-a63b-4e6a-8c36-45f32c29988d
>{"id":"ed51b63b-a63b-4e6a-8c36-45f32c29988d","event":"VOLUME.DELETE","reso
>urce":"com.cloud.storage.Volume","account":"f66d4d60-bbdf-11e2-8bb5-52540

Review Request 12162: Add documents on plugin development

[Ian Duffy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12162/
---

Review request for cloudstack and Sebastien Goasguen.


Repository: cloudstack-git


Description
---

Add documentation on creating a simple "helloWorld" API command plugin. 


Diffs
-

  docs/en-US/creating-a-plugin.xml PRE-CREATION 
  docs/en-US/creating-my-first-plugin.xml PRE-CREATION 
  docs/en-US/plugin-development.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/12162/diff/


Testing
---

Build with publican, reviewed the build pdf in adobe reader.
There was funky text indentation between pages... this seems to be a global 
problem though.  


Thanks,

Ian Duffy

Re: Test case execution issue: connect to remote db

[Gaurav Aradhye]

Regards,
Gaurav | +919028496765


On Fri, Jun 28, 2013 at 5:38 PM, Prasanna Santhanam  wrote:

> On Fri, Jun 28, 2013 at 05:26:31PM +0530, Gaurav Aradhye wrote:
> > Hi all,
> >
> > I am using a management server and hence db server on remote host which
> is
> > not local.
> > While running test cases, Whenever I try to get the dbclient, it throws
> > error " Access denied for user 'username@ip' (using password: YES)"
>
> Is the 'ip' of localhost or the remote machine where the mysql-server
> is running? Can you show the snippet of config where the dbSvr is
> configured?
>

IP is of localhost (while it should be of remote host)

Sure following is the snippet of config:
"dbSvr": {
"dbSvr": "remote server ip",
"db": "",
"passwd": "",
"port": X,
"user": ""
},


>
> >
> > While I have kept the Db server ip, username and password values in
> config
> > file, still in the error message it shows that it's trying to connect
> > localhost only.
> From what I can see, it should be connecting to the remote host only.
>
> > Is there any method to tell marvin lib to explicitly use remote host by
> > passing its ip and other values? It seems that the values are defaulted
> to
> > "localhost" in all the library functions.
>
> marvin connects to the db provided in the config file. The values are
> defaulted to localhost only if no remote host information is given.
>
> >
> > Any directions on this?
> >
> > Regards,
> > Gaurav
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>
>

Re: Review Request 12063: Fix for CLOUDSTACK-2835: Registering router template and usage of router.template.* configuration parameter

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12063/#review22506
---


Commit 75d860b3ac03e7bec2d8849859584654bfb7d801 in branch 
refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=75d860b ]

CLOUDSTACK-2835: VR Deployement from admin registered template is failing 
because registered template type is user. Additional parameter "isrouter" in 
register/update template API for the root admin. True if registered template is 
of type ROUTING.

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On June 24, 2013, 3:39 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12063/
> ---
> 
> (Updated June 24, 2013, 3:39 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin 
> Mehta.
> 
> 
> Bugs: CLOUDSTACK-2835
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2835:  VR Deployement from admin registered template is failing 
> because registered template type is user. 
> Additional parameter "isrouter" in register/update template API for the root 
> admin. True if registered template is of type ROUTING.
> 
> A new template type is introduced named "ROUTING" which is used to deploy 
> router. 
> Admin registers a ROUTING type template and provides the value zone/global 
> level configuration parameters in 
> routing.template.xenserver/kvm/hyperv/vmware/lxc So that router deploys using 
> that template.
> By default router can be deployed by the normal SYSTEM template.
> 
> Added upgrade case to update the configuration parameter values 
> routing.template.xenserver/kvm/hyperv/vmware/lxc
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/storage/Storage.java 16ef019 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 8ac7c3f 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java b01c8d0 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  6a8e555 
>   
> api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java
>  9f55f9d 
>   engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java e7b85f8 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 8f63a6c 
>   server/src/com/cloud/server/ManagementServerImpl.java 97bac1b 
>   server/src/com/cloud/storage/TemplateProfile.java 00aab4d 
>   server/src/com/cloud/template/TemplateAdapter.java d50d45b 
>   server/src/com/cloud/template/TemplateAdapterBase.java c1f0604 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
> 
> Diff: https://reviews.apache.org/r/12063/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> Registered ROUTING template and checked router deployment by setting the 
> configuration parameter routing.template.xenserver to the new ROUTING 
> template.
> Tested the default behavior of router deployment from SYSTEM template.
> 
> Tested upgrade case from 4.1 to 4.2  
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12079/#review22505
---


Commit 98b47ab4667e57e110faa88a71ce2f78a2161a8b in branch 
refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=98b47ab ]

CLOUDSTACK-2794: Global parameter "router.template.id" should be removed The 
parameter was not in use. We use zone/global coonfigutaion parameters 
router.template.xenserver/vmware/hyperv/kvm/lxc to deploy router

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On June 25, 2013, 1:51 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12079/
> ---
> 
> (Updated June 25, 2013, 1:51 p.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-2794
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2794: Global parameter "router.template.id"should be removed.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 
>   server/src/com/cloud/configuration/Config.java 3a6d3aa 
>   server/src/com/cloud/template/TemplateManagerImpl.java 273614c 
>   setup/db/db/schema-410to420.sql d2add32 
> 
> Diff: https://reviews.apache.org/r/12079/diff/
> 
> 
> Testing
> ---
> 
> Tested with latest master, also upgrade case.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able to register template

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/#review22504
---


Commit 11a28aae455ba070a8afa105a51a758a78762f9e in branch 
refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=11a28aa ]

CLOUDSTACK-3245: non admin user not able to register template

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12136/
> ---
> 
> (Updated June 27, 2013, 7:04 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
> 
> 
> Bugs: CLOUDSTACK-3245
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3245:  non admin user not able to register template
> 
>  During registering template Admin only API parameter is set defaulted to 
> false in the API layer if it is not set which causing user to fail 
> registering template. 
> 
> 
> Diffs
> -
> 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  13bd5da 
>   server/src/com/cloud/template/TemplateAdapterBase.java 7835680 
> 
> Diff: https://reviews.apache.org/r/12136/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 11910: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11910/#review22507
---


Commit d8690837ded1e7219ece5889b8302b5d2a85d730 in branch 
refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d869083 ]

CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable 
dynamic scaling of vm

CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of 
XS tools in the template
This also takes care of updation of VM after XS tools are installed in the vm 
and set memory values accordingly to support dynamic scaling after stop start 
of VM

Signed-off-by: Jayapal 


- ASF Subversion and Git Services


On June 20, 2013, 5:19 a.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11910/
> ---
> 
> (Updated June 20, 2013, 5:19 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2987 and CLOUDSTACK-3042
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable 
> dynamic scaling of vm 
> 
> CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of 
> XS tools in the template
> This should also take care of updation of VM after XS tools are installed in 
> the vm and set memory values accordingly to support dynamic scaling after 
> stop start of VM
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 
>   api/src/com/cloud/vm/VirtualMachine.java ce9add6 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 12e5097 
>   api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 
>   api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 
> 284d553 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  c9da0c2 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 
>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java ed933ff 
>   api/src/org/apache/cloudstack/api/response/UserVmResponse.java 5b71ba2 
>   core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 
>   engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java
>  4d162bb 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  5e8283a 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  8e37809 
>   server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f9877ab 
>   server/src/com/cloud/api/query/vo/UserVmJoinVO.java c97d71a 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f 
>   server/src/com/cloud/server/ManagementServerImpl.java cfc8333 
>   server/src/com/cloud/storage/TemplateProfile.java 0b55f1f 
>   server/src/com/cloud/template/TemplateAdapter.java 9a2d877 
>   server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5814075 
>   server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e 
>   setup/db/db/schema-410to420.sql c782234 
> 
> Diff: https://reviews.apache.org/r/11910/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

PrimaryDataStoreEntityImpl TODOs

[John Burwell]

All,

While reviewing the solidfire patch, I noticed that a dummy getter/setter 
implementations with TODO comments in the PrimaryDataStoreImpl in  were merged 
into master.  I have opened a defect [1] for this issue, as the code will not 
work as expected (they are not actually working with the internal state of the 
object as expected).  

Speaking generally, every review I have performed for 4.2.0 has contained TODO 
comments, as well, tab characters and improper indentation.  Please check 
patches for these issues before submission.  For me, patches with TODOs are an 
immediate -1 because it conveys that the implementation is incomplete.  The 
formatting issues are minor, but easily rectified with a quick code format in 
an IDE.  

Thanks,
-John

[1]: https://issues.apache.org/jira/browse/CLOUDSTACK-3277

RE: [MERGE] Merge VMSync improvement branch into master

[Sudha Ponnaganti]

Ideally I would like to see all validation to be done on feature branch - BVTs 
and also manual validation of the P1 test cases from VM Sync test plan just 
like object store validation - sadhu has signed up for it along with Ilya. This 
would help us to identify feature specific issues. 

We are running BVTs right now which have high failure rate. Focusing on this 
part right now to reach parity with Master branch. 


-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Thursday, June 27, 2013 5:32 PM
To: dev@cloudstack.apache.org
Subject: Re: [MERGE] Merge VMSync improvement branch into master

I agree with John that a change like this is very hard to test in an automated 
fashion. Still i have been looking at the numbers for the code coverage with 
cobertura. I was a bit disappointed to find that we have not made any progress 
with this merge with regards to unit tests and total code coverage. We do not 
seem to be in a worse shape than before.

@Sudha, it would be nice if you could add your view on this patch from the QA 
perspective? How would this patch affect your planning for example?

Cheers,

Hugo

On Jun 27, 2013, at 5:12 PM, John Burwell  wrote:

> @David The types of concurrency changes introduced in this patch are 
> extremely difficult to completely test in an automated fashion.
> Therefore, code review for correctness is critical to ensure quality.
> To be clear, I am not questioning the value of automated testing.  I 
> am just noting that it's next to impossible to achieve full coverage, 
> and code review is an critical supplement.
> 
> @Ilya I plan to review this patch, but I will be able to start until 
> next week.  I am also still reviewing object_store (a separate 
> procedural issue for another thread), and need to complete solidfire.
> This backlog is precisely why need to be reviewing iteratively 
> throughout the dev cycle.
> 
> Thanks,
> -John
> 
> On Jun 27, 2013, at 7:35 PM, David Nalley  wrote:
> 
>> On Thu, Jun 27, 2013 at 5:51 PM, Hugo Trippaers  wrote:
>>> 
>>> I think Ilya offers is great, my current stance is also to see how we can 
>>> bring this forward.
>>> 
>>> I've had the opportunity to meet with several people at the Citrix office 
>>> in Santa Clara, i'm actually working from their office at this moment. I 
>>> think it's also the responsibility of someone who put in a -1 to work with 
>>> the original committer to get the situation resolved. So i'll invest the 
>>> time to help with the review as well.
>>> 
>>> It would be great if Alex or Kelven could take the time to explain how this 
>>> feature has been tested. That would give the community some insight as well.
>>> 
>>> My main technical problem with this merge is that stuff is moving all over 
>>> the place without having even the slightest idea why. Now having discussed 
>>> this with Alex in person i get the general idea of this merge, so can 
>>> actually try to review it.
>>> 
>>> I think that John have nicely explained what we could do to prevent 
>>> situations like this in advance. I fully understand that big features or 
>>> rewrites don't happen overnight and might show up near the end of the 
>>> release cycle. With the time based release cycle it's always a risk that 
>>> some feature might not make it in on time. Getting more people involved and 
>>> chunking the commits into master will greatly speed up the reviewing 
>>> process.
>>> 
>>> I'll get back to this after spending some time on reviewing the actual 
>>> patch. In fact i would like to ask more people to have a look at this patch 
>>> and reply to this thread with comments or remarks.
>>> 
>>> Cheers,
>>> 
>>> Hugo
>> 
>> So the problem in my mind, is that we don't have a way of verifying 
>> that master isn't broken, and won't be broken by any given merge. I 
>> look at even the minimal level of automated testing that I see today, 
>> and ~20% of integration tests are failing[1]. The regression set of 
>> tests (which isn't running as often) is seeing 75% of tests 
>> failing[2]. Heaping on more change when we are demonstrably already 
>> failing in many places is not behaving responsibly IMO.
>> The question I'd pose is this - running the various automated tests 
>> is pretty cheap - whats the output of that compared to the current 
>> test output on master? Better or worse? If it hasn't been done, why not?
>> I desperately want these features, but not necessarily at the cost of 
>> further destabilizing what we have now in master - we can't continue 
>> accruing technical debt.
>> 
>> --David
>> 
>> [1] 
>> http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matr
>> ix/lastCompletedBuild/testReport/ [2] 
>> http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-regression
>> -matrix/28/testReport/

[ACS42] Automation Blockers

[Sudha Ponnaganti]

Hi,

Following 2 issues are blocking automation runs - can these be fixed ASAP. If 
check-ins are not done to fix these in 24 hours, we have to revert the changes 
that caused these failures.

CLOUDSTACK-3167  [Automation] List VLAN range API call failed with null 
pointer exceptionBharat Kumar
CLOUDSTACK-3260  [Automation] Volume attach and detach failed with null 
pointer exception in vmwareUnassign


Thanks
/sudha

[ACS42] Blockers - June 28th

[Sudha Ponnaganti]

List of blockers - pl take ownership of unassigned ones. Need to address these 
aggressively. QA would be blocked on validation or automation if these are not 
addressed.


KeySummary Assignee
CLOUDSTACK-643KVM snapshots deleted on UI/API do not physically 
delete from secondary storageUnassigned
CLOUDSTACK-2155  Anti-Affinity -When Vm deployment is done in parallel 
, anti-affinity rule is not honored.Prachi Damle
CLOUDSTACK-2385  template download fails with Unexpected failure in 
Vmware.Venkata Siva Vijayendra Bhamidipati
CLOUDSTACK-2433  Enable rps and rfs support on virtual router.
Abhinandan Prateek
CLOUDSTACK-2630  Object_Store_Refactor - Snapshots - There is no delta 
snapshots being created for subsequent snapshots when multiple snapshots are 
taken for root /data volumes.   edison su
CLOUDSTACK-2660  Object_Store_Refactor - Vmware - Not able create 
snapshot of root volume.edison su
CLOUDSTACK-2777  AWSAPI: build and packaging issue causing EC2 SOAP 
test failuresRayees Namathponnan
CLOUDSTACK-2823  SystemVMs start fail on CentOS 6.4 Unassigned
CLOUDSTACK-2927  [AWSAPI] EC2 SOAP calls fail with 'Uninitalized user 
context' errorUnassigned
CLOUDSTACK-2943  [ZWPS][VMWARE]: NPE while creating volume from 
snapshot   Sateesh Chodapuneedi
CLOUDSTACK-2966  System VM's failed to start when using 64 bit 
Templates.  Abhinandan Prateek
CLOUDSTACK-2994  [Automation][Object_Store] Failed to attach ISO to vm 
Unassigned
CLOUDSTACK-3074  Automation framework need to be updated for adding DC 
to zone, in vmware  Prasanna Santhanam
CLOUDSTACK-3082  System VMs are failed to start with Xen 6.2.0( Failing 
to create VIF's)  Sanjay Tripathi
CLOUDSTACK-3167  [Automation] List VLAN range API call failed with null 
pointer exceptionBharat Kumar
CLOUDSTACK-3184  updatevirtual machine api gives java NPE 
Sanjay Tripathi
CLOUDSTACK-3189  Primary storage usage is not getting decremented after 
deleting the DATA volumes   Sanjay Tripathi
CLOUDSTACK-3237  [vmware][SM] Migrate volume is failing when there are 
snapshots for that volume Unassigned
CLOUDSTACK-3238  creating template from snapshot fails in vmware
  Unassigned
CLOUDSTACK-3240  [Multiple_IP_Ranges] Failed to create ip alias on VR 
while deploying guest vm with ip address from new CIDRUnassigned
CLOUDSTACK-3260  [Automation] Volume attach and detach failed with null 
pointer exception in vmwareUnassigned
CLOUDSTACK-3264  [ZWPS]NPE while finding storage pools for migration
  Unassigned
CLOUDSTACK-3277  TODO/Non-Implemented Methods in 
PrimaryDataStoreEntityImpl  Unassigned

AttachVolumeCommand no longer in use?

[Mike Tutkowski]

Hi,

I've been trying to reconcile a ton of changes that were merged in this
week.

We used to pass an AttachVolumeCommand to CitrixResourceBase, but now it's
called AttachCommand and CitrixResourceBase doesn't know anything about it
(this merge issue is in VolumeManagerImpl).

I'm a bit confused at the moment on how to handle this merge issue.

Does anyone know anything about this change?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

RE: AttachVolumeCommand no longer in use?

[Donal Lafferty]

Yeah, I noticed that as well.  

The implementation of AttachCommand is in XenServerStorageProcessor.  Look for 
handleStorageCommands in  CitrixResourceBase.

Also, could you send me a JSON encoded version of the command?



> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: 28 June 2013 3:30 PM
> To: John Burwell; dev@cloudstack.apache.org
> Subject: AttachVolumeCommand no longer in use?
> 
> Hi,
> 
> I've been trying to reconcile a ton of changes that were merged in this week.
> 
> We used to pass an AttachVolumeCommand to CitrixResourceBase, but now
> it's called AttachCommand and CitrixResourceBase doesn't know anything
> about it (this merge issue is in VolumeManagerImpl).
> 
> I'm a bit confused at the moment on how to handle this merge issue.
> 
> Does anyone know anything about this change?
> 
> Thanks!
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Re: AttachVolumeCommand no longer in use?

[Mike Tutkowski]

So, basically, it could take a while to merge and re-test this.

This week has been kind of a mess with all of the merges.

Do you know if we have the weekend to tie up loose ends?


On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
wrote:

> Yeah, I noticed that as well.
>
> The implementation of AttachCommand is in XenServerStorageProcessor.  Look
> for handleStorageCommands in  CitrixResourceBase.
>
> Also, could you send me a JSON encoded version of the command?
>
>
>
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: 28 June 2013 3:30 PM
> > To: John Burwell; dev@cloudstack.apache.org
> > Subject: AttachVolumeCommand no longer in use?
> >
> > Hi,
> >
> > I've been trying to reconcile a ton of changes that were merged in this
> week.
> >
> > We used to pass an AttachVolumeCommand to CitrixResourceBase, but now
> > it's called AttachCommand and CitrixResourceBase doesn't know anything
> > about it (this merge issue is in VolumeManagerImpl).
> >
> > I'm a bit confused at the moment on how to handle this merge issue.
> >
> > Does anyone know anything about this change?
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

RE: AttachVolumeCommand no longer in use?

[Donal Lafferty]

Merge.  AFAIK, it's already merged to Master

Retest?  I'm out of the loop.  I'm working on adding Hyper-V to Master, and not 
the current release.


> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: 28 June 2013 3:57 PM
> To: dev@cloudstack.apache.org
> Subject: Re: AttachVolumeCommand no longer in use?
> 
> So, basically, it could take a while to merge and re-test this.
> 
> This week has been kind of a mess with all of the merges.
> 
> Do you know if we have the weekend to tie up loose ends?
> 
> 
> On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
> wrote:
> 
> > Yeah, I noticed that as well.
> >
> > The implementation of AttachCommand is in XenServerStorageProcessor.
> > Look for handleStorageCommands in  CitrixResourceBase.
> >
> > Also, could you send me a JSON encoded version of the command?
> >
> >
> >
> > > -Original Message-
> > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > > Sent: 28 June 2013 3:30 PM
> > > To: John Burwell; dev@cloudstack.apache.org
> > > Subject: AttachVolumeCommand no longer in use?
> > >
> > > Hi,
> > >
> > > I've been trying to reconcile a ton of changes that were merged in
> > > this
> > week.
> > >
> > > We used to pass an AttachVolumeCommand to CitrixResourceBase, but
> > > now it's called AttachCommand and CitrixResourceBase doesn't know
> > > anything about it (this merge issue is in VolumeManagerImpl).
> > >
> > > I'm a bit confused at the moment on how to handle this merge issue.
> > >
> > > Does anyone know anything about this change?
> > >
> > > Thanks!
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the
> > > cloud
> > > *(tm)*
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Is there any patch file CS 4.1 to xen-6.2.0

[keerthiraja s. Jegannathan]

Hi All,

 

Is there any patch file for cloudstack-4.1 to added xenserver-6.2.0 .

 

I knew that 
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
 this file plays vital role to added xenserver-6.2.0 but it support only upto 
6.1 do u guys have any patch Just but adding into my cloudstack location will 
help me.

 

 

I have installed Cloudstack as RPM it would be better to patch like script to 
work in my installed CS.

 

Thanks,

Keerthi

RE: vmware help for dynamic scaling

[Sateesh Chodapuneedi]

Nitin,
Yes, given a guestos id of a VM, we can get if it supports hotadd of memory or 
cpu.
I can provide a method to do this.

Regards,
Sateesh

From: Nitin Mehta
Sent: 27 June 2013 17:54
To: dev@cloudstack.apache.org
Cc: Kelven Yang; Sateesh Chodapuneedi
Subject: vmware help for dynamic scaling

Hi All,
I have been working on dynamic scaling vm memory and cpu and trying to tune it 
for vmware hypervisor, but being a novice need some assistance.
Vmware publishes a list for  vmware guest os and their supported capabilities 
for each vmware release. Example for guest OS Ubuntu 10.04 and ESX some release 
4.x we only support hot add of vcpu (and not hot add memory)

GuestOS Release

Ubuntu 10.04 Desktop

Supported Releases

ESX 4.1 U31, 2, 3, 4, 5, 6, 4.1 U21, 2, 3, 4, 5, 6, 4.1 U11, 2, 3, 4, 5, 6, 
4.12, 1, 6, 5, 4, 3

Support Details

Hot Add vCPU etc
More info @ 
http://partnerweb.vmware.com/comp_guide2/pdf/VMware_GOS_Compatibility_Guide.pdf

Vmware says that the attributes hot add cpu and memory should be turned on 
during deployment of vm (i.e. As part of deployvm api) so that in future the 
user can dynamically scale cpu and memory(scale vm api). Now I wanted to 
understand how to enforce this check in Cloudstack. The best would be Vmware 
providing a method to check whether hot add cpu and memory is enabled for the 
current GuestOS version in the vmware releae. Is there an api available for the 
same ? If not, we have to go down the path of maintaining this list in CS of  
vmware guest os and their supported capabilities for each vmware release which 
is going to be extremely hard to maintain and error prone.

Thanks,
-Nitin

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

[John Burwell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11479/#review22508
---



api/src/com/cloud/offering/DiskOffering.java


Strip out additional tab charcters



api/src/com/cloud/offering/DiskOffering.java


When would it be valid for the value of this property to be null?  Seems 
like it should be boolean, not Boolean.



api/src/com/cloud/storage/Volume.java


Strip out tab charcaters



api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java


Strip out tab characters



api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java


Strip out tab characters



api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java


Strip out tab characters



api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java


Strip out tab characters



api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java


Strip out tab characters



api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java


Strip out tab characters



api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java


Strip out tab characters



api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java


Strip out tab characters



api/src/org/apache/cloudstack/api/response/VolumeResponse.java


Strip out tab characters



api/src/org/apache/cloudstack/api/response/VolumeResponse.java


Strip out tab characters



core/src/com/cloud/agent/api/AttachVolumeAnswer.java


Strip out tab characters



core/src/com/cloud/agent/api/AttachVolumeCommand.java


Fix formatting/continuation from the previous line



core/src/com/cloud/agent/api/AttachVolumeCommand.java


Fix indentation



core/test/org/apache/cloudstack/api/agent/test/AttachVolumeAnswerTest.java


Create a new AttachVolumeAnswer constructor that only takes two parameters 
and encapsulates the default value.  Leaky abstraction that negatively impacts 
maintenance.



engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreParameters.java


Strip out tab characters



engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreParameters.java


Strip out tab characters



engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreParameters.java


Strip out tab characters



engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java


Strip out tab characters



engine/schema/src/com/cloud/storage/DiskOfferingVO.java


1) The minIops and maxIops attributes should be private.
2) Strip out tab characters



engine/schema/src/com/cloud/storage/DiskOfferingVO.java


Strip out tab characters



engine/schema/src/com/cloud/storage/DiskOfferingVO.java


1) Fix identation
2) Strip out tab characters



engine/schema/src/com/cloud/storage/VolumeVO.java


1) Strip out tab characters
2) Make minIops and maxIops attributes private



engine/schema/src/com/cloud/storage/VolumeVO.java


Strip out tab characters



engine/schema/src/com/cloud/storage/VolumeVO.java


1) Strip out tab characters
2) Fix formatting from the previous line



engine/schema/src/com/cloud/storage/VolumeVO.java


Strip out additional tab characters



engine/storage/src/org/apache/cloudstack/storage/datastore/PrimaryDataStoreEntityImpl.java

Re: [ACS42] Release Status Update

[John Burwell]

Mike,

I (finally) completed the review of the patch.  The TL;DR is that I am removing 
my -1 on the patch so long as a supplemental patch that addresses the issues 
raised is submitted to Review Board for a third review .  The following items 
are concern me, and must be addressed before release:

Error handling in the patch catches and throws Exception too broadly.  There is 
also no attempt in methods manipulating the hypervisor to back out partial 
changes.  I am concerned that errors could put a hypervisor in an inconsistent 
state.
There is a manually built thread pool in the VMwareResource.  What is driving 
the use of multiple threads?  It feels like pre-mature optimization.  If it is 
necessary, ExceutorService should be used.
There are unresolved TODOs in the PrimaryDataStoreImpl where getters are not 
returning internal state as expected

Since we had Collab this week and I couldn't review it, I don't think we should 
prevent the feature from coming into the release.  I also think these issues 
can addressed rather quickly next week.  Finally, this patch has had two rounds 
of review, so I don't expect the need for a fourth round.  As such, let's get 
it merged and do the last bits of cleanup next week.

Thanks,
-John

On Jun 26, 2013, at 11:42 PM, Mike Tutkowski  
wrote:

> Hey John,
> 
> I know you were at a CloudStack Meetup today, but any thoughts on when we are 
> going to get Storage QoS (the SolidFire plug-in) merged into master?
> 
> Thanks!
> 
> 
> On Wed, Jun 26, 2013 at 9:37 PM, Animesh Chaturvedi 
>  wrote:
> Folks
> 
> The status for features or improvement is depicted in table below
> 
> |-+---+---|
> | New Features / Improvements | This Week | TwoWeekAgo|
> |-+---+---|
> | Closed  | 8 | 7 |
> | Resolved|56 |52 |
> | In Progress |13 |17 |
> | Reopened| 1 | 2 |
> | Ready To Review | 2 | 2 |
> | Open|22 |23 |
> |-+---+---|
> | Total   |   102 |   103 |
> |-+---+---|
> 
> We are now just two days away from feature freeze, but still there are many 
> open tickets. If the feature or improvement is unlikely to be wrapped up by 
> 6/28 it should be moved out of 4.2
> 
> 
> 
> As for bugs here is a summary for this week:
> 
>   Bugs| This Week| Two Week Ago
>  
> -+---+--+---+---+---+--+---+---
>   |   Blocker   Critical   Major   Total |   Blocker   
> Critical   Major   Total
>  
> -+---+--+---+---+---+--+---+---
>   Incoming| 4 19  37  68 | 8 
> 20  29  60
>   Outgoing|19 42  34 102 |18 
> 10  42  76
>   Open Unassigned | 4 27 116 184 | 7 
> 35  93 166
>   Open Total  |17 62 223 365 |19 
> 74 192 345
> 
> 
> 
> The outgoing defect fix rate is much higher than incoming defects which is a 
> good sign but we still have large number of open defects. We have a large 
> number of unassigned open defects and it is increasing every week. If you are 
> interested in helping out on defects please check the release dashboard  
> http://s.apache.org/M5k
> 
> The resolved but not verified /closed has gone up now to 458 and needs to be 
> contained. If you reported a issues and fixed it yourself but did not close 
> it please take a moment to close the defect after verification.
> 
> I also wanted to call out that there are large number of patches on review 
> board. If you are reviewer please attend to your reviews. If you are a 
> submitter and want your contribution to be included in 4.2 please follow 
> through with your reviewers.
> 
> 
> Comments/feedback on this release status update are appreciated. You can 
> always visit the 4.2 Release dashboard http://s.apache.org/M5k for the 
> current status.
> 
> 
> Thanks
> Animesh
> 
> 
> 
> -- 
> Mike Tutkowski
> Senior CloudStack Developer, SolidFire Inc.
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud™

object_store Merge

[John Burwell]

All,

We had a procedural snafu earlier this week when the object_store branch was 
merged without me removing my -1.  Animesh, Edision, Min, and myself discussed 
this issue Wednesday afternoon, and it was an honest misunderstanding of the 
rules.  Edison pushed a review request to the list that I didn't see.  Since I 
didn't respond within in 72 hours, he thought lazy consensus applied and 
performed the merge.  For this merge, we will leave it in master assuming that 
no significant issues will be found when I will review the patch next week.  If 
I do find a reason not remove the -1, we will burn that bridge when we come it.

To be clear, once a -1 is lodged against a branch, it can not be merged until 
that -1 is removed.  As we have discussed on other threads, those placing a -1 
on a merge should work with all due haste to resolve their issues with the 
merge requester.  I apologize to Edison for failing to see the request.

Thanks,
-John

Re: Is there any patch file CS 4.1 to xen-6.2.0

[Prasanna Santhanam]

Try the one in this review:
https://reviews.apache.org/r/11341/

The XenServer Java SDK for 6.2 is different from the one in our
codebase.  So whether the patch will work is still unclear. Your test
results will be appreciated.

Keep us informed

Thanks,

-- 
Prasanna.,

On Fri, Jun 28, 2013 at 08:58:48PM +0530, keerthiraja s. Jegannathan wrote:
> Hi All,
> 
>  
> 
> Is there any patch file for cloudstack-4.1 to added xenserver-6.2.0 .
> 
>  
> 
> I knew that 
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  this file plays vital role to added xenserver-6.2.0 but it support only upto 
> 6.1 do u guys have any patch Just but adding into my cloudstack location will 
> help me.
> 
>  
> 
>  
> 
> I have installed Cloudstack as RPM it would be better to patch like script to 
> work in my installed CS.
> 
>  
> 
> Thanks,
> 
> Keerthi
> 



Powered by BigRock.com

Re: object_store Merge

[John Burwell]

All,

One quick amendment to the compromise we worked out on Wednesday.  Edison and 
Min will resolve any issues discovered in my review, and if necessary, push 
another patch through Review Board for a third round review.

Thanks,
-John

On Jun 28, 2013, at 11:57 AM, John Burwell  wrote:

> All,
> 
> We had a procedural snafu earlier this week when the object_store branch was 
> merged without me removing my -1.  Animesh, Edision, Min, and myself 
> discussed this issue Wednesday afternoon, and it was an honest 
> misunderstanding of the rules.  Edison pushed a review request to the list 
> that I didn't see.  Since I didn't respond within in 72 hours, he thought 
> lazy consensus applied and performed the merge.  For this merge, we will 
> leave it in master assuming that no significant issues will be found when I 
> will review the patch next week.  If I do find a reason not remove the -1, we 
> will burn that bridge when we come it.
> 
> To be clear, once a -1 is lodged against a branch, it can not be merged until 
> that -1 is removed.  As we have discussed on other threads, those placing a 
> -1 on a merge should work with all due haste to resolve their issues with the 
> merge requester.  I apologize to Edison for failing to see the request.
> 
> Thanks,
> -John

Re: PrimaryDataStoreEntityImpl TODOs

[Prasanna Santhanam]

+1

The TODOs, @author tags and minor typos irks me too. Typos are
understandable and I fix them when I see them. But it we should be
keep the code clean of IDE introduced comments like TODOs. Please
consider configuring your IDEs.

Let's all _care_ for our codebase ... just a little.

Now everyone go clean your classes :)

On Fri, Jun 28, 2013 at 10:06:47AM -0400, John Burwell wrote:
> All,
> 
> While reviewing the solidfire patch, I noticed that a dummy
> getter/setter implementations with TODO comments in the
> PrimaryDataStoreImpl in  were merged into master.  I have opened a
> defect [1] for this issue, as the code will not work as expected
> (they are not actually working with the internal state of the object
> as expected).  
> 
> Speaking generally, every review I have performed for 4.2.0 has
> contained TODO comments, as well, tab characters and improper
> indentation.  Please check patches for these issues before
> submission.  For me, patches with TODOs are an immediate -1 because
> it conveys that the implementation is incomplete.  The formatting
> issues are minor, but easily rectified with a quick code format in
> an IDE.  
> 
> Thanks,
> -John
> 
> [1]: https://issues.apache.org/jira/browse/CLOUDSTACK-3277

-- 
Prasanna.,


Powered by BigRock.com

Re: [MERGE] Simulator Storage Fixes to master (was Re: How does the plugin model work for storage providers?)

[Prasanna Santhanam]

On Fri, Jun 28, 2013 at 12:28:17AM +, Edison Su wrote:
> Hi Prasanna, thanks for your great effort to get simulator work. I
> reviewed all your changes, looks good to me, while there is only one
> thing that I don't like: the implementation of
> SimulatorImageStoreDriverImpl, so I rewrote it with a simpler
> implementation. The commit number is
> a2ec1daf8422d0a1c789e331a3261b05a4501060, please double check.

Thanks, it's got real good use for testing. We need to start using the
simulator more and more ... and make improvements to it.

Thanks for the fix. I didn't fully comprehend the AsyncDispatcher so
that's why the code plugged into the DB like that.  Now it looks
clearer.


-- 
Prasanna.,


Powered by BigRock.com

Re: Master broken on systemVM start

[Min Chen]

Prasanna, glad to know that CLOUDSTACK-3137 is resolved. I fixed
CLOUDSTACK-3249 yesterday for a corner case reported by Alena, but I could
not reproduce CLOUDSTACK-3137 on my environment at all. For the JSON
issue, I can only tell that it is inconsistent systemvm issue between
management server and system vm. In 4.2, we changed ArrayTypeAdaptor to
return full qualified command class name, so I don't quite get why you are
still seeing the abbreviated command name in your log. Yes,
StartupSecondaryStorageCommand is still there. From your log, it seems
that your ssvm has the old code.

Thanks
-min

On 6/28/13 12:03 AM, "Prasanna Santhanam"  wrote:

>On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
>> On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
>> > Json deserialization issue is caused by out-of-dated systemvm.iso on
>>your
>> > hypervisor host. You need rebuilding systemvm.iso and deployed to your
>> > hypervisor host.
>> > 
>> 
>> CLOUDSTACK-3137 exists and seems to be a problem with HA and
>> systemVMs. The JSON serialization also exists for me despite
>> rebuidling the systemvm with -Dsystemvm.
>
>Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
>jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.
>
>> 
>> I see the deserialization error when the ssvm agent sends this to
>> management server:
>> 
>> 2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent] (Agent-Handler-1:)
>>Sending Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags:
>>101, 
>>[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter
>>":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-1-V
>>M","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.168.56
>>.144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00:00:
>>42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84:00:
>>00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.56.21
>>7","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:00:00:1
>>2","resourceName":"NfsSecondaryStorageResource","wait":0}}] }
>> 
>> This happens both when I have a s3 store added and a regular nfs
>>storage added.
>> Is the startupcommand still reqd?
>> 
>> -- 
>> Prasanna.,
>> 
>> 
>> Powered by BigRock.com
>
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>

Re: [ACS42] Release Status Update

[Mike Tutkowski]

Hi John,

OK, this sounds good.

I updated from master yesterday and was resolving some (major) conflicts
last night and this morning. I want to get in some more testing before I
commit.

Sounds good on the points you make. It should be, as you say, easy to
resolve them.

Thanks,
Mike


On Fri, Jun 28, 2013 at 9:50 AM, John Burwell  wrote:

> Mike,
>
> I (finally) completed the review of the patch.  The TL;DR is that I am
> removing my -1 on the patch so long as a supplemental patch that addresses
> the issues raised is submitted to Review Board for a third review .  The
> following items are concern me, and must be addressed before release:
>
>
>- Error handling in the patch catches and throws Exception too
>broadly.  There is also no attempt in methods manipulating the hypervisor
>to back out partial changes.  I am concerned that errors could put a
>hypervisor in an inconsistent state.
>- There is a manually built thread pool in the VMwareResource.  What
>is driving the use of multiple threads?  It feels like pre-mature
>optimization.  If it is necessary, ExceutorService should be used.
>- There are unresolved TODOs in the PrimaryDataStoreImpl where getters
>are not returning internal state as expected
>
>
> Since we had Collab this week and I couldn't review it, I don't think we
> should prevent the feature from coming into the release.  I also think
> these issues can addressed rather quickly next week.  Finally, this patch
> has had two rounds of review, so I don't expect the need for a fourth
> round.  As such, let's get it merged and do the last bits of cleanup next
> week.
>
> Thanks,
> -John
>
> On Jun 26, 2013, at 11:42 PM, Mike Tutkowski 
> wrote:
>
> Hey John,
>
> I know you were at a CloudStack Meetup today, but any thoughts on when we
> are going to get Storage QoS (the SolidFire plug-in) merged into master?
>
> Thanks!
>
>
> On Wed, Jun 26, 2013 at 9:37 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
>> Folks
>>
>> The status for features or improvement is depicted in table below
>>
>> |-+---+---|
>> | New Features / Improvements | This Week | TwoWeekAgo|
>> |-+---+---|
>> | Closed  | 8 | 7 |
>> | Resolved|56 |52 |
>> | In Progress |13 |17 |
>> | Reopened| 1 | 2 |
>> | Ready To Review | 2 | 2 |
>> | Open|22 |23 |
>> |-+---+---|
>> | Total   |   102 |   103 |
>> |-+---+---|
>>
>> We are now just two days away from feature freeze, but still there are
>> many open tickets. If the feature or improvement is unlikely to be wrapped
>> up by 6/28 it should be moved out of 4.2
>>
>>
>>
>> As for bugs here is a summary for this week:
>>
>>   Bugs| This Week| Two Week Ago
>>
>>  
>> -+---+--+---+---+---+--+---+---
>>   |   Blocker   Critical   Major   Total |   Blocker
>> Critical   Major   Total
>>
>>  
>> -+---+--+---+---+---+--+---+---
>>   Incoming| 4 19  37  68 | 8
>> 20  29  60
>>   Outgoing|19 42  34 102 |18
>> 10  42  76
>>   Open Unassigned | 4 27 116 184 | 7
>> 35  93 166
>>   Open Total  |17 62 223 365 |19
>> 74 192 345
>>
>>
>>
>> The outgoing defect fix rate is much higher than incoming defects which
>> is a good sign but we still have large number of open defects. We have a
>> large number of unassigned open defects and it is increasing every week. If
>> you are interested in helping out on defects please check the release
>> dashboard  http://s.apache.org/M5k
>>
>> The resolved but not verified /closed has gone up now to 458 and needs to
>> be contained. If you reported a issues and fixed it yourself but did not
>> close it please take a moment to close the defect after verification.
>>
>> I also wanted to call out that there are large number of patches on
>> review board. If you are reviewer please attend to your reviews. If you are
>> a submitter and want your contribution to be included in 4.2 please follow
>> through with your reviewers.
>>
>>
>> Comments/feedback on this release status update are appreciated. You can
>> always visit the 4.2 Release dashboard http://s.apache.org/M5k for the
>> current status.
>>
>>
>> Thanks
>> Animesh
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o:

Re: AttachVolumeCommand no longer in use?

[Mike Tutkowski]

Oh, yeah, to clarify, I just meant I need to continue to merge these large
changes into my code and then re-test my code before I commit it.


On Fri, Jun 28, 2013 at 9:23 AM, Donal Lafferty
wrote:

> Merge.  AFAIK, it's already merged to Master
>
> Retest?  I'm out of the loop.  I'm working on adding Hyper-V to Master,
> and not the current release.
>
>
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: 28 June 2013 3:57 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: AttachVolumeCommand no longer in use?
> >
> > So, basically, it could take a while to merge and re-test this.
> >
> > This week has been kind of a mess with all of the merges.
> >
> > Do you know if we have the weekend to tie up loose ends?
> >
> >
> > On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
> > wrote:
> >
> > > Yeah, I noticed that as well.
> > >
> > > The implementation of AttachCommand is in XenServerStorageProcessor.
> > > Look for handleStorageCommands in  CitrixResourceBase.
> > >
> > > Also, could you send me a JSON encoded version of the command?
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > > > Sent: 28 June 2013 3:30 PM
> > > > To: John Burwell; dev@cloudstack.apache.org
> > > > Subject: AttachVolumeCommand no longer in use?
> > > >
> > > > Hi,
> > > >
> > > > I've been trying to reconcile a ton of changes that were merged in
> > > > this
> > > week.
> > > >
> > > > We used to pass an AttachVolumeCommand to CitrixResourceBase, but
> > > > now it's called AttachCommand and CitrixResourceBase doesn't know
> > > > anything about it (this merge issue is in VolumeManagerImpl).
> > > >
> > > > I'm a bit confused at the moment on how to handle this merge issue.
> > > >
> > > > Does anyone know anything about this change?
> > > >
> > > > Thanks!
> > > >
> > > > --
> > > > *Mike Tutkowski*
> > > > *Senior CloudStack Developer, SolidFire Inc.*
> > > > e: mike.tutkow...@solidfire.com
> > > > o: 303.746.7302
> > > > Advancing the way the world uses the
> > > > cloud
> > > > *(tm)*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: BVT failure - CLOUDSTACK-3167

[Min Chen]

Yes, Edison and I will look at those object_store related bugs.

Thanks
-min

On 6/28/13 2:00 AM, "Prasanna Santhanam"  wrote:

>On Tue, Jun 25, 2013 at 11:27:42AM +0530, Prasanna Santhanam wrote:
>> On Tue, Jun 25, 2013 at 05:25:08AM +, Rayees Namathponnan wrote:
>> > 
>> > List VLAN range API call failed with null pointer exception in
>> > latest build from master and master-6-17-stable branch build,
>> > 
>> > SSVM and router test cases failed due this from BVT
>> > 
>> > 
>>http://jenkins.cloudstack.org/view/cloudstack-qa/job/test-smoke-matrix/su
>>ite=test_ssvm/lastCompletedBuild/testReport/
>> > 
>>http://jenkins.cloudstack.org/view/cloudstack-qa/job/test-smoke-matrix/su
>>ite=test_routers/524/testReport/junit/
>> > 
>> 
>> Here's some more:
>>CLOUDSTACK-3176 KVM DeployVM fails with unable to get answer that is
>>of type StartAnswer (blocker)
>Kawai-san fixed this
>
>Following are still looking for a fix. They're related to the
>object_store merge.
>
>>CLOUDSTACK-3175 DetachVolume command fails with Internal Server Error
>>CLOUDSTACK-3146 Extract Template command fails with Unsupported
>>Command: storage.CreateEntityDownloadURLCommand on SSVM
>>CLOUDSTACK-3145 StorageManager-Scavenger NPEs when cleaning up
>>templates
>>CLOUDSTACK-3144 [Automation] Deletion of templates failing. Fails to
>>find image store housing template
>
>Edison/Min - can you guys help with the above?
>
>Thanks,
>
> 
>-- 
>Prasanna.,
>
>
>Powered by BigRock.com
>

Jenkins and IRC

[Hugo Trippaers]

Heya,

I've added a parameterised job to jenkins that will run a complete build on any 
branch. You can kick it off on jenkins.cloudstack.org and enter any branch as 
the parameter. It will do the regular maven build with the clean and test 
actions. It will also generate a cobertura coverage report so you can easily 
see how much code your unit tests cover.

Also its possible to kick this build right from our IRC channel. For example 
the following command will build the vmsync branch:

!jenkins build cloudstack-build-parameterized now branch=vmsync

List the current builds using the '!jenkins cb' command.

So whenever you push a branch to apache, feel free to ask cato to build it for 
you. 

Cheers,

Hugo


@David, remember that nginx proxy timeout setting we discussed ages ago? Would 
be nice to get that sorted so we can use some extra cloud power on 
jenkins.cloudstack.org. Any ideas on how we can get that done?

Re: Jenkins and IRC

[Prasanna Santhanam]

On Fri, Jun 28, 2013 at 10:09:41AM -0700, Hugo Trippaers wrote:
> Heya,
> 
> I've added a parameterised job to jenkins that will run a complete
> build on any branch. You can kick it off on jenkins.cloudstack.org
> and enter any branch as the parameter. It will do the regular maven
> build with the clean and test actions. It will also generate a
> cobertura coverage report so you can easily see how much code your
> unit tests cover.
> 
> Also its possible to kick this build right from our IRC channel. For
> example the following command will build the vmsync branch:
> 
> !jenkins build cloudstack-build-parameterized now branch=vmsync
> 
> List the current builds using the '!jenkins cb' command.
> 
> So whenever you push a branch to apache, feel free to ask cato to
> build it for you. 

Awesome! With Ian's help I plan to put in pretty Sonar graphs (if you
like that sort of thing) as well for the static analysis checks. 

> 
> Cheers,
> 
> Hugo
> 
> 
> @David, remember that nginx proxy timeout setting we discussed ages
> ago? Would be nice to get that sorted so we can use some extra cloud
> power on jenkins.cloudstack.org. Any ideas on how we can get that
> done?

I plan on moving the current jenkins node on to a CloudStack setup
along with configuring jenkins purely via github/yaml config files.
still exploring. I think there should be some nginx puppet recipes
around for quick configuration.  

-- 
Prasanna.,


Powered by BigRock.com

Re: Master broken on systemVM start

[Prasanna Santhanam]

I deleted all traces of systemvm.iso from my codebase
$ find . -name systemvm.iso | xargs -n1 rm -f

Then reverted my devcloud snapshot to old state and don't see this
error again.

I wonder by mvn doesn't do a good job of cleaning though :/

Thanks for the fixes to the bugs and the upcoming fixes for the new
ones. I'll be switching over the test infra to run object store backed
secondary only from next week so we should have more results. 

-- 
Prasanna.,

On Fri, Jun 28, 2013 at 04:35:29PM +, Min Chen wrote:
> Prasanna, glad to know that CLOUDSTACK-3137 is resolved. I fixed
> CLOUDSTACK-3249 yesterday for a corner case reported by Alena, but I could
> not reproduce CLOUDSTACK-3137 on my environment at all. For the JSON
> issue, I can only tell that it is inconsistent systemvm issue between
> management server and system vm. In 4.2, we changed ArrayTypeAdaptor to
> return full qualified command class name, so I don't quite get why you are
> still seeing the abbreviated command name in your log. Yes,
> StartupSecondaryStorageCommand is still there. From your log, it seems
> that your ssvm has the old code.
> 
> Thanks
> -min
> 
> On 6/28/13 12:03 AM, "Prasanna Santhanam"  wrote:
> 
> >On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
> >> On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
> >> > Json deserialization issue is caused by out-of-dated systemvm.iso on
> >>your
> >> > hypervisor host. You need rebuilding systemvm.iso and deployed to your
> >> > hypervisor host.
> >> > 
> >> 
> >> CLOUDSTACK-3137 exists and seems to be a problem with HA and
> >> systemVMs. The JSON serialization also exists for me despite
> >> rebuidling the systemvm with -Dsystemvm.
> >
> >Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
> >jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.
> >
> >> 
> >> I see the deserialization error when the ssvm agent sends this to
> >> management server:
> >> 
> >> 2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent] (Agent-Handler-1:)
> >>Sending Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags:
> >>101, 
> >>[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter
> >>":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-1-V
> >>M","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.168.56
> >>.144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00:00:
> >>42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84:00:
> >>00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.56.21
> >>7","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:00:00:1
> >>2","resourceName":"NfsSecondaryStorageResource","wait":0}}] }
> >> 
> >> This happens both when I have a s3 store added and a regular nfs
> >>storage added.
> >> Is the startupcommand still reqd?
> >> 
> >> -- 
> >> Prasanna.,
> >> 
> >> 
> >> Powered by BigRock.com
> >
> >-- 
> >Prasanna.,
> >
> >
> >Powered by BigRock.com
> >



Powered by BigRock.com

Re: Jenkins and IRC

[Hugo Trippaers]

On Jun 28, 2013, at 10:18 AM, Prasanna Santhanam  wrote:

> On Fri, Jun 28, 2013 at 10:09:41AM -0700, Hugo Trippaers wrote:
>> Heya,
>> 
>> I've added a parameterised job to jenkins that will run a complete
>> build on any branch. You can kick it off on jenkins.cloudstack.org
>> and enter any branch as the parameter. It will do the regular maven
>> build with the clean and test actions. It will also generate a
>> cobertura coverage report so you can easily see how much code your
>> unit tests cover.
>> 
>> Also its possible to kick this build right from our IRC channel. For
>> example the following command will build the vmsync branch:
>> 
>> !jenkins build cloudstack-build-parameterized now branch=vmsync
>> 
>> List the current builds using the '!jenkins cb' command.
>> 
>> So whenever you push a branch to apache, feel free to ask cato to
>> build it for you. 
> 
> Awesome! With Ian's help I plan to put in pretty Sonar graphs (if you
> like that sort of thing) as well for the static analysis checks. 
> 
>> 
>> Cheers,
>> 
>> Hugo
>> 
>> 
>> @David, remember that nginx proxy timeout setting we discussed ages
>> ago? Would be nice to get that sorted so we can use some extra cloud
>> power on jenkins.cloudstack.org. Any ideas on how we can get that
>> done?
> 
> I plan on moving the current jenkins node on to a CloudStack setup
> along with configuring jenkins purely via github/yaml config files.
> still exploring. I think there should be some nginx puppet recipes
> around for quick configuration.  

Nice! I still have some cloud power i can add to the jenkins pool in our cloud, 
so with all those clouds we should be able to speed things up.

I tried making the change to the nginx configuration a while back, but some it 
did not get propagated, maybe you can have a look?  This is my commit on the 
puppet module: 
https://github.com/CloudStack-extras/cso-infrastructure/commit/9d65207989e7cbc5231f3f5184bd4bf6bf0f84d5

> 
> -- 
> Prasanna.,
> 
> 
> Powered by BigRock.com
> 

RE: Query String Request Authentication(QSRA) support by S3 providers

[Jessica Wang]

Thomas,

I've written down my comment in this bug.

Jessica

-Original Message-
From: Thomas O'Dowd [mailto:tpod...@cloudian.com] 
Sent: Thursday, June 27, 2013 8:04 PM
To: Min Chen
Cc: dev@cloudstack.apache.org; Jessica Wang
Subject: Re: Query String Request Authentication(QSRA) support by S3 providers

Hi Min/Jessica,

I attached an image to that issue to show what what my browser is
showing.

https://issues.apache.org/jira/browse/CLOUDSTACK-3220 

Tom.

On Fri, 2013-06-28 at 09:45 +0900, Thomas O'Dowd wrote:
> Hi Min,
> 
> Yes. I'll try it again today to check again but when I added Amazon S3
> as the S3 secondary storage and uploaded a template, I was not shown the
> "download template" link. However - for Cloudian S3, I am shown it so
> I'm wondering why.
> 
> Tom.
> 
> On Fri, 2013-06-28 at 00:26 +, Min Chen wrote:
> > Hi Tom,
> > 
> > Are you saying that you cannot see a Download Template button from UI
> > when Amazon S3 is added as secondary storage? I only tested with RiakCS
> > and Cloudian, so didn't see this issue. But I am CC Jessica her to confirm
> > what special handling is done in UI to enable/disable a button from UI.
> > 
> > Thanks
> > -min
> > 
> > On 6/27/13 5:23 PM, "Thomas O'Dowd"  wrote:
> > 
> > >Hi Min,
> > >
> > >Can you check this bug? I'm trying to test this feature for Amazon but
> > >having no luck getting the Download template link/button to appear.
> > >
> > >https://issues.apache.org/jira/browse/CLOUDSTACK-3220
> > >
> > >Thanks,
> > >
> > >Tom.
> > >
> > >On Fri, 2013-06-21 at 17:21 +, Min Chen wrote:
> > >> John,
> > >> 
> > >>  For S3, the api call createEntityExtractUrl is done on management
> > >>server
> > >> side; while for NFS secondary storage, if the implementation of
> > >> createEntityExtractUrl will involve some code be executed in ssvm to
> > >>copy
> > >> template from the install location to a public accessible web server
> > >> location.
> > >>  I don't quite understand some of your comments below. This API is not
> > >> used to write any information to S3 bucket/directory. This is used for
> > >> object already existed on S3, and we just provide a URL for user to
> > >> download a template from S3, just like how Amazon provided user a way to
> > >> user to extract a S3 object through generatePresignedUrl. We can discuss
> > >> more on this on collaboration conference.
> > >> 
> > >>  Thanks  
> > >>  -min
> > >> 
> > >> 
> > >> 
> > >> On 6/21/13 7:25 AM, "John Burwell"  wrote:
> > >> 
> > >> >Min,
> > >> >
> > >> >(I apologize for my belated reply -- I lost track of this draft in the
> > >> >chaos of the last couple of days.)
> > >> >
> > >> >Upon further review, I think I feel into the confusion between
> > >>management
> > >> >server and ssvm.  This code is executing on the management server side,
> > >> >correct?  Based on my "corrected" understanding is correct, I would
> > >>like
> > >> >to amend my thoughts.  Namely, I would like to see the driver
> > >>operations
> > >> >pushed out to the SSVM where we can use the stream.  As I think about
> > >>it,
> > >> >the management server should not need to interact with the driver.
> > >> >Simply yard up the DataStore attributes + details map and other extract
> > >> >parameters, and send them to the SSVM.  Using this information, the S3
> > >> >driver could open a stream to write the template out to the
> > >> >bucket/directory.  I recognize it changes the protocol between the
> > >> >management server and SSVM, but it simply both sides of the operation
> > >>by
> > >> >allowing the DataStore information to be treated opaquely until it is
> > >> >consumed by the driver to execute the write operation.  I also
> > >>recognize
> > >> >that we may a little late in the cycle to address it for 4.2, and it
> > >>may
> > >> >need to be part of the 4.3 enhancements.
> > >> >
> > >> >Thanks,
> > >> >-John
> > >> >
> > >> >On Jun 18, 2013, at 3:55 PM, Min Chen  wrote:
> > >> >
> > >> >> John,
> > >> >>   In that case, how do we keep backward compatibility of
> > >>extractTemplate
> > >> >> api, which requires a URL in the response?
> > >> >> 
> > >> >>   Thanks
> > >> >>   -min
> > >> >> 
> > >> >> On 6/18/13 11:53 AM, "John Burwell"  wrote:
> > >> >> 
> > >> >>> Min,
> > >> >>> 
> > >> >>> Looking through the code, I think we can simplify driver operation
> > >>and
> > >> >>> increase robustness by changing
> > >> >>>ImageStoreDriver#createEntityExtractUrl()
> > >> >>> : String to ImageStoreDriver#readEntity(Š) : InputStream.  My first
> > >> >>> concern with the current implementation is that it circumvents any
> > >> >>> connection pooling/resource management underlying client libraries
> > >> >>> provide.  I/O streams provide a higher-level abstraction that allows
> > >> >>> drivers to provide the orchestration components with actual
> > >>resources
> > >> >>> rather String references.  Second, the current interface seems to
> > >> >>>appears
> > >> >>> to assume tha

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

[Marcus Sorensen]

Anything special required to do this POST? Just read this thread when
searching for "userdata 2k" and noticed that POST is supposed to be
supported, but if I run the following it doesn't work:

 curl --request POST 'http://localhost:8096/client/api' --data
'command=listVirtualMachines'


On Wed, Apr 24, 2013 at 5:30 PM, Min Chen  wrote:
>
>
>> On April 24, 2013, 11:29 p.m., Min Chen wrote:
>> > Ship It!
>
> Prasanna has fixed the marvin test and pushed to master.
> These are the rebased commits on master:
> 4e9e7937ed5e56cbd7f678b2ed9863a56af16635 Fix Vijay's test to use the marvin 
> integratin libararies
> b0caae6b33347f36721f28dca1fa12e7b18f1cd1 CLOUDSTACK-1086: 
> DeployVirtualMachine userdata enhancements
>
>
> - Min
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10294/#review19680
> ---
>
>
> On April 23, 2013, 9:45 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10294/
>> ---
>>
>> (Updated April 23, 2013, 9:45 p.m.)
>>
>>
>> Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, 
>> and Min Chen.
>>
>>
>> Description
>> ---
>>
>> Please refer to 
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements
>>  for a background on the requirements driving this patch.
>>
>> This patch hasn't been extensively tested yet, and I will update this 
>> request with more info. I am uploading a first diff for initial 
>> review/comments.
>>
>>
>> This addresses bug CLOUDSTACK-1086.
>>
>>
>> Diffs
>> -
>>
>>   api/src/com/cloud/vm/UserVmService.java aa21136
>>   api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680
>>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 70c0159
>>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ff8fff1
>>   core/src/com/cloud/vm/UserVmVO.java a16eaf9
>>   server/src/com/cloud/api/ApiDispatcher.java 925d90a
>>   server/src/com/cloud/api/ApiServer.java d842819
>>   server/src/com/cloud/api/ApiServerService.java 12d8b52
>>   server/src/com/cloud/api/ApiServlet.java 03bfb5f
>>   server/src/com/cloud/vm/UserVmManagerImpl.java 1843f60
>>   server/test/com/cloud/vm/MockUserVmManagerImpl.java 0d0a8f4
>>   server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180
>>   server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION
>>   server/test/resources/UserVMDaoTestContext.xml PRE-CREATION
>>   setup/db/db/schema-410to420.sql 10cdbba
>>   test/integration/component/test_deploy_vm_with_userdata.py PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/10294/diff/
>>
>>
>> Testing
>> ---
>>
>> Manual testing done with scripts generating large/small userdata during 
>> creation of VMs, with both GET and POST requests confirmed to work 
>> correctly, on both integration port and the 8080 port.
>>
>> Basic Marvin test to create a VM with user data has been written. Since 
>> marvin doesn't yet support POSTable APIs, as soon as that is made available 
>> for create/update VM operations, marvin tests will be written for the same. 
>> Requesting that this be noted as an AI for the future.
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>>
>>
>

RE: Master broken on systemVM start

[Edison Su]

Devcloud has a trick to clean up systemvm.iso:
There is a bug in xapi on Ubuntu/debian(not sure the bug still there in the 
latest debian or not), which can't attach an ISO to a VM. I worked around the 
bug by creating a VDI on primary storage, copy systemvm iso into that VDI, then 
attach the vdi into system vm. The downside of this workaround is that, the VDI 
is not synced with systemvm iso.
In order to clean up devcloud, need to either clean up primary storage, or 
restore devcloud from snapshot for each run in your test infra.

> -Original Message-
> From: Prasanna Santhanam [mailto:t...@apache.org]
> Sent: Friday, June 28, 2013 10:22 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Master broken on systemVM start
> 
> I deleted all traces of systemvm.iso from my codebase $ find . -name
> systemvm.iso | xargs -n1 rm -f
> 
> Then reverted my devcloud snapshot to old state and don't see this error
> again.
> 
> I wonder by mvn doesn't do a good job of cleaning though :/
> 
> Thanks for the fixes to the bugs and the upcoming fixes for the new ones. I'll
> be switching over the test infra to run object store backed secondary only
> from next week so we should have more results.
> 
> --
> Prasanna.,
> 
> On Fri, Jun 28, 2013 at 04:35:29PM +, Min Chen wrote:
> > Prasanna, glad to know that CLOUDSTACK-3137 is resolved. I fixed
> > CLOUDSTACK-3249 yesterday for a corner case reported by Alena, but I
> > could not reproduce CLOUDSTACK-3137 on my environment at all. For the
> > JSON issue, I can only tell that it is inconsistent systemvm issue
> > between management server and system vm. In 4.2, we changed
> > ArrayTypeAdaptor to return full qualified command class name, so I
> > don't quite get why you are still seeing the abbreviated command name
> > in your log. Yes, StartupSecondaryStorageCommand is still there. From
> > your log, it seems that your ssvm has the old code.
> >
> > Thanks
> > -min
> >
> > On 6/28/13 12:03 AM, "Prasanna Santhanam"  wrote:
> >
> > >On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
> > >> On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
> > >> > Json deserialization issue is caused by out-of-dated systemvm.iso
> > >> > on
> > >>your
> > >> > hypervisor host. You need rebuilding systemvm.iso and deployed to
> > >> > your hypervisor host.
> > >> >
> > >>
> > >> CLOUDSTACK-3137 exists and seems to be a problem with HA and
> > >> systemVMs. The JSON serialization also exists for me despite
> > >> rebuidling the systemvm with -Dsystemvm.
> > >
> > >Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
> > >jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.
> > >
> > >>
> > >> I see the deserialization error when the ssvm agent sends this to
> > >> management server:
> > >>
> > >> 2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent]
> > >>(Agent-Handler-1:) Sending Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: 
> > >>-1,
> Ver: v1, Flags:
> > >>101,
> > >>[{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","da
> taC
> > >>enter
> > >>":"1","pod":"1","guid":"s-1-VM-
> NfsSecondaryStorageResource","name":"
> > >>s-1-V
> > >>M","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.1
> > >>68.56
> > >>.144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00
> :00:
> > >>42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84
> :00:
> > >>00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.
> > >>56.21
> > >>7","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:0
> 0
> > >>:00:1 2","resourceName":"NfsSecondaryStorageResource","wait":0}}] }
> > >>
> > >> This happens both when I have a s3 store added and a regular nfs
> > >>storage added.
> > >> Is the startupcommand still reqd?
> > >>
> > >> --
> > >> Prasanna.,
> > >>
> > >> 
> > >> Powered by BigRock.com
> > >
> > >--
> > >Prasanna.,
> > >
> > >
> > >Powered by BigRock.com
> > >
> 
> 
> 
> Powered by BigRock.com

Re: On git 4.1 (4.1.1-SNAPSHOT), jetty:run fails because of database version errors

[Ryan Lei]

Actually, the errors happen only in non-OSS build with git 4.1
(4.1.1-SNAPSHOT).

OSS build with git 4.1 and non-OSS build with 4.1.0 source code work fine.
They are able to run the Upgrade40to41 or Upgrade410to411.

I have created a JIRA ticket for this issue:
https://issues.apache.org/jira/browse/CLOUDSTACK-3278

---
Yu-Heng (Ryan) Lei, Associate Reasearcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw
or
ryanlei750...@gmail.com



On Fri, Jun 28, 2013 at 4:42 PM, Ryan Lei  wrote:

> Hi all,
> I was trying to use the git 4.1 branch to run non-OSS CloudStack from
> source. My commands were:
>
> (1) Put the neccessary jars in deps
> (2) Run deps/install-non-oss.sh with success
> (3) $ mvn clean install -DskipTests=true -Dnonoss
> (4) $ mvn -P developer -pl developer -Ddeploydb
> (5) $ mvn -pl :cloud-client-ui jetty:run
>
> Then I got these DB version errors which made the jetty quit:
> INFO  [utils.component.ComponentContext] (Timer-2:) Running
> SystemIntegrityChecker encryptionSecretKeyChecker
> INFO  [utils.component.ComponentContext] (Timer-2:) Running
> SystemIntegrityChecker databaseIntegrityChecker
> INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Grabbing lock to
> check for database integrity.
> INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Performing
> database integrity check
> INFO  [utils.component.ComponentContext] (Timer-2:) Running
> SystemIntegrityChecker managementServerNode
> INFO  [utils.component.ComponentContext] (Timer-2:) Running
> SystemIntegrityChecker premiumDatabaseUpgradeChecker
> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Grabbing lock to
> check for database upgrade.
> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) DB version = 4.0.0
> Code Version = 4.1.1-SNAPSHOT
> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Database upgrade
> must be performed from 4.0.0 to 4.1.1-SNAPSHOT
> ERROR [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) The end upgrade
> version is actually at 4.1.0 but our management server code version is at
> 4.1.1-SNAPSHOT
> ERROR [utils.component.ComponentContext] (Timer-2:) System integrity check
> failed. Refuse to startup
>
>
> In MySQL, I found the table in 'version' has only one entry whose value is
> 4.0.0.
> Manually modifying the value to 4.1.1 led to other exceptions. Looks like
> 4.1 git "forgets" to upgrade the database.
>
> Is this a bug in the current 4.1 branch?
>
>
> ---
> Yu-Heng (Ryan) Lei, Associate Reasearcher
> Chunghwa Telecom Laboratories / Cloud Computing Laboratory
> ryan...@cht.com.tw
>  or
> ryanlei750...@gmail.com
>
>

Re: Master broken on systemVM start

[Hugo Trippaers]

Hey Prasanna,

I just did a quick test, these systemvm.iso files are generated by the default 
maven build (mvm -Dnonoss -Psystemvm install)

./client/target/cloud-client-ui-4.2.0-SNAPSHOT/WEB-INF/classes/vms/systemvm.iso
./client/target/generated-webapp/WEB-INF/classes/vms/systemvm.iso
./services/console-proxy/server/dist/systemvm.iso

After cleaning (mvm -Dnonoss -Psystemvm clean) these files were removed as well.

Which targets did you run?

Cheers,

Hugo


On Jun 28, 2013, at 10:21 AM, Prasanna Santhanam  wrote:

> I deleted all traces of systemvm.iso from my codebase
> $ find . -name systemvm.iso | xargs -n1 rm -f
> 
> Then reverted my devcloud snapshot to old state and don't see this
> error again.
> 
> I wonder by mvn doesn't do a good job of cleaning though :/
> 
> Thanks for the fixes to the bugs and the upcoming fixes for the new
> ones. I'll be switching over the test infra to run object store backed
> secondary only from next week so we should have more results. 
> 
> -- 
> Prasanna.,
> 
> On Fri, Jun 28, 2013 at 04:35:29PM +, Min Chen wrote:
>> Prasanna, glad to know that CLOUDSTACK-3137 is resolved. I fixed
>> CLOUDSTACK-3249 yesterday for a corner case reported by Alena, but I could
>> not reproduce CLOUDSTACK-3137 on my environment at all. For the JSON
>> issue, I can only tell that it is inconsistent systemvm issue between
>> management server and system vm. In 4.2, we changed ArrayTypeAdaptor to
>> return full qualified command class name, so I don't quite get why you are
>> still seeing the abbreviated command name in your log. Yes,
>> StartupSecondaryStorageCommand is still there. From your log, it seems
>> that your ssvm has the old code.
>> 
>> Thanks
>> -min
>> 
>> On 6/28/13 12:03 AM, "Prasanna Santhanam"  wrote:
>> 
>>> On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
 On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
> Json deserialization issue is caused by out-of-dated systemvm.iso on
 your
> hypervisor host. You need rebuilding systemvm.iso and deployed to your
> hypervisor host.
> 
 
 CLOUDSTACK-3137 exists and seems to be a problem with HA and
 systemVMs. The JSON serialization also exists for me despite
 rebuidling the systemvm with -Dsystemvm.
>>> 
>>> Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
>>> jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.
>>> 
 
 I see the deserialization error when the ssvm agent sends this to
 management server:
 
 2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent] (Agent-Handler-1:)
 Sending Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags:
 101, 
 [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter
 ":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-1-V
 M","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.168.56
 .144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00:00:
 42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84:00:
 00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.56.21
 7","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:00:00:1
 2","resourceName":"NfsSecondaryStorageResource","wait":0}}] }
 
 This happens both when I have a s3 store added and a regular nfs
 storage added.
 Is the startupcommand still reqd?
 
 -- 
 Prasanna.,
 
 
 Powered by BigRock.com
>>> 
>>> -- 
>>> Prasanna.,
>>> 
>>> 
>>> Powered by BigRock.com
>>> 
> 
> 
> 
> Powered by BigRock.com
> 

Re: Review Request 12149: Fix for template download failure for vmware deployments on cloudstack

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12149/#review22518
---

Ship it!


Ship It!

- Devdeep Singh


On June 28, 2013, 2:10 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12149/
> ---
> 
> (Updated June 28, 2013, 2:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Kelven Yang, Min Chen, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2385
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix to allow template downloads for templates available across zones.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 92148c3 
> 
> Diff: https://reviews.apache.org/r/12149/diff/
> 
> 
> Testing
> ---
> 
> Confirmed that template download works for templates registered across zones 
> as well as with individual zones.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Master broken on systemVM start

[Prasanna Santhanam]

I did a mvn -Pdeveloper -Dsystemvm clean install and those
systemvm.iso(s) went away. So it must be within devcloud somewhere
that the iso existed. 

On Fri, Jun 28, 2013 at 10:41:39AM -0700, Hugo Trippaers wrote:
> Hey Prasanna,
> 
> I just did a quick test, these systemvm.iso files are generated by
> the default maven build (mvm -Dnonoss -Psystemvm install)
> 
> ./client/target/cloud-client-ui-4.2.0-SNAPSHOT/WEB-INF/classes/vms/systemvm.iso
> ./client/target/generated-webapp/WEB-INF/classes/vms/systemvm.iso
> ./services/console-proxy/server/dist/systemvm.iso
> 
> After cleaning (mvm -Dnonoss -Psystemvm clean) these files were removed as 
> well.
> 
> Which targets did you run?
> 
> Cheers,
> 
> Hugo
> 
> 
> On Jun 28, 2013, at 10:21 AM, Prasanna Santhanam  wrote:
> 
> > I deleted all traces of systemvm.iso from my codebase
> > $ find . -name systemvm.iso | xargs -n1 rm -f
> > 
> > Then reverted my devcloud snapshot to old state and don't see this
> > error again.
> > 
> > I wonder by mvn doesn't do a good job of cleaning though :/
> > 
> > Thanks for the fixes to the bugs and the upcoming fixes for the new
> > ones. I'll be switching over the test infra to run object store backed
> > secondary only from next week so we should have more results. 
> > 
> > -- 
> > Prasanna.,
> > 
> > On Fri, Jun 28, 2013 at 04:35:29PM +, Min Chen wrote:
> >> Prasanna, glad to know that CLOUDSTACK-3137 is resolved. I fixed
> >> CLOUDSTACK-3249 yesterday for a corner case reported by Alena, but I could
> >> not reproduce CLOUDSTACK-3137 on my environment at all. For the JSON
> >> issue, I can only tell that it is inconsistent systemvm issue between
> >> management server and system vm. In 4.2, we changed ArrayTypeAdaptor to
> >> return full qualified command class name, so I don't quite get why you are
> >> still seeing the abbreviated command name in your log. Yes,
> >> StartupSecondaryStorageCommand is still there. From your log, it seems
> >> that your ssvm has the old code.
> >> 
> >> Thanks
> >> -min
> >> 
> >> On 6/28/13 12:03 AM, "Prasanna Santhanam"  wrote:
> >> 
> >>> On Fri, Jun 28, 2013 at 12:17:55PM +0530, Prasanna Santhanam wrote:
>  On Tue, Jun 25, 2013 at 04:07:08PM +, Min Chen wrote:
> > Json deserialization issue is caused by out-of-dated systemvm.iso on
>  your
> > hypervisor host. You need rebuilding systemvm.iso and deployed to your
> > hypervisor host.
> > 
>  
>  CLOUDSTACK-3137 exists and seems to be a problem with HA and
>  systemVMs. The JSON serialization also exists for me despite
>  rebuidling the systemvm with -Dsystemvm.
> >>> 
> >>> Ok - CLOUDSTACK-3137 _may_ have been fixed. the last few test-matrix
> >>> jobs have succeeded. Perhaps related to fix for CLOUDSTACK-3249.
> >>> 
>  
>  I see the deserialization error when the ssvm agent sends this to
>  management server:
>  
>  2013-06-28 06:42:50,609 DEBUG [cloud.agent.Agent] (Agent-Handler-1:)
>  Sending Startup: Seq -1-2:  { Cmd , MgmtId: -1, via: -1, Ver: v1, Flags:
>  101, 
>  [{"StartupSecondaryStorageCommand":{"type":"SecondaryStorage","dataCenter
>  ":"1","pod":"1","guid":"s-1-VM-NfsSecondaryStorageResource","name":"s-1-V
>  M","version":"4.2.0-SNAPSHOT","iqn":"NoIqn","publicIpAddress":"192.168.56
>  .144","publicNetmask":"255.255.255.0","publicMacAddress":"06:5c:ac:00:00:
>  42","privateIpAddress":"192.168.56.217","privateMacAddress":"06:aa:84:00:
>  00:12","privateNetmask":"255.255.255.0","storageIpAddress":"192.168.56.21
>  7","storageNetmask":"255.255.255.0","storageMacAddress":"06:aa:84:00:00:1
>  2","resourceName":"NfsSecondaryStorageResource","wait":0}}] }
>  
>  This happens both when I have a s3 store added and a regular nfs
>  storage added.
>  Is the startupcommand still reqd?
>  
>  -- 
>  Prasanna.,
>  
>  
>  Powered by BigRock.com
> >>> 
> >>> -- 
> >>> Prasanna.,
> >>> 
> >>> 
> >>> Powered by BigRock.com
> >>> 
> > 
> > 
> > 
> > Powered by BigRock.com
> > 

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 12149: Fix for template download failure for vmware deployments on cloudstack

[Devdeep Singh]

> On June 28, 2013, 5:52 p.m., Devdeep Singh wrote:
> > Ship It!

Committed in 78922589bbdc7914b9d4ce3b97a9fcf03d4b7b57. Kindly close the request


- Devdeep


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12149/#review22518
---


On June 28, 2013, 2:10 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12149/
> ---
> 
> (Updated June 28, 2013, 2:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Kelven Yang, Min Chen, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-2385
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix to allow template downloads for templates available across zones.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 92148c3 
> 
> Diff: https://reviews.apache.org/r/12149/diff/
> 
> 
> Testing
> ---
> 
> Confirmed that template download works for templates registered across zones 
> as well as with individual zones.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Master broken on systemVM start

[Prasanna Santhanam]

On Fri, Jun 28, 2013 at 05:38:19PM +, Edison Su wrote:
> Devcloud has a trick to clean up systemvm.iso:
> There is a bug in xapi on Ubuntu/debian(not sure the bug still there
> in the latest debian or not), which can't attach an ISO to a VM. I
> worked around the bug by creating a VDI on primary storage, copy
> systemvm iso into that VDI, then attach the vdi into system vm. The
> downside of this workaround is that, the VDI is not synced with
> systemvm iso.
> In order to clean up devcloud, need to either clean up primary
> storage, or restore devcloud from snapshot for each run in your test
> infra.
> 
Ok I'll have to explore that. I don't do a vdi reset each time so that
must be the problem.

-- 
Prasanna.,


Powered by BigRock.com

Re: On git 4.1 (4.1.1-SNAPSHOT), jetty:run fails because of database version errors

[Hugo Trippaers]

Hello :-)

Nice find!

I've pushed this commit to the branch:

 commit b330f2aa909d7ddc387863e0806f71964f6d5f80
Author: Hugo Trippaers 
Date:   Fri Jun 28 10:57:51 2013 -0700

CLOUDSTACK-3278 Add the 410 to 411 upgrade to the 
PremiumDatabaseUpgradeChecker

Can you verify if this fixes your problem?


Cheers,

Hugo

On Jun 28, 2013, at 10:39 AM, Ryan Lei  wrote:

> Actually, the errors happen only in non-OSS build with git 4.1
> (4.1.1-SNAPSHOT).
> 
> OSS build with git 4.1 and non-OSS build with 4.1.0 source code work fine.
> They are able to run the Upgrade40to41 or Upgrade410to411.
> 
> I have created a JIRA ticket for this issue:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3278
> 
> ---
> Yu-Heng (Ryan) Lei, Associate Reasearcher
> Chunghwa Telecom Laboratories / Cloud Computing Laboratory
> ryan...@cht.com.tw
> or
> ryanlei750...@gmail.com
> 
> 
> 
> On Fri, Jun 28, 2013 at 4:42 PM, Ryan Lei  wrote:
> 
>> Hi all,
>> I was trying to use the git 4.1 branch to run non-OSS CloudStack from
>> source. My commands were:
>> 
>> (1) Put the neccessary jars in deps
>> (2) Run deps/install-non-oss.sh with success
>> (3) $ mvn clean install -DskipTests=true -Dnonoss
>> (4) $ mvn -P developer -pl developer -Ddeploydb
>> (5) $ mvn -pl :cloud-client-ui jetty:run
>> 
>> Then I got these DB version errors which made the jetty quit:
>> INFO  [utils.component.ComponentContext] (Timer-2:) Running
>> SystemIntegrityChecker encryptionSecretKeyChecker
>> INFO  [utils.component.ComponentContext] (Timer-2:) Running
>> SystemIntegrityChecker databaseIntegrityChecker
>> INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Grabbing lock to
>> check for database integrity.
>> INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Performing
>> database integrity check
>> INFO  [utils.component.ComponentContext] (Timer-2:) Running
>> SystemIntegrityChecker managementServerNode
>> INFO  [utils.component.ComponentContext] (Timer-2:) Running
>> SystemIntegrityChecker premiumDatabaseUpgradeChecker
>> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Grabbing lock to
>> check for database upgrade.
>> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) DB version = 4.0.0
>> Code Version = 4.1.1-SNAPSHOT
>> INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Database upgrade
>> must be performed from 4.0.0 to 4.1.1-SNAPSHOT
>> ERROR [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) The end upgrade
>> version is actually at 4.1.0 but our management server code version is at
>> 4.1.1-SNAPSHOT
>> ERROR [utils.component.ComponentContext] (Timer-2:) System integrity check
>> failed. Refuse to startup
>> 
>> 
>> In MySQL, I found the table in 'version' has only one entry whose value is
>> 4.0.0.
>> Manually modifying the value to 4.1.1 led to other exceptions. Looks like
>> 4.1 git "forgets" to upgrade the database.
>> 
>> Is this a bug in the current 4.1 branch?
>> 
>> 
>> ---
>> Yu-Heng (Ryan) Lei, Associate Reasearcher
>> Chunghwa Telecom Laboratories / Cloud Computing Laboratory
>> ryan...@cht.com.tw
>>  or
>> ryanlei750...@gmail.com
>> 
>> 

Re: Jenkins and IRC

[John Burwell]

Prasanna,

I am all for static analysis, but I think we should discuss it before
implementation to ensure that the community is in sync on the rules
and priority.  I am of the belief that static analysis shouldn't check
for violations that we don't are worthy of breaking a build.  However,
implementing such an approach would take a fair amount if coordination
and effort for (needed) cleanup.

That's my $0.02,
-John



On Jun 28, 2013, at 1:19 PM, Prasanna Santhanam  wrote:

> On Fri, Jun 28, 2013 at 10:09:41AM -0700, Hugo Trippaers wrote:
>> Heya,
>>
>> I've added a parameterised job to jenkins that will run a complete
>> build on any branch. You can kick it off on jenkins.cloudstack.org
>> and enter any branch as the parameter. It will do the regular maven
>> build with the clean and test actions. It will also generate a
>> cobertura coverage report so you can easily see how much code your
>> unit tests cover.
>>
>> Also its possible to kick this build right from our IRC channel. For
>> example the following command will build the vmsync branch:
>>
>> !jenkins build cloudstack-build-parameterized now branch=vmsync
>>
>> List the current builds using the '!jenkins cb' command.
>>
>> So whenever you push a branch to apache, feel free to ask cato to
>> build it for you.
>
> Awesome! With Ian's help I plan to put in pretty Sonar graphs (if you
> like that sort of thing) as well for the static analysis checks.
>
>>
>> Cheers,
>>
>> Hugo
>>
>>
>> @David, remember that nginx proxy timeout setting we discussed ages
>> ago? Would be nice to get that sorted so we can use some extra cloud
>> power on jenkins.cloudstack.org. Any ideas on how we can get that
>> done?
>
> I plan on moving the current jenkins node on to a CloudStack setup
> along with configuring jenkins purely via github/yaml config files.
> still exploring. I think there should be some nginx puppet recipes
> around for quick configuration.
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>

Re: PrimaryDataStoreEntityImpl TODOs

[John Burwell]

Prasanna,

More irksome than forgetting to remove TODO comments after addressing
them are TODOs that actually are TODOs and not cruft.  The ticket
referenced below us the later.  I am fine with having an IDE generate
them as a reminder to finish something.  Contributors need to remember
to address and remove them before submission because I see them take
at face value -- there is more work to be done.

Thanks,
-John


On Jun 28, 2013, at 12:08 PM, Prasanna Santhanam  wrote:

> +1
>
> The TODOs, @author tags and minor typos irks me too. Typos are
> understandable and I fix them when I see them. But it we should be
> keep the code clean of IDE introduced comments like TODOs. Please
> consider configuring your IDEs.
>
> Let's all _care_ for our codebase ... just a little.
>
> Now everyone go clean your classes :)
>
> On Fri, Jun 28, 2013 at 10:06:47AM -0400, John Burwell wrote:
>> All,
>>
>> While reviewing the solidfire patch, I noticed that a dummy
>> getter/setter implementations with TODO comments in the
>> PrimaryDataStoreImpl in  were merged into master.  I have opened a
>> defect [1] for this issue, as the code will not work as expected
>> (they are not actually working with the internal state of the object
>> as expected).
>>
>> Speaking generally, every review I have performed for 4.2.0 has
>> contained TODO comments, as well, tab characters and improper
>> indentation.  Please check patches for these issues before
>> submission.  For me, patches with TODOs are an immediate -1 because
>> it conveys that the implementation is incomplete.  The formatting
>> issues are minor, but easily rectified with a quick code format in
>> an IDE.
>>
>> Thanks,
>> -John
>>
>> [1]: https://issues.apache.org/jira/browse/CLOUDSTACK-3277
>
> --
> Prasanna.,
>
> 
> Powered by BigRock.com
>

Re: [GSOC] cloudstack-agent service and "unable to add host"

[Sebastien Goasguen]

Meng,

I am not sure where you stand on this, but you should not use VLANs.

Just setup a basic zone (no vlans needed) , use the packages from the 
repository and don't even try to compile from source.

All information should be in the installation guide (not the quick install 
guide, which is not valid for 4.1).

This script might help you:
http://simonljb123.wordpress.com/2013/05/22/installation-of-cloudstack-4-0-kvm-hypervisor-host-with-onekey/

but this is only for 4.0. In 4.1 the package names have changed from cloud- to 
cloudstack-

I will do an install on monday and get back with you (have not done an install 
in a while).

-sebastien

On Jun 24, 2013, at 10:53 PM, "Han,Meng"  wrote:

> Hi all,
> 
> In the CloudStack installation guides(both 4.0 and 4.1), it says that we need 
> to install cloud-agent.
> (http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html#hypervisor-host-install-agent)
> 
> However I could not find this package. Instead I found a directory named 
> "agent" in the CloudStack master branch.
> 
> Is it the same agent? How should I run this agent?
> Also it is mentioned here that we should configure a couple of things after 
> we installed cloud agent 
> :http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Quick_Install_Guide/sect-qig-KVM-Installation.html
> What configuration do I need to make to the cloud agent? It seems to me at 
> least  we should told the agent which bridges the VMs are connected to. There 
> is a script called "cloud-setup-agent" under the agent directory. Should we 
> use this to configure the agent?
> 
> I have stuck on these question for a couple of days. I seems to grab pieces 
> from every installation guide I can find to make things through :(
> 
> Also in the network configuration part: 
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html#hypervisor-host-install-network
> 
> We assume that the hypervisor has one NIC (eth0) with three tagged VLAN's:
> 
>VLAN 100 for management of the hypervisor
>VLAN 200 for public network of the instances (cloudbr0)
>VLAN 300 for private network of the instances (cloudbr1)
> 
> I am not allowed to use tagged VLANs on campus, which means my VMs will not 
> be able to connect to internet. Is there anyway to work around this? Can we 
> use a "flat" network structure?
> 
> If we setup these two bridges: cloudbr0 and cloudbr1, how does the cloud 
> agent know these two bridges?
> 
> Thanks for your help.
> 
> Best Regards,
> Meng

Re: CloudStack API Development

[SuichII, Christopher]

So a little update on the hot-deployable API front:

It works…I think. I've been able to package my code into a jar deploy it to a 
pre-comipiled CloudStack. All I had to do was:
-Compile the client
-Add a bean for my PluggableService to applicationContext.xml
-Add my command permissions to the commands.properties
-Drop my jar and dependency jars into /WEB-INF/lib/

So, to anyone curious, the plugins look more firefox-y than we though. =)

If anyone sees a potential problem with this please let me know. I'll update 
the list if I come across anything else interesting in my investigation.

-Chris

On Jun 28, 2013, at 12:43 AM, Prasanna Santhanam  wrote:

> On Thu, Jun 27, 2013 at 07:36:58PM +, SuichII, Christopher wrote:
>> I've got some questions related to this topic?
>> 
>> We're planning on developing an API plugin, but not submitting the
>> source to CloudStack. Rather, we would like to generate a jar file
>> and deploy that to the CloudStack API plugin directory. Has anyone
>> done this?
>> 
>> Ian, your blog post and notes were extremely helpful, so thanks for
>> that! Do you have any idea how to contribute an API without having
>> to add your plugin as a maven dependency at compile time? It seems
>> like, in order for us to do this, there needs to be a way to
>> register an API plugin to an existing CloudStack deployment without
>> re-compiling.
>> 
> 
> It could work, but not without a recompile. Plugins here aren't quite
> firefox plugins (yet) :)
> 
> -- 
> Prasanna.,
> 
> 
> Powered by BigRock.com
> 

On master updatephysicalnetwork won't enable the phy. net?

[Prasanna Santhanam]

Just running some devcloud tests and my physicalnetwork won't be
enabled? Looks like a regression. Anyone else seeing this?

I'll have to find the checkin to be reverted if so.

-- 
Prasanna.,


Powered by BigRock.com

Re: CloudStack API Development

[David Nalley]

Do you mind writing up the process on the wiki or in a blog post (or both?)

--David

On Fri, Jun 28, 2013 at 2:56 PM, SuichII, Christopher
 wrote:
> So a little update on the hot-deployable API front:
>
> It works…I think. I've been able to package my code into a jar deploy it to a 
> pre-comipiled CloudStack. All I had to do was:
> -Compile the client
> -Add a bean for my PluggableService to applicationContext.xml
> -Add my command permissions to the commands.properties
> -Drop my jar and dependency jars into /WEB-INF/lib/
>
> So, to anyone curious, the plugins look more firefox-y than we though. =)
>
> If anyone sees a potential problem with this please let me know. I'll update 
> the list if I come across anything else interesting in my investigation.
>
> -Chris
>
> On Jun 28, 2013, at 12:43 AM, Prasanna Santhanam  wrote:
>
>> On Thu, Jun 27, 2013 at 07:36:58PM +, SuichII, Christopher wrote:
>>> I've got some questions related to this topic?
>>>
>>> We're planning on developing an API plugin, but not submitting the
>>> source to CloudStack. Rather, we would like to generate a jar file
>>> and deploy that to the CloudStack API plugin directory. Has anyone
>>> done this?
>>>
>>> Ian, your blog post and notes were extremely helpful, so thanks for
>>> that! Do you have any idea how to contribute an API without having
>>> to add your plugin as a maven dependency at compile time? It seems
>>> like, in order for us to do this, there needs to be a way to
>>> register an API plugin to an existing CloudStack deployment without
>>> re-compiling.
>>>
>>
>> It could work, but not without a recompile. Plugins here aren't quite
>> firefox plugins (yet) :)
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>>
>

Re: CloudStack API Development

[SuichII, Christopher]

Sure thing! I'll be on vacation next week but will document the process a 
little more and write something up the following week. If you have a more 
urgent need than that, feel free to shoot me an email.

-Chris

On Jun 28, 2013, at 3:07 PM, David Nalley 
 wrote:

> Do you mind writing up the process on the wiki or in a blog post (or both?)
> 
> --David
> 
> On Fri, Jun 28, 2013 at 2:56 PM, SuichII, Christopher
>  wrote:
>> So a little update on the hot-deployable API front:
>> 
>> It works…I think. I've been able to package my code into a jar deploy it to 
>> a pre-comipiled CloudStack. All I had to do was:
>> -Compile the client
>> -Add a bean for my PluggableService to applicationContext.xml
>> -Add my command permissions to the commands.properties
>> -Drop my jar and dependency jars into /WEB-INF/lib/
>> 
>> So, to anyone curious, the plugins look more firefox-y than we though. =)
>> 
>> If anyone sees a potential problem with this please let me know. I'll update 
>> the list if I come across anything else interesting in my investigation.
>> 
>> -Chris
>> 
>> On Jun 28, 2013, at 12:43 AM, Prasanna Santhanam  wrote:
>> 
>>> On Thu, Jun 27, 2013 at 07:36:58PM +, SuichII, Christopher wrote:
 I've got some questions related to this topic?
 
 We're planning on developing an API plugin, but not submitting the
 source to CloudStack. Rather, we would like to generate a jar file
 and deploy that to the CloudStack API plugin directory. Has anyone
 done this?
 
 Ian, your blog post and notes were extremely helpful, so thanks for
 that! Do you have any idea how to contribute an API without having
 to add your plugin as a maven dependency at compile time? It seems
 like, in order for us to do this, there needs to be a way to
 register an API plugin to an existing CloudStack deployment without
 re-compiling.
 
>>> 
>>> It could work, but not without a recompile. Plugins here aren't quite
>>> firefox plugins (yet) :)
>>> 
>>> --
>>> Prasanna.,
>>> 
>>> 
>>> Powered by BigRock.com
>>> 
>> 

FW: Win7 License key?

[Donal Lafferty]

Hi Ram / Manan,

Devdeep added you to a meeting to discuss Hyper-V development on Tuesday.

If you've not already received it, the agenda is outlined below.

DL


> -Original Message-
> From: Donal Lafferty
> Sent: 28 June 2013 10:17 AM
> To: Devdeep Singh
> Cc: Will Chan; Kevin Kluge
> Subject: RE: Win7 License key?
> 
> Hi Devdeep,
> 
> Can we meet today?  Will is out of the office, but Kevin should be around.
> 
> During the meeting I would like to go over the following topics:
> 
> First up is development strategy, namely division of labour.  From your
> Linkedin profile, it looks like you're strongest with Windows.  However,
> access to people familiar with CloudStack has been the blocker.  For instance,
> your answer below is from a question asked ten days ago :(  If you work on
> items that require collaboration from the India team, it will greatly speed
> development.
> 
> Second is a series of tactical concerns that I'd like some input on.
> 
> 1.  The Hyper-V API used by CloudStack and OpenStack has been removed as
> of Hyper-V 2012 R2.  If we update it, OpenStack might copy us.  Should we
> hold off on publishing any updates until the plugin is good to go?
> Alternatively, should we contract the open stack developer to update our
> API calls?
> 
> 2.  Hyper-V Server 2012 does not have an NFS client, which prevents it from
> using the existing staging strategy.  With other Hypervisors, images can be
> downloaded from an object store to a NFS cache where they are
> uncompressed and made ready for distribution to hypervisors.  Hyper-V
> needs either a CIFS-based cache system, or it should pull directly from the
> object store.  In the later case, you'd have to prevent users from creating
> templates from compressed images.  What strategy should we pursue?  (this
> needs deciding today)
> 
> 3.  The RDP console proxy code needs to be updated and deployed to a
> system VM.  A contractor has produced an RDP proxy, but it does not provide
> the correct handshaking required to select the virtual frame buffer for a
> Hyper-V VM.  Also, the proxy has to be added to our system VM
> infrastructure, which work that Rohit used to do.  Do we have any expertise
> with RDP?Also, who is the System VM guru these days?
> 
> 4.  Instructions for the Hyper-V agent have been developed by replaying
> JSON encoded kernel commands.  However, it has been extremely difficult
> to get samples of the relevant commands.  What is a good strategy for
> obtaining them?  The current one involves begging CloudStack developers to
> provide debug logs, as testing don't appear to log the actual kernel
> commands.
> 
> 5.  There's no DevCloud for Hyper-V.  To work on the plugin, I have deployed
> a full CloudStack with Hyper-V servers as the hosts.  Is this something that 
> is
> reasonable to duplicate India?
> 
> 6.  Integrating with the Apache CloudStack build faces an IP hurdle and a
> testing hurdle.  The IP issue concerns compiling the Hyper-V agent.  I use
> VS2012SP1, which is a problem with for ASF.  Either we get the build working
> with mono, or we distribute the agent ourselves in an MSI via codecomplex
> or similar.  What are people's feelings on this?  The build only tests 
> correctly
> when it is run on a Hyper-V server.  As a result, unit tests are turned off by
> default.  Is this reasonable?
> 
> I think that's enough for now :)
> 
> DL
> 
> 
> > -Original Message-
> > From: Devdeep Singh
> > Sent: 27 June 2013 10:24 PM
> > To: Donal Lafferty
> > Subject: RE: Win7 License key?
> >
> > Hi Donal,
> >
> > Sorry, I didn't get back to you earlier. I was attending the apache
> > collaboration conference and I forgot to reply to your mail. Really
> > sorry. Were you able to get the bvt logs for attach and detach
> > volumes? I was pointed to the attached mail by a colleague. Using the
> > instructions in the mail I was able to locate the logs and look at the
> > json examples of commands. See if it helps you.
> >
> > I also wanted to sync up with you on Hyper-V. I have gone through the
> > mail chains on Hyper-V in the last six months. Would it be possible to
> > get on a call so that I can get some queries answered? If so, what
> > time will be suitable for you? I am in Santa Clara (PST) right now. I
> > am here till mid next week (3rd of June). Will a call early next week
> > work for you? If we have a call, Kevin or Will may join it too.
> >
> > Regards,
> > Devdeep
> >
> > > -Original Message-
> > > From: Donal Lafferty
> > > Sent: Thursday, June 20, 2013 2:08 PM
> > > To: Devdeep Singh
> > > Subject: RE: Win7 License key?
> > >
> > > Okay, but the logs from the BVT are easier to get, no?
> > >
> > > > -Original Message-
> > > > From: Devdeep Singh
> > > > Sent: 20 June 2013 9:53 PM
> > > > To: Donal Lafferty
> > > > Subject: RE: Win7 License key?
> > > >
> > > > Hi Donal,
> > > >
> > > > I generally use firebug plugin in firefox to look at the command
> > > > and json response of any co

Re: Review Request 12131: CLOUDSTACK-3215 Cannot Deploy VM when using S3 object store without NFS Cache

[Donal Lafferty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/
---

(Updated June 28, 2013, 7:46 p.m.)


Review request for cloudstack, edison su and Min Chen.


Changes
---

Updated code to address comments by Edison Su.


Bugs: CLOUDSTACK-3215


Repository: cloudstack-git


Description
---

Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to 
not use a cache for image transfer if one can't be found.  Previously, the 
management server entered a failure state.
Also, added addition debug logging.


Diffs (updated)
-

  
engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
 4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e 
  
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 631de6a47a3eff510c84aa275fd87f8fa2f7780b 

Diff: https://reviews.apache.org/r/12131/diff/


Testing
---

Code executed on deployement using S3 and no NFS cache.  Did not have 
facilities to test on S3 with a cache. 


Thanks,

Donal Lafferty

RE: On master updatephysicalnetwork won't enable the phy. net?

[Prachi Damle]

Yes seeing this issue too. 
Checked the code and looks like a regression due to the following commit. 

---

Author: Bharat Kumar (bharat.ku...@citrix.com)
Author date:2 days ago (Wed Jun 26 20:55:30 2013 +0530)
Commit hash:7f2f25d640b47c8e72381bfc318a71ca2bfd

Cloudstack-2150 DB table entries of phisical network is not proper.Shows 
Duplicate entries 
Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges 
results in inconsistent DB entries

Signed-off-by: Jayapal 

Contained in branches: master
Contained in no tag

-Original Message-
From: Prasanna Santhanam [mailto:t...@apache.org] 
Sent: Friday, June 28, 2013 12:01 PM
To: CloudStack Dev
Subject: On master updatephysicalnetwork won't enable the phy. net?

Just running some devcloud tests and my physicalnetwork won't be enabled? Looks 
like a regression. Anyone else seeing this?

I'll have to find the checkin to be reverted if so.

--
Prasanna.,


Powered by BigRock.com

RE: On master updatephysicalnetwork won't enable the phy. net?

[Sudha Ponnaganti]

Pl do revert if it doesn't cause other issues. 

-Original Message-
From: Prachi Damle [mailto:prachi.da...@citrix.com] 
Sent: Friday, June 28, 2013 1:44 PM
To: dev@cloudstack.apache.org
Subject: RE: On master updatephysicalnetwork won't enable the phy. net?

Yes seeing this issue too. 
Checked the code and looks like a regression due to the following commit. 

---

Author: Bharat Kumar (bharat.ku...@citrix.com)
Author date:2 days ago (Wed Jun 26 20:55:30 2013 +0530)
Commit hash:7f2f25d640b47c8e72381bfc318a71ca2bfd

Cloudstack-2150 DB table entries of phisical network is not proper.Shows 
Duplicate entries 
Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges 
results in inconsistent DB entries

Signed-off-by: Jayapal 

Contained in branches: master
Contained in no tag

-Original Message-
From: Prasanna Santhanam [mailto:t...@apache.org] 
Sent: Friday, June 28, 2013 12:01 PM
To: CloudStack Dev
Subject: On master updatephysicalnetwork won't enable the phy. net?

Just running some devcloud tests and my physicalnetwork won't be enabled? Looks 
like a regression. Anyone else seeing this?

I'll have to find the checkin to be reverted if so.

--
Prasanna.,


Powered by BigRock.com

force all SSL for mgmt

[Musayev, Ilya]

Hi List,

How would I force all connections to go over https/8443, alternatively, I can 
just stop running 8080, but it would be nice to push all traffic from 8080 to 
8443.

Thanks
ilya

RE: force all SSL for mgmt

[Animesh Chaturvedi]

Do you have redirectPort set to 8443 in In Tomcat's  server.xml  connector 
element which specifies port 8080

> -Original Message-
> From: Musayev, Ilya [mailto:imusa...@webmd.net]
> Sent: Friday, June 28, 2013 2:16 PM
> To: dev@cloudstack.apache.org
> Subject: force all SSL for mgmt
> 
> Hi List,
> 
> How would I force all connections to go over https/8443, alternatively,
> I can just stop running 8080, but it would be nice to push all traffic
> from 8080 to 8443.
> 
> Thanks
> ilya

Review Request 12180: Fix NPE when adding invalid primary datastore

[Venkata Siva Vijayendra Bhamidipati]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/
---

Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and 
Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-3110


Repository: cloudstack-git


Description
---

Fixing an NPE when an attempt is made to add a primary datastore by providing 
an unreachable/nonexistent datastore/host.


Diffs
-

  
engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
 b92f92f 
  
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
 06b54e0 

Diff: https://reviews.apache.org/r/12180/diff/


Testing
---

With fix in place, an attempt to add an invalid primary datastore will fail 
with a GUI error dialog instead of failing silently with an NPE in the mgmt 
server log.


Thanks,

Venkata Siva Vijayendra Bhamidipati

RE: On master updatephysicalnetwork won't enable the phy. net?

[Prachi Damle]

I have reverted the commit 7f2f25d640b47c8e72381bfc318a71ca2bfd

-Original Message-
From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] 
Sent: Friday, June 28, 2013 2:00 PM
To: dev@cloudstack.apache.org
Subject: RE: On master updatephysicalnetwork won't enable the phy. net?

Pl do revert if it doesn't cause other issues. 

-Original Message-
From: Prachi Damle [mailto:prachi.da...@citrix.com] 
Sent: Friday, June 28, 2013 1:44 PM
To: dev@cloudstack.apache.org
Subject: RE: On master updatephysicalnetwork won't enable the phy. net?

Yes seeing this issue too. 
Checked the code and looks like a regression due to the following commit. 

---

Author: Bharat Kumar (bharat.ku...@citrix.com)
Author date:2 days ago (Wed Jun 26 20:55:30 2013 +0530)
Commit hash:7f2f25d640b47c8e72381bfc318a71ca2bfd

Cloudstack-2150 DB table entries of phisical network is not proper.Shows 
Duplicate entries 
Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges 
results in inconsistent DB entries

Signed-off-by: Jayapal 

Contained in branches: master
Contained in no tag

-Original Message-
From: Prasanna Santhanam [mailto:t...@apache.org] 
Sent: Friday, June 28, 2013 12:01 PM
To: CloudStack Dev
Subject: On master updatephysicalnetwork won't enable the phy. net?

Just running some devcloud tests and my physicalnetwork won't be enabled? Looks 
like a regression. Anyone else seeing this?

I'll have to find the checkin to be reverted if so.

--
Prasanna.,


Powered by BigRock.com

[ACS42] Feature Freeze reminder

[Animesh Chaturvedi]

Folks

Today is the feature freeze date, if you plan to get your features into 4.2 it 
needs to be in master today. I will cut 4.2 branch tomorrow morning PST.



Thanks
Animesh

Re: [ACS42] Feature Freeze reminder

[Mike Tutkowski]

Hi Animesh,

Just to make sure I'm dealing with the correct repo, I pushed my code to
master here:

https://git-wip-us.apache.org/repos/asf/cloudstack.git

This is where I fetch from, but I had not done a push there until today, so
I just wanted to make sure it was the correct location (i.e. not a mirror)
(although, I suppose if it were a mirror, I wouldn't have had permission to
push to it).

Thanks


On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> Folks
>
> Today is the feature freeze date, if you plan to get your features into
> 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow morning
> PST.
>
>
>
> Thanks
> Animesh
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: [ACS42] Feature Freeze reminder

[Hugo Trippaers]

Thats the one git to bind them :-)

Congrats on the first commit 


Cheers,

Hugo

On Jun 28, 2013, at 4:06 PM, Mike Tutkowski  
wrote:

> Hi Animesh,
> 
> Just to make sure I'm dealing with the correct repo, I pushed my code to
> master here:
> 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 
> This is where I fetch from, but I had not done a push there until today, so
> I just wanted to make sure it was the correct location (i.e. not a mirror)
> (although, I suppose if it were a mirror, I wouldn't have had permission to
> push to it).
> 
> Thanks
> 
> 
> On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
> 
>> Folks
>> 
>> Today is the feature freeze date, if you plan to get your features into
>> 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow morning
>> PST.
>> 
>> 
>> 
>> Thanks
>> Animesh
>> 
> 
> 
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *™*

Re: [ACS42] Feature Freeze reminder

[Mike Tutkowski]

Thanks!

It's great to have the code in place now. :)


On Fri, Jun 28, 2013 at 5:22 PM, Hugo Trippaers  wrote:

> Thats the one git to bind them :-)
>
> Congrats on the first commit
>
>
> Cheers,
>
> Hugo
>
> On Jun 28, 2013, at 4:06 PM, Mike Tutkowski 
> wrote:
>
> > Hi Animesh,
> >
> > Just to make sure I'm dealing with the correct repo, I pushed my code to
> > master here:
> >
> > https://git-wip-us.apache.org/repos/asf/cloudstack.git
> >
> > This is where I fetch from, but I had not done a push there until today,
> so
> > I just wanted to make sure it was the correct location (i.e. not a
> mirror)
> > (although, I suppose if it were a mirror, I wouldn't have had permission
> to
> > push to it).
> >
> > Thanks
> >
> >
> > On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
> > animesh.chaturv...@citrix.com> wrote:
> >
> >> Folks
> >>
> >> Today is the feature freeze date, if you plan to get your features into
> >> 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow
> morning
> >> PST.
> >>
> >>
> >>
> >> Thanks
> >> Animesh
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *™*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

RE: [ACS42] Feature Freeze reminder

[Animesh Chaturvedi]

Yes that's the one

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Friday, June 28, 2013 4:07 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Feature Freeze reminder
> 
> Hi Animesh,
> 
> Just to make sure I'm dealing with the correct repo, I pushed my code to
> master here:
> 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 
> This is where I fetch from, but I had not done a push there until today,
> so I just wanted to make sure it was the correct location (i.e. not a
> mirror) (although, I suppose if it were a mirror, I wouldn't have had
> permission to push to it).
> 
> Thanks
> 
> 
> On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
> 
> > Folks
> >
> > Today is the feature freeze date, if you plan to get your features
> > into
> > 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow
> > morning PST.
> >
> >
> >
> > Thanks
> > Animesh
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Re: Review Request 12131: CLOUDSTACK-3215 Cannot Deploy VM when using S3 object store without NFS Cache

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/#review22548
---

Ship it!


Ship It!

- edison su


On June 28, 2013, 7:46 p.m., Donal Lafferty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12131/
> ---
> 
> (Updated June 28, 2013, 7:46 p.m.)
> 
> 
> Review request for cloudstack, edison su and Min Chen.
> 
> 
> Bugs: CLOUDSTACK-3215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to 
> not use a cache for image transfer if one can't be found.  Previously, the 
> management server entered a failure state.
> Also, added addition debug logging.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
>  4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  631de6a47a3eff510c84aa275fd87f8fa2f7780b 
> 
> Diff: https://reviews.apache.org/r/12131/diff/
> 
> 
> Testing
> ---
> 
> Code executed on deployement using S3 and no NFS cache.  Did not have 
> facilities to test on S3 with a cache. 
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>

Re: Review Request 12131: CLOUDSTACK-3215 Cannot Deploy VM when using S3 object store without NFS Cache

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/#review22547
---


Commit 58f9202818ffe78f3cd6748fc8710433d11bd5a2 in branch refs/heads/master 
from Donal Lafferty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58f9202 ]

CLOUDSTACK-3215: Cannot Deploy VM when using S3 object store without NFS Cache

Signed-off-by: Edison Su 


- ASF Subversion and Git Services


On June 28, 2013, 7:46 p.m., Donal Lafferty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12131/
> ---
> 
> (Updated June 28, 2013, 7:46 p.m.)
> 
> 
> Review request for cloudstack, edison su and Min Chen.
> 
> 
> Bugs: CLOUDSTACK-3215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to 
> not use a cache for image transfer if one can't be found.  Previously, the 
> management server entered a failure state.
> Also, added addition debug logging.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
>  4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  631de6a47a3eff510c84aa275fd87f8fa2f7780b 
> 
> Diff: https://reviews.apache.org/r/12131/diff/
> 
> 
> Testing
> ---
> 
> Code executed on deployement using S3 and no NFS cache.  Did not have 
> facilities to test on S3 with a cache. 
> 
> 
> Thanks,
> 
> Donal Lafferty
> 
>

RE: [ACS42] Feature Freeze reminder

[Edison Su]

Nice! Thanks for your great work, now we will have first primary storage plugin 
in 4.2. 

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Friday, June 28, 2013 4:07 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Feature Freeze reminder
> 
> Hi Animesh,
> 
> Just to make sure I'm dealing with the correct repo, I pushed my code to
> master here:
> 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 
> This is where I fetch from, but I had not done a push there until today, so I
> just wanted to make sure it was the correct location (i.e. not a mirror)
> (although, I suppose if it were a mirror, I wouldn't have had permission to
> push to it).
> 
> Thanks
> 
> 
> On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
> 
> > Folks
> >
> > Today is the feature freeze date, if you plan to get your features
> > into
> > 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow
> > morning PST.
> >
> >
> >
> > Thanks
> > Animesh
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Re: Review Request 12101: CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to create VIF's)

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12101/#review22549
---


Commit 1659ee225c936b074bae1ede955194f60c546c02 in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1659ee2 ]

CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to 
create VIF's)


- ASF Subversion and Git Services


On June 26, 2013, 7:58 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12101/
> ---
> 
> (Updated June 26, 2013, 7:58 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3082
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to 
> create VIF's).
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3082
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  af640a2 
> 
> Diff: https://reviews.apache.org/r/12101/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1) setup a CS environment with XenServer 6.2
> 2) Verified that systemVMs are coming up.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 12101: CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to create VIF's)

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12101/#review22550
---


Commit 9e4b4a707f433d30c4513926cbdbb352d527ed55 in branch 
refs/heads/master-6-17-stable from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9e4b4a7 ]

CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to 
create VIF's)


- ASF Subversion and Git Services


On June 26, 2013, 7:58 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12101/
> ---
> 
> (Updated June 26, 2013, 7:58 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3082
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to 
> create VIF's).
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3082
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  af640a2 
> 
> Diff: https://reviews.apache.org/r/12101/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1) setup a CS environment with XenServer 6.2
> 2) Verified that systemVMs are coming up.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

[DISCUSS] If BVT breaks, revert the commits...

[Alex Huang]

After Dave's complain in the vmsync [MERGE] thread about BVT in horrible shape 
on master, I went around to figure out what exactly happened.  The best I can 
figure is that after a certain merge (I will leave out which merge as that's 
not important), BVT no longer runs automatically.  It was promised to be fixed 
and there are people who are actively fixing it but it's been in this way for 
about two weeks.  People running BVTs are working around the problem but it's 
not automated anymore and so it's no longer running on master.  I understand 
people are nice and tried to be accommodating to other people by working around 
the problem but sometimes we just have to be an arse.  So let me be that arse...

New Rule
If BVT or automated regression tests break on master or any release branch, we 
revert all commits that broke it.  It doesn't matter if they promise to fix it 
within the next hour.  If it's broken, the release manager will revert the 
commits and developers must resubmit.  It sounds mean but it's the only way 
this problem can be fixed.  

To avoid having a bunch of reverts and resubmits, the developers should be able 
to request that BVT run on their branch and don't merge until BVT on their 
branch is at 100%.  We will work on figuring out how to do that.

Comments?

--Alex

Re: Review Request 12130: Tag missing for test integratin.component test_ldap.py

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12130/#review22551
---

Ship it!


Ship It!

- Rayees Namathponnan


On June 27, 2013, 7:30 a.m., suresh sadhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12130/
> ---
> 
> (Updated June 27, 2013, 7:30 a.m.)
> 
> 
> Review request for cloudstack, Rayees Namathponnan, SrikanteswaraRao Talluri, 
> and Prasanna Santhanam.
> 
> 
> Bugs: cloudstack-3023
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added missing tags for test_ldap test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ldap.py 1b933db 
> 
> Diff: https://reviews.apache.org/r/12130/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> suresh sadhu
> 
>

Review Request 12184: Fix for defect CLOUDSTACK-2927

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12184/
---

Review request for cloudstack and Prachi Damle.


Repository: cloudstack-git


Description
---

Updated cloud.spec to package from  awsapi/resource/Axis2/axis2.xml  
cloudstack-bridge/webapps/awsapi/WEB-INF/conf


Diffs
-


Diff: https://reviews.apache.org/r/12184/diff/


Testing
---

tested 


Thanks,

Rayees Namathponnan

Re: Review Request 12184: Fix for defect CLOUDSTACK-2927

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12184/
---

(Updated June 29, 2013, 12:27 a.m.)


Review request for cloudstack and Prachi Damle.


Changes
---

Please merge to master and master-6-17-stable


Bugs: CLOUDSTACK-2927


Repository: cloudstack-git


Description
---

Updated cloud.spec to package from  awsapi/resource/Axis2/axis2.xml  
cloudstack-bridge/webapps/awsapi/WEB-INF/conf


Diffs
-


Diff: https://reviews.apache.org/r/12184/diff/


Testing
---

tested 


Thanks,

Rayees Namathponnan

Re: Review Request 12184: Fix for defect CLOUDSTACK-2927

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12184/
---

(Updated June 29, 2013, 12:28 a.m.)


Review request for cloudstack and Prachi Damle.


Bugs: CLOUDSTACK-2927


Repository: cloudstack-git


Description
---

Updated cloud.spec to package from  awsapi/resource/Axis2/axis2.xml  
cloudstack-bridge/webapps/awsapi/WEB-INF/conf


Diffs
-


Diff: https://reviews.apache.org/r/12184/diff/


Testing
---

tested 


File Attachments (updated)


File added
  
https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-Adding-axis2.xml-to-cloudstack-bridge-webapps-awsapi.patch


Thanks,

Rayees Namathponnan

Re: Review Request 12101: CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to create VIF's)

[Devdeep Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12101/#review22554
---

Ship it!


Ship It!

- Devdeep Singh


On June 26, 2013, 7:58 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12101/
> ---
> 
> (Updated June 26, 2013, 7:58 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3082
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-3082: System VMs are failed to start with Xen 6.2.0( Failing to 
> create VIF's).
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3082
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  af640a2 
> 
> Diff: https://reviews.apache.org/r/12101/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1) setup a CS environment with XenServer 6.2
> 2) Verified that systemVMs are coming up.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>