[GitHub] ant-ivy pull request #18: Fix IVY-1448

[jaikiran]

GitHub user jaikiran opened a pull request:

https://github.com/apache/ant-ivy/pull/18

Fix IVY-1448

The commit here fixes the issue reported in 
https://issues.apache.org/jira/browse/IVY-1448 and also includes a test case to 
verify the fix.

**Note that this issue isn't reproducible in \*nix platform, the one which 
I used for "fixing" this and this PR must be tested on a Windows system before 
this PR is merged.**

This commit also contains a fix to a potential resource leak while parsing 
the descriptor.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1448

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Minimum Java runtime version for proposed upcoming Ivy release

[J Pai]

Now that the plan seems to be to release 2.5.x of Ivy, would it be fine if we 
mandate the _minimum_ Java runtime version to be something higher than Java 5 
that’s currently supported for 2.4.x 
http://ant.apache.org/ivy/history/latest-milestone/compatibility.html.

Given that Java 6 itself has long been EOLed, I’m not sure whether we should 
consider that as minimum supported version or something higher. Any thoughts?

Things will be a bit more easy to develop and test once we finalize on the Java 
version.

-Jaikiran
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[Nicolas Lalevée]

I think that upgrading the requirement on the JDK is a good idea, because at 
least us, the maintainers, need at some point to be able to test it if there is 
an issue with that minimum JDK.

One thing to consider is which JDK is being required in the environment Ivy is 
being used: Ant, Gradle, SBT, Eclipse, Intellij… We shouldn’t require too high.

Nicolas

> Le 18 mai 2017 à 10:58, J Pai  a écrit :
> 
> Now that the plan seems to be to release 2.5.x of Ivy, would it be fine if we 
> mandate the _minimum_ Java runtime version to be something higher than Java 5 
> that’s currently supported for 2.4.x 
> http://ant.apache.org/ivy/history/latest-milestone/compatibility.html.
> 
> Given that Java 6 itself has long been EOLed, I’m not sure whether we should 
> consider that as minimum supported version or something higher. Any thoughts?
> 
> Things will be a bit more easy to develop and test once we finalize on the 
> Java version.
> 
> -Jaikiran
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[Paul King]

The current version of Groovy has 1.6 as the minimum but is our maintenance
stream.
The upcoming next version will require 1.7 and versions with 1.8 as the
minimum are not too far away.

Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.

I don't think Gradle uses any Ivy classes any more.

I'd recommend 1.7 since most active projects will be releasing on 1.7/1.8
and then after a release, if all goes well activity-wise, I'd then bump the
Ivy version and target 8.

Cheers, Paul.


On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée  wrote:

> I think that upgrading the requirement on the JDK is a good idea, because
> at least us, the maintainers, need at some point to be able to test it if
> there is an issue with that minimum JDK.
>
> One thing to consider is which JDK is being required in the environment
> Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij… We shouldn’t
> require too high.
>
> Nicolas
>
> > Le 18 mai 2017 à 10:58, J Pai  a écrit :
> >
> > Now that the plan seems to be to release 2.5.x of Ivy, would it be fine
> if we mandate the _minimum_ Java runtime version to be something higher
> than Java 5 that’s currently supported for 2.4.x
> http://ant.apache.org/ivy/history/latest-milestone/compatibility.html.
> >
> > Given that Java 6 itself has long been EOLed, I’m not sure whether we
> should consider that as minimum supported version or something higher. Any
> thoughts?
> >
> > Things will be a bit more easy to develop and test once we finalize on
> the Java version.
> >
> > -Jaikiran
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

Re: Ivy - Buildjobs/PreCommit

[Nicolas Lalevée]

I have changed the config of the build so it does a build, then checkstyle, 
then findbugs, and then the unit tests.

Nicolas

> Le 18 mai 2017 à 08:21, J Pai  a écrit :
> 
> Now that the findbugs URL issue has been resolved with this PR[1] being 
> merged, maybe we should change the targets that get run via this pre commit 
> job to be just:
> 
> ant clean test
> 
> and as a start, see how it goes with the PR integration process?
> 
> [1] https://github.com/apache/ant-ivy/pull/16 
> 
> 
> -Jaikiran
> 
> On 17-May-2017, at 6:59 PM, Nicolas Lalevée  > wrote:
> 
> Seems to be a classpath issue where two ivy.jar are loaded. Considering the 
> full console log, probably due to init-ivy called twice, a consequence of Ant 
> not computing one unified tree of tasks to call, but a list of trees of the 
> tasks on the command line.
> 
> The build dedicated to check the style of Ivy is just calling: ant findbugs 
> checkstyle-internal
> https://builds.apache.org/view/A/view/Ant/job/Ivy-check 
>  
>  >
> But it seems broken too due to some broken download link. The init-findbug 
> task needs to be fixed.
> 
> Nicolas
> 
>> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm)  a écrit :
>> 
>> My last test result:
>> The Jenkins job could not load Findbugs. So I have deactivated that for the 
>> moment.
>> 
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
>> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report 
>> resolve:
>> BUILD FAILED
>> /.../build.xml:184: java.lang.ClassCastException: 
>> org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast 
>> to org.apache.ivy.core.module.descriptor.ModuleDescriptor
>>  at 
>> org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
>>  at 
>> org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
>>  at 
>> org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
>>  at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
>>  at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>> 
>> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
>> not run due to prior problems
>> 
>> 
>> Some ideas?
>> 
>> 
>> Jan
>> 
>> 
>>> -Ursprüngliche Nachricht-
>>> Von: J Pai [mailto:jai.forums2...@gmail.com]
>>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>>> An: Ant Developers List
>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>> 
>>> Updated the same PR and that triggered this job
>>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>>> to a host not being resolvable. This job ran on node called H15
>>> https://builds.apache.org/computer/H15/ whereas the first job which had
>>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>>> all nodes are not equal and perhaps this job needs to be
>>> assigned/categorized to certain node groups?
>>> 
>>> -Jaikiran
>>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) 
>>> wrote:
>>> 
>>> Thanks, I changed the job to run:
>>> 
>>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>>> -f build-release.xml -Drat.failOnError=false rat
>>> 
>>> Please try again ;)
>>> 
>>> 
>>> Jan
>>> 
>>> 
 -Ursprüngliche Nachricht-
 Von: J Pai [mailto:jai.forums2...@gmail.com]
 Gesendet: Mittwoch, 17. Mai 2017 10:53
 An: Ant Developers List
 Betreff: Re: Ivy - Buildjobs/PreCommit
 
 It turns out the PR you submitted was to your personal repo instead
>>> of
 the apache repo. I just submitted a dummy PR to apache repo
 https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
 the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
 GithubPR/1/ automagically :) I’m guessing this job isn’t running any
 tests right now (given how quickly it finished)?
 
 This is good start to getting this working. Thanks for getting this
 setup :)
 
 -Jaikiran
 
 
 On 17-May-2017, at 2:07 PM, J Pai  wrote:
 
 Doesn’t look like it got triggered in Jenkins.
 
 -Jaikiran
 On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) 
 wrote:
 
> I read the wiki page
>>> https://wiki.apache.org/general/PreCommitBuilds,
> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> had a look at some other PreCommit-jobs.
> For me this works like that:
> 1. The PreCommit-Admin job checks regularly on for new patches in
 Jira.
> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
> file-ID as argument.
> 3. The job does the rest.
> 
> That means the job itself has to apply the patchfile - and of course
> run the build.
> 
>>>

[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

[jaikiran]

GitHub user jaikiran opened a pull request:

https://github.com/apache/ant-ivy/pull/19

IVY-1554 - Add (conditional) support for SHA-256 SHA-512 and SHA-384 
checksum algorithms

The commit here adds support for SHA-256, SHA-512 and SHA-384 algorithms as 
requested in https://issues.apache.org/jira/browse/IVY-1554.

These algorithms are added to the "known/supported algorithms", that Ivy 
uses to verify and publish checksums, only if the underlying Java runtime 
supports those. Starting Java 6 all these 3 are standard supported algorithms, 
but we haven't yet finalized what the minimum required Java runtime is going to 
be for the next Ivy release. Hence the conditional check for now.

Furthermore, although the feature doesn't mandate Java 6 runtime, the 
testcases that I have added do require Java 6 runtime to pass. I can make those 
tests conditional too, but decided not to at this point. Let me know if I have 
to.

Finally, I decided to use the algorithm keys as-is i.e. `SHA-256`, 
`SHA-512` and `SHA-384` instead of using aliases like we do for `SHA-1` (we use 
`sha1` as the checksum name there). What this effectively means for Ivy 
checksum verification and publishing is that the checksum files will have an 
extension like `original-file.SHA-256`. I haven't found any well known 
conventions for file name extensions for these algorithm checksum files, so I 
just decided to go ahead with this convention.

With this commit, the complete list of supported checksum algorithms are:

- md5
- sha1
- MD5
- SHA-1
- SHA-256
- SHA-512
- SHA-384



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1554

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit d8c3ef1363fd2c9d88df1093db4fe04340bedec6
Author: Jaikiran Pai 
Date:   2017-05-18T10:39:06Z

IVY-1554 Add support for SHA-256 SHA-512 and SHA-384 checksum algorithms if 
the underlying Java runtime supports it




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: Minimum Java runtime version for proposed upcoming Ivy release

[jhm]

I would favour 1.7 as it's the newest before the major update to Java8.
Having a 1.7 in the target environment should not been so restrictive ...

Jan

> -Ursprüngliche Nachricht-
> Von: Paul King [mailto:pa...@asert.com.au]
> Gesendet: Donnerstag, 18. Mai 2017 11:27
> An: Ant Developers List
> Betreff: Re: Minimum Java runtime version for proposed upcoming Ivy
> release
> 
> The current version of Groovy has 1.6 as the minimum but is our
> maintenance stream.
> The upcoming next version will require 1.7 and versions with 1.8 as the
> minimum are not too far away.
> 
> Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
> 
> I don't think Gradle uses any Ivy classes any more.
> 
> I'd recommend 1.7 since most active projects will be releasing on
> 1.7/1.8 and then after a release, if all goes well activity-wise, I'd
> then bump the Ivy version and target 8.
> 
> Cheers, Paul.
> 
> 
> On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée
>  > wrote:
> 
> > I think that upgrading the requirement on the JDK is a good idea,
> > because at least us, the maintainers, need at some point to be able
> to
> > test it if there is an issue with that minimum JDK.
> >
> > One thing to consider is which JDK is being required in the
> > environment Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij…
> We
> > shouldn’t require too high.
> >
> > Nicolas
> >
> > > Le 18 mai 2017 à 10:58, J Pai  a écrit :
> > >
> > > Now that the plan seems to be to release 2.5.x of Ivy, would it be
> > > fine
> > if we mandate the _minimum_ Java runtime version to be something
> > higher than Java 5 that’s currently supported for 2.4.x
> > http://ant.apache.org/ivy/history/latest-
> milestone/compatibility.html.
> > >
> > > Given that Java 6 itself has long been EOLed, I’m not sure whether
> > > we
> > should consider that as minimum supported version or something
> higher.
> > Any thoughts?
> > >
> > > Things will be a bit more easy to develop and test once we finalize
> > > on
> > the Java version.
> > >
> > > -Jaikiran
> > > ---
> -
> > > - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For
> > > additional commands, e-mail: dev-h...@ant.apache.org
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > commands, e-mail: dev-h...@ant.apache.org
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[J Pai]

+1

-Jaikiran
On 18-May-2017, at 4:26 PM, Jan Matèrne (jhm)  wrote:

I would favour 1.7 as it's the newest before the major update to Java8.
Having a 1.7 in the target environment should not been so restrictive ...

Jan

> -Ursprüngliche Nachricht-
> Von: Paul King [mailto:pa...@asert.com.au]
> Gesendet: Donnerstag, 18. Mai 2017 11:27
> An: Ant Developers List
> Betreff: Re: Minimum Java runtime version for proposed upcoming Ivy
> release
> 
> The current version of Groovy has 1.6 as the minimum but is our
> maintenance stream.
> The upcoming next version will require 1.7 and versions with 1.8 as the
> minimum are not too far away.
> 
> Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
> 
> I don't think Gradle uses any Ivy classes any more.
> 
> I'd recommend 1.7 since most active projects will be releasing on
> 1.7/1.8 and then after a release, if all goes well activity-wise, I'd
> then bump the Ivy version and target 8.
> 
> Cheers, Paul.
> 
> 
> On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée
> > wrote:
> 
>> I think that upgrading the requirement on the JDK is a good idea,
>> because at least us, the maintainers, need at some point to be able
> to
>> test it if there is an issue with that minimum JDK.
>> 
>> One thing to consider is which JDK is being required in the
>> environment Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij…
> We
>> shouldn’t require too high.
>> 
>> Nicolas
>> 
>>> Le 18 mai 2017 à 10:58, J Pai  a écrit :
>>> 
>>> Now that the plan seems to be to release 2.5.x of Ivy, would it be
>>> fine
>> if we mandate the _minimum_ Java runtime version to be something
>> higher than Java 5 that’s currently supported for 2.4.x
>> http://ant.apache.org/ivy/history/latest-
> milestone/compatibility.html.
>>> 
>>> Given that Java 6 itself has long been EOLed, I’m not sure whether
>>> we
>> should consider that as minimum supported version or something
> higher.
>> Any thoughts?
>>> 
>>> Things will be a bit more easy to develop and test once we finalize
>>> on
>> the Java version.
>>> 
>>> -Jaikiran
>>> ---
> -
>>> - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For
>>> additional commands, e-mail: dev-h...@ant.apache.org
>>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
>> commands, e-mail: dev-h...@ant.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[Matt Sicker]

Using 1.7 for the next release and then 1.8 for the following release makes
sense to me.

On 18 May 2017 at 05:58, J Pai  wrote:

> +1
>
> -Jaikiran
> On 18-May-2017, at 4:26 PM, Jan Matèrne (jhm)  wrote:
>
> I would favour 1.7 as it's the newest before the major update to Java8.
> Having a 1.7 in the target environment should not been so restrictive ...
>
> Jan
>
> > -Ursprüngliche Nachricht-
> > Von: Paul King [mailto:pa...@asert.com.au]
> > Gesendet: Donnerstag, 18. Mai 2017 11:27
> > An: Ant Developers List
> > Betreff: Re: Minimum Java runtime version for proposed upcoming Ivy
> > release
> >
> > The current version of Groovy has 1.6 as the minimum but is our
> > maintenance stream.
> > The upcoming next version will require 1.7 and versions with 1.8 as the
> > minimum are not too far away.
> >
> > Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
> >
> > I don't think Gradle uses any Ivy classes any more.
> >
> > I'd recommend 1.7 since most active projects will be releasing on
> > 1.7/1.8 and then after a release, if all goes well activity-wise, I'd
> > then bump the Ivy version and target 8.
> >
> > Cheers, Paul.
> >
> >
> > On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée
> >  >> wrote:
> >
> >> I think that upgrading the requirement on the JDK is a good idea,
> >> because at least us, the maintainers, need at some point to be able
> > to
> >> test it if there is an issue with that minimum JDK.
> >>
> >> One thing to consider is which JDK is being required in the
> >> environment Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij…
> > We
> >> shouldn’t require too high.
> >>
> >> Nicolas
> >>
> >>> Le 18 mai 2017 à 10:58, J Pai  a écrit :
> >>>
> >>> Now that the plan seems to be to release 2.5.x of Ivy, would it be
> >>> fine
> >> if we mandate the _minimum_ Java runtime version to be something
> >> higher than Java 5 that’s currently supported for 2.4.x
> >> http://ant.apache.org/ivy/history/latest-
> > milestone/compatibility.html.
> >>>
> >>> Given that Java 6 itself has long been EOLed, I’m not sure whether
> >>> we
> >> should consider that as minimum supported version or something
> > higher.
> >> Any thoughts?
> >>>
> >>> Things will be a bit more easy to develop and test once we finalize
> >>> on
> >> the Java version.
> >>>
> >>> -Jaikiran
> >>> ---
> > -
> >>> - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For
> >>> additional commands, e-mail: dev-h...@ant.apache.org
> >>>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> >> commands, e-mail: dev-h...@ant.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


-- 
Matt Sicker 

[GitHub] ant-ivy pull request #17: Fix IVY-1478

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[Gintautas Grigelionis]

That's fine, IvyDE is already at Java 7/Eclipse 3.7.1; then IvyDE baseline
should be bumped to Java 8/Eclipse 4.4 with the next Ivy release. Hopefully
updatesite resolver could be used then.

2017-05-18 17:12 GMT+02:00 Matt Sicker :

> Using 1.7 for the next release and then 1.8 for the following release makes
> sense to me.
>
> On 18 May 2017 at 05:58, J Pai  wrote:
>
> > +1
> >
> > -Jaikiran
> > On 18-May-2017, at 4:26 PM, Jan Matèrne (jhm)  wrote:
> >
> > I would favour 1.7 as it's the newest before the major update to Java8.
> > Having a 1.7 in the target environment should not been so restrictive ...
> >
> > Jan
> >
> > > -Ursprüngliche Nachricht-
> > > Von: Paul King [mailto:pa...@asert.com.au]
> > > Gesendet: Donnerstag, 18. Mai 2017 11:27
> > > An: Ant Developers List
> > > Betreff: Re: Minimum Java runtime version for proposed upcoming Ivy
> > > release
> > >
> > > The current version of Groovy has 1.6 as the minimum but is our
> > > maintenance stream.
> > > The upcoming next version will require 1.7 and versions with 1.8 as the
> > > minimum are not too far away.
> > >
> > > Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
> > >
> > > I don't think Gradle uses any Ivy classes any more.
> > >
> > > I'd recommend 1.7 since most active projects will be releasing on
> > > 1.7/1.8 and then after a release, if all goes well activity-wise, I'd
> > > then bump the Ivy version and target 8.
> > >
> > > Cheers, Paul.
> > >
> > >
> > > On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée
> > >  > >> wrote:
> > >
> > >> I think that upgrading the requirement on the JDK is a good idea,
> > >> because at least us, the maintainers, need at some point to be able
> > > to
> > >> test it if there is an issue with that minimum JDK.
> > >>
> > >> One thing to consider is which JDK is being required in the
> > >> environment Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij…
> > > We
> > >> shouldn’t require too high.
> > >>
> > >> Nicolas
> > >>
> > >>> Le 18 mai 2017 à 10:58, J Pai  a écrit :
> > >>>
> > >>> Now that the plan seems to be to release 2.5.x of Ivy, would it be
> > >>> fine
> > >> if we mandate the _minimum_ Java runtime version to be something
> > >> higher than Java 5 that’s currently supported for 2.4.x
> > >> http://ant.apache.org/ivy/history/latest-
> > > milestone/compatibility.html.
> > >>>
> > >>> Given that Java 6 itself has long been EOLed, I’m not sure whether
> > >>> we
> > >> should consider that as minimum supported version or something
> > > higher.
> > >> Any thoughts?
> > >>>
> > >>> Things will be a bit more easy to develop and test once we finalize
> > >>> on
> > >> the Java version.
> > >>>
> > >>> -Jaikiran
> > >>> ---
> > > -
> > >>> - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For
> > >>> additional commands, e-mail: dev-h...@ant.apache.org
> > >>>
> > >>
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > >> commands, e-mail: dev-h...@ant.apache.org
> > >>
> > >>
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
> >
>
>
> --
> Matt Sicker 
>

[GitHub] ant-ivy pull request #18: Fix IVY-1448

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[Gintautas Grigelionis]

Gradle does have an Ivy plugin which wraps Ivy 2.2.0

2017-05-18 11:26 GMT+02:00 Paul King :

> The current version of Groovy has 1.6 as the minimum but is our maintenance
> stream.
> The upcoming next version will require 1.7 and versions with 1.8 as the
> minimum are not too far away.
>
> Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
>
> I don't think Gradle uses any Ivy classes any more.
>
> I'd recommend 1.7 since most active projects will be releasing on 1.7/1.8
> and then after a release, if all goes well activity-wise, I'd then bump the
> Ivy version and target 8.
>
> Cheers, Paul.
>
>
> On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée <
> nicolas.lale...@hibnet.org
> > wrote:
>
> > I think that upgrading the requirement on the JDK is a good idea, because
> > at least us, the maintainers, need at some point to be able to test it if
> > there is an issue with that minimum JDK.
> >
> > One thing to consider is which JDK is being required in the environment
> > Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij… We shouldn’t
> > require too high.
> >
> > Nicolas
> >
> > > Le 18 mai 2017 à 10:58, J Pai  a écrit :
> > >
> > > Now that the plan seems to be to release 2.5.x of Ivy, would it be fine
> > if we mandate the _minimum_ Java runtime version to be something higher
> > than Java 5 that’s currently supported for 2.4.x
> > http://ant.apache.org/ivy/history/latest-milestone/compatibility.html.
> > >
> > > Given that Java 6 itself has long been EOLed, I’m not sure whether we
> > should consider that as minimum supported version or something higher.
> Any
> > thoughts?
> > >
> > > Things will be a bit more easy to develop and test once we finalize on
> > the Java version.
> > >
> > > -Jaikiran
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > > For additional commands, e-mail: dev-h...@ant.apache.org
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
> >
>

[GitHub] ant-ivy pull request #20: Fix IVY-1522

[jaikiran]

GitHub user jaikiran opened a pull request:

https://github.com/apache/ant-ivy/pull/20

Fix IVY-1522

The commit here contains a potential fix for the issue reported in 
https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test 
case to verify the fix. 

**Note that this issue isn't reproducible on my \*nix system and as such 
the fix/PR itself needs to be tested on a Windows OS before being merged. That 
plus the fact that this commit deals with the part of the code which gets used 
in multiple places. Tests on my local \*nix have gone fine with this change and 
such don't seem to introduce any regressions.**



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 47312947d3c2411aae8b26f44182d7256193558e
Author: Jaikiran Pai 
Date:   2017-05-18T14:42:41Z

IVY-1522 Fix FileUtil.normalize to only consider ":" if it's part of the 
filesystem root on Windows OS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Minimum Java runtime version for proposed upcoming Ivy release

[J Pai]

So far the majority seems to be to require a minimum of Java 7. If there are no 
concerns or objections to this by the end of this week, then on Monday, I’ll 
raise a PR to mandate Java 7 for Ivy.

-Jaikiran


On 18-May-2017, at 11:48 PM, Gintautas Grigelionis  
wrote:

That's fine, IvyDE is already at Java 7/Eclipse 3.7.1; then IvyDE baseline
should be bumped to Java 8/Eclipse 4.4 with the next Ivy release. Hopefully
updatesite resolver could be used then.

2017-05-18 17:12 GMT+02:00 Matt Sicker :

> Using 1.7 for the next release and then 1.8 for the following release makes
> sense to me.
> 
> On 18 May 2017 at 05:58, J Pai  wrote:
> 
>> +1
>> 
>> -Jaikiran
>> On 18-May-2017, at 4:26 PM, Jan Matèrne (jhm)  wrote:
>> 
>> I would favour 1.7 as it's the newest before the major update to Java8.
>> Having a 1.7 in the target environment should not been so restrictive ...
>> 
>> Jan
>> 
>>> -Ursprüngliche Nachricht-
>>> Von: Paul King [mailto:pa...@asert.com.au]
>>> Gesendet: Donnerstag, 18. Mai 2017 11:27
>>> An: Ant Developers List
>>> Betreff: Re: Minimum Java runtime version for proposed upcoming Ivy
>>> release
>>> 
>>> The current version of Groovy has 1.6 as the minimum but is our
>>> maintenance stream.
>>> The upcoming next version will require 1.7 and versions with 1.8 as the
>>> minimum are not too far away.
>>> 
>>> Ant 1.9.x is still on Java5 but Ant 1.10.x requires Java 8.
>>> 
>>> I don't think Gradle uses any Ivy classes any more.
>>> 
>>> I'd recommend 1.7 since most active projects will be releasing on
>>> 1.7/1.8 and then after a release, if all goes well activity-wise, I'd
>>> then bump the Ivy version and target 8.
>>> 
>>> Cheers, Paul.
>>> 
>>> 
>>> On Thu, May 18, 2017 at 7:14 PM, Nicolas Lalevée
>>> >>> wrote:
>>> 
 I think that upgrading the requirement on the JDK is a good idea,
 because at least us, the maintainers, need at some point to be able
>>> to
 test it if there is an issue with that minimum JDK.
 
 One thing to consider is which JDK is being required in the
 environment Ivy is being used: Ant, Gradle, SBT, Eclipse, Intellij…
>>> We
 shouldn’t require too high.
 
 Nicolas
 
> Le 18 mai 2017 à 10:58, J Pai  a écrit :
> 
> Now that the plan seems to be to release 2.5.x of Ivy, would it be
> fine
 if we mandate the _minimum_ Java runtime version to be something
 higher than Java 5 that’s currently supported for 2.4.x
 http://ant.apache.org/ivy/history/latest-
>>> milestone/compatibility.html.
> 
> Given that Java 6 itself has long been EOLed, I’m not sure whether
> we
 should consider that as minimum supported version or something
>>> higher.
 Any thoughts?
> 
> Things will be a bit more easy to develop and test once we finalize
> on
 the Java version.
> 
> -Jaikiran
> ---
>>> -
> - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For
> additional commands, e-mail: dev-h...@ant.apache.org
> 
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
 commands, e-mail: dev-h...@ant.apache.org
 
 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>> 
>> 
> 
> 
> --
> Matt Sicker 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[VOTE] Increase minimum Java version for Ivy to Java7

[Jan Matèrne]

As discussed on this mailing list [1] we should increase the minimum Java
version [2] from current (Ivy-2.4.0) Java5 to Java 7 (Ivy-2.5.0).
Decisions whether to increase to Java8 after that release should be make
after that release.
According to the bylaws [3] this vote is open for one week (until
26.05.2017).

Here is my +1
Jan

[1]
http://mail-archives.apache.org/mod_mbox/ant-dev/201705.mbox/ajax/%3C87415C1
F-5EFF-4C81-8078-0276CC21A8ED%40gmail.com%3E
[2] http://ant.apache.org/ivy/history/latest-milestone/compatibility.html
[3] http://ant.apache.org/bylaws.html


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Increase minimum Java version for Ivy to Java7

[J Pai]

+1

-Jaikiran
On 19-May-2017, at 10:55 AM, Jan Matèrne  wrote:

As discussed on this mailing list [1] we should increase the minimum Java
version [2] from current (Ivy-2.4.0) Java5 to Java 7 (Ivy-2.5.0).
Decisions whether to increase to Java8 after that release should be make
after that release.
According to the bylaws [3] this vote is open for one week (until
26.05.2017).

Here is my +1
Jan

[1]
http://mail-archives.apache.org/mod_mbox/ant-dev/201705.mbox/ajax/%3C87415C1
F-5EFF-4C81-8078-0276CC21A8ED%40gmail.com%3E
[2] http://ant.apache.org/ivy/history/latest-milestone/compatibility.html
[3] http://ant.apache.org/bylaws.html


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org