Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
On Thu, 25 Aug 2016, adrian15 wrote: > That's how the grub-pc menu (BIOS) shows currently in live-build. Well, it sucks compared to the default visual appearance of isolinux/syslinux in live-build. > > - there are no menu entries to start debian-installer even though > >I built my image with "--debian-installer live" > > There were not such entries in the isolinux menu (BIOS). I already commented > such incongruence when I submitted my loopback patch but Daniel (or irl > maybe?. It was around the time dba quitted the project) agreed to merge my > code. > > Compared to binary_grub2 script I have removed the installation > entries because I did not see any of them in binary_syslinux. > > Can you explain to me why such Installation entries are not available in > binary_syslinux? > Maybe they should be put there also? Well, the menu entries are there by default: $ cat share/bootloaders/isolinux/menu.cfg menu hshift 0 menu width 82 menu title Boot menu include stdmenu.cfg include live.cfg include install.cfg menu begin advanced menu title Advanced options include stdmenu.cfg label mainmenu menu label ^Back.. menu exit include advanced.cfg menu end menu clear $ cat share/bootloaders/isolinux/install.cfg label install menu label ^Install linux /install/vmlinuz initrd /install/initrd.gz append vga=788 @APPEND_INSTALL@ --- quiet label installgui menu label ^Graphical install linux /install/gtk/vmlinuz initrd /install/gtk/initrd.gz append video=vesa:ywrap,mtrr vga=788 @APPEND_INSTALL@ --- quiet In fact I have not found any code to drop those entries when you don't want debian-installer in your live image... so I would rather see the opposite problem. So please add those entries in the grub menu. > > - the menu entries hardcode "Debian GNU/Linux" as name of the project, > >in the default syslinux configuration the entries are agnostic as in > >"Live (@FLAVOUR@)". > That @FLAVOUR@ is from Debian's live-build? Yes: $ cat share/bootloaders/isolinux/live.cfg.in label live-@FLAVOUR@ menu label ^Live (@FLAVOUR@) menu default linux @LINUX@ initrd @INITRD@ append @APPEND_LIVE@ label live-@FLAVOUR@-failsafe menu label ^Live (@FLAVOUR@ failsafe) linux @LINUX@ initrd @INITRD@ append @APPEND_LIVE_FAILSAFE@ > > I guess that some of those issues are not due to your changes, they > > are probably longstanding issues in the generic grub code but still > > it would be nice to have this fixed to have a more consistent experience > > between grub and syslinux. > > Well, there are some possible solutions to this problem: > > 1. Try to reuse some code from jnqnfe. He did quite some work on improving > bootloaders design which I don't think got into GIT: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775322 . His patch set is massive... but yes we should probably review them and merge what's appropriate. > 2. Try to reuse the debian-cd scripts which try to convert syslinux cfg > files into grub ones (including the design). > > Here: > > https://anonscm.debian.org/cgit/debian-cd/debian-cd.git/tree/tools/boot/jessie/parse_isolinux > > Not sure if this is the correct version to use but be warned that Sledge > himself warns us that it's not pretty. Yeah, I looked that code in the past and I would not want to rely on this even though the principle would be nice... > 3. Commit the patch as is and later on add more patches on the minimal set > needed for prettyfing this. I'm ok for this but I would still like you to re-add the installer entries first. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
El 26/08/16 a las 09:52, Raphael Hertzog escribió: On Thu, 25 Aug 2016, adrian15 wrote: That's how the grub-pc menu (BIOS) shows currently in live-build. Well, it sucks compared to the default visual appearance of isolinux/syslinux in live-build. I know, but the purpose of my patch is to add UEFI support. Not to improve visual appearance of grub2 so that it matches the isolinux/syslinux one. - there are no menu entries to start debian-installer even though I built my image with "--debian-installer live" There were not such entries in the isolinux menu (BIOS). I already commented such incongruence when I submitted my loopback patch but Daniel (or irl maybe?. It was around the time dba quitted the project) agreed to merge my code. Compared to binary_grub2 script I have removed the installation entries because I did not see any of them in binary_syslinux. Can you explain to me why such Installation entries are not available in binary_syslinux? Maybe they should be put there also? Well, the menu entries are there by default: $ cat share/bootloaders/isolinux/menu.cfg menu hshift 0 menu width 82 menu title Boot menu include stdmenu.cfg include live.cfg include install.cfg menu begin advanced menu title Advanced options include stdmenu.cfg label mainmenu menu label ^Back.. menu exit include advanced.cfg menu end menu clear $ cat share/bootloaders/isolinux/install.cfg label install menu label ^Install linux /install/vmlinuz initrd /install/initrd.gz append vga=788 @APPEND_INSTALL@ --- quiet label installgui menu label ^Graphical install linux /install/gtk/vmlinuz initrd /install/gtk/initrd.gz append video=vesa:ywrap,mtrr vga=788 @APPEND_INSTALL@ --- quiet In fact I have not found any code to drop those entries when you don't want debian-installer in your live image... so I would rather see the opposite problem. So please add those entries in the grub menu. These: /install/vmlinuz and /install/initrd.gz strings seem to be hardcoded. That explains why I did not see them in binary_syslinux . What does happen if you request both x86 and amd64 in your Debian Live? The first kernel gets into the /install/vmlinuz and the second kernel gets discarded? - the menu entries hardcode "Debian GNU/Linux" as name of the project, in the default syslinux configuration the entries are agnostic as in "Live (@FLAVOUR@)". That @FLAVOUR@ is from Debian's live-build? Yes: $ cat share/bootloaders/isolinux/live.cfg.in label live-@FLAVOUR@ menu label ^Live (@FLAVOUR@) menu default linux @LINUX@ initrd @INITRD@ append @APPEND_LIVE@ label live-@FLAVOUR@-failsafe menu label ^Live (@FLAVOUR@ failsafe) linux @LINUX@ initrd @INITRD@ append @APPEND_LIVE_FAILSAFE@ I see. I guess that some of those issues are not due to your changes, they are probably longstanding issues in the generic grub code but still it would be nice to have this fixed to have a more consistent experience between grub and syslinux. Well, there are some possible solutions to this problem: 1. Try to reuse some code from jnqnfe. He did quite some work on improving bootloaders design which I don't think got into GIT: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775322 . His patch set is massive... but yes we should probably review them and merge what's appropriate. Yeah, probably. 2. Try to reuse the debian-cd scripts which try to convert syslinux cfg files into grub ones (including the design). Here: https://anonscm.debian.org/cgit/debian-cd/debian-cd.git/tree/tools/boot/jessie/parse_isolinux Not sure if this is the correct version to use but be warned that Sledge himself warns us that it's not pretty. Yeah, I looked that code in the past and I would not want to rely on this even though the principle would be nice... :) 3. Commit the patch as is and later on add more patches on the minimal set needed for prettyfing this. I'm ok for this but I would still like you to re-add the installer entries first. Although I do not like those hardcoded /install/vmlinuz strings I think I can do that. I will apply those patches as an addendum to my current changes. I don't think it's worth the rebased needed for applying first the changes into the grub-pc code. Cheers, Thank you for your feedback. adrian15 -- Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
On Fri, 26 Aug 2016, adrian15 wrote: > > Well, it sucks compared to the default visual appearance of > > isolinux/syslinux in live-build. > I know, but the purpose of my patch is to add UEFI support. Not to improve > visual appearance of grub2 so that it matches the isolinux/syslinux one. Well, my initial patch added EFI support on top of syslinux-efi and it thus had a nice visual appearance by default. So for me it's a regression... But I assume it's not a regression in terms of computers supported because I believe that syslinux-efi works for less cases than grub-efi and hence why I did not commit my own patch in the first place. Also I expect that secure boot will be easier to add on top of grub than on top of syslinux. So I agree to apply your patch but I hope that you will stick around to help improve the visual appearance. > These: /install/vmlinuz and /install/initrd.gz strings seem to be hardcoded. > That explains why I did not see them in binary_syslinux . > What does happen if you request both x86 and amd64 in your Debian Live? The > first kernel gets into the /install/vmlinuz and the second kernel gets > discarded? I don't know, I never tried to build images for multiple architectures. It's not a need for me. > I will apply those patches as an addendum to my current changes. I don't > think it's worth the rebased needed for applying first the changes into the > grub-pc code. Fine for me. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
Hi, Raphael Hertzog wrote: > I believe that syslinux-efi works for less cases than grub-efi Discussions on syslinux mailing lists indicate that syslinux-efi does not work with optical drives. (And i know of no bootable ISO 9660 image which would have syslinux-efi in its El Torito boot image which serves as EFI System Partition.) Have a nice day :) Thomas
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
El 26/08/16 a las 13:34, Raphael Hertzog escribió: On Fri, 26 Aug 2016, adrian15 wrote: Well, it sucks compared to the default visual appearance of isolinux/syslinux in live-build. I know, but the purpose of my patch is to add UEFI support. Not to improve visual appearance of grub2 so that it matches the isolinux/syslinux one. Well, my initial patch added EFI support on top of syslinux-efi and it thus had a nice visual appearance by default. So for me it's a regression... I consider myself syslinux to be a regression in terms of functionality compared to grub2 but I stick to syslinux because I don't want delta between Rescatux and Debian Live to be too large. I compare this new grub2 appearance to be the same one had the debian-cd when it started to support UEFI back in the day. But I assume it's not a regression in terms of computers supported because I believe that syslinux-efi works for less cases than grub-efi and hence why I did not commit my own patch in the first place. Also I expect that secure boot will be easier to add on top of grub than on top of syslinux. That's true. There does not seem to be a secure boot support in the works in the syslinux side of things. So I agree to apply your patch but I hope that you will stick around to help improve the visual appearance. I will try to check what jnqnfe did but I don't promise anything. I commited myself to work on this bug one year ago and I went silent on this bug for 3 or 4 months. These: /install/vmlinuz and /install/initrd.gz strings seem to be hardcoded. That explains why I did not see them in binary_syslinux . What does happen if you request both x86 and amd64 in your Debian Live? The first kernel gets into the /install/vmlinuz and the second kernel gets discarded? I don't know, I never tried to build images for multiple architectures. It's not a need for me. I see. I will apply those patches as an addendum to my current changes. I don't think it's worth the rebased needed for applying first the changes into the grub-pc code. Fine for me. Ok. Cheers, adrian15 -- Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
On 26 August 2016 at 13:34, Raphael Hertzog wrote: > On Fri, 26 Aug 2016, adrian15 wrote: >> > Well, it sucks compared to the default visual appearance of >> > isolinux/syslinux in live-build. >> I know, but the purpose of my patch is to add UEFI support. Not to improve >> visual appearance of grub2 so that it matches the isolinux/syslinux one. > > Well, my initial patch added EFI support on top of syslinux-efi and it > thus had a nice visual appearance by default. So for me it's a > regression... > > But I assume it's not a regression in terms of computers supported because > I believe that syslinux-efi works for less cases than grub-efi and hence > why I did not commit my own patch in the first place. Also I expect that > secure boot will be easier to add on top of grub than on top of syslinux. It works for Ubuntu so you can just pull the packages from there either through apt pinning or by building a personal repo with them. It seems some parts of the stuff are landing in experimental/sid but it would be nice to have support for this in debian-live when it's complete. I am probably not going to look into this any time soon, though. > > So I agree to apply your patch but I hope that you will stick around to > help improve the visual appearance. This bug is totally not about look of grub menus in debian-live. If you are concerned about that file a separate bug about it. > >> These: /install/vmlinuz and /install/initrd.gz strings seem to be hardcoded. >> That explains why I did not see them in binary_syslinux . >> What does happen if you request both x86 and amd64 in your Debian Live? The >> first kernel gets into the /install/vmlinuz and the second kernel gets >> discarded? > > I don't know, I never tried to build images for multiple architectures. > It's not a need for me. It depends on the grub live scripts/templates, obviously. Presumably fixing the installer support is needed to get full UEFI live support but just filing it as an additional bug after this one is resolved may be also fine. It will be easier to fix once live media with *some* UEFI support are available. Also I am fine with debootstrapping my system so that's not complete installation blocker. Unfortunately, most systems that need UEFI support also need secure boot so solving that is probably most urgent UEFI problem. The few I have access to right now do require it. Thanks Michal
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
El 26/08/16 a las 09:52, Raphael Hertzog escribió:
(...)
Can you explain to me why such Installation entries are not available in
binary_syslinux?
Maybe they should be put there also?
Well, the menu entries are there by default:
$ cat share/bootloaders/isolinux/menu.cfg
menu hshift 0
menu width 82
menu title Boot menu
include stdmenu.cfg
include live.cfg
include install.cfg
menu begin advanced
menu title Advanced options
include stdmenu.cfg
label mainmenu
menu label ^Back..
menu exit
include advanced.cfg
menu end
menu clear
$ cat share/bootloaders/isolinux/install.cfg
label install
menu label ^Install
linux /install/vmlinuz
initrd /install/initrd.gz
append vga=788 @APPEND_INSTALL@ --- quiet
label installgui
menu label ^Graphical install
linux /install/gtk/vmlinuz
initrd /install/gtk/initrd.gz
append video=vesa:ywrap,mtrr vga=788 @APPEND_INSTALL@ --- quiet
In fact I have not found any code to drop those entries when you don't
want debian-installer in your live image... so I would rather see the opposite
problem.
So please add those entries in the grub menu.
(...)
I guess that some of those issues are not due to your changes, they
are probably longstanding issues in the generic grub code but still
it would be nice to have this fixed to have a more consistent experience
between grub and syslinux.
Well, there are some possible solutions to this problem:
(...)
3. Commit the patch as is and later on add more patches on the minimal set
needed for prettyfing this.
I'm ok for this but I would still like you to re-add the installer entries
first.
Cheers,
So, here's my current uefi patch + the installation boot entries.
This recycled code from old binary_grub-pc does drop the installation
entries if LB_DEBIAN_INSTALLER is false.
I don't know how to add Debian Installer to a Debian Live so I have not
been able to test it.
So your feedback as user of the Debian Installer is welcome.
https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_10
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
>From 01a9df8ce325c5df9762f0db86128614b4d3476c Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:04:00 +
Subject: [PATCH 01/11] functions/default.sh : Define LB_PRIMARY_BOOTLOADER at
the Set_defaults function which it's the right place where to do it
---
functions/defaults.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/functions/defaults.sh b/functions/defaults.sh
index ddf4b19..334984f 100755
--- a/functions/defaults.sh
+++ b/functions/defaults.sh
@@ -537,6 +537,8 @@ Set_defaults ()
esac
fi
+ LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
+
# Setting checksums
case "${LB_MODE}" in
progress-linux)
@@ -845,9 +847,6 @@ Check_defaults ()
fi
fi
-
- LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
if [ "${LB_PRIMARY_BOOTLOADER}" = "syslinux" ]
then
# syslinux + fat or ntfs, or extlinux + ext[234] or btrfs
--
2.1.4
>From 0624064d44ed811aec5c43fabfd7b928688ed8e1 Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Wed, 20 Jan 2016 00:53:53 +0100
Subject: [PATCH 02/11] Remove repeated LB_PRIMARY_BOOTLOADER definition
---
scripts/build/binary_hdd | 2 --
scripts/build/binary_iso | 2 --
2 files changed, 4 deletions(-)
diff --git a/scripts/build/binary_hdd b/scripts/build/binary_hdd
index 407901a..b45b2a9 100755
--- a/scripts/build/binary_hdd
+++ b/scripts/build/binary_hdd
@@ -67,8 +67,6 @@ do
esac
done
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
case ${LB_PRIMARY_BOOTLOADER} in
syslinux)
case ${LB_BINARY_FILESYSTEM} in
diff --git a/scripts/build/binary_iso b/scripts/build/binary_iso
index d8b1553..67dfc85 100755
--- a/scripts/build/binary_iso
+++ b/scripts/build/binary_iso
@@ -107,8 +107,6 @@ then
XORRISO_OPTIONS="${XORRISO_OPTIONS} -V \"${LB_ISO_VOLUME}\""
fi
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
# Handle xorriso architecture specific options
case "${LB_PRIMARY_BOOTLOADER}" in
grub)
--
2.1.4
>From 9d1a983cc8fe12966d1a2c24a6ee0cfb419b3ce5 Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:07:48 +
Subject: [PATCH 03/11] Added new multi bootloader helper functions * Added:
functions/bootloaders.sh . This file adds bootloader functions that are
heavily used in efi scenarios where a bootloader can act as a first or an
extra bootloader.
Since the introduction of the new switch:
--bootloaders
you can setup it like this:
--bootloaders=syslinux,grub-efi
.
This means that syslinux is the first bootloader and grub-efi is the extra bootloader.
* Added new bootloader functions:
Processing of psutils_1.17.dfsg-3_amd64.changes
psutils_1.17.dfsg-3_amd64.changes uploaded successfully to localhost along with the files: psutils_1.17.dfsg-3.dsc psutils_1.17.dfsg-3.debian.tar.xz psutils-dbgsym_1.17.dfsg-3_amd64.deb psutils_1.17.dfsg-3_amd64.deb Greetings, Your Debian queue daemon (running on host franck.debian.org)
psutils_1.17.dfsg-3_amd64.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Fri, 26 Aug 2016 21:59:27 -0400 Source: psutils Binary: psutils Architecture: source amd64 Version: 1.17.dfsg-3 Distribution: unstable Urgency: medium Maintainer: Debian QA Group Changed-By: Jay Berkenbilt Description: psutils- PostScript document handling utilities Changes: psutils (1.17.dfsg-3) unstable; urgency=medium . * Orphan package Checksums-Sha1: 7d40f6b386ed46e6726141eafca2746703fffec8 1757 psutils_1.17.dfsg-3.dsc 43502ef4944179e138385ba6d35d7799baa6ebd2 22100 psutils_1.17.dfsg-3.debian.tar.xz 9ae6f1625ae84763f8e6e17ce7f74c4adcc13336 80972 psutils-dbgsym_1.17.dfsg-3_amd64.deb 0300d3b8e6b220c0b744b8b36b67ae8582147228 58756 psutils_1.17.dfsg-3_amd64.deb Checksums-Sha256: 9ed30f0434cd295815c82050343a9fe95109283f1c7185578f00ee09a2ddb817 1757 psutils_1.17.dfsg-3.dsc 819794a2f65d4977e7fceb10e5b9b1bc3eb4c6da7e9b69bf97d222abd62d0852 22100 psutils_1.17.dfsg-3.debian.tar.xz dc2012266e8550ed229b1fad3551546d60d8caeb80ba638cb08810a61dabf700 80972 psutils-dbgsym_1.17.dfsg-3_amd64.deb 2ea73205dcf9132bedc7811144ad9860ffd045dc1db8e6ec895863cee5e83498 58756 psutils_1.17.dfsg-3_amd64.deb Files: 47a447113d4590cd1aab37eb9deea95f 1757 text optional psutils_1.17.dfsg-3.dsc 6c3ba584f2483134bf61bd26227e92f6 22100 text optional psutils_1.17.dfsg-3.debian.tar.xz 93562d941bd6a345e09114427a9bfa63 80972 debug extra psutils-dbgsym_1.17.dfsg-3_amd64.deb abd02907178f4ef90476091d3e55 58756 text optional psutils_1.17.dfsg-3_amd64.deb -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJXwPSGAAoJEIp10QmYASx+XigP/i58w+IXGUSh1YsNfszeTFXd 7VSF2xYVGRVi8P7HCiQpd+3YsxpdJSc1HaM0pCnQgvvzDnajAftSRfw6tn4fRlkZ NxqZkIkYMfhyOHIsB3UoJketrR+qoqDirF8IgLw8Y/1m3vlyEHjsdtrUlb7b+mjY pB27YOcZcU6W9JfZxTSuDYDNnrdgAjzOkWpS6ZnmXJD3sPirl20KQwJUTElDe+dF zdMU++jVDS5hXjImfVa60dyqII6lRwD071h3vTfJL1/khDaCXHtzMJqbNP8HJOr1 rYTheqmJebXvXNFVmm8+YjyulvDNL080lbqCHr5nstaevt9n8wLNS9NKs56Hu23p 6VZGDP7SS5QjO5YPTGGUpOGuKm1pxN1RfkXG9DeBs0BX3pZZDPiFWvy4a4/D4LGB Yb7/LiHJI+iU0FoPqM1EXR7lCxNtu6NAgznmiQEH+wSBR12iB7GrXBZu1Pu47XH9 Oqb0Db6rv9ZPacEjy2/Nw9bZrKj5lvX3dqzW+NVVQv4mccDSi0l3kBZ3JC6RprWb OzFs1h7X4DYGaHsnBeY3MyiaSeASVWfht0KRZbbISX2Bndg79FLNyzleYn4TBigm CRYzrR6Vf/KuGfO5wThqjjUaGGBOj4lScI00ASwt+i7l/YWaeLs4a+bx5sdew9YX o9xB0iNlB6pNCi5H9HOJ =PuzS -END PGP SIGNATURE- Thank you for your contribution to Debian.
