El 26/08/16 a las 09:52, Raphael Hertzog escribió:
On Thu, 25 Aug 2016, adrian15 wrote:
That's how the grub-pc menu (BIOS) shows currently in live-build.
Well, it sucks compared to the default visual appearance of
isolinux/syslinux in live-build.
I know, but the purpose of my patch is to add UEFI support. Not to
improve visual appearance of grub2 so that it matches the
isolinux/syslinux one.
- there are no menu entries to start debian-installer even though
I built my image with "--debian-installer live"
There were not such entries in the isolinux menu (BIOS). I already commented
such incongruence when I submitted my loopback patch but Daniel (or irl
maybe?. It was around the time dba quitted the project) agreed to merge my
code.
Compared to binary_grub2 script I have removed the installation
entries because I did not see any of them in binary_syslinux.
Can you explain to me why such Installation entries are not available in
binary_syslinux?
Maybe they should be put there also?
Well, the menu entries are there by default:
$ cat share/bootloaders/isolinux/menu.cfg
menu hshift 0
menu width 82
menu title Boot menu
include stdmenu.cfg
include live.cfg
include install.cfg
menu begin advanced
menu title Advanced options
include stdmenu.cfg
label mainmenu
menu label ^Back..
menu exit
include advanced.cfg
menu end
menu clear
$ cat share/bootloaders/isolinux/install.cfg
label install
menu label ^Install
linux /install/vmlinuz
initrd /install/initrd.gz
append vga=788 @APPEND_INSTALL@ --- quiet
label installgui
menu label ^Graphical install
linux /install/gtk/vmlinuz
initrd /install/gtk/initrd.gz
append video=vesa:ywrap,mtrr vga=788 @APPEND_INSTALL@ --- quiet
In fact I have not found any code to drop those entries when you don't
want debian-installer in your live image... so I would rather see the opposite
problem.
So please add those entries in the grub menu.
These: /install/vmlinuz and /install/initrd.gz strings seem to be
hardcoded. That explains why I did not see them in binary_syslinux .
What does happen if you request both x86 and amd64 in your Debian Live?
The first kernel gets into the /install/vmlinuz and the second kernel
gets discarded?
- the menu entries hardcode "Debian GNU/Linux" as name of the project,
in the default syslinux configuration the entries are agnostic as in
"Live (@FLAVOUR@)".
That @FLAVOUR@ is from Debian's live-build?
Yes:
$ cat share/bootloaders/isolinux/live.cfg.in
label live-@FLAVOUR@
menu label ^Live (@FLAVOUR@)
menu default
linux @LINUX@
initrd @INITRD@
append @APPEND_LIVE@
label live-@FLAVOUR@-failsafe
menu label ^Live (@FLAVOUR@ failsafe)
linux @LINUX@
initrd @INITRD@
append @APPEND_LIVE_FAILSAFE@
I see.
I guess that some of those issues are not due to your changes, they
are probably longstanding issues in the generic grub code but still
it would be nice to have this fixed to have a more consistent experience
between grub and syslinux.
Well, there are some possible solutions to this problem:
1. Try to reuse some code from jnqnfe. He did quite some work on improving
bootloaders design which I don't think got into GIT:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775322 .
His patch set is massive... but yes we should probably review them
and merge what's appropriate.
Yeah, probably.
2. Try to reuse the debian-cd scripts which try to convert syslinux cfg
files into grub ones (including the design).
Here:
https://anonscm.debian.org/cgit/debian-cd/debian-cd.git/tree/tools/boot/jessie/parse_isolinux
Not sure if this is the correct version to use but be warned that Sledge
himself warns us that it's not pretty.
Yeah, I looked that code in the past and I would not want to rely on this even
though
the principle would be nice...
:)
3. Commit the patch as is and later on add more patches on the minimal set
needed for prettyfing this.
I'm ok for this but I would still like you to re-add the installer entries
first.
Although I do not like those hardcoded /install/vmlinuz strings I think
I can do that.
I will apply those patches as an addendum to my current changes. I don't
think it's worth the rebased needed for applying first the changes into
the grub-pc code.
Cheers,
Thank you for your feedback.
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
