Help to build golang-github-boltdb-bolt on riscv64
Hi, There are several packages ftbfs issue on riscv64 due to golang-github-boltdb-bolt: https://udd.debian.org/cgi-bin/ftbfs.cgi?arch=riscv64 e.g: the vuls build log: https://buildd.debian.org/status/fetch.php?pkg=vuls&arch=riscv64&ver=0.6.1-3&stamp=1650290490&raw=0 ``` golang.org/x/crypto/curve25519/internal/field # github.com/boltdb/bolt src/github.com/boltdb/bolt/db.go:101:13: undeclared name maxMapSize for array length src/github.com/boltdb/bolt/db.go:317:12: undefined: maxMapSize src/github.com/boltdb/bolt/db.go:335:10: undefined: maxMapSize src/github.com/boltdb/bolt/db.go:336:8: undefined: maxMapSize src/github.com/boltdb/bolt/db.go:795:2: pos declared but not used src/github.com/boltdb/bolt/bolt_unix.go:62:15: undeclared name maxMapSize for array length src/github.com/boltdb/bolt/bucket.go:135:15: undefined: brokenUnaligned src/github.com/boltdb/bolt/freelist.go:166:2: idx declared but not used src/github.com/boltdb/bolt/freelist.go:169:19: undeclared name maxAllocSize for array length src/github.com/boltdb/bolt/freelist.go:176:14: undeclared name maxAllocSize for array length src/github.com/boltdb/bolt/freelist.go:166:2: too many errors ... ``` The fact is that the github.com/boltdb/bolt is public archive(This is another process to replace it with https://github.com/etcd-io/bbolt) Now I patched for golang-github-boltdb-bolt to build on riscv64 from bbolt but got error: ``` Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot dpkg-buildpackage: info: source package golang-github-boltdb-bolt dpkg-buildpackage: info: source version 1.3.1-7 dpkg-buildpackage: info: source distribution unstable dpkg-buildpackage: info: source changed by Nilesh Patra dpkg-source --before-build . dpkg-buildpackage: info: host architecture riscv64 debian/rules clean dh clean --buildsystem=golang --with=golang dh_auto_clean -O--buildsystem=golang dh_autoreconf_clean -O--buildsystem=golang dh_clean -O--buildsystem=golang debian/rules binary dh binary --buildsystem=golang --with=golang dh_update_autotools_config -O--buildsystem=golang dh_autoreconf -O--buildsystem=golang dh_auto_configure -O--buildsystem=golang dh_auto_build -O--buildsystem=golang found packages bolt (bolt_linux.go) and bbolt (bolt_riscv64.go) in /<>/obj-riscv64-linux-gnu/src/github.com/boltdb/bolt cd obj-riscv64-linux-gnu && go install -trimpath -v -p 4 package .: no Go files in /<>/obj-riscv64-linux-gnu dh_auto_build: error: cd obj-riscv64-linux-gnu && go install -trimpath -v -p 4 returned exit code 1 make: *** [debian/rules:7: binary] Error 25 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 ``` I am unfamiliar with the golang (build)packaging mechanism so please give any help to fix it ;) BR, Bo 0005-add-support-riscv64.patch Description: Binary data
Re: Help to build golang-github-boltdb-bolt on riscv64
Hi, On Wed, May 04, 2022 at 05:15:33PM +0800, Shengjing Zhu wrote: On Wed, May 4, 2022 at 5:09 PM Bo YU wrote: Hi, There are several packages ftbfs issue on riscv64 due to golang-github-boltdb-bolt: https://udd.debian.org/cgi-bin/ftbfs.cgi?arch=riscv64 e.g: the vuls build log: https://buildd.debian.org/status/fetch.php?pkg=vuls&arch=riscv64&ver=0.6.1-3&stamp=1650290490&raw=0 The fact is that the github.com/boltdb/bolt is public archive(This is another process to replace it with https://github.com/etcd-io/bbolt) Please just ask the relevant packages' upstream to switch to bbolt. There's is not value to fix bolt. Fixing bolt just means doing what bbolt has done again. Ok, will do. This is perhaps the most straightforward solution. Thank you. BR, Bo -- Shengjing Zhu
Bug#1010686: golang-github-boltdb-bolt: ftbfs issue on riscv64 arch
Source: golang-github-boltdb-bolt Followup-For: Bug #1010686 X-Debbugs-Cc: debian-ri...@lists.debian.org, debian-go@lists.debian.org These package's upstream had switched to bbolt: * golang-github-blevesearch-bleve * influxdb * golang-github-hashicorp-raft-boltdb So can these packages dependencs switch from golang-github-boltdb-bolt-dev to golang-github-coreos-bbolt? The snapd package's upstream import bolt that was maintained by snap project: https://github.com/snapcore/bolt. It seems to support riscv64 also. These packages is switching to bblot: * nomad * vuls * golang-github-micromdm-scep BR, Bo
Request to join the Debian Go Team
hi, I would like to request to join the "Debian Go Team" and intend to update some go packages to fix some ftbfs issues. Some go packages depend on bolt[0] that does not suppport riscv64 now some of these go packages's upstream has to switch bbolt[1] that supports riscv64. I have already requested on salsa. Salsa username : vimerbf Thank you :) [0]: https://github.com/boltdb/bolt [1]: https://github.com/etcd-io/bbolt -- Best Regards, signature.asc Description: PGP signature
Bug#1012251: ITP: golang-github-coredns-coredns -- CoreDNS is a DNS server/forwarder, written in Go, that chains plugins. Each plugin performs a (DNS) function.
Package: wnpp Severity: wishlist Owner: Bo YU X-Debbugs-Cc: debian-de...@lists.debian.org, debian-go@lists.debian.org * Package name: golang-github-coredns-coredns Version : 1.9.3 Upstream Author : Miek Gieben * URL : https://github.com/coredns/coredns * License : (GPL, LGPL, BSD, MIT/X, etc.) Programming Lang: go Description : CoreDNS is a DNS server/forwarder, written in Go, that chains plugins. Each plugin performs a (DNS) function. CoreDNS is a DNS server/forwarder, written in Go, that chains plugins. Each plugin performs a (DNS) function. CoreDNS is a Cloud Native Computing Foundation graduated project. CoreDNS is a fast and flexible DNS server. The key word here is flexible: with CoreDNS you are able to do what you want with your DNS data by utilizing plugins. If some functionality is not provided out of the box you can add it by writing a plugin. CoreDNS can listen for DNS requests coming in over UDP/TCP (go'old DNS), TLS (RFC 7858), also called DoT, DNS over HTTP/2 - DoH - (RFC 8484) and gRPC (not a standard). Currently CoreDNS is able to: * Serve zone data from a file; both DNSSEC (NSEC only) and DNS are supported (file and auto). * Retrieve zone data from primaries, i.e., act as a secondary server (AXFR only) (secondary). * Sign zone data on-the-fly (dnssec). * Load balancing of responses (loadbalance). * Allow for zone transfers, i.e., act as a primary server (file + transfer). * Automatically load zone files from disk (auto). * Caching of DNS responses (cache). * Use etcd as a backend (replacing SkyDNS) (etcd). * Use k8s (kubernetes) as a backend (kubernetes). * Serve as a proxy to forward queries to some other (recursive) nameserver (forward). * Provide metrics (by using Prometheus) (prometheus). * Provide query (log) and error (errors) logging. * Integrate with cloud providers (route53). * Support the CH class: version.bind and friends (chaos). * Support the RFC 5001 DNS name server identifier (NSID) option (nsid). * Profiling support (pprof). * Rewrite queries (qtype, qclass and qname) (rewrite and template). * Block ANY queries (any). * Provide DNS64 IPv6 Translation (dns64). * And more. Each of the plugins is documented. See coredns.io/plugins for all in-tree plugins, and coredns.io/explugins for all out-of-tree plugins. -- Best Regards, signature.asc Description: PGP signature
Help to confirm the workflow for updating golang-github-zyedidia-pty
Hi, This is my the first time to upload package updated for go team. So I seek for the help to confirm the workflow is right and avoid to cause trouble for the package. Here is the olang-github-zyedidia-pty that I want to upgrade it and fix #1032265[0]. Below is my workflow to update it. ``` 1. git clone golang-github-zyedidia-pty.git git clone g...@salsa.debian.org:go-team/packages/golang-github-zyedidia-pty.git 2. git remote add up https://github.com/zyedidia/pty 3. git fetch up 4. git checkout upstream 5. git merge v1.1.20 Auto-merging run.go CONFLICT (content): Merge conflict in run.go Automatic merge failed; fix conflicts and then commit the result. vimer@dev:~/build/rfs/packages/go/golang-github-zyedidia-pty$ git mergetool -t vimdiff Merging: run.go [no sure why there is a conflict here, but this can be solved] 6. vimer@dev:~/build/rfs/packages/go/golang-github-zyedidia-pty$ git merge --continue [upstream 12fd551] Merge tag 'v1.1.20' into upstream Then git log on upstream: 12fd55163d7d13320b15fc632b594c5ae8d8cff7 (HEAD -> upstream) Merge tag 'v1.1.20' into upstream 104cfcfee6cc32d158331136df47414820d7050c (tag: v1.1.20, up/master) Fix redeclaration 7abcb99d3d173a8c9b43d88d13b071b480046ac8 (tag: v1.1.19) rename go.mod import path cefbbb7900bc935573b4b527011254fe2074c8cf Remove openbsd32 support 51717ce7a47827d6b6057b133282fcf73efe134d Support storing output 0d412c9fbeb14954aa65830dcfdb84005cd0cd96 Provide correct pty/tty file paths on OpenBSD (#148) 2e47437b1ffb0fa7e3d274cca1e468c6272ed349 Add some basic tests (#145) 7. git tag -a upstream/1.1.20 8. git checkout debian/sid 9. git merge upstream/1.1.20 On debian/sid 10 git log b4051ce (HEAD -> debian/sid) Merge tag 'upstream/1.1.20' into debian/sid 12fd551 (tag: upstream/1.1.20, upstream) Merge tag 'v1.1.20' into upstream 017dd82 (tag: debian/1.1.1+git20180126.3036466-4, origin/debian/sid, origin/HEAD) releasing package golang-github-zyedidia-pty version 1.1.1+git20180126.3036466-4 11 dch -v ... (and Update debian/) ``` The wiki [1] and [2] are my mainly reference to finish it. But some places for me was unclear here. 1. When does the tag of the upstream branch have a git commit revision? About golang-github-zyedidia-pty, because I git merged the v1.1.20, So I think only upstream version 1.1.20 is enough. Right? 2. From [1] I can see the connector symbol between the upstream version number and git or svn is '~', but from some go packages on salsa, there is '+' also, are both ok? 3. During freeze, do we upload it to unstable or UNRELEASED in changelog file? or modify of this with the help of sponsor when upload it? PS, I have tested its reverse dependency micro and golang-github-zyedidia-terminal. They are all built ok with new verison *-zyedidia-tty. Thanks. [0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032265 [1]: https://go-team.pages.debian.net/packaging.html#_version_numbers [2]: https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-upstream-branch -- Regards, -- Bo YU signature.asc Description: PGP signature
Re: Help to confirm the workflow for updating golang-github-zyedidia-pty
hi， On Wed, Mar 15, 2023 at 3:33 PM Shengjing Zhu wrote: > > On Wed, Mar 15, 2023 at 3:24 PM Bo YU wrote: > [...] > > 4. git checkout upstream > > 5. git merge v1.1.20 > > 6. git merge --continue > > 7. git tag -a upstream/1.1.20 > > 8. git checkout debian/sid > > 9. git merge upstream/1.1.20 > > > > No. We use gbp. You can just use `gbp import-orig --uscan > --upstream-vcs-tag=v1.1.20` Thanks. I personally tend to use gbp too;) I will try this again. > > > 10 git log > > 11 dch -v ... (and Update debian/) > > ``` > > We just use `gbp dch`. > > Besides, a question for uploaders of golang-github-zyedidia-pty, do we > really need this fork? Can you convince upstream to forward their > patch to https://github.com/creack/pty? Yeah, This is one problem I noticed here also. The downstream of golang-github-zyedidia-pty mainly is micro[0]. So need to convince micro import creack/pty after forward zyedidia/pty patch to creack/pty. I suspect the uploader of micro on Debian who introduced golang-github-zyedidia-pty also. I think this is a long term to convince. I will try here. Thanks. [0]: https://github.com/zyedidia/micro/blob/master/go.mod#L17 > > -- > Shengjing Zhu
Re: Help to confirm the workflow for updating golang-github-zyedidia-pty
hi， On Wed, Mar 15, 2023 at 3:33 PM Shengjing Zhu wrote: > > On Wed, Mar 15, 2023 at 3:24 PM Bo YU wrote: > [...] > > 4. git checkout upstream > > 5. git merge v1.1.20 > > 6. git merge --continue > > 7. git tag -a upstream/1.1.20 > > 8. git checkout debian/sid > > 9. git merge upstream/1.1.20 > > > > No. We use gbp. You can just use `gbp import-orig --uscan > --upstream-vcs-tag=v1.1.20` How to understand this? "“upstream” branch should contain upstream git history" But from my observation, both ways(upstream branch contains upstrream git history and it does not contain upstream git history) was accepted for go team. BR, Bo [0]: https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-upstream-branch > > > 10 git log > > 11 dch -v ... (and Update debian/) > > ``` > > We just use `gbp dch`. > > Besides, a question for uploaders of golang-github-zyedidia-pty, do we > really need this fork? Can you convince upstream to forward their > patch to https://github.com/creack/pty? > > -- > Shengjing Zhu
Re: Help to confirm the workflow for updating golang-github-zyedidia-pty
On Wed, Mar 15, 2023 at 5:59 PM Shengjing Zhu wrote: > > On Wed, Mar 15, 2023 at 5:55 PM Bo YU wrote: > > How to understand this? > > "“upstream” branch should contain upstream git history" > > > > But from my observation, both ways(upstream branch contains upstrream > > git history > > and it does not contain upstream git history) was accepted for go team. > > Which part confuses you? Do you try the `--upstream-vcs-tag` option > and see its behavior? > First I fixed the d/watch[0] and then I try this but failed: ``` vimer@dev:~/build/rfs/packages/go/for_upload/new-pty$ gbp import-orig --uscan --upstream-vcs-tag=v1.1.20 gbp:info: Launching uscan... Newest version of golang-github-zyedidia-pty on remote site is 1.1.20, local version is 1.1.1+git20180126.3036466 => Newer package available from: => https://github.com/zyedidia/pty/archive/refs/tags/v1.1.20.tar.gz Leaving ../golang-github-zyedidia-pty_1.1.20.orig.tar.gz where it isgbp:info: Using uscan downloaded tarball ../golang-github-zyedidia-pty_1.1.20.orig.tar.gz What is the upstream version? [1.1.20] gbp:info: Importing '../golang-github-zyedidia-pty_1.1.20.orig.tar.gz' to branch 'upstream'... gbp:info: Source package is golang-github-zyedidia-pty gbp:info: Upstream version is 1.1.20 gbp:error: Import of ../golang-github-zyedidia-pty_1.1.20.orig.tar.gz failed: Can't find upstream vcs tag at 'v1.1.20' ``` >From man manual[1], the `--upstream-vcs-tag` option should enable upstream branch contains all upstream git history. So the result without he options.is different. [0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-pty/-/blob/debian/sid/debian/watch [1]: https://manpages.debian.org/testing/git-buildpackage/gbp-import-orig.1.en.html#upstream~3 > -- > Shengjing Zhu
Re: Help to confirm the workflow for updating golang-github-zyedidia-pty
On Wed, Mar 15, 2023 at 6:40 PM Shengjing Zhu wrote: > > On Wed, Mar 15, 2023 at 6:34 PM Bo YU wrote: > [...] > > From man manual[1], the `--upstream-vcs-tag` option should enable > > upstream branch contains all upstream git history. > > Yes. You need add a new remote which points to upstream repository, > and fetch tags from it. > > Well, dh-make-golang does that for you when you do the initial > packaging. But there's no much doc about consuming from an existing > repo on salsa :/ Ok, many thanks for clarifying here. Today I learned many from here. Although the wiki[0] is obscure. But it should work. Or others git skill need me to explore. Thanks again! [0]: https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-upstream-branch > > -- > Shengjing Zhu
[RFS] -- golang-github-zyedidia-pty
Hi team, I am looking for sponsorship for the package golang-github-zyedidia-pty[0]. This upload will fix #1032265. Please let me know if there is any issue. Thanks. [0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-pty [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032265 -- Regards, -- Bo YU signature.asc Description: PGP signature
Re: Help to confirm the workflow for updating golang-github-zyedidia-pty
hi, On Wed, Mar 15, 2023 at 3:33 PM Shengjing Zhu wrote: > > On Wed, Mar 15, 2023 at 3:24 PM Bo YU wrote: > > ``` > > We just use `gbp dch`. > > Besides, a question for uploaders of golang-github-zyedidia-pty, do we > really need this fork? Can you convince upstream to forward their > patch to https://github.com/creack/pty? Thanks for quick response from upstream. This happened: https://github.com/zyedidia/micro/issues/2775 And zyedidia/terminal switchs to creack/pty also. And I am failing to find other packages depending on the package. So can we remove this package? BR, Bo > > -- > Shengjing Zhu
Re: [RFS] -- golang-github-zyedidia-pty
Hi Nilesh! On Tue, Jun 13, 2023 at 2:44 AM Nilesh Patra wrote: > > > > > On 03/24/2023 9:20 AM IST Nilesh Patra wrote: > > > On 03/15/2023 6:37 PM IST Bo YU wrote: > > > > > > > > > Hi team, > > > > > > I am looking for sponsorship for the package > > > golang-github-zyedidia-pty[0]. > > > > > > This upload will fix #1032265. Please let me know if there is any issue. > > > > Currently there is an ongoing (hard-)freeze[2] and the uploading new > > upstream releases > > is no appropriate at this point (on checking the diff, it is not super nice > > at this > > time). > > > > Please ping on the thread after we release bookworm. I/someone else will > > sponsor. Many thanks for sponsoring this. But I found the situation is complicated, hope I can explain as much as possible.:) Micro upstream has been switched to creack/pty[0] from zyedidia/pty, which is the package that needs to be updated here. The same switch happens on zyedidia/terminal also[1]. So I think the package(golang-github-zyedidia-pty) can be removed once micro and golang-github-zyedidia-terminals' dependences switch to golang-github-creack-pty. More background is here[2]. But I have not tested it given micro has not upgrade the newest version with upstream. > > Freeze is over now, I was planning to upload but it seems that it has 2 > reverse-deps, one of which (golang-github-zyedidia-terminal-dev) is also at > an old version. > > Did you check with ratt / any other tooling check that the update is not > breaking reverse-dependencies? Yeah, I can confirmed the micro and golang-github-zyedidia-terminal-dev can be built with the version from golang-github-zyedidia-pty. What are your options here? Sorry for late reply here. BR, Bo [0]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4 [1]: https://github.com/zyedidia/terminal/blob/master/go.sum#LL1 [2]: https://lists.debian.org/debian-go/2023/03/msg00045.html > > > > [0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-pty > > > [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032265 > > [2]: https://release.debian.org/bookworm/freeze_policy.html#appropriate > > Best, > Nilesh
Re: [RFS] -- golang-github-zyedidia-pty
Hi! On Tue, Jun 13, 2023 at 1:03 PM Nilesh Patra wrote: > > > > On 13 June 2023 9:05:26 am IST, Bo YU wrote: > >On Tue, Jun 13, 2023 at 2:44 AM Nilesh Patra wrote: > >Many thanks for sponsoring this. > >But I found the situation is complicated, hope I can explain as much > >as possible.:) > > > >Micro upstream has been switched to creack/pty[0] from zyedidia/pty, > >which is the package that needs to be updated here. > > go.mod is the file you should usually be looking at to check dependencies. > > I confirm the analysis. terminal depends on creak-pty and micro > (build-)depends on terminal. > > >So I think the package(golang-github-zyedidia-pty) can be removed once > >micro and golang-github-zyedidia-terminals' dependences switch to > >golang-github-creack-pty. > > Yes. Would you like to package creak-pty? If this is correct, we have packaged the creack-pty? https://tracker.debian.org/pkg/golang-github-creack-pty > > >But I have not > >tested it given micro has not upgrade the newest version with > >upstream. > > Micro is at latest version, it was me who upgraded it. Ok, got it. > > >Yeah, I can confirmed the micro and > >golang-github-zyedidia-terminal-dev can be built with the version from > >golang-github-zyedidia-pty. > >What are your options here? > > I don't think it makes sense to do more work on zyedidia-pty given that it > would be removed at some point. > This is my point here also. So the next thing is I should update golang-github-zyedidia-terminal. Once done, we can remove golang-github-zyedidia-pty. BR, Bo > >[0]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4 > >[1]: https://github.com/zyedidia/terminal/blob/master/go.sum#LL1 > >[2]: https://lists.debian.org/debian-go/2023/03/msg00045.html
Re: [RFS] -- golang-github-zyedidia-pty
hi! On Wed, Jun 14, 2023 at 3:07 AM Nilesh Patra wrote: > > On 06/13/2023 1:08 PM IST Bo YU wrote: > > On Tue, Jun 13, 2023 at 1:03 PM Nilesh Patra wrote: > > > Yes. Would you like to package creak-pty? > > If this is correct, we have packaged the creack-pty? > > https://tracker.debian.org/pkg/golang-github-creack-pty > > Oh, right. I missed seeing this in a hurry. Thanks for pointing this out! > > > > I don't think it makes sense to do more work on zyedidia-pty given that > > > it would be removed at some point. > > > > > This is my point here also. So the next thing is I should update > > golang-github-zyedidia-terminal. Once done, > > we can remove golang-github-zyedidia-pty. > > Sure! Do ping here once you update zyedidia-terminal. Update: It is time to update zyedidia-terminal here. But something else need to be updated also I think. The reason why to update these go packages is due to #1032265[0]. Now micro has switched to creack/pty[1] micro build dependence on golang-github-zyedidia-terminal-dev and golang-github-zyedidia-pty-dev. golang-github-zyedidia-terminal-dev dependence on golang-github-zyedidia-pty-dev. Now the zyedidia/terminal and mciro upstream has switched to creack/pty[2] [3]. So we can update golang-github-zyedidia-terminal-dev[4] and micro[5] and remove golang-github-zyedidia-pty. But these update do not fix my final goal: to fix FTBFS on riscv64 for micro due to the issue[6]. Now the micro has new upstream version and i think this is a chance to fix the FTBFS issue. I can confirm the micro(2.0.12) can be built with golang-github-zyedidia-terminal which has switch to creack-pty. Another thing is that need to upgrade golang-github-zyedidia-tcell also. In other words, in order to fix FTBFS on riscv64 for micro, I have to update two go -dev packages and then update micro also. Once I get the ack, I will start the work. What are your options here? :) BR, Bo [0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032265 [1]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4 [2]: https://github.com/zyedidia/terminal/blob/master/go.mod [3]: https://github.com/zyedidia/micro/blob/master/go.sum#L6 [4]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-terminal/-/blob/debian/sid/debian/control#L12 [5]: https://salsa.debian.org/go-team/packages/micro/-/blob/debian/sid/debian/control#L25 [6]: https://github.com/zyedidia/micro/issues/2854 > > > > >[0]: https://github.com/zyedidia/micro/blob/master/go.sum#LL6C4-L6C4 > > > >[1]: https://github.com/zyedidia/terminal/blob/master/go.sum#LL1 > > > >[2]: https://lists.debian.org/debian-go/2023/03/msg00045.html > > Best, > Nilesh
Re: [RFS] -- golang-github-zyedidia-pty
hi! On Fri, Sep 22, 2023 at 9:03 PM Nilesh Patra wrote: > > On Fri, Sep 22, 2023 at 05:35:50PM +0800, Bo YU wrote: > > It is time to update zyedidia-terminal here. But something else need > > to be updated also I think. > > > > The reason why to update these go packages is due to #1032265[0]. > > Now micro has switched to creack/pty[1] > > > > micro build dependence on golang-github-zyedidia-terminal-dev and > > golang-github-zyedidia-pty-dev. > > golang-github-zyedidia-terminal-dev dependence on > > golang-github-zyedidia-pty-dev. > > Now the zyedidia/terminal and mciro upstream has switched to creack/pty[2] > > [3]. > > > > So we can update golang-github-zyedidia-terminal-dev[4] and micro[5] > > and remove golang-github-zyedidia-pty. > > > > But these update do not fix my final goal: to fix FTBFS on riscv64 for > > micro due to the issue[6]. Now the micro > > has new upstream version and i think this is a chance to fix the FTBFS > > issue. > > > > I can confirm the micro(2.0.12) can be built with > > golang-github-zyedidia-terminal which has switch to creack-pty. > > Another thing is that need to upgrade golang-github-zyedidia-tcell also. > > > > In other words, in order to fix FTBFS on riscv64 for micro, I have to > > update two go -dev packages and then > > update micro also. Once I get the ack, I will start the work. > > > > What are your options here? :) > > Sounds good to me, please proceed ahead! 1. I have updated golang-github-zyedidia-tcell first[0] Because the upgrading is not harmful, micro 2.0.11 and 2.0.12 both can be built with it. Please notice I have to change d/watch to fetch the newest version for zyedidia-tcell[1] [0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-tcell [1]: https://github.com/zyedidia/micro/blob/master/go.mod#L17 2. It was stuck to upgrade micro or golang-github-zyedidia-terminal-dev. for example: now micro(2.0.11-3) and golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2). micro(2.0.12-1) will not be built with golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2) or micro(2.0.11-3) will bot built with golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) but micro(2.0.12-1) can be built with golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) with updated golang-github-zyedidia-tcell. I think I should update golang-github-zyedidia-terminal-dev and then upload micro in a short time. Can this be done? BR, Bo > > > Best, > Nilesh
Re: [RFS] -- golang-github-zyedidia-pty
Hi, On Mon, Sep 25, 2023 at 5:58 PM Nilesh Patra wrote: > > > > On 25 September 2023 2:17:05 pm IST, Bo YU wrote: > >2. It was stuck to upgrade micro or golang-github-zyedidia-terminal-dev. > >for example: now micro(2.0.11-3) and > >golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2). > >micro(2.0.12-1) will not be built with > >golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2) > >or micro(2.0.11-3) will bot built with > >golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) > >but micro(2.0.12-1) can be built with > >golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) > >with updated golang-github-zyedidia-tcell. > > > >I think I should update golang-github-zyedidia-terminal-dev and then > >upload micro in a short time. > > > >Can this be done? > > I'm not sure if I understand what you're trying to say here. > > That said if you want micro to build against the updates versions of its > dependencies, why not simply add a versioned build-depends on them? Ah, sorry. I mean here: if update golang-github-zyedidia-terminal-dev from 0.0~git20180726.533c623-2 to 0.0~git20230315.4b3bcf6-1, this will break micro(2.0.11-3); but if at the same time update micro from 2.0.11-3 to 2.0.12-1, the micro is built fine. In other words, both need to be upgraded together. BR, Bo > > Best, > Nilesh >
Re: [RFS] -- golang-github-zyedidia-terminal/golang-github-zyedidia-tcell/ and micro
On Mon, Sep 25, 2023 at 7:42 PM Nilesh Patra wrote: > > > > On 25 September 2023 3:38:01 pm IST, Bo YU wrote: > >Hi, > > > >On Mon, Sep 25, 2023 at 5:58 PM Nilesh Patra wrote: > >> > >> > >> > >> On 25 September 2023 2:17:05 pm IST, Bo YU wrote: > >> >2. It was stuck to upgrade micro or golang-github-zyedidia-terminal-dev. > >> >for example: now micro(2.0.11-3) and > >> >golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2). > >> >micro(2.0.12-1) will not be built with > >> >golang-github-zyedidia-terminal-dev(0.0~git20180726.533c623-2) > >> >or micro(2.0.11-3) will bot built with > >> >golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) > >> >but micro(2.0.12-1) can be built with > >> >golang-github-zyedidia-terminal-dev(0.0~git20230315.4b3bcf6) > >> >with updated golang-github-zyedidia-tcell. > >> > > >> >I think I should update golang-github-zyedidia-terminal-dev and then > >> >upload micro in a short time. > >> > > >> >Can this be done? > >> > >> I'm not sure if I understand what you're trying to say here. > >> > >> That said if you want micro to build against the updates versions of its > >> dependencies, why not simply add a versioned build-depends on them? > > > >Ah, sorry. I mean here: > >if update golang-github-zyedidia-terminal-dev from > >0.0~git20180726.533c623-2 to 0.0~git20230315.4b3bcf6-1, > >this will break micro(2.0.11-3); but if at the same time update micro > >from 2.0.11-3 to 2.0.12-1, the micro is built fine. > >In other words, both need to be upgraded together. > > Yes, fine for me. You need to add a versioned B-D on zyedidia-terminal in the > d/control file of micro to ensure micro builds against a later version, as I > said above too. Thanks. Done. Now I am seeking help to upload them: golang-github-zyedidia-terminal [0] golang-github-zyedidia-tcell [1] micro [2] Please let me know any issues. [0]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-terminal [1]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-tcell/ [2]: https://salsa.debian.org/go-team/packages/micro/-/tree/debian/sid BR, Bo > > Thanks, > Nilesh
Re: [RFS] -- golang-github-zyedidia-terminal/golang-github-zyedidia-tcell/ and micro
On Wed, Sep 27, 2023 at 2:58 AM Nilesh Patra wrote: > > On Tue, Sep 26, 2023 at 02:42:44PM +0800, Bo YU wrote: > > Now I am seeking help to upload them: > > golang-github-zyedidia-terminal [0] > > golang-github-zyedidia-tcell [1] > > micro [2] > > I am a little confused. The go.mod of micro says: > > github.com/zyedidia/tcell/v2 v2.0.10-0.20230831153116-061c5b2c7260 // > indirect > > However on github, I see 2.0.9 as the latest release, and you modified > d/watch for a git tag. > Can you please check with upstream as to what maybe the correct version? Thanks. I suppose the upstream forget to push new version to zyedidia/tcell? See: https://github.com/zyedidia/micro/issues/2854#issuecomment-1736471075 > > Also, since the commit comes after the release commit of version 2.0.9, you > should use the > "+" qualifier in the release name, i.e. 2.0.9+git20230831.061c5b2-1 > indicating it should > sort higher than 2.0.9. Okay. Here I follow the changelog entry in d/changelog: golang-github-zyedidia-tcell (0.0~git20200210.f7f063a-1) unstable; urgency=medium But I think I should change as your advice. Let's wait for upstream response. BR, Bo > > > [0]: > > https://salsa.debian.org/go-team/packages/golang-github-zyedidia-terminal > > [1]: https://salsa.debian.org/go-team/packages/golang-github-zyedidia-tcell/ > > [2]: https://salsa.debian.org/go-team/packages/micro/-/tree/debian/sid > > Best, > Nilesh
Re: [RFS] -- golang-github-zyedidia-terminal/golang-github-zyedidia-tcell/ and micro
Hi! On Mon, Oct 23, 2023 at 6:10 AM Nilesh Patra wrote: > > > > On 27 September 2023 9:45:05 am IST, Bo YU wrote: > >On Wed, Sep 27, 2023 at 2:58 AM Nilesh Patra wrote: > >> > >> On Tue, Sep 26, 2023 at 02:42:44PM +0800, Bo YU wrote: > >> > Now I am seeking help to upload them: > >> > golang-github-zyedidia-terminal [0] > >> > golang-github-zyedidia-tcell [1] > >> > micro [2] > >> > >> I am a little confused. The go.mod of micro says: > >> > >> github.com/zyedidia/tcell/v2 v2.0.10-0.20230831153116-061c5b2c7260 > >> // indirect > >> > >> However on github, I see 2.0.9 as the latest release, and you modified > >> d/watch for a git tag. > >> Can you please check with upstream as to what maybe the correct version? > > > >Thanks. I suppose the upstream forget to push new version to zyedidia/tcell? > >See: https://github.com/zyedidia/micro/issues/2854#issuecomment-1736471075 > >> > >> Also, since the commit comes after the release commit of version 2.0.9, > >> you should use the > >> "+" qualifier in the release name, i.e. 2.0.9+git20230831.061c5b2-1 > >> indicating it should > >> sort higher than 2.0.9. > > > >Okay. Here I follow the changelog entry in d/changelog: > > > >golang-github-zyedidia-tcell (0.0~git20200210.f7f063a-1) unstable; > >urgency=medium > > > >But I think I should change as your advice. > > > >Let's wait for upstream response. > > Hey, seems like upstream fixed the problem. > > Could you please update this package and micro? Yeah. I have updated golang-github-zyedidia-tcell and micro. If everything is ok, maybe we first upload golang-github-zyedidia-terminal then upload micro given the micro has a versioned golang-github-zyedidia-terminal on B-D. Thanks. Bo > > Let's close this - it's pending for a while! :) > > >> > >> > [0]: > >> > https://salsa.debian.org/go-team/packages/golang-github-zyedidia-terminal > >> > [1]: > >> > https://salsa.debian.org/go-team/packages/golang-github-zyedidia-tcell/ > >> > [2]: https://salsa.debian.org/go-team/packages/micro/-/tree/debian/sid > > Thanks, > Nilesh
Re: [RFS] -- golang-github-zyedidia-terminal/golang-github-zyedidia-tcell/ and micro
Hi! On Wed, Oct 25, 2023 at 10:29 PM Nilesh Patra wrote: > > On Wed, Oct 25, 2023 at 12:16:46PM +0800, Bo YU wrote: > > Yeah. I have updated golang-github-zyedidia-tcell and micro. > > If everything is ok, maybe we first upload golang-github-zyedidia-terminal > > then > > upload micro given the micro has a versioned golang-github-zyedidia-terminal > > on B-D. > > Uploaded all with some changes from my end -- thanks for your > contribution! Thanks. This is the first time for micro built on riscv64: https://buildd.debian.org/status/logs.php?pkg=micro&arch=riscv64 and this is my initial thoughts.:) In additions to I should file a RM bug for golang-github-zyedidia-pty. Let me do it. Thanks again! Bo > > Best, > Nilesh
RPS: golang-github-go-jose-go-jose.v3
Hi, I have one golang package[0] that needs to be uploaded, so please review it and let me know any issues. BTW, how to enable the CI job with a default debian/gitlab-ci.yml file? I can not find the setting on the salsa page. [0]: https://salsa.debian.org/go-team/golang-github-go-jose-go-jose.v3 BR, Bo
Re: RPS: golang-github-go-jose-go-jose.v3
Hi, Thanks for you quick reply! On Sun, Dec 10, 2023 at 10:24 PM Nilesh Patra wrote: > > > > On 10 December 2023 7:31:19 pm IST, Bo YU wrote: > >Hi, > > > >I have one golang package[0] that needs to be uploaded, so please > >review it and let me know any issues. > > Go team packages are located under go-team/packages/ and not under > go-team/ > > Please move it there. Ah, sorry, I just pushed it to go-team/packages/golang-github-go-jose-go-jose.v3 https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose.v3 (I think I do not have any permission to transfer the project to anywhere, so uplaod done, I will request to delete go-team/golang-github-go-jose-go-jose.v3 ) > > >BTW, how to enable the CI job with a default debian/gitlab-ci.yml > >file? I can not find the setting on the salsa page. > > I guess you can't without having maintainer permissions on the repo. Okay. I hope the CI job done before uploading each time... Even on the new location, it does not work to find the setting option. BR, Bo > > >[0]: https://salsa.debian.org/go-team/golang-github-go-jose-go-jose.v3 > > Thanks > Nilesh
Re: RPS: golang-github-go-jose-go-jose.v3
hi! On Sun, Dec 10, 2023 at 11:25 PM Shengjing Zhu wrote: > > On Sun, Dec 10, 2023 at 10:01 PM Bo YU wrote: > > > > Hi, > > > > I have one golang package[0] that needs to be uploaded, so please > > review it and let me know any issues. > > > > BTW, how to enable the CI job with a default debian/gitlab-ci.yml > > file? I can not find the setting on the salsa page. > > > > [0]: https://salsa.debian.org/go-team/golang-github-go-jose-go-jose.v3 > > > > The package name should be golang-github-go-jose-go-jose. Please be > aware that the .v1 and .v2 pattern are gopkg.in specific, since their > import path has .v1 and .v2 (dot in path). > > And please create the salsa repo with command `dh-make-golang > create-salsa-project`, as it will do the right settings for you. All right. It seems that Ben has did this: https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose @Ben, Could you finish the upload again or need me to refresh your work and to upload the package to sid? please notice here also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056342 BR, Bo > > -- > Shengjing Zhu
Re: RPS: golang-github-go-jose-go-jose.v3
Hi! On Tue, Dec 12, 2023 at 1:40 AM Ben Westover wrote: > > Hello, > > On 12/11/23 02:52, Bo YU wrote: > > @Ben, Could you finish the upload again or need me to refresh your > > work and to upload the package to sid? > > I'm not a Debian Developer, so I don't have upload permissions. Feel > free to refresh the packaging and upload it. You can remove my name from > the package if you want as I don't plan to work on it at all. Thanks for your contribution to Debian. I did not mention that I am not a Debian Developer until now. So this is my the first RFS for golang-team. Okay, I will refresh it again but I want to keep your name as one of Uploader as you have finished the most of packaging. Thanks again. Bo > > Thanks, > -- > Ben Westover
Re: RFS: golang-github-go-jose-go-jose.v3
hi, On Tue, Dec 12, 2023 at 11:51 AM Nilesh Patra wrote: > > > > On 12 December 2023 4:11:22 am IST, Bo YU wrote: > >Okay, I will refresh it again but I want to keep your name as one of > >Uploader as you have finished the most of packaging. > > You can mention them in d/ch and d/copyright for this. > > Mentioning someone in uploaders means that they are in some sense responsible > for the package maintenance. Since Ben isn't interested to maintain it, you > should not keep their name there as it adds up for extra work for Ben. Okay, make sense for me. I have uploaded the new version of go-jose v3 to salsa, please help to review it: https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose And please remove my extra useless repos: 0: https://salsa.debian.org/go-team/golang-github-go-jose-go-jose.v3 1: https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose.v3 Sorry for the trouble. BR, Bo
Re: RFS: golang-github-go-jose-go-jose.v3
hi! On Sun, Dec 17, 2023 at 6:39 PM Nilesh Patra wrote: > > On Wed, Dec 13, 2023 at 07:20:11AM +0800, Bo YU wrote: > > Okay, make sense for me. > > I have uploaded the new version of go-jose v3 to salsa, please help to > > review it: > > > > https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose > > The copyright looks incorrect. I do not find the name of "Cedric Staub" > anywhere. Rather, in each file I see: "Copyright 2014 Square Inc." > Okay. I found the name of "Cedric Staub" from committers who own the most git commits.:) > There are also files where there are more copyright holders > > jwt/jwt_test.go:2: * Copyright 2016 Zbigniew Mandziejewicz > jwt/jwt_test.go:3: * Copyright 2016 Square, Inc > > Please fixup your copyright to mention correct copyright holders > and mention people other than square separately in separate entries in > d/copyright I have updated the debian/copyright following your suggestions: https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose > > > And please remove my extra useless repos: > > > > 0: https://salsa.debian.org/go-team/golang-github-go-jose-go-jose.v3 > > 1: > > https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose.v3 > > > > Sorry for the trouble. > > Pruned. Thanks. BR, Bo > > Best, > Nilesh
Help to update golang-github-go-jose-go-jose
Hi team！ Sorry to disturb here again. Now I am trying to update golang-github-go-jose-go-jose with a new upstream release due to one CVE issue, see: #1065814. Everything is okay, but when I look back it again, I realize I had made a mistake for it: I forgot to merge upstream history when `gbp import-orig`. I think I should use `gbp import-orig --pristine-tar --uscan` instead of `gbp import-orig --pristine-tar --upstream-vcs-tag= --uscan`. So how I can fix the upstream branch now? Or just like that. And in fact, could you help me to understand why the upstream branch will contain upstream history? TIA. Bo https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065814
Re: Help to update golang-github-go-jose-go-jose
On Tue, Mar 12, 2024 at 3:20 PM Bo YU wrote: > > Hi team！ > > Sorry to disturb here again. > > Now I am trying to update golang-github-go-jose-go-jose with a new > upstream release due to one CVE issue, see: #1065814. salsa repo is here: https://salsa.debian.org/go-team/packages/golang-github-go-jose-go-jose sorry again. Bo > > Everything is okay, but when I look back it again, I realize I had > made a mistake for it: I forgot to merge upstream history when `gbp > import-orig`. > > I think I should use `gbp import-orig --pristine-tar --uscan` instead > of `gbp import-orig --pristine-tar --upstream-vcs-tag= > --uscan`. > > So how I can fix the upstream branch now? Or just like that. And in > fact, could you help me to understand why the upstream branch will > contain upstream history? > > TIA. > Bo > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065814
