Re: [darktable-dev] Re: Unusual stability problem
thanks for providing the fix! seems correct to me, since the loop is y <= max and y+1 is accessed inside. i pushed this PR to master. let's see if it fixes it for everyone. cheers, jo On Mon, Jan 30, 2017 at 5:38 PM, Dan Torop wrote: > I should also mention that the Bayer downscale code for the previews is, as > it stands, something of a stopgap. It produces fewer edge artifacts > (confetti) than the prior code, but still isn't ideal. There does seem to be > a way to make it better, and that work could translate back to the X-Trans > version as well, but I'm waiting for a moment for concentration on this... > > Dan > > > Dan Torop writes: > >> Many apologies. This was carelessness on my part. PR 1431 should fix this. >> >> The bug was in changes I made to the Bayer downscaling code. For certain raw >> image dimensions, the downscaling to produce the preview would look at a >> pixel past the edge of the image. >> >> Thank you very much for reporting & to Ulrich for the bisect work to narrow >> this down. >> >> Dan >> >> >> >> Ulrich Pegelow writes: >> >>> I checked further and it's obviously not (only) related to my system >>> upgrade, 'cause if I go back a few commits darktable runs stable. >>> >>> git bisect helped me to find the offending part: >>> >>> 07dc9664df548c7f775ade36cbdb7875a4aa4c9f is the first bad commit >>> commit 07dc9664df548c7f775ade36cbdb7875a4aa4c9f >>> Author: Dan Torop >>> Date: Mon Jan 23 21:27:48 2017 -0500 >>> >>> imageop_math: take advantage of CFA pattern on downscale >>> >>> This increase speed to be faster than prior code w/out blurring. >>> >>> :04 04 88e97f48a9f6671c9e328008c1ad63b0ec0a4ab0 >>> 153545841ee127841b78ee5b01f8334098ac4fcf M src >>> >>> My backtraces indicate that the crash always is linked to >>> >>> dt_iop_clip_and_zoom_mosaic_half_size_plain._omp_fn.1 () at >>> /home/pegelow/darktable/src/develop/imageop_math.c:230 >>> >>> which somehow makes it plausible that the a.m. commit might be involved. >>> >>> Ulrich >>> >>> Am 29.01.2017 um 08:03 schrieb Roman Lebedev: On Sun, Jan 29, 2017 at 1:09 AM, Ulrich Pegelow wrote: > Same here with current master on specific images with and without OpenCL. > I > have several images from one session, all have the same raw size. One > image > with an uncommon crop crashes whenever I open it in the darkroom. Looks like the crash is in gtk / x? > Ulrich Roman. >>> >>> ___ >>> darktable developer mailing list >>> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org >> >> ___ >> darktable developer mailing list >> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] darktable 2.2.2 released
we're proud to announce the second bugfix release for the 2.2 series of darktable, 2.2.2! as always, please don't use the autogenerated tarball provided by github, but only our tar.xz. the checksum is: $ sha256sum darktable-2.2.2.tar.xz 766d7d734e7bd5a33f6a6932a43b15cc88435c64ad9a0b20410ba5b4706941c2 darktable-2.2.2.tar.xz $ sha256sum darktable-2.2.2.dmg 52fd0e9a8bb74c82abdc9a88d4c369ef181ef7fe2b946723c5706d7278ff2dfb darktable-2.2.2.dmg Important note: to make sure that darktable can keep on supporting the raw file format for your camera, please help us by visiting https://raw.pixls.us/ and making sure that we have the full raw sample set for your camera under CC0 license! and the changelog as compared to 2.2.1 can be found below. ## New features: - color look up table module: include preset for helmholtz/kohlrausch monochrome - Lens module: re-enable tiling - Darkroom: fix some artefacts in the preview image (not the main view!) - DNG decoder: support reading one more white balance encoding method - Mac: display an error when too old OS version is detected - Some documentation and tooltips updates ## Bugfixes: - Main view no longer grabs focus when mouse enters it. Prevents accidental catastrophic image rating loss. - OSX: fix bauhaus slider popup keyboard input - Don't write all XMP when detaching tag - OSX: don't do PPD autodetection, gtk did their thing again. - Don't show db lock popup when dbus is used to start darktable - Actually delete duplicate's XMP when deleting duplicated image - Ignore UTF-8 BOM in GPX files - Fix import of LR custom tone-curve - Overwrite Xmp rating from raw when exporting - Some memory leak fixes - Lua: sync XMPs after some tag manipulations - Explicitly link against math library ## Base Support: - Canon PowerShot SX40 HS (dng) - Fujifilm X-E2S - Leica D-LUX (Typ 109) (4:3, 3:2, 16:9, 1:1) - Leica X2 (dng) - Nikon LS-5000 (dng) - Nokia Lumia 1020 (dng) - Panasonic DMC-GF6 (16:9, 3:2, 1:1) - Pentax K-5 (dng) - Pentax K-r (dng) - Pentax K10D (dng) - Sony ILCE-6500 ## Noise Profiles: - Fujifilm X-M1 - Leica X2 - Nikon Coolpix A - Panasonic DMC-G8 - Panasonic DMC-G80 - Panasonic DMC-G81 - Panasonic DMC-G85 signature.asc Description: This is a digitally signed message part.
Re: [darktable-dev] Re: Unusual stability problem
Great, this seems to have fixed the issue for me! Ulrich Am 30.01.2017 um 09:45 schrieb johannes hanika: thanks for providing the fix! seems correct to me, since the loop is y <= max and y+1 is accessed inside. i pushed this PR to master. let's see if it fixes it for everyone. cheers, jo ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
AW: [darktable-dev] Re: Unusual stability problem
Hi I am just an ordinary user not familiar with the coding details. Version 2.2.2 (Ubuntu 16.04) which I installed today closes down or freezes in approx. 80% of the cases when I open a picture in darkroom. Also my camera is not found for the lens correction (Panasonic GX80) and the program does also not identify aGX80 noise profile which was mentioned in the change list for version 2.2.2. Stefan Von: Ulrich Pegelow Gesendet: Montag, 30. Januar 2017 18:31 An: johannes hanika; Dan Torop Cc: darktable Betreff: Re: [darktable-dev] Re: Unusual stability problem Great, this seems to have fixed the issue for me! Ulrich Am 30.01.2017 um 09:45 schrieb johannes hanika: > thanks for providing the fix! seems correct to me, since the loop is y > <= max and y+1 is accessed inside. i pushed this PR to master. let's > see if it fixes it for everyone. > > cheers, > jo > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Re: Unusual stability problem
My problem appears to be fixed now ... thanks for the quick work David On 01/30/2017 09:31 AM, Ulrich Pegelow wrote: Great, this seems to have fixed the issue for me! Ulrich Am 30.01.2017 um 09:45 schrieb johannes hanika: thanks for providing the fix! seems correct to me, since the loop is y <= max and y+1 is accessed inside. i pushed this PR to master. let's see if it fixes it for everyone. cheers, jo ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: AW: [darktable-dev] Re: Unusual stability problem
Am Montag, 30. Januar 2017, 19:01:45 CET schrieb PD Dr. Stefan Schmidt: > Hi Hi. > I am just an ordinary user not familiar with the coding details. Version > 2.2.2 (Ubuntu 16.04) which I installed today closes down or freezes in > approx. 80% of the cases when I open a picture in darkroom. Also my camera > is not found for the lens correction (Panasonic GX80) and the program does > also not identify aGX80 noise profile which was mentioned in the change > list for version 2.2.2. The release notes mention the G80 which seems to be something else than the GX80 (hooray for model names that are easy to decipher). There also isn't any sample raw file on http://raw.pixls.us/. Please consider uploading one (ore more if required). About the freezes, does darktable consume CPU time while frozen (have a look at your system monitor, top, htop, …) or is it just sitting there? Do you have OpenCL enabled? > Stefan Tobias [...] signature.asc Description: This is a digitally signed message part.
Re: [darktable-dev] Re: Unusual stability problem
Thank you for the report & the very helpful sample file. I'm mortified, though, that the bug made its way into 2.2.2. Dan David Vincent-Jones writes: > My problem appears to be fixed now ... thanks for the quick work > > David > > On 01/30/2017 09:31 AM, Ulrich Pegelow wrote: > > Great, this seems to have fixed the issue for me! > > Ulrich > > Am 30.01.2017 um 09:45 schrieb johannes hanika: > > thanks for providing the fix! seems correct to me, since the loop is y > <= max and y+1 is accessed inside. i pushed this PR to master. let's > see if it fixes it for everyone. > > cheers, > jo > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > > ___ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
