thanks for providing the fix! seems correct to me, since the loop is y <= max and y+1 is accessed inside. i pushed this PR to master. let's see if it fixes it for everyone.
cheers, jo On Mon, Jan 30, 2017 at 5:38 PM, Dan Torop <d...@pnym.net> wrote: > I should also mention that the Bayer downscale code for the previews is, as > it stands, something of a stopgap. It produces fewer edge artifacts > (confetti) than the prior code, but still isn't ideal. There does seem to be > a way to make it better, and that work could translate back to the X-Trans > version as well, but I'm waiting for a moment for concentration on this... > > Dan > > > Dan Torop <d...@pnym.net> writes: > >> Many apologies. This was carelessness on my part. PR 1431 should fix this. >> >> The bug was in changes I made to the Bayer downscaling code. For certain raw >> image dimensions, the downscaling to produce the preview would look at a >> pixel past the edge of the image. >> >> Thank you very much for reporting & to Ulrich for the bisect work to narrow >> this down. >> >> Dan >> >> >> >> Ulrich Pegelow <ulrich.pege...@tongareva.de> writes: >> >>> I checked further and it's obviously not (only) related to my system >>> upgrade, 'cause if I go back a few commits darktable runs stable. >>> >>> git bisect helped me to find the offending part: >>> >>> 07dc9664df548c7f775ade36cbdb7875a4aa4c9f is the first bad commit >>> commit 07dc9664df548c7f775ade36cbdb7875a4aa4c9f >>> Author: Dan Torop <d...@pnym.net> >>> Date: Mon Jan 23 21:27:48 2017 -0500 >>> >>> imageop_math: take advantage of CFA pattern on downscale >>> >>> This increase speed to be faster than prior code w/out blurring. >>> >>> :040000 040000 88e97f48a9f6671c9e328008c1ad63b0ec0a4ab0 >>> 153545841ee127841b78ee5b01f8334098ac4fcf M src >>> >>> My backtraces indicate that the crash always is linked to >>> >>> dt_iop_clip_and_zoom_mosaic_half_size_plain._omp_fn.1 () at >>> /home/pegelow/darktable/src/develop/imageop_math.c:230 >>> >>> which somehow makes it plausible that the a.m. commit might be involved. >>> >>> Ulrich >>> >>> Am 29.01.2017 um 08:03 schrieb Roman Lebedev: >>>> On Sun, Jan 29, 2017 at 1:09 AM, Ulrich Pegelow >>>> <ulrich.pege...@tongareva.de> wrote: >>>>> Same here with current master on specific images with and without OpenCL. >>>>> I >>>>> have several images from one session, all have the same raw size. One >>>>> image >>>>> with an uncommon crop crashes whenever I open it in the darkroom. >>>> Looks like the crash is in gtk / x? >>>> >>>>> Ulrich >>>> Roman. >>>> >>> >>> ___________________________________________________________________________ >>> darktable developer mailing list >>> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org >> >> ___________________________________________________________________________ >> darktable developer mailing list >> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
