[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #9: Update guava to 30.1.1-jre

[GitBox]

jojochuang opened a new pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9


   HADOOP-17648


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: Update guava to 30.1.1-jre

[GitBox]

jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173335


   Yeah I think we should release hadoop-thirdparty 1.1.0 now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] virajjasani commented on pull request #9: Update guava to 30.1.1-jre

[GitBox]

virajjasani commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173643


   Just one minor comment: We can update PR title to include `HADOOP-17648`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822175134


   Oh yeah you're right. I'm doing too much work at once. Updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822398949


   Actually this PR breaks shading
   `Error creating shaded jar: duplicate entry: META-INF/LICENSE.txt`
   Looking into this error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822907603


   The above commit fixes the shading problem. @virajjasani  care to have 
another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] virajjasani commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

virajjasani commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822972015


   I see, it was coming from `checker-qual`. Sounds good to exclude it. 
   +1 (non-binding).
   @jojochuang where do we usually see QA results for hadoop-thirdparty? It 
seems 
[hadoop-multibranch](https://ci-hadoop.apache.org/job/hadoop-multibranch/view/change-requests/)
 doesn't have it.
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-823699977


   It doesn't look like we run QA for hadoop-thirdparty repo. It's a relatively 
less developed repo after all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #10: HADOOP-17660. Update dependency-check-maven version.

[GitBox]

jojochuang opened a new pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10


   Manually tested by running command `mvn dependency-check:aggregate`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #10: HADOOP-17660. Update dependency-check-maven version.

[GitBox]

aajisaka merged pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #10: HADOOP-17660. Update dependency-check-maven version.

[GitBox]

aajisaka commented on pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156


   Thanks @jojochuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

aajisaka merged pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

aajisaka commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797


   Thank you @jojochuang and @virajjasani 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

aajisaka commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797


   Thank you @jojochuang and @virajjasani 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

[GitBox]

aajisaka merged pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #10: HADOOP-17660. Update dependency-check-maven version.

[GitBox]

aajisaka commented on pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156


   Thanks @jojochuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #10: HADOOP-17660. Update dependency-check-maven version.

[GitBox]

aajisaka merged pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #11: HADOOP-17659. Remove hadoop-shaded-jaeger from hadoop-thirdparty 1.1.0 release.

[GitBox]

jojochuang opened a new pull request #11:
URL: https://github.com/apache/hadoop-thirdparty/pull/11


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka opened a new pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka opened a new pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12


   JIRA: https://issues.apache.org/jira/browse/HADOOP-17667
   
   Test GitHub Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826744706


   Umm. Maybe GitHub actions will be enabled after the PR is merged into the 
branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826751862


   Result: https://github.com/aajisaka/hadoop-thirdparty/actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

smengcl commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986


   Thanks @aajisaka . Would you trigger a re-run on your fork? looks like it is 
still failing on the previous java-version typo here:
   https://github.com/aajisaka/hadoop-thirdparty/actions/runs/785332982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] smengcl edited a comment on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

smengcl edited a comment on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986


   Thanks @aajisaka . ~~Would you trigger a re-run on your fork? looks like it 
is still failing on the previous java-version typo here:
   https://github.com/aajisaka/hadoop-thirdparty/actions/runs/785332982~~
   
   nvm. I was looking at an older run. lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-827247977


   @jojochuang @ayushtkn 
   Do you need any additional tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #11: HADOOP-17659. Remove hadoop-shaded-jaeger from hadoop-thirdparty 1.1.0 release.

[GitBox]

jojochuang merged pull request #11:
URL: https://github.com/apache/hadoop-thirdparty/pull/11


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb opened a new pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

[GitBox]

medb opened a new pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13


   Protobuf 3.7.1 is not available in any OS repo and requires manual 
compilation which takes time (10-15 mins).
   
   Protobuf 3.12.4 is not only newer but also available in latest Debian and 
Ubuntu release out of the box which eliminates need for manual compilation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka merged pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

[GitBox]

aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-830728944


   Merged. Thank you @smengcl and @jojochuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox]

jojochuang opened a new pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14


   (1) Hard code a python dependency version to avoid image build error.
   (2) Remove npm which is not used for building hadoop-thirdparty to avoid 
image build error.
   (2) Migrate to Ubuntu 18.04 (Bionic) to use GPG 2.2 (LTS) instead of 1.x for 
signing.
   The build script runs a gpg agent inside docker that shares the gpg keys 
with the host machine, of which most ships GPG2.2. GPG 1.x is quite old and is 
not compatible with GPG 2.x. Ubuntu 16.04 (Xenia) has gpg2.1 packages, which is 
incompatible with gpg2.2. Ubuntu 18.04 installs gpg 2.2 by default. 
   
   Test: manually tested by running `dev-support/bin/create-release 
--asfrelease --docker --dockercache`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox]

jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-839651970


   This change blocks the hadoop-thirdparty 1.1.0 release. Please review 
@aajisaka @ayushtkn @vinayakumarb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox]

aajisaka commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840239920


   Thank you @jojochuang. Maybe we need to update the description to something 
like "Fix the docker image".
   
   In the future, I want to clean up the Dockerfile:
   - Upgrade Yetus to 0.13.0 and Python to 3.x
   - Upgrade to Focal
   - Remove unused libraries


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox]

aajisaka commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733



##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
 && apt-get clean \
 && rm -rf /var/lib/apt/lists/*
 
-
-##
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-##
-RUN mkdir -p /opt/cmake \
-&& curl -L -s -S \
-  https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
-  -o /opt/cmake.tar.gz \
-&& tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
 ##
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)

Review comment:
   I think protobuf is not required and can be removed to build the image 
faster.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

[GitBox]

jojochuang opened a new pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15


   Update the LICENSE and NOTICE files to reflect what's bundled in 
hadoop-thirdparty 1.1 and above.
   
   1. Removed licenses and notices of the thirdparty dependency that shipped 
along with opentracing and jaeger. (the shaded jaeger was removed by 
HADOOP-17659)
   2. added transitive dependencies shipped with guva 30.1.1. We bundle 
com.google.j2objc:j2objc-annotations and org.checkerframework:checker-qual 
(com.google.code.findbugs:jsr305 is excluded by the shader)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka opened a new pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

[GitBox]

aajisaka opened a new pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16


   JIRA: HADOOP-17697
   
   - Added the license header
   - Create a job to check license


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox]

jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631526674



##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
 && apt-get clean \
 && rm -rf /var/lib/apt/lists/*
 
-
-##
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-##
-RUN mkdir -p /opt/cmake \
-&& curl -L -s -S \
-  https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
-  -o /opt/cmake.tar.gz \
-&& tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
 ##
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)

Review comment:
   a! you're perfectly right. I kept thinking we shade protobuf so we need 
it. But we don't use protoc to compile proto files




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

[GitBox]

jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840250988


   So at the end of the day, we probably don't need to use protobuf in the 
hadoop-thirdparty repository. See: 
https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

[GitBox]

jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840251431


   Instead, we should do this for the main hadoop repository, not the 
hadoop-thirdparty repo. 
https://github.com/apache/hadoop/blob/trunk/dev-support/docker/Dockerfile#L120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

[GitBox]

medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840254235


   @jojochuang May you clarify, do you mean that we do not need to compile 
protoc in [`hadoop-thirdparty` Docker 
file](https://github.com/apache/hadoop-thirdparty/blob/trunk/dev-support/docker/Dockerfile)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

[GitBox]

jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840256223


   Yeah. We have a number of redundant steps in hadoop-thirdparty Dockerfile. 
It was copied from the main hadoop repo but we don't need many of the packages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

[GitBox]

jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631539990



##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
 && apt-get clean \
 && rm -rf /var/lib/apt/lists/*
 
-
-##
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-##
-RUN mkdir -p /opt/cmake \
-&& curl -L -s -S \
-  https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
-  -o /opt/cmake.tar.gz \
-&& tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
 ##
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)

Review comment:
   Updated. Please review, @aajisaka 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

[GitBox]

jojochuang merged pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

[GitBox]

jojochuang commented on pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15#issuecomment-840301789


   Thanks @aajisaka @tasanuma !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

[GitBox]

jojochuang merged pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

[GitBox]

jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840305102


   Thanks @aajisaka !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

[GitBox]

jojochuang merged pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

[GitBox]

aajisaka commented on pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16#issuecomment-840328780


   Thank you @jojochuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

[GitBox]

medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840985181


   @jojochuang rebased on the trunk HEAD and updated PR to the latest Protobuf 
version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

[GitBox]

jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117


   As I said, this PR is not needed. I'd like to ask you to work on the 
protobuf update in the main hadoop repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

[GitBox]

jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117


   As I said, this PR is not needed. I'd like to ask you to work on the 
protobuf update in the main hadoop repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma opened a new pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma opened a new pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17


   JIRA: https://issues.apache.org/jira/browse/HADOOP-17707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842794574


   @jojochuang Could you review it? We may need it in 1.1.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

smengcl commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842802932


   Thanks @tasanuma @jojochuang for taking care of the doc.
   
   Posting `mvn dependency:tree` result on latest trunk here just for reference:
   
   ```bash
   [INFO] --< org.apache.hadoop.thirdparty:hadoop-shaded-protobuf_3_7 
>---
   [INFO] Building Apache Hadoop shaded Protobuf 3.7 1.2.0-SNAPSHOT  
[2/3]
   [INFO] [ jar 
]-
   [INFO]
   [INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ 
hadoop-shaded-protobuf_3_7 ---
   [INFO] 
org.apache.hadoop.thirdparty:hadoop-shaded-protobuf_3_7:jar:1.2.0-SNAPSHOT
   [INFO] \- com.google.protobuf:protobuf-java:jar:3.7.1:compile
   [INFO]
   [INFO] --< org.apache.hadoop.thirdparty:hadoop-shaded-guava 
>--
   [INFO] Building Apache Hadoop shaded Guava 1.2.0-SNAPSHOT 
[3/3]
   [INFO] [ jar 
]-
   [INFO]
   [INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ 
hadoop-shaded-guava ---
   [INFO] org.apache.hadoop.thirdparty:hadoop-shaded-guava:jar:1.2.0-SNAPSHOT
   [INFO] \- com.google.guava:guava:jar:30.1.1-jre:compile
   [INFO]+- com.google.guava:failureaccess:jar:1.0.1:compile
   [INFO]+- 
com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
   [INFO]+- com.google.code.findbugs:jsr305:jar:3.0.2:compile
   [INFO]+- org.checkerframework:checker-qual:jar:3.8.0:compile
   [INFO]\- com.google.j2objc:j2objc-annotations:jar:1.3:compile
   [INFO] 

   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842812751


   @jojochuang @smengcl Thanks for your reviews and your help. I added guava 
document.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843034859


   @jojochuang I added the information about `org.checkerframework`.
   
   `failureaccess` and `listenablefuture` are included in `com.google.guava`, 
and both of the relocations are under the 
`org.apache.hadoop.thirdparty.com.google`. So I think it is enough to write the 
path of `com.google.guava`.
   
   I can't find the relocation of `com.google.code.findbugs:jsr305`. Since 
Hadoop is using `com.google.code.findbugs:jsr305` directly, we may not need to 
write it here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma merged pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma merged pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843794096


   Thanks for your view, @jojochuang.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844164345


   Sorry, I forgot to squash it...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

smengcl commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844355268


   @tasanuma We can probably configure the "Merge button" config in Repo 
Settings page the same as apache/hadoop to only allow squash merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844755126


   I don't have the privilege to see the Repo Settings page. Maybe we need to 
add `.asf.yml` like HADOOP-17234?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844761869


   Actually, we asked INFRA to only allow squash merging for apache/hadoop. I 
will create another jira for hadoop-thirdparty.
   https://issues.apache.org/jira/browse/INFRA-18777


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

[GitBox]

tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-846657744


   Now only the "Squash and Merge" is enabled.
   https://issues.apache.org/jira/browse/INFRA-21905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #18: HADOOP-17730. Add back error_prone

[GitBox]

jojochuang opened a new pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18


   Tested by compiling Ozone with the modified Hadoop-thirdparty 1.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #18: HADOOP-17730. Add back error_prone

[GitBox]

jojochuang commented on pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848416511


   @ayushtkn or @tasanuma can you review?
   
   I am thinking to add this and then start a hadoop-thirdparty 1.1.1 vote. It 
is not strictly required. For Ozone, I have a workaround but it would be nice 
to have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #18: HADOOP-17730. Add back error_prone

[GitBox]

jojochuang merged pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #18: HADOOP-17730. Add back error_prone

[GitBox]

jojochuang commented on pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848474245


   Thanks! I'll start preparing the 1.1.1 RC then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

[GitBox]

medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-912924915


   @jojochuang sent PR to the Hadoop repo: 
https://github.com/apache/hadoop/pull/3384
   
   Please, let me know if this is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

[GitBox]

medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242


   @jojochuang I took a look at Hadoop changes, and it seems to upgrade 
Protobuf both PRs are necessary (in `hadoop-thirdparty` and `hadoop` 
repositories)
   
   May you explain, how can I update Protobuf without any changes in Hadoop 
Thirdparty repository (i.e. this PR)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb edited a comment on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

[GitBox]

medb edited a comment on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242


   @jojochuang I took a look at Hadoop changes in apache/hadoop#3384, and it 
seems that to upgrade Protobuf both PRs are required 
(apache/hadoop-thirdparty#13 in `hadoop-thirdparty` and apache/hadoop#3384 in 
`hadoop` repositories)
   
   May you explain, how can I update Protobuf without any changes in Hadoop 
Thirdparty repository (i.e. this PR)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] cjolivier01 commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

[GitBox]

cjolivier01 commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-1050314164


   It would be good to update this to a non-vulnerable version of protobuf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] steveloughran opened a new pull request, #19: HADOOP-18197. Upgrade protobuf to 3.20.1

[GitBox]

steveloughran opened a new pull request, #19:
URL: https://github.com/apache/hadoop-thirdparty/pull/19

   
   This patch bumps up the protobuf version so that Hadoop
   is not a vulnerable to CVE-2021-22569.
   
   I'm not renaming the module hadoop-shaded-protobuf_3_7
   because that significantly complicates imports/upgrading.
   That said, I don't see why the version number needed to be
   included there. We will have to live with that.
   
   This also fixes up the parent POM references in the child modules
   as IntelliJ requires a full path.
   
   Testing: needs to go through hadoop built with the updated jar and
   with its own protobuf version marker updated.
   Verified hadoop compiles on a macbook m1.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on pull request #19: HADOOP-18197. Upgrade protobuf to 3.21.1

[GitBox]

ayushtkn commented on PR #19:
URL: https://github.com/apache/hadoop-thirdparty/pull/19#issuecomment-1150334147

   >That said, I don't see why the version number needed to be
   included there. We will have to live with that.
   
   That wasn't something we wanted to do that initially, that came as a 
suggestion in the ML thread.
   https://lists.apache.org/thread/v7cqm2bwvrlyhmdl2xo9pg84rvb6t214
   
   Guess as per the ML suggestion, it was to be done for Guava also, but the 
developer forgot about this, so we have to live without that in guava


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn opened a new pull request, #20: HADOOP-18282. Add .asf.yaml to hadoop-thirdparty.

[GitBox]

ayushtkn opened a new pull request, #20:
URL: https://github.com/apache/hadoop-thirdparty/pull/20

   Similar to [HADOOP-17234](https://issues.apache.org/jira/browse/HADOOP-17234)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn merged pull request #20: HADOOP-18282. Add .asf.yaml to hadoop-thirdparty.

[GitBox]

ayushtkn merged PR #20:
URL: https://github.com/apache/hadoop-thirdparty/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb opened a new pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb opened a new pull request #1: HADOOP-16595. [pb-upgrade] Create 
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r329297329
 
 

 ##
 File path: pom.xml
 ##
 @@ -0,0 +1,466 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+  org.apache.hadoop.thirdparty
+  hadoop-thirdparty
+  1.0.0-SNAPSHOT
+  
+org.apache
+apache
+21
+
+
+  
+  Apache Hadoop Third-party Libs
+  pom
+  
+Packaging of relocated (renamed, shaded) third-party libraries used by 
Hadoop.
+  
+
+  
+
+  ${distMgmtStagingId}
+  ${distMgmtStagingName}
+  ${distMgmtStagingUrl}
+
+
+  ${distMgmtSnapshotsId}
+  ${distMgmtSnapshotsName}
+  ${distMgmtSnapshotsUrl}
+
+
+  apache.website
+  
scpexe://people.apache.org/www/hadoop.apache.org/docs/rthirdparty-${project.version}
+
+  
+
+  
+
+  ${distMgmtSnapshotsId}
+  ${distMgmtSnapshotsName}
+  ${distMgmtSnapshotsUrl}
+
+
+  repository.jboss.org
+  https://repository.jboss.org/nexus/content/groups/public/
+  
+false
+  
+
+  
+
+  
+
+  Apache License, Version 2.0
+  https://www.apache.org/licenses/LICENSE-2.0.txt
+
+  
+
+  
+
+3.2.0
+
+1.8
+
+apache.snapshots.https
+Apache Development Snapshot 
Repository
+
https://repository.apache.org/content/repositories/snapshots
+apache.staging.https
+Apache Release Distribution 
Repository
+
https://repository.apache.org/service/local/staging/deploy/maven2
+
+
+UTF-8
+UTF-8
+
+
+org.apache.hadoop.thirdparty
+3.7.1
+
+
+2.8.1
+3.6
+1.5
+1.7
+2.5
+3.0.2
+3.0.0-M1
+3.0.1
+1.5
+0.12
+2.4
+2.5.0
+3.0.0
+8.19
+1.4.3
+1.3.1
+  
+
+  
+Apache Software Foundation
+https://www.apache.org
+  
+
+  
+hadoop-shaded-protobuf
+  
+
+  
+
+  
+
+  org.apache.maven.plugins
+  maven-dependency-plugin
+  ${maven-dependency-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-enforcer-plugin
+  ${maven-enforcer-plugin.version}
+  
+
+  
+[3.0.2,)
+  
+  
+[1.8,)
+  
+
+  
+
+
+  org.apache.maven.plugins
+  maven-assembly-plugin
+  ${maven-assembly-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-deploy-plugin
+  ${maven-deploy-plugin.version}
+
+
+  org.apache.rat
+  apache-rat-plugin
+  ${apache-rat-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-antrun-plugin
+  ${maven-antrun-plugin.version}
+
+
+  org.codehaus.mojo
+  exec-maven-plugin
+  ${exec-maven-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-site-plugin
+  ${maven-site-plugin.version}
+  
+
+  org.apache.maven.wagon
+  wagon-ssh
+  ${wagon-ssh.version}
+
+
+  org.apache.maven.doxia
+  doxia-module-markdown
+  1.8
+
+  
+
+
+  org.apache.felix
+  maven-bundle-plugin
+  ${maven-bundle-plugin.version}
+
+
 
 Review comment:
   Do we need checkstyle? We do not have any hand written java files in the 
project...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r329297473
 
 

 ##
 File path: hadoop-shaded-protobuf/pom.xml
 ##
 @@ -0,0 +1,120 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf
+  Apache Hadoop shaded Protobuf
+  jar
+
+  
+  
+
+  
+
+  com.google.protobuf
+  protobuf-java
+  ${protobuf.version}
+
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-shade-plugin
+
+  true
+
+
+  
+org.apache.hadoop
+hadoop-maven-plugins
+${hadoop.version}
+  
+
+
+  
+shade-protobuf
+package
+
+  shade
+
+
+  
+
+  com.google.protobuf:protobuf-java
+
+  
+  
+
+  com.google.protobuf:*
+  
+**/*
+  
+
+  
+  
+
+  com/google/protobuf
+  
${shaded.prefix}.com.google.protobuf
+
+
+  google/
+  ${shaded.prefix}.google.
+  
+**/*.proto
+  
+
+  
+  
+
 
 Review comment:
   https://issues.apache.org/jira/browse/MSHADE-182 has been resolved for 
years, so we do not need this any more?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create 
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-539941211
 
 
   Will update the PR later today


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333191213
 
 

 ##
 File path: hadoop-shaded-protobuf/pom.xml
 ##
 @@ -0,0 +1,120 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf
+  Apache Hadoop shaded Protobuf
+  jar
+
+  
+  
+
+  
+
+  com.google.protobuf
+  protobuf-java
+  ${protobuf.version}
+
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-shade-plugin
+
+  true
+
+
+  
+org.apache.hadoop
+hadoop-maven-plugins
+${hadoop.version}
+  
+
+
+  
+shade-protobuf
+package
+
+  shade
+
+
+  
+
+  com.google.protobuf:protobuf-java
+
+  
+  
+
+  com.google.protobuf:*
+  
+**/*
+  
+
+  
+  
+
+  com/google/protobuf
+  
${shaded.prefix}.com.google.protobuf
+
+
+  google/
+  ${shaded.prefix}.google.
+  
+**/*.proto
+  
+
+  
+  
+
 
 Review comment:
   Removed the dependency on hadoop-maven-plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333191323
 
 

 ##
 File path: pom.xml
 ##
 @@ -0,0 +1,466 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+  org.apache.hadoop.thirdparty
+  hadoop-thirdparty
+  1.0.0-SNAPSHOT
+  
+org.apache
+apache
+21
+
+
+  
+  Apache Hadoop Third-party Libs
+  pom
+  
+Packaging of relocated (renamed, shaded) third-party libraries used by 
Hadoop.
+  
+
+  
+
+  ${distMgmtStagingId}
+  ${distMgmtStagingName}
+  ${distMgmtStagingUrl}
+
+
+  ${distMgmtSnapshotsId}
+  ${distMgmtSnapshotsName}
+  ${distMgmtSnapshotsUrl}
+
+
+  apache.website
+  
scpexe://people.apache.org/www/hadoop.apache.org/docs/rthirdparty-${project.version}
+
+  
+
+  
+
+  ${distMgmtSnapshotsId}
+  ${distMgmtSnapshotsName}
+  ${distMgmtSnapshotsUrl}
+
+
+  repository.jboss.org
+  https://repository.jboss.org/nexus/content/groups/public/
+  
+false
+  
+
+  
+
+  
+
+  Apache License, Version 2.0
+  https://www.apache.org/licenses/LICENSE-2.0.txt
+
+  
+
+  
+
+3.2.0
+
+1.8
+
+apache.snapshots.https
+Apache Development Snapshot 
Repository
+
https://repository.apache.org/content/repositories/snapshots
+apache.staging.https
+Apache Release Distribution 
Repository
+
https://repository.apache.org/service/local/staging/deploy/maven2
+
+
+UTF-8
+UTF-8
+
+
+org.apache.hadoop.thirdparty
+3.7.1
+
+
+2.8.1
+3.6
+1.5
+1.7
+2.5
+3.0.2
+3.0.0-M1
+3.0.1
+1.5
+0.12
+2.4
+2.5.0
+3.0.0
+8.19
+1.4.3
+1.3.1
+  
+
+  
+Apache Software Foundation
+https://www.apache.org
+  
+
+  
+hadoop-shaded-protobuf
+  
+
+  
+
+  
+
+  org.apache.maven.plugins
+  maven-dependency-plugin
+  ${maven-dependency-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-enforcer-plugin
+  ${maven-enforcer-plugin.version}
+  
+
+  
+[3.0.2,)
+  
+  
+[1.8,)
+  
+
+  
+
+
+  org.apache.maven.plugins
+  maven-assembly-plugin
+  ${maven-assembly-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-deploy-plugin
+  ${maven-deploy-plugin.version}
+
+
+  org.apache.rat
+  apache-rat-plugin
+  ${apache-rat-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-antrun-plugin
+  ${maven-antrun-plugin.version}
+
+
+  org.codehaus.mojo
+  exec-maven-plugin
+  ${exec-maven-plugin.version}
+
+
+  org.apache.maven.plugins
+  maven-site-plugin
+  ${maven-site-plugin.version}
+  
+
+  org.apache.maven.wagon
+  wagon-ssh
+  ${wagon-ssh.version}
+
+
+  org.apache.maven.doxia
+  doxia-module-markdown
+  1.8
+
+  
+
+
+  org.apache.felix
+  maven-bundle-plugin
+  ${maven-bundle-plugin.version}
+
+
 
 Review comment:
   removed the checkstyle plugin as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333198496
 
 

 ##
 File path: hadoop-shaded-protobuf37/pom.xml
 ##
 @@ -0,0 +1,110 @@
+
+

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333198546
 
 

 ##
 File path: src/site/markdown/index.md.vm
 ##
 @@ -0,0 +1,40 @@
+

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r48847
 
 

 ##
 File path: hadoop-shaded-protobuf37/pom.xml
 ##
 @@ -0,0 +1,110 @@
+
+

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r48879
 
 

 ##
 File path: src/site/markdown/index.md.vm
 ##
 @@ -0,0 +1,40 @@
+

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333460910
 
 

 ##
 File path: .gitignore
 ##
 @@ -0,0 +1,6 @@
+.idea
+**/target/*
+*.patch
+*.iml
+patchprocess
+**/dependency-reduced-pom.xml
 
 Review comment:
   can we add .project, .classpath and .settings?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333461008
 
 

 ##
 File path: LICENSE.txt
 ##
 @@ -0,0 +1,224 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is prvided in the Appendix below).
 
 Review comment:
   typo *provided


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333461646
 
 

 ##
 File path: NOTICE-binary
 ##
 @@ -0,0 +1,840 @@
+Apache Hadoop
+Copyright 2006 and onwards The Apache Software Foundation.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Export Control Notice
+-
+
+This distribution includes cryptographic software.  The country in
+which you currently reside may have restrictions on the import,
+possession, use, and/or re-export to another country, of
+encryption software.  BEFORE using any encryption software, please
+check your country's laws, regulations and policies concerning the
+import, possession, or use, and re-export of encryption software, to
+see if this is permitted.  See  for more
+information.
+
+The U.S. Government Department of Commerce, Bureau of Industry and
+Security (BIS), has classified this software as Export Commodity
+Control Number (ECCN) 5D002.C.1, which includes information security
+software using or performing cryptographic functions with asymmetric
+algorithms.  The form and manner of this Apache Software Foundation
+distribution makes it eligible for export under the License Exception
+ENC Technology Software Unrestricted (TSU) exception (see the BIS
+Export Administration Regulations, Section 740.13) for both object
+code and source code.
+
+The following provides more details on the included cryptographic software:
+
+This software uses the SSL libraries from the Jetty project written
+by mortbay.org.
+Hadoop Yarn Server Web Proxy uses the BouncyCastle Java
+cryptography APIs written by the Legion of the Bouncy Castle Inc.
+
+// --
+// NOTICE file corresponding to the section 4d of The Apache License,
+// Version 2.0, in this case for
+// --
+
+
+Apache Yetus
+Copyright 2008-2017 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+---
+Additional licenses for the Apache Yetus Source/Website:
+---
+
+
+See LICENSE for terms.
+
+
+
+Apache Avro
+Copyright 2010 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+C JSON parsing provided by Jansson and
+written by Petri Lehtinen. The original software is
+available from http://www.digip.org/jansson/.
+
+
+AWS SDK for Java
+Copyright 2010-2014 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+
+This product includes software developed by
+Amazon Technologies, Inc (http://www.amazon.com/).
+
+**
+THIRD PARTY COMPONENTS
+**
+This software includes third party software subject to the following 
copyrights:
+- XML parsing and utility functions from JetS3t - Copyright 2006-2009 James 
Murty.
+- PKCS#1 PEM encoded private key parsing and utility functions from 
oauth.googlecode.com - Copyright 1998-2010 AOL Inc.
+
+The licenses for these third party components are included in LICENSE.txt
+
+
+Apache Commons BeanUtils
+Copyright 2000-2016 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+Apache Commons CLI
+Copyright 2001-2009 The Apache Software Foundation
+
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).
+
+
+Apache Commons Codec
+Copyright 2002-2017 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+contains test data from http://aspell.net/test/orig/batch0.tab.
+Copyright (C) 2002 Kevin Atkinson (kev...@gnu.org)
+
+===
+
+The content of package org.apache.commons.codec.language.bm has been translated
+from the original php source code available at 
http://stevemorse.org/phoneticinfo.htm
+with permission from the original authors.
+Original source copyright:
+Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+
+Apache Commons Collections
+Copyright 2001-2018 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+Apache Commons Compress
+Copyright 2002-2018 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (https://www.apache.org/).
+
+The files in the package org.apache.commons.compress.archivers.sevenz
+were derived from the LZMA SDK, version 9.20 (C/ and CPP/7zip/),
+which has been placed 

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333463878
 
 

 ##
 File path: hadoop-shaded-protobuf37/pom.xml
 ##
 @@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf37
 
 Review comment:
   Well I am ok with 37 but 37 is itself a whole number doesn't directly 
indicate 3.7 may be can we have something like 3_7?
   if that sounds better to you, otherwise I am still Ok with this also.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r359182162
 
 

 ##
 File path: hadoop-shaded-protobuf37/pom.xml
 ##
 @@ -0,0 +1,110 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf37
 
 Review comment:
   Okay will change to _3_7


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r360321079
 
 

 ##
 File path: dev-support/bin/create-release
 ##
 @@ -0,0 +1,692 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+if [[ -z "${BASH_VERSINFO[0]}" ]] \
+   || [[ "${BASH_VERSINFO[0]}" -lt 3 ]] \
+   || [[ "${BASH_VERSINFO[0]}" -eq 3 && "${BASH_VERSINFO[1]}" -lt 2 ]]; then
+  echo "bash v3.2+ is required. Sorry."
+  exit 1
+fi
+
+function centered_text
+{
+  local text="$*"
+  local spacing=$(( (75+${#text}) /2 ))
+  printf "%*s\n"  ${spacing} "${text}"
+}
+
+function big_console_header
+{
+  printf "\n\n"
+  echo 
""
+  centered_text "${@}"
+  echo 
""
+  printf "\n\n"
+}
+
+## @description  Given a filename or dir, return the absolute version of it
+## @audience public
+## @stabilitystable
+## @paramdirectory
+## @replaceable  no
+## @return   0 success
+## @return   1 failure
+## @return   stdout abspath
+function hadoop_abs
+{
+  declare obj=$1
+  declare dir
+  declare fn
+  declare ret
+
+  if [[ ! -e ${obj} ]]; then
+return 1
+  elif [[ -d ${obj} ]]; then
+dir=${obj}
+  else
+dir=$(dirname -- "${obj}")
+fn=$(basename -- "${obj}")
+fn="/${fn}"
+  fi
+
+  dir=$(cd -P -- "${dir}" >/dev/null 2>/dev/null && pwd -P)
+  ret=$?
+  if [[ ${ret} = 0 ]]; then
+echo "${dir}${fn}"
+return 0
+  fi
+  return 1
+}
+
+## @description  Print a message to stderr
+## @audience public
+## @stabilitystable
+## @replaceable  no
+## @paramstring
+function hadoop_error
+{
+  echo "$*" 1>&2
+}
+
+
+function run_and_redirect
+{
+  declare logfile=$1
+  shift
+  declare res
+
+  echo "\$ ${*} > ${logfile} 2>&1"
+  # to the log
+  {
+date
+echo "cd $(pwd)"
+echo "${*}"
+  } > "${logfile}"
+  # run the actual command
+  "${@}" >> "${logfile}" 2>&1
+  res=$?
+  if [[ ${res} != 0 ]]; then
+echo
+echo "Failed!"
+echo
+exit "${res}"
+  fi
+}
+
+function hadoop_native_flags
+{
+
+  # modified version of the Yetus personality
+
+  if [[ ${NATIVE} != true ]]; then
+return
+  fi
+
+  # Based upon HADOOP-11937
+  #
+  # Some notes:
+  #
+  # - getting fuse to compile on anything but Linux
+  #   is always tricky.
+  # - Darwin assumes homebrew is in use.
+  # - HADOOP-12027 required for bzip2 on OS X.
+  # - bzip2 is broken in lots of places.
+  #   e.g, HADOOP-12027 for OS X. so no -Drequire.bzip2
+  #
+
+  case "${OSNAME}" in
+Linux)
+  # shellcheck disable=SC2086
+  echo -Pnative -Drequire.snappy -Drequire.openssl -Drequire.fuse
+;;
+Darwin)
+  echo \
+  -Pnative -Drequire.snappy  \
+  -Drequire.openssl \
+-Dopenssl.prefix=/usr/local/opt/openssl/ \
+-Dopenssl.include=/usr/local/opt/openssl/include \
+-Dopenssl.lib=/usr/local/opt/openssl/lib
+;;
+*)
+  # shellcheck disable=SC2086
+  echo \
+-Pnative \
+-Drequire.snappy -Drequire.openssl \
+-Drequire.test.libhadoop
+;;
+  esac
+}
+
+# Function to probe the exit code of the script commands,
+# and stop in the case of failure with an contextual error
+# message.
+function run()
+{
+  declare res
+  declare logfile
+
+  echo "\$ ${*}"
+  "${@}"
+  res=$?
+  if [[ ${res} != 0 ]]; then
+echo
+echo "Failed!"
+echo
+exit "${res}"
+  fi
+}
+
+function header()
+{
+  echo
+  printf "\n\n"
+  echo 
""
+  echo 
""
+  centered_text "Hadoop Thirdparty Release Creator"
+  echo 
""
+  echo 
""
+  printf "\n\n"
+  echo "Version to create  : ${HADOOP_VERSION}"
+  echo "Release Candidate Label: ${RC_LABEL##-}"
+  echo "Source Version : $

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r360321593
 
 

 ##
 File path: dev-support/bin/create-release
 ##
 @@ -0,0 +1,692 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+if [[ -z "${BASH_VERSINFO[0]}" ]] \
+   || [[ "${BASH_VERSINFO[0]}" -lt 3 ]] \
+   || [[ "${BASH_VERSINFO[0]}" -eq 3 && "${BASH_VERSINFO[1]}" -lt 2 ]]; then
+  echo "bash v3.2+ is required. Sorry."
+  exit 1
+fi
+
+function centered_text
+{
+  local text="$*"
+  local spacing=$(( (75+${#text}) /2 ))
+  printf "%*s\n"  ${spacing} "${text}"
+}
+
+function big_console_header
+{
+  printf "\n\n"
+  echo 
""
+  centered_text "${@}"
+  echo 
""
+  printf "\n\n"
+}
+
+## @description  Given a filename or dir, return the absolute version of it
+## @audience public
+## @stabilitystable
+## @paramdirectory
+## @replaceable  no
+## @return   0 success
+## @return   1 failure
+## @return   stdout abspath
+function hadoop_abs
+{
+  declare obj=$1
+  declare dir
+  declare fn
+  declare ret
+
+  if [[ ! -e ${obj} ]]; then
+return 1
+  elif [[ -d ${obj} ]]; then
+dir=${obj}
+  else
+dir=$(dirname -- "${obj}")
+fn=$(basename -- "${obj}")
+fn="/${fn}"
+  fi
+
+  dir=$(cd -P -- "${dir}" >/dev/null 2>/dev/null && pwd -P)
+  ret=$?
+  if [[ ${ret} = 0 ]]; then
+echo "${dir}${fn}"
+return 0
+  fi
+  return 1
+}
+
+## @description  Print a message to stderr
+## @audience public
+## @stabilitystable
+## @replaceable  no
+## @paramstring
+function hadoop_error
+{
+  echo "$*" 1>&2
+}
+
+
+function run_and_redirect
+{
+  declare logfile=$1
+  shift
+  declare res
+
+  echo "\$ ${*} > ${logfile} 2>&1"
+  # to the log
+  {
+date
+echo "cd $(pwd)"
+echo "${*}"
+  } > "${logfile}"
+  # run the actual command
+  "${@}" >> "${logfile}" 2>&1
+  res=$?
+  if [[ ${res} != 0 ]]; then
+echo
+echo "Failed!"
+echo
+exit "${res}"
+  fi
+}
+
+function hadoop_native_flags
+{
+
+  # modified version of the Yetus personality
+
+  if [[ ${NATIVE} != true ]]; then
+return
+  fi
+
+  # Based upon HADOOP-11937
+  #
+  # Some notes:
+  #
+  # - getting fuse to compile on anything but Linux
+  #   is always tricky.
+  # - Darwin assumes homebrew is in use.
+  # - HADOOP-12027 required for bzip2 on OS X.
+  # - bzip2 is broken in lots of places.
+  #   e.g, HADOOP-12027 for OS X. so no -Drequire.bzip2
+  #
+
+  case "${OSNAME}" in
+Linux)
+  # shellcheck disable=SC2086
+  echo -Pnative -Drequire.snappy -Drequire.openssl -Drequire.fuse
+;;
+Darwin)
+  echo \
+  -Pnative -Drequire.snappy  \
+  -Drequire.openssl \
+-Dopenssl.prefix=/usr/local/opt/openssl/ \
+-Dopenssl.include=/usr/local/opt/openssl/include \
+-Dopenssl.lib=/usr/local/opt/openssl/lib
+;;
+*)
+  # shellcheck disable=SC2086
+  echo \
+-Pnative \
+-Drequire.snappy -Drequire.openssl \
+-Drequire.test.libhadoop
+;;
+  esac
+}
+
+# Function to probe the exit code of the script commands,
+# and stop in the case of failure with an contextual error
+# message.
+function run()
+{
+  declare res
+  declare logfile
+
+  echo "\$ ${*}"
+  "${@}"
+  res=$?
+  if [[ ${res} != 0 ]]; then
+echo
+echo "Failed!"
+echo
+exit "${res}"
+  fi
+}
+
+function header()
+{
+  echo
+  printf "\n\n"
+  echo 
""
+  echo 
""
+  centered_text "Hadoop Thirdparty Release Creator"
+  echo 
""
+  echo 
""
+  printf "\n\n"
+  echo "Version to create  : ${HADOOP_VERSION}"
+  echo "Release Candidate Label: ${RC_LABEL##-}"
+  echo "Source Version : $

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create 
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-567883149
 
 
   Thanks @ayushtkn for reviews.
   
   @Apache9 @jojochuang Please take a look latest change as well. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] 
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r363039815
 
 

 ##
 File path: hadoop-shaded-protobuf_3_7/pom.xml
 ##
 @@ -0,0 +1,115 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf_3_7
 
 Review comment:
   Do we really need a 3_7 in the name? What if we upgrade the protobuf version 
in the future? The newest one is 3.11.2, then we need to change this to 3_11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r363041310
 
 

 ##
 File path: hadoop-shaded-protobuf_3_7/pom.xml
 ##
 @@ -0,0 +1,115 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.0.0-SNAPSHOT
+..
+  
+  4.0.0
+  hadoop-shaded-protobuf_3_7
 
 Review comment:
   This change is as per Owen O'Malley's comments in discussion thread.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] brahmareddybattula commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

brahmareddybattula commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r365116836
 
 

 ##
 File path: hadoop-shaded-protobuf_3_7/pom.xml
 ##
 @@ -0,0 +1,115 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
 
 Review comment:
   How about changing to shaded-artifact instead of thirdparty..?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on a change in pull request #1: HADOOP-16595. 
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r365172839
 
 

 ##
 File path: hadoop-shaded-protobuf_3_7/pom.xml
 ##
 @@ -0,0 +1,115 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  
+hadoop-thirdparty
 
 Review comment:
   This will be just a parent pom, this will not have any content to shade. 
Also this will not be directly used by any of the projects. 
   Actual artifacts used (ex: hadoop-shaded-protobuf-3_7) will have 'shaded' 
prefix in their name.
   I this will suffice.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb merged pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb merged pull request #1: HADOOP-16595. [pb-upgrade] Create 
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf

[GitBox]

vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create 
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-573513164
 
 
   Merged.
   Thanks @Apache9 @ayushtkn @jojochuang @brahmareddybattula  for reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb opened a new pull request #2: HADOOP-16820. [thirdparty] ChangeLog and ReleaseNote are not packaged by createrelease script

[GitBox]

vinayakumarb opened a new pull request #2: HADOOP-16820. [thirdparty] ChangeLog 
and ReleaseNote are not packaged by createrelease script
URL: https://github.com/apache/hadoop-thirdparty/pull/2
 
 
   # Changes
   ChangeLog and ReleaseNotes were not included due to version change.
   Hadoop thirdparty module have versions in form of "thirdparty-x.y.z", but 
script expects in "x.y.z" format.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] vinayakumarb opened a new pull request #3: HADOOP-16821. [pb-upgrade] Use 'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'

[GitBox]

vinayakumarb opened a new pull request #3: HADOOP-16821. [pb-upgrade] Use 
'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'
URL: https://github.com/apache/hadoop-thirdparty/pull/3
 
 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] steveloughran commented on issue #3: HADOOP-16821. [pb-upgrade] Use 'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'

[GitBox]

steveloughran commented on issue #3: HADOOP-16821. [pb-upgrade] Use 
'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'
URL: https://github.com/apache/hadoop-thirdparty/pull/3#issuecomment-576710054
 
 
   LGTM, +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org