vinayakumarb commented on a change in pull request #1: HADOOP-16595. [pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333191323
########## File path: pom.xml ########## @@ -0,0 +1,466 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <modelVersion>4.0.0</modelVersion> + <groupId>org.apache.hadoop.thirdparty</groupId> + <artifactId>hadoop-thirdparty</artifactId> + <version>1.0.0-SNAPSHOT</version> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>21</version> + <relativePath/> + <!-- no parent resolution --> + </parent> + <name>Apache Hadoop Third-party Libs</name> + <packaging>pom</packaging> + <description> + Packaging of relocated (renamed, shaded) third-party libraries used by Hadoop. + </description> + + <distributionManagement> + <repository> + <id>${distMgmtStagingId}</id> + <name>${distMgmtStagingName}</name> + <url>${distMgmtStagingUrl}</url> + </repository> + <snapshotRepository> + <id>${distMgmtSnapshotsId}</id> + <name>${distMgmtSnapshotsName}</name> + <url>${distMgmtSnapshotsUrl}</url> + </snapshotRepository> + <site> + <id>apache.website</id> + <url>scpexe://people.apache.org/www/hadoop.apache.org/docs/rthirdparty-${project.version}</url> + </site> + </distributionManagement> + + <repositories> + <repository> + <id>${distMgmtSnapshotsId}</id> + <name>${distMgmtSnapshotsName}</name> + <url>${distMgmtSnapshotsUrl}</url> + </repository> + <repository> + <id>repository.jboss.org</id> + <url>https://repository.jboss.org/nexus/content/groups/public/</url> + <snapshots> + <enabled>false</enabled> + </snapshots> + </repository> + </repositories> + + <licenses> + <license> + <name>Apache License, Version 2.0</name> + <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url> + </license> + </licenses> + + <properties> + <!-- required for build tools--> + <hadoop.version>3.2.0</hadoop.version> + <!-- define the Java language version used by the compiler --> + <javac.version>1.8</javac.version> + + <distMgmtSnapshotsId>apache.snapshots.https</distMgmtSnapshotsId> + <distMgmtSnapshotsName>Apache Development Snapshot Repository</distMgmtSnapshotsName> + <distMgmtSnapshotsUrl>https://repository.apache.org/content/repositories/snapshots</distMgmtSnapshotsUrl> + <distMgmtStagingId>apache.staging.https</distMgmtStagingId> + <distMgmtStagingName>Apache Release Distribution Repository</distMgmtStagingName> + <distMgmtStagingUrl>https://repository.apache.org/service/local/staging/deploy/maven2</distMgmtStagingUrl> + + <!-- platform encoding override --> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> + + <!--thirdparty dependency versions--> + <shaded.prefix>org.apache.hadoop.thirdparty</shaded.prefix> + <protobuf.version>3.7.1</protobuf.version> + + <!-- maven plugin versions --> + <maven-deploy-plugin.version>2.8.1</maven-deploy-plugin.version> + <maven-site-plugin.version>3.6</maven-site-plugin.version> + <maven-stylus-skin.version>1.5</maven-stylus-skin.version> + <maven-antrun-plugin.version>1.7</maven-antrun-plugin.version> + <maven-assembly-plugin.version>2.5</maven-assembly-plugin.version> + <maven-dependency-plugin.version>3.0.2</maven-dependency-plugin.version> + <maven-enforcer-plugin.version>3.0.0-M1</maven-enforcer-plugin.version> + <maven-javadoc-plugin.version>3.0.1</maven-javadoc-plugin.version> + <maven-gpg-plugin.version>1.5</maven-gpg-plugin.version> + <apache-rat-plugin.version>0.12</apache-rat-plugin.version> + <wagon-ssh.version>2.4</wagon-ssh.version> + <maven-bundle-plugin.version>2.5.0</maven-bundle-plugin.version> + <maven-checkstyle-plugin.version>3.0.0</maven-checkstyle-plugin.version> + <checkstyle.version>8.19</checkstyle.version> + <dependency-check-maven.version>1.4.3</dependency-check-maven.version> + <exec-maven-plugin.version>1.3.1</exec-maven-plugin.version> + </properties> + + <organization> + <name>Apache Software Foundation</name> + <url>https://www.apache.org</url> + </organization> + + <modules> + <module>hadoop-shaded-protobuf</module> + </modules> + + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-dependency-plugin</artifactId> + <version>${maven-dependency-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-enforcer-plugin</artifactId> + <version>${maven-enforcer-plugin.version}</version> + <configuration> + <rules> + <requireMavenVersion> + <version>[3.0.2,)</version> + </requireMavenVersion> + <requireJavaVersion> + <version>[1.8,)</version> + </requireJavaVersion> + </rules> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-assembly-plugin</artifactId> + <version>${maven-assembly-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-deploy-plugin</artifactId> + <version>${maven-deploy-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + <version>${apache-rat-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-antrun-plugin</artifactId> + <version>${maven-antrun-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>exec-maven-plugin</artifactId> + <version>${exec-maven-plugin.version}</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-site-plugin</artifactId> + <version>${maven-site-plugin.version}</version> + <dependencies> + <dependency><!-- add support for ssh/scp --> + <groupId>org.apache.maven.wagon</groupId> + <artifactId>wagon-ssh</artifactId> + <version>${wagon-ssh.version}</version> + </dependency> + <dependency> + <groupId>org.apache.maven.doxia</groupId> + <artifactId>doxia-module-markdown</artifactId> + <version>1.8</version> + </dependency> + </dependencies> + </plugin> + <plugin> + <groupId>org.apache.felix</groupId> + <artifactId>maven-bundle-plugin</artifactId> + <version>${maven-bundle-plugin.version}</version> + </plugin> + <plugin> Review comment: removed the checkstyle plugin as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org