Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836039056
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Do you mean file path separator in test case? I also have this doubts but
the other use cases I refer to in this file are like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by github-actions[bot]). Head commit for run: 06631368834ae81da1f87d5a6a2459eddcf09fca / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11771023289 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8906] Handle string toUpperCase outside the loop [rocketmq]
mawen12 opened a new pull request, #8907: URL: https://github.com/apache/rocketmq/pull/8907 ### Which Issue(s) This PR Fixes Fixes #8906 ### Brief Description Handle string toUpperCase outside the loop ### How Did You Test This Change? No test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Handle string toUpperCase outside the loop [rocketmq]
mawen12 opened a new issue, #8906: URL: https://github.com/apache/rocketmq/issues/8906 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary The variable authMode has no relations with foreach, it just call the `toUpperCase` method, so i think handle it outside the loop is better. ### Motivation authMode doesn't need to repeat call `toUpperCase`, it only need to be called once. ### Describe the Solution You'd Like Handle string toUpperCase outside the loop ### Describe Alternatives You've Considered No. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836004799
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> The UTs also need to be modified accordingly.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> Sorry, it was my oversight. I have modified it as required. Please review
it again. Thank you.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by hexueyuan). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11773144534 With regards, GitHub Actions via GitBox
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836004799
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> The UTs also need to be modified accordingly.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 06631368834ae81da1f87d5a6a2459eddcf09fca / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11771023300 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 06631368834ae81da1f87d5a6a2459eddcf09fca / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11771023289 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11770723582 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11770723587 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 6b072f393f4b32fe9c61aca298c5c8ceea56d16e / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11753923866 With regards, GitHub Actions via GitBox
Re: [I] [Bug] proxy local mode send message failed [rocketmq]
dyrnq commented on issue #8904: URL: https://github.com/apache/rocketmq/issues/8904#issuecomment-2467170456 > 那现在的问题就是，客户端从proxy获取路由报错，Message type is not specified，是不是proxy提供的获取路由接口存在问题？期望是，proxy会返回全量的topicRoute，并且返回内容可以被客户端正确解析。 这样比较好 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 6b072f393f4b32fe9c61aca298c5c8ceea56d16e / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11753923855 With regards, GitHub Actions via GitBox
Re: [I] [Bug] proxy local mode send message failed [rocketmq]
dyrnq commented on issue #8904: URL: https://github.com/apache/rocketmq/issues/8904#issuecomment-2467145811 确实如此了，那得要求client自行判断了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fixed typo of RocketMQ_Example.md [rocketmq]
RongtongJin merged PR #8905: URL: https://github.com/apache/rocketmq/pull/8905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Run Integration Tests" failed!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 6b072f393f4b32fe9c61aca298c5c8ceea56d16e / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11753923914 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by hexueyuan). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11770741566 With regards, GitHub Actions via GitBox
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835886913
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Sorry, it was my oversight. I have modified it as required. Please review it
again. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(rocketmq) branch develop updated: fixed typo of RocketMQ_Example.md (#8905)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 7eb16fffec fixed typo of RocketMQ_Example.md (#8905) 7eb16fffec is described below commit 7eb16fffec6bf7f118e3373df48e76c7647eb348 Author: TianMing2018 <2452146...@qq.com> AuthorDate: Mon Nov 11 10:00:26 2024 +0800 fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' --- docs/cn/RocketMQ_Example.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cn/RocketMQ_Example.md b/docs/cn/RocketMQ_Example.md index 4f08e88154..77c1bd7b27 100644 --- a/docs/cn/RocketMQ_Example.md +++ b/docs/cn/RocketMQ_Example.md @@ -645,7 +645,7 @@ RocketMQ只定义了一些基本语法来支持这个特性。你也可以很容 只有使用push模式的消费者才能用使用SQL92标准的sql语句，接口如下： ``` -public void subscribe(finalString topic, final MessageSelector messageSelector) +public void subscribe(final String topic, final MessageSelector messageSelector) ``` ### 5.2 使用样例
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by RongtongJin). Head commit for run: 6b072f393f4b32fe9c61aca298c5c8ceea56d16e / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11753923879 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Run Integration Tests" is working again!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11770723580 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hexueyuan (triggered by github-actions[bot]). Head commit for run: 6b072f393f4b32fe9c61aca298c5c8ceea56d16e / hexueyuan Fix duplicate mapped file in mutil commitlog store path mode. Report URL: https://github.com/apache/rocketmq/actions/runs/11753923866 With regards, GitHub Actions via GitBox
Re: [I] [Bug] proxy local mode send message failed [rocketmq]
VictoryAnn commented on issue #8904: URL: https://github.com/apache/rocketmq/issues/8904#issuecomment-2467074172 > * https://github.com/apache/rocketmq/tree/develop/proxy#cluster-mode > * https://github.com/apache/rocketmq/tree/develop/proxy#local-mode > > 看以上2图,能看出点端倪来 这个图有点疑问，就是client需要先获取所有topic路由，用了proxy和broker 同一个进程的话，获取到的路由地址会被proxy替换成proxy的端口，然后根据对应topic所在的proxy，客户端会选择对应的proxy地址去send message。但是现状看起来是客户端获取topic路由的时候，由于topic不在当前broker上，导致路由信息返回的message type 为 0，客户端获取不到topic路由。  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835870473
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
The UTs also need to be modified accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] proxy local mode send message failed [rocketmq]
VictoryAnn commented on issue #8904: URL: https://github.com/apache/rocketmq/issues/8904#issuecomment-2467153290 那现在的问题就是，客户端从proxy获取路由报错，Message type is not specified，是不是proxy提供的获取路由接口存在问题？期望是，proxy会返回全量的topicRoute，并且返回内容可以被客户端正确解析。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11770723579 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user mawen12 (triggered by mawen12). Head commit for run: 7eb16fffec6bf7f118e3373df48e76c7647eb348 / TianMing2018 <2452146...@qq.com> fixed typo of RocketMQ_Example.md (#8905) fixed typo worlds 'finalString' Report URL: https://github.com/apache/rocketmq/actions/runs/11773841665 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Java Coverage" failed!
The GitHub Actions job "Java Coverage" on rocketmq-clients.git has failed. Run started by GitHub user qianye1001 (triggered by lollipopjin). Head commit for run: cb596f242b4cffa1d3cc30edc4c89d86486ad374 / qianye f Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11695958526 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8906] Handle string toUpperCase outside the loop [rocketmq]
codecov-commenter commented on PR #8907: URL: https://github.com/apache/rocketmq/pull/8907#issuecomment-2467434591 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8907?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `50.0%` with `2 lines` in your changes missing coverage. Please review. > Project coverage is 47.52%. Comparing base [(`7eb16ff`)](https://app.codecov.io/gh/apache/rocketmq/commit/7eb16fffec6bf7f118e3373df48e76c7647eb348?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6883fb5`)](https://app.codecov.io/gh/apache/rocketmq/commit/6883fb509c7dd260e23fcdeacca43e3381d90864?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8907?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ocketmq/proxy/remoting/MultiProtocolTlsHelper.java](https://app.codecov.io/gh/apache/rocketmq/pull/8907?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fremoting%2FMultiProtocolTlsHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL011bHRpUHJvdG9jb2xUbHNIZWxwZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8907?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8907 +/- ## = - Coverage 47.54% 47.52% -0.03% - Complexity 1172811732 +4 = Files 1304 1304 Lines 9105691058 +2 Branches 1167711677 = - Hits 4329743276 -21 - Misses 4240942441 +32 + Partials5350 5341 -9 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8907?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
