RongtongJin commented on code in PR #8897: URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836004799
########## store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java: ########## @@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String nextFilePath, String next canSubmitRequests--; } + String nextNextFileName = nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1); Review Comment: > The UTs also need to be modified accordingly. By the way, is there any compatibility issue here? From the code, it seems that there isn't. ########## store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java: ########## @@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String nextFilePath, String next canSubmitRequests--; } + String nextNextFileName = nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1); Review Comment: > Sorry, it was my oversight. I have modified it as required. Please review it again. Thank you. By the way, is there any compatibility issue here? From the code, it seems that there isn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org