Re: [PR] [ISSUE #7785] Remove the redundant code [rocketmq]
RongtongJin merged PR #7784: URL: https://github.com/apache/rocketmq/pull/7784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Remove the redundant code [rocketmq]
RongtongJin closed issue #7785: [Enhancement] Remove the redundant code URL: https://github.com/apache/rocketmq/issues/7785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7785] Remove the redundant code
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new e104273fd0 [ISSUE #7785] Remove the redundant code
e104273fd0 is described below
commit e104273fd03b85a59b7d3fc991a214a8e41e0778
Author: wyyl1 <289460...@qq.com>
AuthorDate: Sun Jan 28 20:06:18 2024 +0800
[ISSUE #7785] Remove the redundant code
---
.../java/org/apache/rocketmq/client/common/ThreadLocalIndex.java | 3 ---
.../org/apache/rocketmq/client/common/ThreadLocalIndexTest.java| 7 +++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
index 3a086c13df..c15cdbfadb 100644
---
a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
+++
b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
@@ -35,9 +35,6 @@ public class ThreadLocalIndex {
public void reset() {
int index = Math.abs(random.nextInt(Integer.MAX_VALUE));
-if (index < 0) {
-index = 0;
-}
this.threadLocalIndex.set(index);
}
diff --git
a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
index 94f02abaae..87a71df92b 100644
---
a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
+++
b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
@@ -51,4 +51,11 @@ public class ThreadLocalIndexTest {
assertThat(initialVal >= 0).isTrue();
}
+@Test
+public void testResultOfResetIsGreaterThanOrEqualToZero() {
+ThreadLocalIndex localIndex = new ThreadLocalIndex();
+localIndex.reset();
+assertThat(localIndex.incrementAndGet() > 0).isTrue();
+}
+
}
\ No newline at end of file
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: e104273fd03b85a59b7d3fc991a214a8e41e0778 / wyyl1 <289460...@qq.com> [ISSUE #7785] Remove the redundant code Report URL: https://github.com/apache/rocketmq/actions/runs/7685573115 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: e104273fd03b85a59b7d3fc991a214a8e41e0778 / wyyl1 <289460...@qq.com> [ISSUE #7785] Remove the redundant code Report URL: https://github.com/apache/rocketmq/actions/runs/7685573106 With regards, GitHub Actions via GitBox
[I] [Enhancement] Refactor AllocateMachineRoomNearby [rocketmq]
wyyl1 opened a new issue, #7788: URL: https://github.com/apache/rocketmq/issues/7788 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Refactor ### Motivation Make the code better and better ### Describe the Solution You'd Like 1. Consistency in abstraction levels 2. Use method names instead of comments 3. Make the code more concise: inline the result returned by a successful condition into a block of code. AllocateMachineRoomNearByTest ran successfully ### Describe Alternatives You've Considered none ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Refactor AllocateMachineRoomNearby [rocketmq]
wyyl1 opened a new pull request, #7789: URL: https://github.com/apache/rocketmq/pull/7789 ### Which Issue(s) This PR Fixes Refactor Fixes #7788 ### Brief Description 1. Consistency in abstraction levels 2. Use method names instead of comments 3. Make the code more concise: inline the result returned by a successful condition into a block of code ### How Did You Test This Change? AllocateMachineRoomNearByTest ran successfully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user wyyl1 (triggered by wyyl1). Head commit for run: 9ad51795d007bafc9df7234cc040212ffe5caf7b / wyyl1 <289460...@qq.com> Refactor AllocateMachineRoomNearby 1. Consistency in abstraction levels 2. Use method names instead of comments 3. Make the code more concise: inline the result returned by a successful condition into a block of code. Report URL: https://github.com/apache/rocketmq/actions/runs/7686535690 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user wyyl1 (triggered by wyyl1). Head commit for run: e104273fd03b85a59b7d3fc991a214a8e41e0778 / wyyl1 <289460...@qq.com> [ISSUE #7785] Remove the redundant code Report URL: https://github.com/apache/rocketmq/actions/runs/7686544219 With regards, GitHub Actions via GitBox
Re: [PR] Refactor AllocateMachineRoomNearby [rocketmq]
codecov-commenter commented on PR #7789: URL: https://github.com/apache/rocketmq/pull/7789#issuecomment-1913631662 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `1 lines` in your changes are missing coverage. Please review. > Comparison is base [(`e104273`)](https://app.codecov.io/gh/apache/rocketmq/commit/e104273fd03b85a59b7d3fc991a214a8e41e0778?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.25% compared to head [(`9ad5179`)](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.27%. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../consumer/rebalance/AllocateMachineRoomNearby.java](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWFjaGluZVJvb21OZWFyYnkuamF2YQ==) | 95.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7789 +/- ## = + Coverage 43.25% 43.27% +0.02% - Complexity 9880 9888 +8 = Files 1173 1173 Lines 8504785058 +11 Branches 1101411012 -2 = + Hits 3678836811 +23 + Misses 4369243681 -11 + Partials4567 4566 -1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7789?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Replace assertThat instanceof with assertThat#instanceOf in test case [rocketmq]
github-actions[bot] commented on issue #5938: URL: https://github.com/apache/rocketmq/issues/5938#issuecomment-1913771538 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] test case missing on dledger mode on consume queue [rocketmq]
github-actions[bot] commented on issue #5937: URL: https://github.com/apache/rocketmq/issues/5937#issuecomment-1913771554 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5933]Fix LocalTransactionState enum attribute typo [rocketmq]
github-actions[bot] commented on PR #5934: URL: https://github.com/apache/rocketmq/pull/5934#issuecomment-1913771567 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Fix LocalTransactionState enum attribute typo [rocketmq]
github-actions[bot] commented on issue #5933: URL: https://github.com/apache/rocketmq/issues/5933#issuecomment-1913771585 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5914]Remove BrokerStatsManager class deprecated and useless attributes [rocketmq]
github-actions[bot] commented on PR #5915: URL: https://github.com/apache/rocketmq/pull/5915#issuecomment-1913771621 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Remove MessageDecoder class useless attributes [rocketmq]
github-actions[bot] commented on issue #5911: URL: https://github.com/apache/rocketmq/issues/5911#issuecomment-1913771652 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5937] test: add test case for dledger on consume queue [rocketmq]
github-actions[bot] commented on PR #5910: URL: https://github.com/apache/rocketmq/pull/5910#issuecomment-1913771678 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [RIP-29] Optimize RocketMQ NameServer [rocketmq]
github-actions[bot] commented on issue #3792: URL: https://github.com/apache/rocketmq/issues/3792#issuecomment-1913771704 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (golang) give a random index for NewSubscriptionLoadBalancer [rocketmq-clients]
github-actions[bot] commented on PR #657: URL: https://github.com/apache/rocketmq-clients/pull/657#issuecomment-1913776195 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (golang) give a random index for NewSubscriptionLoadBalancer [rocketmq-clients]
github-actions[bot] closed pull request #657: (golang) give a random index for NewSubscriptionLoadBalancer URL: https://github.com/apache/rocketmq-clients/pull/657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Use SimpleConsumer there will always be some messages that cannot be pulled [rocketmq-clients]
github-actions[bot] commented on issue #655: URL: https://github.com/apache/rocketmq-clients/issues/655#issuecomment-1913776210 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Use SimpleConsumer there will always be some messages that cannot be pulled [rocketmq-clients]
github-actions[bot] closed issue #655: [Bug] Use SimpleConsumer there will always be some messages that cannot be pulled URL: https://github.com/apache/rocketmq-clients/issues/655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7777]Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization [rocketmq]
RongtongJin merged PR #7778: URL: https://github.com/apache/rocketmq/pull/7778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7777] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new a0cb9d42e3 [ISSUE #] Optimize the logic of
DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization
(#7778)
a0cb9d42e3 is described below
commit a0cb9d42e3bc78fb9d931aed370a738cb17d992f
Author: mxsm
AuthorDate: Mon Jan 29 08:34:29 2024 +0800
[ISSUE #] Optimize the logic of
DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization
(#7778)
---
.../namesrv/processor/DefaultRequestProcessor.java | 25 +++---
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
index 2daa95b9bc..deb51e4fc1 100644
---
a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
+++
b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
@@ -366,7 +366,7 @@ public class DefaultRequestProcessor implements
NettyRequestProcessor {
}
public RemotingCommand unregisterBroker(ChannelHandlerContext ctx,
-RemotingCommand request) throws RemotingCommandException {
+RemotingCommand request) throws RemotingCommandException {
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
final UnRegisterBrokerRequestHeader requestHeader =
(UnRegisterBrokerRequestHeader)
request.decodeCommandCustomHeader(UnRegisterBrokerRequestHeader.class);
@@ -387,7 +387,6 @@ public class DefaultRequestProcessor implements
NettyRequestProcessor {
final BrokerHeartbeatRequestHeader requestHeader =
(BrokerHeartbeatRequestHeader)
request.decodeCommandCustomHeader(BrokerHeartbeatRequestHeader.class);
-
this.namesrvController.getRouteInfoManager().updateBrokerInfoUpdateTimestamp(requestHeader.getClusterName(),
requestHeader.getBrokerAddr());
response.setCode(ResponseCode.SUCCESS);
@@ -522,21 +521,21 @@ public class DefaultRequestProcessor implements
NettyRequestProcessor {
private RemotingCommand getTopicsByCluster(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
-final GetTopicsByClusterRequestHeader requestHeader =
-(GetTopicsByClusterRequestHeader)
request.decodeCommandCustomHeader(GetTopicsByClusterRequestHeader.class);
-
boolean enableTopicList =
namesrvController.getNamesrvConfig().isEnableTopicList();
-if (enableTopicList) {
-TopicList topicsByCluster =
this.namesrvController.getRouteInfoManager().getTopicsByCluster(requestHeader.getCluster());
-byte[] body = topicsByCluster.encode();
-
-response.setBody(body);
-response.setCode(ResponseCode.SUCCESS);
-response.setRemark(null);
-} else {
+if (!enableTopicList) {
response.setCode(ResponseCode.SYSTEM_ERROR);
response.setRemark("disable");
+return response;
}
+final GetTopicsByClusterRequestHeader requestHeader =
+(GetTopicsByClusterRequestHeader)
request.decodeCommandCustomHeader(GetTopicsByClusterRequestHeader.class);
+
+TopicList topicsByCluster =
this.namesrvController.getRouteInfoManager().getTopicsByCluster(requestHeader.getCluster());
+byte[] body = topicsByCluster.encode();
+
+response.setBody(body);
+response.setCode(ResponseCode.SUCCESS);
+response.setRemark(null);
return response;
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a0cb9d42e3bc78fb9d931aed370a738cb17d992f / mxsm [ISSUE #] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778) Report URL: https://github.com/apache/rocketmq/actions/runs/7689518926 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization [rocketmq]
RongtongJin closed issue #: [Enhancement] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization URL: https://github.com/apache/rocketmq/issues/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user sevenleave (triggered by RongtongJin). Head commit for run: 54e28b62ebc1eb6168e93046c7cf1651b0032c33 / poirot <1400289...@qq.com> fix: 判断JAVA_HOME逻辑提前 Report URL: https://github.com/apache/rocketmq/actions/runs/7666397428 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7740] Optimize LocalFileOffsetStore [rocketmq]
RongtongJin merged PR #7745: URL: https://github.com/apache/rocketmq/pull/7745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch 4.9.x updated: [ISSUE #7740] Optimize LocalFileOffsetStore (#7745)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch 4.9.x
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/4.9.x by this push:
new 99bb415db4 [ISSUE #7740] Optimize LocalFileOffsetStore (#7745)
99bb415db4 is described below
commit 99bb415db46796a16205a6747f0627cc88178835
Author: Liu Shengzhong
AuthorDate: Mon Jan 29 08:50:43 2024 +0800
[ISSUE #7740] Optimize LocalFileOffsetStore (#7745)
* Fix LocalFileOffsetStore persistAll and persist
* Fix LocalFileOffsetStore removeOffset
* Add test case
---
.../consumer/store/LocalFileOffsetStore.java | 45 --
.../consumer/store/LocalFileOffsetStoreTest.java | 45 ++
2 files changed, 87 insertions(+), 3 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java
b/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java
index f949b75a81..0fbe8010db 100644
---
a/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java
+++
b/client/src/main/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStore.java
@@ -131,10 +131,20 @@ public class LocalFileOffsetStore implements OffsetStore {
@Override
public void persistAll(Set mqs) {
-if (null == mqs || mqs.isEmpty())
+if (null == mqs || mqs.isEmpty()) {
return;
+}
+OffsetSerializeWrapper offsetSerializeWrapper = null;
+try {
+offsetSerializeWrapper = readLocalOffset();
+} catch (MQClientException e) {
+log.error("readLocalOffset exception", e);
+return;
+}
-OffsetSerializeWrapper offsetSerializeWrapper = new
OffsetSerializeWrapper();
+if (offsetSerializeWrapper == null) {
+offsetSerializeWrapper = new OffsetSerializeWrapper();
+}
for (Map.Entry entry :
this.offsetTable.entrySet()) {
if (mqs.contains(entry.getKey())) {
AtomicLong offset = entry.getValue();
@@ -154,11 +164,40 @@ public class LocalFileOffsetStore implements OffsetStore {
@Override
public void persist(MessageQueue mq) {
+if (mq == null) {
+return;
+}
+AtomicLong offset = this.offsetTable.get(mq);
+if (offset != null) {
+OffsetSerializeWrapper offsetSerializeWrapper = null;
+try {
+offsetSerializeWrapper = readLocalOffset();
+} catch (MQClientException e) {
+log.error("readLocalOffset exception", e);
+return;
+}
+if (offsetSerializeWrapper == null) {
+offsetSerializeWrapper = new OffsetSerializeWrapper();
+}
+offsetSerializeWrapper.getOffsetTable().put(mq, offset);
+String jsonString = offsetSerializeWrapper.toJson(true);
+if (jsonString != null) {
+try {
+MixAll.string2File(jsonString, this.storePath);
+} catch (IOException e) {
+log.error("persist consumer offset exception, " +
this.storePath, e);
+}
+}
+}
}
@Override
public void removeOffset(MessageQueue mq) {
-
+if (mq != null) {
+this.offsetTable.remove(mq);
+log.info("remove unnecessary messageQueue offset. group={}, mq={},
offsetTableSize={}", this.groupName, mq,
+offsetTable.size());
+}
}
@Override
diff --git
a/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java
b/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java
index a705b30fc3..e3f2cc070d 100644
---
a/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java
+++
b/client/src/test/java/org/apache/rocketmq/client/consumer/store/LocalFileOffsetStoreTest.java
@@ -17,6 +17,7 @@
package org.apache.rocketmq.client.consumer.store;
import java.io.File;
+import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
import java.util.Map;
@@ -85,4 +86,48 @@ public class LocalFileOffsetStoreTest {
assertThat(cloneOffsetTable.size()).isEqualTo(1);
assertThat(cloneOffsetTable.get(messageQueue)).isEqualTo(1024);
}
+
+@Test
+public void testPersist() throws Exception {
+OffsetStore offsetStore = new LocalFileOffsetStore(mQClientFactory,
group);
+
+MessageQueue messageQueue0 = new MessageQueue(topic, brokerName, 0);
+offsetStore.updateOffset(messageQueue0, 1024, false);
+offsetStore.persist(messageQueue0);
+assertThat(offsetStore.readOffset(messageQueue0,
ReadOffsetType.READ_FROM_STORE)).isEqualTo(1024);
+
+
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a0cb9d42e3bc78fb9d931aed370a738cb17d992f / mxsm [ISSUE #] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778) Report URL: https://github.com/apache/rocketmq/actions/runs/7689518929 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #5613] Change the broker default value configuration of 'useSe… [rocketmq]
RongtongJin commented on PR #7581: URL: https://github.com/apache/rocketmq/pull/7581#issuecomment-1913791416 Hi @yp969803 could you help to reslove the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user sevenleave (triggered by sevenleave). Head commit for run: a0cb9d42e3bc78fb9d931aed370a738cb17d992f / mxsm [ISSUE #] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778) Report URL: https://github.com/apache/rocketmq/actions/runs/7689570832 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a0cb9d42e3bc78fb9d931aed370a738cb17d992f / mxsm [ISSUE #] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778) Report URL: https://github.com/apache/rocketmq/actions/runs/7689518928 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user sevenleave (triggered by RongtongJin). Head commit for run: 54e28b62ebc1eb6168e93046c7cf1651b0032c33 / poirot <1400289...@qq.com> fix: 判断JAVA_HOME逻辑提前 Report URL: https://github.com/apache/rocketmq/actions/runs/7666397429 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment [rocketmq]
codecov-commenter commented on PR #7787: URL: https://github.com/apache/rocketmq/pull/7787#issuecomment-1913797052 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`3d357bb`)](https://app.codecov.io/gh/apache/rocketmq/commit/3d357bb3ed4dcee38cdde9b1525b15226820321a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.29% compared to head [(`54e28b6`)](https://app.codecov.io/gh/apache/rocketmq/pull/7787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.27%. > Report is 2 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7787 +/- ## = - Coverage 43.29% 43.27% -0.02% + Complexity 9886 9878 -8 = Files 1173 1173 Lines 8504985049 Branches 1101511015 = - Hits 3681936804 -15 - Misses 4365843678 +20 + Partials4572 4567 -5 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7787?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: a0cb9d42e3bc78fb9d931aed370a738cb17d992f / mxsm [ISSUE #] Optimize the logic of DefaultRequestProcessor#getTopicsByCluster to avoid unnecessary deserialization (#7778) Report URL: https://github.com/apache/rocketmq/actions/runs/7689518931 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user sevenleave (triggered by RongtongJin). Head commit for run: 54e28b62ebc1eb6168e93046c7cf1651b0032c33 / poirot <1400289...@qq.com> fix: 判断JAVA_HOME逻辑提前 Report URL: https://github.com/apache/rocketmq/actions/runs/7666397447 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment [rocketmq]
RongtongJin merged PR #7787: URL: https://github.com/apache/rocketmq/pull/7787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The find_java_home function of tools.sh reports an error in the JRE environment [rocketmq]
RongtongJin closed issue #7786: [Bug] The find_java_home function of tools.sh reports an error in the JRE environment URL: https://github.com/apache/rocketmq/issues/7786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 178421386f [ISSUE #7786] Optimize the execution logic of tool.sh in
the JRE environment
178421386f is described below
commit 178421386f728f0320bad550e965b74a0b088d40
Author: Poirot Hercule
AuthorDate: Mon Jan 29 09:40:19 2024 +0800
[ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment
---
distribution/bin/tools.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/distribution/bin/tools.sh b/distribution/bin/tools.sh
index d772465a3d..9b1e1d804d 100644
--- a/distribution/bin/tools.sh
+++ b/distribution/bin/tools.sh
@@ -26,12 +26,12 @@ error_exit ()
find_java_home()
{
+if [ -n "$JAVA_HOME" ]; then
+JAVA_HOME=$JAVA_HOME
+return
+fi
case "`uname`" in
Darwin)
- if [ -n "$JAVA_HOME" ]; then
- JAVA_HOME=$JAVA_HOME
- return
- fi
JAVA_HOME=$(/usr/libexec/java_home)
;;
*)
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690002620 With regards, GitHub Actions via GitBox
Re: [PR] lock.lock() before try [rocketmq]
shenjianeng commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1913821428 resolved conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690002622 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690002621 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user shenjianeng (triggered by RongtongJin). Head commit for run: 17259ae34d3f17f28bc956f97fb9dbcd650f19be / shenjianeng Merge remote-tracking branch 'origin/develop' into lock # Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java Report URL: https://github.com/apache/rocketmq/actions/runs/7690008745 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 552b0498d8787c56caf4fa691d53ee5792adf24c / RongtongJin Pass the code check style Report URL: https://github.com/apache/rocketmq/actions/runs/7690388841 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: b1886029c6cf9e287f71e68efe5128da3b0b / RongtongJin Merge remote-tracking branch 'apache/develop' into issue#5613 Report URL: https://github.com/apache/rocketmq/actions/runs/7690442053 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user shenjianeng (triggered by shenjianeng). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690359283 With regards, GitHub Actions via GitBox
Re: [PR] lock.lock() before try [rocketmq]
codecov-commenter commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1913870110 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `10 lines` in your changes are missing coverage. Please review. > Comparison is base [(`e104273`)](https://app.codecov.io/gh/apache/rocketmq/commit/e104273fd03b85a59b7d3fc991a214a8e41e0778?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.25% compared to head [(`17259ae`)](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.26%. > Report is 2 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | 61.11% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tmq/namesrv/processor/DefaultRequestProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | 77.77% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/rocketmq/client/impl/MQAdminImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUFkbWluSW1wbC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7582 +/- ## = + Coverage 43.25% 43.26% +0.01% - Complexity 9880 9884 +4 = Files 1173 1173 Lines 8504785049 +2 Branches 1101411014 = + Hits 3678836799 +11 + Misses 4369243685 -7 + Partials4567 4565 -2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7582?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690405662 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 178421386f728f0320bad550e965b74a0b088d40 / Poirot Hercule [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Report URL: https://github.com/apache/rocketmq/actions/runs/7690459646 With regards, GitHub Actions via GitBox
Re: [PR] add config of maxFilterMessageSize [rocketmq]
codecov-commenter commented on PR #7447: URL: https://github.com/apache/rocketmq/pull/7447#issuecomment-1913874102 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `14 lines` in your changes are missing coverage. Please review. > Comparison is base [(`4acb43e`)](https://app.codecov.io/gh/apache/rocketmq/commit/4acb43ecee03e429d036e3ff4c28bd402d1b30c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.68% compared to head [(`552b049`)](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.31%. > Report is 90 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/rocketmq/common/message/Message.java](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlLmphdmE=) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/rocketmq/store/config/MessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7447 +/- ## = + Coverage 42.68% 43.31% +0.63% - Complexity 9477 9888 +411 = Files 1150 1173 +23 Lines 8281485051+2237 Branches 1076811014 +246 = + Hits 3534636841+1495 - Misses 4304543647 +602 - Partials4423 4563 +140 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user shenjianeng (triggered by RongtongJin). Head commit for run: 17259ae34d3f17f28bc956f97fb9dbcd650f19be / shenjianeng Merge remote-tracking branch 'origin/develop' into lock # Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java Report URL: https://github.com/apache/rocketmq/actions/runs/7690008747 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: b1886029c6cf9e287f71e68efe5128da3b0b / RongtongJin Merge remote-tracking branch 'apache/develop' into issue#5613 Report URL: https://github.com/apache/rocketmq/actions/runs/7690442049 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 552b0498d8787c56caf4fa691d53ee5792adf24c / RongtongJin Pass the code check style Report URL: https://github.com/apache/rocketmq/actions/runs/7690388851 With regards, GitHub Actions via GitBox
[I] [Bug] Master broker in Dledger mode didn't sync consume offset in time after reboot, which caused consume repeatedly [rocketmq]
bxfjb opened a new issue, #7790: URL: https://github.com/apache/rocketmq/issues/7790 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment CentOS Linux release 7.3.1611 ### RocketMQ version 4.8.0 ### JDK Version 1.8 ### Describe the Bug In dledger mode, master broker which was shut down and reboot would not synchornize consume offset with the previous temporary master broker. The problem described may caused repeatedly consumption. After reading code, one bug may exist in the synchornize logic: BrokerController.java:  The oneway flag is set true, which means that following code in BrokerOuterAPI@registerBrokerAll will return null without waiting for the result:  which caused the following marked code didn't run actually:  Masteraddr which is null leads to a result that SlaveSynchronize@syncAll didnt't run either, including function body of SlaveSynchronize@syncConsumerOffset:  The Synchronization task was set to run every 10 seconds , but before next sync happens, the reboot broker was elected to be master again already, which means it stopped to try to get the newest consume offset, but start to push messsages from the offset before.  ### Steps to Reproduce * Run a cluster in dledger mode. * Shut down master broker gracefully. * Reboot previous master broker, be sure that consume offset increases during downtime. * Repeat consumption should be observed. ### What Did You Expect to See? Rebooted broker should synchornize the newest consume offset and consume from it correctly. ### What Did You See Instead? Abnormal repeated consumption. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Is python client development going well? [rocketmq-clients]
ma-pony opened a new issue, #678: URL: https://github.com/apache/rocketmq-clients/issues/678 ### Programming Language of the Client Java ### Is Your Feature Request Related to a Problem? I've noticed that rockertmq-clients/python code hasn't been updated in 5 months, is development still going well and is there anything i can do help. I'm planning to use rocketmq in a python project. ### Describe the Solution You'd Like null ### Describe Alternatives You've Considered null ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Integration test testEstimateLag can not pass [rocketmq]
UWE commented on issue #7765: URL: https://github.com/apache/rocketmq/issues/7765#issuecomment-1914013976 I cannot reproduce testEstimateLag's test failure unless it fails when my disk space is less than 10% causing the DefaultMessageStore.isSpaceToDelete() function to trigger the file to be deleted. So sir, does your question refer to this? 刘家辉 ***@***.*** -- 原始邮件 -- 发件人: ***@***.***>; 发送时间: 2024年1月27日(星期六) 晚上11:15 收件人: ***@***.***>; 抄送: ***@***.***>; ***@***.***>; 主题: Re: [apache/rocketmq] [Enhancement] Integration test testEstimateLag can not pass (Issue #7765) This issue is related to the 'develop' branch, right? I couldn't reproduce the test failure in the 5.1.4 branch. Has it been completed? I would also like to give it a try. This issue is related to the 'develop' branch, right? I couldn't reproduce the test failure in the 5.1.4 branch. Yes, in develop branch. You can submit a PR to fix it. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Integration test testEstimateLag can not pass [rocketmq]
UWE commented on issue #7765: URL: https://github.com/apache/rocketmq/issues/7765#issuecomment-1914015754 > > This issue is related to the 'develop' branch, right? I couldn't reproduce the test failure in the 5.1.4 branch. > > > Has it been completed? I would also like to give it a try. > > > > > > This issue is related to the 'develop' branch, right? I couldn't reproduce the test failure in the 5.1.4 branch. > > Yes, in develop branch. You can submit a PR to fix it. I cannot reproduce testEstimateLag's test failure unless it fails when my disk space is less than 10% causing the DefaultMessageStore.isSpaceToDelete() function to trigger the file to be deleted. So sir, does your question refer to this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Can it support Spring Framework 6.0+ ？ it's a trend [rocketmq-spring]
dazer007 commented on issue #568: URL: https://github.com/apache/rocketmq-spring/issues/568#issuecomment-1914086586 Is there a plan to release a version that is compatible with Springboot 3？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 配置文件不能自动装配RocketMQAutoConfiguration [rocketmq-spring]
dazer007 commented on issue #609: URL: https://github.com/apache/rocketmq-spring/issues/609#issuecomment-1914087316 Is there a plan to release a version that is compatible with Springboot 3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
