This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new e104273fd0 [ISSUE #7785] Remove the redundant code
e104273fd0 is described below

commit e104273fd03b85a59b7d3fc991a214a8e41e0778
Author: wyyl1 <289460...@qq.com>
AuthorDate: Sun Jan 28 20:06:18 2024 +0800

    [ISSUE #7785] Remove the redundant code
---
 .../java/org/apache/rocketmq/client/common/ThreadLocalIndex.java   | 3 ---
 .../org/apache/rocketmq/client/common/ThreadLocalIndexTest.java    | 7 +++++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java 
b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
index 3a086c13df..c15cdbfadb 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/common/ThreadLocalIndex.java
@@ -35,9 +35,6 @@ public class ThreadLocalIndex {
 
     public void reset() {
         int index = Math.abs(random.nextInt(Integer.MAX_VALUE));
-        if (index < 0) {
-            index = 0;
-        }
         this.threadLocalIndex.set(index);
     }
 
diff --git 
a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
 
b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
index 94f02abaae..87a71df92b 100644
--- 
a/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
+++ 
b/client/src/test/java/org/apache/rocketmq/client/common/ThreadLocalIndexTest.java
@@ -51,4 +51,11 @@ public class ThreadLocalIndexTest {
         assertThat(initialVal >= 0).isTrue();
     }
 
+    @Test
+    public void testResultOfResetIsGreaterThanOrEqualToZero() {
+        ThreadLocalIndex localIndex = new ThreadLocalIndex();
+        localIndex.reset();
+        assertThat(localIndex.incrementAndGet() > 0).isTrue();
+    }
+
 }
\ No newline at end of file

Reply via email to