Re: [I] [Bugs]auto-bach cause some bugs [rocketmq]
francisoliverlee commented on issue #7764: URL: https://github.com/apache/rocketmq/issues/7764#issuecomment-1902554384 can you show your producer and consumer code, and their client version pls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Check message size before message compression [rocketmq]
francisoliverlee commented on issue #7758:
URL: https://github.com/apache/rocketmq/issues/7758#issuecomment-1902566721
## Client's config key=maxMessageSize checked in
Validators.checkMessage(msg, this.defaultMQProducer);
```java
if (msg.getBody().length > defaultMQProducer.getMaxMessageSize()) {
throw new MQClientException(ResponseCode.MESSAGE_ILLEGAL,
"the message body size over max value, MAX: " +
defaultMQProducer.getMaxMessageSize());
}
```
- sync send one message, do body size check
- async send one message, do body size check
- sync send batch message, do 2 checks
- do every message body check
- do all message's body size check
- async send one message, do 2 checks
- do every message body check
- do all message's body size check
## Proxy check message body size
## Broker not check message size
## Store's config key=maxMessageSize checked in MessageExtEncoder.encode()
WITH 2 checks
- body check
- header + body check
> at 5.1.4 delay check message is about (header + body), but send to broke
is only body. is also a problem.
i found some size checks here but no delay message check, can you pls give
out the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(rocketmq-clients) branch java_release_5.0.6 created (now 793bba47)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git at 793bba47 [maven-release-plugin] prepare release java-5.0.6 This branch includes the following new commits: new 793bba47 [maven-release-plugin] prepare release java-5.0.6 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(rocketmq-clients) 01/01: [maven-release-plugin] prepare release java-5.0.6
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a commit to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git commit 793bba4793853c6ccbe4645bae87b27ee1f0923d Author: tigerlee AuthorDate: Sun Jan 21 20:43:56 2024 +0800 [maven-release-plugin] prepare release java-5.0.6 --- java/client-apis/pom.xml | 2 +- java/client-shade/pom.xml | 2 +- java/client/pom.xml | 2 +- java/pom.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/java/client-apis/pom.xml b/java/client-apis/pom.xml index 59ec9ab4..9ac0fd07 100644 --- a/java/client-apis/pom.xml +++ b/java/client-apis/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/client-shade/pom.xml b/java/client-shade/pom.xml index f08678b1..08866a23 100644 --- a/java/client-shade/pom.xml +++ b/java/client-shade/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/client/pom.xml b/java/client/pom.xml index 4df99484..875ba96d 100644 --- a/java/client/pom.xml +++ b/java/client/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/pom.xml b/java/pom.xml index d39b7094..501aa047 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -26,7 +26,7 @@ org.apache.rocketmq rocketmq-client-java-parent pom -5.0.6-SNAPSHOT +5.0.6 client-apis client @@ -394,6 +394,6 @@ g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git -HEAD +java-5.0.6 \ No newline at end of file
Re: [PR] [maven-release-plugin] prepare release java-5.0.6 [rocketmq-clients]
codecov-commenter commented on PR #672: URL: https://github.com/apache/rocketmq-clients/pull/672#issuecomment-1902618757 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9004405`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/90044056cee6eb009b70fb524077728d745057c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 55.89% compared to head [(`793bba4`)](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.12%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #672 +/- ## - Coverage 55.89% 47.12% -8.78% Complexity 668 668 Files 259 207 -52 Lines 1562712156-3471 Branches 3865 3513 -352 - Hits 8735 5728-3007 + Misses 6641 6177 -464 Partials251 251 ``` | [Flag](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.95% <ø> (ø)` | | | [nodejs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq-clients/pull/672?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Build docker image with maven failed [rocketmq-exporter]
caigy opened a new issue, #154: URL: https://github.com/apache/rocketmq-exporter/issues/154 **Describe the bug** Building docker image as instructions in document failed with output: ``` [ERROR] Failed to execute goal com.spotify:docker-maven-plugin:0.4.11:build (default-cli) on project rocketmq-exporter: Exception caught: ADD failed: file not found in build context or excluded by .dockerignore: stat rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar: file does not exist -> [Help 1] ``` **To Reproduce** Steps to reproduce the behavior: 1. Run ` mvn package -Dmaven.test.skip=true docker:build` 2. The building process will end with error. **Expected behavior** The docker image should be successfully created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-exporter) branch master updated: fix #154
This is an automated email from the ASF dual-hosted git repository.
caigy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git
The following commit(s) were added to refs/heads/master by this push:
new 7cc732e fix #154
7cc732e is described below
commit 7cc732e8c63b0315a4a89fb77e43255b1c4bb96f
Author: gaoyang.cgy
AuthorDate: Sun Jan 21 20:57:07 2024 +0800
fix #154
---
pom.xml| 6 +-
src/main/docker/Dockerfile | 4 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 7084b57..bdfbce9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -126,12 +126,16 @@
${docker.image.prefix}/${project.artifactId}
+
+${project.version}
+latest
+
src/main/docker
/
${project.build.directory}
-${project.build.finalName}.jar
+
${project.build.finalName}-exec.jar
diff --git a/src/main/docker/Dockerfile b/src/main/docker/Dockerfile
index 4953093..792939a 100644
--- a/src/main/docker/Dockerfile
+++ b/src/main/docker/Dockerfile
@@ -17,6 +17,6 @@
FROM java:8
MAINTAINER breeze
-ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar quickstart.jar
+ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar rocketmq-exporter.jar
EXPOSE 5557
-ENTRYPOINT ["java","-jar","quickstart.jar"]
+ENTRYPOINT ["java","-jar","rocketmq-exporter.jar"]
Re: [I] Build docker image with maven failed [rocketmq-exporter]
caigy closed issue #154: Build docker image with maven failed URL: https://github.com/apache/rocketmq-exporter/issues/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-exporter) branch master updated (7cc732e -> 5ac38b7)
This is an automated email from the ASF dual-hosted git repository. caigy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git discard 7cc732e fix #154 This update removed existing revisions from the reference, leaving the reference pointing at a previous point in the repository history. * -- * -- N refs/heads/master (5ac38b7) \ O -- O -- O (7cc732e) Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: pom.xml| 6 +- src/main/docker/Dockerfile | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-)
[PR] [ISSUE #154] make building docker images successful [rocketmq-exporter]
caigy opened a new pull request, #155: URL: https://github.com/apache/rocketmq-exporter/pull/155 ## What is the purpose of the change fix #154 ## Brief changelog fix the name of jar file in configurations of docker-maven-plugin. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add statistics for the production of transaction messages. [rocketmq]
kingkh1995 opened a new pull request, #7766: URL: https://github.com/apache/rocketmq/pull/7766 ### Which Issue(s) This PR Fixes Missing statistics when transaction messages are committed ### Brief Description Add statistics for the production of transaction messages. ### How Did You Test This Change? Test cases are updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [maven-release-plugin] prepare release java-5.0.6 [rocketmq-clients]
francisoliverlee closed pull request #672: [maven-release-plugin] prepare release java-5.0.6 URL: https://github.com/apache/rocketmq-clients/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-clients) branch java_release_5.0.6 deleted (was 793bba47)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git was 793bba47 [maven-release-plugin] prepare release java-5.0.6 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(rocketmq-clients) branch java-5.0.6 created (now 90044056)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to branch java-5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git at 90044056 [ISSUE #660] Add namespace in metadata (#671) No new revisions were added by this update.
(rocketmq-clients) branch java-5.0.6 deleted (was 90044056)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to branch java-5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git was 90044056 [ISSUE #660] Add namespace in metadata (#671) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(rocketmq-clients) branch java_release_5.0.6 created (now 90044056)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git at 90044056 [ISSUE #660] Add namespace in metadata (#671) No new revisions were added by this update.
(rocketmq-clients) branch java_release_5.0.6 updated: [maven-release-plugin] prepare release java-5.0.6
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a commit to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git The following commit(s) were added to refs/heads/java_release_5.0.6 by this push: new 5ea91c3a [maven-release-plugin] prepare release java-5.0.6 5ea91c3a is described below commit 5ea91c3a23616cd7e1cc36c6a1dc753d8ab58dd3 Author: tigerlee AuthorDate: Sun Jan 21 23:24:40 2024 +0800 [maven-release-plugin] prepare release java-5.0.6 --- java/client-apis/pom.xml | 2 +- java/client-shade/pom.xml | 2 +- java/client/pom.xml | 2 +- java/pom.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/java/client-apis/pom.xml b/java/client-apis/pom.xml index 59ec9ab4..9ac0fd07 100644 --- a/java/client-apis/pom.xml +++ b/java/client-apis/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/client-shade/pom.xml b/java/client-shade/pom.xml index f08678b1..08866a23 100644 --- a/java/client-shade/pom.xml +++ b/java/client-shade/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/client/pom.xml b/java/client/pom.xml index 4df99484..875ba96d 100644 --- a/java/client/pom.xml +++ b/java/client/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6-SNAPSHOT +5.0.6 4.0.0 diff --git a/java/pom.xml b/java/pom.xml index d39b7094..501aa047 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -26,7 +26,7 @@ org.apache.rocketmq rocketmq-client-java-parent pom -5.0.6-SNAPSHOT +5.0.6 client-apis client @@ -394,6 +394,6 @@ g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git -HEAD +java-5.0.6 \ No newline at end of file
(rocketmq-clients) annotated tag java-5.0.6 updated (5ea91c3a -> 49e8b224)
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a change to annotated tag java-5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git *** WARNING: tag java-5.0.6 was modified! *** from 5ea91c3a (commit) to 49e8b224 (tag) tagging 5ea91c3a23616cd7e1cc36c6a1dc753d8ab58dd3 (commit) replaces rust-5.0.0 by tigerlee on Sun Jan 21 23:25:05 2024 +0800 - Log - [maven-release-plugin] copy for tag java-5.0.6 --- No new revisions were added by this update. Summary of changes:
(rocketmq-clients) branch java_release_5.0.6 updated: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. tigerlee pushed a commit to branch java_release_5.0.6 in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git The following commit(s) were added to refs/heads/java_release_5.0.6 by this push: new 203ec756 [maven-release-plugin] prepare for next development iteration 203ec756 is described below commit 203ec756c2f7145207b4992ae0a4be13e5815530 Author: tigerlee AuthorDate: Sun Jan 21 23:25:10 2024 +0800 [maven-release-plugin] prepare for next development iteration --- java/client-apis/pom.xml | 2 +- java/client-shade/pom.xml | 2 +- java/client/pom.xml | 2 +- java/pom.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/java/client-apis/pom.xml b/java/client-apis/pom.xml index 9ac0fd07..f8279c19 100644 --- a/java/client-apis/pom.xml +++ b/java/client-apis/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6 +5.0.7-SNAPSHOT 4.0.0 diff --git a/java/client-shade/pom.xml b/java/client-shade/pom.xml index 08866a23..b3ea377e 100644 --- a/java/client-shade/pom.xml +++ b/java/client-shade/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6 +5.0.7-SNAPSHOT 4.0.0 diff --git a/java/client/pom.xml b/java/client/pom.xml index 875ba96d..65635d58 100644 --- a/java/client/pom.xml +++ b/java/client/pom.xml @@ -18,7 +18,7 @@ rocketmq-client-java-parent org.apache.rocketmq -5.0.6 +5.0.7-SNAPSHOT 4.0.0 diff --git a/java/pom.xml b/java/pom.xml index 501aa047..779a74d4 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -26,7 +26,7 @@ org.apache.rocketmq rocketmq-client-java-parent pom -5.0.6 +5.0.7-SNAPSHOT client-apis client @@ -394,6 +394,6 @@ g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git scm:git:g...@github.com:apache/rocketmq-clients.git -java-5.0.6 +HEAD \ No newline at end of file
svn commit: r66730 - /dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/
Author: tigerlee Date: Sun Jan 21 16:14:00 2024 New Revision: 66730 Log: upload rocketmq clients for java 5.0.6 rc1 Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/ dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip (with props) dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.asc (with props) dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.sha512 dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip (with props) dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.asc (with props) dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.sha512 Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip == Binary file - no diff available. Propchange: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip -- svn:mime-type = application/zip Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.asc == Binary file - no diff available. Propchange: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.asc -- svn:mime-type = application/pgp-signature Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.sha512 == --- dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.sha512 (added) +++ dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-bin-release.zip.sha512 Sun Jan 21 16:14:00 2024 @@ -0,0 +1,3 @@ +rocketmq-client-java-5.0.6-bin-release.zip: +623590F0 4206B46C C19A8E83 26C38826 74BBED1B 880231C9 BBF72978 CCBEBACB C54570AE + DA1DF0DE 26B5EB2E 2E2DE391 08C6B538 DB01781F 684E1E9F A733B336 Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip == Binary file - no diff available. Propchange: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip -- svn:mime-type = application/zip Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.asc == Binary file - no diff available. Propchange: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.asc -- svn:mime-type = application/pgp-signature Added: dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.sha512 == --- dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.sha512 (added) +++ dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.6-rc1/rocketmq-client-java-5.0.6-source-release.zip.sha512 Sun Jan 21 16:14:00 2024 @@ -0,0 +1,3 @@ +rocketmq-client-java-5.0.6-source-release.zip: +EBEBD644 665A5691 12D22E3F 17B58DB5 6B412EAB 1380C49D 93171B5D E6BD83E2 9C4B1FF3 + 49124257 8C0F5CE5 C720B0AD 2E760360 0D64D79B E0122D54 32B3F45A
Re: [PR] [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… [rocketmq]
yp969803 closed pull request #7618: [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… URL: https://github.com/apache/rocketmq/pull/7618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7617] Changed the buffer time to 10sec in unit test testState… [rocketmq]
yp969803 commented on code in PR #7618:
URL: https://github.com/apache/rocketmq/pull/7618#discussion_r1461106290
##
common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java:
##
@@ -36,6 +36,6 @@ public void computeIfAbsent() {
String value2 = ConcurrentHashMapUtils.computeIfAbsent(map, "123", k
-> "2342");
assertEquals("", value2);
//map.computeIfAbsent("AaAa",
key->map.computeIfAbsent("",key2->"42"));
-ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key ->
map.computeIfAbsent("", key2 -> "42"));
+// ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key ->
map.computeIfAbsent("", key2 -> "42"));
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Task] add pop consumer example [rocketmq]
github-actions[bot] closed issue #5896: [Task] add pop consumer example URL: https://github.com/apache/rocketmq/issues/5896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Task] add pop consumer example [rocketmq]
github-actions[bot] commented on issue #5896: URL: https://github.com/apache/rocketmq/issues/5896#issuecomment-1902815268 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user kingkh1995 (triggered by RongtongJin). Head commit for run: 48bb4e4835a29a4c6401efa92ac983990031ffb8 / kingkh fix transaction msg stats Report URL: https://github.com/apache/rocketmq/actions/runs/7601710721 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #154] make building docker images successful [rocketmq-exporter]
RongtongJin merged PR #155: URL: https://github.com/apache/rocketmq-exporter/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-exporter) branch master updated: [ISSUE #154] make building docker images successful
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-exporter.git
The following commit(s) were added to refs/heads/master by this push:
new a643d3e [ISSUE #154] make building docker images successful
a643d3e is described below
commit a643d3ee4afcfbbabef94480a339308a9a996196
Author: caigy
AuthorDate: Mon Jan 22 10:06:35 2024 +0800
[ISSUE #154] make building docker images successful
Co-authored-by: gaoyang.cgy
---
pom.xml| 6 +-
src/main/docker/Dockerfile | 4 ++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 7084b57..bdfbce9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -126,12 +126,16 @@
${docker.image.prefix}/${project.artifactId}
+
+${project.version}
+latest
+
src/main/docker
/
${project.build.directory}
-${project.build.finalName}.jar
+
${project.build.finalName}-exec.jar
diff --git a/src/main/docker/Dockerfile b/src/main/docker/Dockerfile
index 4953093..792939a 100644
--- a/src/main/docker/Dockerfile
+++ b/src/main/docker/Dockerfile
@@ -17,6 +17,6 @@
FROM java:8
MAINTAINER breeze
-ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar quickstart.jar
+ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar rocketmq-exporter.jar
EXPOSE 5557
-ENTRYPOINT ["java","-jar","quickstart.jar"]
+ENTRYPOINT ["java","-jar","rocketmq-exporter.jar"]
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user kingkh1995 (triggered by kingkh1995). Head commit for run: 920dc32d27032716ec5d6ea6361af5778a9ed7b1 / Lei Zhiyuan [ISSUE #7760] make timerSkipUnknownError can be set by config file Report URL: https://github.com/apache/rocketmq/actions/runs/7605479164 With regards, GitHub Actions via GitBox
Re: [PR] Add statistics for the production of transaction messages. [rocketmq]
codecov-commenter commented on PR #7766: URL: https://github.com/apache/rocketmq/pull/7766#issuecomment-1902927348 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7766?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`50974ad`)](https://app.codecov.io/gh/apache/rocketmq/commit/50974adaaa75200092a4bb7fad48c6a3d4c2b1ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.16% compared to head [(`48bb4e4`)](https://app.codecov.io/gh/apache/rocketmq/pull/7766?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.18%. > Report is 6 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7766 +/- ## = + Coverage 43.16% 43.18% +0.01% - Complexity 9822 9828 +6 = Files 1167 1167 Lines 8460784695 +88 Branches 1097310993 +20 = + Hits 3652236574 +52 - Misses 4354143577 +36 Partials4544 4544 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7766?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Improve RouteInfoManager#registerTopic readability [rocketmq]
mxsm opened a new issue, #7768: URL: https://github.com/apache/rocketmq/issues/7768 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary  This method can be simplified. ### Motivation This method can be simplified. ### Describe the Solution You'd Like Refactor this method ### Describe Alternatives You've Considered Improve RouteInfoManager#registerTopic readability ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7699] Refector NamespaceRpcHook [rocketmq]
drpmma opened a new pull request, #7769: URL: https://github.com/apache/rocketmq/pull/7769 ### Which Issue(s) This PR Fixes Fixes #7699 ### Brief Description Refector NamespaceRpcHook ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 9de76fdcecfb493da469705bd5b852b2f1d25bc6 / zhouxiang [ISSUE #7699] Refector NamespaceRpcHook Report URL: https://github.com/apache/rocketmq/actions/runs/7608027753 With regards, GitHub Actions via GitBox
