Re: [I] Check message size before message compression [rocketmq]

[via GitHub]

francisoliverlee commented on issue #7758:
URL: https://github.com/apache/rocketmq/issues/7758#issuecomment-1902566721

   
   ## Client's config key=maxMessageSize checked in 
Validators.checkMessage(msg, this.defaultMQProducer); 
   ```java
   if (msg.getBody().length > defaultMQProducer.getMaxMessageSize()) {
               throw new MQClientException(ResponseCode.MESSAGE_ILLEGAL,
                   "the message body size over max value, MAX: " + 
defaultMQProducer.getMaxMessageSize());
           }
   ```
   - sync send one message, do body size check
   - async send one message, do body size check
   - sync send batch message, do 2 checks
     - do every message body check
     - do all message's body size check
   - async send one message, do 2 checks
     - do every message body check
     - do all message's body size check
   
   
   ## Proxy check message body size
   
![image](https://github.com/apache/rocketmq/assets/5908412/3a4638a4-0536-4112-bf17-40d7d0968257)
   
   ## Broker not check message size
   
![image](https://github.com/apache/rocketmq/assets/5908412/9b105d1a-9c12-4fdd-9174-95e94c0719dd)
   
   ## Store's config key=maxMessageSize checked in MessageExtEncoder.encode() 
WITH 2 checks
   
![image](https://github.com/apache/rocketmq/assets/5908412/fc33ea7e-ca8c-491e-b7aa-31a2b859ebfc)
   
   - body check
   - header + body check
   
   
   
   > at 5.1.4 delay check message is about (header + body), but send to broke 
is only body. is also a problem.
   
   i found some size checks here but no delay message check, can you pls give 
out the code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org