[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 116c3d41d79e47f9dce80b0f1968b8334666c8b8 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7346459986 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 710d3bcdb083d28f0cdb405adb749509150f0b25 / zhouxiang fix SendMessageRequestHeaderV2Test Report URL: https://github.com/apache/rocketmq/actions/runs/7354688961 With regards, GitHub Actions via GitBox
[I] [Enhancement] Add namespace in java client [rocketmq-clients]
drpmma opened a new issue, #660: URL: https://github.com/apache/rocketmq-clients/issues/660 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Programming Language of the Client Java ### Summary Add namespace in java client. ### Motivation For the purpose for the future namespace feature. ### Describe the Solution You'd Like Add namespace in ClientConfiguration. ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #660] Add namespace in java client [rocketmq-clients]
drpmma opened a new pull request, #661: URL: https://github.com/apache/rocketmq-clients/pull/661 ### Which Issue(s) This PR Fixes Fixes #660 ### Brief Description Add namespace in java client ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "CodeSpell Check" failed!
The GitHub Actions job "CodeSpell Check" on rocketmq-clients.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 92c0ac222abd9a5a091d1c6b12bf9c711bc564cc / zhouxiang Add namespace for java client Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355016390 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Java Coverage" failed!
The GitHub Actions job "Java Coverage" on rocketmq-clients.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 92c0ac222abd9a5a091d1c6b12bf9c711bc564cc / zhouxiang Add namespace for java client Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355016389 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "License Checker" failed!
The GitHub Actions job "License Checker" on rocketmq-clients.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 92c0ac222abd9a5a091d1c6b12bf9c711bc564cc / zhouxiang Add namespace for java client Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355016392 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 92c0ac222abd9a5a091d1c6b12bf9c711bc564cc / zhouxiang Add namespace for java client Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355016399 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7671] filter inner producer client when report to metrics [rocketmq]
zhiliatom commented on code in PR #7673:
URL: https://github.com/apache/rocketmq/pull/7673#discussion_r1438091180
##
broker/src/main/java/org/apache/rocketmq/broker/metrics/BrokerMetricsManager.java:
##
@@ -459,9 +462,14 @@ private void initConnectionMetrics() {
.ofLongs()
.buildWithCallback(measurement -> {
Map metricsMap = new HashMap<>();
-brokerController.getProducerManager()
-.getGroupChannelTable()
-.values()
+ConcurrentHashMap> groupChannelTable =
brokerController.getProducerManager().getGroupChannelTable();
+ConcurrentHashMap> clone = new ConcurrentHashMap<>(groupChannelTable);
+clone.forEach((group, map) -> {
+if (MixAll.CLIENT_INNER_PRODUCER_GROUP.equals(group)) {
+groupChannelTable.remove(group);
+}
Review Comment:
Thanks for your review, but I think `remove` in a clone map won't affect
original map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "CodeSpell Check" is working again!
The GitHub Actions job "CodeSpell Check" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 501fd82ca88d903ebc621e575d5683c0564e1fdf / qipingluo fix cargo fmt issue Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7353750402 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "License Checker" is working again!
The GitHub Actions job "License Checker" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 501fd82ca88d903ebc621e575d5683c0564e1fdf / qipingluo fix cargo fmt issue Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7353750406 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" is working again!
The GitHub Actions job "Build" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 501fd82ca88d903ebc621e575d5683c0564e1fdf / qipingluo fix cargo fmt issue Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7353750448 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7671] filter inner producer client when report to metrics [rocketmq]
zhiliatom commented on PR #7673: URL: https://github.com/apache/rocketmq/pull/7673#issuecomment-1871854900 @spiritsx take a look at this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7671] filter inner producer client when report to metrics [rocketmq]
zhiliatom commented on PR #7673: URL: https://github.com/apache/rocketmq/pull/7673#issuecomment-1871855741 @ShadowySpirits take a look at this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] support handling settings command in telemetry rpc [rocketmq-clients]
glcrazier opened a new pull request, #662: URL: https://github.com/apache/rocketmq-clients/pull/662 ### Which Issue(s) This PR Fixes Fixes ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "metrics bugfix: switch getTps() to getSum()" [rocketmq-exporter]
cserwen commented on PR #141: URL: https://github.com/apache/rocketmq-exporter/pull/141#issuecomment-1871897708 > What is the reason for changing to sum before? Is it necessary? 最早的版本就是 TPS，使用的getTps()，https://github.com/apache/rocketmq-exporter/pull/108 改成了 getSum，理论上应该增加个指标叫 tpm，而不是在原本的基础上改 @ferrirW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 23143bf8b224e5dd93421dffe3fa2843f135ed2c / qipingluo remove ugly variable use Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355547041 With regards, GitHub Actions via GitBox
Re: [PR] [rust]support handling settings command in telemetry rpc [rocketmq-clients]
codecov-commenter commented on PR #662: URL: https://github.com/apache/rocketmq-clients/pull/662#issuecomment-1871925727 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `13 lines` in your changes are missing coverage. Please review. > Comparison is base [(`2d3cdf7`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/2d3cdf735e27a3c3a9e1786d0ee7c8318ba1578c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.69% compared to head [(`23143bf`)](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.77%. | [Files](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [rust/src/conf.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvY29uZi5ycw==) | 50.00% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/client.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvY2xpZW50LnJz) | 93.75% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/producer.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvcHJvZHVjZXIucnM=) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/model/common.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvbW9kZWwvY29tbW9uLnJz) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/simple\_consumer.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvc2ltcGxlX2NvbnN1bWVyLnJz) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #662 +/- ## + Coverage 46.69% 46.77% +0.07% Complexity 651 651 Files 207 207 Lines 1212012168 +48 Branches 3510 3558 +48 + Hits 5659 5691 +32 - Misses 6212 6223 +11 - Partials249 254 +5 ``` | [Flag](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/apache/rocketmq-clients/pull/662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.40% <80.30%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq-clie
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by lizhanhui). Head commit for run: 5e49dd2209ce2b33a1eb8640d0b81d47c799c813 / qipingluo fix cargo fmt issue Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7355903434 With regards, GitHub Actions via GitBox
Re: [I] HATest is flaky on macOS [rocketmq]
github-actions[bot] commented on issue #5782: URL: https://github.com/apache/rocketmq/issues/5782#issuecomment-1872398841 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feat query key by time range [rocketmq]
github-actions[bot] commented on PR #5772: URL: https://github.com/apache/rocketmq/pull/5772#issuecomment-1872398852 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 能增加web端支持吗？有计划吗 [rocketmq-mqtt]
cwj12345612 commented on issue #230: URL: https://github.com/apache/rocketmq-mqtt/issues/230#issuecomment-1872430572 > > > > 可以增加对web端的支持吗？和emqx一样能在前端使用mqtt.js连接。 > > > > > > > > > 可以的，现在是支持mqtt.js的 > > > > > > 那前端端口是多少？1883？使用什么协议访问？ > > tcp 是 1883、ssl 是 8883、ws是 ok谢谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 能增加web端支持吗？有计划吗 [rocketmq-mqtt]
cwj12345612 commented on issue #230: URL: https://github.com/apache/rocketmq-mqtt/issues/230#issuecomment-1872430665 > > > > 可以增加对web端的支持吗？和emqx一样能在前端使用mqtt.js连接。 > > > > > > > > > 可以的，现在是支持mqtt.js的 > > > > > > 那前端端口是多少？1883？使用什么协议访问？ > > tcp 是 1883、ssl 是 8883、ws是 ok 谢谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
