zhiliatom commented on code in PR #7673:
URL: https://github.com/apache/rocketmq/pull/7673#discussion_r1438091180
##########
broker/src/main/java/org/apache/rocketmq/broker/metrics/BrokerMetricsManager.java:
##########
@@ -459,9 +462,14 @@ private void initConnectionMetrics() {
.ofLongs()
.buildWithCallback(measurement -> {
Map<ProducerAttr, Integer> metricsMap = new HashMap<>();
- brokerController.getProducerManager()
- .getGroupChannelTable()
- .values()
+ ConcurrentHashMap<String, ConcurrentHashMap<Channel,
ClientChannelInfo>> groupChannelTable =
brokerController.getProducerManager().getGroupChannelTable();
+ ConcurrentHashMap<String, ConcurrentHashMap<Channel,
ClientChannelInfo>> clone = new ConcurrentHashMap<>(groupChannelTable);
+ clone.forEach((group, map) -> {
+ if (MixAll.CLIENT_INNER_PRODUCER_GROUP.equals(group)) {
+ groupChannelTable.remove(group);
+ }
Review Comment:
Thanks for your review, but I think `remove` in a clone map won't affect
original map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
