[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6822179007 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 8258eddff826e430bc7c51e0a10dcb16734ef767 / Zhanhui Li fix: set MixCommitlogTest test size as medium Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq/actions/runs/6822123854 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: e0e9589485361647456477115be305feb7de2057 / Li Zhanhui allow cache bazel test results Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822130715 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: f74c8874ee341c80a47e0906a0de245d8446f8ac / Li Zhanhui fix code style issue by removing unused imports Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822159207 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 3dfe73125ac0463dc3a3968a0cfacb0a0020ae9c / Li Zhanhui let consumer be aware of message queue assignment change Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822002001 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 974c7658828fb70028de6ecdd2966b3ad638a2ed / Li Zhanhui add unit test for DefaultMQPushConsumer#setMessageQueueListener Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822073596 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7547] Let consumer be aware of message queue assignment change [rocketmq]
codecov-commenter commented on PR #7548: URL: https://github.com/apache/rocketmq/pull/7548#issuecomment-1805285905 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7548](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f74c887) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/27759f3556c279f63c13bc94fe3ad6ca8114?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (27759f3) will **decrease** coverage by `0.04%`. > The diff coverage is `40.00%`. ```diff @@ Coverage Diff @@ ## develop#7548 +/- ## = - Coverage 43.13% 43.09% -0.04% - Complexity 9709 9714 +5 = Files 1159 1159 Lines 8404984058 +9 Branches 1092310924 +1 = - Hits 3625736228 -29 - Misses 4327943319 +40 + Partials4513 4511 -2 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `56.76% <33.33%> (-0.32%)` | :arrow_down: | | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `34.98% <50.00%> (-0.01%)` | :arrow_down: | | [...cketmq/client/impl/consumer/RebalancePushImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdXNoSW1wbC5qYXZh) | `48.80% <33.33%> (-0.39%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7548/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: e0e9589485361647456477115be305feb7de2057 / Li Zhanhui allow cache bazel test results Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822130711 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 8258eddff826e430bc7c51e0a10dcb16734ef767 / Zhanhui Li fix: set MixCommitlogTest test size as medium Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq/actions/runs/6822123853 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: f74c8874ee341c80a47e0906a0de245d8446f8ac / Li Zhanhui fix code style issue by removing unused imports Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822159208 With regards, GitHub Actions via GitBox
[PR] fix local mode by making ext-headers remoting protocol compliant [rocketmq]
lizhanhui opened a new pull request, #7549: URL: https://github.com/apache/rocketmq/pull/7549 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch fix_local_mode created (now 2e5f48ffa6)
This is an automated email from the ASF dual-hosted git repository. lizhanhui pushed a change to branch fix_local_mode in repository https://gitbox.apache.org/repos/asf/rocketmq.git at 2e5f48ffa6 fix local mode by making ext-headers remoting protocol compliant This branch includes the following new commits: new 2e5f48ffa6 fix local mode by making ext-headers remoting protocol compliant The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(rocketmq) 01/01: fix local mode by making ext-headers remoting protocol compliant
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch fix_local_mode
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
commit 2e5f48ffa6c392f31bfff68596fcff673c1c46bb
Author: Li Zhanhui
AuthorDate: Fri Nov 10 17:18:23 2023 +0800
fix local mode by making ext-headers remoting protocol compliant
Signed-off-by: Li Zhanhui
---
.../org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
index 915cafcd57..7bf4a16982 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
@@ -32,6 +32,7 @@ public class LocalRemotingCommand extends RemotingCommand {
cmd.writeCustomHeader(customHeader);
cmd.setExtFields(new HashMap<>());
setCmdVersion(cmd);
+cmd.makeCustomHeaderToNet();
return cmd;
}
(rocketmq) branch free_direct_byte_buffer created (now d12ece13d3)
This is an automated email from the ASF dual-hosted git repository. lizhanhui pushed a change to branch free_direct_byte_buffer in repository https://gitbox.apache.org/repos/asf/rocketmq.git at d12ece13d3 Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible This branch includes the following new commits: new d12ece13d3 Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(rocketmq) 01/01: Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch free_direct_byte_buffer
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
commit d12ece13d3cf92fdbbbc136c07012c79f9e2600d
Author: Li Zhanhui
AuthorDate: Fri Nov 10 17:24:49 2023 +0800
Reuse helper methods from Netty to free direct byte buffer, making codebase
JDK 9+ compatible
Signed-off-by: Li Zhanhui
---
.../java/org/apache/rocketmq/common/UtilAll.java | 61 +-
.../org/apache/rocketmq/common/UtilAllTest.java| 10
2 files changed, 2 insertions(+), 69 deletions(-)
diff --git a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
index 95b6b09b41..d017791f8e 100644
--- a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
+++ b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
@@ -16,21 +16,18 @@
*/
package org.apache.rocketmq.common;
+import io.netty.util.internal.PlatformDependent;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.lang.management.ManagementFactory;
-import java.lang.reflect.Field;
-import java.lang.reflect.Method;
import java.net.Inet4Address;
import java.net.Inet6Address;
import java.net.InetAddress;
import java.net.NetworkInterface;
import java.nio.ByteBuffer;
import java.nio.file.Files;
-import java.security.AccessController;
-import java.security.PrivilegedAction;
import java.text.NumberFormat;
import java.text.ParseException;
import java.text.SimpleDateFormat;
@@ -46,15 +43,11 @@ import java.util.function.Supplier;
import java.util.zip.CRC32;
import java.util.zip.DeflaterOutputStream;
import java.util.zip.InflaterInputStream;
-import org.apache.commons.lang3.JavaVersion;
import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.SystemUtils;
import org.apache.commons.validator.routines.InetAddressValidator;
import org.apache.rocketmq.common.constant.LoggerName;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
-import sun.misc.Unsafe;
-import sun.nio.ch.DirectBuffer;
public class UtilAll {
private static final Logger log =
LoggerFactory.getLogger(LoggerName.COMMON_LOGGER_NAME);
@@ -707,57 +700,7 @@ public class UtilAll {
}
public static void cleanBuffer(final ByteBuffer buffer) {
-if (buffer == null || !buffer.isDirect() || buffer.capacity() == 0) {
-return;
-}
-if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
-try {
-Field field = Unsafe.class.getDeclaredField("theUnsafe");
-field.setAccessible(true);
-Unsafe unsafe = (Unsafe) field.get(null);
-Method cleaner = method(unsafe, "invokeCleaner", new Class[]
{ByteBuffer.class});
-cleaner.invoke(unsafe, viewed(buffer));
-} catch (Exception e) {
-throw new IllegalStateException(e);
-}
-} else {
-invoke(invoke(viewed(buffer), "cleaner"), "clean");
-}
-}
-
-public static Object invoke(final Object target, final String methodName,
final Class... args) {
-return AccessController.doPrivileged(new PrivilegedAction() {
-@Override
-public Object run() {
-try {
-Method method = method(target, methodName, args);
-method.setAccessible(true);
-return method.invoke(target);
-} catch (Exception e) {
-throw new IllegalStateException(e);
-}
-}
-});
-}
-
-public static Method method(Object target, String methodName, Class[]
args) throws NoSuchMethodException {
-try {
-return target.getClass().getMethod(methodName, args);
-} catch (NoSuchMethodException e) {
-return target.getClass().getDeclaredMethod(methodName, args);
-}
-}
-
-private static ByteBuffer viewed(ByteBuffer buffer) {
-if (!buffer.isDirect()) {
-throw new IllegalArgumentException("buffer is non-direct");
-}
-ByteBuffer viewedBuffer = (ByteBuffer) ((DirectBuffer)
buffer).attachment();
-if (viewedBuffer == null) {
-return buffer;
-} else {
-return viewed(viewedBuffer);
-}
+PlatformDependent.freeDirectBuffer(buffer);
}
public static void ensureDirOK(final String dirName) {
diff --git a/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
b/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
index 94bb390eb6..cb288578cc 100644
--- a/common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java
+++ b/common/src/test/java/org/apache/rocketmq/comm
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 2e5f48ffa6c392f31bfff68596fcff673c1c46bb / Li Zhanhui fix local mode by making ext-headers remoting protocol compliant Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822965126 With regards, GitHub Actions via GitBox
[PR] Reuse helper methods from Netty to free direct byte buffer [rocketmq]
lizhanhui opened a new pull request, #7550: URL: https://github.com/apache/rocketmq/pull/7550 Make codebase JDK 9+ compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d12ece13d3cf92fdbbbc136c07012c79f9e2600d / Li Zhanhui Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823030115 With regards, GitHub Actions via GitBox
[I] [Enhancement] Git rid of internal sun.nio.ch.DirectBuffer [rocketmq]
lizhanhui opened a new issue, #7551: URL: https://github.com/apache/rocketmq/issues/7551 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Remove dependency on sun.nio.ch.DirectBuffer ### Motivation Get rid of dependency on sun.nio.ch.DirectBuffer, making codebase JDK 9+ compatible ### Describe the Solution You'd Like Reuse assets from netty ### Describe Alternatives You've Considered Repeat work offered by netty ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d12ece13d3cf92fdbbbc136c07012c79f9e2600d / Li Zhanhui Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823030116 With regards, GitHub Actions via GitBox
[I] [Bug] Local Mode cannot work properly without necessary remoting ext-headers accessible [rocketmq]
lizhanhui opened a new issue, #7552: URL: https://github.com/apache/rocketmq/issues/7552 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment N/A ### RocketMQ version N/A ### JDK Version N/A ### Describe the Bug N/A ### Steps to Reproduce Run the following integration test src/test/java/org/apache/rocketmq/test/grpc/v2/LocalGrpcIT ### What Did You Expect to See? Test should pass ### What Did You See Instead? Test failed ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 2e5f48ffa6c392f31bfff68596fcff673c1c46bb / Li Zhanhui fix local mode by making ext-headers remoting protocol compliant Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822965125 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d12ece13d3cf92fdbbbc136c07012c79f9e2600d / Li Zhanhui Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823030114 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6822991768 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6823055339 With regards, GitHub Actions via GitBox
(rocketmq) branch free_direct_byte_buffer updated: Guard against null
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch free_direct_byte_buffer
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/free_direct_byte_buffer by
this push:
new dd2f6695f5 Guard against null
dd2f6695f5 is described below
commit dd2f6695f579ccba83cf548289bc89a6dfb9298b
Author: Li Zhanhui
AuthorDate: Fri Nov 10 17:41:02 2023 +0800
Guard against null
Signed-off-by: Li Zhanhui
---
common/src/main/java/org/apache/rocketmq/common/UtilAll.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
index d017791f8e..2808f106ae 100644
--- a/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
+++ b/common/src/main/java/org/apache/rocketmq/common/UtilAll.java
@@ -700,6 +700,9 @@ public class UtilAll {
}
public static void cleanBuffer(final ByteBuffer buffer) {
+if (null == buffer) {
+return;
+}
PlatformDependent.freeDirectBuffer(buffer);
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: dd2f6695f579ccba83cf548289bc89a6dfb9298b / Li Zhanhui Guard against null Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823176390 With regards, GitHub Actions via GitBox
(rocketmq) branch consumer_aware_queue_change updated: fix #7552
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch consumer_aware_queue_change
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/consumer_aware_queue_change by
this push:
new 4552c339c9 fix #7552
4552c339c9 is described below
commit 4552c339c9584842bafb7343716de3d26efef5bb
Author: Zhanhui Li
AuthorDate: Fri Nov 10 09:53:52 2023 +
fix #7552
Signed-off-by: Zhanhui Li
---
.../org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
index 915cafcd57..7bf4a16982 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
@@ -32,6 +32,7 @@ public class LocalRemotingCommand extends RemotingCommand {
cmd.writeCustomHeader(customHeader);
cmd.setExtFields(new HashMap<>());
setCmdVersion(cmd);
+cmd.makeCustomHeaderToNet();
return cmd;
}
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6823198085 With regards, GitHub Actions via GitBox
(rocketmq) branch free_direct_byte_buffer updated: fix #7552
This is an automated email from the ASF dual-hosted git repository.
lizhanhui pushed a commit to branch free_direct_byte_buffer
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/free_direct_byte_buffer by
this push:
new f8b5b4bac3 fix #7552
f8b5b4bac3 is described below
commit f8b5b4bac3111a8832453e5167905e071b95e603
Author: Li Zhanhui
AuthorDate: Fri Nov 10 17:56:07 2023 +0800
fix #7552
Signed-off-by: Li Zhanhui
---
.../org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
index 915cafcd57..7bf4a16982 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java
@@ -32,6 +32,7 @@ public class LocalRemotingCommand extends RemotingCommand {
cmd.writeCustomHeader(customHeader);
cmd.setExtFields(new HashMap<>());
setCmdVersion(cmd);
+cmd.makeCustomHeaderToNet();
return cmd;
}
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 4552c339c9584842bafb7343716de3d26efef5bb / Zhanhui Li fix #7552 Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq/actions/runs/6823293925 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: f8b5b4bac3111a8832453e5167905e071b95e603 / Li Zhanhui fix #7552 Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823314651 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 4552c339c9584842bafb7343716de3d26efef5bb / Zhanhui Li fix #7552 Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq/actions/runs/6823293918 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: f8b5b4bac3111a8832453e5167905e071b95e603 / Li Zhanhui fix #7552 Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823314656 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 2e5f48ffa6c392f31bfff68596fcff673c1c46bb / Li Zhanhui fix local mode by making ext-headers remoting protocol compliant Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822965125 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 2e5f48ffa6c392f31bfff68596fcff673c1c46bb / Li Zhanhui fix local mode by making ext-headers remoting protocol compliant Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6822965128 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 4552c339c9584842bafb7343716de3d26efef5bb / Zhanhui Li fix #7552 Signed-off-by: Zhanhui Li Report URL: https://github.com/apache/rocketmq/actions/runs/6823293918 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6823345431 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6823316676 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: dd2f6695f579ccba83cf548289bc89a6dfb9298b / Li Zhanhui Guard against null Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823176384 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: f8b5b4bac3111a8832453e5167905e071b95e603 / Li Zhanhui fix #7552 Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/6823314656 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #4890] fix binary search consume queue offset by timestamp [rocketmq]
github-actions[bot] commented on PR #5504: URL: https://github.com/apache/rocketmq/pull/5504#issuecomment-1806580901 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Do producer‘s apis in rocketmq5 not support send with selector? [rocketmq]
github-actions[bot] commented on issue #5496: URL: https://github.com/apache/rocketmq/issues/5496#issuecomment-1806580922 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Does the community have any intention to adopt RIP-18? [rocketmq]
github-actions[bot] commented on issue #5495: URL: https://github.com/apache/rocketmq/issues/5495#issuecomment-1806580944 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] the consumer's group info not exist [rocketmq]
github-actions[bot] commented on issue #5479: URL: https://github.com/apache/rocketmq/issues/5479#issuecomment-1806580958 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The main method of class “MonitorService” could be removed [rocketmq]
github-actions[bot] closed issue #5472: The main method of class “MonitorService” could be removed URL: https://github.com/apache/rocketmq/issues/5472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The main method of class “MonitorService” could be removed [rocketmq]
github-actions[bot] commented on issue #5472: URL: https://github.com/apache/rocketmq/issues/5472#issuecomment-1806580981 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [idea] Add rocketmq icon to idea. [rocketmq]
github-actions[bot] commented on PR #5470: URL: https://github.com/apache/rocketmq/pull/5470#issuecomment-1806581005 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [idea] Add rocketmq icon to idea. [rocketmq]
github-actions[bot] closed pull request #5470: [idea] Add rocketmq icon to idea. URL: https://github.com/apache/rocketmq/pull/5470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Can I switch back to the master-slave cluster from the DLeger cluster mode？ [rocketmq]
github-actions[bot] commented on issue #5469: URL: https://github.com/apache/rocketmq/issues/5469#issuecomment-1806581026 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Can I switch back to the master-slave cluster from the DLeger cluster mode？ [rocketmq]
github-actions[bot] closed issue #5469: Can I switch back to the master-slave cluster from the DLeger cluster mode？ URL: https://github.com/apache/rocketmq/issues/5469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix cmd resetOffsetByTime bug with batch messages #5445 [rocketmq]
github-actions[bot] commented on PR #5456: URL: https://github.com/apache/rocketmq/pull/5456#issuecomment-1806581055 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix cmd resetOffsetByTime bug with batch messages #5445 [rocketmq]
github-actions[bot] closed pull request #5456: fix cmd resetOffsetByTime bug with batch messages #5445 URL: https://github.com/apache/rocketmq/pull/5456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Delete Duplicate Code in DefaultRequestProcessor [rocketmq]
github-actions[bot] commented on PR #5435: URL: https://github.com/apache/rocketmq/pull/5435#issuecomment-1806581080 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Delete Duplicate Code in DefaultRequestProcessor [rocketmq]
github-actions[bot] closed pull request #5435: Delete Duplicate Code in DefaultRequestProcessor URL: https://github.com/apache/rocketmq/pull/5435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Client IP（Message Born IP， Consumer client ip) is not right if there is a proxy between client and broker on 4.x [rocketmq]
github-actions[bot] commented on issue #5395: URL: https://github.com/apache/rocketmq/issues/5395#issuecomment-1806581103 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add dynamic log change [rocketmq]
github-actions[bot] commented on PR #5033: URL: https://github.com/apache/rocketmq/pull/5033#issuecomment-1806581124 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/net from 0.0.0-20220809184613-07c6da5e1ced to 0.17.0 in /golang [rocketmq-clients]
github-actions[bot] commented on PR #622: URL: https://github.com/apache/rocketmq-clients/pull/622#issuecomment-1806588297 This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 27759f3556c279f63c13bc94fe3ad6ca8114 / Allon Murienik Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows (#7419) This patch offers an alternative approach to 5d492c338258d07613103e6ae16df4c6fa5b3838. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes #7418 Report URL: https://github.com/apache/rocketmq/actions/runs/6830902527 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7551] Reuse helper methods from Netty to free direct byte buffer [rocketmq]
joeCarf commented on code in PR #7550: URL: https://github.com/apache/rocketmq/pull/7550#discussion_r1390106567 ## proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java: ## @@ -32,6 +32,7 @@ public static LocalRemotingCommand createRequestCommand(int code, CommandCustomH cmd.writeCustomHeader(customHeader); cmd.setExtFields(new HashMap<>()); setCmdVersion(cmd); +cmd.makeCustomHeaderToNet(); Review Comment: seems that this is irrelevant to the commit ## proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java: ## @@ -32,6 +32,7 @@ public static LocalRemotingCommand createRequestCommand(int code, CommandCustomH cmd.writeCustomHeader(customHeader); cmd.setExtFields(new HashMap<>()); setCmdVersion(cmd); +cmd.makeCustomHeaderToNet(); Review Comment: I saw your commit in another pr, maybe you can split them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
