joeCarf commented on code in PR #7550:
URL: https://github.com/apache/rocketmq/pull/7550#discussion_r1390106567
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java:
##########
@@ -32,6 +32,7 @@ public static LocalRemotingCommand createRequestCommand(int
code, CommandCustomH
cmd.writeCustomHeader(customHeader);
cmd.setExtFields(new HashMap<>());
setCmdVersion(cmd);
+ cmd.makeCustomHeaderToNet();
Review Comment:
seems that this is irrelevant to the commit
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java:
##########
@@ -32,6 +32,7 @@ public static LocalRemotingCommand createRequestCommand(int
code, CommandCustomH
cmd.writeCustomHeader(customHeader);
cmd.setExtFields(new HashMap<>());
setCmdVersion(cmd);
+ cmd.makeCustomHeaderToNet();
Review Comment:
I saw your commit in another pr, maybe you can split them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
