Re: [PR] [ISSUE #7543] Retry topic v2 in pop [rocketmq]
xdkxlk commented on PR #7544: URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1798027448 We need to consider the modifications from #7208 in order to ensure compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] jdk17下报错：Caused by: java.lang.NoClassDefFoundError: Could not initialize class io.netty.util.internal.PlatformDependent0 [rocketmq-dashboard]
wshu-oli opened a new issue, #187: URL: https://github.com/apache/rocketmq-dashboard/issues/187 应该需要升级netty如： ` io.netty netty-all 4.1.82.Final ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 安装配置好之后使用mqttx测试连接不上 [rocketmq-mqtt]
EssinZhang commented on issue #216:
URL: https://github.com/apache/rocketmq-mqtt/issues/216#issuecomment-1798106228
> 密码 参考示例代码，密码需要加签 connOpts.setUserName(System.getenv("username"));
connOpts.setPassword(HmacSHA1Util.macSignature(clientId,
System.getenv("password")).toCharArray());
有交流群么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "License checker" failed!
The GitHub Actions job "License checker" on rocketmq.git has failed. Run started by GitHub user bibhanshu12 (triggered by lizhanhui). Head commit for run: c2c39bf8a7e053b8a2ef45b7632ce6fba30e4e3f / Bibhanshu <130032629+bibhansh...@users.noreply.github.com> Add files via upload Report URL: https://github.com/apache/rocketmq/actions/runs/6709023036 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Misspell Check" failed!
The GitHub Actions job "Misspell Check" on rocketmq.git has failed. Run started by GitHub user bibhanshu12 (triggered by lizhanhui). Head commit for run: c2c39bf8a7e053b8a2ef45b7632ce6fba30e4e3f / Bibhanshu <130032629+bibhansh...@users.noreply.github.com> Add files via upload Report URL: https://github.com/apache/rocketmq/actions/runs/6709023027 With regards, GitHub Actions via GitBox
Re: [PR] Add files via upload [rocketmq]
lizhanhui commented on PR #7521: URL: https://github.com/apache/rocketmq/pull/7521#issuecomment-1798125492 I do not see how this PR would be relevant to this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add files via upload [rocketmq]
lizhanhui closed pull request #7521: Add files via upload URL: https://github.com/apache/rocketmq/pull/7521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Misspell Check" is working again!
The GitHub Actions job "Misspell Check" on rocketmq.git has succeeded. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439768 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user bibhanshu12 (triggered by lizhanhui). Head commit for run: c2c39bf8a7e053b8a2ef45b7632ce6fba30e4e3f / Bibhanshu <130032629+bibhansh...@users.noreply.github.com> Add files via upload Report URL: https://github.com/apache/rocketmq/actions/runs/6709023029 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "License checker" is working again!
The GitHub Actions job "License checker" on rocketmq.git has succeeded. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439767 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439778 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user bibhanshu12 (triggered by bibhanshu12). Head commit for run: 00965d8c11833237d5c9cd925664a1c456493cee / lk [ISSUE #7531] Clear POP_CK when sending messages (#7532) Report URL: https://github.com/apache/rocketmq/actions/runs/6782512054 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user golden-yang (triggered by golden-yang). Head commit for run: 00965d8c11833237d5c9cd925664a1c456493cee / lk [ISSUE #7531] Clear POP_CK when sending messages (#7532) Report URL: https://github.com/apache/rocketmq/actions/runs/6782586257 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user bibhanshu12 (triggered by lizhanhui). Head commit for run: c2c39bf8a7e053b8a2ef45b7632ce6fba30e4e3f / Bibhanshu <130032629+bibhansh...@users.noreply.github.com> Add files via upload Report URL: https://github.com/apache/rocketmq/actions/runs/6709023042 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439766 With regards, GitHub Actions via GitBox
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
codecov-commenter commented on PR #7436: URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1798182052 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7436](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (371b765) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/0f01df460f78c383a35338aa77eb0fda4c8f2dd3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0f01df4) will **increase** coverage by `0.08%`. > Report is 15 commits behind head on develop. > The diff coverage is `39.39%`. ```diff @@ Coverage Diff @@ ## develop#7436 +/- ## = + Coverage 42.97% 43.06% +0.08% - Complexity 9665 9686 +21 = Files 1161 1161 Lines 8392083926 +6 Branches 1089810899 +1 = + Hits 3606436139 +75 + Misses 4337943314 -65 + Partials4477 4473 -4 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...q/tieredstore/common/TieredMessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvbW1vbi9UaWVyZWRNZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | `68.91% <100.00%> (ø)` | | | [...q/tieredstore/provider/posix/PosixFileSegment.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL3Byb3ZpZGVyL3Bvc2l4L1Bvc2l4RmlsZVNlZ21lbnQuamF2YQ==) | `67.56% <100.00%> (ø)` | | | [...he/rocketmq/broker/processor/PopReviveService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==) | `36.38% <25.00%> (ø)` | | | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `40.29% <31.25%> (-0.24%)` | :arrow_down: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user bibhanshu12 (triggered by lizhanhui). Head commit for run: c2c39bf8a7e053b8a2ef45b7632ce6fba30e4e3f / Bibhanshu <130032629+bibhansh...@users.noreply.github.com> Add files via upload Report URL: https://github.com/apache/rocketmq/actions/runs/6709023037 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439769 With regards, GitHub Actions via GitBox
Re: [I] [Doc] Documentation Related 有对nameserver进行权限访问吗。 [rocketmq]
hacats commented on issue #7542: URL: https://github.com/apache/rocketmq/issues/7542#issuecomment-1798266284 +1 这是一个安全问题，我们的安全部门多次向我们报告了`nameserver`未授权修改配置漏洞，我们研发侧是难以解决的 虽然你们的`CVE-2023-37582`修复代码禁止了关键属性，但是其他属性被黑客恶意修改，可能导致服务不可用，使用`mqadmin`修改的数据包抓一下就能获得报文，比如修改线程数为1，容量为1，或者关闭某些flag导致服务不可用 这个问题是需要尽快解决的 This is a security issue, and our security department has repeatedly reported to us the 'nameserver' unauthorized configuration modification vulnerability, which is difficult for our research and development team to solve Although your 'CVS 2023 37582' fix code prohibits key attributes, other attributes have been maliciously modified by hackers, which may cause the service to be unusable. Use the 'mqadmin' modified packet to grab the message and obtain it, such as modifying the number of threads to 1 and the capacity to 1, or closing certain flags to cause the service to be unusable This problem needs to be resolved as soon as possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439778 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user golden-yang (triggered by lizhanhui). Head commit for run: 371b765cb22038f7e2e9c017a3456c64def6630c / yangguodong.cn revert README.md change Report URL: https://github.com/apache/rocketmq/actions/runs/6555439769 With regards, GitHub Actions via GitBox
Re: [I] The main method of class “MonitorService” could be removed [rocketmq]
github-actions[bot] commented on issue #5472: URL: https://github.com/apache/rocketmq/issues/5472#issuecomment-1800603565 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [idea] Add rocketmq icon to idea. [rocketmq]
github-actions[bot] commented on PR #5470: URL: https://github.com/apache/rocketmq/pull/5470#issuecomment-1800603951 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Can I switch back to the master-slave cluster from the DLeger cluster mode？ [rocketmq]
github-actions[bot] commented on issue #5469: URL: https://github.com/apache/rocketmq/issues/5469#issuecomment-1800604379 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix cmd resetOffsetByTime bug with batch messages #5445 [rocketmq]
github-actions[bot] commented on PR #5456: URL: https://github.com/apache/rocketmq/pull/5456#issuecomment-1800604849 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Delete Duplicate Code in DefaultRequestProcessor [rocketmq]
github-actions[bot] commented on PR #5435: URL: https://github.com/apache/rocketmq/pull/5435#issuecomment-1800605413 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7511]Lock granularity issue causing LMQ message loss [rocketmq]
RongtongJin commented on PR #7525: URL: https://github.com/apache/rocketmq/pull/7525#issuecomment-1800901791 LGTM～ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7511]Lock granularity issue causing LMQ message loss [rocketmq]
RongtongJin merged PR #7525: URL: https://github.com/apache/rocketmq/pull/7525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Lock granularity issue causing LMQ message loss [rocketmq]
RongtongJin closed issue #7511: [Bug] Lock granularity issue causing LMQ message loss URL: https://github.com/apache/rocketmq/issues/7511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7511] Lock granularity issue causing LMQ message loss (#7525)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new ead3d90501 [ISSUE #7511] Lock granularity issue causing LMQ message
loss (#7525)
ead3d90501 is described below
commit ead3d905016d9db4785a46beaa555c7fafd4f9bb
Author: Dongyuan Pan
AuthorDate: Wed Nov 8 10:40:52 2023 +0800
[ISSUE #7511] Lock granularity issue causing LMQ message loss (#7525)
* bug fix: assignOffset and increaseOffset in LMQ has concurrency issues in
topicQueueLock, should be in putMessageLock
* fix MultiDispatchTest
* fix MultiDispatchTest
* fix unit test
---
.../common/message/MessageExtBrokerInner.java | 10 ++
.../java/org/apache/rocketmq/store/CommitLog.java | 94 ++--
.../org/apache/rocketmq/store/ConsumeQueue.java| 44 +---
.../apache/rocketmq/store/DefaultMessageStore.java | 1 -
.../apache/rocketmq/store/MessageExtEncoder.java | 118 ++---
.../org/apache/rocketmq/store/MultiDispatch.java | 77 ++
.../store/queue/AbstractConsumeQueueStore.java | 10 ++
.../store/queue/ConsumeQueueInterface.java | 1 -
.../store/queue/ConsumeQueueStoreInterface.java| 14 +++
...{MultiDispatch.java => MultiDispatchUtils.java} | 17 +--
.../rocketmq/store/queue/QueueOffsetOperator.java | 6 +-
.../rocketmq/store/queue/RocksDBConsumeQueue.java | 42
.../apache/rocketmq/store/AppendCallbackTest.java | 6 +-
.../apache/rocketmq/store/AppendPropCRCTest.java | 5 +-
.../apache/rocketmq/store/MultiDispatchTest.java | 12 +--
.../rocketmq/store/kv/CompactionLogTest.java | 2 +-
16 files changed, 322 insertions(+), 137 deletions(-)
diff --git
a/common/src/main/java/org/apache/rocketmq/common/message/MessageExtBrokerInner.java
b/common/src/main/java/org/apache/rocketmq/common/message/MessageExtBrokerInner.java
index 52501dbca0..147f23f123 100644
---
a/common/src/main/java/org/apache/rocketmq/common/message/MessageExtBrokerInner.java
+++
b/common/src/main/java/org/apache/rocketmq/common/message/MessageExtBrokerInner.java
@@ -28,6 +28,8 @@ public class MessageExtBrokerInner extends MessageExt {
private ByteBuffer encodedBuff;
+private volatile boolean encodeCompleted;
+
private MessageVersion version = MessageVersion.MESSAGE_VERSION_V1;
public ByteBuffer getEncodedBuff() {
@@ -92,4 +94,12 @@ public class MessageExtBrokerInner extends MessageExt {
this.setPropertiesString(MessageDecoder.messageProperties2String(this.getProperties()));
}
}
+
+public boolean isEncodeCompleted() {
+return encodeCompleted;
+}
+
+public void setEncodeCompleted(boolean encodeCompleted) {
+this.encodeCompleted = encodeCompleted;
+}
}
diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
index 6c3afde70f..35c1d0e2d7 100644
--- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
+++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
@@ -35,6 +35,7 @@ import java.util.function.Supplier;
import java.util.stream.Collectors;
import com.sun.jna.NativeLong;
import com.sun.jna.Pointer;
+import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.common.MixAll;
import org.apache.rocketmq.common.ServiceThread;
import org.apache.rocketmq.common.SystemClock;
@@ -56,6 +57,7 @@ import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
import org.apache.rocketmq.store.MessageExtEncoder.PutMessageThreadLocal;
import org.apache.rocketmq.store.config.BrokerRole;
import org.apache.rocketmq.store.config.FlushDiskType;
+import org.apache.rocketmq.store.config.MessageStoreConfig;
import org.apache.rocketmq.store.ha.HAService;
import org.apache.rocketmq.store.ha.autoswitch.AutoSwitchHAService;
import org.apache.rocketmq.store.logfile.MappedFile;
@@ -101,6 +103,7 @@ public class CommitLog implements Swappable {
protected int commitLogSize;
private final boolean enabledAppendPropCRC;
+protected final MultiDispatch multiDispatch;
public CommitLog(final DefaultMessageStore messageStore) {
String storePath =
messageStore.getMessageStoreConfig().getStorePathCommitLog();
@@ -119,13 +122,11 @@ public class CommitLog implements Swappable {
this.flushManager = new DefaultFlushManager();
this.coldDataCheckService = new ColdDataCheckService();
-this.appendMessageCallback = new DefaultAppendMessageCallback();
+this.appendMessageCallback = new
DefaultAppendMessageCallback(defaultMessageStore.getMessageStoreConfig());
putMessageThreadLocal = new ThreadLocal() {
@Override
protected PutMessageThreadLocal initialValue() {
-re
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ead3d905016d9db4785a46beaa555c7fafd4f9bb / Dongyuan Pan [ISSUE #7511] Lock granularity issue causing LMQ message loss (#7525) * bug fix: assignOffset and increaseOffset in LMQ has concurrency issues in topicQueueLock, should be in putMessageLock * fix MultiDispatchTest * fix MultiDispatchTest * fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6793084276 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ead3d905016d9db4785a46beaa555c7fafd4f9bb / Dongyuan Pan [ISSUE #7511] Lock granularity issue causing LMQ message loss (#7525) * bug fix: assignOffset and increaseOffset in LMQ has concurrency issues in topicQueueLock, should be in putMessageLock * fix MultiDispatchTest * fix MultiDispatchTest * fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6793084270 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: ead3d905016d9db4785a46beaa555c7fafd4f9bb / Dongyuan Pan [ISSUE #7511] Lock granularity issue causing LMQ message loss (#7525) * bug fix: assignOffset and increaseOffset in LMQ has concurrency issues in topicQueueLock, should be in putMessageLock * fix MultiDispatchTest * fix MultiDispatchTest * fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6793084273 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7480] Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]
RongtongJin commented on code in PR #7488:
URL: https://github.com/apache/rocketmq/pull/7488#discussion_r1385924653
##
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##
@@ -291,6 +291,19 @@ public void recover() {
}
currQueueOffset = Math.min(currQueueOffset,
timerCheckpoint.getMasterTimerQueueOffset());
+ConsumeQueueInterface cq =
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+// Correction based consume queue
+if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {
Review Comment:
主要是commitlog和cq数据被截断的时候，但timer这里是不会修正的
##
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##
@@ -291,6 +291,19 @@ public void recover() {
}
currQueueOffset = Math.min(currQueueOffset,
timerCheckpoint.getMasterTimerQueueOffset());
+ConsumeQueueInterface cq =
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+// Correction based consume queue
+if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {
Review Comment:
主要是commitlog和cq数据被截断的时候，但timer这里是不会修正的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] nested transaction demo? [rocketmq-client-go]
DouFuJuShi commented on issue #1097: URL: https://github.com/apache/rocketmq-client-go/issues/1097#issuecomment-1800970689 TKS！！！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] nested transaction demo? [rocketmq-client-go]
DouFuJuShi closed issue #1097: nested transaction demo? URL: https://github.com/apache/rocketmq-client-go/issues/1097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] when I delete unused topic, topic consume queue on the standby node is not deleted synchronously. [rocketmq]
iamgd67 commented on issue #7264: URL: https://github.com/apache/rocketmq/issues/7264#issuecomment-1801255997 if receate the same name topic and send message, slave will produce log repeatlly `WARN ReputMessageService - Build consume queue repeatedly, expectLogicOffset: xxx currentLogicOffset: xxx Topic: QID: x Diff: -` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7263& ISSUE #7264]Fix to delete synchronously the consumption offset data of the subscription group on the standby node, when execute command 'mqadmin deleteSubGroup -b xxx -g xxx -r
iamgd67 commented on PR #7273: URL: https://github.com/apache/rocketmq/pull/7273#issuecomment-1801262033 lgtm this bothers me too. I copy master's consumerqueue data to slave and restart slave to fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7263& ISSUE #7264]Fix to delete synchronously the consumption offset data of the subscription group on the standby node, when execute command 'mqadmin deleteSubGroup -b xxx -g xxx -r
iamgd67 commented on PR #7273: URL: https://github.com/apache/rocketmq/pull/7273#issuecomment-1801266474 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
