RongtongJin commented on code in PR #7488:
URL: https://github.com/apache/rocketmq/pull/7488#discussion_r1385924653
##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -291,6 +291,19 @@ public void recover() {
}
currQueueOffset = Math.min(currQueueOffset,
timerCheckpoint.getMasterTimerQueueOffset());
+ ConsumeQueueInterface cq =
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+ // Correction based consume queue
+ if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {
Review Comment:
主要是commitlog和cq数据被截断的时候，但timer这里是不会修正的
##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -291,6 +291,19 @@ public void recover() {
}
currQueueOffset = Math.min(currQueueOffset,
timerCheckpoint.getMasterTimerQueueOffset());
+ ConsumeQueueInterface cq =
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+ // Correction based consume queue
+ if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {
Review Comment:
主要是commitlog和cq数据被截断的时候，但timer这里是不会修正的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
