[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 48ef5ced4639699e3ba207b1a648b1fd47649a69 / rongtong [ISSUE #7505] Do not validate the length when deleting a topic Report URL: https://github.com/apache/rocketmq/actions/runs/6663883965 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 7bad2e05ba392b7228b198f0838f98d76b1458d3 / zhouxiang Optimize updateTopicRouteInfoFromNameServer * Throw MQClientException for updateTopicRouteInfoFromNameServer * Add compatible updateTopicRouteInfoFromNameServerWithoutException method Report URL: https://github.com/apache/rocketmq/actions/runs/6663864605 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 6dbdcef8fdc9ef42ac90f51e3475eb762bc83f5c / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6664116868 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 6dbdcef8fdc9ef42ac90f51e3475eb762bc83f5c / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6664116861 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 48ef5ced4639699e3ba207b1a648b1fd47649a69 / rongtong [ISSUE #7505] Do not validate the length when deleting a topic Report URL: https://github.com/apache/rocketmq/actions/runs/6664143567 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 6dbdcef8fdc9ef42ac90f51e3475eb762bc83f5c / zhouxiang fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6664116865 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 033690e199e7a80daf52a15438f95bf6e5cfb580 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6664457161 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 033690e199e7a80daf52a15438f95bf6e5cfb580 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6664457163 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 033690e199e7a80daf52a15438f95bf6e5cfb580 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6664457166 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 48ef5ced4639699e3ba207b1a648b1fd47649a69 / rongtong [ISSUE #7505] Do not validate the length when deleting a topic Report URL: https://github.com/apache/rocketmq/actions/runs/6664481274 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] The broker supports idempotence in creating topics [rocketmq]
RongtongJin closed issue #7501: [Enhancement] The broker supports idempotence in creating topics URL: https://github.com/apache/rocketmq/issues/7501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
Dr-wgy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1782513022 https://heapdump.cn/article/6344684 in our production environment commitLog dispatch comsume queue and index slowly ``` 16:48:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 0 bytes 16:49:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 195011090 bytes 16:50:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 503128527 bytes 16:51:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 820827985 bytes 16:52:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 1119154950 bytes 16:53:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 1371931476 bytes 16:54:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 1627376302 bytes 16:55:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 1895197916 bytes 16:56:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 2172267528 bytes 16:57:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 2431757827 bytes 16:58:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 2710935695 bytes 16:59:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 2992111923 bytes 17:00:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 3265533055 bytes 17:01:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 3713616179 bytes 17:02:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 4121989447 bytes 17:03:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 4506883955 bytes 17:04:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 4831540126 bytes 17:05:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 5153375631 bytes 17:06:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 5477330907 bytes 17:07:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 5827133856 bytes 17:08:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 6174273510 bytes 17:09:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 6509742357 bytes 17:10:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 6848652654 bytes 17:11:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 7150862926 bytes 17:12:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 7432869470 bytes 17:13:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 7699771035 bytes 17:14:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 7948980439 bytes 17:15:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 8202390118 bytes 17:16:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 8125492927 bytes 17:17:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 7519621856 bytes 17:18:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 6779058147 bytes 17:19:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 5989943481 bytes 17:20:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 5039680763 bytes 17:21:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 4333049451 bytes 17:22:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 3563592630 bytes 17:23:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 851804170 bytes 17:24:02 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 1975 bytes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7501] The broker supports idempotence in creating topics [rocketmq]
RongtongJin merged PR #7502: URL: https://github.com/apache/rocketmq/pull/7502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: [ISSUE #7501] The broker supports idempotence in creating topics (#7502)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 26fa050148 [ISSUE #7501] The broker supports idempotence in creating
topics (#7502)
26fa050148 is described below
commit 26fa0501482bbf31c2a64a33f329ab9744ac3800
Author: fuyou001
AuthorDate: Fri Oct 27 16:28:17 2023 +0800
[ISSUE #7501] The broker supports idempotence in creating topics (#7502)
---
.../org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java | 7 +++
1 file changed, 7 insertions(+)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
index 004bf12acd..fbba6633b6 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -440,6 +440,13 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
return response;
}
+if
(topicConfig.equals(this.brokerController.getTopicConfigManager().getTopicConfigTable().get(topic)))
{
+LOGGER.info("Broker receive request to update or create topic={},
but topicConfig has no changes , so idempotent, caller address={}",
+requestHeader.getTopic(),
RemotingHelper.parseChannelRemoteAddr(ctx.channel()));
+response.setCode(ResponseCode.SUCCESS);
+return response;
+}
+
try {
this.brokerController.getTopicConfigManager().updateTopicConfig(topicConfig);
if
(brokerController.getBrokerConfig().isEnableSingleTopicRegister()) {
Re: [I] What circumstances will messages not be consumed or delay consumed? [rocketmq]
Dr-wgy commented on issue #2794: URL: https://github.com/apache/rocketmq/issues/2794#issuecomment-1782517450 https://heapdump.cn/article/5003784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6664797549 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6664797552 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6664797559 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6664797555 With regards, GitHub Actions via GitBox
[I] [Bug] CommitLog topicQueueLock.lock(topicQueueKey) 锁粒度问题，导致defaultMessageStore.assignOffset(msg) 中 给LMQ消息分配的INNER_MULTI_QUEUE_OFFSET重复，导致LMQ消费时，LMQ消息丢失 [rocketmq]
lzkisok opened a new issue, #7511: URL: https://github.com/apache/rocketmq/issues/7511 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Centos 7 ### RocketMQ version RMQ 5.1.4 ### JDK Version JDk 1.8 ### Describe the Bug 1，当并发发送两条MQ消息，设置相同的INNER_MULTI_DISPATCH，相当于DefaultMQProducer并发发送了两条同一个LMQ的消息（消息的LMQ相同，内容不同）。 2，当这两条消息发送到两个的MessageQuene 时，消息的queneId不同，topicQueueKey是topic-queneId，topicQueueLock.lock(topicQueueKey) 是锁各自queneId的，所以两条消息是并发处理的。 3，在消息并发处理时，defaultMessageStore.assignOffset(msg) 会同时从QueueOffsetOperator拿到LMQ的queneOffste，这时并发拿到的queneOffst相同，导致两条LMQ消息的INNER_MULTI_QUEUE_OFFSET 相同，LMQ 消息的offset重复 ### Steps to Reproduce 1，DefaultMQProducer并发发送两条相同LMQ的消息（消息的LMQ相同，内容不同）如： String secondTopic = "/r7"; setLmq(msg, new HashSet<>(Arrays.asList(TopicUtils.wrapLmq(firstTopic, secondTopic; 2. 观察RMQ 日志，确定两个消息的MessageQuene不同。 3. mqtt客户端消费，只消费到一条。 ### What Did You Expect to See? 在消息并发，且MessageQuene不同时，能正确设置LMQ消息的INNER_MULTI_QUEUE_OFFSET ### What Did You See Instead? 两条LMQ消息的INNER_MULTI_QUEUE_OFFSET 相同，LMQ 消息的offset重复 ### Additional Context  如上图：两条消息的INNER_MULTI_QUEUE_OFFSET相同  如上图：在DefaultMQProducer并发发送两条相同LMQ的消息（消息的LMQ相同，内容不同），这里的锁，对LMQ不适用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 当MQTT设备数量特别多，消息特别频繁的时候，notify的RPC 因为是每台服务器都通知的，每台服务器接受notify QPS会特别高 [rocketmq-mqtt]
pingww commented on issue #212: URL: https://github.com/apache/rocketmq-mqtt/issues/212#issuecomment-1782596206 > 比如10W台设备，每台设备每秒下发一个消息，每台服务器的notify RPC就是10W QPS 1）这10W QPS并不是一台服务器负责，而是通过RMQ消费负载均衡的notify 2）这个notify只是topic名称，没有消息体 3）notify可以按批（pull）合并降低qps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: c10b5d315d0f8e6030a72541aefc3295f49743bf / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6665399271 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6665428198 With regards, GitHub Actions via GitBox
Re: [I] [Bug] dledger集群消息丢失 [rocketmq]
GenerousMan commented on issue #7477: URL: https://github.com/apache/rocketmq/issues/7477#issuecomment-1782616428 Hello, I have verified the situation you mentioned. Below are some of my testing processes. ### Verification process  Send a message and save the sending status of one of the messages: SendResult [sendStatus=SEND_OK, msgId=AC1004C454E75D099F62895F43C403E7, offsetMsgId=AC1004C478D3001181B9, messageQueue=MessageQueue [topic=TopicTest, brokerName=RaftNode00, queueId=1], queueOffset=999] Close using the test script and restart.  Still able to query:  Forcefully kill the process after startup and observe the query result:   ### Preliminary conclusion After killing the broker with kill -9, it is indeed possible that the msgId cannot be found. The index folder is emptied after restarting, indicating that the recover process cleans up the index files.  However, the offsetId can still be found, indicating that the message is not lost and is still in the commit log. Further investigation is needed to determine the specific cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 开启5个子线程发送5条MQ消息，MqttConsumer 只能收到4条或者更少，必现。 [rocketmq-mqtt]
lzkisok commented on issue #215: URL: https://github.com/apache/rocketmq-mqtt/issues/215#issuecomment-1782666863 能私信下吗？给个私信方式，咋们交流交流 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: c10b5d315d0f8e6030a72541aefc3295f49743bf / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6665399280 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: c10b5d315d0f8e6030a72541aefc3295f49743bf / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6665399280 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: c10b5d315d0f8e6030a72541aefc3295f49743bf / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6665399280 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: c10b5d315d0f8e6030a72541aefc3295f49743bf / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/6665399280 With regards, GitHub Actions via GitBox
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
nowinkeyy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1782753245 @Dr-wgy Hi, which version are you using, this optimization was added in rocketmq-all-5.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
Dr-wgy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1782794003 > @Dr-wgy Hi, which version are you using, this optimization was added in rocketmq-all-5.1.0. 4.7.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
nowinkeyy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1782827863 > > @Dr-wgy Hi, which version are you using, this optimization was added in rocketmq-all-5.1.0. > > 4.7.1 Versions prior to 5.1.0 did have this issue, and updating your version should alleviate the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] TimerMessageStoreTest.testStateAndRecover is unstable [rocketmq]
github-actions[bot] commented on issue #5412: URL: https://github.com/apache/rocketmq/issues/5412#issuecomment-1783626949 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] could consumer update sql92 properties dynamic? [rocketmq]
github-actions[bot] commented on issue #5396: URL: https://github.com/apache/rocketmq/issues/5396#issuecomment-1783626980 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7509] Optimize updateTopicRouteInfoFromNameServer [rocketmq]
joeCarf commented on code in PR #7510:
URL: https://github.com/apache/rocketmq/pull/7510#discussion_r1375154890
##
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##
@@ -785,6 +793,7 @@ public boolean updateTopicRouteInfoFromNameServer(final
String topic, boolean is
if (!topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) &&
!topic.equals(TopicValidator.AUTO_CREATE_TOPIC_KEY_TOPIC)) {
log.warn("updateTopicRouteInfoFromNameServer
Exception", e);
}
+throw e;
Review Comment:
先log再throw的写法可能会造成上层出现重复打印error的情况
##
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##
@@ -785,6 +793,7 @@ public boolean updateTopicRouteInfoFromNameServer(final
String topic, boolean is
if (!topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) &&
!topic.equals(TopicValidator.AUTO_CREATE_TOPIC_KEY_TOPIC)) {
log.warn("updateTopicRouteInfoFromNameServer
Exception", e);
}
+throw e;
Review Comment:
先log再throw的写法可能会造成上层出现重复打印error的情况
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
Dr-wgy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1783683116 > > > @Dr-wgy Hi, which version are you using, this optimization was added in rocketmq-all-5.1.0. > > > > > > 4.7.1 > > Versions prior to 5.1.0 did have this issue, and updating your version should alleviate the problem. `private boolean enableBuildConsumeQueueConcurrently = false; ` enableBuildConsumeQueueConcurrently = true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Read Commitlogs concurrently to speed up generation of the consumeQueue [rocketmq]
nowinkeyy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1783691862 > ` private boolean enableBuildConsumeQueueConcurrently = false;` enableBuildConsumeQueueConcurrently = true right？ yes, you are right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
