[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6584373557 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6584373555 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6584373553 With regards, GitHub Actions via GitBox
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772364020 https://github.com/apache/rocketmq/assets/52153761/b801a8e5-773b-472d-8304-1327ff800e52";> updateOffset这个方法有两个实现，一个是在本地存储offset，一个是将offset存在broker里。这两种实现分别对应着广播消费和集群消费模式，因此我理解这里的comment有些模糊，但是大意应该没有问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
joeCarf commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772366984 > > 看了下代码里，打出这个log的地方有很多。但大多会有其他的warn 或者 error日志，辛苦看下是否有其他日志呢 > > 代码中没有这个日志 是rocketmq底层打印出来的 有一台服务器不报这个 都是一样的配置 是rocketmq的代码。看下你的命令行中是否有其他日志打印出来。如果没有的话，由于这个日志和netty通信相关，我怀疑是不是防火墙或者端口的配置问题呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
1607004157 commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772429746 > > > 看了下代码里，打出这个log的地方有很多。但大多会有其他的warn 或者 error日志，辛苦看下是否有其他日志呢 > > > > > > 代码中没有这个日志 是rocketmq底层打印出来的 有一台服务器不报这个 都是一样的配置 > > 是rocketmq的代码。看下你的命令行中是否有其他日志打印出来。如果没有的话，由于这个日志和netty通信相关，我怀疑是不是防火墙或者端口的配置问题呢 只有这个日志 再没有其他的，防火墙是关着的，我进行telnet是通的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
tensory2022 commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772543186 > https://user-images.githubusercontent.com/52153761/276881360-b801a8e5-773b-472d-8304-1327ff800e52.png";> updateOffset这个方法有两个实现，一个是在本地存储offset，一个是将offset存在broker里。这两种实现分别对应着广播消费和集群消费模式，因此我理解这里的comment有些模糊，但是大意应该没有问题 Thanks for your reply :) There is no difference in the implementations of method updateOffset() between LocalFileOffsetStore and RemoteBrokerOffsetStore. The codes of updateOffset() in RemoteBrokerOffsetStore (Clustering mode as you said) are as follows：  As per the code, I can not found the interaction between client and broker. Therefore, I still think the comment should be corrected. You are right with the fact that the scheduled service would update offset from client memory to broker disk. However, that action is not directly to update offset to broker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772555145 @tensory2022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1772554676 图中的代码只更新了内存中的offset。在`RemoteBrokerOffsetStore`中，有一`persistAll`函数，会将整个offsetTable更新到对应的broker https://github.com/apache/rocketmq/assets/52153761/87751575-c2e3-4eba-bc2a-7ec1c14ab9d0";> 而`LocalFileOffsetStore`中只会写到本地文件中 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] rocketmq 5. x 构建镜像，使用operator启动集群时，namesrv无法启动 [rocketmq-operator]
Cloud-Yao opened a new issue, #188: URL: https://github.com/apache/rocketmq-operator/issues/188 **BUG REPORT** 1. Please describe the issue you observed: 我使用的是rocketmq5.x的版本，用的是示例的脚本构建的broker和namesrv的镜像，然后使用官方的提供的example启动一个集群，但是namesrv一直启动不起来，namesrv中的报错日志如下，broker主从节点启动都没有问题。5.0.x的版本和5.1.x的版本我都试过了，都是namesrv这个地方报错，想问一下这个是什么情况？ // namesrv日志报错 cat: can't open '/sys/fs/cgroup/memory/memory.limit_in_bytes': No such file or directory /root/rocketmq/nameserver/bin/runserver.sh: line 58: arithmetic syntax error // 下面是我的启动集群的配置文件（使用的官方的） apiVersion: v1 kind: ConfigMap metadata: name: broker-config namespace: default data: # BROKER_MEM sets the broker JVM, if set to "" then Xms = Xmx = max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB)) BROKER_MEM: " -Xms1g -Xmx1g -Xmn1g " broker-common.conf: | # brokerClusterName, brokerName, brokerId are automatically generated by the operator and do not set it manually!!! deleteWhen=04 fileReservedTime=48 flushDiskType=ASYNC_FLUSH # set brokerRole to ASYNC_MASTER or SYNC_MASTER. DO NOT set to SLAVE because the replica instance will automatically be set!!! brokerRole=ASYNC_MASTER --- apiVersion: rocketmq.apache.org/v1alpha1 kind: Broker metadata: # name of broker cluster name: broker namespace: default spec: # size is the number of the broker cluster, each broker cluster contains a master broker and [replicaPerGroup] replica brokers. size: 1 # nameServers is the [ip:port] list of name service nameServers: "" # replicaPerGroup is the number of each broker cluster replicaPerGroup: 1 # brokerImage is the customized docker image repo of the RocketMQ broker brokerImage: registry.cn-hangzhou.aliyuncs.com/super-yao/supertest:rocketmq-broker-operator-5.0.0 # imagePullPolicy is the image pull policy imagePullPolicy: IfNotPresent # resources describes the compute resource requirements and limits resources: requests: memory: "512Mi" cpu: "250m" limits: memory: "512Mi" cpu: "250m" # allowRestart defines whether allow pod restart allowRestart: true # storageMode can be EmptyDir, HostPath, StorageClass storageMode: EmptyDir # hostPath is the local path to store data hostPath: /data/rocketmq/broker # scalePodName is [Broker name]-[broker group number]-master-0 scalePodName: broker-0-master-0 # env defines custom env, e.g. BROKER_MEM env: - name: BROKER_MEM valueFrom: configMapKeyRef: name: broker-config key: BROKER_MEM # volumes defines the broker.conf volumes: - name: broker-config configMap: name: broker-config items: - key: broker-common.conf path: broker-common.conf # volumeClaimTemplates defines the storageClass volumeClaimTemplates: - metadata: name: broker-storage spec: accessModes: - ReadWriteOnce storageClassName: rocketmq-storage resources: requests: storage: 8Gi --- apiVersion: rocketmq.apache.org/v1alpha1 kind: NameService metadata: name: name-service namespace: default spec: # size is the the name service instance number of the name service cluster size: 1 # nameServiceImage is the customized docker image repo of the RocketMQ name service nameServiceImage: registry.cn-hangzhou.aliyuncs.com/super-yao/supertest:rocketmq-namesrv-operator-5.0.0 # imagePullPolicy is the image pull policy imagePullPolicy: IfNotPresent # hostNetwork can be true or false hostNetwork: true # Set DNS policy for the pod. # Defaults to "ClusterFirst". # Valid values are 'ClusterFirstWithHostNet', 'ClusterFirst', 'Default' or 'None'. # DNS parameters given in DNSConfig will be merged with the policy selected with DNSPolicy. # To have DNS options set along with hostNetwork, you have to specify DNS policy # explicitly to 'ClusterFirstWithHostNet'. dnsPolicy: ClusterFirstWithHostNet # resources describes the compute resource requirements and limits resources: requests: memory: "1024Mi" cpu: "500m" limits: memory: "1024Mi" cpu: "500m" # storageMode can be EmptyDir, HostPath, StorageClass storageMode: EmptyDir # hostPath is the local path to store data hostPath: /data/rocketmq/nameserver # volumeClaimTemplates defines the storageClass volumeClaimTemplates: - metadata: name: namesrv-storage spec: accessModes: - ReadWriteOnce storageClassName: rocketmq-storage resources: requests:
Re: [I] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] commented on issue #5359: URL: https://github.com/apache/rocketmq/issues/5359#issuecomment-1773541429 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Duplicate code in TimerFlushService [rocketmq]
github-actions[bot] commented on issue #5327: URL: https://github.com/apache/rocketmq/issues/5327#issuecomment-1773541564 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Duplicate code in TimerFlushService [rocketmq]
github-actions[bot] closed issue #5327: Duplicate code in TimerFlushService URL: https://github.com/apache/rocketmq/issues/5327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] DefaultLitePullConsumerImpl's persistConsumeOffset method should not be called by MQClientInstance if DefaultLitePullConsumerImpl disable autoCommit [rocketmq]
github-actions[bot] commented on issue #5315: URL: https://github.com/apache/rocketmq/issues/5315#issuecomment-1773541597 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE#5359] Optimize the heartbeat check pre-collection address [rocketmq]
github-actions[bot] commented on PR #5360: URL: https://github.com/apache/rocketmq/pull/5360#issuecomment-1773541392 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Error core-concept url in comment. [rocketmq]
github-actions[bot] commented on issue #5358: URL: https://github.com/apache/rocketmq/issues/5358#issuecomment-1773541463 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Resolve the unstable unit tests [rocketmq]
github-actions[bot] commented on issue #5331: URL: https://github.com/apache/rocketmq/issues/5331#issuecomment-1773541501 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] How to use Rocketmq Ledger cluster mode for spring boot？ [rocketmq]
github-actions[bot] commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1773541530 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-e2e): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq-e2e.git has failed. Run started by GitHub user Zintoki (triggered by Zintoki). Head commit for run: 51a01c18fd9eb2652dbf3ec97a9877d48e00cd89 / XiaoWei Zhang <1403767...@qq.com> Added the java4.x client cluster filter pull test content (#51) * Added the java4.x client cluster filter pull test content * Improved the test content, adding the test content of batchproducer, transactions, loadbacing, offset, retry and other scenarios * Refine old tests and add retry test scenarios * Refine old tests and normalize non-standard code Report URL: https://github.com/apache/rocketmq-e2e/actions/runs/6594371749 With regards, GitHub Actions via GitBox
[GH] (rocketmq-e2e): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq-e2e.git has failed. Run started by GitHub user Zintoki (triggered by Zintoki). Head commit for run: 51a01c18fd9eb2652dbf3ec97a9877d48e00cd89 / XiaoWei Zhang <1403767...@qq.com> Added the java4.x client cluster filter pull test content (#51) * Added the java4.x client cluster filter pull test content * Improved the test content, adding the test content of batchproducer, transactions, loadbacing, offset, retry and other scenarios * Refine old tests and add retry test scenarios * Refine old tests and normalize non-standard code Report URL: https://github.com/apache/rocketmq-e2e/actions/runs/6594398389 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]
joeCarf commented on code in PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#discussion_r1367675718 ## store/src/main/java/org/apache/rocketmq/store/CommitLog.java: ## @@ -61,7 +61,6 @@ import org.apache.rocketmq.store.logfile.MappedFile; import org.apache.rocketmq.store.util.LibC; import org.rocksdb.RocksDBException; - Review Comment: maybe no need to reformat the import in this file and `MessageConfig.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
