Re: [I] producer.SendAsync panic: runtime error: invalid memory address or nil pointer dereference [rocketmq-client-go]
474903784 commented on issue #1102: URL: https://github.com/apache/rocketmq-client-go/issues/1102#issuecomment-1770198231 miss return when err != nil，so occur panic: runtime error: invalid memory address or nil pointer dereference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] consumer Exception zlib error [rocketmq-client-cpp]
zadley commented on issue #453: URL: https://github.com/apache/rocketmq-client-cpp/issues/453#issuecomment-1770272399 我们也碰到这个问题了，请问下这个问题修复了没？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] option to control not reading all message log on startup. 启动时可配置不读取所有消息日志 [rocketmq]
iamgd67 opened a new issue, #7478: URL: https://github.com/apache/rocketmq/issues/7478 ### Is Your Feature Request Related to a Problem? yes, when there are many message log files, startup time will be very long(tens of minuts), even set `checkCRCOnRecover=false` won't help 消息文件多时，启动会很慢，配置了`checkCRCOnRecover=false` 效果也不大，因为还是会去读所有文件内容。 ### Describe the Solution You'd Like when set `checkCRCOnRecover=false` not read log file content on startup 配置了 `checkCRCOnRecover=false` 的话，不在启动时读取消息日志内容 ### Describe Alternatives You've Considered another config flag to control read content behavior 添加一个控制是否读取消息日志内容的配置 ### Additional Context cloud evn machine, disk very poor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #1102] fix send async err occur panic: runtime error: invalid … [rocketmq-client-go]
474903784 opened a new pull request, #1104: URL: https://github.com/apache/rocketmq-client-go/pull/1104 miss return when send async err, so occur panic: runtime error: invalid memory address or nil pointer #1102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large [rocketmq]
iamgd67 opened a new pull request, #7479: URL: https://github.com/apache/rocketmq/pull/7479 ### Which Issue(s) This PR Fixes Fixes #7478 ### Brief Description see issue #7478 ### How Did You Test This Change? tens of minuts reduced to about 1 minuts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]
RongtongJin opened a new issue, #7480: URL: https://github.com/apache/rocketmq/issues/7480 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Linux ### RocketMQ version 5.1.4 ### JDK Version 1.8 ### Describe the Bug The offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated  Then currentOffset is not moving  Timer messages are lost ### Steps to Reproduce https://github.com/apache/rocketmq/pull/7468 Regarding the validation of this PR, when performing an in-place upgrade on a broker with data and both enabledAppendPropCRC and forceVerifyPropCRC are set to true, the commitlog and consumeQueue are truncated. However, the currentQueueOffset in TimerMessageStore remains stuck. ### What Did You Expect to See? The currentQueueOffset in timerMessageStore will be corrected when the commitlog and consumeQueue are truncate ### What Did You See Instead? The currentQueueOffset in timerMessageStore remains stuck. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]
RongtongJin commented on issue #7480: URL: https://github.com/apache/rocketmq/issues/7480#issuecomment-1770361716 @guyinyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: facf9cc9210b7a96d9d886b441de497d5081cad4 / Liu Qiang(BSS-HZ) [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large Report URL: https://github.com/apache/rocketmq/actions/runs/6572173073 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 14408303e45651a05c4c09763f3b71c6c46431b9 / 67 <6...@gd67.com> [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large Report URL: https://github.com/apache/rocketmq/actions/runs/6572201766 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: facf9cc9210b7a96d9d886b441de497d5081cad4 / Liu Qiang(BSS-HZ) [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large Report URL: https://github.com/apache/rocketmq/actions/runs/6572173086 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large [rocketmq]
codecov-commenter commented on PR #7479: URL: https://github.com/apache/rocketmq/pull/7479#issuecomment-1770404834 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7479](https://app.codecov.io/gh/apache/rocketmq/pull/7479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (facf9cc) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.04%`. > Report is 1 commits behind head on develop. > The diff coverage is `66.66%`. > :exclamation: Current head facf9cc differs from pull request most recent head 1440830. Consider uploading reports for the commit 1440830 to get more accurate results ```diff @@ Coverage Diff @@ ## develop#7479 +/- ## = + Coverage 42.93% 42.98% +0.04% - Complexity 9660 9673 +13 = Files 1161 1161 Lines 8393083930 Branches 1089810898 = + Hits 3603836077 +39 + Misses 4341043376 -34 + Partials4482 4477 -5 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `57.96% <100.00%> (+0.08%)` | :arrow_up: | | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `77.56% <0.00%> (-0.82%)` | :arrow_down: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7479/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Invalid key/value in long polling is not removed from Map [rocketmq]
yx9o opened a new issue, #7481: URL: https://github.com/apache/rocketmq/issues/7481 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment mac ### RocketMQ version master ### JDK Version jdk17 ### Describe the Bug Invalid Consumer data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` will not be removed https://github.com/apache/rocketmq/assets/12792261/c2cccd3b-2e34-4c18-a676-5d370fb66983";> https://github.com/apache/rocketmq/assets/12792261/eb07e894-4dee-4c14-8528-48305b8365e2";> ### Steps to Reproduce 1. Start Broker 2. Create a Topic and send a message 3. Start Consumer. When the pull message returns `ResponseCode.PULL_NOT_FOUND`, it will be added to `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` 4. But when the `Consumer` is stopped, the data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` still exists ### What Did You Expect to See? After `Consumer` is stopped, the matching data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` is removed ### What Did You See Instead? After `Consumer` is stopped, the matching data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` is still there ### Additional Context We should remove `key` under the condition that `null == mpr || null == mpr.cloneListAndClear()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Invalid key/value in long polling is not removed from Map [rocketmq]
yx9o commented on issue #7481: URL: https://github.com/apache/rocketmq/issues/7481#issuecomment-1770420471 Hi @RongtongJin , please help check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 14408303e45651a05c4c09763f3b71c6c46431b9 / 67 <6...@gd67.com> [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large Report URL: https://github.com/apache/rocketmq/actions/runs/6572201755 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7478] On startup, if not check crc, not read body. avoid startup too slow when data is large [rocketmq]
iamgd67 commented on PR #7479: URL: https://github.com/apache/rocketmq/pull/7479#issuecomment-1770557340 Failed tests seem unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: e078d669282f964bda5ee0d3a702a06282a3e478 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6573572286 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7231] Fix: proxy client language error [rocketmq]
weihubeats commented on PR #7200: URL: https://github.com/apache/rocketmq/pull/7200#issuecomment-1770587995 Maybe this pr can be merged now. @RongtongJin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: e078d669282f964bda5ee0d3a702a06282a3e478 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6573572295 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c952c1aa80269efa162519b1c0e56774ced75ae7 / 67 <6...@gd67.com> same exception as try read body Report URL: https://github.com/apache/rocketmq/actions/runs/6575578680 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: dbc633d92b6c8c35922234611d698d3cb0a1a234 / Ji Juntao Check the input yaml and the path in ACL (#7475) * check the input yaml and the path. * only modify the path, no yaml. * remove useless import Report URL: https://github.com/apache/rocketmq/actions/runs/6575593576 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c952c1aa80269efa162519b1c0e56774ced75ae7 / 67 <6...@gd67.com> same exception as try read body Report URL: https://github.com/apache/rocketmq/actions/runs/6575578669 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c952c1aa80269efa162519b1c0e56774ced75ae7 / 67 <6...@gd67.com> same exception as try read body Report URL: https://github.com/apache/rocketmq/actions/runs/6575578671 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: b1e3047eb0813cdbb76d9cb6b264d6665428c075 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6575703713 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: dbc633d92b6c8c35922234611d698d3cb0a1a234 / Ji Juntao Check the input yaml and the path in ACL (#7475) * check the input yaml and the path. * only modify the path, no yaml. * remove useless import Report URL: https://github.com/apache/rocketmq/actions/runs/6575718701 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: b1e3047eb0813cdbb76d9cb6b264d6665428c075 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6575703710 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: b1e3047eb0813cdbb76d9cb6b264d6665428c075 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6575703708 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: b1e3047eb0813cdbb76d9cb6b264d6665428c075 / 67 <6...@gd67.com> comments Report URL: https://github.com/apache/rocketmq/actions/runs/6575703728 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: fe92edf172120da726a92bf9230fe7e112ddb68a / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6575871718 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: dbc633d92b6c8c35922234611d698d3cb0a1a234 / Ji Juntao Check the input yaml and the path in ACL (#7475) * check the input yaml and the path. * only modify the path, no yaml. * remove useless import Report URL: https://github.com/apache/rocketmq/actions/runs/6575890036 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: fe92edf172120da726a92bf9230fe7e112ddb68a / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6575871719 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: fe92edf172120da726a92bf9230fe7e112ddb68a / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6575871713 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: fe92edf172120da726a92bf9230fe7e112ddb68a / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6575871701 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c952c1aa80269efa162519b1c0e56774ced75ae7 / 67 <6...@gd67.com> same exception as try read body Report URL: https://github.com/apache/rocketmq/actions/runs/6575578673 With regards, GitHub Actions via GitBox
[PR] fix UtilAllTest.java Can't create a empty path [rocketmq]
Einstein opened a new pull request, #7484: URL: https://github.com/apache/rocketmq/pull/7484 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [5318]defaultlitepullconsumer support resetoffset [rocketmq]
github-actions[bot] commented on PR #5321: URL: https://github.com/apache/rocketmq/pull/5321#issuecomment-1771867415 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The pr template is outdated for licence and checkstyle [rocketmq]
github-actions[bot] commented on issue #5353: URL: https://github.com/apache/rocketmq/issues/5353#issuecomment-1771867377 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 提示 close the connection to remote address [rocketmq]
1607004157 opened a new issue, #7485: URL: https://github.com/apache/rocketmq/issues/7485 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos7 ### RocketMQ version 4.4.0 ### JDK Version jdk 1.8 ### Describe the Bug 一直提示close the connection to remote address[x.x.x.x:10909] result: true rocketmq是集群环境 ### Steps to Reproduce NettyClientSelector_1|RocketmqRemoting:95|closeChannel: close the connection to remote address[x.x.x.x:10909] result: true ### What Did You Expect to See? 能给出解决 ### What Did You See Instead? NettyClientSelector_1|RocketmqRemoting:95|closeChannel: close the connection to remote address ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c0b6081fc4844125118fa21a049e6e52c145bbce / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6582085588 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c0b6081fc4844125118fa21a049e6e52c145bbce / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6582085583 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: dbc633d92b6c8c35922234611d698d3cb0a1a234 / Ji Juntao Check the input yaml and the path in ACL (#7475) * check the input yaml and the path. * only modify the path, no yaml. * remove useless import Report URL: https://github.com/apache/rocketmq/actions/runs/6582108616 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c0b6081fc4844125118fa21a049e6e52c145bbce / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6582085580 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: c0b6081fc4844125118fa21a049e6e52c145bbce / 67 <6...@gd67.com> format Report URL: https://github.com/apache/rocketmq/actions/runs/6582085585 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: 8c648727f6d7bb92d0151270122acf19f65d / 67 <6...@gd67.com> log fix Report URL: https://github.com/apache/rocketmq/actions/runs/6582415404 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user iamgd67 (triggered by iamgd67). Head commit for run: cd0ab8dae51eba4f5f1781a0876109d48084fe26 / 67 <6...@gd67.com> add log Report URL: https://github.com/apache/rocketmq/actions/runs/6582489142 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Invalid key/value in long polling is not removed from Map [rocketmq]
joeCarf commented on issue #7481: URL: https://github.com/apache/rocketmq/issues/7481#issuecomment-1771980476 这个未删除的问题会带来哪些影响呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
joeCarf commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1771980902 能贴一下截图吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
1607004157 commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1771983583 > 能贴一下截图吗  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
RongtongJin opened a new pull request, #7486: URL: https://github.com/apache/rocketmq/pull/7486 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
joeCarf commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1771986377 看起来一直在关闭链接。有具体的复现步骤吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 052cd2ed0da1bd47927151a91ef928bc20bb7a62 / RongtongJin Remove getBrokerClusterAclConfig from admin and server Report URL: https://github.com/apache/rocketmq/actions/runs/6582707921 With regards, GitHub Actions via GitBox
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1771990441 Why delete this method? How to obtain ACL configuration through the interface after deletion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
1607004157 commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1771995540 > 看起来一直在关闭链接。有具体的复现步骤吗 1、rocketmq是双主双从，配置的外网ip 2、业务应用启动起来后 一直报这个错（ip是其中部署rocketmq的一台服务器外网ip）3、进行telnet ip和端口都是通的，消息能正常发送和收到，但是一直报这个错 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]
codecov-commenter commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1772002750 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7486](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (052cd2e) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.03%`. > Report is 1 commits behind head on develop. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## develop#7486 +/- ## = + Coverage 42.93% 42.96% +0.03% - Complexity 9660 9665 +5 = Files 1161 1158 -3 Lines 8393083838 -92 Branches 1089810888 -10 = - Hits 3603836024 -14 + Misses 4341043343 -67 + Partials4482 4471 -11 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | `23.78% <ø> (+0.19%)` | :arrow_up: | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `22.90% <ø> (-0.37%)` | :arrow_down: | | [...apache/rocketmq/remoting/protocol/RequestCode.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlcXVlc3RDb2RlLmphdmE=) | `0.00% <ø> (ø)` | | | [...apache/rocketmq/tools/admin/DefaultMQAdminExt.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL0RlZmF1bHRNUUFkbWluRXh0LmphdmE=) | `29.12% <ø> (+0.15%)` | :arrow_up: | | [...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL0RlZmF1bHRNUUFkbWluRXh0SW1wbC5qYXZh) | `24.94% <ø> (+0.02%)` | :arrow_up: | | [.../apache/rocketmq/tools/command/MQAdminStartup.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvTVFBZG1pblN0YXJ0dXAuamF2YQ==) | `0.00% <ø> (ø)` | | | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `78.37% <0.00%> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif
Re: [I] 提示 close the connection to remote address [rocketmq]
joeCarf commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772004995 看了下代码里，打出这个log的地方有很多。但大多会有其他的warn 或者 error日志，辛苦看下是否有其他日志呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 提示 close the connection to remote address [rocketmq]
1607004157 commented on issue #7485: URL: https://github.com/apache/rocketmq/issues/7485#issuecomment-1772006373 > 看了下代码里，打出这个log的地方有很多。但大多会有其他的warn 或者 error日志，辛苦看下是否有其他日志呢 代码中没有这个日志 是rocketmq底层打印出来的 有一台服务器不报这个 都是一样的配置 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7480] Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated [rocketmq]
RongtongJin opened a new pull request, #7488: URL: https://github.com/apache/rocketmq/pull/7488 ### Which Issue(s) This PR Fixes Fixes #7480 ### Brief Description Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8494b3bfad6c8ff28e6851618891fcdf06e75a50 / RongtongJin Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated Report URL: https://github.com/apache/rocketmq/actions/runs/6582987937 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8494b3bfad6c8ff28e6851618891fcdf06e75a50 / RongtongJin Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated Report URL: https://github.com/apache/rocketmq/actions/runs/6582987926 With regards, GitHub Actions via GitBox
[GH] (rocketmq-e2e): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq-e2e.git has failed. Run started by GitHub user Zintoki (triggered by Zintoki). Head commit for run: b035dd07bb7dceb536a4a2015c03076d6fe2073b / Gezi-lzq <68054234+gezi-...@users.noreply.github.com> fix: initAcl (#45) Signed-off-by: Gezi-lzq Report URL: https://github.com/apache/rocketmq-e2e/actions/runs/6583021585 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 8494b3bfad6c8ff28e6851618891fcdf06e75a50 / RongtongJin Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated Report URL: https://github.com/apache/rocketmq/actions/runs/6582987925 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: dbc633d92b6c8c35922234611d698d3cb0a1a234 / Ji Juntao Check the input yaml and the path in ACL (#7475) * check the input yaml and the path. * only modify the path, no yaml. * remove useless import Report URL: https://github.com/apache/rocketmq/actions/runs/6583007609 With regards, GitHub Actions via GitBox
Re: [PR] Added the java4.x client cluster filter pull test content [rocketmq-e2e]
aaron-ai merged PR #51: URL: https://github.com/apache/rocketmq-e2e/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-e2e): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq-e2e.git has failed. Run started by GitHub user aaron-ai (triggered by aaron-ai). Head commit for run: 51a01c18fd9eb2652dbf3ec97a9877d48e00cd89 / XiaoWei Zhang <1403767...@qq.com> Added the java4.x client cluster filter pull test content (#51) * Added the java4.x client cluster filter pull test content * Improved the test content, adding the test content of batchproducer, transactions, loadbacing, offset, retry and other scenarios * Refine old tests and add retry test scenarios * Refine old tests and normalize non-standard code Report URL: https://github.com/apache/rocketmq-e2e/actions/runs/6583136505 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Invalid key/value in long polling is not removed from Map [rocketmq]
yx9o commented on issue #7481: URL: https://github.com/apache/rocketmq/issues/7481#issuecomment-1772055014 There may be problems in the following aspects: 1. org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable is getting larger and larger, which may lead to insufficient memory or even OOM 2. Useless traversal and useless acquisition getMaxOffsetInQueue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
tensory2022 opened a new issue, #7489: URL: https://github.com/apache/rocketmq/issues/7489 ### Search before creation - [X] I had searched in the [issues](https://github.com/apache/rocketmq/issues) and found no similar issues. ### Documentation Related [org/apache/rocketmq/example/simple/PullConsumer.java] https://github.com/apache/rocketmq/blob/develop/example/src/main/java/org/apache/rocketmq/example/simple/PullConsumer.java  consumer.updateConsumeOffset() uses the function of updateOffset() in OffsetStore interface here: [org/apache/rocketmq/client/consumer/store/OffsetStore.java](https://github.com/apache/rocketmq/blob/develop/client/src/main/java/org/apache/rocketmq/client/consumer/store/OffsetStore.java)  In example, the comments show "//update offset to broker" and the interface class code shows "Update the offset,store it in memory". Or one of the two comments might be wrong. Please correct me if I misunderstood them. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: [ISSUE #7231] Fix: proxy client language error (#7200)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 3968c186a5 [ISSUE #7231] Fix: proxy client language error (#7200)
3968c186a5 is described below
commit 3968c186a59db96701ade8c343bc6a5d31ee2d24
Author: weihubeats
AuthorDate: Fri Oct 20 14:49:00 2023 +0800
[ISSUE #7231] Fix: proxy client language error (#7200)
* Adding null does not update
* add langeuga code
* add langeuga code
* add langeuga code
* add langeuga code
* add langeuga code
* Rerun ci
* Rerun ci
* Rerun ci
* remove redundant package imports
* redundant line
* modify the parameter passed as proxyContext to language
* format
---
.../rocketmq/proxy/service/message/LocalMessageService.java | 12 ++--
.../rocketmq/proxy/service/message/LocalRemotingCommand.java | 8 ++--
.../org/apache/rocketmq/remoting/protocol/LanguageCode.java | 11 +++
3 files changed, 23 insertions(+), 8 deletions(-)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalMessageService.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalMessageService.java
index ca7dcc9eb0..aaa688fee6 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalMessageService.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalMessageService.java
@@ -104,7 +104,7 @@ public class LocalMessageService implements MessageService {
body = message.getBody();
messageId = MessageClientIDSetter.getUniqID(message);
}
-RemotingCommand request =
LocalRemotingCommand.createRequestCommand(RequestCode.SEND_MESSAGE,
requestHeader);
+RemotingCommand request =
LocalRemotingCommand.createRequestCommand(RequestCode.SEND_MESSAGE,
requestHeader, ctx.getLanguage());
request.setBody(body);
CompletableFuture future = new CompletableFuture<>();
SimpleChannel channel = channelManager.createInvocationChannel(ctx);
@@ -162,7 +162,7 @@ public class LocalMessageService implements MessageService {
ConsumerSendMsgBackRequestHeader requestHeader, long timeoutMillis) {
SimpleChannel channel = channelManager.createChannel(ctx);
ChannelHandlerContext channelHandlerContext =
channel.getChannelHandlerContext();
-RemotingCommand command =
LocalRemotingCommand.createRequestCommand(RequestCode.CONSUMER_SEND_MSG_BACK,
requestHeader);
+RemotingCommand command =
LocalRemotingCommand.createRequestCommand(RequestCode.CONSUMER_SEND_MSG_BACK,
requestHeader, ctx.getLanguage());
CompletableFuture future = new CompletableFuture<>();
try {
RemotingCommand response =
brokerController.getSendMessageProcessor()
@@ -181,7 +181,7 @@ public class LocalMessageService implements MessageService {
CompletableFuture future = new CompletableFuture<>();
SimpleChannel channel = channelManager.createChannel(ctx);
ChannelHandlerContext channelHandlerContext =
channel.getChannelHandlerContext();
-RemotingCommand command =
LocalRemotingCommand.createRequestCommand(RequestCode.END_TRANSACTION,
requestHeader);
+RemotingCommand command =
LocalRemotingCommand.createRequestCommand(RequestCode.END_TRANSACTION,
requestHeader, ctx.getLanguage());
try {
brokerController.getEndTransactionProcessor()
.processRequest(channelHandlerContext, command);
@@ -196,7 +196,7 @@ public class LocalMessageService implements MessageService {
public CompletableFuture popMessage(ProxyContext ctx,
AddressableMessageQueue messageQueue,
PopMessageRequestHeader requestHeader, long timeoutMillis) {
requestHeader.setBornTime(System.currentTimeMillis());
-RemotingCommand request =
LocalRemotingCommand.createRequestCommand(RequestCode.POP_MESSAGE,
requestHeader);
+RemotingCommand request =
LocalRemotingCommand.createRequestCommand(RequestCode.POP_MESSAGE,
requestHeader, ctx.getLanguage());
CompletableFuture future = new CompletableFuture<>();
SimpleChannel channel = channelManager.createInvocationChannel(ctx);
InvocationContext invocationContext = new InvocationContext(future);
@@ -307,7 +307,7 @@ public class LocalMessageService implements MessageService {
ChangeInvisibleTimeRequestHeader requestHeader, long timeoutMillis) {
SimpleChannel channel = channelManager.createChannel(ctx);
ChannelHandlerContext channelHandlerContext =
channel.getChannelHandlerContext();
-RemotingCommand command =
LocalRemotingCommand.createRequestCommand(RequestCode.CHANGE_MESSAGE_INVISIBLETIME,
requestHeader);
+Re
Re: [PR] [ISSUE #7231] Fix: proxy client language error [rocketmq]
RongtongJin merged PR #7200: URL: https://github.com/apache/rocketmq/pull/7200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6584373552 With regards, GitHub Actions via GitBox
