yx9o opened a new issue, #7481: URL: https://github.com/apache/rocketmq/issues/7481
### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment mac ### RocketMQ version master ### JDK Version jdk17 ### Describe the Bug Invalid Consumer data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` will not be removed <img width="929" alt="image" src="https://github.com/apache/rocketmq/assets/12792261/c2cccd3b-2e34-4c18-a676-5d370fb66983";> <img width="1052" alt="image" src="https://github.com/apache/rocketmq/assets/12792261/eb07e894-4dee-4c14-8528-48305b8365e2";> ### Steps to Reproduce 1. Start Broker 2. Create a Topic and send a message 3. Start Consumer. When the pull message returns `ResponseCode.PULL_NOT_FOUND`, it will be added to `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` 4. But when the `Consumer` is stopped, the data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` still exists ### What Did You Expect to See? After `Consumer` is stopped, the matching data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` is removed ### What Did You See Instead? After `Consumer` is stopped, the matching data in `org.apache.rocketmq.broker.longpolling.PullRequestHoldService#pullRequestTable` is still there ### Additional Context We should remove `key` under the condition that `null == mpr || null == mpr.cloneListAndClear()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
