[GitHub] [incubator-nuttx] acassis commented on issue #1494: NXP imxrt1064 dose not support
acassis commented on issue #1494: URL: https://github.com/apache/incubator-nuttx/issues/1494#issuecomment-667967470 Hi @degree900 thank you for explaining more details about the issue. I don't have a imxrt1064 here to test, but did you try to change all "ORIGIN = 0x6000" to "ORIGIN = 0x7000" for those scripts at nuttx/boards/arm/imxrt/imxrt1060-evk/scripts/ ? Maybe it could work (or could not case there are more differences in these two boards). So, try to do it and let me know if you succeed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] degree900 commented on issue #1494: NXP imxrt1064 dose not support
degree900 commented on issue #1494: URL: https://github.com/apache/incubator-nuttx/issues/1494#issuecomment-667976148 Yes, I tried to modify the link script, and also modified the FLASH_BASE and FLASH_END at nuttx/configs/imxrt1060-evk/src/imxrt_flexspi_nor_boot.h , but it still did not work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d opened a new pull request #1501: New Documentation
v01d opened a new pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501 ## Summary This is a WIP of the new documentation system based on Sphinx and RST. Migration from HTML documents is in progress. The CI system currently setup is based on GitHub pages and updates the following URL when the "docs" branch of my fork is pushed: https://v01d.github.io/incubator-nuttx/docs/index.html The final step before have a mergeable PR is to switch to a CI system which will publish in NuttX website. The following outlines the status of the migration of HTML documents. A checkmark indicates migration complete. - [ ] NuttX.html: mostly converted, supported boards will be moved to special section - [x] NuttXCCodingStandard.html - [ ] NuttxUserGuide.html: initial conversion placed in "User API" - [ ] NuttShell.html: initial conversion placed inside "OS Components". Could also be placed inside "Applications" but we could consider this a special case - [ ] acronyms.txt: I believe Sphinx supports this, it should be converted - [ ] NfsHowto.html - [ ] NuttXBinfmt.html - [ ] NuttXDemandPaging.html - [ ] NuttXNxFlat.html - [ ] NuttXPortingGuide.html: this should be split into "OS Api" and the guide itself - [ ] NXGraphicsSubsystem.html - [ ] NxWidgets.html - [ ] UsbTrace.html The following is a list of TODOs related to this PR: - [ ] Implement support for versioned docs (this is related to CI item below): one for master, one for each tagged release - [ ] Migrate/integrate board and application READMEs - [ ] Look into auto generating the table of supported architectures and SoCs - [ ] Publish docs in main site and not using GitHub pages - [ ] After migration complete, make current "doc" directory the new "Documentation" directory - [ ] squash commits **NOTE** for documents for which migration has started (a file exists under "doc" already) or is complete, any updates to the current HTML documents under Documentation should be held until this PR is complete so as not to fall out of sync. Please not of existing issues that may impact this and would be better to hold once this PR is merged: #883 #1498 **NOTE2**: completing this PR will only mean that HTMLs are converted and a good first base for the new documentation is in place. A second iteration should focus on migrating information found in other sources (wiki, READMEs, etc) and should then continued to be improve coherence in the result. ## Impact All changes are to documentation and CI system. ## Testing Correct migration of HTML documents should be verified by visually comparing these to the new ones. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1501: New Documentation
v01d commented on pull request #1501: URL: https://github.com/apache/incubator-nuttx/pull/1501#issuecomment-668183937 FYI: I will be working on NSH and User API parts next Maybe we can continue colaborating on this using PRs on my fork? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 03/03: fs/procfs: Handle /proc/xxx/group/ correctly
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0e610caec857808124c13f65b142f45ff4d79b0b
Author: Xiang Xiao
AuthorDate: Fri Jul 31 02:51:58 2020 +0800
fs/procfs: Handle /proc/xxx/group/ correctly
Signed-off-by: Xiang Xiao
Change-Id: Ic9f4c38a3baf199712c5497c094dc7af84deee2c
---
fs/procfs/fs_procfsproc.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/procfs/fs_procfsproc.c b/fs/procfs/fs_procfsproc.c
index 26a549b..0584a9e 100644
--- a/fs/procfs/fs_procfsproc.c
+++ b/fs/procfs/fs_procfsproc.c
@@ -406,7 +406,12 @@ static FAR const struct proc_node_s *proc_findnode(FAR
const char *relpath)
for (i = 0; i < PROC_NNODES; i++)
{
- if (strcmp(g_nodeinfo[i]->relpath, relpath) == 0)
+ size_t len = strlen(g_nodeinfo[i]->relpath);
+
+ if (strncmp(g_nodeinfo[i]->relpath, relpath, len) == 0 &&
+ (relpath[len] == '\0' || (relpath[len] == '/' &&
+ relpath[len + 1] == '\0' &&
+ g_nodeinfo[i]->dtype == DTYPE_DIRECTORY)))
{
return g_nodeinfo[i];
}
[incubator-nuttx] branch master updated (2a2dd35 -> 0e610ca)
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2a2dd35 arch/sim: Fix warning: implicit declaration of function
‘pthread_yield’
new 2d7f58d net/procfs: Support chdir("/proc/net/") correctly
new 1bad139 fs/romfs: Support the path with tail '/' correctly
new 0e610ca fs/procfs: Handle /proc/xxx/group/ correctly
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
fs/procfs/fs_procfsproc.c | 7 ++-
fs/romfs/fs_romfsutil.c | 5 +
net/procfs/net_procfs.c | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
[incubator-nuttx] 01/03: net/procfs: Support chdir("/proc/net/") correctly
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2d7f58d1659168d196ea90cc92f30d7e27e7a92d
Author: Xiang Xiao
AuthorDate: Fri Jul 31 02:50:17 2020 +0800
net/procfs: Support chdir("/proc/net/") correctly
Signed-off-by: Xiang Xiao
Change-Id: I47295019c6054c869545e33258ad3460896e851a
---
net/procfs/net_procfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/procfs/net_procfs.c b/net/procfs/net_procfs.c
index b3481fc..64aa3ad 100644
--- a/net/procfs/net_procfs.c
+++ b/net/procfs/net_procfs.c
@@ -660,7 +660,7 @@ static int netprocfs_stat(FAR const char *relpath, FAR
struct stat *buf)
{
/* Check for the directory "net" */
- if (strcmp(relpath, "net") == 0)
+ if (strcmp(relpath, "net") == 0 || strcmp(relpath, "net/") == 0)
{
buf->st_mode = S_IFDIR | S_IROTH | S_IRGRP | S_IRUSR;
}
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1490: Ensure the filesystem handle the tail '/' correctly
Ouss4 merged pull request #1490: URL: https://github.com/apache/incubator-nuttx/pull/1490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 02/03: fs/romfs: Support the path with tail '/' correctly
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 1bad139f88d18b8e26d2b77abe5c8735f866799f
Author: Xiang Xiao
AuthorDate: Fri Jul 31 02:51:05 2020 +0800
fs/romfs: Support the path with tail '/' correctly
Signed-off-by: Xiang Xiao
Change-Id: I7ea668e50e68cb384d013349a2c8cfc2844f3b73
---
fs/romfs/fs_romfsutil.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/fs/romfs/fs_romfsutil.c b/fs/romfs/fs_romfsutil.c
index bb6123d..92b24b7 100644
--- a/fs/romfs/fs_romfsutil.c
+++ b/fs/romfs/fs_romfsutil.c
@@ -751,6 +751,11 @@ int romfs_finddirentry(struct romfs_mountpt_s *rm,
entrylen = terminator - entryname;
}
+ if (entrylen == 0)
+{
+ return OK;
+}
+
/* Long path segment names will be truncated to NAME_MAX */
if (entrylen > NAME_MAX)
[incubator-nuttx] branch master updated (0e610ca -> 16cd363)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0e610ca fs/procfs: Handle /proc/xxx/group/ correctly new ea1ce2b boards: lc82345-xgevk: Replace license header with Apache License 2.0 new 16cd363 arch: lc823450: Replace license header with Apache License 2.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/include/lc823450/chip.h | 40 ++- arch/arm/include/lc823450/clk.h| 40 ++- arch/arm/include/lc823450/irq.h| 40 ++- arch/arm/src/lc823450/Make.defs| 41 ++-- arch/arm/src/lc823450/chip.h | 40 ++- arch/arm/src/lc823450/lc823450_adc.c | 45 +++--- arch/arm/src/lc823450/lc823450_adc.h | 40 ++- arch/arm/src/lc823450/lc823450_allocateheap2.c | 45 +++--- arch/arm/src/lc823450/lc823450_clockconfig.c | 41 ++-- arch/arm/src/lc823450/lc823450_clockconfig.h | 41 ++-- arch/arm/src/lc823450/lc823450_cpuidlestack.c | 40 ++- arch/arm/src/lc823450/lc823450_cpuindex.c | 44 +++-- arch/arm/src/lc823450/lc823450_cpupause.c | 40 ++- arch/arm/src/lc823450/lc823450_cpustart.c | 40 ++- arch/arm/src/lc823450/lc823450_dma.c | 39 ++- arch/arm/src/lc823450/lc823450_dma.h | 39 ++- arch/arm/src/lc823450/lc823450_dvfs2.c | 40 ++- arch/arm/src/lc823450/lc823450_dvfs2.h | 39 ++- arch/arm/src/lc823450/lc823450_gpio.c | 41 ++-- arch/arm/src/lc823450/lc823450_gpio.h | 41 ++-- arch/arm/src/lc823450/lc823450_i2c.c | 41 ++-- arch/arm/src/lc823450/lc823450_i2c.h | 40 ++- arch/arm/src/lc823450/lc823450_i2s.c | 39 ++- arch/arm/src/lc823450/lc823450_i2s.h | 39 ++- arch/arm/src/lc823450/lc823450_idle.c | 40 ++- arch/arm/src/lc823450/lc823450_intc.h | 40 ++- arch/arm/src/lc823450/lc823450_ipl2.c | 41 ++-- arch/arm/src/lc823450/lc823450_irq.c | 45 +++--- arch/arm/src/lc823450/lc823450_lowputc.c | 40 ++- arch/arm/src/lc823450/lc823450_lowputc.h | 39 ++- arch/arm/src/lc823450/lc823450_mmcl.c | 40 ++- arch/arm/src/lc823450/lc823450_mmcl.h | 39 ++- arch/arm/src/lc823450/lc823450_mpuinit2.c | 41 ++-- arch/arm/src/lc823450/lc823450_mpuinit2.h | 45 +++--- arch/arm/src/lc823450/lc823450_mtd.c | 41 ++-- arch/arm/src/lc823450/lc823450_mtd.h | 39 ++- arch/arm/src/lc823450/lc823450_procfs_dvfs.c | 39 ++- arch/arm/src/lc823450/lc823450_pwm.h | 40 ++- arch/arm/src/lc823450/lc823450_rtc.c | 40 ++- arch/arm/src/lc823450/lc823450_sdc.h | 39 ++- arch/arm/src/lc823450/lc823450_serial.c| 40 ++- arch/arm/src/lc823450/lc823450_serial.h| 40 ++- arch/arm/src/lc823450/lc823450_spi.c | 45 +++--- arch/arm/src/lc823450/lc823450_spi.h | 39 ++- arch/arm/src/lc823450/lc823450_spifi2.c| 40 ++- arch/arm/src/lc823450/lc823450_spifi2.h| 40 ++- arch/arm/src/lc823450/lc823450_start.c | 41 ++-- arch/arm/src/lc823450/lc823450_syscontrol.c| 41 ++-- arch/arm/src/lc823450/lc823450_syscontrol.h| 41 ++-- arch/arm/src/lc823450/lc823450_testset.c | 40 ++- arch/arm/src/lc823450/lc823450_timer.c | 41 ++-- arch/arm/src/lc823450/lc823450_timer.h | 39 ++- arch/arm/src/lc823450/lc823450_usbdev.c| 44 +++-- arch/arm/src/lc823450/lc823450_usbdev.h| 39 ++- arch/arm/src/lc823450/lc823450_userspace.c | 41 ++-- arch/arm/src/lc823450/lc823450_userspace.h | 45 +
[incubator-nuttx] 01/02: boards: lc82345-xgevk: Replace license header with Apache License 2.0
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ea1ce2bcb693c11e63dbef31ad7f76e9efc8855e Author: Masayuki Ishikawa AuthorDate: Fri Jul 31 12:47:58 2020 +0900 boards: lc82345-xgevk: Replace license header with Apache License 2.0 Summary: - This commit replaces license header under lc823450-xgevk Impact: - No impact Testing: - Build check only Signed-off-by: Masayuki Ishikawa --- boards/arm/lc823450/lc823450-xgevk/include/board.h | 39 ++-- boards/arm/lc823450/lc823450-xgevk/kernel/Makefile | 41 ++--- .../lc823450-xgevk/kernel/lc823450_userspace.c | 41 ++--- .../arm/lc823450/lc823450-xgevk/scripts/Make.defs | 39 ++-- .../arm/lc823450/lc823450-xgevk/scripts/gnu-elf.ld | 39 ++-- .../lc823450/lc823450-xgevk/scripts/ld-ipl2.script | 39 ++-- .../lc823450-xgevk/scripts/ld-spif-boot.script | 39 ++-- .../arm/lc823450/lc823450-xgevk/scripts/ld.script | 39 ++-- .../arm/lc823450/lc823450-xgevk/scripts/memory.ld | 41 ++--- .../lc823450/lc823450-xgevk/scripts/user-space.ld | 41 ++--- boards/arm/lc823450/lc823450-xgevk/src/Makefile| 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450-xgevk.h | 39 ++-- .../lc823450-xgevk/src/lc823450-xgevk_mux.h| 40 ++-- .../arm/lc823450/lc823450-xgevk/src/lc823450_adc.c | 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_appinit.c | 39 ++-- .../lc823450-xgevk/src/lc823450_autoleds.c | 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_boot.c| 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_bringup.c | 39 ++-- .../arm/lc823450/lc823450-xgevk/src/lc823450_bt.c | 39 ++-- .../arm/lc823450/lc823450-xgevk/src/lc823450_mux.c | 40 ++-- .../lc823450/lc823450-xgevk/src/lc823450_netinit.c | 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_sdif.c| 39 ++-- .../arm/lc823450/lc823450-xgevk/src/lc823450_spi.c | 43 +++--- .../lc823450/lc823450-xgevk/src/lc823450_st7565.c | 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_usbmsc.c | 39 ++-- .../lc823450/lc823450-xgevk/src/lc823450_wm8776.c | 39 ++-- 26 files changed, 314 insertions(+), 714 deletions(-) diff --git a/boards/arm/lc823450/lc823450-xgevk/include/board.h b/boards/arm/lc823450/lc823450-xgevk/include/board.h index 726d842..f2419c8 100644 --- a/boards/arm/lc823450/lc823450-xgevk/include/board.h +++ b/boards/arm/lc823450/lc823450-xgevk/include/board.h @@ -1,35 +1,20 @@ / * boards/arm/lc823450/lc823450-xgevk/include/board.h * - * Copyright 2017 Sony Video & Sound Products Inc. - * Author: Masayuki Ishikawa + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: + * http://www.apache.org/licenses/LICENSE-2.0 * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in - *the documentation and/or other materials provided with the - *distribution. - * 3. Neither the name NuttX nor the names of its contributors may be - *used to endorse or promote products derived from this software - *without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS - * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE - * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS - * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED - * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRA
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1493: Change license for lc823450
Ouss4 merged pull request #1493: URL: https://github.com/apache/incubator-nuttx/pull/1493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #348: testing/cxxtest: increase STACKSIZE to avoid crash
Ouss4 merged pull request #348: URL: https://github.com/apache/incubator-nuttx-apps/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: testing/cxxtest: increase STACKSIZE to avoid crash
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 63a5ddc testing/cxxtest: increase STACKSIZE to avoid crash 63a5ddc is described below commit 63a5ddcc7cb741e5506badd432d1f98d1aa55d8a Author: Peter Bee AuthorDate: Wed Jul 29 08:54:59 2020 + testing/cxxtest: increase STACKSIZE to avoid crash The previous version of cxxtest uses a fixed value(4096) for STACKSIZE, insufficient when no optimization options are set(CONFIG_DEBUG_NOOPT). This patch increased the STACKSIZE to CONFIG_DEFAULT_TASK_STACKSIZE for stability and consistency. Change-Id: I45a4806d2cda1583f60a5cf24b98b8df58f377d0 Signed-off-by: Peter Bee --- testing/cxxtest/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/cxxtest/Makefile b/testing/cxxtest/Makefile index ea2af76..d2bb10a 100644 --- a/testing/cxxtest/Makefile +++ b/testing/cxxtest/Makefile @@ -43,7 +43,7 @@ MAINSRC = cxxtest_main.cxx PROGNAME = cxxtest PRIORITY = SCHED_PRIORITY_DEFAULT -STACKSIZE = 4096 +STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE) MODULE = $(CONFIG_TESTING_CXXTEST) include $(APPDIR)/Application.mk
[GitHub] [incubator-nuttx] yamt opened a new pull request #1502: Random fixes for issues reported by clang-check
yamt opened a new pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502 ## Summary Random fixes for issues reported by clang-check ## Impact None of these seems critical ## Testing Compile tested only This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on issue #128: IP Clearance
adamfeuer commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-668331164 Thanks @xiaoxiang781216 – I should have enough time to do a high-level analysis this week or next, and I could definitely use the help! @PeterBee97 are you able to help me do this? If so, reply here or send me an email (it's on my profile), and we'll work out what to do. 🙂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464756947
##
File path: arch/sim/src/sim/up_exit.c
##
@@ -65,9 +65,9 @@
void up_exit(int status)
{
- FAR struct tcb_s *tcb = this_task();
+ FAR struct tcb_s *tcb;
Review comment:
what does this change accomplish? I can only see that it introduces a
second call to `this_task()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464757137 ## File path: net/tcp/tcp_timer.c ## @@ -182,7 +182,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, /* Notify upper layers about the timeout */ - result = tcp_callback(dev, conn, TCP_TIMEDOUT); + tcp_callback(dev, conn, TCP_TIMEDOUT); Review comment: is this correct? what did clang-check say? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464757443 ## File path: net/tcp/tcp_timer.c ## @@ -182,7 +182,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, /* Notify upper layers about the timeout */ - result = tcp_callback(dev, conn, TCP_TIMEDOUT); + tcp_callback(dev, conn, TCP_TIMEDOUT); Review comment: ah, I see the commit message. the fact that result is never read probably indicates that it should be read. not assigning the result is not the correct solution if so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1502: Random fixes for issues reported by clang-check
yamt commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464757818
##
File path: arch/sim/src/sim/up_exit.c
##
@@ -65,9 +65,9 @@
void up_exit(int status)
{
- FAR struct tcb_s *tcb = this_task();
+ FAR struct tcb_s *tcb;
Review comment:
the commit messages have the snippets of the clang output.
this change is intended to appease the warning when sinfo() expands to empty.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464757967
##
File path: drivers/usbhost/hid_parser.c
##
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
-usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
Review comment:
I understand the code does the same thing as before, only differently. I
don't understand by clang-check considers the other version problematic and
this one does not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1502: Random fixes for issues reported by clang-check
yamt commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464758552
##
File path: drivers/usbhost/hid_parser.c
##
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
-usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
Review comment:
the original code reads usage[nusage+1]. the new one doesn't.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1502: Random fixes for issues reported by clang-check
yamt commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464758552
##
File path: drivers/usbhost/hid_parser.c
##
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
-usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
Review comment:
the original code reads usage[nusage]. the new one doesn't.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1502: Random fixes for issues reported by clang-check
yamt commented on a change in pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464758272 ## File path: net/tcp/tcp_timer.c ## @@ -182,7 +182,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, /* Notify upper layers about the timeout */ - result = tcp_callback(dev, conn, TCP_TIMEDOUT); + tcp_callback(dev, conn, TCP_TIMEDOUT); Review comment: see the commit message for the clang output. i read the code and i agreed with clang about this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464758538
##
File path: arch/sim/src/sim/up_exit.c
##
@@ -65,9 +65,9 @@
void up_exit(int status)
{
- FAR struct tcb_s *tcb = this_task();
+ FAR struct tcb_s *tcb;
Review comment:
Ok, I understand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464759559 ## File path: net/tcp/tcp_timer.c ## @@ -182,7 +182,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn, /* Notify upper layers about the timeout */ - result = tcp_callback(dev, conn, TCP_TIMEDOUT); + tcp_callback(dev, conn, TCP_TIMEDOUT); Review comment: ok, tcp_timer does not return errors so I guess it is OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1502: Random fixes for issues reported by clang-check
v01d commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464759907
##
File path: drivers/usbhost/hid_parser.c
##
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
-usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
Review comment:
got it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #1487: libc: Avoid ctype function to evaluate the argument more than once
xiaoxiang781216 closed pull request #1487: URL: https://github.com/apache/incubator-nuttx/pull/1487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1487: libc: Avoid ctype function to evaluate the argument more than once
xiaoxiang781216 commented on pull request #1487: URL: https://github.com/apache/incubator-nuttx/pull/1487#issuecomment-668345144 Close, https://github.com/apache/incubator-nuttx/pull/1496 is better for the embeded system. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1502: Random fixes for issues reported by clang-check
xiaoxiang781216 merged pull request #1502: URL: https://github.com/apache/incubator-nuttx/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 02/04: drivers/usbhost/hid_parser.c: Fix out of range array accesses
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 59ba52aee8fd21442fa59ff4a04a30e6ff8d0c80
Author: YAMAMOTO Takashi
AuthorDate: Tue Aug 4 10:17:41 2020 +0900
drivers/usbhost/hid_parser.c: Fix out of range array accesses
Found by clang-check:
usbhost/hid_parser.c:278:26: warning: Assigned value is garbage or undefined
usage[i] = usage[i + 1];
^
usbhost/hid_parser.c:321:34: warning: Assigned value is garbage or undefined
usage[i] = usage[i + 1];
^
2 warnings generated.
---
drivers/usbhost/hid_parser.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usbhost/hid_parser.c b/drivers/usbhost/hid_parser.c
index e87df56..00ee05e 100644
--- a/drivers/usbhost/hid_parser.c
+++ b/drivers/usbhost/hid_parser.c
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
-usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
+usage[i - 1] = usage[i];
nusage--;
}
@@ -316,9 +316,9 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
newitem.attrib.usage.usage = usage[0];
-for (i = 0; i < nusage; i++)
+for (i = 1; i < nusage; i++)
{
-usage[i] = usage[i + 1];
+usage[i - 1] = usage[i];
}
nusage--;
}
[incubator-nuttx] branch master updated (16cd363 -> 0b90ad3)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 16cd363 arch: lc823450: Replace license header with Apache License 2.0 new 4f7745a net/tcp/tcp_timer.c: Remove redundant assignments new 59ba52a drivers/usbhost/hid_parser.c: Fix out of range array accesses new 123a31e drivers/usbhost/hid_parser.c: nxstyle fixes new 0b90ad3 arch/sim/src/sim/up_exit.c: Appease a clang-check warning The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/sim/src/sim/up_exit.c | 4 +-- drivers/usbhost/hid_parser.c | 59 +++- net/tcp/tcp_timer.c | 6 ++--- 3 files changed, 41 insertions(+), 28 deletions(-)
[incubator-nuttx] 03/04: drivers/usbhost/hid_parser.c: nxstyle fixes
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 123a31e3a2d8849d7da6a6c1ef1fcd5fd54de551
Author: YAMAMOTO Takashi
AuthorDate: Tue Aug 4 10:24:09 2020 +0900
drivers/usbhost/hid_parser.c: nxstyle fixes
---
drivers/usbhost/hid_parser.c | 51 +++-
1 file changed, 32 insertions(+), 19 deletions(-)
diff --git a/drivers/usbhost/hid_parser.c b/drivers/usbhost/hid_parser.c
index 00ee05e..fa41603 100644
--- a/drivers/usbhost/hid_parser.c
+++ b/drivers/usbhost/hid_parser.c
@@ -71,14 +71,16 @@ struct hid_state_s
*report Buffer containing the device's HID report table.
*rptlen Size in bytes of the HID report table.
*filter Callback function to decide if an item should be retained
- *rptinfo Pointer to a struct hid_rptinfo_s instance for the parser
output.
+ *rptinfo Pointer to a struct hid_rptinfo_s instance for the parser
+ * output.
*
* Returned Value:
* Zero on success, otherwise a negated errno value.
/
int hid_parsereport(FAR const uint8_t *report, int rptlen,
-hid_rptfilter_t filter, FAR struct hid_rptinfo_s *rptinfo)
+hid_rptfilter_t filter,
+FAR struct hid_rptinfo_s *rptinfo)
{
struct hid_state_s state[CONFIG_HID_STATEDEPTH];
struct hid_state_s *currstate = &state[0];
@@ -86,7 +88,12 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
struct hid_rptsizeinfo_s*rptidinfo = &rptinfo->rptsize[0];
uint16_t usage[CONFIG_HID_USAGEDEPTH];
uint8_t nusage = 0;
- struct hid_range_s usage_range = { 0, 0 };
+ struct hid_range_s usage_range =
+{
+ 0,
+ 0
+};
+
int i;
DEBUGASSERT(report && filter && rptinfo);
@@ -250,13 +257,15 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
}
else
{
- struct hid_collectionpath_s *ParentCollectionPath =
collectionpath;
+ struct hid_collectionpath_s *parent_collection_path =
+ collectionpath;
collectionpath = &rptinfo->collectionpaths[1];
while (collectionpath->parent != NULL)
{
- if (collectionpath ==
&rptinfo->collectionpaths[CONFIG_HID_MAXCOLLECTIONS - 1])
+ if (collectionpath == &rptinfo->collectionpaths[
+CONFIG_HID_MAXCOLLECTIONS - 1])
{
return -EINVAL;
}
@@ -264,7 +273,7 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
collectionpath++;
}
- collectionpath->parent = ParentCollectionPath;
+ collectionpath->parent = parent_collection_path;
}
collectionpath->type = data;
@@ -320,6 +329,7 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
usage[i - 1] = usage[i];
}
+
nusage--;
}
else if (usage_range.min <= usage_range.max)
@@ -341,7 +351,7 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
newitem.type = HID_REPORT_ITEM_FEATURE;
}
-newitem.bitoffset = rptidinfo->size[newitem.type];
+newitem.bitoffset = rptidinfo->size[newitem.type];
rptidinfo->size[newitem.type] += currstate->attrib.bitsize;
/* Accumulate the maximum report size */
@@ -389,8 +399,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
*
* Description:
* Extracts the given report item's value out of the given HID report and
- * places it into the value member of the report item's struct hid_rptitem_s
- * structure.
+ * places it into the value member of the report item's struct
+ * hid_rptitem_s structure.
*
* When called on a report with an item that exists in that report, this
* copies the report item's Value to it's previous element for easy
@@ -401,8 +411,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
* Input Parameters:
* report Buffer containing an IN or FEATURE report from an attached
* device.
- * itemPointer to the report item of interest in a struct
hid_rptinfo_s
- * item array.
+ * itemPointer to the report item of interest in a struct
+ * hid_rptinfo_s item array.
*
* Returned Value:
* Zero on success, otherwise a negated errno value.
@@ -447,10 +457,11 @@ int hid_getitem(FAR const uint8_t *
[incubator-nuttx] 01/04: net/tcp/tcp_timer.c: Remove redundant assignments
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4f7745ae1c47958ab4273eb9d273c5c8f3067281
Author: YAMAMOTO Takashi
AuthorDate: Tue Aug 4 10:09:33 2020 +0900
net/tcp/tcp_timer.c: Remove redundant assignments
Found by clang-check:
tcp/tcp_timer.c:185:15: warning: Value stored to 'result' is never read
result = tcp_callback(dev, conn, TCP_TIMEDOUT);
^~
tcp/tcp_timer.c:264:23: warning: Value stored to 'result' is never read
result = tcp_callback(dev, listener, TCP_TIMEDOUT);
^~
tcp/tcp_timer.c:300:19: warning: Value stored to 'result' is never read
result = tcp_callback(dev, conn, TCP_TIMEDOUT);
^~
3 warnings generated.
---
net/tcp/tcp_timer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/tcp/tcp_timer.c b/net/tcp/tcp_timer.c
index d78d6ea..56e988d 100644
--- a/net/tcp/tcp_timer.c
+++ b/net/tcp/tcp_timer.c
@@ -182,7 +182,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct
tcp_conn_s *conn,
/* Notify upper layers about the timeout */
- result = tcp_callback(dev, conn, TCP_TIMEDOUT);
+ tcp_callback(dev, conn, TCP_TIMEDOUT);
ninfo("TCP state: TCP_CLOSED\n");
}
@@ -261,7 +261,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct
tcp_conn_s *conn,
* connection has timed out.
*/
- result = tcp_callback(dev, listener, TCP_TIMEDOUT);
+ tcp_callback(dev, listener, TCP_TIMEDOUT);
}
/* We also send a reset packet to the remote host. */
@@ -297,7 +297,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct
tcp_conn_s *conn,
* timed out.
*/
- result = tcp_callback(dev, conn, TCP_TIMEDOUT);
+ tcp_callback(dev, conn, TCP_TIMEDOUT);
/* We also send a reset packet to the remote host. */
[incubator-nuttx] 04/04: arch/sim/src/sim/up_exit.c: Appease a clang-check warning
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0b90ad3dd4e549cfca3416b223974a08fb03fa1c
Author: YAMAMOTO Takashi
AuthorDate: Tue Aug 4 10:37:35 2020 +0900
arch/sim/src/sim/up_exit.c: Appease a clang-check warning
clang-check complained like the following.
While this is not a real bug, it's easy to appease.
sim/up_exit.c:68:21: warning: Value stored to 'tcb' during its
initialization is never read
FAR struct tcb_s *tcb = this_task();
^~~ ~~~
1 warning generated.
---
arch/sim/src/sim/up_exit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sim/src/sim/up_exit.c b/arch/sim/src/sim/up_exit.c
index fada99a..4241e60 100644
--- a/arch/sim/src/sim/up_exit.c
+++ b/arch/sim/src/sim/up_exit.c
@@ -65,9 +65,9 @@
void up_exit(int status)
{
- FAR struct tcb_s *tcb = this_task();
+ FAR struct tcb_s *tcb;
- sinfo("TCB=%p exiting\n", tcb);
+ sinfo("TCB=%p exiting\n", this_task());
/* Destroy the task at the head of the ready to run list. */
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #1503: Change shes related headers
masayuki2009 opened a new pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503 ## Summary - This commit replaces SHES related headers with Apache License 2.0 ## Impact - No impact ## Testing - Build check only This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #1377: Add task trace support
YuuichiNakamura commented on pull request #1377: URL: https://github.com/apache/incubator-nuttx/pull/1377#issuecomment-668406404 @xiaoxiang781216 How about my changes? I think I have answered all your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] justinmclean commented on pull request #1503: Change shes related headers
justinmclean commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-668407426 HI, Why are these headers being replaced without a software grant? Thanks, Justin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1503: Change shes related headers
masayuki2009 commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-668409920 > HI, Why are these headers being replaced without a software grant? Thanks, Justin Hi, @justinmclean, I am currently an SHES employee and I already submitted ICLA and I contributed the code. so I thought it's OK to replace the headers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] justinmclean commented on pull request #1503: Change shes related headers
justinmclean commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-668414083 Hi, > I am currently an SHES employee and I already submitted ICLA and I contributed the code. > so I thought it's OK to replace the headers. > It is never OK to replace 3rd party headers without permission of the copyright owner. Sony is most likely the copyright owner here. Do we have documented permission on this mailing list to change the license or headers of those files? About the only case I could think of were it would be OK is if the wrong headers were accidentally put on the files in the first place, but I don’t think that’s the case here. Thanks, justin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
