v01d commented on a change in pull request #1502:
URL: https://github.com/apache/incubator-nuttx/pull/1502#discussion_r464757967
##########
File path: drivers/usbhost/hid_parser.c
##########
@@ -274,8 +274,8 @@ int hid_parsereport(FAR const uint8_t *report, int rptlen,
{
collectionpath->usage.usage = usage[0];
- for (i = 0; i < nusage; i++)
- usage[i] = usage[i + 1];
+ for (i = 1; i < nusage; i++)
Review comment:
I understand the code does the same thing as before, only differently. I
don't understand by clang-check considers the other version problematic and
this one does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
