Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106146248 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](spill) improve spill log printing [doris]
HappenLee merged PR #34729: URL: https://github.com/apache/doris/pull/34729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (c6b469aad65 -> 8a532e8ab14)
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c6b469aad65 [fix](config) for compatibility issue of log dir config (#34734) add 8a532e8ab14 [improvement](spill) improve spill log printing (#34729) No new revisions were added by this update. Summary of changes: be/src/pipeline/pipeline_task.cpp| 15 --- be/src/runtime/workload_group/workload_group_manager.cpp | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
amorynan commented on PR #34683: URL: https://github.com/apache/doris/pull/34683#issuecomment-2106152267 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
doris-robot commented on PR #34683: URL: https://github.com/apache/doris/pull/34683#issuecomment-2106156696 TPC-H: Total hot run time: 41945 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit de4dade5a24c6a593f48b7e2640ba3720cc114bb, data reload: false -- Round 1 -- q1 17650 428742354235 q2 2022185 185 185 q3 10516 128212511251 q4 10206 849 827 827 q5 7484277127152715 q6 222 132 138 132 q7 1062617 585 585 q8 9237218521032103 q9 9807673967676739 q10 9457412338513851 q11 435 240 250 240 q12 440 227 242 227 q13 17229 322132553221 q14 288 223 211 211 q15 523 476 482 476 q16 499 393 388 388 q17 980 628 688 628 q18 8419780677657765 q19 5892157915061506 q20 642 331 320 320 q21 5295406241484062 q22 351 284 278 278 Total cold run time: 118656 ms Total hot run time: 41945 ms - Round 2, with runtime_filter_mode=off - q1 4535436948574369 q2 378 261 283 261 q3 3143292528732873 q4 1962167316551655 q5 5483551355085508 q6 217 129 122 122 q7 2366199319541954 q8 3224338934153389 q9 8672872087248720 q10 3963374838253748 q11 611 487 497 487 q12 803 623 655 623 q13 16997 319631553155 q14 303 262 277 262 q15 524 492 469 469 q16 506 443 441 441 q17 1792151614771477 q18 7632747073847384 q19 1664155515641555 q20 1937178317501750 q21 8314481049194810 q22 563 491 478 478 Total cold run time: 75589 ms Total hot run time: 55490 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
doris-robot commented on PR #34683: URL: https://github.com/apache/doris/pull/34683#issuecomment-2106159823 TPC-DS: Total hot run time: 186452 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit de4dade5a24c6a593f48b7e2640ba3720cc114bb, data reload: false query1 904 377 343 343 query2 6462250824242424 query3 6644204 208 204 query4 24066 21325 21212 21212 query5 4109427 428 427 query6 266 181 195 181 query7 4597290 291 290 query8 245 202 197 197 query9 8765243224382432 query10 427 255 263 255 query11 15002 14237 14203 14203 query12 133 90 90 90 query13 1646385 379 379 query14 9679803667936793 query15 265 176 171 171 query16 8052259 255 255 query17 1801544 542 542 query18 2093278 271 271 query19 209 142 154 142 query20 92 86 83 83 query21 193 127 131 127 query22 5085481848144814 query23 34112 33691 33515 33515 query24 9789281328692813 query25 562 361 369 361 query26 695 165 157 157 query27 2149326 329 326 query28 5757208020632063 query29 864 598 590 590 query30 224 150 151 150 query31 983 759 743 743 query32 89 53 56 53 query33 640 261 250 250 query34 910 476 482 476 query35 786 703 674 674 query36 1133893 908 893 query37 102 68 73 68 query38 2894276227542754 query39 1633156115471547 query40 197 131 125 125 query41 41 39 39 39 query42 103 96 99 96 query43 570 547 579 547 query44 1116724 746 724 query45 271 259 254 254 query46 1088720 706 706 query47 1939189418771877 query48 373 306 302 302 query49 858 398 406 398 query50 829 399 402 399 query51 6686671566566656 query52 100 91 95 91 query53 352 280 282 280 query54 841 436 431 431 query55 75 71 73 71 query56 249 223 227 223 query57 1226112411481124 query58 233 222 204 204 query59 3336342632653265 query60 255 235 272 235 query61 89 90 84 84 query62 642 492 463 463 query63 305 281 276 276 query64 8417740573397339 query65 3176309131003091 query66 801 339 336 336 query67 15483 14970 15218 14970 query68 4691545 540 540 query69 530 304 309 304 query70 1215117311661166 query71 399 274 278 274 query72 7988256523652365 query73 720 326 329 326 query74 6541612961336129 query75 3552262125802580 query76 3115997 988 988 query77 606 264 268 264 query78 10509 10184 query79 1758514 516 514 query80 830 435 433 433 query81 521 218 219 218 query82 734 93 96 93 query83 236 163 167 163 query84 249 87 83 83 query85 1416271 309 271 query86 456 302 325 302 query87 3324312030683068 query88 4125245224662452 query89 473 380 383 380 query90 1965192 187 187 query91 126 96 100 96 query92 62 53 51 51 query93 2013503 495 495 query94 1221179 190 179 query95 395 304 304 304 query96 582 282 271 271 query97 3128297429922974 query98 248 221 213 213 query99 1219898 896 896 Total cold run time: 278655 ms Total hot run time: 186452 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s
Re: [PR] [refactor](jdbc catalog) split sap_hana jdbc executor [doris]
zy-kkk commented on PR #34733: URL: https://github.com/apache/doris/pull/34733#issuecomment-2106161259 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
doris-robot commented on PR #34683: URL: https://github.com/apache/doris/pull/34683#issuecomment-2106179843 TeamCity be ut coverage result: Function Coverage: 35.65% (8983/25201) Line Coverage: 27.31% (74258/271867) Region Coverage: 26.55% (38381/144577) Branch Coverage: 23.36% (19569/83768) Coverage Report: http://coverage.selectdb-in.cc/coverage/de4dade5a24c6a593f48b7e2640ba3720cc114bb_de4dade5a24c6a593f48b7e2640ba3720cc114bb/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106181366 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) check pushDownContext validation after withNewProbeExpression() [doris]
englefly merged PR #34704: URL: https://github.com/apache/doris/pull/34704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: check pushDownContext validation after withNewProbeExpression() (#34704)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 7f06cf0a012 check pushDownContext validation after withNewProbeExpression() (#34704) 7f06cf0a012 is described below commit 7f06cf0a0125d84c41e1edbb71366e293f70239d Author: minghong AuthorDate: Sun May 12 18:05:15 2024 +0800 check pushDownContext validation after withNewProbeExpression() (#34704) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped. --- .../processor/post/RuntimeFilterPushDownVisitor.java | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java index f268d1ab8b5..7cadbde1768 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java @@ -103,9 +103,14 @@ public class RuntimeFilterPushDownVisitor extends PlanVisitorselect 0, 0 * push down context for "select 0, 0" is invalid */ -pushedDown |= setOperation.child(i).accept(this, ctx.withNewProbeExpression(newProbeExpr)); +pushedDown |= setOperation.child(i).accept(this, childPushDownContext); } } return pushedDown; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids)check pushDownContext validation after withNewProbeExpression() (#34704) [doris]
englefly opened a new pull request, #34737: URL: https://github.com/apache/doris/pull/34737 when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped. (cherry picked from commit 7f06cf0a0125d84c41e1edbb71366e293f70239d) ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)check pushDownContext validation after withNewProbeExpression() (#34704) [doris]
doris-robot commented on PR #34737: URL: https://github.com/apache/doris/pull/34737#issuecomment-2106193363 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)check pushDownContext validation after withNewProbeExpression() (#34704) [doris]
englefly commented on PR #34737: URL: https://github.com/apache/doris/pull/34737#issuecomment-2106193770 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)check pushDownContext validation after withNewProbeExpression() (#34704) [doris]
englefly merged PR #34737: URL: https://github.com/apache/doris/pull/34737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: check pushDownContext validation after withNewProbeExpression() (#34704) (#34737)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 755757e57c3 check pushDownContext validation after withNewProbeExpression() (#34704) (#34737) 755757e57c3 is described below commit 755757e57c3dc2029a0cd5a09f1b89ca73d493aa Author: minghong AuthorDate: Sun May 12 18:09:13 2024 +0800 check pushDownContext validation after withNewProbeExpression() (#34704) (#34737) when the runtime filter target to a constant, the PushDownContext.finalTarget is null. in this case, do not pushdown runtime filter. example: select * from (select 1 as x from T1) T2 join T3 on T2.x=T3.x when push down RF(T3.x->T2.x) inside "select 1 as x from T1", the column x is a constant, and the pushDown stopped. (cherry picked from commit 7f06cf0a0125d84c41e1edbb71366e293f70239d) --- .../processor/post/RuntimeFilterPushDownVisitor.java | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java index f268d1ab8b5..7cadbde1768 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java @@ -103,9 +103,14 @@ public class RuntimeFilterPushDownVisitor extends PlanVisitorselect 0, 0 * push down context for "select 0, 0" is invalid */ -pushedDown |= setOperation.child(i).accept(this, ctx.withNewProbeExpression(newProbeExpr)); +pushedDown |= setOperation.child(i).accept(this, childPushDownContext); } } return pushedDown; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [doc](stream load) Correct Some Mistakes [doris-website]
wanghuan2054 opened a new pull request, #640: URL: https://github.com/apache/doris-website/pull/640 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](stream load) Correct Some Mistakes [doris-website]
wanghuan2054 closed pull request #640: [doc](stream load) Correct Some Mistakes URL: https://github.com/apache/doris-website/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [doc](stream load) Correct Some Mistakes [doris-website]
wanghuan2054 opened a new pull request, #641: URL: https://github.com/apache/doris-website/pull/641 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [improvement](spill) improve spill log printing
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new cdc950f2c3f [improvement](spill) improve spill log printing
cdc950f2c3f is described below
commit cdc950f2c3fd2f9b6f1fcd891419034a159cc9af
Author: yiguolei
AuthorDate: Sun May 12 19:33:27 2024 +0800
[improvement](spill) improve spill log printing
---
be/src/pipeline/pipeline_x/pipeline_x_task.cpp | 13 ++---
be/src/runtime/workload_group/workload_group_manager.cpp | 4 ++--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/be/src/pipeline/pipeline_x/pipeline_x_task.cpp
b/be/src/pipeline/pipeline_x/pipeline_x_task.cpp
index 760fbd385e6..af1e3912eb4 100644
--- a/be/src/pipeline/pipeline_x/pipeline_x_task.cpp
+++ b/be/src/pipeline/pipeline_x/pipeline_x_task.cpp
@@ -319,7 +319,7 @@ bool PipelineXTask::should_revoke_memory(RuntimeState*
state, int64_t revocable_
wg->check_mem_used(&is_wg_mem_low_water_mark, &is_wg_mem_high_water_mark);
if (is_wg_mem_high_water_mark) {
if (revocable_mem_bytes > min_revocable_mem_bytes) {
-LOG_EVERY_N(INFO, 10) << "revoke memory, hight water mark";
+VLOG_DEBUG << "revoke memory, hight water mark";
return true;
}
return false;
@@ -339,12 +339,11 @@ bool PipelineXTask::should_revoke_memory(RuntimeState*
state, int64_t revocable_
mem_limit_of_op = query_weighted_limit / big_memory_operator_num;
}
-LOG_EVERY_N(INFO, 10) << "revoke memory, low water mark,
revocable_mem_bytes: "
- <<
PrettyPrinter::print_bytes(revocable_mem_bytes)
- << ", mem_limit_of_op: "
- << PrettyPrinter::print_bytes(mem_limit_of_op)
- << ", min_revocable_mem_bytes: "
- <<
PrettyPrinter::print_bytes(min_revocable_mem_bytes);
+VLOG_DEBUG << "revoke memory, low water mark, revocable_mem_bytes: "
+ << PrettyPrinter::print_bytes(revocable_mem_bytes)
+ << ", mem_limit_of_op: " <<
PrettyPrinter::print_bytes(mem_limit_of_op)
+ << ", min_revocable_mem_bytes: "
+ << PrettyPrinter::print_bytes(min_revocable_mem_bytes);
return (revocable_mem_bytes > mem_limit_of_op ||
revocable_mem_bytes > min_revocable_mem_bytes);
} else {
diff --git a/be/src/runtime/workload_group/workload_group_manager.cpp
b/be/src/runtime/workload_group/workload_group_manager.cpp
index a0e0de75f36..153e9bab8ce 100644
--- a/be/src/runtime/workload_group/workload_group_manager.cpp
+++ b/be/src/runtime/workload_group/workload_group_manager.cpp
@@ -201,7 +201,7 @@ void WorkloadGroupMgr::refresh_wg_memory_info() {
PrettyPrinter::print(process_mem_used, TUnit::BYTES),
PrettyPrinter::print(sys_mem_available, TUnit::BYTES),
PrettyPrinter::print(all_queries_mem_used, TUnit::BYTES));
-VLOG_EVERY_N(1, 10) << debug_msg;
+LOG_EVERY_T(INFO, 10) << debug_msg;
}
for (auto& wg : _workload_groups) {
@@ -264,7 +264,7 @@ void WorkloadGroupMgr::refresh_wg_memory_info() {
}
}
if (wg_mem_info.is_high_wartermark || wg_mem_info.is_low_wartermark) {
-VLOG_EVERY_N(1, 10) << debug_msg;
+LOG_EVERY_T(INFO, 10) << debug_msg;
}
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids): add projection for join reorder [doris]
jackwener commented on PR #34400: URL: https://github.com/apache/doris/pull/34400#issuecomment-2106222039 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](nereids)new way to set pre-agg status [doris]
starocean999 opened a new pull request, #34738: URL: https://github.com/apache/doris/pull/34738 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids)new way to set pre-agg status [doris]
doris-robot commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2106227812 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids)new way to set pre-agg status [doris]
starocean999 commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2106227833 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
DarvenDuan opened a new pull request, #34739: URL: https://github.com/apache/doris/pull/34739 ## Proposed changes Issue Number: close #xxx The original data type of column `CREATION_TIME` and `NEWEST_WRITE_TIMESTAMP` in table `information_schema.rowsets` is bigint, which is not read friendly，change to DATETIME is more reasonable. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106245307 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106247175 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106249463 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106249797 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: 2.1.3-rc07
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 4150971e07f 2.1.3-rc07
4150971e07f is described below
commit 4150971e07f3e9a9d9a1f1b847efad6a3ff1e4e1
Author: yiguolei
AuthorDate: Sun May 12 22:22:09 2024 +0800
2.1.3-rc07
---
gensrc/script/gen_build_version.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gensrc/script/gen_build_version.sh
b/gensrc/script/gen_build_version.sh
index 8b5aeb60664..c7343e8b6ad 100755
--- a/gensrc/script/gen_build_version.sh
+++ b/gensrc/script/gen_build_version.sh
@@ -31,7 +31,7 @@ build_version_prefix="doris"
build_version_major=2
build_version_minor=1
build_version_patch=3
-build_version_rc_version="rc06"
+build_version_rc_version="rc07"
build_version="${build_version_prefix}-${build_version_major}.${build_version_minor}.${build_version_patch}-${build_version_rc_version}"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) annotated tag 2.1.3-rc07 updated (4150971e07f -> 565bc2168c6)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to annotated tag 2.1.3-rc07 in repository https://gitbox.apache.org/repos/asf/doris.git *** WARNING: tag 2.1.3-rc07 was modified! *** from 4150971e07f (commit) to 565bc2168c6 (tag) tagging 4150971e07f3e9a9d9a1f1b847efad6a3ff1e4e1 (commit) replaces 2.1.3-rc06 by yiguolei on Sun May 12 22:22:32 2024 +0800 - Log - 2.1.3-rc07 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](split) get file splits in batch mode [doris]
morningman commented on code in PR #34032:
URL: https://github.com/apache/doris/pull/34032#discussion_r1597645580
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##
@@ -370,9 +375,51 @@ public List getSplits() throws UserException {
} catch (InterruptedException e) {
throw new RuntimeException(e.getMessage(), e);
}
+}
+
+@Override
+public List getSplits() throws UserException {
Review Comment:
I think `getSplit()` method should also be in `SplitGenerator` interface?
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##
@@ -370,9 +375,51 @@ public List getSplits() throws UserException {
} catch (InterruptedException e) {
throw new RuntimeException(e.getMessage(), e);
}
+}
+
+@Override
+public List getSplits() throws UserException {
+if (incrementalRead && !incrementalRelation.fallbackFullTableScan()) {
+return getIncrementalSplits();
+}
+List splits = Collections.synchronizedList(new ArrayList<>());
+getPartitionSplits(prunedPartitions, splits);
+return splits;
+}
+
+public List getNextBatch(int maxBatchSize) throws UserException {
+List splits = Collections.synchronizedList(new ArrayList<>());
+int numPartitions = 0;
+while (splits.size() < maxBatchSize && prunedPartitionsIter.hasNext())
{
+List partitions = new
ArrayList<>(NUM_PARTITIONS_PER_LOOP);
+for (int i = 0; i < NUM_PARTITIONS_PER_LOOP &&
prunedPartitionsIter.hasNext(); ++i) {
+partitions.add(prunedPartitionsIter.next());
+numPartitions++;
+}
+getPartitionSplits(partitions, splits);
+}
+if (splits.size() / numPartitions > numSplitsPerPartition) {
+numSplitsPerPartition = splits.size() / numPartitions;
+}
return splits;
}
+public boolean hasNext() {
+return prunedPartitionsIter.hasNext();
+}
+
+public boolean isBatchMode() {
+if (incrementalRead && !incrementalRelation.fallbackFullTableScan()) {
+return false;
+}
+int numPartitions =
ConnectContext.get().getSessionVariable().getNumPartitionsInBatchMode();
+return numPartitions >= 0 && prunedPartitions.size() >= numPartitions;
+}
+
+public int numApproximateSplits() {
Review Comment:
@Override
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##
@@ -370,9 +375,51 @@ public List getSplits() throws UserException {
} catch (InterruptedException e) {
throw new RuntimeException(e.getMessage(), e);
}
+}
+
+@Override
+public List getSplits() throws UserException {
+if (incrementalRead && !incrementalRelation.fallbackFullTableScan()) {
+return getIncrementalSplits();
+}
+List splits = Collections.synchronizedList(new ArrayList<>());
+getPartitionSplits(prunedPartitions, splits);
+return splits;
+}
+
+public List getNextBatch(int maxBatchSize) throws UserException {
Review Comment:
@Override
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##
@@ -370,9 +375,51 @@ public List getSplits() throws UserException {
} catch (InterruptedException e) {
throw new RuntimeException(e.getMessage(), e);
}
+}
+
+@Override
+public List getSplits() throws UserException {
+if (incrementalRead && !incrementalRelation.fallbackFullTableScan()) {
+return getIncrementalSplits();
+}
+List splits = Collections.synchronizedList(new ArrayList<>());
+getPartitionSplits(prunedPartitions, splits);
+return splits;
+}
+
+public List getNextBatch(int maxBatchSize) throws UserException {
+List splits = Collections.synchronizedList(new ArrayList<>());
+int numPartitions = 0;
+while (splits.size() < maxBatchSize && prunedPartitionsIter.hasNext())
{
+List partitions = new
ArrayList<>(NUM_PARTITIONS_PER_LOOP);
+for (int i = 0; i < NUM_PARTITIONS_PER_LOOP &&
prunedPartitionsIter.hasNext(); ++i) {
+partitions.add(prunedPartitionsIter.next());
+numPartitions++;
+}
+getPartitionSplits(partitions, splits);
+}
+if (splits.size() / numPartitions > numSplitsPerPartition) {
+numSplitsPerPartition = splits.size() / numPartitions;
+}
return splits;
}
+public boolean hasNext() {
+return prunedPartitionsIter.hasNext();
+}
+
+public boolean isBatchMode() {
Review Comment:
@Override
##
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.j
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
morningman commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106266595 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106266881 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106266889 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
github-actions[bot] commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106268090 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](decimal) improve overflow error message [doris]
jacktengg commented on PR #34689: URL: https://github.com/apache/doris/pull/34689#issuecomment-2106268621 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]
Mryange commented on PR #34720: URL: https://github.com/apache/doris/pull/34720#issuecomment-2106270106 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106270680 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
github-actions[bot] commented on code in PR #34679:
URL: https://github.com/apache/doris/pull/34679#discussion_r1597652023
##
be/src/io/fs/s3_file_writer.cpp:
##
@@ -248,7 +240,7 @@ Status S3FileWriter::close() {
}
Status S3FileWriter::appendv(const Slice* data, size_t data_cnt) {
Review Comment:
warning: function 'appendv' has cognitive complexity of 65 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status S3FileWriter::appendv(const Slice* data, size_t data_cnt) {
^
```
Additional context
**be/src/io/fs/s3_file_writer.cpp:242:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
if (closed() != FileWriterState::OPEN) [[unlikely]] {
^
```
**be/src/io/fs/s3_file_writer.cpp:247:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("s3_file_writer::appendv",
^
```
**be/src/util/debug_points.h:35:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) {
\
^
```
**be/src/io/fs/s3_file_writer.cpp:247:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("s3_file_writer::appendv",
^
```
**be/src/util/debug_points.h:37:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) {
\
^
```
**be/src/io/fs/s3_file_writer.cpp:249:** +1, including nesting penalty of 0,
nesting level increased to 1
```cpp
for (size_t i = 0; i < data_cnt; i++) {
^
```
**be/src/io/fs/s3_file_writer.cpp:251:** +2, including nesting penalty of 1,
nesting level increased to 2
```cpp
for (size_t pos = 0, data_size_to_append = 0; pos < data_size; pos
+= data_size_to_append) {
^
```
**be/src/io/fs/s3_file_writer.cpp:252:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if (_failed) {
^
```
**be/src/io/fs/s3_file_writer.cpp:255:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if (!_pending_buf) {
^
```
**be/src/io/fs/s3_file_writer.cpp:259:** nesting level increased to 4
```cpp
[part_num = _cur_part_num,
this](UploadFileBuffer& buf) {
^
```
**be/src/io/fs/s3_file_writer.cpp:263:** nesting level increased to 4
```cpp
.set_sync_after_complete_task([this, part_num =
_cur_part_num](Status s) {
^
```
**be/src/io/fs/s3_file_writer.cpp:265:** +5, including nesting penalty of 4,
nesting level increased to 5
```cpp
if (!s.ok()) [[unlikely]] {
^
```
**be/src/io/fs/s3_file_writer.cpp:279:** nesting level increased to 4
```cpp
.set_is_cancelled([this]() { return _failed.load();
});
^
```
**be/src/io/fs/s3_file_writer.cpp:280:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
if (_cache_builder != nullptr) {
^
```
**be/src/io/fs/s3_file_writer.cpp:292:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(builder.build(&_pending_buf));
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/io/fs/s3_file_writer.cpp:292:** +5, including nesting penalty of 4,
nesting level increased to 5
```cpp
RETURN_IF_ERROR(builder.build(&_pending_buf));
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/io/fs/s3_file_writer.cpp:301:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
RETURN_IF_ERROR(_pending_buf->append_data(
^
```
**be/src/common/status.h:570:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do {\
^
```
**be/src/io/fs/s3_file_writer.cpp:301:** +4, including nesting penalty of 3,
nesting level increased to 4
```cpp
RETURN_IF_ERROR(_pending_buf->append_data(
^
```
**be/src/common/status.h:572:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/io/fs/s3_file_writer.cpp:307:** +3, including nesting penalty of 2,
nesting level increased to 3
```cpp
if (_pending_buf->ge
Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]
github-actions[bot] commented on PR #34720: URL: https://github.com/apache/doris/pull/34720#issuecomment-2106271836 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106272237 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106272701 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106273349 TeamCity be ut coverage result: Function Coverage: 35.65% (8984/25203) Line Coverage: 27.32% (74277/271866) Region Coverage: 26.56% (38392/144574) Branch Coverage: 23.37% (19578/83766) Coverage Report: http://coverage.selectdb-in.cc/coverage/eaee586a17b95fbe2fd63b99e5cfda62b000dd09_eaee586a17b95fbe2fd63b99e5cfda62b000dd09/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](expr) fix expr serde, let it work as expected [doris]
morningman commented on code in PR #34449:
URL: https://github.com/apache/doris/pull/34449#discussion_r1597650487
##
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##
@@ -65,8 +65,11 @@ public enum Operator {
GT(">", "gt", TExprOpcode.GT),
EQ_FOR_NULL("<=>", "eq_for_null", TExprOpcode.EQ_FOR_NULL);
+@SerializedName("desc")
Review Comment:
use short name
##
fe/fe-core/src/main/java/org/apache/doris/analysis/CompoundPredicate.java:
##
@@ -41,7 +43,9 @@
*/
public class CompoundPredicate extends Predicate {
private static final Logger LOG =
LogManager.getLogger(CompoundPredicate.class);
-private final Operator op;
+@Expose
Review Comment:
Why explicitly use @Expose?
##
fe/fe-core/src/main/java/org/apache/doris/analysis/BetweenPredicate.java:
##
@@ -34,7 +36,13 @@
public class BetweenPredicate extends Predicate {
private static final Logger LOG =
LogManager.getLogger(BetweenPredicate.class);
-private final boolean isNotBetween;
+@Expose
+@SerializedName("isNotBetween")
Review Comment:
use short name, eg `inb`
##
fe/fe-core/src/main/java/org/apache/doris/analysis/VirtualSlotRef.java:
##
@@ -122,4 +105,9 @@ public void analyzeImpl(Analyzer analyzer) throws
AnalysisException {
public String getExprName() {
return super.getExprName();
}
+
+@Override
+public boolean supportSerializable() {
+return false;
Review Comment:
Why return false?
It has a `write()` method before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106285312 TPC-H: Total hot run time: 41877 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit eaee586a17b95fbe2fd63b99e5cfda62b000dd09, data reload: false -- Round 1 -- q1 17642 426542034203 q2 2021187 189 187 q3 10442 126012391239 q4 10205 777 841 777 q5 7459267127632671 q6 224 136 131 131 q7 1006594 585 585 q8 9228211320942094 q9 9271670667166706 q10 9031380338493803 q11 466 242 240 240 q12 482 220 220 220 q13 17388 319832203198 q14 279 234 225 225 q15 519 468 489 468 q16 515 432 414 414 q17 980 702 654 654 q18 8223781777817781 q19 6696157415321532 q20 655 320 331 320 q21 5280414742234147 q22 353 288 282 282 Total cold run time: 118365 ms Total hot run time: 41877 ms - Round 2, with runtime_filter_mode=off - q1 4583433844084338 q2 368 280 268 268 q3 3182296529662965 q4 2022162016421620 q5 5443550055375500 q6 213 123 122 122 q7 2345194919171917 q8 3271339634133396 q9 8578871786478647 q10 3940369837893698 q11 589 521 485 485 q12 791 619 623 619 q13 17023 313531243124 q14 285 262 277 262 q15 524 483 483 483 q16 482 456 448 448 q17 1826150914761476 q18 7686751374097409 q19 1652148715371487 q20 2005176517811765 q21 12840 480248244802 q22 580 508 502 502 Total cold run time: 80228 ms Total hot run time: 55333 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Nereids) Nereids supports group_commit with insert [doris]
zzzs commented on PR #32523: URL: https://github.com/apache/doris/pull/32523#issuecomment-2106285714 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the `_is_closed` flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34668: URL: https://github.com/apache/doris/pull/34668#issuecomment-2106288350 TPC-DS: Total hot run time: 186978 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit eaee586a17b95fbe2fd63b99e5cfda62b000dd09, data reload: false query1 919 360 353 353 query2 7166240124692401 query3 6639213 212 212 query4 22815 21165 21145 21145 query5 4135411 413 411 query6 276 175 171 171 query7 4582296 285 285 query8 238 197 199 197 query9 8523243924212421 query10 433 265 264 264 query11 14841 14258 14234 14234 query12 133 100 97 97 query13 1655379 372 372 query14 10706 753375817533 query15 212 170 171 170 query16 7690267 256 256 query17 1306555 539 539 query18 1939269 290 269 query19 194 145 145 145 query20 87 85 84 84 query21 190 133 127 127 query22 4992485048014801 query23 34078 33686 33618 33618 query24 8819286029642860 query25 590 380 363 363 query26 702 156 152 152 query27 2244319 314 314 query28 5766208020582058 query29 843 601 614 601 query30 268 148 153 148 query31 949 768 740 740 query32 95 56 54 54 query33 583 250 243 243 query34 861 494 480 480 query35 771 678 700 678 query36 1066890 945 890 query37 105 67 67 67 query38 2898281927682768 query39 1619155715481548 query40 205 130 124 124 query41 42 62 37 37 query42 104 95 94 94 query43 601 562 573 562 query44 1057724 739 724 query45 267 248 254 248 query46 1067707 744 707 query47 1955186419081864 query48 379 303 300 300 query49 839 397 394 394 query50 769 386 397 386 query51 6976681967646764 query52 107 89 90 89 query53 354 279 276 276 query54 636 433 422 422 query55 72 70 73 70 query56 235 220 219 219 query57 1250115211571152 query58 218 200 206 200 query59 3526320931513151 query60 254 233 234 233 query61 126 90 91 90 query62 616 471 474 471 query63 311 280 283 280 query64 8478745973247324 query65 3102308930653065 query66 784 350 347 347 query67 15505 15035 14815 14815 query68 4509538 565 538 query69 482 320 308 308 query70 1170110711461107 query71 384 273 325 273 query72 7069261023472347 query73 700 328 326 326 query74 6496612360696069 query75 3307263926152615 query76 2235986 997 986 query77 389 263 261 261 query78 10646 10035 10046 10035 query79 2460515 504 504 query80 1090452 429 429 query81 544 218 220 218 query82 926 96 94 94 query83 237 165 162 162 query84 246 87 82 82 query85 1268271 318 271 query86 457 293 301 293 query87 3312319531253125 query88 4414245424692454 query89 483 398 399 398 query90 1996195 187 187 query91 123 99 98 98 query92 54 48 50 48 query93 1853510 489 489 query94 1296182 181 181 query95 402 293 303 293 query96 594 269 270 269 query97 3145294929762949 query98 235 211 221 211 query99 1174881 904 881 Total cold run time: 275459 ms Total hot run time: 186978 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]
morningman commented on PR #32164: URL: https://github.com/apache/doris/pull/32164#issuecomment-2106291999 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]
github-actions[bot] commented on PR #32164: URL: https://github.com/apache/doris/pull/32164#issuecomment-2106292262 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106292420 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]
DarvenDuan commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2106292530 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]
github-actions[bot] commented on PR #32164: URL: https://github.com/apache/doris/pull/32164#issuecomment-2106293619 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]
doris-robot commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2106299576 TeamCity be ut coverage result: Function Coverage: 35.65% (8985/25205) Line Coverage: 27.31% (74262/271916) Region Coverage: 26.54% (38373/144586) Branch Coverage: 23.36% (19574/83780) Coverage Report: http://coverage.selectdb-in.cc/coverage/d8bb11c6811f6e2d7bab416d389d117e3661aafe_d8bb11c6811f6e2d7bab416d389d117e3661aafe/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]
doris-robot commented on PR #34720: URL: https://github.com/apache/doris/pull/34720#issuecomment-2106301671 TeamCity be ut coverage result: Function Coverage: 35.65% (8984/25202) Line Coverage: 27.31% (74263/271878) Region Coverage: 26.55% (38382/144579) Branch Coverage: 23.36% (19571/83766) Coverage Report: http://coverage.selectdb-in.cc/coverage/60278271c99fd32cb261e1cd8f35545e530590c7_60278271c99fd32cb261e1cd8f35545e530590c7/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]
doris-robot commented on PR #32164: URL: https://github.com/apache/doris/pull/32164#issuecomment-2106318351 TeamCity be ut coverage result: Function Coverage: 35.65% (8986/25206) Line Coverage: 27.32% (74275/271909) Region Coverage: 26.55% (38392/144592) Branch Coverage: 23.37% (19576/83776) Coverage Report: http://coverage.selectdb-in.cc/coverage/49a3a9082cb6ae5bf5d066cf945ee3ebb0f5f575_49a3a9082cb6ae5bf5d066cf945ee3ebb0f5f575/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [doc](cloud) Update deployment and file cache [doris-website]
gavinchou opened a new pull request, #642: URL: https://github.com/apache/doris-website/pull/642 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
doris-robot commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106338711 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106338742 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb opened a new pull request, #34740: URL: https://github.com/apache/doris/pull/34740 ## Proposed changes Issue Number: close #xxx Before if we have multi sender but some of their sink node have no data of some specific partition, then this sink won't know it has to close it. So tablets channel won't be closed correctly. Now change close time needed count to same with open in tablets channel. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb closed pull request #33996: [Fix](auto-partition) fix auto partition load lost data in multi sender URL: https://github.com/apache/doris/pull/33996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106339311 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](cloud) Use c++20 and unleash endian check [doris]
github-actions[bot] commented on PR #34735: URL: https://github.com/apache/doris/pull/34735#issuecomment-2106339599 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
github-actions[bot] commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106340056 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
github-actions[bot] commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106340616 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](function) fix wrong describe of function from_unixtime [doris-website]
zclllyybb opened a new pull request, #643: URL: https://github.com/apache/doris-website/pull/643 This pr could directly be merged without any code change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106364311 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
github-actions[bot] commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106365452 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
doris-robot commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106373160 TPC-H: Total hot run time: 40797 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 21c0f3a7662207bc4d6c9e078c3c15e56b5fa724, data reload: false -- Round 1 -- q1 17605 434141984198 q2 2032205 193 193 q3 10441 123511981198 q4 10215 747 923 747 q5 7485268626232623 q6 234 127 137 127 q7 1064600 577 577 q8 9228215820792079 q9 9091676267356735 q10 9306389938773877 q11 460 238 240 238 q12 423 219 232 219 q13 17455 312232983122 q14 259 221 218 218 q15 511 476 468 468 q16 465 407 401 401 q17 980 741 752 741 q18 8297767976397639 q19 7478155915021502 q20 625 323 312 312 q21 5210423833093309 q22 349 274 286 274 Total cold run time: 119213 ms Total hot run time: 40797 ms - Round 2, with runtime_filter_mode=off - q1 4565444943124312 q2 379 277 260 260 q3 3125292028702870 q4 1884160415991599 q5 5475548254905482 q6 210 121 125 121 q7 2296198719511951 q8 3231336533633363 q9 8684867587248675 q10 3912381038283810 q11 577 505 506 505 q12 786 619 622 619 q13 17048 314431713144 q14 294 273 300 273 q15 516 465 468 465 q16 458 404 422 404 q17 1739147314701470 q18 7673757773057305 q19 1641149515521495 q20 1960176417681764 q21 8768484147914791 q22 560 489 480 480 Total cold run time: 75781 ms Total hot run time: 55158 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
doris-robot commented on PR #34740: URL: https://github.com/apache/doris/pull/34740#issuecomment-2106375965 TPC-DS: Total hot run time: 186958 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 21c0f3a7662207bc4d6c9e078c3c15e56b5fa724, data reload: false query1 898 369 361 361 query2 6435231622372237 query3 6637204 211 204 query4 25153 21190 21261 21190 query5 4124411 412 411 query6 261 171 167 167 query7 4585288 288 288 query8 240 178 189 178 query9 8697244824292429 query10 435 245 250 245 query11 14711 14238 14143 14143 query12 139 95 84 84 query13 1642366 366 366 query14 9652859383478347 query15 219 165 178 165 query16 7815259 261 259 query17 1725546 544 544 query18 2000267 259 259 query19 186 146 143 143 query20 93 87 85 85 query21 195 129 127 127 query22 5036482748884827 query23 34246 33455 33456 33455 query24 6691287629082876 query25 527 360 382 360 query26 701 152 155 152 query27 2008317 321 317 query28 3750206520512051 query29 867 602 595 595 query30 233 178 152 152 query31 972 780 740 740 query32 86 51 54 51 query33 491 246 245 245 query34 868 487 486 486 query35 775 703 693 693 query36 1081922 936 922 query37 106 66 70 66 query38 2864274927622749 query39 1591154815621548 query40 204 125 124 124 query41 42 39 38 38 query42 99 96 92 92 query43 556 543 524 524 query44 1084720 735 720 query45 274 261 258 258 query46 1077692 695 692 query47 1915191018711871 query48 372 296 295 295 query49 771 391 395 391 query50 765 387 374 374 query51 6806674268476742 query52 112 91 92 91 query53 357 282 280 280 query54 525 439 427 427 query55 73 74 74 74 query56 241 228 215 215 query57 1228115611371137 query58 209 194 196 194 query59 3456304730783047 query60 256 233 261 233 query61 93 85 88 85 query62 612 475 477 475 query63 309 281 285 281 query64 8347733774497337 query65 3138308431143084 query66 782 342 345 342 query67 15052 15122 14780 14780 query68 4488531 539 531 query69 470 303 301 301 query70 1192105711451057 query71 391 272 269 269 query72 7409257423222322 query73 700 324 322 322 query74 6541603259755975 query75 3283263725972597 query76 2227101610011001 query77 379 268 258 258 query78 10595 10008 10124 10008 query79 2398507 504 504 query80 893 427 444 427 query81 503 224 224 224 query82 733 91 92 91 query83 234 157 159 157 query84 244 90 85 85 query85 1195270 259 259 query86 464 292 308 292 query87 3263307630573057 query88 4204245024412441 query89 477 378 378 378 query90 2086197 191 191 query91 122 101 96 96 query92 57 50 48 48 query93 1932509 495 495 query94 1103180 174 174 query95 398 302 303 302 query96 593 276 271 271 query97 3200298129802980 query98 264 230 220 220 query99 1226907 905 905 Total cold run time: 270754 ms Total hot run time: 186958 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts [doris]
github-actions[bot] closed pull request #25203: [fix](Tools) Fix the escape character '\' error in sql generated by tpcds tools scripts URL: https://github.com/apache/doris/pull/25203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Doris leozhuo [doris]
github-actions[bot] commented on PR #26496: URL: https://github.com/apache/doris/pull/26496#issuecomment-2106422667 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](be)fix merged_columns and num_columns lnconsistency problem [doris]
github-actions[bot] commented on PR #26615: URL: https://github.com/apache/doris/pull/26615#issuecomment-2106422652 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
github-actions[bot] commented on PR #34683: URL: https://github.com/apache/doris/pull/34683#issuecomment-2106445841 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) error format case in test_query_json_object [doris]
Mryange commented on PR #34722: URL: https://github.com/apache/doris/pull/34722#issuecomment-2106453005 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](Rqg445) do not push rf through cteAnchor [doris]
englefly opened a new pull request, #34741: URL: https://github.com/apache/doris/pull/34741 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Rqg445) do not push rf through cteAnchor [doris]
doris-robot commented on PR #34741: URL: https://github.com/apache/doris/pull/34741#issuecomment-2106463306 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids)do not push rf through cteAnchor [doris]
englefly opened a new pull request, #34742: URL: https://github.com/apache/doris/pull/34742 ## Proposed changes Or_expansion rule create a CTEAnchor inside plan tree, and there are some columns above anchor sharing the same ExprId with columns under anchor. This mislead runtime pushdown visitor. Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)do not push rf through cteAnchor [doris]
doris-robot commented on PR #34742: URL: https://github.com/apache/doris/pull/34742#issuecomment-2106464935 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) insert into select time [doris]
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2106483488 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](framework) support trino connector tests in multi be and fe env [doris]
github-actions[bot] commented on PR #34731: URL: https://github.com/apache/doris/pull/34731#issuecomment-2106487683 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) insert into select time [doris]
github-actions[bot] commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2106488893 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](Paimon) support deletion vector for Paimon naive reader [doris]
suxiaogang223 opened a new pull request, #34743: URL: https://github.com/apache/doris/pull/34743 ## Proposed changes support support deletion vector for Paimon naive reader ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Paimon) support deletion vector for Paimon naive reader [doris]
doris-robot commented on PR #34743: URL: https://github.com/apache/doris/pull/34743#issuecomment-2106489168 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](mtmv)Mtmv rollup [doris]
zddr commented on code in PR #31812:
URL: https://github.com/apache/doris/pull/31812#discussion_r1597789288
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java:
##
@@ -0,0 +1,225 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+//
https://github.com/apache/impala/blob/branch-2.9.0/fe/src/main/java/org/apache/impala/Expr.java
+// and modified by Doris
+
+package org.apache.doris.nereids.trees.plans.commands.info;
+
+import org.apache.doris.analysis.Expr;
+import org.apache.doris.analysis.FunctionCallExpr;
+import org.apache.doris.analysis.FunctionParams;
+import org.apache.doris.analysis.SlotRef;
+import org.apache.doris.analysis.StringLiteral;
+import org.apache.doris.common.DdlException;
+import org.apache.doris.datasource.hive.HMSExternalTable;
+import org.apache.doris.mtmv.MTMVPartitionExprFactory;
+import org.apache.doris.mtmv.MTMVPartitionInfo;
+import org.apache.doris.mtmv.MTMVPartitionInfo.MTMVPartitionType;
+import org.apache.doris.mtmv.MTMVRelatedTableIf;
+import org.apache.doris.mtmv.MTMVUtil;
+import org.apache.doris.nereids.CascadesContext;
+import org.apache.doris.nereids.NereidsPlanner;
+import org.apache.doris.nereids.analyzer.UnboundFunction;
+import org.apache.doris.nereids.analyzer.UnboundSlot;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.properties.PhysicalProperties;
+import org.apache.doris.nereids.rules.exploration.mv.MaterializedViewUtils;
+import
org.apache.doris.nereids.rules.exploration.mv.MaterializedViewUtils.RelatedTableInfo;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.Literal;
+import org.apache.doris.nereids.trees.plans.Plan;
+import
org.apache.doris.nereids.trees.plans.commands.ExplainCommand.ExplainLevel;
+import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.SessionVariable;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * MTMVPartitionDefinition
+ */
+public class MTMVPartitionDefinition {
+private MTMVPartitionType partitionType;
+private String partitionCol;
+private Expression functionCallExpression;
+
+/**
+ * analyzeAndTransferToMTMVPartitionInfo
+ *
+ * @param planner planner
+ * @param ctx ctx
+ * @param logicalQuery logicalQuery
+ * @return MTMVPartitionInfo
+ */
+public MTMVPartitionInfo
analyzeAndTransferToMTMVPartitionInfo(NereidsPlanner planner, ConnectContext
ctx,
+LogicalPlan logicalQuery) {
+MTMVPartitionInfo mtmvPartitionInfo = new
MTMVPartitionInfo(partitionType);
+if (this.partitionType == MTMVPartitionType.SELF_MANAGE) {
+return mtmvPartitionInfo;
+}
+String partitionColName;
+if (this.partitionType == MTMVPartitionType.EXPR) {
+Expr expr =
convertToLegacyAutoPartitionExprs(Lists.newArrayList(functionCallExpression))
+.get(0);
+partitionColName = getColNameFromExpr(expr);
+mtmvPartitionInfo.setExpr(expr);
+} else {
+partitionColName = this.partitionCol;
+}
+mtmvPartitionInfo.setPartitionCol(partitionColName);
+RelatedTableInfo relatedTableInfo = getRelatedTableInfo(planner, ctx,
logicalQuery, partitionColName);
+mtmvPartitionInfo.setRelatedCol(relatedTableInfo.getColumn());
+mtmvPartitionInfo.setRelatedTable(relatedTableInfo.getTableInfo());
+if (this.partitionType == MTMVPartitionType.EXPR) {
+try {
+
MTMVPartitionExprFactory.getExprSerice(mtmvPartitionInfo.getExpr()).analyze(mtmvPartitionInfo);
Review Comment:
service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
Re: [PR] [fix](Rqg445) do not push rf through cteAnchor [doris]
englefly closed pull request #34741: [fix](Rqg445) do not push rf through cteAnchor URL: https://github.com/apache/doris/pull/34741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids) do not push rf through cteAnchor [doris]
englefly opened a new pull request, #34744: URL: https://github.com/apache/doris/pull/34744 ## Proposed changes Or_expansion rule create a CTEAnchor inside plan tree, and there are some columns above anchor sharing the same ExprId with columns under anchor. This mislead runtime pushdown visitor. Solution: when detect anchor inside plan tree, do not push rf through it. Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) do not push rf through cteAnchor [doris]
doris-robot commented on PR #34744: URL: https://github.com/apache/doris/pull/34744#issuecomment-2106500420 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) do not push rf through cteAnchor [doris]
englefly commented on PR #34744: URL: https://github.com/apache/doris/pull/34744#issuecomment-2106500492 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](mtmv)Mv refresh on commit [doris]
zddr commented on PR #34548: URL: https://github.com/apache/doris/pull/34548#issuecomment-2106503092 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](set) enable admin_set_frontend_config can apply to all fe [doris]
github-actions[bot] commented on PR #34685: URL: https://github.com/apache/doris/pull/34685#issuecomment-2106504359 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](set) enable admin_set_frontend_config can apply to all fe [doris]
github-actions[bot] commented on PR #34685: URL: https://github.com/apache/doris/pull/34685#issuecomment-2106504402 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids): eliminate useless project [doris]
github-actions[bot] commented on PR #34611: URL: https://github.com/apache/doris/pull/34611#issuecomment-2106506850 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix] Fix clang-18 and libc++ compile problems [doris]
biohazard4321 commented on PR #34715: URL: https://github.com/apache/doris/pull/34715#issuecomment-2106507746 please approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Nereids) Nereids supports group_commit with insert [doris]
mymeiyi commented on code in PR #32523:
URL: https://github.com/apache/doris/pull/32523#discussion_r1597794113
##
regression-test/suites/insert_p0/insert_group_commit_into.groovy:
##
@@ -132,11 +132,13 @@ suite("insert_group_commit_into") {
"""
connect(user = context.config.jdbcUser, password =
context.config.jdbcPassword, url = context.config.jdbcUrl +
"&useLocalSessionState=true") {
+// TODO: pipeline need to be implemented
+sql """ set experimental_enable_nereids_dml_with_pipeline =
false; """
Review Comment:
should remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Fix failed p2 hive statistics case. (#34663) [doris]
Jibing-Li opened a new pull request, #34745: URL: https://github.com/apache/doris/pull/34745 backport https://github.com/apache/doris/pull/34663 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fix failed p2 hive statistics case. (#34663) [doris]
doris-robot commented on PR #34745: URL: https://github.com/apache/doris/pull/34745#issuecomment-2106509789 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](ui) web profile download use plain text [doris]
Mryange commented on code in PR #34705:
URL: https://github.com/apache/doris/pull/34705#discussion_r1597795224
##
fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/QueryProfileController.java:
##
@@ -59,6 +59,15 @@ public Object profile(@PathVariable(value = ID) String id) {
return ResponseEntityBuilder.ok(profile);
}
+@RequestMapping(path = "/query_profile/text/{" + ID + "}", method =
RequestMethod.GET)
Review Comment:
web use download
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids): eliminate useless project [doris]
github-actions[bot] commented on PR #34611: URL: https://github.com/apache/doris/pull/34611#issuecomment-2106513553 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FIX](array_index)fix array tokenized index parser and array_contains bugs [doris]
eldenmoon merged PR #34683: URL: https://github.com/apache/doris/pull/34683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
