morningman commented on code in PR #34449:
URL: https://github.com/apache/doris/pull/34449#discussion_r1597650487
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -65,8 +65,11 @@ public enum Operator {
GT(">", "gt", TExprOpcode.GT),
EQ_FOR_NULL("<=>", "eq_for_null", TExprOpcode.EQ_FOR_NULL);
+ @SerializedName("desc")
Review Comment:
use short name
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CompoundPredicate.java:
##########
@@ -41,7 +43,9 @@
*/
public class CompoundPredicate extends Predicate {
private static final Logger LOG =
LogManager.getLogger(CompoundPredicate.class);
- private final Operator op;
+ @Expose
Review Comment:
Why explicitly use @Expose?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BetweenPredicate.java:
##########
@@ -34,7 +36,13 @@
public class BetweenPredicate extends Predicate {
private static final Logger LOG =
LogManager.getLogger(BetweenPredicate.class);
- private final boolean isNotBetween;
+ @Expose
+ @SerializedName("isNotBetween")
Review Comment:
use short name, eg `inb`
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/VirtualSlotRef.java:
##########
@@ -122,4 +105,9 @@ public void analyzeImpl(Analyzer analyzer) throws
AnalysisException {
public String getExprName() {
return super.getExprName();
}
+
+ @Override
+ public boolean supportSerializable() {
+ return false;
Review Comment:
Why return false?
It has a `write()` method before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
