Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28556:
URL: https://github.com/apache/doris/pull/28556#issuecomment-1859727299

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit cfb3f1ccb0fb51b26e90075f7648568a38735da8, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4750443744674437
   q2   370 147 159 147
   q3   1450125412801254
   q4   1131924 919 919
   q5   3165314930983098
   q6   250 132 129 129
   q7   1011483 491 483
   q8   2237224121832183
   q9   6694666566806665
   q10  3243327732713271
   q11  317 206 196 196
   q12  346 219 207 207
   q13  4588383237883788
   q14  240 211 215 211
   q15  573 518 529 518
   q16  440 389 382 382
   q17  1019574 525 525
   q18  7269704369356935
   q19  1553142613801380
   q20  515 334 288 288
   q21  3103262527492625
   q22  352 282 287 282
   Total cold run time: 44616 ms
   Total hot run time: 39923 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4403439943684368
   q2   265 164 171 164
   q3   3537351935253519
   q4   2379237323692369
   q5   5729571957355719
   q6   246 120 124 120
   q7   2379186418341834
   q8   3528352235223522
   q9   9033897089738970
   q10  3897399639963996
   q11  494 387 390 387
   q12  762 608 613 608
   q13  4267356635693566
   q14  287 259 265 259
   q15  579 514 522 514
   q16  507 444 449 444
   q17  1891185518721855
   q18  8681833782568256
   q19  1713176617551755
   q20  2261194419391939
   q21  6541620261806180
   q22  515 425 417 417
   Total cold run time: 63894 ms
   Total hot run time: 60761 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](regresson) fix vcompound constant column regression case [doris]

2023-12-18 Thread via GitHub


airborne12 commented on PR #28560:
URL: https://github.com/apache/doris/pull/28560#issuecomment-1859727875

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [Fix](regresson) fix vcompound constant column regression case [doris]

2023-12-18 Thread via GitHub


airborne12 opened a new pull request, #28560:
URL: https://github.com/apache/doris/pull/28560

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enchancement](delete) fix delete stmt return error with fold on be [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28557:
URL: https://github.com/apache/doris/pull/28557#issuecomment-1859728517

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.9 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  27.9 seconds inserted 1000 Rows, about 
358K ops/s
storage size: 17219889980 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] Can not insert data after enabling the partial column updates [doris]

2023-12-18 Thread via GitHub


bingwill commented on issue #28553:
URL: https://github.com/apache/doris/issues/28553#issuecomment-1859728634

   > > Please refer to 
https://doris.apache.org/zh-CN/docs/dev/data-operate/update-delete/partial-update?_highlight=enable_unique_key_partial_update#%E9%80%82%E7%94%A8%E5%9C%BA%E6%99%AF
   > 
   > set enable_insert_strict = false;
   Thank you
   Yes,I'v noticed this **enable_insert_strict**,but it seems to be focused on 
those column key that does not exist only. In this case all my columns and 
values are all matched. And most import is,if i set it as false doris will 
return success when one entry imported correctly.What i want is to import all 
data correctly or no one correctly.
   
![e_i_s](https://github.com/apache/doris/assets/150641822/d20fc330-ec27-4bce-8943-5fb501edfb6c)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


yiguolei commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429633455


##
fe/fe-core/src/main/java/org/apache/doris/common/publish/WorkloadMoveActionPublisherThread.java:
##
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.publish;
+
+import org.apache.doris.common.ClientPool;
+import org.apache.doris.common.ThreadPoolManager;
+import org.apache.doris.common.util.Daemon;
+import org.apache.doris.system.Backend;
+import org.apache.doris.system.SystemInfoService;
+import org.apache.doris.thrift.BackendService;
+import org.apache.doris.thrift.TNetworkAddress;
+import org.apache.doris.thrift.TPublishTopicRequest;
+import org.apache.doris.thrift.TTopicInfoType;
+import org.apache.doris.thrift.TWorkloadMoveQueryToGroupAction;
+import org.apache.doris.thrift.TopicInfo;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.concurrent.ExecutorService;
+
+public class WorkloadMoveActionPublisherThread extends Daemon {

Review Comment:
   那我觉得 也不能move action 启动一个thread,每个action 都搞一个trhead 太废了,然后别人想写workload 
group的代码也很费劲。
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


yiguolei commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429635537


##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadCondition.java:
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+import org.apache.doris.common.UserException;
+
+
+public interface WorkloadCondition {
+
+boolean eval(String strValue);
+
+WorkloadMetricType getMetricType();
+
+// NOTE(wb) currently createPolicyCondition is also used when replay meta, 
it better not contains heavy check
+static WorkloadCondition createWorkloadCondition(String metricName, String 
op, String value)
+throws UserException {
+if (WorkloadMetricType.username.toString().equals(metricName)) {

Review Comment:
   这里也是,不要tostring 比较



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


yiguolei commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429637175


##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadConditionQueryTime.java:
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+import org.apache.doris.common.UserException;
+
+public class WorkloadConditionQueryTime implements WorkloadCondition {
+
+private long value;
+private WorkloadConditionOperator op;
+
+public WorkloadConditionQueryTime(WorkloadConditionOperator op, long 
value) {
+this.op = op;
+this.value = value;
+}
+
+@Override
+public boolean eval(String strValue) {
+long inputLongValue = Long.parseLong(strValue);
+return WorkloadConditionCompareUtils.compareInteger(op, 
inputLongValue, value);
+}
+
+public static WorkloadConditionQueryTime 
createWorkloadCondition(WorkloadConditionOperator op, String value)
+throws UserException {
+long longValue = Long.parseLong(value);
+if (longValue < 0) {
+throw new UserException("invalid query time value, " + longValue + 
", it requires >= 0");
+}
+return new WorkloadConditionQueryTime(op, longValue);
+}
+
+@Override
+public WorkloadMetricType getMetricType() {
+return WorkloadMetricType.query_time;

Review Comment:
   java 里的枚举一般都是全部大写字母



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


yiguolei commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429639152


##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicyMgr.java:
##
@@ -0,0 +1,509 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+import org.apache.doris.analysis.AlterWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.CreateWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.DropWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.common.proc.BaseProcResult;
+import org.apache.doris.common.proc.ProcResult;
+import org.apache.doris.common.util.DebugUtil;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.persist.gson.GsonPostProcessable;
+import org.apache.doris.persist.gson.GsonUtils;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.service.ExecuteEnv;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Maps;
+import com.google.gson.annotations.SerializedName;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+public class WorkloadSchedPolicyMgr implements Writable, GsonPostProcessable {
+
+private static final Logger LOG = 
LogManager.getLogger(WorkloadSchedPolicyMgr.class);
+
+@SerializedName(value = "idToPolicy")
+private Map idToPolicy = 
Maps.newConcurrentMap();
+private Map nameToPolicy = Maps.newHashMap();
+
+private PolicyProcNode policyProcNode = new PolicyProcNode();
+
+public static final ImmutableList 
WORKLOAD_SCHED_POLICY_NODE_TITLE_NAMES
+= new ImmutableList.Builder()
+.add("Id").add("Name").add("ItemName").add("ItemValue")
+.build();
+
+private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
+
+public static Comparator policyComparator = new 
Comparator() {
+@Override
+public int compare(WorkloadSchedPolicy p1, WorkloadSchedPolicy p2) {
+return p2.getPriority() - p1.getPriority();
+}
+};
+
+private Thread policyExecThread = new Thread() {

Review Comment:
   每一个thread 都需要有一个名字,当定位问题的时候可以看到名字



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


bobhan1 commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859734481

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859735833

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit e1bd3ffdd8749e73e6a7c64dbb030b170a12e8f1, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4684447344874473
   q2   376 138 167 138
   q3   1458126812771268
   q4   1113902 895 895
   q5   3134318131813181
   q6   247 129 129 129
   q7   990 483 488 483
   q8   2199218721792179
   q9   6693667866866678
   q10  3197326032473247
   q11  327 204 204 204
   q12  356 221 212 212
   q13  4587384138133813
   q14  247 214 215 214
   q15  563 526 529 526
   q16  439 391 391 391
   q17  1024591 527 527
   q18  7192698669826982
   q19  1541142414311424
   q20  536 305 310 305
   q21  3095266326572657
   q22  359 293 289 289
   Total cold run time: 44357 ms
   Total hot run time: 40215 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4419440643844384
   q2   266 172 176 172
   q3   3545353335173517
   q4   2372237823692369
   q5   5718573857345734
   q6   243 122 123 122
   q7   2388187318581858
   q8   3523351835163516
   q9   9041895489958954
   q10  3888399539943994
   q11  507 368 396 368
   q12  761 605 592 592
   q13  4295357935763576
   q14  286 261 258 258
   q15  569 510 524 510
   q16  505 434 474 434
   q17  1888185318641853
   q18  8678812982618129
   q19  1766176917531753
   q20  2262196519491949
   q21  6522619361736173
   q22  517 424 429 424
   Total cold run time: 63959 ms
   Total hot run time: 60639 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-18 Thread via GitHub


caiconghui commented on PR #27943:
URL: https://github.com/apache/doris/pull/27943#issuecomment-1859739679

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


yiguolei commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429645572


##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicyMgr.java:
##
@@ -0,0 +1,509 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+import org.apache.doris.analysis.AlterWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.CreateWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.DropWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.common.proc.BaseProcResult;
+import org.apache.doris.common.proc.ProcResult;
+import org.apache.doris.common.util.DebugUtil;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.persist.gson.GsonPostProcessable;
+import org.apache.doris.persist.gson.GsonUtils;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.service.ExecuteEnv;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Maps;
+import com.google.gson.annotations.SerializedName;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+public class WorkloadSchedPolicyMgr implements Writable, GsonPostProcessable {
+
+private static final Logger LOG = 
LogManager.getLogger(WorkloadSchedPolicyMgr.class);
+
+@SerializedName(value = "idToPolicy")
+private Map idToPolicy = 
Maps.newConcurrentMap();
+private Map nameToPolicy = Maps.newHashMap();
+
+private PolicyProcNode policyProcNode = new PolicyProcNode();
+
+public static final ImmutableList 
WORKLOAD_SCHED_POLICY_NODE_TITLE_NAMES
+= new ImmutableList.Builder()
+.add("Id").add("Name").add("ItemName").add("ItemValue")
+.build();
+
+private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
+
+public static Comparator policyComparator = new 
Comparator() {
+@Override
+public int compare(WorkloadSchedPolicy p1, WorkloadSchedPolicy p2) {
+return p2.getPriority() - p1.getPriority();
+}
+};
+
+private Thread policyExecThread = new Thread() {
+@Override
+public void run() {
+while (true) {
+try {
+// 1 get query info map
+Map connectMap = 
ExecuteEnv.getInstance().getScheduler()
+.getConnectionMap();
+List queryInfoList = new ArrayList<>();
+
+// a snapshot for connect context
+Set keySet = new HashSet<>();
+keySet.addAll(connectMap.keySet());
+
+for (Integer connectId : keySet) {
+ConnectContext cctx = connectMap.get(connectId);
+if (cctx == null) {
+continue;
+}
+
+String username = cctx.getQualifiedUser();
+long queryTime = System.currentTimeMillis() - 
cctx.getStartTime();
+
+WorkloadQueryInfo policyQueryInfo = new 
WorkloadQueryInfo();
+policyQueryInfo.queryId = 
DebugUtil.printId(cctx.queryId());
+policyQueryInfo.tUniqueId = cctx.queryId();
+policyQueryInfo.context = cctx;
+policyQueryInfo.metricMap = new HashMap<>();
+
policyQueryInfo.metricMap.put(WorkloadMetricType.usern

Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-18 Thread via GitHub


gavinchou commented on PR #28374:
URL: https://github.com/apache/doris/pull/28374#issuecomment-1859740851

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859744359

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enchancement](delete) fix delete stmt return error with fold on be [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28557:
URL: https://github.com/apache/doris/pull/28557#issuecomment-1859744476

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit f87408ad4ffb3800cc4271860326498571f3baff, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4710452144594459
   q2   367 148 158 148
   q3   1468126612421242
   q4   1115909 938 909
   q5   3146318631583158
   q6   248 128 129 128
   q7   992 481 486 481
   q8   2198222422022202
   q9   6703665666976656
   q10  3227328032433243
   q11  331 208 205 205
   q12  357 214 201 201
   q13  4560380438113804
   q14  241 216 217 216
   q15  567 511 521 511
   q16  446 383 387 383
   q17  1019580 477 477
   q18  7222693270746932
   q19  1562144013861386
   q20  544 328 297 297
   q21  3071264126542641
   q22  345 277 286 277
   Total cold run time: 44439 ms
   Total hot run time: 39956 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4409437343794373
   q2   273 161 170 161
   q3   3538352235243522
   q4   2380237123542354
   q5   5725572657255725
   q6   243 120 121 120
   q7   2391186718441844
   q8   3541354035773540
   q9   9002898090178980
   q10  3915399240143992
   q11  501 376 392 376
   q12  762 608 590 590
   q13  4285357035663566
   q14  293 257 252 252
   q15  570 521 526 521
   q16  519 441 465 441
   q17  1899185118441844
   q18  8724817682048176
   q19  1724176617131713
   q20  2263194519211921
   q21  6511614961586149
   q22  497 436 416 416
   Total cold run time: 63965 ms
   Total hot run time: 60576 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](streamload)catch exception [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28558:
URL: https://github.com/apache/doris/pull/28558#issuecomment-1859746506

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.2 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17219689459 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-18 Thread via GitHub


sjyango commented on PR #28556:
URL: https://github.com/apache/doris/pull/28556#issuecomment-1859747923

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](cooldown) Fix problem that followers may never completely cooldown [doris]

2023-12-18 Thread via GitHub


platoneko commented on PR #28561:
URL: https://github.com/apache/doris/pull/28561#issuecomment-1859746924

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


wsjz commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859747929

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Improvement](decimal) reduce overhead on disable check decimal overflow [doris]

2023-12-18 Thread via GitHub


BiteThet commented on PR #28249:
URL: https://github.com/apache/doris/pull/28249#issuecomment-1859748242

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #27943:
URL: https://github.com/apache/doris/pull/27943#issuecomment-1859756155

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-18 Thread via GitHub


gavinchou commented on PR #28374:
URL: https://github.com/apache/doris/pull/28374#issuecomment-1859756909

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](streamload)catch exception [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28558:
URL: https://github.com/apache/doris/pull/28558#issuecomment-1859757985

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 0d16327927839b2eaddfbb9b30a29e2c1627d1a1, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4742451144674467
   q2   363 151 158 151
   q3   1458129012531253
   q4   1113883 874 874
   q5   3154317631983176
   q6   245 125 127 125
   q7   999 482 483 482
   q8   2201221821792179
   q9   6664666966806669
   q10  3226325632293229
   q11  324 196 204 196
   q12  355 208 206 206
   q13  4582379937933793
   q14  243 211 218 211
   q15  561 519 522 519
   q16  441 382 388 382
   q17  1024637 585 585
   q18  7249699769126912
   q19  1553147513871387
   q20  509 303 311 303
   q21  3106264126802641
   q22  346 283 288 283
   Total cold run time: 44458 ms
   Total hot run time: 40023 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4410440043934393
   q2   271 164 169 164
   q3   3536352835203520
   q4   2378238123602360
   q5   5739572957265726
   q6   242 120 123 120
   q7   2397188118801880
   q8   3520352435233523
   q9   9055899889998998
   q10  3922399040063990
   q11  508 380 368 368
   q12  773 602 599 599
   q13  4285355235813552
   q14  292 242 260 242
   q15  566 529 525 525
   q16  501 468 460 460
   q17  1874186118231823
   q18  8709829282928292
   q19  1742178017451745
   q20  2250195119351935
   q21  6573622761616161
   q22  501 434 439 434
   Total cold run time: 64044 ms
   Total hot run time: 60810 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] Can not insert data after enabling the partial column updates [doris]

2023-12-18 Thread via GitHub


bingwill commented on issue #28553:
URL: https://github.com/apache/doris/issues/28553#issuecomment-1859759698

   > > Please refer to 
https://doris.apache.org/zh-CN/docs/dev/data-operate/update-delete/partial-update?_highlight=enable_unique_key_partial_update#%E9%80%82%E7%94%A8%E5%9C%BA%E6%99%AF
   > 
   > set enable_insert_strict = false;
   
   Thank you.
   Yes, I've noticed this **enable_insert_strict too**,but it seems to be 
focused on those column keys that do not exist int table only.In this case,all 
my key match.So it might be a diffrent situation.And most import is if i set 
**enable_insert_strict** to false ,doris may return succese when one entry 
imported correctly according to the docs.
   
![e_i_s](https://github.com/apache/doris/assets/150641822/0e52362d-3611-48d4-99db-77ff9dcf6299).
   What i want is either all data import correctly or no one import correctly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](cooldown) Fix problem that followers may never completely cooldown [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28561:
URL: https://github.com/apache/doris/pull/28561#issuecomment-1859761358

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Improvement](decimal) reduce overhead on disable check decimal overflow [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on code in PR #28249:
URL: https://github.com/apache/doris/pull/28249#discussion_r1429668471


##
be/src/vec/functions/function_cast.h:
##
@@ -256,9 +256,8 @@ struct ConvertImpl {
 
 template 
 static Status execute(FunctionContext* context, Block& block, const 
ColumnNumbers& arguments,

Review Comment:
   warning: function 'execute' has cognitive complexity of 96 (threshold 50) 
[readability-function-cognitive-complexity]
   ```cpp
   static Status execute(FunctionContext* context, Block& block, const 
ColumnNumbers& arguments,
 ^
   ```
   
   Additional context
   
   **be/src/vec/functions/function_cast.h:268:** +1, including nesting penalty 
of 0, nesting level increased to 1
   ```cpp
   if constexpr (IsDataTypeDecimal || 
IsDataTypeDecimal) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:268:** +1
   ```cpp
   if constexpr (IsDataTypeDecimal || 
IsDataTypeDecimal) {
 ^
   ```
   **be/src/vec/functions/function_cast.h:269:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (!(IsDataTypeDecimalOrNumber || 
IsTimeType ||
   ^
   ```
   **be/src/vec/functions/function_cast.h:270:** +1
   ```cpp
   IsTimeV2Type) ||
   ^
   ```
   **be/src/vec/functions/function_cast.h:276:** +1, including nesting penalty 
of 0, nesting level increased to 1
   ```cpp
   if (const ColVecFrom* col_from =
   ^
   ```
   **be/src/vec/functions/function_cast.h:282:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (IsDataTypeDecimal) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:294:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (IsDataTypeDecimal) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:306:** +1, nesting level increased to 
2
   ```cpp
   } else {
 ^
   ```
   **be/src/vec/functions/function_cast.h:309:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (IsDataTypeNumber) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:313:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (std::is_integral_v) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:323:** +2, including nesting penalty 
of 1, nesting level increased to 2
   ```cpp
   if constexpr (IsDataTypeDecimal || 
IsDataTypeDecimal) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:323:** +1
   ```cpp
   if constexpr (IsDataTypeDecimal || 
IsDataTypeDecimal) {
 ^
   ```
   **be/src/vec/functions/function_cast.h:324:** +1
   ```cpp
   bool narrow_integral = context->check_overflow_for_decimal() 
&&

^
   ```
   **be/src/vec/functions/function_cast.h:328:** +3, including nesting penalty 
of 2, nesting level increased to 3
   ```cpp
   if (to_scale > from_scale) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:359:** +1, nesting level increased to 
2
   ```cpp
   } else if constexpr (IsTimeType) {
  ^
   ```
   **be/src/vec/functions/function_cast.h:360:** +3, including nesting penalty 
of 2, nesting level increased to 3
   ```cpp
   for (size_t i = 0; i < size; ++i) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:361:** +4, including nesting penalty 
of 3, nesting level increased to 4
   ```cpp
   if constexpr (IsTimeType) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:363:** +5, including nesting penalty 
of 4, nesting level increased to 5
   ```cpp
   if constexpr (IsDateTimeType) {
   ^
   ```
   **be/src/vec/functions/function_cast.h:365:** +1, nesting level increased to 
5
   ```cpp
   } else {
 ^
   ```
   **be/src/vec/functions/function_cast.h:368:** +1, nesting level increased to 
4
   ```cpp
   } else if constexpr (IsDateV2Type) {
  ^
   ```
   **be/src/vec/functions/function_cast.h:370:** +1, nesting level increased to 
4
   ```cpp
   } else if constexpr (IsDateTimeV2Type) {
  ^
   ```
   **be/src/vec/functions/function_cast.h:372:** +1, nesting level increased to 
4
   ```cpp
   } else {
 ^
   ```
   **be/src/vec/fu

[PR] [chore](Nereids): remove SemiJoinCommute in rewriter [doris]

2023-12-18 Thread via GitHub


jackwener opened a new pull request, #28563:
URL: https://github.com/apache/doris/pull/28563

   ## Proposed changes
   
   analyzer already contained SemiJoinCommute
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] Can not insert data after enabling the partial column updates [doris]

2023-12-18 Thread via GitHub


liugddx commented on issue #28553:
URL: https://github.com/apache/doris/issues/28553#issuecomment-1859771998

   Because you have some data that does not exist in the table, in unique-key 
table you need set enable_insert_strict = false. I tested using your table and 
everything is fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](coverage): refresh the coverage file before exiting the program [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28354:
URL: https://github.com/apache/doris/pull/28354#issuecomment-1859773191

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 33994021bc5e37b0d0b4b2b0633eb88499325f9c, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4690446144994461
   q2   362 151 160 151
   q3   1468129612501250
   q4   1114923 958 923
   q5   3168312031923120
   q6   241 127 124 124
   q7   990 478 472 472
   q8   2231222822112211
   q9   6695673266836683
   q10  3243326932843269
   q11  315 207 200 200
   q12  355 215 203 203
   q13  4560384837643764
   q14  242 212 213 212
   q15  575 533 523 523
   q16  440 378 388 378
   q17  1021643 583 583
   q18  7197682869176828
   q19  1539146414121412
   q20  545 290 309 290
   q21  3095266726672667
   q22  351 283 280 280
   Total cold run time: 44437 ms
   Total hot run time: 40004 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4400437943894379
   q2   272 167 173 167
   q3   3527354135243524
   q4   2391237123812371
   q5   5740571657165716
   q6   241 121 120 120
   q7   2393189818581858
   q8   3524352935513529
   q9   9063899289468946
   q10  3891400439863986
   q11  511 381 401 381
   q12  765 595 599 595
   q13  4269358735863586
   q14  287 249 246 246
   q15  579 525 523 523
   q16  501 462 443 443
   q17  1905186118451845
   q18  8671828583328285
   q19  1749174817431743
   q20  2260195519471947
   q21  6558620961906190
   q22  504 413 423 413
   Total cold run time: 64001 ms
   Total hot run time: 60793 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](coverage): refresh the coverage file before exiting the program [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28354:
URL: https://github.com/apache/doris/pull/28354#issuecomment-1859777406

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.58 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.8 seconds inserted 1000 Rows, about 
347K ops/s
storage size: 17219699189 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Nereids): remove SemiJoinCommute in rewriter [doris]

2023-12-18 Thread via GitHub


jackwener commented on PR #28563:
URL: https://github.com/apache/doris/pull/28563#issuecomment-1859779241

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859790169

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit ea8fe2223614cdf56723fc2405e1cf6b1df3d39f, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4666448644584458
   q2   360 152 158 152
   q3   1465126812511251
   q4   1121889 909 889
   q5   3139316231293129
   q6   249 126 128 126
   q7   1002487 488 487
   q8   2203223521922192
   q9   6707669467006694
   q10  3231327932783278
   q11  329 200 202 200
   q12  352 208 203 203
   q13  4595379738273797
   q14  237 203 207 203
   q15  556 521 519 519
   q16  444 380 381 380
   q17  1018675 510 510
   q18  7229701269306930
   q19  1554147613691369
   q20  544 317 300 300
   q21  3079267826932678
   q22  350 282 290 282
   Total cold run time: 44430 ms
   Total hot run time: 40027 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4400447844044404
   q2   268 164 173 164
   q3   3541351035133510
   q4   2390237223662366
   q5   5748572157415721
   q6   238 120 124 120
   q7   2384184818571848
   q8   3523354635333533
   q9   9013897389898973
   q10  3900399539973995
   q11  500 385 396 385
   q12  763 595 612 595
   q13  4320355235623552
   q14  290 260 252 252
   q15  568 516 523 516
   q16  500 461 463 461
   q17  1884182918591829
   q18  8568832283518322
   q19  1732177817541754
   q20  2271195219381938
   q21  6550621461716171
   q22  510 422 434 422
   Total cold run time: 63861 ms
   Total hot run time: 60831 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated: [fix](Nereids) explain should fallback too if Nereids is not enable (#28475)

2023-12-18 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new b50bc0d2c90 [fix](Nereids) explain should fallback too if Nereids is 
not enable (#28475)
b50bc0d2c90 is described below

commit b50bc0d2c902856f6727c5301d256ca6a561f8a3
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Mon Dec 18 16:44:10 2023 +0800

[fix](Nereids) explain should fallback too if Nereids is not enable (#28475)
---
 .../plans/commands/BatchInsertIntoTableCommand.java|  8 
 .../trees/plans/commands/DeleteFromUsingCommand.java   | 10 +-
 .../trees/plans/commands/InsertIntoTableCommand.java   |  8 
 .../plans/commands/InsertOverwriteTableCommand.java|  8 
 .../nereids/trees/plans/commands/UpdateCommand.java| 18 ++
 .../doris/nereids/trees/plans/UpdateCommandTest.java   |  9 -
 6 files changed, 51 insertions(+), 10 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/BatchInsertIntoTableCommand.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/BatchInsertIntoTableCommand.java
index 0e2b6540300..87ab7f73426 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/BatchInsertIntoTableCommand.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/BatchInsertIntoTableCommand.java
@@ -69,6 +69,14 @@ public class BatchInsertIntoTableCommand extends Command 
implements ForwardWithS
 
 @Override
 public Plan getExplainPlan(ConnectContext ctx) throws Exception {
+if (!ctx.getSessionVariable().isEnableNereidsDML()) {
+try {
+ctx.getSessionVariable().enableFallbackToOriginalPlannerOnce();
+} catch (Exception e) {
+throw new AnalysisException("failed to set fallback to 
original planner to true", e);
+}
+throw new AnalysisException("Nereids DML is disabled, will try to 
fall back to the original planner");
+}
 return InsertExecutor.normalizePlan(this.logicalQuery, 
InsertExecutor.getTargetTable(this.logicalQuery, ctx));
 }
 
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromUsingCommand.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromUsingCommand.java
index 8fadeb3b14d..3022578ed60 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromUsingCommand.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromUsingCommand.java
@@ -19,9 +19,9 @@ package org.apache.doris.nereids.trees.plans.commands;
 
 import org.apache.doris.catalog.Column;
 import org.apache.doris.catalog.OlapTable;
-import org.apache.doris.common.AnalysisException;
 import org.apache.doris.nereids.analyzer.UnboundSlot;
 import org.apache.doris.nereids.analyzer.UnboundTableSink;
+import org.apache.doris.nereids.exceptions.AnalysisException;
 import org.apache.doris.nereids.trees.expressions.Alias;
 import org.apache.doris.nereids.trees.expressions.NamedExpression;
 import org.apache.doris.nereids.trees.expressions.literal.TinyIntLiteral;
@@ -123,6 +123,14 @@ public class DeleteFromUsingCommand extends Command 
implements ForwardWithSync,
 
 @Override
 public Plan getExplainPlan(ConnectContext ctx) {
+if (!ctx.getSessionVariable().isEnableNereidsDML()) {
+try {
+ctx.getSessionVariable().enableFallbackToOriginalPlannerOnce();
+} catch (Exception e) {
+throw new AnalysisException("failed to set fallback to 
original planner to true", e);
+}
+throw new AnalysisException("Nereids DML is disabled, will try to 
fall back to the original planner");
+}
 return completeQueryPlan(ctx, logicalQuery);
 }
 
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java
index eaee75936d3..a8dd89f5a93 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java
@@ -232,6 +232,14 @@ public class InsertIntoTableCommand extends Command 
implements ForwardWithSync,
 
 @Override
 public Plan getExplainPlan(ConnectContext ctx) {
+if (!ctx.getSessionVariable().isEnableNereidsDML()) {
+try {
+ctx.getSessionVariable().enableFallbackToOriginalPlannerOnce();
+} catch (Exception e) {
+throw new AnalysisException("failed to set fallba

Re: [PR] [fix](compaction) time series compaction policy -> compact consecutive empty rowsets [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #27299:
URL: https://github.com/apache/doris/pull/27299#issuecomment-1859815063

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit c6725851097de19ed9f11cae7e44023013e7ea61, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4695447744684468
   q2   360 154 158 154
   q3   1474126512611261
   q4   1124936 920 920
   q5   3150318131593159
   q6   244 130 125 125
   q7   977 487 490 487
   q8   2260222322102210
   q9   6719668867076688
   q10  3214328032523252
   q11  333 193 201 193
   q12  357 214 204 204
   q13  4563379637783778
   q14  240 219 218 218
   q15  567 526 521 521
   q16  440 382 377 377
   q17  1027636 550 550
   q18  7110703070187018
   q19  1558142514461425
   q20  548 314 293 293
   q21  3066263526572635
   q22  346 279 278 278
   Total cold run time: 44372 ms
   Total hot run time: 40214 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4389439943904390
   q2   275 165 168 165
   q3   3528354235313531
   q4   2383237023682368
   q5   5773572757355727
   q6   243 122 123 122
   q7   2408185619051856
   q8   3534353035333530
   q9   9073905489998999
   q10  3907400139893989
   q11  506 382 398 382
   q12  778 595 606 595
   q13  4279359435523552
   q14  286 250 260 250
   q15  579 530 522 522
   q16  493 438 462 438
   q17  1887184318471843
   q18  8686812683778126
   q19  1727174517681745
   q20  2264195219431943
   q21  6527620561726172
   q22  500 415 410 410
   Total cold run time: 64025 ms
   Total hot run time: 60655 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Error while running github feature from .asf.yaml in doris!

2023-12-18 Thread Apache Infrastructure


An error occurred while running github feature in .asf.yaml!:
You can only have a maximum of 10 external triage collaborators, please contact 
vp-in...@apache.org to request an exception.


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) explain should fallback too if Nereids dml is not enable [doris]

2023-12-18 Thread via GitHub


morrySnow merged PR #28475:
URL: https://github.com/apache/doris/pull/28475


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859823186

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.83 seconds
stream load tsv:  575 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17219935590 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feat](Nereids) add distribute hint to leading hint [doris]

2023-12-18 Thread via GitHub


LiBinfeng-01 commented on PR #28562:
URL: https://github.com/apache/doris/pull/28562#issuecomment-1859821854

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859823934

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit bf3c2297f19b695265f4e8b8569a903120ac, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4696443844574438
   q2   362 153 158 153
   q3   1462126212381238
   q4   1122939 925 925
   q5   3142312431543124
   q6   255 132 129 129
   q7   984 485 487 485
   q8   2204219921782178
   q9   6670667666486648
   q10  3243325932883259
   q11  329 192 193 192
   q12  348 208 205 205
   q13  4566379238113792
   q14  244 220 215 215
   q15  569 532 529 529
   q16  440 379 381 379
   q17  997 681 564 564
   q18  7239681769566817
   q19  1520146613751375
   q20  550 328 279 279
   q21  3073263427212634
   q22  351 273 277 273
   Total cold run time: 44366 ms
   Total hot run time: 39831 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4364433943864339
   q2   262 163 173 163
   q3   3543353535133513
   q4   2386236923642364
   q5   5736573757175717
   q6   243 119 125 119
   q7   2375188218701870
   q8   3523352335113511
   q9   9069902189698969
   q10  3899399839713971
   q11  498 394 382 382
   q12  769 592 586 586
   q13  4312360335813581
   q14  294 254 256 254
   q15  580 520 530 520
   q16  520 447 488 447
   q17  1869182218321822
   q18  8839812583028125
   q19  1710173717281728
   q20  2257194719341934
   q21  6489616161446144
   q22  489 431 420 420
   Total cold run time: 64026 ms
   Total hot run time: 60479 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](cases) Set analyze_timeout in global [doris]

2023-12-18 Thread via GitHub


morrySnow closed pull request #26974: [fix](cases) Set analyze_timeout in global
URL: https://github.com/apache/doris/pull/26974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](stats) Fix auto sample [doris]

2023-12-18 Thread via GitHub


morrySnow closed pull request #26184: [fix](stats) Fix auto sample
URL: https://github.com/apache/doris/pull/26184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat](stats) Prioritize critical column for auto analyze [doris]

2023-12-18 Thread via GitHub


morrySnow closed pull request #27811: [feat](stats) Prioritize critical column 
for auto analyze
URL: https://github.com/apache/doris/pull/27811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


bobhan1 commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859830192

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bug](schema change)fix schema change cause load failed due to err -215 [doris]

2023-12-18 Thread via GitHub


DarvenDuan commented on PR #23836:
URL: https://github.com/apache/doris/pull/23836#issuecomment-1859831155

   run compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feat](Nereids) add join hints [doris]

2023-12-18 Thread via GitHub


LiBinfeng-01 commented on PR #27819:
URL: https://github.com/apache/doris/pull/27819#issuecomment-1859832572

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](compaction) time series compaction policy -> compact consecutive empty rowsets [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #27299:
URL: https://github.com/apache/doris/pull/27299#issuecomment-1859833556

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.96 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.5 seconds inserted 1000 Rows, about 
350K ops/s
storage size: 17218526320 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refine](runtimefilter) do not use QueryContext in runtime filter [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28559:
URL: https://github.com/apache/doris/pull/28559#issuecomment-1859834491

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.95 seconds
stream load tsv:  595 seconds loaded 74807831229 Bytes, about 119 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17221199326 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](cooldown) Fix problem that followers may never completely cooldown [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28561:
URL: https://github.com/apache/doris/pull/28561#issuecomment-1859835029

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 44edc6b8668611da93f1b37051b1de31be20ce07, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4698447044984470
   q2   376 137 159 137
   q3   1465125112511251
   q4   1124916 873 873
   q5   3179316331553155
   q6   244 130 129 129
   q7   1001486 473 473
   q8   2204223622132213
   q9   6687669367016693
   q10  3251325032823250
   q11  332 199 197 197
   q12  349 214 203 203
   q13  4543379837933793
   q14  241 214 212 212
   q15  559 526 519 519
   q16  447 385 391 385
   q17  1011625 516 516
   q18  7157701670067006
   q19  1533140913901390
   q20  515 286 324 286
   q21  3081264126482641
   q22  345 280 284 280
   Total cold run time: 44342 ms
   Total hot run time: 40072 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4397462244094409
   q2   269 160 172 160
   q3   3549354535203520
   q4   2383239523852385
   q5   5743573357435733
   q6   239 121 120 120
   q7   2385185418601854
   q8   3539355335333533
   q9   9073898190448981
   q10  3929400239913991
   q11  510 392 404 392
   q12  774 626 603 603
   q13  4295357535573557
   q14  286 248 256 248
   q15  571 517 522 517
   q16  510 434 461 434
   q17  1887183718531837
   q18  8682811882398118
   q19  1732177717431743
   q20  2277195519311931
   q21  6523621061956195
   q22  495 461 417 417
   Total cold run time: 64048 ms
   Total hot run time: 60678 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859836459

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.98 seconds
stream load tsv:  575 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17219842626 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](cooldown) Fix problem that followers may never completely cooldown [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28561:
URL: https://github.com/apache/doris/pull/28561#issuecomment-1859836691

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.12 seconds
stream load tsv:  575 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.2 seconds inserted 1000 Rows, about 
354K ops/s
storage size: 17221015039 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when cehcking broken tablet [doris]

2023-12-18 Thread via GitHub


TangSiyang2001 commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859835824

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when cehcking broken tablet [doris]

2023-12-18 Thread via GitHub


TangSiyang2001 commented on code in PR #28552:
URL: https://github.com/apache/doris/pull/28552#discussion_r1429726218


##
be/src/runtime/tablets_channel.cpp:
##
@@ -589,9 +573,30 @@ void BaseTabletsChannel::_add_broken_tablet(int64_t 
tablet_id) {
 _broken_tablets.insert(tablet_id);
 }
 
-bool BaseTabletsChannel::_is_broken_tablet(int64_t tablet_id) {
+void BaseTabletsChannel::_build_tablet_to_rowidxs(

Review Comment:
   nope, class member used in BaseTabletsChannel::_build_tablet_to_rowidxs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859840080

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](planner) choice wrong length of string type output of union [doris]

2023-12-18 Thread via GitHub


morrySnow commented on PR #28514:
URL: https://github.com/apache/doris/pull/28514#issuecomment-1859844362

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859845959

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit bfaf47d2d8d5afd2139a72fa8158f34d4871a719, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4731446844604460
   q2   368 152 158 152
   q3   1484127012421242
   q4   1123904 880 880
   q5   3124317431833174
   q6   244 127 130 127
   q7   979 490 493 490
   q8   2195222321942194
   q9   67226681
   q10  3233325532743255
   q11  320 207 212 207
   q12  351 211 209 209
   q13  4541380738093807
   q14  240 207 219 207
   q15  565 523 527 523
   q16  443 378 385 378
   q17  1025569 460 460
   q18  7161698469186918
   q19  1511144613731373
   q20  554 320 283 283
   q21  3073264327312643
   q22  348 287 282 282
   Total cold run time: 44335 ms
   Total hot run time: 39930 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4413439243714371
   q2   269 160 172 160
   q3   3561353235233523
   q4   2392238123752375
   q5   5735574557545745
   q6   244 121 125 121
   q7   2413186518581858
   q8   3537351335233513
   q9   9041906790049004
   q10  3887398040053980
   q11  512 392 379 379
   q12  758 611 592 592
   q13  4302358535433543
   q14  292 260 248 248
   q15  565 517 515 515
   q16  501 473 471 471
   q17  1888186418801864
   q18  8666819082898190
   q19  1717178217831782
   q20  2269196619341934
   q21  6545621861666166
   q22  484 442 424 424
   Total cold run time: 63991 ms
   Total hot run time: 60758 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when checking broken tablets [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859847125

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


wsjz commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859853077

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #27943:
URL: https://github.com/apache/doris/pull/27943#issuecomment-1859856812

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit b5499dbb02b0f59fc2a6e8dd50daf3666c385542, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4735443444834434
   q2   364 146 162 146
   q3   1446127512431243
   q4   1108941 906 906
   q5   3133312531463125
   q6   246 130 129 129
   q7   980 484 481 481
   q8   2224221221992199
   q9   6707663766416637
   q10  3240325532593255
   q11  316 211 207 207
   q12  358 217 209 209
   q13  4566381737803780
   q14  235 213 215 213
   q15  571 522 516 516
   q16  440 384 384 384
   q17  1023658 604 604
   q18  7196703968976897
   q19  1538141614121412
   q20  508 310 291 291
   q21  3061266226742662
   q22  345 281 287 281
   Total cold run time: 44340 ms
   Total hot run time: 40011 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4371440043784378
   q2   269 160 173 160
   q3   3540351935193519
   q4   2383237523672367
   q5   5739571057345710
   q6   241 121 123 121
   q7   2374185418641854
   q8   3536353635343534
   q9   9039900789838983
   q10  3877397939823979
   q11  503 396 394 394
   q12  768 592 600 592
   q13  4240355135643551
   q14  273 256 250 250
   q15  571 520 523 520
   q16  518 476 485 476
   q17  1870186118511851
   q18  8627812082638120
   q19  1736174417591744
   q20  2260194119421941
   q21  6524616961786169
   q22  486 420 442 420
   Total cold run time: 63745 ms
   Total hot run time: 60633 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #27943:
URL: https://github.com/apache/doris/pull/27943#issuecomment-1859862968

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.95 seconds
stream load tsv:  580 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.2 seconds inserted 1000 Rows, about 
354K ops/s
storage size: 17222620647 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] Can not insert data after enabling the partial column updates [doris]

2023-12-18 Thread via GitHub


bobhan1 commented on issue #28553:
URL: https://github.com/apache/doris/issues/28553#issuecomment-1859865862

   It seems that columns in the insert statement covers all the columns in the 
table, so you don't need to set `enable_unique_key_partial_update` to `true`. 
The upsert semantic of MOW unique table can satisfy your requirements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Nereids): remove SemiJoinCommute in rewriter [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28563:
URL: https://github.com/apache/doris/pull/28563#issuecomment-1859866753

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit eab8da3b5df063021e7a9efb60cfeaaba0a71b85, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4734443744814437
   q2   367 147 160 147
   q3   1470124512281228
   q4   1131944 917 917
   q5   3157312731623127
   q6   253 130 130 130
   q7   994 494 496 494
   q8   2212222821912191
   q9   6707667766916677
   q10  3220329032653265
   q11  322 201 194 194
   q12  359 218 211 211
   q13  4525380738223807
   q14  249 211 210 210
   q15  566 525 530 525
   q16  441 398 393 393
   q17  1003571 502 502
   q18  7193703668566856
   q19  1540144514251425
   q20  545 313 298 298
   q21  3089265726772657
   q22  346 279 282 279
   Total cold run time: 44423 ms
   Total hot run time: 39970 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4407441443964396
   q2   270 165 173 165
   q3   3529352335133513
   q4   2384236923672367
   q5   5735570557225705
   q6   243 122 123 122
   q7   2371187618451845
   q8   3513352535553525
   q9   9035900189928992
   q10  3910398339923983
   q11  504 371 390 371
   q12  758 598 604 598
   q13  4283354235633542
   q14  284 243 262 243
   q15  570 528 525 525
   q16  499 440 458 440
   q17  1894186418621862
   q18  8684830983048304
   q19  1738177717551755
   q20  2244194119231923
   q21  6559621262046204
   q22  501 418 438 418
   Total cold run time: 63915 ms
   Total hot run time: 60798 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


wangbo commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429751855


##
fe/fe-core/src/main/java/org/apache/doris/common/publish/WorkloadMoveActionPublisherThread.java:
##
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.publish;
+
+import org.apache.doris.common.ClientPool;
+import org.apache.doris.common.ThreadPoolManager;
+import org.apache.doris.common.util.Daemon;
+import org.apache.doris.system.Backend;
+import org.apache.doris.system.SystemInfoService;
+import org.apache.doris.thrift.BackendService;
+import org.apache.doris.thrift.TNetworkAddress;
+import org.apache.doris.thrift.TPublishTopicRequest;
+import org.apache.doris.thrift.TTopicInfoType;
+import org.apache.doris.thrift.TWorkloadMoveQueryToGroupAction;
+import org.apache.doris.thrift.TopicInfo;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.concurrent.ExecutorService;
+
+public class WorkloadMoveActionPublisherThread extends Daemon {

Review Comment:
   那就所有action一个线程呗



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Nereids): remove SemiJoinCommute in rewriter [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28563:
URL: https://github.com/apache/doris/pull/28563#issuecomment-1859868195

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.94 seconds
stream load tsv:  577 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  27.8 seconds inserted 1000 Rows, about 
359K ops/s
storage size: 17219660750 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature][execturo]support query schedule policy [doris]

2023-12-18 Thread via GitHub


wangbo commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1429753869


##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicyMgr.java:
##
@@ -0,0 +1,509 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+import org.apache.doris.analysis.AlterWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.CreateWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.DropWorkloadSchedPolicyStmt;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.common.proc.BaseProcResult;
+import org.apache.doris.common.proc.ProcResult;
+import org.apache.doris.common.util.DebugUtil;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.persist.gson.GsonPostProcessable;
+import org.apache.doris.persist.gson.GsonUtils;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.service.ExecuteEnv;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Maps;
+import com.google.gson.annotations.SerializedName;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+public class WorkloadSchedPolicyMgr implements Writable, GsonPostProcessable {
+
+private static final Logger LOG = 
LogManager.getLogger(WorkloadSchedPolicyMgr.class);
+
+@SerializedName(value = "idToPolicy")
+private Map idToPolicy = 
Maps.newConcurrentMap();
+private Map nameToPolicy = Maps.newHashMap();
+
+private PolicyProcNode policyProcNode = new PolicyProcNode();
+
+public static final ImmutableList 
WORKLOAD_SCHED_POLICY_NODE_TITLE_NAMES
+= new ImmutableList.Builder()
+.add("Id").add("Name").add("ItemName").add("ItemValue")
+.build();
+
+private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
+
+public static Comparator policyComparator = new 
Comparator() {
+@Override
+public int compare(WorkloadSchedPolicy p1, WorkloadSchedPolicy p2) {
+return p2.getPriority() - p1.getPriority();
+}
+};
+
+private Thread policyExecThread = new Thread() {
+@Override
+public void run() {
+while (true) {
+try {
+// 1 get query info map
+Map connectMap = 
ExecuteEnv.getInstance().getScheduler()
+.getConnectionMap();
+List queryInfoList = new ArrayList<>();
+
+// a snapshot for connect context
+Set keySet = new HashSet<>();
+keySet.addAll(connectMap.keySet());
+
+for (Integer connectId : keySet) {
+ConnectContext cctx = connectMap.get(connectId);
+if (cctx == null) {
+continue;
+}
+
+String username = cctx.getQualifiedUser();
+long queryTime = System.currentTimeMillis() - 
cctx.getStartTime();
+
+WorkloadQueryInfo policyQueryInfo = new 
WorkloadQueryInfo();
+policyQueryInfo.queryId = 
DebugUtil.printId(cctx.queryId());
+policyQueryInfo.tUniqueId = cctx.queryId();
+policyQueryInfo.context = cctx;
+policyQueryInfo.metricMap = new HashMap<>();
+
policyQueryInfo.metricMap.put(WorkloadMetricType.usernam

Re: [PR] [FIX](explode) fix explode with array has specific precision at old planner [doris]

2023-12-18 Thread via GitHub


gavinchou commented on PR #28491:
URL: https://github.com/apache/doris/pull/28491#issuecomment-1859873291

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feat](Nereids) add distribute hint to leading hint [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28562:
URL: https://github.com/apache/doris/pull/28562#issuecomment-1859873843

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.72 seconds
stream load tsv:  576 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.2 seconds inserted 1000 Rows, about 
354K ops/s
storage size: 17222719878 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [FIX](explode) fix explode with array has specific precision at old planner [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28491:
URL: https://github.com/apache/doris/pull/28491#issuecomment-1859875176

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feat](Nereids) add distribute hint to leading hint [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28562:
URL: https://github.com/apache/doris/pull/28562#issuecomment-1859876852

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 83628b8999b5737ff966b42c3f0e2552ee6f5699, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4761448244544454
   q2   361 154 153 153
   q3   1463127311761176
   q4   923 928 923
   q5   3140313131563131
   q6   247 130 131 130
   q7   990 495 479 479
   q8   2215219221662166
   q9   6691668166796679
   q10  3245327532803275
   q11  330 196 206 196
   q12  354 217 207 207
   q13  4579381338083808
   q14  239 219 215 215
   q15  573 528 519 519
   q16  436 383 380 380
   q17  1010554 484 484
   q18  7114698869436943
   q19  1538142514191419
   q20  514 317 308 308
   q21  3078262826832628
   q22  348 281 283 281
   Total cold run time: 44337 ms
   Total hot run time: 39954 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4429438443984384
   q2   264 161 167 161
   q3   3526351735193517
   q4   2380237023602360
   q5   5712573257255725
   q6   241 122 123 122
   q7   2382184318411841
   q8   3516351535183515
   q9   8997893989288928
   q10  3914398940003989
   q11  498 394 383 383
   q12  757 588 603 588
   q13  4289357135553555
   q14  280 261 261 261
   q15  565 517 518 517
   q16  502 450 453 450
   q17  1873184218231823
   q18  8568823383328233
   q19  1764175617781756
   q20  2245193019541930
   q21  6536618661596159
   q22  494 433 430 430
   Total cold run time: 63732 ms
   Total hot run time: 60627 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](regresson) fix vcompound constant column regression case [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28560:
URL: https://github.com/apache/doris/pull/28560#issuecomment-1859884964

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](regresson) fix vcompound constant column regression case [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28560:
URL: https://github.com/apache/doris/pull/28560#issuecomment-1859885092

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859886698

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.26 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.9 seconds inserted 1000 Rows, about 
346K ops/s
storage size: 17220950616 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when checking broken tablets [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859903701

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.84 seconds
stream load tsv:  572 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.7 seconds inserted 1000 Rows, about 
348K ops/s
storage size: 17224286988 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](planner) allow `HLL` and `QUANTILE_STATE` types on duplicate and unique table [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28546:
URL: https://github.com/apache/doris/pull/28546#issuecomment-1859907418

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 4a696edb9291e916698ef9621d0fab46ea6afdf0, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4724443944284428
   q2   370 137 139 137
   q3   1441118312371183
   q4   1119871 889 871
   q5   3136314831233123
   q6   245 128 126 126
   q7   981 491 499 491
   q8   2150225821762176
   q9   6691670966876687
   q10  3199326932513251
   q11  317 213 198 198
   q12  350 200 214 200
   q13  4578382538253825
   q14  243 208 212 208
   q15  569 526 527 526
   q16  440 383 379 379
   q17  1007625 515 515
   q18  7164692769326927
   q19  1533143114181418
   q20  548 299 292 292
   q21  3066265426872654
   q22  346 280 282 280
   Total cold run time: 44217 ms
   Total hot run time: 39895 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4412439643934393
   q2   266 162 180 162
   q3   3534352835193519
   q4   2459237023552355
   q5   5734571657385716
   q6   242 118 120 118
   q7   2371184618621846
   q8   3520351535233515
   q9   8983896389498949
   q10  3915400540084005
   q11  508 382 384 382
   q12  768 622 602 602
   q13  4296357235633563
   q14  294 249 247 247
   q15  575 516 518 516
   q16  504 447 453 447
   q17  1870185618461846
   q18  8636838383038303
   q19  1731175117331733
   q20  2263195119331933
   q21  6512618661636163
   q22  508 411 418 411
   Total cold run time: 63901 ms
   Total hot run time: 60724 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](planner) choice wrong length of string type output of union [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28514:
URL: https://github.com/apache/doris/pull/28514#issuecomment-1859934394

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.2 seconds
stream load tsv:  578 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.5 seconds inserted 1000 Rows, about 
350K ops/s
storage size: 17221802859 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when checking broken tablets [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859942038

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 20f73b7364f8ac6a41acf4118444a3fd55ca473f, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4715443144974431
   q2   359 155 156 155
   q3   1447132712201220
   q4   1119927 962 927
   q5   3175317631343134
   q6   248 128 128 128
   q7   996 496 484 484
   q8   2239222421872187
   q9   6701668166806680
   q10  3216325132623251
   q11  318 201 197 197
   q12  346 207 204 204
   q13  4595379137733773
   q14  241 211 211 211
   q15  574 526 531 526
   q16  430 387 381 381
   q17  1028666 597 597
   q18  7131692169136913
   q19  1543144613651365
   q20  513 313 298 298
   q21  3085258927042589
   q22  347 279 279 279
   Total cold run time: 44366 ms
   Total hot run time: 39930 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4415439143974391
   q2   269 164 175 164
   q3   3536351735113511
   q4   2389236723592359
   q5   5713571457175714
   q6   243 120 120 120
   q7   2381186018731860
   q8   3541355735343534
   q9   9053902489588958
   q10  3927397840113978
   q11  492 391 382 382
   q12  763 591 587 587
   q13  4292356535483548
   q14  291 251 265 251
   q15  580 529 534 529
   q16  502 443 451 443
   q17  1873185918621859
   q18  8594816783428167
   q19  1766174117691741
   q20  2245194719331933
   q21  6524616061916160
   q22  508 437 420 420
   Total cold run time: 63897 ms
   Total hot run time: 60609 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[I] [Enhancement] unbalanced resouce overhead between several BEs when loading [doris]

2023-12-18 Thread via GitHub


TangSiyang2001 opened a new issue, #28564:
URL: https://github.com/apache/doris/issues/28564

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Description
   
   
![image](https://github.com/apache/doris/assets/82279870/5065055a-c0eb-4ff9-a632-fe3e3577f0a2)
   
   CPU
   
![image](https://github.com/apache/doris/assets/82279870/a72fa520-24c9-423c-a560-59cd98ee76b4)
 
   
![image](https://github.com/apache/doris/assets/82279870/44595c70-2835-4f16-ae16-841808ef10c2)
 
   
![image](https://github.com/apache/doris/assets/82279870/eb3c4fa3-82da-46d1-8b78-c7ad7126484a)
   
   Mem
   
![image](https://github.com/apache/doris/assets/82279870/0ded63db-e221-44f7-9fc4-59536059deb2)
 
   
![image](https://github.com/apache/doris/assets/82279870/c535883e-6aa2-4ce5-a3f2-f4719451bb7b)
 
   
![image](https://github.com/apache/doris/assets/82279870/64180717-94bb-4e57-8770-6ed20da91376)
   
   
   
   
   ### Solution
   
   Actually, the node the heavy resource overhead is suffering from the back 
pressure of the add batch RPC, due to the low responce from the target BE which 
is add batching.
   
   Finally, we found that the read lock for checking broken tablet (writers) 
maybe inreasonable and add to the overhead, making it very slow but with a very 
light behavior.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](function) make STRLEFT and STRRIGHT and SUBSTR function DEPEND_ON_ARGUMENT [doris]

2023-12-18 Thread via GitHub


koarz commented on PR #28352:
URL: https://github.com/apache/doris/pull/28352#issuecomment-1859942043

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28374:
URL: https://github.com/apache/doris/pull/28374#issuecomment-1859944470

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.02 seconds
stream load tsv:  575 seconds loaded 74807831229 Bytes, about 124 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  33 seconds loaded 861443392 Bytes, about 24 
MB/s
insert into select:  28.3 seconds inserted 1000 Rows, about 
353K ops/s
storage size: 17219968583 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] Can not insert data after enabling the partial column updates [doris]

2023-12-18 Thread via GitHub


bingwill commented on issue #28553:
URL: https://github.com/apache/doris/issues/28553#issuecomment-1859947111

   > It seems that columns in the insert statement covers all the columns in 
the table, so you don't need to set `enable_unique_key_partial_update` to 
`true`. The upsert semantic of MOW unique table can satisfy your requirements.
   
   Do not cover all the columns this time,and error occurs still.
   
![problem_still](https://github.com/apache/doris/assets/150641822/9afdc9eb-49bd-4398-8d8d-4e419f3f007d)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](function) make STRLEFT and STRRIGHT and SUBSTR function DEPEND_ON_ARGUMENT [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28352:
URL: https://github.com/apache/doris/pull/28352#issuecomment-1859949459

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Nereids) found rows support [doris]

2023-12-18 Thread via GitHub


xzj7019 commented on PR #28372:
URL: https://github.com/apache/doris/pull/28372#issuecomment-1859952864

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](planner) choice wrong length of string type output of union [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28514:
URL: https://github.com/apache/doris/pull/28514#issuecomment-1859952511

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 73b2052fb140e83b64f3b5b46938d3baac229011, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4693444944414441
   q2   358 153 159 153
   q3   1460122612381226
   q4   1123887 860 860
   q5   3197316631593159
   q6   247 127 125 125
   q7   981 487 495 487
   q8   2213221822012201
   q9   6667667266516651
   q10  3203326732643264
   q11  325 192 191 191
   q12  347 214 201 201
   q13  4539380437763776
   q14  235 211 213 211
   q15  572 526 516 516
   q16  438 384 386 384
   q17  1014642 601 601
   q18  7239697970306979
   q19  1542142414521424
   q20  504 335 304 304
   q21  3038267426972674
   q22  346 272 278 272
   Total cold run time: 44281 ms
   Total hot run time: 40100 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4380434144154341
   q2   271 166 178 166
   q3   3532353135203520
   q4   2386238423722372
   q5   5732571557195715
   q6   241 121 119 119
   q7   2358189318901890
   q8   3522352535293525
   q9   9044894289428942
   q10  3919400239623962
   q11  501 404 365 365
   q12  768 595 605 595
   q13  4282354435533544
   q14  291 260 250 250
   q15  578 520 520 520
   q16  517 446 451 446
   q17  1879183418431834
   q18  8648821883158218
   q19  1739173517721735
   q20  2262193619201920
   q21  6551618061606160
   q22  502 427 425 425
   Total cold run time: 63903 ms
   Total hot run time: 60564 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859955145

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.64 seconds
stream load tsv:  579 seconds loaded 74807831229 Bytes, about 123 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  28.6 seconds inserted 1000 Rows, about 
349K ops/s
storage size: 17219926919 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [Enhance](regression)enhance jdbc case to adapt to use case concurrency [doris]

2023-12-18 Thread via GitHub


zhangguoqiang666 opened a new pull request, #28565:
URL: https://github.com/apache/doris/pull/28565

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   enhance jdbc case to adapt to use case concurrency
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when checking broken tablets [doris]

2023-12-18 Thread via GitHub


TangSiyang2001 commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859956468

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #28374:
URL: https://github.com/apache/doris/pull/28374#issuecomment-1859962834

   
   
   TPC-H test result on machine: 
'aliyun_ecs.c7a.8xlarge_32C64G'
   
   ```
   Tpch sf100 test result on commit 49900c0dbb6a93de45d36aaf42578ced64ba538a, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4698446344484448
   q2   359 146 142 142
   q3   1472125112441244
   q4   1119977 913 913
   q5   3146316631513151
   q6   242 126 131 126
   q7   978 499 481 481
   q8   2211223321992199
   q9   6701665166746651
   q10  3240326032693260
   q11  318 212 209 209
   q12  351 214 207 207
   q13  4559382138123812
   q14  240 214 211 211
   q15  568 521 528 521
   q16  443 396 378 378
   q17  1012647 493 493
   q18  7202696768916891
   q19  1556143014161416
   q20  551 328 307 307
   q21  3092263727082637
   q22  351 274 284 274
   Total cold run time: 44409 ms
   Total hot run time: 39971 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4419440643914391
   q2   267 165 167 165
   q3   3539353135123512
   q4   2386236923642364
   q5   5737572057285720
   q6   245 121 122 121
   q7   2383189718741874
   q8   3530352835283528
   q9   9041903789838983
   q10  3895398940153989
   q11  502 390 385 385
   q12  767 619 610 610
   q13  4292357635593559
   q14  281 256 271 256
   q15  574 524 518 518
   q16  507 453 453 453
   q17  1878185218461846
   q18  8690837982568256
   q19  1739174717351735
   q20  2255193119291929
   q21  6515621161746174
   q22  504 414 422 414
   Total cold run time: 63946 ms
   Total hot run time: 60782 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [feature](mtmv)create mtmv support refresh_partition_num [doris]

2023-12-18 Thread via GitHub


zddr opened a new pull request, #28566:
URL: https://github.com/apache/doris/pull/28566

   ## Proposed changes
   
   Issue Number: close #xxx
   
   - create/alter mtmv support refresh_partition_num
   - mtmv task according to refresh_partition_num executes refresh tasks in 
batches
   - `tasks` tvf add column `CompletedPartitions` and `progress`
   - fix mtmv can not `show temp partition` and `drop temp partition`
   - fix task can not get error msg when insert overwrite error
   - fix when the partition field is capitalized, the verification of creating 
a mtmv does not pass
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](mtmv)create mtmv support refresh_partition_num [doris]

2023-12-18 Thread via GitHub


zddr commented on PR #28566:
URL: https://github.com/apache/doris/pull/28566#issuecomment-1859964879

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](tablet-channel) enhance performance for load under multi-core scenario with a coarse-grained read lock when checking broken tablets [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28552:
URL: https://github.com/apache/doris/pull/28552#issuecomment-1859967478

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](testcase) fix p0 testcase rf_prune and explain_graph [doris]

2023-12-18 Thread via GitHub


github-actions[bot] commented on PR #28549:
URL: https://github.com/apache/doris/pull/28549#issuecomment-1859968117

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhance](regression)enhance jdbc case to adapt to use case concurrency [doris]

2023-12-18 Thread via GitHub


zhangguoqiang666 commented on PR #28565:
URL: https://github.com/apache/doris/pull/28565#issuecomment-1859975000

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-18 Thread via GitHub


doris-robot commented on PR #26356:
URL: https://github.com/apache/doris/pull/26356#issuecomment-1859975066

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 1a3e98ff0a58621903f0c6728327143ef13ada75, 
data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1   4704445545084455
   q2   368 148 159 148
   q3   1450123512791235
   q4   1112884 899 884
   q5   3131313631323132
   q6   243 125 127 125
   q7   998 483 487 483
   q8   2189223422032203
   q9   6691665766886657
   q10  3220327832573257
   q11  315 206 201 201
   q12  349 208 206 206
   q13  4555376237923762
   q14  247 217 208 208
   q15  565 520 522 520
   q16  438 381 379 379
   q17  1016607 537 537
   q18  7236687469336874
   q19  1530147913881388
   q20  546 311 319 311
   q21  3054267626832676
   q22  347 279 282 279
   Total cold run time: 44304 ms
   Total hot run time: 39920 ms
   
   run tpch-sf100 query with default conf and set session variable 
runtime_filter_mode=off
   q1   4431443243934393
   q2   264 164 170 164
   q3   3538352535253525
   q4   2379237123522352
   q5   5736572357345723
   q6   241 121 123 121
   q7   2384190318671867
   q8   3528352935233523
   q9   9005898989568956
   q10  3887399739973997
   q11  499 384 383 383
   q12  767 600 599 599
   q13  4281358635473547
   q14  280 258 245 245
   q15  567 522 517 517
   q16  499 442 467 442
   q17  1883185218461846
   q18  8636840883558355
   q19  1726180917941794
   q20  2267195219441944
   q21  6534620461796179
   q22  496 430 435 430
   Total cold run time: 63828 ms
   Total hot run time: 60902 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhance](regression)enhance jdbc case to adapt to use case concurrency [doris]

2023-12-18 Thread via GitHub


zhangguoqiang666 commented on PR #28565:
URL: https://github.com/apache/doris/pull/28565#issuecomment-1859975796

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](Nereids) compound predicate need cast children to boolean (#27649) [doris]

2023-12-18 Thread via GitHub


morrySnow opened a new pull request, #28567:
URL: https://github.com/apache/doris/pull/28567

   pick from master
   PR #27649
   commit f0dbce4cf58ec829734175e05bf2188c7158078d
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) compound predicate need cast children to boolean (#27649) [doris]

2023-12-18 Thread via GitHub


morrySnow commented on PR #28567:
URL: https://github.com/apache/doris/pull/28567#issuecomment-1859978468

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](test) disable join reorder in bucket shuffle join test (#27930) [doris]

2023-12-18 Thread via GitHub


morrySnow opened a new pull request, #28568:
URL: https://github.com/apache/doris/pull/28568

   pick from master
   PR #27930
   commit c80807a5c7f9454bd4ec8d5a2c829ed986efa653
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](test) disable join reorder in bucket shuffle join test (#27930) [doris]

2023-12-18 Thread via GitHub


morrySnow commented on PR #28568:
URL: https://github.com/apache/doris/pull/28568#issuecomment-1859982868

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) forbid two TVF in one fragment since the limit of coordinator (#28114) [doris]

2023-12-18 Thread via GitHub


morrySnow commented on PR #28569:
URL: https://github.com/apache/doris/pull/28569#issuecomment-1859988528

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](Nereids) forbid two TVF in one fragment since the limit of coordinator (#28114) [doris]

2023-12-18 Thread via GitHub


morrySnow opened a new pull request, #28569:
URL: https://github.com/apache/doris/pull/28569

   pick from master
   PR #28114 
   commit 65fc2e043871c426f5efe60d44ed528e2b5aeff3
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   6   7   8   9   >