yiguolei commented on code in PR #28443: URL: https://github.com/apache/doris/pull/28443#discussion_r1429637175
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadConditionQueryTime.java: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource.workloadschedpolicy; + +import org.apache.doris.common.UserException; + +public class WorkloadConditionQueryTime implements WorkloadCondition { + + private long value; + private WorkloadConditionOperator op; + + public WorkloadConditionQueryTime(WorkloadConditionOperator op, long value) { + this.op = op; + this.value = value; + } + + @Override + public boolean eval(String strValue) { + long inputLongValue = Long.parseLong(strValue); + return WorkloadConditionCompareUtils.compareInteger(op, inputLongValue, value); + } + + public static WorkloadConditionQueryTime createWorkloadCondition(WorkloadConditionOperator op, String value) + throws UserException { + long longValue = Long.parseLong(value); + if (longValue < 0) { + throw new UserException("invalid query time value, " + longValue + ", it requires >= 0"); + } + return new WorkloadConditionQueryTime(op, longValue); + } + + @Override + public WorkloadMetricType getMetricType() { + return WorkloadMetricType.query_time; Review Comment: java 里的枚举一般都是全部大写字母 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
