[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
LemonLiTree commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510807411 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] datayesJava2 commented on issue #17286: [Bug] 官网提供的Docker Compose script无法启动
datayesJava2 commented on issue #17286:
URL: https://github.com/apache/doris/issues/17286#issuecomment-1510809591
> 注意，fe/be的节点配置文件是以追加模式写入的（吐槽），需要手动清理
这个怎么清理，第一次启动成功了，后面再启动时就报java.net.ConnectException: Connection refused
(Connection refused)错误
`
```powershell
``` mysql> show proc '/backends' \G;
*** 1. row ***
BackendId: 13003
Cluster: default_cluster
IP: 172.20.80.3
HostName: doris-be.doris_doris_net
HeartbeatPort: 9050
BePort: -1
HttpPort: -1
BrpcPort: -1
LastStartTime: NULL
LastHeartbeat: NULL
Alive: false
SystemDecommissioned: false
ClusterDecommissioned: false
TabletNum: 0
DataUsedCapacity: 0.000
AvailCapacity: 1.000 B
TotalCapacity: 0.000
UsedPct: 0.00 %
MaxDiskUsedPct: 0.00 %
RemoteUsedCapacity: 0.000
Tag: {"location" : "default"}
ErrMsg: java.net.ConnectException: Connection refused
(Connection refused)
Version:
Status:
{"lastSuccessReportTabletsTime":"N/A","lastStreamLoadTime":-1,"isQueryDisabled":false,"isLoadDisabled":false}
HeartbeatFailureCounter: 1
NodeRole:
1 row in set (0.01 sec)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener merged pull request #18675: [fix](Nereids): fix sum func in eager agg
jackwener merged PR #18675: URL: https://github.com/apache/doris/pull/18675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (1e06763366 -> d61f52d277)
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 1e06763366 [fix](bitmap) fix bitmap_count errors to set nullable to non-nullable bitmap col (#18689) add d61f52d277 [fix](Nereids): fix sum func in eager agg (#18675) No new revisions were added by this update. Summary of changes: .../doris/nereids/rules/exploration/CBOUtils.java | 12 --- .../nereids/rules/exploration/EagerCount.java | 10 +++--- .../nereids/rules/exploration/EagerGroupBy.java| 2 +- .../rules/exploration/EagerGroupByCount.java | 8 ++--- .../nereids/rules/exploration/EagerSplit.java | 18 +- .../exploration/join/InnerJoinLAsscomProject.java | 2 +- .../join/InnerJoinLeftAssociateProject.java| 2 +- .../join/InnerJoinRightAssociateProject.java | 2 +- .../exploration/join/JoinExchangeBothProject.java | 3 +- .../exploration/join/JoinExchangeLeftProject.java | 2 +- .../exploration/join/JoinExchangeRightProject.java | 2 +- .../join/LogicalJoinSemiJoinTransposeProject.java | 4 +-- .../exploration/join/OuterJoinAssocProject.java| 2 +- .../exploration/join/OuterJoinLAsscomProject.java | 2 +- .../join/PushdownProjectThroughInnerJoin.java | 5 +-- .../join/PushdownProjectThroughSemiJoin.java | 5 +-- .../join/SemiJoinSemiJoinTransposeProject.java | 2 +- .../trees/plans/logical/LogicalProject.java| 4 +++ .../nereids/rules/exploration/EagerCountTest.java | 9 ++--- .../rules/exploration/EagerGroupByCountTest.java | 8 ++--- .../nereids/rules/exploration/EagerSplitTest.java | 12 +++ .../join/InnerJoinLAsscomProjectTest.java | 16 + .../join/JoinExchangeBothProjectTest.java | 24 +++--- .../join/JoinExchangeLeftProjectTest.java | 16 + .../join/JoinExchangeRightProjectTest.java | 24 -- .../join/OuterJoinLAsscomProjectTest.java | 38 -- 26 files changed, 120 insertions(+), 114 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #18731: (fix)[olap] not support in_memory=true now
nextdreamblue commented on PR #18731: URL: https://github.com/apache/doris/pull/18731#issuecomment-1510820770 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #18735: [chore](hashtable) Use doris' Allocator to replace std::allocator in phmap
mrhhsg commented on PR #18735: URL: https://github.com/apache/doris/pull/18735#issuecomment-1510832700 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18643: [improvement](merge-on-write) move segment check to delta writer
github-actions[bot] commented on PR #18643: URL: https://github.com/apache/doris/pull/18643#issuecomment-1510834469 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18643: [improvement](merge-on-write) move segment check to delta writer
github-actions[bot] commented on PR #18643: URL: https://github.com/apache/doris/pull/18643#issuecomment-1510834414 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18541: [Feature](aggregate) support generic aggregate functions on pre-aggregate model
github-actions[bot] commented on PR #18541: URL: https://github.com/apache/doris/pull/18541#issuecomment-1510837598 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #18669: [feature](Nereids): pullup semiJoin through aggregate.
jackwener commented on PR #18669: URL: https://github.com/apache/doris/pull/18669#issuecomment-1510841691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18731: (fix)[olap] not support in_memory=true now
hello-stephen commented on PR #18731: URL: https://github.com/apache/doris/pull/18731#issuecomment-1510848004 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 32.89 seconds stream load tsv: 435 seconds loaded 74807831229 Bytes, about 164 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417073259_clickbench_pr_129989.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liaoxin01 commented on pull request #18734: [fix](merge-on-write) enable_unique_key_merge_on_write property should only be used for unique table
liaoxin01 commented on PR #18734: URL: https://github.com/apache/doris/pull/18734#issuecomment-1510856338 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-thirdparty] adonis0147 merged pull request #50: [Enhancement](tokenizer) accelerate ascii tokenizer speed by simd to_lower function
adonis0147 merged PR #50: URL: https://github.com/apache/doris-thirdparty/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Lchangliang commented on pull request #18652: [improve] Refactor file cache and Improve the file cache strategy
Lchangliang commented on PR #18652: URL: https://github.com/apache/doris/pull/18652#issuecomment-1510857346 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18652: [improve] Refactor file cache and Improve the file cache strategy
github-actions[bot] commented on PR #18652: URL: https://github.com/apache/doris/pull/18652#issuecomment-1510857368 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Lchangliang commented on a diff in pull request #18652: [improve] Refactor file cache and Improve the file cache strategy
Lchangliang commented on code in PR #18652:
URL: https://github.com/apache/doris/pull/18652#discussion_r1168303270
##
be/src/olap/options.cpp:
##
@@ -174,45 +173,59 @@ Status parse_conf_cache_paths(const std::string&
config_path, std::vectorvalue.GetString();
-int64_t normal_size = map.HasMember(CACHE_NORMAL_SIZE.c_str())
- ?
map.FindMember(CACHE_NORMAL_SIZE.c_str())->value.GetInt64()
- : 0;
-int64_t persistent_size =
-map.HasMember(CACHE_PERSISTENT_SIZE.c_str())
-?
map.FindMember(CACHE_PERSISTENT_SIZE.c_str())->value.GetInt64()
-: 0;
-int64_t query_limit_bytes = 0;
+int64_t total_size = 0, query_limit_bytes = 0;
+if (map.HasMember(CACHE_TOTAL_SIZE.c_str())) {
+auto& value = map.FindMember(CACHE_TOTAL_SIZE.c_str())->value;
+if (value.IsInt64()) {
+total_size = value.GetInt64();
+} else {
+return Status::InvalidArgument("normal should be int64");
+}
+}
if (config::enable_file_cache_query_limit) {
-query_limit_bytes =
-map.HasMember(CACHE_QUERY_LIMIT_SIZE.c_str())
-?
map.FindMember(CACHE_QUERY_LIMIT_SIZE.c_str())->value.GetInt64()
-: normal_size / 5;
+if (map.HasMember(CACHE_QUERY_LIMIT_SIZE.c_str())) {
+auto& value =
map.FindMember(CACHE_QUERY_LIMIT_SIZE.c_str())->value;
+if (value.IsInt64()) {
+query_limit_bytes = value.GetInt64();
+} else {
+return Status::InvalidArgument("query_limit should be
int64");
+}
+}
}
-if (normal_size <= 0 || persistent_size <= 0) {
-LOG(WARNING) << "normal or persistent size should not less than or
equal to zero";
-return Status::InternalError("OLAP_ERR_INPUT_PARAMETER_ERROR");
+if (total_size <= 0 || (config::enable_file_cache_query_limit &&
query_limit_bytes <= 0)) {
+return Status::InvalidArgument(
+"total_size or query_limit should not less than or equal
to zero");
}
-paths.emplace_back(std::move(path), normal_size, persistent_size,
query_limit_bytes);
+paths.emplace_back(std::move(path), total_size, query_limit_bytes);
}
if (paths.empty()) {
-LOG(WARNING) << "fail to parse storage_root_path config. value=[" <<
config_path << "]";
-return Status::InternalError("OLAP_ERR_INPUT_PARAMETER_ERROR");
+return Status::InvalidArgument("fail to parse storage_root_path
config. value={}",
+ config_path);
}
return Status::OK();
}
io::FileCacheSettings CachePath::init_settings() const {
io::FileCacheSettings settings;
-settings.max_size = normal_bytes;
-settings.persistent_max_size = persistent_bytes;
+settings.total_size = total_bytes;
settings.max_file_segment_size = config::file_cache_max_file_segment_size;
-
-settings.max_elements = std::max(
-normal_bytes / config::file_cache_max_file_segment_size,
settings.max_elements);
-settings.persistent_max_elements =
-std::max(persistent_bytes /
config::file_cache_max_file_segment_size,
- settings.persistent_max_elements);
settings.max_query_cache_size = query_limit_bytes;
+size_t per_size = settings.total_size / io::percentage[3];
+settings.disposable_queue_size = per_size * io::percentage[1];
+settings.disposable_queue_elements =
Review Comment:
I will remove it in future optimizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris-thirdparty] branch clucene updated: [enhancement](tokenizer) Accelerate ascii tokenizer speed by SIMD to_lower function (#50)
This is an automated email from the ASF dual-hosted git repository.
adonisling pushed a commit to branch clucene
in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git
The following commit(s) were added to refs/heads/clucene by this push:
new b4e4f8f [enhancement](tokenizer) Accelerate ascii tokenizer speed by
SIMD to_lower function (#50)
b4e4f8f is described below
commit b4e4f8f4b8f3407057fa7061a83dbfa16071642b
Author: airborne12
AuthorDate: Mon Apr 17 15:41:32 2023 +0800
[enhancement](tokenizer) Accelerate ascii tokenizer speed by SIMD to_lower
function (#50)
---
src/core/CLucene/analysis/Analyzers.cpp | 46
src/core/CLucene/analysis/Analyzers.h | 6
src/core/CLucene/util/stringUtil.cpp| 1 +
src/core/CLucene/util/stringUtil.h | 53 -
src/test/analysis/TestAnalysis.cpp | 2 ++
5 files changed, 107 insertions(+), 1 deletion(-)
diff --git a/src/core/CLucene/analysis/Analyzers.cpp
b/src/core/CLucene/analysis/Analyzers.cpp
index 6ca4183..c5c9b6a 100644
--- a/src/core/CLucene/analysis/Analyzers.cpp
+++ b/src/core/CLucene/analysis/Analyzers.cpp
@@ -13,6 +13,52 @@
CL_NS_USE(util)
CL_NS_DEF(analysis)
+template<>
+void CharTokenizer::normalize(const char *src, int64_t len, char *dst) {
+to_lower((const uint8_t *) src, len, (uint8_t *) dst);
+}
+
+template<>
+Token *CharTokenizer::next(Token *token) {
+int32_t length = 0;
+int32_t start = offset;
+while (true) {
+char c;
+offset++;
+if (bufferIndex >= dataLen) {
+dataLen = input->read((const void **) &ioBuffer, 1,
LUCENE_IO_BUFFER_SIZE);
+if (dataLen == -1)
+dataLen = 0;
+bufferIndex = 0;
+}
+if (dataLen <= 0) {
+if (length > 0)
+break;
+else
+return NULL;
+} else
+c = ioBuffer[bufferIndex++];
+if (isTokenChar(c)) {// if it's a token TCHAR
+
+if (length == 0)// start of token
+start = offset - 1;
+
+//buffer[length++] = normalize(c); // buffer it,
normalized
+buffer[length++] = c;
+if (length == LUCENE_MAX_WORD_LEN)// buffer overflow!
+break;
+
+} else if (length > 0)// at non-Letter w/ chars
+break;// return 'em
+}
+char buffer_copy[LUCENE_MAX_WORD_LEN + 1];
+normalize(buffer, length, buffer_copy);
+buffer_copy[length] = 0;
+token->set(buffer_copy, start, start + length);
+
+return token;
+};
+
template
LetterTokenizer::LetterTokenizer(CL_NS(util)::Reader* in):
CharTokenizer(in) {
diff --git a/src/core/CLucene/analysis/Analyzers.h
b/src/core/CLucene/analysis/Analyzers.h
index fc65204..6ab819e 100644
--- a/src/core/CLucene/analysis/Analyzers.h
+++ b/src/core/CLucene/analysis/Analyzers.h
@@ -10,6 +10,7 @@
#include "CLucene/util/VoidList.h"
#include "CLucene/util/VoidMap.h"
#include "CLucene/util/CLStreams.h"
+#include "CLucene/util/stringUtil.h"
#include "AnalysisHeader.h"
CL_NS_DEF(analysis)
@@ -33,6 +34,11 @@ protected:
* to, e.g., lowercase tokens. */
virtual T normalize(const T c) const{return c;};
+virtual void normalize(const T *src, int64_t len, T *dst) {
+for (; src < src + len; ++src, ++dst)
+*dst = normalize(*src);
+};
+
public:
explicit CharTokenizer(CL_NS(util)::Reader* in):Tokenizer(in),
offset(0),
diff --git a/src/core/CLucene/util/stringUtil.cpp
b/src/core/CLucene/util/stringUtil.cpp
index 68437f5..07aa155 100644
--- a/src/core/CLucene/util/stringUtil.cpp
+++ b/src/core/CLucene/util/stringUtil.cpp
@@ -1,6 +1,7 @@
//
// Created by 姜凯 on 2022/9/20.
//
+#include "CLucene/_ApiHeader.h"
#include "stringUtil.h"
template <>
diff --git a/src/core/CLucene/util/stringUtil.h
b/src/core/CLucene/util/stringUtil.h
index eeddce7..f6a4958 100644
--- a/src/core/CLucene/util/stringUtil.h
+++ b/src/core/CLucene/util/stringUtil.h
@@ -5,7 +5,11 @@
#ifndef _lucene_util__stringutil_H
#define _lucene_util__stringutil_H
-#include "CLucene/_ApiHeader.h"
+#ifdef __SSE2__
+#include
+#elif __aarch64__
+#include
+#endif
template
const T* LUCENE_BLANK_SSTRING();
@@ -24,4 +28,51 @@ T *strDuplicate(const T *str);
template
size_t lenOfString(const T *str);
+
+template
+class LowerUpperImpl {
+public:
+static void transfer(const uint8_t* src, const uint8_t* src_end, uint8_t*
dst) {
+const auto flip_case_mask = 'A' ^ 'a';
+
+#if defined(__SSE2__) || defined(__aarch64__)
+const auto bytes_sse = sizeof(__m128i);
+const auto src_end_sse = src_end - (src_end - src) % bytes_sse;
+
+const auto v_not_case_lower_bound = _mm_set1_epi8(not_case_lower_bound
- 1);
+const auto v_not_case_upper_bound = _mm_set1_epi8(not_case_upper_bound
+ 1);
+const auto v_f
[GitHub] [doris-thirdparty] adonis0147 merged pull request #57: [test] add testcase for document add
adonis0147 merged PR #57: URL: https://github.com/apache/doris-thirdparty/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-thirdparty] branch clucene updated: [test] Add testcase for document add (#57)
This is an automated email from the ASF dual-hosted git repository.
adonisling pushed a commit to branch clucene
in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git
The following commit(s) were added to refs/heads/clucene by this push:
new 3f91661 [test] Add testcase for document add (#57)
3f91661 is described below
commit 3f91661ca51a3e0e2e32de196847f3fe2be53395
Author: airborne12
AuthorDate: Mon Apr 17 15:42:20 2023 +0800
[test] Add testcase for document add (#57)
---
src/test/document/TestDocument.cpp | 46 --
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/src/test/document/TestDocument.cpp
b/src/test/document/TestDocument.cpp
index b90f67d..93d52e8 100644
--- a/src/test/document/TestDocument.cpp
+++ b/src/test/document/TestDocument.cpp
@@ -407,23 +407,55 @@ void TestSetFieldBench(CuTest *tc) {
});
}
+string generateRandomString(int length) {
+static const char alphanum[] =
+"0123456789"
+"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
+"abcdefghijklmnopqrstuvwxyz";
+string randomString;
+random_device rd;
+mt19937 gen(rd());
+uniform_int_distribution<> dis(0, sizeof(alphanum) - 2);
+for (int i = 0; i < length; ++i) {
+randomString += alphanum[dis(gen)];
+}
+return randomString;
+}
+
+const int32_t MAX_FIELD_LEN = 0x7FFFL;
+const int32_t MAX_BUFFER_DOCS = 1;
+const int32_t MERGE_FACTOR = 1;
void TestAddDocument(CuTest *tc) {
RAMDirectory dir;
SimpleAnalyzer sanalyzer;
IndexWriter w(&dir, NULL, true);
w.setUseCompoundFile(false);
+w.setMaxBufferedDocs(MAX_BUFFER_DOCS);
+w.setRAMBufferSizeMB(256);
+w.setMaxFieldLength(MAX_FIELD_LEN);
+w.setMergeFactor(MERGE_FACTOR);
w.setDocumentWriter(_CLNEW SDocumentsWriter(w.getDirectory(), &w));
Document doc;
auto field_name = lucene::util::Misc::_charToWide("f3");
-auto value1 = "value1";
-auto stringReader = _CLNEW lucene::util::SStringReader(
-value1, strlen(value1), false);
-auto stream = sanalyzer.reusableTokenStream(field_name, stringReader);
-
auto field = _CLNEW Field(field_name, Field::INDEX_TOKENIZED |
Field::STORE_NO);
-field->setValue(stream);
doc.add(*field);
-w.addDocument(&doc, &sanalyzer);
+
+for (int i = 0; i <= 200; i++) {
+std::string value1 = "value1";
+if (i > 0)
+value1 = generateRandomString(2000);
+auto stringReader = _CLNEW lucene::util::SStringReader(
+value1.c_str(), strlen(value1.c_str()), false);
+auto stream = sanalyzer.reusableTokenStream(field_name, stringReader);
+
+field->setValue(stream);
+w.addDocument(&doc, &sanalyzer);
+}
+IndexSearcher searcher(&dir);
+Term *t2 = _CLNEW Term(_T("f3"), _T("value1"));
+auto *query2 = _CLNEW TermQuery(t2);
+Hits *hits2 = searcher.search(query2);
+CLUCENE_ASSERT(1 == hits2->length());
doc.clear();
w.close();
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wzymumon commented on a diff in pull request #18557: [feature](function) support array_count function
wzymumon commented on code in PR #18557:
URL: https://github.com/apache/doris/pull/18557#discussion_r1168309111
##
be/src/vec/functions/array/function_array_count.cpp:
##
@@ -0,0 +1,154 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace doris::vectorized {
+
+// array_count([1, 2, 3, 0, 0]) -> 3
+class FunctionArrayCount : public IFunction {
+public:
+static constexpr auto name = "array_count";
+
+static FunctionPtr create() { return
std::make_shared(); }
+
+/// Get function name.
+String get_name() const override { return name; }
+
+bool is_variadic() const override { return false; }
+
+size_t get_number_of_arguments() const override { return 1; }
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+DCHECK(is_array(arguments[0]))
+<< "first argument for function: " << name << " should be
DataTypeArray";
+return make_nullable(std::make_shared());
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) override {
+// extract array offsets and nested data
+auto left_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
Review Comment:
> Please dont use `convert_to_full_column_if_const`. Nowadays our common
usage is listed in
[document](https://selectdb.feishu.cn/docx/UtysdxKDkoJ5xoxtJEUcoN6ineU)
ok. I will fix it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3
github-actions[bot] commented on PR #18723: URL: https://github.com/apache/doris/pull/18723#issuecomment-1510866295 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3
github-actions[bot] commented on PR #18723: URL: https://github.com/apache/doris/pull/18723#issuecomment-1510866399 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg opened a new pull request, #18737: [fix](const column) fix coredump caused by const column for some functions
jacktengg opened a new pull request, #18737: URL: https://github.com/apache/doris/pull/18737 # Proposed changes Issue Number: close #xxx ## Problem summary Be coredump for the following case: ``` select /*+ SET_VAR(query_timeout = 600) */ ref_1.`sr_reason_sk` as c0, ref_1.`sr_return_tax` as c1,version() as c2,BITMAP_SUBSET_IN_RANGE( cast(TO_BITMAP( cast( sum( cast(ref_1.`sr_return_quantity` as int)) over (partition by ref_1.`sr_store_credit` order by ref_1.`sr_store_credit` desc ) as int)) as bitmap), cast(null as bigint), cast(BITMAP_MIN( cast(BITMAP_EMPTY() as bitmap)) as bigint)) as c3 from regression_test_tpcds_sf1_unique_p1.store_returns as ref_1 where true ``` The reason is that bug is introduced for optimization of const columns for some functions. coredump stack: ``` ==1324550==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603024ea8b80 at pc 0 x55922e13fedf bp 0x7f281ad574f0 sp 0x7f281ad574e8 READ of size 1 at 0x603024ea8b80 thread T5758 (FragmentMgrThre) #0 0x55922e13fede in doris::vectorized::VectorizedUtils::update_null_map(doris::vector ized::PODArray, 15ul, 16ul>&, doris::vector ized::PODArray, 15ul, 16ul> const&) /mnt/di sk1/yuejing/projects/doris/be/src/vec/utils/util.hpp:73:21 #1 0x55922e133f59 in doris::vectorized::check_set_nullable(COW::immutable_ptr&, COW::mutable _ptr>&) /mnt/disk1/yuejing/projects/doris/b e/src/vec/columns/column_nullable.cpp:642:9 #2 0x55923443de6c in doris::vectorized::FunctionBitmapSubs::execute_impl(doris::FunctionContext*, doris::vectorized::Block&, std::vector > const&, unsigned long, unsigned long) /mnt/ disk1/yuejing/projects/doris/be/src/vec/functions/function_bitmap.cpp:1004:13 #3 0x55923304c4b5 in doris::vectorized::DefaultExecutable::execute_impl(doris::Functio nContext*, doris::vectorized::Block&, std::vector> const&, unsigned long, unsigned long) /mnt/disk1/yuejing/projects/doris/be/src/vec/f unctions/function.h:464:26 #4 0x559235a5d6d2 in doris::vectorized::PreparedFunctionImpl::_execute_skipped_constan t_deal(doris::FunctionContext*, doris::vectorized::Block&, std::vector> const&, unsigned long, unsigned long, bool) /mnt/disk1/yuejing/ projects/doris/be/src/vec/functions/function.cpp:146:16 #5 0x559235a540e0 in doris::vectorized::PreparedFunctionImpl::execute_without_low_card inality_columns(doris::FunctionContext*, doris::vectorized::Block&, std::vector> const&, unsigned long, unsigned long, bool) /mnt/disk1 /yuejing/projects/doris/be/src/vec/functions/function.cpp:257:12 #6 0x559235a541ff in doris::vectorized::PreparedFunctionImpl::execute(doris::FunctionC ontext*, doris::vectorized::Block&, std::vector> const&, unsigned long, unsigned long, bool) /mnt/disk1/yuejing/projects/doris/be/src/v ec/functions/function.cpp:278:12 #7 0x55923304938a in doris::vectorized::IFunctionBase::execute(doris::FunctionContext* , doris::vectorized::Block&, std::vector> con st&, unsigned long, unsigned long, bool) /mnt/disk1/yuejing/projects/doris/be/src/vec/func tions/function.h:159:19 #8 0x559232f534e2 in doris::vectorized::VectorizedFnCall::execute(doris::vectorized::V ExprContext*, doris::vectorized::Block*, int*) /mnt/disk1/yuejing/projects/doris/be/src/ve c/exprs/vectorized_fn_call.cpp:107:5 #9 0x559232f5fd82 in doris::vectorized::VExprContext::execute(doris::vectorized::Block , int) /mnt/disk1/yuejing/projects/doris/be/src/vec/exprs/vexpr_context.cpp:42:21 #10 0x559232f62d4e in doris::vectorized::VExprContext::get_output_block_after_execute_ exprs(std::vector> const&, doris::vectorized::Block const&, doris::Status&) /mnt/disk1/yuejing/pr ojects/doris/be/src/vec/exprs/vexpr_context.cpp:135:29 #11 0x559227caff5e in doris::vectorized::VMysqlResultWriter::append_block(doris ::vectorized::Block&) /mnt/disk1/yuejing/projects/doris/be/src/vec/sink/vmysql_result_writ er.cpp:559:18 #12 0x55923eaaa613 in doris::vectorized::VResultSink::send(doris::RuntimeState*, doris ::vectorized::Block*, bool) /mnt/disk1/yuejing/projects/doris/be/src/vec/sink/vresult_sink .cpp:92:21 #13 0x5592278c7912 in doris::PlanFragmentExecutor::open_vectorized_internal() /mnt/dis k1/yuejing/projects/doris/be/src/runtime/plan_fragment_executor.cpp:303:34 #14 0x5592278c604b in doris::PlanFragmentExecutor::open() /mnt/disk1/yuejing/projects/ doris/be/src/runtime/plan_fragment_executor.cpp:245:14 #15 0x55922781e1ed in doris::FragmentExecState::execute() /mnt/disk1/yuejing/projects/ doris/be/src/runtime/fragment_mgr.cpp:230:31 #16 0x5592278280d2 in doris::FragmentMgr::_exec_actual(std::shared_ptr, std::function const&) /mnt/disk1/ yuejing/projects/doris/be/src/runtime/fragment_mgr.cpp:495:29 #17 0x55922783e1bb in doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmen
[GitHub] [doris] jackwener commented on pull request #18687: [enhance](Nereids): memo check cycle by getParentGroupExpressions().
jackwener commented on PR #18687: URL: https://github.com/apache/doris/pull/18687#issuecomment-1510868261 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-thirdparty] annotated tag libclucene-v2.4.10 updated (3f91661 -> 3621df8)
This is an automated email from the ASF dual-hosted git repository. adonisling pushed a change to annotated tag libclucene-v2.4.10 in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git *** WARNING: tag libclucene-v2.4.10 was modified! *** from 3f91661 (commit) to 3621df8 (tag) tagging 3f91661ca51a3e0e2e32de196847f3fe2be53395 (commit) replaces libclucene-v2.4.9 by Adonis Ling on Mon Apr 17 15:50:41 2023 +0800 - Log - libclucene-v2.4.10 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18737: [fix](const column) fix coredump caused by const column for some functions
github-actions[bot] commented on PR #18737: URL: https://github.com/apache/doris/pull/18737#issuecomment-1510874944 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #18737: [fix](const column) fix coredump caused by const column for some functions
jacktengg commented on PR #18737: URL: https://github.com/apache/doris/pull/18737#issuecomment-1510898837 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Xiaoccer commented on pull request #18530: [enhancement](mysql) enable two-way ssl authentication
Xiaoccer commented on PR #18530: URL: https://github.com/apache/doris/pull/18530#issuecomment-1510908216 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 opened a new pull request, #18739: [refactor](scan) optimize the agg function of count(1)
zhangstar333 opened a new pull request, #18739: URL: https://github.com/apache/doris/pull/18739 # Proposed changes after PR #12803, like count(*) in dup table will use the segment static, now add count(const value) also use that optimization. Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou opened a new pull request, #18740: [fix](build) Missing header files
yongjinhou opened a new pull request, #18740: URL: https://github.com/apache/doris/pull/18740 # Proposed changes Issue Number: close #xxx ## Problem summary BE lacks header files, causing the compilation to fail. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #18740: [fix](build) Missing header files
yongjinhou commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510911811 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18740: [fix](build) Missing header files
github-actions[bot] commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510916550 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
github-actions[bot] commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-1510917619 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18735: [chore](hashtable) Use doris' Allocator to replace std::allocator in phmap
hello-stephen commented on PR #18735: URL: https://github.com/apache/doris/pull/18735#issuecomment-1510927666 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.79 seconds stream load tsv: 439 seconds loaded 74807831229 Bytes, about 162 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417083255_clickbench_pr_129996.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #18430: [fix](multi-catalog)fix old s3 properties check
wsjz commented on PR #18430: URL: https://github.com/apache/doris/pull/18430#issuecomment-1510938068 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18740: [fix](build) Missing header files
github-actions[bot] commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510941440 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18740: [fix](build) Missing header files
github-actions[bot] commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510941521 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #18723: [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3
Gabriel39 merged PR #18723: URL: https://github.com/apache/doris/pull/18723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (d61f52d277 -> 74d424e6d4)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d61f52d277 [fix](Nereids): fix sum func in eager agg (#18675) add 74d424e6d4 [Bug](DECIMAL) Fix bug for arithmatic expr DECIMALV2 / DECIMALV3 (#18723) No new revisions were added by this update. Summary of changes: .../org/apache/doris/analysis/ArithmeticExpr.java | 2 +- .../decimalv3/test_arithmetic_expressions.out | 6 ++ .../decimalv3/test_arithmetic_expressions.groovy | 22 ++ 3 files changed, 29 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #18599: [feature](Nereids): infer not null from Agg Count() without groupby.
jackwener commented on PR #18599: URL: https://github.com/apache/doris/pull/18599#issuecomment-1510942696 run buildall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #18575: [improvement](resource-group) add test for resource group
wangbo commented on code in PR #18575:
URL: https://github.com/apache/doris/pull/18575#discussion_r1168372325
##
fe/fe-core/src/main/java/org/apache/doris/resource/resourcegroup/ResourceGroupMgr.java:
##
@@ -127,8 +127,11 @@ private void checkAndCreateDefaultGroup() {
}
public void createResourceGroup(CreateResourceGroupStmt stmt) throws
DdlException {
-ResourceGroup resourceGroup =
ResourceGroup.createResourceGroup(stmt.getResourceGroupName(),
-stmt.getProperties());
+if (!Config.enable_resource_group) {
+throw new DdlException("Please add `enable_resource_group=true` in
fe.conf to enable resource group.");
Review Comment:
```suggestion
throw new DdlException("unsupported feature now,coming soon");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau commented on a diff in pull request #18652: [improve] Refactor file cache and Improve the file cache strategy
AshinGau commented on code in PR #18652:
URL: https://github.com/apache/doris/pull/18652#discussion_r1168380732
##
be/src/io/cache/block/block_file_cache.cpp:
##
@@ -51,16 +51,34 @@ IFileCache::Key IFileCache::hash(const std::string& path) {
return Key(key);
}
-std::string IFileCache::get_path_in_local_cache(const Key& key, size_t offset,
-bool is_persistent) const {
-auto key_str = key.to_string();
-std::string suffix = is_persistent ? "_persistent" : "";
-if constexpr (USE_CACHE_VERSION2) {
-return fs::path(_cache_base_path) / key_str.substr(0,
KEY_PREFIX_LENGTH) / key_str /
- (std::to_string(offset) + suffix);
-} else {
-return fs::path(_cache_base_path) / key_str / (std::to_string(offset)
+ suffix);
+std::string IFileCache::cache_type_to_string(CacheType type) {
+switch (type) {
+case CacheType::INDEX:
+return "_idx";
+case CacheType::DISPOSABLE:
+return "_disposable";
+case CacheType::NORMAL:
+return "";
+}
+return "";
+}
+
+CacheType IFileCache::string_to_cache_type(const std::string& str) {
Review Comment:
Why does only match the first character?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #18575: [improvement](resource-group) add test for resource group
luozenglin commented on PR #18575: URL: https://github.com/apache/doris/pull/18575#issuecomment-1510953957 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18739: [refactor](scan) optimize the agg function of count(1)
HappenLee commented on code in PR #18739:
URL: https://github.com/apache/doris/pull/18739#discussion_r1168384982
##
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##
@@ -490,8 +493,7 @@ private void pushDownAggNoGrouping(AggregateInfo aggInfo,
SelectStmt selectStmt,
break;
}
-if (colType.isCharFamily() && aggOp !=
TPushAggOp.COUNT
-&& col.getType().getLength() > 512) {
+if (colType.isCharFamily() &&
col.getType().getLength() > 512) {
Review Comment:
why change this ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #18720: [fix](stats) Stats still in cache when user dropped it.
Kikyou1997 commented on PR #18720: URL: https://github.com/apache/doris/pull/18720#issuecomment-1510962551 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
github-actions[bot] commented on code in PR #18627:
URL: https://github.com/apache/doris/pull/18627#discussion_r1168389256
##
be/test/vec/data_types/serde/data_type_serde_test.cpp:
##
@@ -0,0 +1,172 @@
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+
+#include
+#include
+
+#include "vec/columns/column_complex.h"
+#include "vec/columns/column_decimal.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/data_types/data_type_bitmap.h"
+#include "vec/data_types/data_type_decimal.h"
+#include "vec/data_types/data_type_hll.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/data_types/data_type_quantilestate.h"
+#include "vec/data_types/data_type_string.h"
+
+namespace doris::vectorized {
+
+void column_to_pb(const DataTypePtr data_type, const IColumn& col, PValues*
result) {
+const DataTypeSerDeSPtr serde = data_type->get_serde();
+serde->write_column_to_pb(col, *result, 0, col.size());
+}
+
+void pb_to_column(const DataTypePtr data_type, PValues& result, IColumn& col) {
+auto serde = data_type->get_serde();
+serde->read_column_from_pb(col, result);
+}
+
+void check_pb_col(const DataTypePtr data_type, const IColumn& col) {
+PValues pv = PValues();
+column_to_pb(data_type, col, &pv);
+std::string s1 = pv.DebugString();
+
+auto col1 = data_type->create_column();
+pb_to_column(data_type, pv, *col1);
+PValues as_pv = PValues();
+column_to_pb(data_type, *col1, &as_pv);
+
+std::string s2 = as_pv.DebugString();
+EXPECT_EQ(s1, s2);
+}
+
+void serialize_and_deserialize_pb_test() {
+// int
+{
+auto vec = vectorized::ColumnVector::create();
+auto& data = vec->get_data();
+for (int i = 0; i < 1024; ++i) {
+data.push_back(i);
+}
+vectorized::DataTypePtr
data_type(std::make_shared());
+check_pb_col(data_type, *vec.get());
+}
+// string
+{
+auto strcol = vectorized::ColumnString::create();
+for (int i = 0; i < 1024; ++i) {
+std::string is = std::to_string(i);
+strcol->insert_data(is.c_str(), is.size());
+}
+vectorized::DataTypePtr
data_type(std::make_shared());
+check_pb_col(data_type, *strcol.get());
+}
+// decimal
+{
+vectorized::DataTypePtr
decimal_data_type(doris::vectorized::create_decimal(27, 9, true));
+auto decimal_column = decimal_data_type->create_column();
+auto& data =
((vectorized::ColumnDecimal>*)
+ decimal_column.get())
+ ->get_data();
+for (int i = 0; i < 1024; ++i) {
+__int128_t value = i * pow(10, 9) + i * pow(10, 8);
+data.push_back(value);
+}
+check_pb_col(decimal_data_type, *decimal_column.get());
+}
+// bitmap
+{
+vectorized::DataTypePtr
bitmap_data_type(std::make_shared());
+auto bitmap_column = bitmap_data_type->create_column();
+std::vector& container =
+((vectorized::ColumnBitmap*)bitmap_column.get())->get_data();
+for (int i = 0; i < 4; ++i) {
+BitmapValue bv;
+for (int j = 0; j <= i; ++j) {
+bv.add(j);
+}
+container.push_back(bv);
+}
+check_pb_col(bitmap_data_type, *bitmap_column.get());
+}
+// hll
+{
+vectorized::DataTypePtr
hll_data_type(std::make_shared());
+auto hll_column = hll_data_type->create_column();
+std::vector& container =
+((vectorized::ColumnHLL*)hll_column.get())->get_data();
+for (int i = 0; i < 4; ++i) {
+HyperLogLog hll;
+hll.update(i);
+container.push_back(hll);
+}
+check_pb_col(hll_data_type, *hll_column.get());
+}
+// quantilestate
+{
+vectorized::DataTypePtr quantile_data_type(
+std::make_shared());
+auto quantile_column = quantile_data_type->create_column();
+std::vector& container =
+
((vectorized::ColumnQuantileStateDouble*)quantile_column.get())->get_data();
+const long max_rand = 100L;
+double lower_bound = 0;
+double upper_bound = 100;
+srandom(time(NULL));
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
srandom(time(nullptr));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
[GitHub] [doris] github-actions[bot] commented on pull request #18739: [refactor](scan) optimize the agg function of count(1)
github-actions[bot] commented on PR #18739: URL: https://github.com/apache/doris/pull/18739#issuecomment-1510965684 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18739: [refactor](scan) optimize the agg function of count(1)
github-actions[bot] commented on PR #18739: URL: https://github.com/apache/doris/pull/18739#issuecomment-1510965763 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan opened a new pull request, #18741: [Improve](type-system)del useless data type api and add some ut for to_string method
amorynan opened a new pull request, #18741: URL: https://github.com/apache/doris/pull/18741 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
yixiutt commented on PR #18702: URL: https://github.com/apache/doris/pull/18702#issuecomment-1510967987 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18653: [Optimization](statistics) optimize the problem of slow deletion of statistics .
Kikyou1997 commented on code in PR #18653:
URL: https://github.com/apache/doris/pull/18653#discussion_r1168393092
##
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java:
##
@@ -179,15 +205,7 @@ private static void dropStatistics(Long dbId,
Map params = new HashMap<>();
params.put("condition", predicate.toString());
-StringSubstitutor stringSubstitutor = new StringSubstitutor(params);
-
-try {
-String statement = isHistogram ?
stringSubstitutor.replace(DROP_TABLE_HISTOGRAM_TEMPLATE) :
-stringSubstitutor.replace(DROP_TABLE_STATISTICS_TEMPLATE);
-StatisticsUtil.execUpdate(statement);
-} catch (Exception e) {
-LOG.warn("Drop statistics failed", e);
-}
+return params;
}
private static void buildPredicate(String fieldName, Set
fieldValues, StringBuilder predicate) {
Review Comment:
you're right, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
github-actions[bot] commented on PR #18702: URL: https://github.com/apache/doris/pull/18702#issuecomment-1510970204 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt opened a new issue, #18742: [Enhancement] (compaction) support parallel compaction for single replica
yixiutt opened a new issue, #18742: URL: https://github.com/apache/doris/issues/18742 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Currently only one thread can do compaction for a tablet, but some case compaction may cost a lot of time and we may able to start other thread do compaction. ### Solution multi-thread compaction for one tablet, modify meta in lock ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #18740: [fix](build) Missing header files
yongjinhou commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510973147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] luzhijing merged pull request #209: update images
luzhijing merged PR #209: URL: https://github.com/apache/doris-website/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: update images (#209)
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 8c2e64ee9eb update images (#209) 8c2e64ee9eb is described below commit 8c2e64ee9eb1d3226c3f9b7d44b4e1f6dd9fc6eb Author: yongkang.zhong AuthorDate: Mon Apr 17 17:06:17 2023 +0800 update images (#209) --- static/images/cpu-flame-demo.svg | 12 static/images/wechat.png | Bin 11913 -> 9890 bytes 2 files changed, 12 deletions(-) diff --git a/static/images/cpu-flame-demo.svg b/static/images/cpu-flame-demo.svg index f08a8a76055..fd2d435a085 100644 --- a/static/images/cpu-flame-demo.svg +++ b/static/images/cpu-flame-demo.svg @@ -1441,10 +1441,6 @@ -doris::SegmentGroup::find_short_key (86 samples, 0.06%) - - - doris::ReadOnlyFileStream::_assure_data (46 samples, 0.03%) @@ -1489,18 +1485,10 @@ -doris::SegmentGroup::add_short_key (362 samples, 0.23%) - - - doris::ColumnData::_seek_to_row (41,249 samples, 26.61%) doris::ColumnData::_seek_to_row -doris::SegmentGroup::add_short_key (100 samples, 0.06%) - - - doris::ReadOnlyFileStream::_assure_data (178 samples, 0.11%) diff --git a/static/images/wechat.png b/static/images/wechat.png index 972034f9644..421b4a6a6c6 100644 Binary files a/static/images/wechat.png and b/static/images/wechat.png differ - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18740: [fix](build) Missing header files
github-actions[bot] commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510976672 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18741: [Improve](type-system)del useless data type api and add some ut for to_string method
github-actions[bot] commented on PR #18741: URL: https://github.com/apache/doris/pull/18741#issuecomment-1510977329 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18740: [fix](build) Missing header files
github-actions[bot] commented on PR #18740: URL: https://github.com/apache/doris/pull/18740#issuecomment-1510978873 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caoliang-web opened a new pull request, #18743: [BUG](es_catalog)Solve the problem of querying es catalog Unexpected exception: Index:…
caoliang-web opened a new pull request, #18743: URL: https://github.com/apache/doris/pull/18743 ## Problem summary 1.Solve the problem of querying es catalog Unexpected exception: Index: 0, Size: 0 ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #18720: [fix](stats) Stats still in cache when user dropped it.
Kikyou1997 commented on PR #18720: URL: https://github.com/apache/doris/pull/18720#issuecomment-1510991612 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #18739: [refactor](scan) optimize the agg function of count(1)
zhangstar333 commented on PR #18739: URL: https://github.com/apache/doris/pull/18739#issuecomment-1510993679 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18676: [vectorzied](function) fix array_map function analyzed failed with order by clause
github-actions[bot] commented on PR #18676: URL: https://github.com/apache/doris/pull/18676#issuecomment-1511003599 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18676: [vectorzied](function) fix array_map function analyzed failed with order by clause
github-actions[bot] commented on PR #18676: URL: https://github.com/apache/doris/pull/18676#issuecomment-1511003725 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
amorynan commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1511014662 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18737: [fix](const column) fix coredump caused by const column for some functions
hello-stephen commented on PR #18737: URL: https://github.com/apache/doris/pull/18737#issuecomment-1511014912 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.87 seconds stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417093415_clickbench_pr_130022.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly opened a new pull request, #18744: [tpch](nereids) estimate broadcast cost and shuffle cost
englefly opened a new pull request, #18744: URL: https://github.com/apache/doris/pull/18744 # Proposed changes We need the sender and receiver number to estimate the cost broadcast and shuffle. But we do not have these numbers under current framework. So we assume the sender number is equal to the receiver number. And then we estimate the cost of sender as the cost of distribute node. Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang opened a new pull request, #18745: [Improvement](broker) support broker load from tencent Goose File System
Yulei-Yang opened a new pull request, #18745: URL: https://github.com/apache/doris/pull/18745 # Proposed changes Including below functions: 1. broker load 2. export 3. select into outfile 4. create repo and backup to gfs after config env, use gfs like other hdfs system. Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
github-actions[bot] commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1511018186 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #18745: [Improvement](broker) support broker load from tencent Goose File System
Yulei-Yang commented on PR #18745: URL: https://github.com/apache/doris/pull/18745#issuecomment-1511024407 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #18733: [Bug](DECIMALV3) report failure if a decimal value is overflow (#18336)
morningman merged PR #18733: URL: https://github.com/apache/doris/pull/18733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [Bug](DECIMALV3) report failure if a decimal value is overflow (#18336) (#18733)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 3a91f083fd [Bug](DECIMALV3) report failure if a decimal value is
overflow (#18336) (#18733)
3a91f083fd is described below
commit 3a91f083fdb8ef43465dd3f82038a3917091b22f
Author: Gabriel
AuthorDate: Mon Apr 17 17:47:39 2023 +0800
[Bug](DECIMALV3) report failure if a decimal value is overflow (#18336)
(#18733)
pick #18336
---
be/src/runtime/decimalv2_value.cpp | 2 +-
be/src/util/string_parser.hpp | 16 +-
be/src/vec/data_types/data_type_decimal.cpp| 11 +-
be/src/vec/data_types/data_type_decimal.h | 2 +-
be/src/vec/exprs/vexpr.cpp | 116 -
be/src/vec/exprs/vliteral.cpp | 59 +++--
be/src/vec/io/io_helper.h | 12 +-
be/src/vec/sink/vtablet_sink.cpp | 70 ++
be/src/vec/sink/vtablet_sink.h | 11 +
.../java/org/apache/doris/catalog/ScalarType.java | 6 +-
.../org/apache/doris/analysis/ArithmeticExpr.java | 9 +-
.../org/apache/doris/planner/QueryPlanTest.java| 4 +-
.../data/datatype_p0/decimalv3/test_overflow.out | 19 --
regression-test/data/insert_p0/insert.out | 182 +++---
.../operator/test_arithmetic_operators.out | 261 +++--
.../conditional_functions/test_nullif.out | 2 +-
.../decimalv3/test_data/test_overflow.csv | 2 +
.../datatype_p0/decimalv3/test_overflow.groovy | 56 -
.../suites/primary_index/test_pk_uk_case.groovy| 8 +-
.../suites/query_p0/aggregate/aggregate.groovy | 2 +-
.../operator/test_arithmetic_operators.groovy | 22 +-
.../conditional_functions/test_nullif.groovy | 4 +-
22 files changed, 361 insertions(+), 515 deletions(-)
diff --git a/be/src/runtime/decimalv2_value.cpp
b/be/src/runtime/decimalv2_value.cpp
index 3d7f56c047..bc3934d3b7 100644
--- a/be/src/runtime/decimalv2_value.cpp
+++ b/be/src/runtime/decimalv2_value.cpp
@@ -353,7 +353,7 @@ int DecimalV2Value::parse_from_str(const char* decimal_str,
int32_t length) {
_value = StringParser::string_to_decimal<__int128>(decimal_str, length,
PRECISION, SCALE,
&result);
-if (result == StringParser::PARSE_FAILURE) {
+if (result != StringParser::PARSE_SUCCESS) {
error = E_DEC_BAD_NUM;
}
return error;
diff --git a/be/src/util/string_parser.hpp b/be/src/util/string_parser.hpp
index 4fb0449cfb..eb0ab53060 100644
--- a/be/src/util/string_parser.hpp
+++ b/be/src/util/string_parser.hpp
@@ -614,19 +614,17 @@ inline T StringParser::string_to_decimal(const char* s,
int len, int type_precis
// an exponent will be made later.
if (LIKELY(type_precision > precision)) {
value = (value * 10) + (c - '0'); // Benchmarks are faster
with parenthesis...
+} else {
+*result = StringParser::PARSE_OVERFLOW;
+value = is_negative ?
vectorized::min_decimal_value>(
+ type_precision)
+:
vectorized::max_decimal_value>(
+ type_precision);
+return value;
}
DCHECK(value >= 0); // For some reason //DCHECK_GE doesn't work
with __int128.
++precision;
scale += found_dot;
-if (precision > type_precision) {
-if constexpr (std::is_same_v) {
-value =
vectorized::max_decimal_value();
-} else if constexpr (std::is_same_v) {
-value =
vectorized::max_decimal_value();
-} else {
-value =
vectorized::max_decimal_value();
-}
-}
} else if (c == '.' && LIKELY(!found_dot)) {
found_dot = 1;
} else if ((c == 'e' || c == 'E') && LIKELY(!found_exponent)) {
diff --git a/be/src/vec/data_types/data_type_decimal.cpp
b/be/src/vec/data_types/data_type_decimal.cpp
index 5d00e65033..4d3a1147de 100644
--- a/be/src/vec/data_types/data_type_decimal.cpp
+++ b/be/src/vec/data_types/data_type_decimal.cpp
@@ -150,14 +150,11 @@ MutableColumnPtr DataTypeDecimal::create_column()
const {
}
template
-T DataTypeDecimal::parse_from_string(const std::string& str) const {
+bool DataTypeDecimal::parse_from_string(const std::string& str, T* res)
const {
StringParser::ParseResult result = StringParser::PARSE_SUCCESS;
-T value = StringParser::string_to_decimal<__int128>(str.c_str(),
str.size(), precision, scale,
-&result);
[GitHub] [doris] TangSiyang2001 opened a new pull request, #18746: [fix](editLog) add sufficient replay logic and edit log for altering light schema change
TangSiyang2001 opened a new pull request, #18746: URL: https://github.com/apache/doris/pull/18746 # Proposed changes Issue Number: close #18732 ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18652: [improve] Refactor file cache and Improve the file cache strategy
AshinGau commented on PR #18652: URL: https://github.com/apache/doris/pull/18652#issuecomment-1511038378 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #18746: [fix](editLog) add sufficient replay logic and edit log for altering light schema change
TangSiyang2001 commented on PR #18746: URL: https://github.com/apache/doris/pull/18746#issuecomment-1511037987 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on pull request #18744: [tpch](nereids) estimate broadcast cost and shuffle cost
englefly commented on PR #18744: URL: https://github.com/apache/doris/pull/18744#issuecomment-1511041797 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18717: [feature](nereids)Tpc-h 1T plan shape check
github-actions[bot] commented on PR #18717: URL: https://github.com/apache/doris/pull/18717#issuecomment-1511042678 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #18746: [fix](editLog) add sufficient replay logic and edit log for altering light schema change
TangSiyang2001 commented on PR #18746: URL: https://github.com/apache/doris/pull/18746#issuecomment-1511044455 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18739: [refactor](scan) optimize the agg function of count(1)
hello-stephen commented on PR #18739: URL: https://github.com/apache/doris/pull/18739#issuecomment-1511046835 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.05 seconds stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417095803_clickbench_pr_130089.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
amorynan commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1511047191 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18722: [feature](segcompaction) enable segcompaction by default
yiguolei merged PR #18722: URL: https://github.com/apache/doris/pull/18722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](segcompaction) enable segcompaction by default (#18722)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 16cdd9e95a [feature](segcompaction) enable segcompaction by default (#18722) 16cdd9e95a is described below commit 16cdd9e95aeecc77dfc9ff675fcc5e12d9516605 Author: zhengyu AuthorDate: Mon Apr 17 18:00:49 2023 +0800 [feature](segcompaction) enable segcompaction by default (#18722) Signed-off-by: freemandealer --- be/src/common/config.h | 2 +- docs/en/docs/admin-manual/config/be-config.md| 10 +- docs/en/docs/faq/data-faq.md | 4 ++-- docs/zh-CN/docs/admin-manual/config/be-config.md | 10 +- docs/zh-CN/docs/faq/data-faq.md | 6 +++--- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/be/src/common/config.h b/be/src/common/config.h index 3f2034191c..976dfd3149 100644 --- a/be/src/common/config.h +++ b/be/src/common/config.h @@ -875,7 +875,7 @@ CONF_String(be_node_role, "mix"); // Hide the be config page for webserver. CONF_Bool(hide_webserver_config_page, "false"); -CONF_Bool(enable_segcompaction, "false"); // currently only support vectorized storage +CONF_Bool(enable_segcompaction, "true"); // Trigger segcompaction if the num of segments in a rowset exceeds this threshold. CONF_Int32(segcompaction_threshold_segment_num, "10"); diff --git a/docs/en/docs/admin-manual/config/be-config.md b/docs/en/docs/admin-manual/config/be-config.md index 821f81b03e..c9443394cf 100644 --- a/docs/en/docs/admin-manual/config/be-config.md +++ b/docs/en/docs/admin-manual/config/be-config.md @@ -7,7 +7,7 @@ } --- -
[GitHub] [doris] github-actions[bot] commented on pull request #18627: [Refact](type system) refact serde for type system and pb serde impl
github-actions[bot] commented on PR #18627: URL: https://github.com/apache/doris/pull/18627#issuecomment-1511059203 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18702: [Enhancement](compaction) stop tablet compaction when table dropped
github-actions[bot] commented on PR #18702: URL: https://github.com/apache/doris/pull/18702#issuecomment-1511060551 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing opened a new pull request, #18747: [Enhancement](Nereids)Add nereids minidump
Bingandbing opened a new pull request, #18747: URL: https://github.com/apache/doris/pull/18747 Add runnable mini dump demo in MinidumpTest ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [x] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing commented on pull request #18747: [Enhancement](Nereids)Add nereids minidump
Bingandbing commented on PR #18747: URL: https://github.com/apache/doris/pull/18747#issuecomment-1511076033 run build all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing commented on pull request #18747: [Enhancement](Nereids)Add nereids minidump
Bingandbing commented on PR #18747: URL: https://github.com/apache/doris/pull/18747#issuecomment-1511076325 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #18748: [Compile](BE) Fix compile failed with mysql/tcmalloc
HappenLee opened a new pull request, #18748: URL: https://github.com/apache/doris/pull/18748 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18745: [Improvement](broker) support broker load from tencent Goose File System
hello-stephen commented on PR #18745: URL: https://github.com/apache/doris/pull/18745#issuecomment-1511081607 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.38 seconds stream load tsv: 439 seconds loaded 74807831229 Bytes, about 162 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417102017_clickbench_pr_130101.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18748: [Compile](BE) Fix compile failed with mysql/tcmalloc
github-actions[bot] commented on PR #18748: URL: https://github.com/apache/doris/pull/18748#issuecomment-1511086526 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #18691: [enhancement](agent-task/schema-change) make agent batch tasks cancelable in BE
TangSiyang2001 commented on PR #18691: URL: https://github.com/apache/doris/pull/18691#issuecomment-1511091028 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18691: [enhancement](agent-task/schema-change) make agent batch tasks cancelable in BE
github-actions[bot] commented on PR #18691: URL: https://github.com/apache/doris/pull/18691#issuecomment-1511096646 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener opened a new pull request, #18749: [fix](Nereids): when GroupExpr already exists, we need to remove ParentExpression
jackwener opened a new pull request, #18749: URL: https://github.com/apache/doris/pull/18749 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #18749: [fix](Nereids): when GroupExpr already exists, we need to remove ParentExpression
jackwener commented on PR #18749: URL: https://github.com/apache/doris/pull/18749#issuecomment-153092 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
LemonLiTree commented on PR #18721: URL: https://github.com/apache/doris/pull/18721#issuecomment-159327 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] weideguo commented on issue #18241: [Bug] ERROR 1105 (HY000): errCode = 2, detailMessage = Failed to find 3 backends for policy: cluster|query|load|schedule|tags|medium: default_clust
weideguo commented on issue #18241: URL: https://github.com/apache/doris/issues/18241#issuecomment-1511120119 Same question, in fact i use HDD as default. any one help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing commented on pull request #18581: [Fix](Nereids)Check bounding of expression in analyze process
Bingandbing commented on PR #18581: URL: https://github.com/apache/doris/pull/18581#issuecomment-1511134282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] imSanko commented on issue #17176: [Good First Issue] Doris' Future
imSanko commented on issue #17176: URL: https://github.com/apache/doris/issues/17176#issuecomment-1511137833 Can you assign this work me ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16909: [feature](docker)add be init script option
github-actions[bot] commented on PR #16909: URL: https://github.com/apache/doris/pull/16909#issuecomment-1511170715 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16909: [feature](docker)add be init script option
github-actions[bot] commented on PR #16909: URL: https://github.com/apache/doris/pull/16909#issuecomment-1511170784 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
