Kikyou1997 commented on code in PR #18653:
URL: https://github.com/apache/doris/pull/18653#discussion_r1168393092
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java:
##########
@@ -179,15 +205,7 @@ private static void dropStatistics(Long dbId,
Map<String, String> params = new HashMap<>();
params.put("condition", predicate.toString());
- StringSubstitutor stringSubstitutor = new StringSubstitutor(params);
-
- try {
- String statement = isHistogram ?
stringSubstitutor.replace(DROP_TABLE_HISTOGRAM_TEMPLATE) :
- stringSubstitutor.replace(DROP_TABLE_STATISTICS_TEMPLATE);
- StatisticsUtil.execUpdate(statement);
- } catch (Exception e) {
- LOG.warn("Drop statistics failed", e);
- }
+ return params;
}
private static <T> void buildPredicate(String fieldName, Set<T>
fieldValues, StringBuilder predicate) {
Review Comment:
you're right, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
