[GitHub] [doris] morningman merged pull request #16629: [fix](docker)Fix Docker init_be script
morningman merged PR #16629: URL: https://github.com/apache/doris/pull/16629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](docker)Fix Docker init_be script (#16629)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 274016f50e [fix](docker)Fix Docker init_be script (#16629)
274016f50e is described below
commit 274016f50e814542bac144c650d667bde805f636
Author: FreeOnePlus <54164178+freeonep...@users.noreply.github.com>
AuthorDate: Sat Feb 11 16:15:48 2023 +0800
[fix](docker)Fix Docker init_be script (#16629)
docker_process_sql function have error output.
---
docker/runtime/be/resource/init_be.sh | 271 +-
1 file changed, 135 insertions(+), 136 deletions(-)
diff --git a/docker/runtime/be/resource/init_be.sh
b/docker/runtime/be/resource/init_be.sh
index bd85416af6..7a4e475a78 100644
--- a/docker/runtime/be/resource/init_be.sh
+++ b/docker/runtime/be/resource/init_be.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
@@ -28,186 +28,185 @@ DORIS_HOME="/opt/apache-doris"
#ie: doris_warn "task may be risky!"
# out: 2023-01-08T19:08:16+08:00 [Warn] [Entrypoint]: task may be risky!
doris_log() {
-local type="$1"
-shift
-# accept argument string or stdin
-local text="$*"
-if [ "$#" -eq 0 ]; then text="$(cat)"; fi
-local dt="$(date -Iseconds)"
-printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
+ local type="$1"
+ shift
+ # accept argument string or stdin
+ local text="$*"
+ if [ "$#" -eq 0 ]; then text="$(cat)"; fi
+ local dt="$(date -Iseconds)"
+ printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
}
doris_note() {
-doris_log Note "$@"
+ doris_log Note "$@"
}
doris_warn() {
-doris_log Warn "$@" >&2
+ doris_log Warn "$@" >&2
}
doris_error() {
-doris_log ERROR "$@" >&2
-exit 1
+ doris_log ERROR "$@" >&2
+ exit 1
}
# check to see if this file is being run or sourced from another script
_is_sourced() {
-[ "${#FUNCNAME[@]}" -ge 2 ] &&
-[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
-[ "${FUNCNAME[1]}" = 'source' ]
+ [ "${#FUNCNAME[@]}" -ge 2 ] &&
+[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
+[ "${FUNCNAME[1]}" = 'source' ]
}
docker_setup_env() {
-declare -g DATABASE_ALREADY_EXISTS
-if [ -d "${DORIS_HOME}/be/storage/data" ]; then
-DATABASE_ALREADY_EXISTS='true'
-fi
+ declare -g DATABASE_ALREADY_EXISTS
+ if [ -d "${DORIS_HOME}/be/storage/data" ]; then
+DATABASE_ALREADY_EXISTS='true'
+ fi
}
# Check the variables required for startup
docker_required_variables_env() {
-if [[ $FE_SERVERS =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
-doris_warn "FE_SERVERS" $FE_SERVERS
-else
-doris_error "FE_SERVERS rule error！example:
\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT[,\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT]..."
-fi
-if [[ $BE_ADDR =~
^[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}$
]]; then
-doris_warn "BE_ADDR" $BE_ADDR
-else
-doris_error "BE_ADDR rule error！example:
\$BE_HOST_IP:\$HEARTBEAT_SERVICE_PORT"
-fi
+ if [[ $FE_SERVERS =~
^.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}(,.+:[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4})*$
]]; then
+doris_warn "FE_SERVERS" $FE_SERVERS
+ else
+doris_error "FE_SERVERS rule error！example:
\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT[,\$FE_NAME:\$FE_HOST_IP:\$FE_EDIT_LOG_PORT]..."
+ fi
+ if [[ $BE_ADDR =~
^[1-2]{0,1}[0-9]{0,1}[0-9]{1}(\.[1-2]{0,1}[0-9]{0,1}[0-9]{1}){3}:[1-6]{0,1}[0-9]{1,4}$
]]; then
+doris_warn "BE_ADDR" $BE_ADDR
+ else
+doris_error "BE_ADDR rule error！example:
\$BE_HOST_IP:\$HEARTBEAT_SERVICE_PORT"
+ fi
}
get_doris_be_args() {
-local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," "); print
$0}'))
-for i in "${feServerArray[@]}"; do
-val=${i}
-val=${val// /}
-tmpFeId=$(echo "${val}" | awk -F ':' '{ sub(/fe/, ""); sub(/ /, "");
print$1}')
-tmpFeIp=$(echo "${val}" | awk -F ':' '{ sub(/ /, ""); print$2}')
-tmpFeEditLogPort=$(echo "${val}" | awk -F ':' '{ sub(/ /, "");
print$3}')
-check_arg "tmpFeIp" $tmpFeIp
-feIpArray[$tmpFeId]=${tmpFeIp}
-check_arg "tmpFeEditLogPort" $tmpFeEditLogPort
-feEditLogPortArray[$tmpFeId]=${tmpFeEditLogPort}
-done
-
-declare -g MASTER_FE_IP BE_HOST_IP BE_HEARTBEAT_PORT PRIORITY_NETWORKS
-MASTER_FE_IP=${feIpArray[1]}
-check_arg "MASTER_FE_IP" $MASTER_FE_IP
-BE_HOST_IP=$(echo "${BE_ADDR}" |
svn commit: r60063 - in /dev/doris/1.2.2-rc01: apache-doris-dependencies-1.2.2-bin-arm.tar.xz apache-doris-dependencies-1.2.2-bin-arm.tar.xz.asc apache-doris-dependencies-1.2.2-bin-arm.tar.xz.sha512
Author: morningman Date: Sat Feb 11 08:30:47 2023 New Revision: 60063 Log: add apache-doris-dependencies-1.2.2-bin-arm.tar.xz for doris 1.2.2 rc01 release Added: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz (with props) dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.asc (with props) dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.sha512 Added: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz == Binary file - no diff available. Propchange: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz -- svn:mime-type = application/x-xz Added: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.asc == Binary file - no diff available. Propchange: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.asc -- svn:mime-type = application/pgp-signature Added: dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.sha512 == --- dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.sha512 (added) +++ dev/doris/1.2.2-rc01/apache-doris-dependencies-1.2.2-bin-arm.tar.xz.sha512 Sat Feb 11 08:30:47 2023 @@ -0,0 +1 @@ +f33c0c0b33e05b401785e19b9ab95c2b9711e3cc749c5b080cfaa20eff91e804c7b3463caf6fc9399bad60b55ae9c6578e2d035343ade492010e529716843691 apache-doris-dependencies-1.2.2-bin-arm.tar.xz - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on issue #16596: [Bug] decimalv3字段查询的时候，BE节点全部挂掉
Yukang-Lian commented on issue #16596: URL: https://github.com/apache/doris/issues/16596#issuecomment-1426663529 Hi @wanqiang2046, I can't reproduce the error in the latest master branch code. It is speculated that this error has been fixed. You can try to run this sql statement on the upcoming version 1.2.2.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426670975 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426672592 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426672955 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426676972 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SaintBacchus commented on a diff in pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query
SaintBacchus commented on code in PR #16633: URL: https://github.com/apache/doris/pull/16633#discussion_r1103582036 ## be/src/exec/es/es_scroll_parser.cpp: ## @@ -528,72 +530,104 @@ Status ScrollParser::fill_columns(const TupleDescriptor* tuple_desc, return Status::OK(); } -Status ScrollParser::fill_date_slot_with_strval(void* slot, const rapidjson::Value& col, Review Comment: this function was not used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong opened a new issue, #16634: [Enhancement] replace brpc bthread with pthead
chenlinzhong opened a new issue, #16634: URL: https://github.com/apache/doris/issues/16634 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description be在高负载下brpc的bthread存在无法调度的问题，导致卡住接口的回调，一个常见的问题就是: timeout when waiting for send fragments RPC 这个接口的耗时很短，通常数百微秒就应该返回，但是在高负载下会卡住很久，我们在高负载下通过perf top工具都在等待锁  原因是：bthread需要找到空闲的ptread才能成功调度，如果所有的pthread都在阻塞那么bthread会一直等待，那么导致pthread阻塞长时间阻塞的原因是啥？ * 主要是调用了pthread阻塞函数，比如在等待一把锁(std::mutex) doris be接口中大量使用了std::mutex，在高负载下很容易把pthread的线程耗尽，一个简单的查询在be间产生的qps就能达到上万或者数万，影响brpc的所有请求的处理 如何解决 通常有3种方式 - 1.brpc_num_thread: 调大线程的数量 - 2.bthread::mutex替换std::mutex - 3.brpc+线程池方式：brpc不再处理请求，只做网络请求收发，请求接到到丢到线程池中 方式1 治标不治本，pthread耗尽仍会影响所有brpc接口 方案2 落地较难，这个多人开发的时候不太好操作了。没办法每个人都知道哪些函数需要bthread的mutex,哪些是需要pthread mutex 方案3 可以彻底解决pthread耗尽影响 ### Solution add thread pool to handle the be service logic, do not use brpc any more ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1426686216 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1426686319 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong opened a new pull request, #16635: [Improvement](brpc) replace brpc bthread with pthread
chenlinzhong opened a new pull request, #16635: URL: https://github.com/apache/doris/pull/16635 # Proposed changes Issue Number: close #16634 ## Problem summary mainly include: 1. brpc service adds two types of thread pools. The number of "light" and "heavy" thread pools is different 2. Classify the interfaces of be. Those related to data transmission are classified as heavy interfaces and others as light interfaces 3. Add some monitoring to the thread pool, including the queue size and the number of active threads. Use these indicators to guide the configuration of the number of threads 主要包括 - 1.brpc服务增加2类线程池，"轻","重" 不同线程池的数量配置不一样 - 2.对be的接口进行分类，跟数据传输有关的归类为重接口，其他为轻接口 - 3.对线程池增加一些监控，包括队列大小、活跃线程个数，根据这些指标来指导线程数的配置 https://user-images.githubusercontent.com/11487604/218252833-b0648a66-c5e3-4cbf-9930-3de5a86cfd08.png";> ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1426687865 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1426688829 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16617: ZhangShunjieNet interface
github-actions[bot] commented on PR #16617: URL: https://github.com/apache/doris/pull/16617#issuecomment-1426689358 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue opened a new issue, #16636: [Enhancement] simplify output of show resource stmt
ByteYue opened a new issue, #16636: URL: https://github.com/apache/doris/issues/16636 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Currently, when we type `show resources` stmt, the output would be like the image as follow. https://user-images.githubusercontent.com/43750022/218257254-bce224d8-a0d2-44a6-9c0f-5b4b5b3834ff.png";> We can make one column named `properties`, and the content of it could be one json inside of which are the version and `AWS_XXX`. ### Solution You can take a look at `ShowResourcesStmt`, `ResourceMgr` ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16635:
URL: https://github.com/apache/doris/pull/16635#discussion_r1103617927
##
be/src/service/internal_service.cpp:
##
@@ -668,75 +755,85 @@ void
PInternalServiceImpl::check_rpc_channel(google::protobuf::RpcController* co
const PCheckRPCChannelRequest*
request,
PCheckRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->data().size() != request->size()) {
-std::stringstream ss;
-ss << "data size not same, expected: " << request->size()
- << ", actual: " << request->data().size();
-response->mutable_status()->add_error_msgs(ss.str());
-response->mutable_status()->set_status_code(1);
-
-} else {
-Md5Digest digest;
-digest.update(static_cast(request->data().c_str()),
request->data().size());
-digest.digest();
-if (!iequal(digest.hex(), request->md5())) {
+DorisMetrics::instance()->check_rpc_channel->increment(1);
+_light_work_pool.offer([this, controller, request, response, done]() {
Review Comment:
warning: lambda capture 'controller' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([this, request, response, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -668,75 +755,85 @@
const PCheckRPCChannelRequest*
request,
PCheckRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->data().size() != request->size()) {
-std::stringstream ss;
-ss << "data size not same, expected: " << request->size()
- << ", actual: " << request->data().size();
-response->mutable_status()->add_error_msgs(ss.str());
-response->mutable_status()->set_status_code(1);
-
-} else {
-Md5Digest digest;
-digest.update(static_cast(request->data().c_str()),
request->data().size());
-digest.digest();
-if (!iequal(digest.hex(), request->md5())) {
+DorisMetrics::instance()->check_rpc_channel->increment(1);
+_light_work_pool.offer([this, controller, request, response, done]() {
+brpc::ClosureGuard closure_guard(done);
+response->mutable_status()->set_status_code(0);
+if (request->data().size() != request->size()) {
std::stringstream ss;
-ss << "md5 not same, expected: " << request->md5() << ", actual: "
<< digest.hex();
+ss << "data size not same, expected: " << request->size()
+<< ", actual: " << request->data().size();
response->mutable_status()->add_error_msgs(ss.str());
response->mutable_status()->set_status_code(1);
+
+} else {
+Md5Digest digest;
+digest.update(static_cast(request->data().c_str()),
request->data().size());
+digest.digest();
+if (!iequal(digest.hex(), request->md5())) {
+std::stringstream ss;
+ss << "md5 not same, expected: " << request->md5() << ",
actual: " << digest.hex();
+response->mutable_status()->add_error_msgs(ss.str());
+response->mutable_status()->set_status_code(1);
+}
}
-}
+});
}
void PInternalServiceImpl::reset_rpc_channel(google::protobuf::RpcController*
controller,
const PResetRPCChannelRequest*
request,
PResetRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->all()) {
-int size =
ExecEnv::GetInstance()->brpc_internal_client_cache()->size();
-if (size > 0) {
-std::vector endpoints;
-
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_all(&endpoints);
-ExecEnv::GetInstance()->brpc_internal_client_cache()->clear();
-*response->mutable_channels() = {endpoints.begin(),
endpoints.end()};
-}
-} else {
-for (const std::string& endpoint : request->endpoints()) {
-if
(!ExecEnv::GetInstance()->brpc_internal_client_cache()->exist(endpoint)) {
-response->mutable_status()->add_error_msgs(endpoint + ": not
found.");
-continue;
+DorisMetrics::instance()->reset_rpc_channel->increment(1);
+_light_work_pool.offer([thi
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16635:
URL: https://github.com/apache/doris/pull/16635#discussion_r1103619001
##
be/src/service/internal_service.cpp:
##
@@ -163,94 +200,103 @@
st.to_protobuf(response->mutable_status());
}
-void
PInternalServiceImpl::exec_plan_fragment_prepare(google::protobuf::RpcController*
cntl_base,
+void
PInternalServiceImpl::exec_plan_fragment_prepare(google::protobuf::RpcController*
controller,
const
PExecPlanFragmentRequest* request,
PExecPlanFragmentResult*
response,
google::protobuf::Closure* done) {
-exec_plan_fragment(cntl_base, request, response, done);
+DorisMetrics::instance()->exec_plan_fragment_prepare->increment(1);
+_light_work_pool.offer([this, controller, request, response, done]() {
+exec_plan_fragment(controller, request, response, done);
+});
}
void
PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController*
controller,
const
PExecPlanFragmentStartRequest* request,
PExecPlanFragmentResult*
result,
google::protobuf::Closure*
done) {
-auto span = telemetry::start_rpc_server_span("exec_plan_fragment_start",
controller);
-auto scope = OpentelemetryScope {span};
-brpc::ClosureGuard closure_guard(done);
-auto st = _exec_env->fragment_mgr()->start_query_execution(request);
-st.to_protobuf(result->mutable_status());
+DorisMetrics::instance()->exec_plan_fragment_start->increment(1);
+_light_work_pool.offer([this, controller, request, result, done]() {
+auto span =
telemetry::start_rpc_server_span("exec_plan_fragment_start", controller);
+auto scope = OpentelemetryScope {span};
+brpc::ClosureGuard closure_guard(done);
+auto st = _exec_env->fragment_mgr()->start_query_execution(request);
+st.to_protobuf(result->mutable_status());
+});
}
-void
PInternalServiceImpl::tablet_writer_add_block(google::protobuf::RpcController*
cntl_base,
+void
PInternalServiceImpl::tablet_writer_add_block(google::protobuf::RpcController*
controller,
const
PTabletWriterAddBlockRequest* request,
PTabletWriterAddBlockResult* response,
google::protobuf::Closure*
done) {
// TODO(zxy) delete in 1.2 version
-google::protobuf::Closure* new_done = new
NewHttpClosure(done);
-brpc::Controller* cntl = static_cast(cntl_base);
-attachment_transfer_request_block(request,
cntl);
-
-_tablet_writer_add_block(cntl_base, request, response, new_done);
+DorisMetrics::instance()->tablet_writer_add_block->increment(1);
+_heavy_work_pool.offer([this, controller, request, response, done]() {
+google::protobuf::Closure* new_done = new
NewHttpClosure(done);
+brpc::Controller* cntl = static_cast(controller);
+
attachment_transfer_request_block(request, cntl);
+_tablet_writer_add_block(controller, request, response, new_done);
+});
}
void PInternalServiceImpl::tablet_writer_add_block_by_http(
-google::protobuf::RpcController* cntl_base, const
::doris::PEmptyRequest* request,
+google::protobuf::RpcController* controller, const
::doris::PEmptyRequest* request,
PTabletWriterAddBlockResult* response, google::protobuf::Closure*
done) {
-PTabletWriterAddBlockRequest* new_request = new
PTabletWriterAddBlockRequest();
-google::protobuf::Closure* new_done =
-new NewHttpClosure(new_request,
done);
-brpc::Controller* cntl = static_cast(cntl_base);
-Status st =
attachment_extract_request_contain_block(new_request,
-
cntl);
-if (st.ok()) {
-_tablet_writer_add_block(cntl_base, new_request, response, new_done);
-} else {
-st.to_protobuf(response->mutable_status());
-}
+DorisMetrics::instance()->tablet_writer_add_block_by_http->increment(1);
+_heavy_work_pool.offer([this, controller, request, response, done]() {
Review Comment:
warning: lambda capture 'request' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_heavy_work_pool.offer([this, controller, response, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -134,22 +167,26 @@ void
PInternalServiceImpl::tablet_writer_open(google::protobuf::RpcController* c
const PTabletWriterOpenRequest*
request,
PTabletWriterOpenResult*
respon
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16635:
URL: https://github.com/apache/doris/pull/16635#discussion_r1103619129
##
be/src/service/internal_service.cpp:
##
@@ -668,75 +760,86 @@ void
PInternalServiceImpl::check_rpc_channel(google::protobuf::RpcController* co
const PCheckRPCChannelRequest*
request,
PCheckRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->data().size() != request->size()) {
-std::stringstream ss;
-ss << "data size not same, expected: " << request->size()
- << ", actual: " << request->data().size();
-response->mutable_status()->add_error_msgs(ss.str());
-response->mutable_status()->set_status_code(1);
-
-} else {
-Md5Digest digest;
-digest.update(static_cast(request->data().c_str()),
request->data().size());
-digest.digest();
-if (!iequal(digest.hex(), request->md5())) {
+DorisMetrics::instance()->check_rpc_channel->increment(1);
+_light_work_pool.offer([controller, request, response, done]() {
Review Comment:
warning: lambda capture 'controller' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([ request, response, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -668,75 +760,86 @@ void
PInternalServiceImpl::check_rpc_channel(google::protobuf::RpcController* co
const PCheckRPCChannelRequest*
request,
PCheckRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->data().size() != request->size()) {
-std::stringstream ss;
-ss << "data size not same, expected: " << request->size()
- << ", actual: " << request->data().size();
-response->mutable_status()->add_error_msgs(ss.str());
-response->mutable_status()->set_status_code(1);
-
-} else {
-Md5Digest digest;
-digest.update(static_cast(request->data().c_str()),
request->data().size());
-digest.digest();
-if (!iequal(digest.hex(), request->md5())) {
+DorisMetrics::instance()->check_rpc_channel->increment(1);
+_light_work_pool.offer([controller, request, response, done]() {
+brpc::ClosureGuard closure_guard(done);
+response->mutable_status()->set_status_code(0);
+if (request->data().size() != request->size()) {
std::stringstream ss;
-ss << "md5 not same, expected: " << request->md5() << ", actual: "
<< digest.hex();
+ss << "data size not same, expected: " << request->size()
+ << ", actual: " << request->data().size();
response->mutable_status()->add_error_msgs(ss.str());
response->mutable_status()->set_status_code(1);
+
+} else {
+Md5Digest digest;
+digest.update(static_cast(request->data().c_str()),
+ request->data().size());
+digest.digest();
+if (!iequal(digest.hex(), request->md5())) {
+std::stringstream ss;
+ss << "md5 not same, expected: " << request->md5() << ",
actual: " << digest.hex();
+response->mutable_status()->add_error_msgs(ss.str());
+response->mutable_status()->set_status_code(1);
+}
}
-}
+});
}
void PInternalServiceImpl::reset_rpc_channel(google::protobuf::RpcController*
controller,
const PResetRPCChannelRequest*
request,
PResetRPCChannelResponse*
response,
google::protobuf::Closure* done) {
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-if (request->all()) {
-int size =
ExecEnv::GetInstance()->brpc_internal_client_cache()->size();
-if (size > 0) {
-std::vector endpoints;
-
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_all(&endpoints);
-ExecEnv::GetInstance()->brpc_internal_client_cache()->clear();
-*response->mutable_channels() = {endpoints.begin(),
endpoints.end()};
-}
-} else {
-for (const std::string& endpoint : request->endpoints()) {
-if
(!ExecEnv::GetInstance()->brpc_internal_client_cache()->exist(endpoint)) {
-response->mutable_status()->add_error_msgs(endpoint + ": not
found.");
-continue;
+
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16635:
URL: https://github.com/apache/doris/pull/16635#discussion_r1103620629
##
be/src/service/internal_service.cpp:
##
@@ -1072,14 +1178,22 @@ void
PInternalServiceImpl::multiget_data(google::protobuf::RpcController* contro
const PMultiGetRequest* request,
PMultiGetResponse* response,
google::protobuf::Closure* done) {
-// multi get data by rowid
-MonotonicStopWatch watch;
-watch.start();
-brpc::ClosureGuard closure_guard(done);
-response->mutable_status()->set_status_code(0);
-Status st = _multi_get(request, response);
-st.to_protobuf(response->mutable_status());
-LOG(INFO) << "multiget_data finished, cost(us):" << watch.elapsed_time() /
1000;
+// Submit task to seperate ThreadPool for avoiding block bthread working
pthread
+ThreadPool* task_pool =
StorageEngine::instance()->get_bg_multiget_threadpool();
Review Comment:
warning: no member named 'get_bg_multiget_threadpool' in
'doris::StorageEngine' [clang-diagnostic-error]
```cpp
ThreadPool* task_pool =
StorageEngine::instance()->get_bg_multiget_threadpool();
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #16632: [improve](dynamic-table) change `addColumns` RPC interface fields fro…
morningman merged PR #16632: URL: https://github.com/apache/doris/pull/16632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [improve](dynamic-table) change `addColumns` RPC interface fields from `required` to `optional` and and config doc (#16632)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4350c98b02 [improve](dynamic-table) change `addColumns` RPC interface
fields from `required` to `optional` and and config doc (#16632)
4350c98b02 is described below
commit 4350c98b02051ac32f567dff19d573f2b385e845
Author: lihangyu <15605149...@163.com>
AuthorDate: Sat Feb 11 20:57:10 2023 +0800
[improve](dynamic-table) change `addColumns` RPC interface fields from
`required` to `optional` and and config doc (#16632)
---
docs/en/docs/admin-manual/config/be-config.md| 5 +
docs/zh-CN/docs/admin-manual/config/be-config.md | 5 +
.../java/org/apache/doris/service/FrontendServiceImpl.java | 10 +++---
gensrc/thrift/FrontendService.thrift | 12 ++--
4 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/docs/en/docs/admin-manual/config/be-config.md
b/docs/en/docs/admin-manual/config/be-config.md
index 14e76bacd7..180e36f5b7 100644
--- a/docs/en/docs/admin-manual/config/be-config.md
+++ b/docs/en/docs/admin-manual/config/be-config.md
@@ -1410,4 +1410,9 @@ Indicates how many tablets failed to load in the data
directory. At the same tim
* Description: Default dirs to put jdbc drivers.
* Default value: `${DORIS_HOME}/jdbc_drivers`
+ `enable_parse_multi_dimession_array`
+
+* Description: Whether parse multidimensional array, if false encountering
will return ERROR
+* Default value: true
+
diff --git a/docs/zh-CN/docs/admin-manual/config/be-config.md
b/docs/zh-CN/docs/admin-manual/config/be-config.md
index 4e93cff62b..734e264b40 100644
--- a/docs/zh-CN/docs/admin-manual/config/be-config.md
+++ b/docs/zh-CN/docs/admin-manual/config/be-config.md
@@ -1428,4 +1428,9 @@ load tablets from header failed, failed tablets size:
xxx, path=xxx
* 描述: 存放 jdbc driver 的默认目录。
* 默认值: `${DORIS_HOME}/jdbc_drivers`
+ `enable_parse_multi_dimession_array`
+
+* 描述: 在动态表中是否解析多维数组，如果是false遇到多维数组则会报错。
+* 默认值: true
+
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
index 0789a2b72c..1e35ca0ecf 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
@@ -255,8 +255,8 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
if (!env.isMaster()) {
status.setStatusCode(TStatusCode.ILLEGAL_STATE);
status.addToErrorMsgs("retry rpc request to master.");
-TAddColumnsResult result = new TAddColumnsResult(status,
request.getTableId(), allColumns, 0);
-LOG.debug("result: {}", result);
+TAddColumnsResult result = new TAddColumnsResult();
+result.setStatus(status);
return result;
}
TableName tableName = new TableName("", request.getDbName(),
request.getTableName());
@@ -378,7 +378,11 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
status.addToErrorMsgs(e.getMessage());
}
-TAddColumnsResult result = new TAddColumnsResult(status,
request.getTableId(), allColumns, schemaVersion);
+TAddColumnsResult result = new TAddColumnsResult();
+result.setStatus(status);
+result.setTableId(request.getTableId());
+result.setAllColumns(allColumns);
+result.setSchemaVersion(schemaVersion);
LOG.debug("result: {}", result);
return result;
}
diff --git a/gensrc/thrift/FrontendService.thrift
b/gensrc/thrift/FrontendService.thrift
index be331f5203..f6cdf61a3a 100644
--- a/gensrc/thrift/FrontendService.thrift
+++ b/gensrc/thrift/FrontendService.thrift
@@ -719,8 +719,8 @@ struct TFetchSchemaTableDataResult {
// Only support base table add columns
struct TAddColumnsRequest {
-1: required i64 table_id
-2: required list addColumns
+1: optional i64 table_id
+2: optional list addColumns
3: optional string table_name
4: optional string db_name
5: optional bool allow_type_conflict
@@ -728,10 +728,10 @@ struct TAddColumnsRequest {
// Only support base table add columns
struct TAddColumnsResult {
-1: required Status.TStatus status
-2: required i64 table_id
-3: required list allColumns
-4: required i32 schema_version
+1: optional Status.TStatus status
+2: optional i64 table_id
+3: optional list allColumns
+4: optional i32 schema_version
}
service FrontendService {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@do
[GitHub] [doris] github-actions[bot] commented on pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on PR #16635: URL: https://github.com/apache/doris/pull/16635#issuecomment-1426770152 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on PR #16635: URL: https://github.com/apache/doris/pull/16635#issuecomment-1426770142 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xutaoustc opened a new issue, #16637: [Feature] support row policy filter for role level
xutaoustc opened a new issue, #16637:
URL: https://github.com/apache/doris/issues/16637
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Description
Currently doris only support create ,drop , show role in user level:
CREATE ROW POLICY test_row_policy_1 ON test.table1
AS {RESTRICTIVE|PERMISSIVE} TO test USING (id in (1, 2));
DROP ROW POLICY test_row_policy_1 on table1 [FOR user];
SHOW ROW POLICY [FOR user]
But it is not convenient and hard to manage if some user share a common row
policy. If Doris could support row policy for role level, it would be helpful
for batch row policy management
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1426774825 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xutaoustc opened a new pull request, #16638: [feature] support row policy filter for role (#16637)
xutaoustc opened a new pull request, #16638: URL: https://github.com/apache/doris/pull/16638 # Proposed changes Issue Number: close #16637 ## Problem summary support row policy filter for role ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [X] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [X] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [X] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [X] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [X No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong closed pull request #16635: [Improvement](brpc) replace brpc bthread with pthread
chenlinzhong closed pull request #16635: [Improvement](brpc) replace brpc bthread with pthread URL: https://github.com/apache/doris/pull/16635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong opened a new pull request, #16639: [Improvement](brpc) replace brpc bthread with pthread
chenlinzhong opened a new pull request, #16639: URL: https://github.com/apache/doris/pull/16639 # Proposed changes Issue Number: close #16634 ## Problem summary mainly include: 1. brpc service adds two types of thread pools. The number of "light" and "heavy" thread pools is different 2. Classify the interfaces of be. Those related to data transmission are classified as heavy interfaces and others as light interfaces 3. Add some monitoring to the thread pool, including the queue size and the number of active threads. Use these indicators to guide the configuration of the number of threads 主要包括 - 1.brpc服务增加2类线程池，"轻","重" 不同线程池的数量配置不一样 - 2.对be的接口进行分类，跟数据传输有关的归类为重接口，其他为轻接口 - 3.增加一些监控，包括be每个接口qps和线程池队列大小、活跃线程个数，根据这些指标来指导线程数的配置 https://user-images.githubusercontent.com/11487604/218252833-b0648a66-c5e3-4cbf-9930-3de5a86cfd08.png";> ## Checklist(Required) 1. Does it affect the original behavior: - [x] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [x] No Need 3. Has document been added or modified: - [ ] Yes - [x] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian opened a new pull request, #16640: [Feature](array-function) Support array functions for nested type dec…
Yukang-Lian opened a new pull request, #16640: URL: https://github.com/apache/doris/pull/16640 …imalv3 - Array functions support nested type decimalv3: * array array_min array_max array_size array_remove array_sort and so on. Signed-off-by: Yukang Lian # Proposed changes Issue Number: close #15954 ## Problem summary ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103645984
##
be/src/service/internal_service.cpp:
##
@@ -247,15 +292,18 @@
const
PTabletWriterCancelRequest* request,
PTabletWriterCancelResult*
response,
google::protobuf::Closure*
done) {
-VLOG_RPC << "tablet writer cancel, id=" << request->id() << ", index_id="
<< request->index_id()
- << ", sender_id=" << request->sender_id();
-brpc::ClosureGuard closure_guard(done);
-auto st = _exec_env->load_channel_mgr()->cancel(*request);
-if (!st.ok()) {
-LOG(WARNING) << "tablet writer cancel failed, id=" << request->id()
- << ", index_id=" << request->index_id()
- << ", sender_id=" << request->sender_id();
-}
+DorisMetrics::instance()->tablet_writer_cancel->increment(1);
+_light_work_pool.offer([this, controller, request, response, done]() {
Review Comment:
warning: lambda capture 'response' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([this, controller, request, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -286,125 +334,134 @@
}
}
-void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
cntl_base,
+void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
controller,
const
PCancelPlanFragmentRequest* request,
PCancelPlanFragmentResult*
result,
google::protobuf::Closure*
done) {
-auto span = telemetry::start_rpc_server_span("exec_plan_fragment_start",
cntl_base);
-auto scope = OpentelemetryScope {span};
-brpc::ClosureGuard closure_guard(done);
-TUniqueId tid;
-tid.__set_hi(request->finst_id().hi());
-tid.__set_lo(request->finst_id().lo());
-
-Status st = Status::OK();
-if (request->has_cancel_reason()) {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid)
- << ", reason: " << request->cancel_reason();
-_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
-} else {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid);
-_exec_env->fragment_mgr()->cancel(tid);
-}
-
-// TODO: the logic seems useless, cancel only return Status::OK. remove it
-st.to_protobuf(result->mutable_status());
+DorisMetrics::instance()->cancel_plan_fragment->increment(1);
+_light_work_pool.offer([this, controller, request, result, done]() {
+auto span =
telemetry::start_rpc_server_span("exec_plan_fragment_start", controller);
+auto scope = OpentelemetryScope {span};
+brpc::ClosureGuard closure_guard(done);
+TUniqueId tid;
+tid.__set_hi(request->finst_id().hi());
+tid.__set_lo(request->finst_id().lo());
+
+Status st = Status::OK();
+if (request->has_cancel_reason()) {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid)
+ << ", reason: " << request->cancel_reason();
+_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
+} else {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid);
+_exec_env->fragment_mgr()->cancel(tid);
+}
+// TODO: the logic seems useless, cancel only return Status::OK.
remove it
+st.to_protobuf(result->mutable_status());
+});
}
-void PInternalServiceImpl::fetch_data(google::protobuf::RpcController*
cntl_base,
+void PInternalServiceImpl::fetch_data(google::protobuf::RpcController*
controller,
const PFetchDataRequest* request,
PFetchDataResult* result,
google::protobuf::Closure* done) {
-brpc::Controller* cntl = static_cast(cntl_base);
-GetResultBatchCtx* ctx = new GetResultBatchCtx(cntl, result, done);
-_exec_env->result_mgr()->fetch_data(request->finst_id(), ctx);
+DorisMetrics::instance()->fetch_data->increment(1);
+_heavy_work_pool.offer([this, controller, request, result, done]() {
+brpc::Controller* cntl = static_cast(controller);
+GetResultBatchCtx* ctx = new GetResultBatchCtx(cntl, result, done);
+_exec_env->result_mgr()->fetch_data(request->finst_id(), ctx);
+});
}
void PInternalServiceImpl::fetch_table_schema(google::protobuf::RpcController*
controller,
const PFetchTableSchemaRequest*
request,
PFetchTableSchemaResult* result,
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103646679
##
be/src/service/internal_service.cpp:
##
@@ -247,15 +292,18 @@
const
PTabletWriterCancelRequest* request,
PTabletWriterCancelResult*
response,
google::protobuf::Closure*
done) {
-VLOG_RPC << "tablet writer cancel, id=" << request->id() << ", index_id="
<< request->index_id()
- << ", sender_id=" << request->sender_id();
-brpc::ClosureGuard closure_guard(done);
-auto st = _exec_env->load_channel_mgr()->cancel(*request);
-if (!st.ok()) {
-LOG(WARNING) << "tablet writer cancel failed, id=" << request->id()
- << ", index_id=" << request->index_id()
- << ", sender_id=" << request->sender_id();
-}
+DorisMetrics::instance()->tablet_writer_cancel->increment(1);
+_light_work_pool.offer([this, controller, request, done]() {
Review Comment:
warning: lambda capture 'response' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([this, controller, request, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -247,15 +292,18 @@ void
PInternalServiceImpl::tablet_writer_cancel(google::protobuf::RpcController*
const
PTabletWriterCancelRequest* request,
PTabletWriterCancelResult*
response,
google::protobuf::Closure*
done) {
-VLOG_RPC << "tablet writer cancel, id=" << request->id() << ", index_id="
<< request->index_id()
- << ", sender_id=" << request->sender_id();
-brpc::ClosureGuard closure_guard(done);
-auto st = _exec_env->load_channel_mgr()->cancel(*request);
-if (!st.ok()) {
-LOG(WARNING) << "tablet writer cancel failed, id=" << request->id()
- << ", index_id=" << request->index_id()
- << ", sender_id=" << request->sender_id();
-}
+DorisMetrics::instance()->tablet_writer_cancel->increment(1);
+_light_work_pool.offer([this, controller, request, done]() {
Review Comment:
warning: lambda capture 'controller' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([this, request, response, done]() {
```
##
be/src/service/internal_service.cpp:
##
@@ -286,125 +334,134 @@
}
}
-void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
cntl_base,
+void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
controller,
const
PCancelPlanFragmentRequest* request,
PCancelPlanFragmentResult*
result,
google::protobuf::Closure*
done) {
-auto span = telemetry::start_rpc_server_span("exec_plan_fragment_start",
cntl_base);
-auto scope = OpentelemetryScope {span};
-brpc::ClosureGuard closure_guard(done);
-TUniqueId tid;
-tid.__set_hi(request->finst_id().hi());
-tid.__set_lo(request->finst_id().lo());
-
-Status st = Status::OK();
-if (request->has_cancel_reason()) {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid)
- << ", reason: " << request->cancel_reason();
-_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
-} else {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid);
-_exec_env->fragment_mgr()->cancel(tid);
-}
-
-// TODO: the logic seems useless, cancel only return Status::OK. remove it
-st.to_protobuf(result->mutable_status());
+DorisMetrics::instance()->cancel_plan_fragment->increment(1);
+_light_work_pool.offer([this, controller, request, result, done]() {
+auto span =
telemetry::start_rpc_server_span("exec_plan_fragment_start", controller);
+auto scope = OpentelemetryScope {span};
+brpc::ClosureGuard closure_guard(done);
+TUniqueId tid;
+tid.__set_hi(request->finst_id().hi());
+tid.__set_lo(request->finst_id().lo());
+
+Status st = Status::OK();
+if (request->has_cancel_reason()) {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid)
+ << ", reason: " << request->cancel_reason();
+_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
+} else {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid);
+_exec_env->fragment_mgr()->cancel(tid);
+}
+// TODO: the logic seems useless, cancel only
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103646730
##
be/src/service/internal_service.cpp:
##
@@ -286,125 +334,134 @@ Status PInternalServiceImpl::_exec_plan_fragment(const
std::string& ser_request,
}
}
-void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
cntl_base,
+void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
controller,
const
PCancelPlanFragmentRequest* request,
PCancelPlanFragmentResult*
result,
google::protobuf::Closure*
done) {
-auto span = telemetry::start_rpc_server_span("exec_plan_fragment_start",
cntl_base);
-auto scope = OpentelemetryScope {span};
-brpc::ClosureGuard closure_guard(done);
-TUniqueId tid;
-tid.__set_hi(request->finst_id().hi());
-tid.__set_lo(request->finst_id().lo());
-
-Status st = Status::OK();
-if (request->has_cancel_reason()) {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid)
- << ", reason: " << request->cancel_reason();
-_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
-} else {
-LOG(INFO) << "cancel fragment, fragment_instance_id=" << print_id(tid);
-_exec_env->fragment_mgr()->cancel(tid);
-}
-
-// TODO: the logic seems useless, cancel only return Status::OK. remove it
-st.to_protobuf(result->mutable_status());
+DorisMetrics::instance()->cancel_plan_fragment->increment(1);
+_light_work_pool.offer([this, controller, request, result, done]() {
+auto span =
telemetry::start_rpc_server_span("exec_plan_fragment_start", controller);
+auto scope = OpentelemetryScope {span};
+brpc::ClosureGuard closure_guard(done);
+TUniqueId tid;
+tid.__set_hi(request->finst_id().hi());
+tid.__set_lo(request->finst_id().lo());
+
+Status st = Status::OK();
+if (request->has_cancel_reason()) {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid)
+ << ", reason: " << request->cancel_reason();
+_exec_env->fragment_mgr()->cancel(tid, request->cancel_reason());
+} else {
+LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid);
+_exec_env->fragment_mgr()->cancel(tid);
+}
+// TODO: the logic seems useless, cancel only return Status::OK.
remove it
+st.to_protobuf(result->mutable_status());
+});
}
-void PInternalServiceImpl::fetch_data(google::protobuf::RpcController*
cntl_base,
+void PInternalServiceImpl::fetch_data(google::protobuf::RpcController*
controller,
const PFetchDataRequest* request,
PFetchDataResult* result,
google::protobuf::Closure* done) {
-brpc::Controller* cntl = static_cast(cntl_base);
-GetResultBatchCtx* ctx = new GetResultBatchCtx(cntl, result, done);
-_exec_env->result_mgr()->fetch_data(request->finst_id(), ctx);
+DorisMetrics::instance()->fetch_data->increment(1);
+_heavy_work_pool.offer([this, controller, request, result, done]() {
+brpc::Controller* cntl = static_cast(controller);
+GetResultBatchCtx* ctx = new GetResultBatchCtx(cntl, result, done);
+_exec_env->result_mgr()->fetch_data(request->finst_id(), ctx);
+});
}
void PInternalServiceImpl::fetch_table_schema(google::protobuf::RpcController*
controller,
const PFetchTableSchemaRequest*
request,
PFetchTableSchemaResult* result,
google::protobuf::Closure* done)
{
-VLOG_RPC << "fetch table schema";
-brpc::ClosureGuard closure_guard(done);
-TFileScanRange file_scan_range;
-Status st = Status::OK();
-{
-const uint8_t* buf = (const
uint8_t*)(request->file_scan_range().data());
-uint32_t len = request->file_scan_range().size();
-st = deserialize_thrift_msg(buf, &len, false, &file_scan_range);
+DorisMetrics::instance()->fetch_table_schema->increment(1);
+_light_work_pool.offer([this, request, result, done]() {
Review Comment:
warning: lambda capture 'this' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([ request, result, done]() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
--
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on code in PR #16639:
URL: https://github.com/apache/doris/pull/16639#discussion_r1103646780
##
be/src/service/internal_service.cpp:
##
@@ -247,15 +292,18 @@ void
PInternalServiceImpl::tablet_writer_cancel(google::protobuf::RpcController*
const
PTabletWriterCancelRequest* request,
PTabletWriterCancelResult*
response,
google::protobuf::Closure*
done) {
-VLOG_RPC << "tablet writer cancel, id=" << request->id() << ", index_id="
<< request->index_id()
- << ", sender_id=" << request->sender_id();
-brpc::ClosureGuard closure_guard(done);
-auto st = _exec_env->load_channel_mgr()->cancel(*request);
-if (!st.ok()) {
-LOG(WARNING) << "tablet writer cancel failed, id=" << request->id()
- << ", index_id=" << request->index_id()
- << ", sender_id=" << request->sender_id();
-}
+DorisMetrics::instance()->tablet_writer_cancel->increment(1);
+_light_work_pool.offer([this, controller, request, done]() {
Review Comment:
warning: lambda capture 'controller' is not used
[clang-diagnostic-unused-lambda-capture]
```suggestion
_light_work_pool.offer([this, request, done]() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue opened a new pull request, #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
ByteYue opened a new pull request, #16641: URL: https://github.com/apache/doris/pull/16641 # Proposed changes Issue Number: close #xxx Currently cooldown's implementation would compare the replica id of the local replica and cooldown_replica_id inside the cooldown conf, unfortunately the `Tablet::revise_tablet_meta` didn't set the right replica id due to the lack of copy of replica id when using copy constructor of tablet meta. Which would end up tablet meta with replica id equals to 0. And the subsequent comparison would fail, neither would the cooldown operation. Plus, this pr add some log for better replica tracing when doing cloning. ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [x] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [x] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
github-actions[bot] commented on PR #16641: URL: https://github.com/apache/doris/pull/16641#issuecomment-1426808096 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
github-actions[bot] commented on PR #16641: URL: https://github.com/apache/doris/pull/16641#issuecomment-1426809325 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
github-actions[bot] commented on PR #16639: URL: https://github.com/apache/doris/pull/16639#issuecomment-1426811566 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16639: [Improvement](brpc) replace brpc bthread with pthread
hello-stephen commented on PR #16639: URL: https://github.com/apache/doris/pull/16639#issuecomment-1426814356 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.68 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230211162649_clickbench_pr_94553.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16641: [Bug](Cooldown) fix load balance causing no cooldown replica
hello-stephen commented on PR #16641: URL: https://github.com/apache/doris/pull/16641#issuecomment-1426823861 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.12 seconds stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230211165631_clickbench_pr_94582.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk opened a new pull request, #16642: [typo](docs)fix the alter frontend statement description
zy-kkk opened a new pull request, #16642: URL: https://github.com/apache/doris/pull/16642 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10802: [enhancement][protocol] support proxy protocol
github-actions[bot] commented on PR #10802: URL: https://github.com/apache/doris/pull/10802#issuecomment-1426904151 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] FreeOnePlus opened a new pull request, #16643: [docs](docs)Fix Docker documentation description
FreeOnePlus opened a new pull request, #16643: URL: https://github.com/apache/doris/pull/16643 # Proposed changes Add computer node interface Remove incorrect description about packaging method ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1426962723 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
