ByteYue opened a new pull request, #16641:
URL: https://github.com/apache/doris/pull/16641

   # Proposed changes
   
   Issue Number: close #xxx
   Currently cooldown's implementation would compare the replica id of the 
local replica and cooldown_replica_id inside the cooldown conf, unfortunately 
the `Tablet::revise_tablet_meta` didn't set the right replica id due to the 
lack of copy of replica id when using copy constructor of tablet meta. Which 
would end up tablet meta with replica id equals to 0. And the subsequent 
comparison would fail, neither would the cooldown operation.
   Plus, this pr add some log for better replica tracing when doing cloning.
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to