[GitHub] [doris] github-actions[bot] commented on pull request #16378: [Feature](Materialized-View) support multiple slot on one column in materialized view
github-actions[bot] commented on PR #16378: URL: https://github.com/apache/doris/pull/16378#issuecomment-1425365141 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15249: [pipeline](test) test regression
github-actions[bot] commented on PR #15249: URL: https://github.com/apache/doris/pull/15249#issuecomment-1425369791 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16466: [Pipeline][WIP] Introduce pipeline tracing
github-actions[bot] commented on PR #16466:
URL: https://github.com/apache/doris/pull/16466#issuecomment-1425374285
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4141986729";) output.
shellcheck errors
```
'shellcheck ' found no issues.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- build.sh.orig
+++ build.sh
@@ -336,7 +336,7 @@
fi
if [[ -z "${ENABLE_QUERY_DEBUG_TRACE}" ]]; then
-ENABLE_QUERY_DEBUG_TRACE='OFF'
+ENABLE_QUERY_DEBUG_TRACE='OFF'
fi
echo "Get params:
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16383: [Improvement](thrift) optimize thrift message
github-actions[bot] commented on PR #16383: URL: https://github.com/apache/doris/pull/16383#issuecomment-1425375052 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz opened a new pull request, #16602: [feature](dlf) add dlf catalog impl for iceberg catalog
wsjz opened a new pull request, #16602: URL: https://github.com/apache/doris/pull/16602 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16601: [fix](planner)fix bug for missing slot
github-actions[bot] commented on PR #16601: URL: https://github.com/apache/doris/pull/16601#issuecomment-1425386811 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16601: [fix](planner)fix bug for missing slot
github-actions[bot] commented on PR #16601: URL: https://github.com/apache/doris/pull/16601#issuecomment-1425386690 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #16496: [bug](jdbc) fix jdbc can't get object of PGobject
morningman merged PR #16496: URL: https://github.com/apache/doris/pull/16496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [bug](jdbc) fix jdbc can't get object of PGobject (#16496)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new b99e2dc727 [bug](jdbc) fix jdbc can't get object of PGobject (#16496)
b99e2dc727 is described below
commit b99e2dc7273d5e8b44cf081106656546ee4802e5
Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>
AuthorDate: Fri Feb 10 16:19:02 2023 +0800
[bug](jdbc) fix jdbc can't get object of PGobject (#16496)
when pg table have some unsupported column type like: point, polygon,
jsonb..
jdbc catalog will convert it to string type in doris. but get result set in
java is org.postgresql.util.PGobject
Some test need this pr: #16442
---
be/src/vec/exec/vjdbc_connector.cpp| 17 +-
be/src/vec/exec/vjdbc_connector.h | 1 +
.../java/org/apache/doris/udf/JdbcExecutor.java| 689 +
.../suites/jdbc_p0/test_jdbc_query_mysql.groovy| 3 +-
.../suites/jdbc_p0/test_jdbc_query_pg.groovy | 3 +-
5 files changed, 590 insertions(+), 123 deletions(-)
diff --git a/be/src/vec/exec/vjdbc_connector.cpp
b/be/src/vec/exec/vjdbc_connector.cpp
index 6a34c0c311..5ded70ed2f 100644
--- a/be/src/vec/exec/vjdbc_connector.cpp
+++ b/be/src/vec/exec/vjdbc_connector.cpp
@@ -460,7 +460,20 @@ Status JdbcConnector::_convert_batch_result_set(JNIEnv*
env, jobject jcolumn_dat
address[1]);
break;
}
-case TYPE_CHAR:
+case TYPE_CHAR: {
+bool need_trim_spaces = false;
+if ((_conn_param.table_type == TOdbcTableType::POSTGRESQL) ||
+(_conn_param.table_type == TOdbcTableType::ORACLE)) {
+need_trim_spaces = true;
+}
+auto column_string =
reinterpret_cast(col_ptr);
+address[1] =
reinterpret_cast(column_string->get_offsets().data());
+auto chars_addres =
reinterpret_cast(&column_string->get_chars());
+env->CallNonvirtualVoidMethod(_executor_obj, _executor_clazz,
_executor_get_char_result,
+ jcolumn_data, column_is_nullable,
num_rows, address[0],
+ address[1], chars_addres,
need_trim_spaces);
+break;
+}
case TYPE_STRING:
case TYPE_VARCHAR: {
auto column_string =
reinterpret_cast(col_ptr);
@@ -591,6 +604,8 @@ Status JdbcConnector::_register_func_id(JNIEnv* env) {
JDBC_EXECUTOR_COPY_BATCH_SIGNATURE,
_executor_get_double_result));
RETURN_IF_ERROR(register_id(_executor_clazz, "copyBatchStringResult",
"(Ljava/lang/Object;ZIJJJ)V",
_executor_get_string_result));
+RETURN_IF_ERROR(register_id(_executor_clazz, "copyBatchCharResult",
+"(Ljava/lang/Object;ZIJJJZ)V",
_executor_get_char_result));
RETURN_IF_ERROR(register_id(_executor_clazz, "copyBatchDateResult",
JDBC_EXECUTOR_COPY_BATCH_SIGNATURE,
_executor_get_date_result));
diff --git a/be/src/vec/exec/vjdbc_connector.h
b/be/src/vec/exec/vjdbc_connector.h
index b7c8b6166a..fecedbb6fc 100644
--- a/be/src/vec/exec/vjdbc_connector.h
+++ b/be/src/vec/exec/vjdbc_connector.h
@@ -127,6 +127,7 @@ private:
jmethodID _executor_get_largeint_result;
jmethodID _executor_get_float_result;
jmethodID _executor_get_double_result;
+jmethodID _executor_get_char_result;
jmethodID _executor_get_string_result;
jmethodID _executor_get_date_result;
jmethodID _executor_get_datev2_result;
diff --git a/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
b/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
index d2bc7d9622..84f766456e 100644
--- a/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
+++ b/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
@@ -57,7 +57,7 @@ public class JdbcExecutor {
private List resultColumnTypeNames = null;
private int baseTypeInt = 0;
private List block = null;
-private int bacthSizeNum = 0;
+private int batchSizeNum = 0;
private int curBlockRows = 0;
private static final byte[] emptyBytes = new byte[0];
private DruidDataSource druidDataSource = null;
@@ -98,14 +98,11 @@ public class JdbcExecutor {
block = new ArrayList<>(columnCount);
for (int i = 0; i < columnCount; ++i) {
resultColumnTypeNames.add(resultSetMetaData.getColumnClassName(i + 1));
-Class clazz =
Class.forName(resultSetMetaData.getColumnClassName(i + 1));
-block.add((Object[]) Array.newInstance(clazz, bacthSizeNum));
+block.add((Object[]) Array.newInstance(Object.class,
batchSizeNum));
}
return columnCount;
} catch (SQLException e)
[GitHub] [doris] yixiutt opened a new pull request, #16603: [regression-test](compaction) add vertical base compaction test
yixiutt opened a new pull request, #16603: URL: https://github.com/apache/doris/pull/16603 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16573: [fix](dlf) Support DLF by catalog properties and update the doc
github-actions[bot] commented on PR #16573: URL: https://github.com/apache/doris/pull/16573#issuecomment-1425402197 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16573: [fix](dlf) Support DLF by catalog properties and update the doc
github-actions[bot] commented on PR #16573: URL: https://github.com/apache/doris/pull/16573#issuecomment-1425402253 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed opened a new issue, #16604: [Bug] Doris 1.1.4 all FE nodes restart failed due to there is a NullPointerException when executing loadJournal
lide-reed opened a new issue, #16604: URL: https://github.com/apache/doris/issues/16604 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version Doris 1.1.4 commit number: 408db56 ### What's Wrong? FE cannot startup and the log as following: `2023-02-09 20:24:22,050 INFO (stateListener|67) [Partition.visualiseShadowIndex():294] visualise the shadow index: 90072650 2023-02-09 20:24:22,050 ERROR (stateListener|67) [EditLog.loadJournal():828] Operation Type 121 java.lang.NullPointerException: null at org.apache.doris.catalog.OlapTable.renameIndexForSchemaChange(OlapTable.java:413) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.alter.SchemaChangeJobV2.onFinished(SchemaChangeJobV2.java:559) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.alter.SchemaChangeJobV2.replayRunningJob(SchemaChangeJobV2.java:720) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.alter.SchemaChangeJobV2.replay(SchemaChangeJobV2.java:755) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.alter.AlterHandler.replayAlterJobV2(AlterHandler.java:250) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.alter.SchemaChangeHandler.replayAlterJobV2(SchemaChangeHandler.java:1913) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:702) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.catalog.Catalog.replayJournal(Catalog.java:2458) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.catalog.Catalog.transferToMaster(Catalog.java:1262) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.catalog.Catalog.access$1200(Catalog.java:300) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.catalog.Catalog$4.runOneCycle(Catalog.java:2375) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.0-SNAPSHOT]` ### What You Expected? FE start successfully ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16593: [fix](test) disable failed ut 'SelectRollupIndexTest#testPreAggHint' temporarily
hello-stephen commented on PR #16593: URL: https://github.com/apache/doris/pull/16593#issuecomment-1425413442 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.45 seconds stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210083317_clickbench_pr_93840.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed commented on issue #16604: [Bug] Doris 1.1.4 all FE nodes restart failed due to there is a NullPointerException when executing loadJournal
lide-reed commented on issue #16604: URL: https://github.com/apache/doris/issues/16604#issuecomment-1425413638 we found alter table statement in audit log: alter table xxx add column c1 varchar(1000) not null default '' comment ''; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed commented on issue #16604: [Bug] Doris 1.1.4 all FE nodes restart failed due to there is a NullPointerException when executing loadJournal
lide-reed commented on issue #16604:
URL: https://github.com/apache/doris/issues/16604#issuecomment-1425414869
It start successfully after made following patch:
`diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
index 60d8c3337..a4f13776b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
@@ -410,8 +410,11 @@ public class OlapTable extends Table {
// this is only for schema change.
public void renameIndexForSchemaChange(String name, String newName) {
-long idxId = indexNameToId.remove(name);
-indexNameToId.put(newName, idxId);
+ if (indexNameToId != null && name != null) {
+long idxId = indexNameToId.remove(name);
+indexNameToId.put(newName, idxId);
+ }
+ LOG.info("indexNameToId="+ indexNameToId + ",name=" + name);
}
public void renameColumnNamePrefix(long idxId) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #16593: [fix](test) disable failed ut 'SelectRollupIndexTest#testPreAggHint' temporarily
morrySnow merged PR #16593: URL: https://github.com/apache/doris/pull/16593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](test) disable failed ut 'SelectRollupIndexTest#testPreAggHint' temporarily (#16593)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c08c643ca0 [fix](test) disable failed ut
'SelectRollupIndexTest#testPreAggHint' temporarily (#16593)
c08c643ca0 is described below
commit c08c643ca0ccac6cf1409db0763185442854d321
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Fri Feb 10 16:36:15 2023 +0800
[fix](test) disable failed ut 'SelectRollupIndexTest#testPreAggHint'
temporarily (#16593)
UT 'SelectRollupIndexTest#testPreAggHint' failed caused by #16286
Disable it temporarily to avoid block CI/CD
---
.../java/org/apache/doris/nereids/rules/mv/SelectRollupIndexTest.java | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectRollupIndexTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectRollupIndexTest.java
index 037242f1e9..8f596b0d18 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectRollupIndexTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/mv/SelectRollupIndexTest.java
@@ -25,6 +25,7 @@ import org.apache.doris.nereids.util.PatternMatchSupported;
import org.apache.doris.nereids.util.PlanChecker;
import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
class SelectRollupIndexTest extends BaseMaterializedIndexSelectTest implements
PatternMatchSupported {
@@ -380,6 +381,7 @@ class SelectRollupIndexTest extends
BaseMaterializedIndexSelectTest implements P
singleTableTest("select v1 from t", "t", false);
}
+@Disabled
@Test
public void testPreAggHint() throws Exception {
createTable(" CREATE TABLE `test_preagg_hint` (\n"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed commented on issue #16604: [Bug] Doris 1.1.4 all FE nodes restart failed due to there is a NullPointerException when executing loadJournal
lide-reed commented on issue #16604:
URL: https://github.com/apache/doris/issues/16604#issuecomment-1425416711
There is a log as following when FE started up successfully
fe.log:431538:2023-02-10 14:30:43,569 INFO (leaderCheckpointer|68)
[OlapTable.renameIndexForSchemaChange():417]
indexNameToId={__doris_shadow_cdp_behavior_stat_user=90072723},name=null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt opened a new pull request, #16605: [bugfix](column_reader) index_page should not be pre-decoded
yixiutt opened a new pull request, #16605:
URL: https://github.com/apache/doris/pull/16605
In our current logic, index page will be pre-decoded but it will return OK
as index page use BinaryPlainPageBuilder and first 4 bytes of the page is a
offset so it's high probablility not equal to EncodingTypePB::DICT_ENCODING
which is 5.
Code in bitshuffle_page_pre_decode.h
```
if constexpr (USED_IN_DICT_ENCODING) {
auto type = decode_fixed32_le((const uint8_t*)&data.data[0]);
if (static_cast(type) !=
EncodingTypePB::DICT_ENCODING) {
return Status::OK();
}
size_of_dict_header = BINARY_DICT_PAGE_HEADER_SIZE;
data.remove_prefix(4);
}
```
But if type just equal to EncodingTypePB::DICT_ENCODING and then it will use
BitShuffle to decode BinaryPlainPage, which will leads to an fatal error.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SaintBacchus commented on a diff in pull request #16483: [Doc](Load)Add mysql load document
SaintBacchus commented on code in PR #16483:
URL: https://github.com/apache/doris/pull/16483#discussion_r1102437099
##
docs/zh-CN/docs/data-operate/import/import-way/mysql-load-manual.md:
##
@@ -0,0 +1,119 @@
+---
+{
+"title": "MySql load",
+"language": "zh-CN"
+}
+---
+
+
+
+
+
+# MySql load
+
+MySql load 是SQL交互的导入方式，用户通过SQL命令将客户端本地或者服务端本地的数据导入Doris 中。
+
+MySql load 同步执行导入并返回导入结果。用户可直接通过SQL返回信息判断本次导入是否成功。
+
+MySql load 主要适用于导入客户端本地文件，或通过程序导入数据流中的数据。
+
+## 基本原理
+
+MySql Load和Stream Load功能相似, 都是导入本地文件到Doris集群中, 因此MySQL
Load实现复用了StreamLoad的基础导入能力:
+
+1. FE接收到客户端执行的MySQL Load请求, 完成SQL解析工作
+
+2. FE将Load请求拆解,并封装为StreamLoad的请求.
+
+3. FE选择一个BE节点发送StreamLoad请求
+
+4. 发送请求的同时, FE会异步且流式的从MySQL客户端读取本地文件数据, 并实时的发送到StreamLoad的HTTP请求中.
+
+5. MySQL客户端数据传输完毕, FE等待StreamLoad完成, 并展示导入成功或者失败的信息给客户端.
+
+
+## 支持数据格式
+
+MySQL Load 支持数据格式：CSV（文本）。
+
+## 基本操作举例
+
+### 创建测试表
+```sql
+CREATE TABLE testdb.t1 (pk INT, v1 INT SUM) AGGREGATE KEY (pk) DISTRIBUTED BY
hash (pk) PROPERTIES ('replication_num' = '1');
+```
+
+### 导入客户端文件
+假设在客户端本地当前路径上有一个CSV文件, 名为`client_local.csv`, 使用MySQL
LOAD语法讲表导入到测试表`testdb.t1`中.
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded
github-actions[bot] commented on PR #16605: URL: https://github.com/apache/doris/pull/16605#issuecomment-1425422436 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed commented on issue #16604: [Bug] Doris 1.1.4 all FE nodes restart failed due to there is a NullPointerException when executing loadJournal
lide-reed commented on issue #16604: URL: https://github.com/apache/doris/issues/16604#issuecomment-1425422157 @nextdreamblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)Remove user/password in properties for mysql load to avoid double auth.
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1425425067 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16343: [Enhancement](Stmt) Set insert_into timeout session variable separately
github-actions[bot] commented on PR #16343: URL: https://github.com/apache/doris/pull/16343#issuecomment-1425429823 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16494: [fix](sequence-column) MergeIterator does not use the correct seq column for comparison
github-actions[bot] commented on PR #16494: URL: https://github.com/apache/doris/pull/16494#issuecomment-1425433050 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16494: [fix](sequence-column) MergeIterator does not use the correct seq column for comparison
github-actions[bot] commented on PR #16494: URL: https://github.com/apache/doris/pull/16494#issuecomment-1425433140 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W opened a new issue, #16606: [Bug] fragment mgr thread pool中的线程卡住导致线程池满，bthread worker资源耗尽，导致BE出现hang接收不了请求的现象
Tanya-W opened a new issue, #16606:
URL: https://github.com/apache/doris/issues/16606
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
master
### What's Wrong?
# Here are two problem
## one:
- Problem phenomenon:
all thread in fragment thread pool in `VNodeChannel::close_wait` call
`std::this_thread::sleep_for` to wait for finished.
- Problem analysis:
In function `FragmentMgr::_exec_actual` will call `exec_state->execute()`,
but not process its return status, if `_executor.open()` failed, there is no
place to call cancel actively, and in function `FragmentMgr::_exec_actual`
after `exec_state->execute()` erase the `fragment_instance_id` from
`_fragment_map`, leads to also cannot cancel through timeout, when
deconstruction for exec_state, will call `VNodeChannel::close_wait`, and in
this function call `std::this_thread::sleep_for` to wait for finished, but the
variable `_add_batches_finished` and `_cancelled` value is always false because
of executor open failed and not cancel, the thread will hang.
not process error return status, and erase fragment instance id from map
directly:
```
void FragmentMgr::_exec_actual(std::shared_ptr
exec_state, FinishCallback cb) {
...
exec_state->execute();
...
// remove exec state after this fragment finished
{
std::lock_guard lock(_lock);
_fragment_map.erase(exec_state->fragment_instance_id());
...
}
...
}
```
not process error return status, only print warning log:
```
Status FragmentExecState::execute() {
...
{
...
WARN_IF_ERROR(_executor.open(),
strings::Substitute("Got error while opening fragment
$0, query id: $1",
print_id(_fragment_instance_id),
print_id(_query_id)));
...
}
...
return Status::OK();
}
```
```
Status VNodeChannel::close_wait(RuntimeState* state) {
...
// waiting for finished, it may take a long time, so we couldn't set a
timeout
while (!_add_batches_finished && !_cancelled) {
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
...
}
```
## two:
- Problem phenomenon:
bthread workers are exhausted, leads to BE cannot receive new rpc requests,
FE send rpc timeout.
- Problem analysis:
When the brpc request reaches BE `FragmentMgr::exec_plan_fragment`, if the
pthread pool is full, submit thread pool failed, will need bthread to destruct
the local variable `std::shared_ptr exec_state`, and then
`VNodeChannel::close_wait` will be called, but in `VNodeChannel::close_wait`
call `std::this_thread::sleep_for` to wait finish, when the variable
`_add_batches_finished` and `_cancelled` value is always false, the bthread
cannot switch out in time, which leads to the exhaustion of the bthread worker,
and finally leads to BE cannot receive new rpc requests.
```
Status VNodeChannel::close_wait(RuntimeState* state) {
...
// waiting for finished, it may take a long time, so we couldn't set a
timeout
while (!_add_batches_finished && !_cancelled) {
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
...
}
```
### What You Expected?
## For problem one:
process the return status for `exec_state->execute()` in function
`FragmentMgr::_exec_actual`
## For problem two:
- define member variable `_cancelled` in FragmentExecState as atomic
- use use bthread_usleep instead of std::this_thread::sleep_for in function
`VNodeChannel::close_wait`
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16089: [enhance](cooldown)accelerate cooldown task produce efficiency
dataroaring merged PR #16089: URL: https://github.com/apache/doris/pull/16089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhance](cooldown)accelerate cooldown task produce efficiency (#16089)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1f631c388d [enhance](cooldown)accelerate cooldown task produce
efficiency (#16089)
1f631c388d is described below
commit 1f631c388ddc6ecbddbf10de50f61d52d69c2932
Author: AlexYue
AuthorDate: Fri Feb 10 16:58:27 2023 +0800
[enhance](cooldown)accelerate cooldown task produce efficiency (#16089)
---
.../exec/schema_scanner/schema_rowsets_scanner.cpp | 9 ---
be/src/http/action/pad_rowset_action.cpp | 1 -
be/src/olap/compaction.cpp | 2 -
be/src/olap/compaction.h | 1 -
be/src/olap/delta_writer.cpp | 1 -
be/src/olap/olap_server.cpp| 64 +-
be/src/olap/push_handler.cpp | 1 -
be/src/olap/rowset/beta_rowset_reader.h| 1 -
be/src/olap/rowset/beta_rowset_writer.cpp | 9 ---
be/src/olap/rowset/rowset.h| 2 +-
be/src/olap/rowset/rowset_meta.h | 6 --
be/src/olap/rowset/rowset_reader.h | 1 -
be/src/olap/rowset/rowset_writer_context.h | 1 -
be/src/olap/schema_change.cpp | 10 +---
be/src/olap/schema_change.h| 7 +--
be/src/olap/snapshot_manager.cpp | 1 -
be/src/olap/storage_engine.h | 3 +-
be/src/olap/tablet.cpp | 20 +--
be/src/olap/tablet_manager.cpp | 56 ++-
be/src/olap/tablet_manager.h | 3 +-
be/src/util/threadpool.cpp | 6 --
be/src/util/threadpool.h | 18 +-
be/test/olap/tablet_test.cpp | 26 +
docs/en/docs/admin-manual/system-table/rowsets.md | 1 -
.../docs/admin-manual/system-table/rowsets.md | 1 -
.../java/org/apache/doris/catalog/SchemaTable.java | 1 -
gensrc/proto/olap_file.proto | 4 +-
27 files changed, 101 insertions(+), 155 deletions(-)
diff --git a/be/src/exec/schema_scanner/schema_rowsets_scanner.cpp
b/be/src/exec/schema_scanner/schema_rowsets_scanner.cpp
index 2744531bd7..5ee608acbb 100644
--- a/be/src/exec/schema_scanner/schema_rowsets_scanner.cpp
+++ b/be/src/exec/schema_scanner/schema_rowsets_scanner.cpp
@@ -44,7 +44,6 @@ std::vector
SchemaRowsetsScanner::_s_tbls_columns = {
{"INDEX_DISK_SIZE", TYPE_BIGINT, sizeof(size_t), true},
{"DATA_DISK_SIZE", TYPE_BIGINT, sizeof(size_t), true},
{"CREATION_TIME", TYPE_BIGINT, sizeof(int64_t), true},
-{"OLDEST_WRITE_TIMESTAMP", TYPE_BIGINT, sizeof(int64_t), true},
{"NEWEST_WRITE_TIMESTAMP", TYPE_BIGINT, sizeof(int64_t), true},
};
@@ -189,14 +188,6 @@ Status
SchemaRowsetsScanner::_fill_block_impl(vectorized::Block* block) {
fill_dest_column(block, &src, _s_tbls_columns[10]);
}
}
-// OLDEST_WRITE_TIMESTAMP
-{
-for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
-RowsetSharedPtr rowset = rowsets_[i];
-size_t src = rowset->oldest_write_timestamp();
-fill_dest_column(block, &src, _s_tbls_columns[11]);
-}
-}
// NEWEST_WRITE_TIMESTAMP
{
for (int i = fill_idx_begin; i < fill_idx_end; ++i) {
diff --git a/be/src/http/action/pad_rowset_action.cpp
b/be/src/http/action/pad_rowset_action.cpp
index 225fec4dd2..c353b4fad7 100644
--- a/be/src/http/action/pad_rowset_action.cpp
+++ b/be/src/http/action/pad_rowset_action.cpp
@@ -91,7 +91,6 @@ Status PadRowsetAction::_pad_rowset(TabletSharedPtr tablet,
const Version& versi
ctx.rowset_state = VISIBLE;
ctx.segments_overlap = NONOVERLAPPING;
ctx.tablet_schema = tablet->tablet_schema();
-ctx.oldest_write_timestamp = UnixSeconds();
ctx.newest_write_timestamp = UnixSeconds();
RETURN_IF_ERROR(tablet->create_rowset_writer(ctx, &writer));
auto rowset = writer->build();
diff --git a/be/src/olap/compaction.cpp b/be/src/olap/compaction.cpp
index e15d263ded..f968f219fe 100644
--- a/be/src/olap/compaction.cpp
+++ b/be/src/olap/compaction.cpp
@@ -184,7 +184,6 @@ void Compaction::build_basic_info() {
_output_version =
Version(_input_rowsets.front()->start_version(),
_input_rowsets.back()->end_version());
-_oldest_write_timestamp = _input_rowsets.front()->oldest_write_timestamp();
_newest_write_timestamp = _input_rowsets.back()->newest_write_timestamp();
std::vector rowset_metas(_input_rowsets.size());
@@ -364,7 +363,6 @@ Status Compaction::construct_output_rowset_writer(bool
is_vertical) {
ctx.rowset_state = VISIBLE;
ctx.segments_overlap = NONOVERLAPPING;
ctx.tablet_schema = _cur_tablet_schema;
-
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded
carlvinhust2012 commented on code in PR #16605:
URL: https://github.com/apache/doris/pull/16605#discussion_r1102461763
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -210,6 +210,10 @@ Status ColumnReader::read_page(const
ColumnIteratorOptions& iter_opts, const Pag
opts.type = iter_opts.type;
opts.encoding_info = _encoding_info;
opts.io_ctx = iter_opts.io_ctx;
+// index page should not pre decode
+if (iter_opts.type == INDEX_PAGE) {
Review Comment:
maybe add some regression test will be more better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded
carlvinhust2012 commented on code in PR #16605:
URL: https://github.com/apache/doris/pull/16605#discussion_r1102461763
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -210,6 +210,10 @@ Status ColumnReader::read_page(const
ColumnIteratorOptions& iter_opts, const Pag
opts.type = iter_opts.type;
opts.encoding_info = _encoding_info;
opts.io_ctx = iter_opts.io_ctx;
+// index page should not pre decode
+if (iter_opts.type == INDEX_PAGE) {
Review Comment:
maybe add some regression test will more better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16603: [regression-test](compaction) add vertical base compaction test
carlvinhust2012 commented on code in PR #16603:
URL: https://github.com/apache/doris/pull/16603#discussion_r1102468609
##
regression-test/suites/compaction/test_vertical_base_compaction.groovy:
##
@@ -0,0 +1,307 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import org.codehaus.groovy.runtime.IOGroovyMethods
+
+suite("test_vertical_base_compaction") {
+def tableName = "base_compaction_regression_test"
+
+def set_be_config = { ->
+String[][] backends = sql """ show backends; """
+assertTrue(backends.size() > 0)
+for (String[] backend in backends) {
+StringBuilder setConfigCommand = new StringBuilder();
+setConfigCommand.append("curl -X POST http://";)
+setConfigCommand.append(backend[2])
+setConfigCommand.append(":")
+setConfigCommand.append(backend[5])
+setConfigCommand.append("/api/update_config?")
+String command1 = setConfigCommand.toString() +
"enable_vertical_compaction=true"
+logger.info(command1)
+def process1 = command1.execute()
+int code = process1.waitFor()
+assertEquals(code, 0)
+}
+}
+def reset_be_config = { ->
+String[][] backends = sql """ show backends; """
+assertTrue(backends.size() > 0)
+for (String[] backend in backends) {
+StringBuilder setConfigCommand = new StringBuilder();
+setConfigCommand.append("curl -X POST http://";)
+setConfigCommand.append(backend[2])
+setConfigCommand.append(":")
+setConfigCommand.append(backend[5])
+setConfigCommand.append("/api/update_config?")
+String command1 = setConfigCommand.toString() +
"enable_vertical_compaction=false"
+logger.info(command1)
+def process1 = command1.execute()
+int code = process1.waitFor()
+assertEquals(code, 0)
+}
+}
+
+try {
+
//BackendId,Cluster,IP,HeartbeatPort,BePort,HttpPort,BrpcPort,LastStartTime,LastHeartbeat,Alive,SystemDecommissioned,ClusterDecommissioned,TabletNum,DataUsedCapacity,AvailCapacity,TotalCapacity,UsedPct,MaxDiskUsedPct,Tag,ErrMsg,Version,Status
Review Comment:
this line is too long，maybe need line break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengshengjun opened a new pull request, #16607: [fix](engine_clone_task) disable compact when tablet version discontinuous to avoid engine clone task failure
zhengshengjun opened a new pull request, #16607: URL: https://github.com/apache/doris/pull/16607 [fix](engine_clone_task) disable compact when tablet version discontinuous to avoid engine clone task failure Fix the Error case： 1. if a version incomplete tablet's local version: 0-10, 12-12 (missed version 11-11) 2. engine_clone task starts to snapshot and download from src be, the cloned version is 0-12, 13-13 3. During download, local be accept data write and triggered compaction, now the local version is 0-10, 12-15 4. after clone download finished, local version 12-15 report error: version cross src latest(max cloned version 13) the engine clone task failed To solve this, we diable compact when tablet version exist holes 1. after clone download finished： local version :0-10, 12-12, 13-13, 14-14, 15-15 cloned version :0-12, 13-13 2. local repaired result: 0-12, 13-13, 14-14, 15-15 For more details and logs：https://github.com/apache/doris/issues/16424 # Proposed changes Issue Number: close #16424 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [x] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16594: [fix](bthread) fix bthread hang
github-actions[bot] commented on PR #16594: URL: https://github.com/apache/doris/pull/16594#issuecomment-1425461265 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16607: [fix](engine_clone_task) disable compact when tablet version discontinuous to avoid engine clone task failure
github-actions[bot] commented on PR #16607: URL: https://github.com/apache/doris/pull/16607#issuecomment-1425466405 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W opened a new pull request, #16608: [fix](fragment thread) fix thread in fragment thread pool hang
Tanya-W opened a new pull request, #16608: URL: https://github.com/apache/doris/pull/16608 # Proposed changes Issue Number: close `problem one` of https://github.com/apache/doris/issues/16606 ## Problem summary process the return status for `exec_state->execute()` in function `FragmentMgr::_exec_actual` ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hystyle commented on issue #16585: [Bug] 外连es，当查询数据量过大时，连接超时报错
hystyle commented on issue #16585: URL: https://github.com/apache/doris/issues/16585#issuecomment-1425470890 > 看下载使用目录有这样的问题吗？ 好的，感谢，我试试 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang
github-actions[bot] commented on PR #16608: URL: https://github.com/apache/doris/pull/16608#issuecomment-1425473444 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #16522: [feature](docker)Add Doris Docker Build Script
morningman merged PR #16522: URL: https://github.com/apache/doris/pull/16522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](docker)Add Doris Docker Build Script (#16522)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 05103d88b2 [feature](docker)Add Doris Docker Build Script (#16522) 05103d88b2 is described below commit 05103d88b2aa4f20dfc9a33183d016b182295de2 Author: FreeOnePlus <54164178+freeonep...@users.noreply.github.com> AuthorDate: Fri Feb 10 17:18:26 2023 +0800 [feature](docker)Add Doris Docker Build Script (#16522) Add 3FE & 3BE Build Script --- .../docker-compose/3fe_3be/docker-compose.yaml | 137 + .../build-cluster/rum-command/3fe_3be.sh | 92 ++ 2 files changed, 229 insertions(+) diff --git a/docker/runtime/docker-compose-demo/build-cluster/docker-compose/3fe_3be/docker-compose.yaml b/docker/runtime/docker-compose-demo/build-cluster/docker-compose/3fe_3be/docker-compose.yaml new file mode 100644 index 00..629a032d84 --- /dev/null +++ b/docker/runtime/docker-compose-demo/build-cluster/docker-compose/3fe_3be/docker-compose.yaml @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +version: '3' +services: + docker-fe-01: +image: "apache/doris:1.2.1-fe-x86_64" +container_name: "doris-fe-01" +hostname: "fe-01" +environment: + - FE_SERVERS=fe1:172.20.80.2:9010,fe2:172.20.80.3:9010,fe3:172.20.80.4:9010 + - FE_ID=1 +ports: + - 8031:8030 + - 9031:9030 +volumes: + - /data/fe-01/doris-meta:/opt/apache-doris/fe/doris-meta + - /data/fe-01/conf:/opt/apache-doris/fe/conf + - /data/fe-01/log:/opt/apache-doris/fe/log +networks: + doris_net: +ipv4_address: 172.20.80.2 + docker-fe-02: +image: "apache/doris:1.2.1-fe-x86_64" +container_name: "doris-fe-02" +hostname: "fe-02" +environment: + - FE_SERVERS=fe1:172.20.80.2:9010,fe2:172.20.80.3:9010,fe3:172.20.80.4:9010 + - FE_ID=2 +ports: + - 8032:8030 + - 9032:9030 +volumes: + - /data/fe-02/doris-meta:/opt/apache-doris/fe/doris-meta + - /data/fe-02/conf:/opt/apache-doris/fe/conf + - /data/fe-02/log:/opt/apache-doris/fe/log +networks: + doris_net: +ipv4_address: 172.20.80.3 + docker-fe-03: +image: "apache/doris:1.2.1-fe-x86_64" +container_name: "doris-fe-03" +hostname: "fe-03" +environment: + - FE_SERVERS=fe1:172.20.80.2:9010,fe2:172.20.80.3:9010,fe3:172.20.80.4:9010 + - FE_ID=3 +ports: + - 8033:8030 + - 9033:9030 +volumes: + - /data/fe-03/doris-meta:/opt/apache-doris/fe/doris-meta + - /data/fe-03/conf:/opt/apache-doris/fe/conf + - /data/fe-03/log:/opt/apache-doris/fe/log +networks: + doris_net: +ipv4_address: 172.20.80.4 + docker-be-01: +image: "apache/doris:1.2.1-be-x86_64" +container_name: "doris-be-01" +hostname: "be-01" +depends_on: + - docker-fe-01 + - docker-fe-02 + - docker-fe-03 +environment: + - FE_SERVERS=fe1:172.20.80.2:9010,fe2:172.20.80.3:9010,fe3:172.20.80.4:9010 + - BE_ADDR=172.20.80.5:9050 +ports: + - 8041:8040 +volumes: + - /data/be-01/storage:/opt/apache-doris/be/storage + - /data/be-01/conf:/opt/apache-doris/be/conf + - /data/be-01/script:/docker-entrypoint-initdb.d + - /data/be-01/log:/opt/apache-doris/be/log +networks: + doris_net: +ipv4_address: 172.20.80.5 + docker-be-02: +image: "apache/doris:1.2.1-be-x86_64" +container_name: "doris-be-02" +hostname: "be-02" +depends_on: + - docker-fe-01 + - docker-fe-02 + - docker-fe-03 +environment: + - FE_SERVERS=fe1:172.20.80.2:9010,fe2:172.20.80.3:9010,fe3:172.20.80.4:9010 + - BE_ADDR=172.20.80.6:9050 +ports: + - 8042:8040 +volumes: + - /data/be-02/storage:/opt/apache-doris/be/storage + - /data/be-02/conf:/opt/apache-doris/be/conf + - /data/be-02/script:/docker-entrypoint-initdb.d + - /data/be-02/log:/opt/apache-doris/be/log +networks: + doris_net: +ipv4_address: 172.20.80.6 + docker-be-03: +image: "apache/doris:1.2.1-be
[GitHub] [doris] eldenmoon opened a new pull request, #16609: [Bug](point query) make `Tablet::get_rowset` thread safe
eldenmoon opened a new pull request, #16609: URL: https://github.com/apache/doris/pull/16609 `get_rowset` calling from `lookup_row_data` without lock will lead to core dump if _rs_version_map, _stale_rs_version_map changed # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16528: [feature](docker)Refactor Image build script
github-actions[bot] commented on PR #16528: URL: https://github.com/apache/doris/pull/16528#issuecomment-1425474860 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16528: [feature](docker)Refactor Image build script
github-actions[bot] commented on PR #16528: URL: https://github.com/apache/doris/pull/16528#issuecomment-1425474924 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang
github-actions[bot] commented on PR #16608: URL: https://github.com/apache/doris/pull/16608#issuecomment-1425478133 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16609: [Bug](point query) make `Tablet::get_rowset` thread safe
github-actions[bot] commented on PR #16609: URL: https://github.com/apache/doris/pull/16609#issuecomment-1425479979 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue opened a new pull request, #16610: [fix](compaction) if there is a rowset version hole, do not compaction
nextdreamblue opened a new pull request, #16610: URL: https://github.com/apache/doris/pull/16610 Signed-off-by: nextdreamblue # Proposed changes Issue Number: close #16424 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [x] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [x] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16610: [fix](compaction) if there is a rowset version hole, do not compaction
github-actions[bot] commented on PR #16610: URL: https://github.com/apache/doris/pull/16610#issuecomment-1425491028 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16563: [fix](fold_constant) add defer in fold constant to close and open fuzzy
github-actions[bot] commented on PR #16563: URL: https://github.com/apache/doris/pull/16563#issuecomment-1425491571 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16594: [fix](bthread) fix bthread hang
github-actions[bot] commented on PR #16594: URL: https://github.com/apache/doris/pull/16594#issuecomment-1425503804 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly opened a new pull request, #16612: [fix](nereids)make slot binding compatible to original planner
englefly opened a new pull request, #16612: URL: https://github.com/apache/doris/pull/16612 # Proposed changes `SELECT a,2 as a FROM (SELECT '1' as a) b HAVING a=1` in original planner, having clause binding is failed. Make nereids failed too. Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang
github-actions[bot] commented on PR #16608: URL: https://github.com/apache/doris/pull/16608#issuecomment-1425507771 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 opened a new pull request, #16613: [Feature](struct-type) Add implicitly cast for struct-type
xy720 opened a new pull request, #16613:
URL: https://github.com/apache/doris/pull/16613
# Proposed changes
Issue Number: close #16444
## Problem summary
For example, currently not support insert {1, 'a'} into struct
This commit will support implicitly cast the char type in the struct to
varchar.
Add implicitly cast for struct-type.
## Checklist(Required)
1. Does it affect the original behavior:
- [x] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [x] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #16571: [Enchancement](HttpServer) Add http interface authentication
carlvinhust2012 commented on PR #16571: URL: https://github.com/apache/doris/pull/16571#issuecomment-1425519460 maybe add some test case is more better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16598: [improve](topn) seperate multiget rpc to ThreadPool
yiguolei merged PR #16598: URL: https://github.com/apache/doris/pull/16598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (05103d88b2 -> 32188855ef)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 05103d88b2 [feature](docker)Add Doris Docker Build Script (#16522) add 32188855ef [improve](topn) seperate multiget rpc to ThreadPool (#16598) No new revisions were added by this update. Summary of changes: be/src/common/config.h | 3 +++ be/src/olap/olap_server.cpp | 4 be/src/olap/storage_engine.h| 2 ++ be/src/service/internal_service.cpp | 24 4 files changed, 25 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16589: [fix](window function) invalid order_by_start in VAnalyticEvalNode
yiguolei merged PR #16589: URL: https://github.com/apache/doris/pull/16589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](window function) invalid order_by_start in VAnalyticEvalNode (#16589)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 861f31205a [fix](window function) invalid order_by_start in
VAnalyticEvalNode (#16589)
861f31205a is described below
commit 861f31205a86b40f1a43cd2c195917eaeb202969
Author: Jerry Hu
AuthorDate: Fri Feb 10 17:40:40 2023 +0800
[fix](window function) invalid order_by_start in VAnalyticEvalNode (#16589)
---
be/src/vec/exec/vanalytic_eval_node.cpp | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/exec/vanalytic_eval_node.cpp
b/be/src/vec/exec/vanalytic_eval_node.cpp
index e52d835a76..f31fc03daf 100644
--- a/be/src/vec/exec/vanalytic_eval_node.cpp
+++ b/be/src/vec/exec/vanalytic_eval_node.cpp
@@ -468,7 +468,7 @@ BlockRowPos VAnalyticEvalNode::_compare_row_to_find_end(int
idx, BlockRowPos sta
//check whether need get column again, maybe same as first init
// if the start_block_num have move to forword, so need update start block
num and compare it from row_num=0
-if (start_column.get() != start_next_block_column.get()) {
+if (start_block_num != start.block_num) {
start_init_row_num = 0;
start.block_num = start_block_num;
start_column =
_input_blocks[start.block_num].get_by_position(idx).column;
@@ -477,7 +477,7 @@ BlockRowPos VAnalyticEvalNode::_compare_row_to_find_end(int
idx, BlockRowPos sta
int64_t start_pos = start_init_row_num;
int64_t end_pos = _input_blocks[start.block_num].rows() - 1;
//if end_block_num haven't moved, only start_block_num go to the end block
-//so could used the end.row_num for binary search
+//so could use the end.row_num for binary search
if (start.block_num == end.block_num) {
end_pos = end.row_num;
}
@@ -489,7 +489,7 @@ BlockRowPos VAnalyticEvalNode::_compare_row_to_find_end(int
idx, BlockRowPos sta
start_pos = mid_pos + 1;
}
}
-start.row_num = start_pos; //upadte row num, return the find end
+start.row_num = start_pos; //update row num, return the find end
return start;
}
@@ -684,6 +684,12 @@ void VAnalyticEvalNode::_update_order_by_range() {
input_block_first_row_positions[_order_by_start.block_num] +
_order_by_start.row_num;
_order_by_end.pos =
input_block_first_row_positions[_order_by_end.block_num] +
_order_by_end.row_num;
+// `_order_by_end` will be assigned to `_order_by_start` next time,
+// so make it a valid position.
+if (_order_by_end.row_num ==
_input_blocks[_order_by_end.block_num].rows()) {
+_order_by_end.block_num++;
+_order_by_end.row_num = 0;
+}
}
Status VAnalyticEvalNode::_init_result_columns() {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg opened a new pull request, #16614: [improvement](batch size) pass batch size of exec engine to storage engine
jacktengg opened a new pull request, #16614: URL: https://github.com/apache/doris/pull/16614 # Proposed changes Issue Number: close #xxx ## Problem summary Currently batch_size is not passed on to SegmentIterator, the SegmentIterator uses the hard coded value 4096 - 32 as the max row count of a block. This PR pass batch_size on to SegmentIterator. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16610: [fix](compaction) if there is a rowset version hole, do not compaction
github-actions[bot] commented on PR #16610: URL: https://github.com/apache/doris/pull/16610#issuecomment-1425525901 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](sequence-column) MergeIterator does not use the correct seq column for comparison (#16494)
This is an automated email from the ASF dual-hosted git repository.
zhangchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6a5277b391 [fix](sequence-column) MergeIterator does not use the
correct seq column for comparison (#16494)
6a5277b391 is described below
commit 6a5277b391db56a2c9ead685a585f6bd2596e3d3
Author: Xin Liao
AuthorDate: Fri Feb 10 17:51:15 2023 +0800
[fix](sequence-column) MergeIterator does not use the correct seq column
for comparison (#16494)
---
be/src/olap/rowset/beta_rowset_reader.cpp | 11 +++-
.../unique/test_unique_table_new_sequence.out | 66 +++---
.../unique/test_unique_table_sequence.out | 41 +++---
.../data/data_model_p0/unique/unique_key_data1.csv | 8 +--
.../data/data_model_p0/unique/unique_key_data2.csv | 8 +--
.../unique/test_unique_table_new_sequence.groovy | 34 +--
.../unique/test_unique_table_sequence.groovy | 24 ++--
7 files changed, 121 insertions(+), 71 deletions(-)
diff --git a/be/src/olap/rowset/beta_rowset_reader.cpp
b/be/src/olap/rowset/beta_rowset_reader.cpp
index 0852641a03..c060b4c286 100644
--- a/be/src/olap/rowset/beta_rowset_reader.cpp
+++ b/be/src/olap/rowset/beta_rowset_reader.cpp
@@ -205,8 +205,17 @@ Status BetaRowsetReader::init(RowsetReaderContext*
read_context) {
// merge or union segment iterator
RowwiseIterator* final_iterator;
if (read_context->need_ordered_result &&
_rowset->rowset_meta()->is_segments_overlapping()) {
+auto sequence_loc = -1;
+if (read_context->sequence_id_idx != -1) {
+for (size_t loc = 0; loc < read_context->return_columns->size();
loc++) {
+if (read_context->return_columns->at(loc) ==
read_context->sequence_id_idx) {
+sequence_loc = loc;
+break;
+}
+}
+}
final_iterator = vectorized::new_merge_iterator(
-iterators, read_context->sequence_id_idx,
read_context->is_unique,
+iterators, sequence_loc, read_context->is_unique,
read_context->read_orderby_key_reverse,
read_context->merged_rows);
} else {
if (read_context->read_orderby_key_reverse) {
diff --git
a/regression-test/data/data_model_p0/unique/test_unique_table_new_sequence.out
b/regression-test/data/data_model_p0/unique/test_unique_table_new_sequence.out
index 825b7039c1..10a08446c6 100644
---
a/regression-test/data/data_model_p0/unique/test_unique_table_new_sequence.out
+++
b/regression-test/data/data_model_p0/unique/test_unique_table_new_sequence.out
@@ -1,45 +1,47 @@
-- This file is automatically generated. You should know what you did if you
want to edit this
-- !all --
-1 4 11
-2 5 12
-3 6 13
+1 4 11 12 13
+2 5 12 13 14
+3 6 13 14 15
--- !all --
+-- !count --
+3
+
+-- !part --
1 2 15
2 5 12
3 6 13
-- !all --
-1 2 15
-15 8 19
-2 5 12
-3 6 13
+1 2 15 16 17
+2 5 12 13 14
+3 6 13 14 15
+
+-- !count --
+3
+
+-- !part --
+1 10 15
+2 5 14
+3 6 11
-- !all --
-1 10 15 0 15
-15 8 19 0 19
-2 5 14 0 12
-3 6 11 0 13
-
--- !desc --
-k1 INT Yes true\N
-v1 TINYINT Yes false \N REPLACE
-v2 INT Yes false \N REPLACE
-__DORIS_DELETE_SIGN__ TINYINT No false 0 REPLACE
-__DORIS_SEQUENCE_COL__ INT Yes false \N REPLACE
-
--- !desc --
-k1 INT Yes true\N
-v1 TINYINT Yes false \N REPLACE
-vv2INT Yes false \N REPLACE
-__DORIS_DELETE_SIGN__ TINYINT No false 0 REPLACE
-__DORIS_SEQUENCE_COL__ INT Yes false \N REPLACE
+1 10 15 16 17
+2 5 14 13 14
+3 6 11 14 15
+
+-- !count --
+4
+
+-- !part --
+1 10 15
+15 8 19
+2 5 14
+3 6 11
-- !all --
-1 10 15 0 15
-15 8 19 0 19
-2 5 14 0 12
-21 8 22 0 22
-23 9 24 0 24
-3 6 11 0 13
+1 10 15 16 17 0 15
+15 8 19 20 21 0 19
+2 5 14 13 14 0 12
+3 6 11 14 15 0 13
diff --git
a/regression-test/data/data_model_p0/unique/test_unique_table_sequence.out
b/regression-test/data/data_model_p0/unique/test_unique_table_sequence.out
index da9bce4389..603e5b87aa 100644
--- a/r
[GitHub] [doris] zhannngchen closed issue #16495: [Bug] VMergeIteratorContext::compare core dump
zhannngchen closed issue #16495: [Bug] VMergeIteratorContext::compare core dump URL: https://github.com/apache/doris/issues/16495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen merged pull request #16494: [fix](sequence-column) MergeIterator does not use the correct seq column for comparison
zhannngchen merged PR #16494: URL: https://github.com/apache/doris/pull/16494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine
github-actions[bot] commented on PR #16614: URL: https://github.com/apache/doris/pull/16614#issuecomment-1425534256 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] airborne12 opened a new pull request, #16615: [Feature-WIP](inverted index) step 1 for supporting range predicate pushing down to inverted index
airborne12 opened a new pull request, #16615: URL: https://github.com/apache/doris/pull/16615 # Proposed changes Try to push down range predicate(like a>1 and a<5) to inverted index for better index filter performance. ## Problem summary Describe your changes. This is step 1 for "push down range predicate", in this pr, we introduced inverted index iterator evaluate for AndBlockColumnPredicate. And we use col_id_to_predicates to construct per column predicates, We also refact apply_inverted_index in this pr. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengshiJ opened a new pull request, #16616: [Feature](nereids) Support Mark join
zhengshiJ opened a new pull request, #16616: URL: https://github.com/apache/doris/pull/16616 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16615: [Feature-WIP](inverted index) step 1 for supporting range predicate pushing down to inverted index
github-actions[bot] commented on PR #16615: URL: https://github.com/apache/doris/pull/16615#issuecomment-1425539036 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.
dataroaring merged PR #16371: URL: https://github.com/apache/doris/pull/16371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16582: [fix](inverted index) fix array type inverted index query error
dataroaring merged PR #16582: URL: https://github.com/apache/doris/pull/16582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (43eca4f209 -> ad141747b4)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 43eca4f209 [Feature-WIP](inverted index) Implementation for alter inverted index. (#16371) add ad141747b4 [fix](inverted index) fix array type inverted index query error (#16582) No new revisions were added by this update. Summary of changes: be/src/exec/olap_common.h | 2 +- fe/fe-core/src/main/java/org/apache/doris/analysis/MatchPredicate.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16582: [fix](inverted index) fix array type inverted index query error
github-actions[bot] commented on PR #16582: URL: https://github.com/apache/doris/pull/16582#issuecomment-1425540784 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16594: [fix](bthread) fix bthread hang
github-actions[bot] commented on PR #16594: URL: https://github.com/apache/doris/pull/16594#issuecomment-1425542649 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1425542956 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1425545677 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #7723: [Bug] Sometimes Fe send the fragments timeout in high concurrency scenarios
xy720 closed issue #7723: [Bug] Sometimes Fe send the fragments timeout in high concurrency scenarios URL: https://github.com/apache/doris/issues/7723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #3992: [Feature]Support cancel load jobs in batch
xy720 closed issue #3992: [Feature]Support cancel load jobs in batch URL: https://github.com/apache/doris/issues/3992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie opened a new pull request, #16617: ZhangShunjieNet interface
ZashJie opened a new pull request, #16617: URL: https://github.com/apache/doris/pull/16617 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #16601: [fix](planner)fix bug for missing slot
nextdreamblue commented on PR #16601: URL: https://github.com/apache/doris/pull/16601#issuecomment-1425550879 https://github.com/apache/doris/pull/16579 may be this pr can fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16617: ZhangShunjieNet interface
github-actions[bot] commented on PR #16617: URL: https://github.com/apache/doris/pull/16617#issuecomment-1425554179 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1425557451 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-flink-connector] link3280 opened a new issue, #101: [Bug] Dataloss silently during streamload
link3280 opened a new issue, #101: URL: https://github.com/apache/doris-flink-connector/issues/101 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.1.0 ### What's Wrong? We have a job that loads MySQL CDC data into Doris with Doris Flink connector 1.1.0. The Flink logs and metrics show that there are 1464 records written, but Streamload only gets 1463 (verified via Doris select and streamload logs), leaving 1 record missing.   I'm pretty sure there are no other streamloads getting the remaining 1 record. ### What You Expected? No data loss. ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16594: [fix](bthread) fix bthread hang
github-actions[bot] commented on PR #16594: URL: https://github.com/apache/doris/pull/16594#issuecomment-1425558628 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #6255: [Bug] Tablet write batch sometimes has a large delay
xy720 closed issue #6255: [Bug] Tablet write batch sometimes has a large delay URL: https://github.com/apache/doris/issues/6255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on issue #6255: [Bug] Tablet write batch sometimes has a large delay
xy720 commented on issue #6255: URL: https://github.com/apache/doris/issues/6255#issuecomment-1425563202 This issue is related to a disk io problem, not a bug in doris. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou opened a new pull request, #16618: [Enhancement] Organize http documents
yongjinhou opened a new pull request, #16618: URL: https://github.com/apache/doris/pull/16618 # Proposed changes Issue Number: close #15658 ## Problem summary Organize http documents. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [x] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [x] No Need 3. Has document been added or modified: - [x] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [x] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [x] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hf200012 merged pull request #16528: [feature](docker)Refactor Image build script
hf200012 merged PR #16528: URL: https://github.com/apache/doris/pull/16528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](docker)Refactor Image build script (#16528)
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1cc735f20b [feature](docker)Refactor Image build script (#16528)
1cc735f20b is described below
commit 1cc735f20bfd06f5fa1bc22daeeba08a5c01f4af
Author: FreeOnePlus <54164178+freeonep...@users.noreply.github.com>
AuthorDate: Fri Feb 10 18:30:54 2023 +0800
[feature](docker)Refactor Image build script (#16528)
Co-authored-by: Yijia Su
---
docker/runtime/be/Dockerfile | 4 +-
docker/runtime/be/resource/entry_point.sh | 184 ++
docker/runtime/be/resource/init_be.sh | 274 ++
docker/runtime/fe/resource/init_fe.sh | 307 --
4 files changed, 588 insertions(+), 181 deletions(-)
diff --git a/docker/runtime/be/Dockerfile b/docker/runtime/be/Dockerfile
index d4b60eec65..95eda2ca1c 100644
--- a/docker/runtime/be/Dockerfile
+++ b/docker/runtime/be/Dockerfile
@@ -35,6 +35,8 @@ RUN apt-get update && \
mv apache-doris-be-x.x.x-bin-x86_64 /opt/apache-doris/be
ADD resource/init_be.sh /opt/apache-doris/be/bin
+ADD resource/entry_point.sh /usr/local/bin
+RUN chmod 755 /usr/local/bin/entry_point.sh
RUN chmod 755 /opt/apache-doris/be/bin/init_be.sh
-ENTRYPOINT ["/opt/apache-doris/be/bin/init_be.sh"]
+ENTRYPOINT ["bash","entry_point.sh"]
diff --git a/docker/runtime/be/resource/entry_point.sh
b/docker/runtime/be/resource/entry_point.sh
new file mode 100644
index 00..ab2ec6a3d3
--- /dev/null
+++ b/docker/runtime/be/resource/entry_point.sh
@@ -0,0 +1,184 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -eo pipefail
+shopt -s nullglob
+
+# Obtain necessary and basic information to complete initialization
+
+# logging functions
+# usage: doris_[note|warn|error] $log_meg
+#ie: doris_warn "task may be risky!"
+# out: 2023-01-08T19:08:16+08:00 [Warn] [Entrypoint]: task may be risky!
+doris_log() {
+local type="$1"
+shift
+# accept argument string or stdin
+local text="$*"
+if [ "$#" -eq 0 ]; then text="$(cat)"; fi
+local dt="$(date -Iseconds)"
+printf '%s [%s] [Entrypoint]: %s\n' "$dt" "$type" "$text"
+}
+doris_note() {
+doris_log Note "$@"
+}
+doris_warn() {
+doris_log Warn "$@" >&2
+}
+doris_error() {
+doris_log ERROR "$@" >&2
+exit 1
+}
+
+# check to see if this file is being run or sourced from another script
+_is_sourced() {
+[ "${#FUNCNAME[@]}" -ge 2 ] &&
+[ "${FUNCNAME[0]}" = '_is_sourced' ] &&
+[ "${FUNCNAME[1]}" = 'source' ]
+}
+
+docker_setup_env() {
+declare -g DATABASE_ALREADY_EXISTS
+if [ -d "${DORIS_HOME}/be/storage/data" ]; then
+DATABASE_ALREADY_EXISTS='true'
+fi
+}
+
+get_doris_args() {
+local feServerArray=($(echo "${FE_SERVERS}" | awk '{gsub (/,/," "); print
$0}'))
+for i in "${feServerArray[@]}"; do
+val=${i}
+val=${val// /}
+tmpFeId=$(echo "${val}" | awk -F ':' '{ sub(/fe/, ""); sub(/ /, "");
print$1}')
+tmpFeIp=$(echo "${val}" | awk -F ':' '{ sub(/ /, ""); print$2}')
+feIpArray[$tmpFeId]=${tmpFeIp}
+done
+
+declare -g MASTER_FE_IP BE_HOST_IP BE_HEARTBEAT_PORT
+MASTER_FE_IP=${feIpArray[1]}
+doris_note "masterFe = ${MASTER_FE_IP}"
+BE_HOST_IP=$(echo "${BE_ADDR}" | awk -F ':' '{ sub(/ /, ""); print$1}')
+BE_HEARTBEAT_PORT=$(echo "${BE_ADDR}" | awk -F ':' '{ sub(/ /, "");
print$2}')
+doris_note "be_addr = ${BE_HOST_IP}:${BE_HEARTBEAT_PORT}"
+}
+
+# Execute sql script, passed via stdin
+# usage: docker_process_sql [mysql-cli-args]
+#ie: docker_process_sql --database=mydb <<<'INSERT ...'
+#ie: docker_process_sql --database=mydb /dev/null
+}
+
+check_be_status() {
+set +e
+local is_fe_start=false
+for i in {1..300}; do
+if [[ $(($i % 20)) == 1 ]]; then
+doris_warn "start check be status~"
+fi
+docker_process_sql <<<"show backends;" | grep
"[[:space:]]${BE_HOST_IP}[[:space:]]" | grep
"[[:space:]]${BE_HEARTBEAT_PORT}[[:space:]]" | grep "[[:space:]]true[[:spa
[GitHub] [doris] hf200012 commented on pull request #16617: ZhangShunjieNet interface
hf200012 commented on PR #16617: URL: https://github.com/apache/doris/pull/16617#issuecomment-1425588711 title style ：[]() https://doris.apache.org/zh-CN/community/how-to-contribute/commit-format-specification @ZashJie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16343: [Enhancement](Stmt) Set insert_into timeout session variable separately
github-actions[bot] commented on PR #16343: URL: https://github.com/apache/doris/pull/16343#issuecomment-1425605047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16595: [fix](auth)(meta) fix auto info missing when upgrading from 1.1 to 1.2
hello-stephen commented on PR #16595: URL: https://github.com/apache/doris/pull/16595#issuecomment-1425615279 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.03 seconds stream load tsv: 479 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 41 seconds loaded 2358488459 Bytes, about 54 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210104728_clickbench_pr_93686.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine
yiguolei commented on code in PR #16614: URL: https://github.com/apache/doris/pull/16614#discussion_r1102602588 ## be/src/olap/reader.cpp: ## @@ -220,7 +220,6 @@ Status TabletReader::_capture_rs_readers(const ReaderParams& read_params, _reader_context.stats = &_stats; _reader_context.use_page_cache = read_params.use_page_cache; _reader_context.sequence_id_idx = _sequence_col_idx; -_reader_context.batch_size = _batch_size; _reader_context.is_unique = tablet()->keys_type() == UNIQUE_KEYS; Review Comment: Does schema change or compaction already set reader_context.batch_size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on a diff in pull request #16617: ZhangShunjieNet interface
dataroaring commented on code in PR #16617:
URL: https://github.com/apache/doris/pull/16617#discussion_r1102610699
##
be/src/service/backend_options.cpp:
##
@@ -81,15 +84,11 @@ std::string BackendOptions::get_localhost() {
return _s_localhost;
}
-bool BackendOptions::analyze_priority_cidrs() {
-if (config::priority_networks == "") {
-return true;
-}
-LOG(INFO) << "priority cidrs in conf: " << config::priority_networks;
-
+// 解析IP为cidr表达方式
+bool BackendOptions::analyze_cidrs(const std::string & ip) {
Review Comment:
There is no need to modify this function.
##
be/src/service/backend_options.cpp:
##
@@ -101,6 +100,61 @@ bool BackendOptions::analyze_priority_cidrs() {
return true;
}
+
+//从network_interface中获取IP
+bool BackendOptions::analyze_network_interface() {
+if (config::network_interface[0] == "") {
+// 为空，则去分析priority_networks配置值
+return false;
+}
+LOG(INFO) << "network name in conf: " << config::network_interface[0];
+LOG(INFO) << "priority cidrs in conf: " << config::network_interface[1];
+
Review Comment:
Please merge the above 2 LOGS to one, LOG(INFO) << "" << "" <<.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Henry2SS opened a new pull request, #16619: Revert "[Performance] Optimize performance of like expr using strstr()"
Henry2SS opened a new pull request, #16619: URL: https://github.com/apache/doris/pull/16619 Reverts apache/doris#15168 in our case, there are one table named `table_A`, having a column `col_1`. It has value "三星" and "红包". a sql like ``` select `clo_1` from table_A where ... and `clo_1` like '%红包%' ... group by xxx LEFT JOIN (select `col_1` from table_A where ... and `clo_1` like '%红包%' ... group by xxx）on = ``` returns a row that `col_1` == "三星"。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on a diff in pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine
jacktengg commented on code in PR #16614: URL: https://github.com/apache/doris/pull/16614#discussion_r1102618924 ## be/src/olap/reader.cpp: ## @@ -220,7 +220,6 @@ Status TabletReader::_capture_rs_readers(const ReaderParams& read_params, _reader_context.stats = &_stats; _reader_context.use_page_cache = read_params.use_page_cache; _reader_context.sequence_id_idx = _sequence_col_idx; -_reader_context.batch_size = _batch_size; _reader_context.is_unique = tablet()->keys_type() == UNIQUE_KEYS; Review Comment: schema change set it's own batch_size to ALTER_TABLE_BATCH_SIZE. Compaction use the default value of 1024 specified in struct RowsetReaderContext. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang
github-actions[bot] commented on PR #16608: URL: https://github.com/apache/doris/pull/16608#issuecomment-1425639217 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16608: [fix](fragment thread) fix thread in fragment thread pool hang
github-actions[bot] commented on PR #16608: URL: https://github.com/apache/doris/pull/16608#issuecomment-1425639279 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sundy-li opened a new pull request, #16620: fix(be): fix incorrect plus_minus_precision
sundy-li opened a new pull request, #16620: URL: https://github.com/apache/doris/pull/16620 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16614: [improvement](batch size) pass batch size of exec engine to storage engine
github-actions[bot] commented on PR #16614: URL: https://github.com/apache/doris/pull/16614#issuecomment-1425645967 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16620: fix(be): fix incorrect plus_minus_precision
github-actions[bot] commented on PR #16620: URL: https://github.com/apache/doris/pull/16620#issuecomment-1425646396 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16609: [Bug](point query) make `Tablet::get_rowset` thread safe
hello-stephen commented on PR #16609: URL: https://github.com/apache/doris/pull/16609#issuecomment-1425653894 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.47 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210111621_clickbench_pr_93943.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
