dataroaring commented on code in PR #16617:
URL: https://github.com/apache/doris/pull/16617#discussion_r1102610699
##########
be/src/service/backend_options.cpp:
##########
@@ -81,15 +84,11 @@ std::string BackendOptions::get_localhost() {
return _s_localhost;
}
-bool BackendOptions::analyze_priority_cidrs() {
- if (config::priority_networks == "") {
- return true;
- }
- LOG(INFO) << "priority cidrs in conf: " << config::priority_networks;
-
+// 解析IP为cidr表达方式
+bool BackendOptions::analyze_cidrs(const std::string & ip) {
Review Comment:
There is no need to modify this function.
##########
be/src/service/backend_options.cpp:
##########
@@ -101,6 +100,61 @@ bool BackendOptions::analyze_priority_cidrs() {
return true;
}
+
+//从network_interface中获取IP
+bool BackendOptions::analyze_network_interface() {
+ if (config::network_interface[0] == "") {
+ // 为空，则去分析priority_networks配置值
+ return false;
+ }
+ LOG(INFO) << "network name in conf: " << config::network_interface[0];
+ LOG(INFO) << "priority cidrs in conf: " << config::network_interface[1];
+
Review Comment:
Please merge the above 2 LOGS to one, LOG(INFO) << "" << "" <<.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
