[I] Ability to filter who can access a cloudstack resource set (possibly domain or...) based on his IP address besides username-password. [cloudstack]
alsko-icom opened a new issue, #10375: URL: https://github.com/apache/cloudstack/issues/10375 ### The required feature described as a wish As a a Cloudstack admin, who recently implemented v4.20 for the first time, I am wondering if we can filter which IP address/network can access a set of resources, a domain, subdomain, account, anything that you can offer. Can we maybe access a domain or subdomain through a direct URL without typing it on the box underneath the password? This might mean injecting the domain path on the URL. but the actual need is to filter based on source IP, the connection to the end user UI specific dashboard. In other words allow a user to reach a specific domain or set of virtualization resources. Is something like this implemented? Also, is there a guide out there to describe the methods to achive isolation per tenant/customer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
weizhouapache commented on code in PR #9504:
URL: https://github.com/apache/cloudstack/pull/9504#discussion_r1952523968
##
engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql:
##
@@ -37,3 +37,37 @@ WHERE rp.rule = 'quotaStatement'
AND NOT EXISTS(SELECT 1 FROM cloud.role_permissions rp_ WHERE rp.role_id =
rp_.role_id AND rp_.rule = 'quotaCreditsList');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.host', 'last_mgmt_server_id',
'bigint unsigned DEFAULT NULL COMMENT "last management server this host is
connected to" AFTER `mgmt_server_id`');
+
+
+-- Create user token_keypairs table for apikey/secretkey tokens
+CREATE TABLE IF NOT EXISTS `cloud`.`api_keypair` (
+`id` bigint(20) unsigned NOT NULL auto_increment,
+`uuid` varchar(40) UNIQUE NOT NULL,
+`name` varchar(255) NOT NULL,
+`domain_id` bigint(20) unsigned NOT NULL,
+`account_id` bigint(20) unsigned NOT NULL,
+`user_id` bigint(20) unsigned NOT NULL,
+`start_date` datetime,
+`end_date` datetime,
+`description` varchar(100),
+`api_key` varchar(255) NOT NULL,
+`secret_key` varchar(255) NOT NULL,
+`created` datetime NOT NULL,
+`removed` datetime,
+PRIMARY KEY (`id`),
+CONSTRAINT `fk_api_keypair__user_id` FOREIGN KEY(`user_id`) REFERENCES
`cloud`.`user`(`id`),
+CONSTRAINT `fk_api_keypair__account_id` FOREIGN KEY(`account_id`)
REFERENCES `cloud`.`account`(`id`),
+CONSTRAINT `fk_api_keypair__domain_id` FOREIGN KEY(`domain_id`) REFERENCES
`cloud`.`domain`(`id`)
+);
+
+CREATE TABLE IF NOT EXISTS `cloud`.`keypair_permissions` (
Review Comment:
to avoid confusion, may be better to use `api_keypair_permissions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
blueorangutan commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2653542371 [SF] Trillian test result (tid-12376) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57260 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9666-t12376-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 391.36 | test_purge_expunged_vms.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.90 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2653031802 [SF] Trillian test result (tid-12371) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 73763 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10300-t12371-kvm-ubuntu22.zip Smoke tests completed. 136 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.46 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.46 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 30.75 | test_outofbandmanagement.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_12_start_vm_multiple_volumes_allocated | `Error` | 17.04 | test_vm_life_cycle.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 4357.82 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 4358.00 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 3615.20 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
Pearl1594 commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1952556107 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: I like `allow.kvm.host.auto.enable`. I feel the use of disable in the name makes it redundant as it is indicated in the value being set against the global setting. Does that seem alright @nvazquez ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
Pearl1594 commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2653586335 First, I was completely unaware there was a PR that addressed a similar issue, my bad. Secondly, I maybe wrong, but I am not sure if the above mentioned fix, addresses the duplicate names being printed for any resource of list type. Removing the v-if altogether could have a negative impact in which resources that haven't been specifically mentioned in the v-if block may not have any items in the drop down menu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated (5aa79a6e05d -> 4f3e8e8c5a6)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 5aa79a6e05d UI: Add offer ha column to system offerings table (#10297) add 60af31c9c0b Decrypt zone, cluster, storage details for configuration values (#10237) add fa5c11e6b2e UI: list backup offerings by zoneid when assign vm to backup offering (#10217) add c1bc57b844b List default network offerings when multiple physical networks for guest traffic type exists (#10222) add 238d0c5e30a Fix NPE while checking for user data provider (#10255) add 37c29f82eda server: fix snapshot physical size (#10216) add 1b2f6c99985 Hide register template, create/upload volume and create vpc buttons when zone is not created. (#10243) add 55e8eaab89c Linstor: encryption support (#10126) add 90c960eeed9 VPC VR: fix ACL between tier and private gateway (#10268) add df99a294832 linstor: Fix using multiple primary storage with same linstor-controller (#10280) add 802bf5fce7c Revert "server: fix attach uploaded volume (#10267)" (#10323) add a627ab67c29 server: fix pod retrieval during volume attach (#10324) add c09720a19a4 systemvm-registration: update seeded template_store_ref sizes (#10317) add 3337f425ffd Primera pure patches & various small fixes (#10132) add a1117acbdfb List only untagged offerings for Shared networks when tag isn't passed (#10320) add 58a63f64fd6 Fix VMWare leftovers when deleting VM without root disk (#9735) add d453c63848f cleanup VM IP after expunge in redundant VPC (#10183) add d920aba176c server: fix scale vm with same disk offering id (#10235) add d3170bfa165 UI: Fixup missing buttons (#10357) add 4f604c00b65 Support virtio-blk root disk controller (#10229) add aa6c581e405 Add the option to filter by host when retrieving of unregistered VMs (#9925) add ae1d7cc8609 Fix private gateway acl on static routes (#10262) add 4f3e8e8c5a6 Merge branch '4.19' into 4.20 No new revisions were added by this update. Summary of changes: .../cloud/exception/StorageAccessException.java| 4 +- api/src/main/java/com/cloud/storage/Storage.java | 141 ++--- .../org/apache/cloudstack/api/ApiConstants.java| 10 +- .../cloudstack/api/response/HostResponse.java | 8 +- ...egisterVMCommand.java => CleanupVMCommand.java} | 19 +- .../engine/orchestration/VolumeOrchestrator.java | 6 +- .../main/java/com/cloud/dc/ClusterDetailsDao.java | 3 +- .../java/com/cloud/dc/ClusterDetailsDaoImpl.java | 16 +- .../main/java/com/cloud/dc/ClusterDetailsVO.java | 18 +- .../main/java/com/cloud/domain/DomainDetailVO.java | 18 +- .../com/cloud/domain/dao/DomainDetailsDao.java | 5 +- .../com/cloud/domain/dao/DomainDetailsDaoImpl.java | 26 +- .../storage/dao/StoragePoolDetailsDaoImpl.java | 2 +- .../upgrade/SystemVmTemplateRegistration.java | 33 +- .../main/java/com/cloud/user/AccountDetailVO.java | 18 +- .../java/com/cloud/user/AccountDetailsDao.java | 5 +- .../java/com/cloud/user/AccountDetailsDaoImpl.java | 28 +- .../resourcedetail/ResourceDetailsDao.java | 20 +- .../resourcedetail/ResourceDetailsDaoBase.java | 34 +- .../datastore/db/ImageStoreDetailsDaoImpl.java | 10 +- .../datastore/db/PrimaryDataStoreDaoImpl.java | 2 +- .../motion/StorageSystemDataMotionStrategy.java| 15 +- .../storage/volume/VolumeServiceImpl.java | 9 +- .../lifecycle/CloudStackExtendedLifeCycle.java | 21 +- .../lifecycle/registry/RegistryLifecycle.java | 17 +- .../acl/DynamicRoleBasedAPIAccessChecker.java | 4 +- .../kvm/resource/LibvirtComputingResource.java | 5 +- .../hypervisor/kvm/resource/LibvirtVMDef.java | 6 +- ...LibvirtGetUnmanagedInstancesCommandWrapper.java | 5 +- .../kvm/storage/KVMStorageProcessor.java | 51 +- .../kvm/storage/MultipathSCSIAdapterBase.java | 23 + .../kvm/resource/LibvirtComputingResourceTest.java | 10 + .../java/com/cloud/hypervisor/guru/VMwareGuru.java | 8 + .../hypervisor/vmware/VmwareDatacenterService.java | 7 +- .../vmware/manager/VmwareManagerImpl.java | 268 +--- .../hypervisor/vmware/resource/VmwareResource.java | 23 + .../api/command/admin/zone/AddVmwareDcCmd.java | 12 +- .../zone/ImportVsphereStoragePoliciesCmd.java | 13 +- ...wareDcVmsCmd.java => ListVmwareDcHostsCmd.java} | 55 +- .../api/command/admin/zone/ListVmwareDcItems.java | 12 +- .../api/command/admin/zone/ListVmwareDcVmsCmd.java | 52 +- .../api/command/admin/zone/ListVmwareDcsCmd.java | 26 +- .../admin/zone/ListVsphereStoragePoliciesCmd.java | 15 +- ...ListVsphereStoragePolicyCompatiblePoolsCmd.java | 2 +- .../api/command/admin/zone/RemoveVmwareDcCmd.java | 6 +- .../api/command/admin/zone/UpdateVmwareDcCmd.java | 9 +- .../command/admin/zone/Vmwa
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
JoaoJandre merged PR #10341: URL: https://github.com/apache/cloudstack/pull/10341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
blueorangutan commented on PR #10326: URL: https://github.com/apache/cloudstack/pull/10326#issuecomment-2653940037 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
JoaoJandre commented on PR #10326: URL: https://github.com/apache/cloudstack/pull/10326#issuecomment-2653935370 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: UI: Add VM state to Volume list view (#10341)
This is an automated email from the ASF dual-hosted git repository.
joao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 0a92cc03496 UI: Add VM state to Volume list view (#10341)
0a92cc03496 is described below
commit 0a92cc034969e57f2cb76eb8d797d0eec1db1783
Author: Lucas Martins <56271185+lucas-a-mart...@users.noreply.github.com>
AuthorDate: Wed Feb 12 11:50:58 2025 -0300
UI: Add VM state to Volume list view (#10341)
* Add vm state to volume list view
* Change size column order
-
Co-authored-by: Lucas Martins
---
ui/public/locales/en.json| 2 +-
ui/src/components/view/ListView.vue | 3 +++
ui/src/components/widgets/Status.vue | 10 +-
ui/src/config/section/storage.js | 2 +-
4 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index 7fdd8fab414..7bf898f4933 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -2454,7 +2454,7 @@
"label.users": "Users",
"label.usersource": "User type",
"label.using.cli": "Using CLI",
-"label.utilization": "Utilisation",
+"label.utilization": "Utilization",
"label.uuid": "ID",
"label.value": "Value",
"label.vcenter": "VMware datacenter vCenter",
diff --git a/ui/src/components/view/ListView.vue
b/ui/src/components/view/ListView.vue
index a0b304c8148..dedbcbc5561 100644
--- a/ui/src/components/view/ListView.vue
+++ b/ui/src/components/view/ListView.vue
@@ -256,6 +256,9 @@
+
+
+
{{ text }}
diff --git a/ui/src/components/widgets/Status.vue
b/ui/src/components/widgets/Status.vue
index af52de7ceb9..22a8236d6cd 100644
--- a/ui/src/components/widgets/Status.vue
+++ b/ui/src/components/widgets/Status.vue
@@ -44,6 +44,10 @@ export default {
styles: {
type: Object,
default: () => {}
+},
+vmState: {
+ type: Boolean,
+ default: false
}
},
methods: {
@@ -182,7 +186,11 @@ export default {
} else if (this.$route.path === '/vm' ||
this.$route.path.includes('/vm/')) {
result = this.$t('message.vm.state.' + state.toLowerCase())
} else if (this.$route.path === '/volume' ||
this.$route.path.includes('/volume/')) {
-result = this.$t('message.volume.state.' + state.toLowerCase())
+if (this.vmState) {
+ result = this.$t('message.vm.state.' + state.toLowerCase())
+} else {
+ result = this.$t('message.volume.state.' + state.toLowerCase())
+}
} else if (this.$route.path === '/guestnetwork' ||
this.$route.path.includes('/guestnetwork/')) {
result = this.$t('message.guestnetwork.state.' + state.toLowerCase())
} else if (this.$route.path === '/publicip' ||
this.$route.path.includes('/publicip/')) {
diff --git a/ui/src/config/section/storage.js b/ui/src/config/section/storage.js
index e0fa72dff8a..b175f5eee93 100644
--- a/ui/src/config/section/storage.js
+++ b/ui/src/config/section/storage.js
@@ -38,7 +38,7 @@ export default {
}
},
columns: () => {
-const fields = ['name', 'state', 'sizegb', 'type', 'vmname']
+const fields = ['name', 'state', 'sizegb', 'type', 'vmname', 'vmstate']
const metricsFields = ['diskkbsread', 'diskkbswrite', 'diskiopstotal']
if (store.getters.userInfo.roletype === 'Admin') {
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
nvazquez commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1952589943 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: I think the use of disable in the name is not redundant as the functionality is Auto Enabling/Disabling hosts (CloudStack will automatically enable or disable hosts based on the setting value). Maybe `allow.kvm.host.auto.enable.or.disable` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
rg9975 opened a new pull request, #10376:
URL: https://github.com/apache/cloudstack/pull/10376
### Description
Adds use of virsh domifaddr command as first choice for finding the external
DHCP address of a newly provisioned VM. This command returns address
information about all the interfaces when the Qemu OS guest agent is installed
within the VM. When this command fails to find the IP, falls back to original
behavior of looking at OS disk lease files to find the data.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested locally with VM running Qemu guest agent.
How did you try to break this feature and the system with this change?
Tested with VM having guest agent and not having agent for expected
behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch ui-fix-duplicate-list-options updated (2739c0112c5 -> af24029c81c)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch ui-fix-duplicate-list-options in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 2739c0112c5 UI: Fix all list items appearing twice in search view add 536888981f8 Revert "UI: Fix all list items appearing twice in search view" add af24029c81c fix duplicate option names on list filters No new revisions were added by this update. Summary of changes: ui/src/components/view/SearchView.vue | 9 + 1 file changed, 1 insertion(+), 8 deletions(-)
Re: [I] Multiple alerts for HA on VM and host [cloudstack]
btzq commented on issue #10367: URL: https://github.com/apache/cloudstack/issues/10367#issuecomment-2654030164 We actually face this alot too! Ive noticed this but wasnt sure if this was normal. In your test, does CS creating multiple jobs also reduce the likelihood of a sucessful HA? Asking cause we often encounter situations where: - In a large hypervisor, it it dies and HA is started, only a portion if VMs start up normally. The rest fails. - When CS is busy, i encounter situations where a VM starts normally, but CS thinks its timedout, and stops the VM. It causes the VM to flap on and off for 10-15 minutes until it stops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
Pearl1594 commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654038196 Oh, I finally understood what you were trying to convey... I've cherry-picked your commit @bernardodemarco that addressed this issue on main. Thanks. Hope this is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
Pearl1594 commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1952874588 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: ah Ok.. got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
weizhouapache commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654056384 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
blueorangutan commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654057951 @weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch bnr-resource-limits deleted (was 6646d6347ef)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch bnr-resource-limits in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 6646d6347ef remove unused import The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Support multi-scope configuration settings [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2653236865 [SF] Trillian test result (tid-12373) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 78384 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10300-t12373-xcpng82.zip Smoke tests completed. 133 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 193.66 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 186.36 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.27 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.38 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.38 | test_ipv4_routing.py test_01_prepare_and_cancel_maintenance | `Error` | 0.11 | test_ms_maintenance_and_safe_shutdown.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 10.49 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 268.78 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 122.26 | test_nonstrict_affinity_group.py test_02_create_volume | `Error` | 2.19 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 70.31 | test_scale_vm.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.84 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Question on modern Windows hypervisors and windows agent versus external framework. [cloudstack]
alsko-icom commented on issue #10361: URL: https://github.com/apache/cloudstack/issues/10361#issuecomment-2653337928 I went through the article https://cwiki.apache.org/confluence/display/CLOUDSTACK/External+Deployment+Integration+in+CloudStack but I am not sure if any other steps are involved to make this work? can you suggest a high level guide of a few steps how to implement? What would be required on the Windows Hypervisor host? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
GutoVeronezi commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2653416661 Given it is already fixed on `main` since Nov, 2024, (see #9947), we just need to backport it to 4.20. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
nvazquez commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1952472287 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: I agree with @shwstppr, I was personally fine with the setting name but it seems to be a bit confusing for users. What about changing the setting name to: `allow.kvm.host.auto.enable.disable` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
blueorangutan commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654111447 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10365 (QA-JID-550) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch rename-ambiguous-globalsetting updated (544f8d5b208 -> c9a9c4b2c78)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch rename-ambiguous-globalsetting in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 544f8d5b208 Update name and UI dialog box add c9a9c4b2c78 address comments No new revisions were added by this update. Summary of changes: engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql | 2 -- engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql | 2 ++ ui/src/views/infra/HostEnableDisable.vue | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
bernardodemarco commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654089883 @Pearl1594, looks good. Now, we just need to fix the bug present in the first video: https://github.com/user-attachments/assets/8e337680-d0b0-4f6a-9253-fc485592b005 It happens when a domain has accounts within it. To fix it, we should remove the lines 719, 720, 721 and 722 from the following block of code: https://github.com/apache/cloudstack/blob/a7beaaf73b819af51294cc35df0830d2a8a2fbc7/ui/src/components/view/SearchView.vue#L710-L722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Compute offerings problem [cloudstack]
UAnton opened a new issue, #10377:
URL: https://github.com/apache/cloudstack/issues/10377
### problem
All additional "Compute offerings" don't work.
### versions
ACS - 4.20
XCP-NG - 8.2.1
### The steps to reproduce the bug
1. Create a new Compute offering.
2. Deploy a new VM with this offering.
3. Get error:
No destination found for a deployment for VM instance
{"id":98,"instanceName":"i-2-98-VM","type":"User","uuid":"97431f03-2203-40a7-bf37-10b747d3e735"}.
P.S. Standart offerings work fine.
### What to do about it?
What to do about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch rename-ambiguous-globalsetting updated (c9a9c4b2c78 -> 517ba7c1e85)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch rename-ambiguous-globalsetting in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c9a9c4b2c78 address comments add 4c801e24f44 Fix Create dropdown menu not changing language (#10023) add 810c4108c7b engine/schema: Add access modifier to `VolumeVO` (#9394) add 47f60190a92 .github: fix test_certauthority_root in 4.19 (#10037) add 971a5b25ec3 Remove SNI option that is correct as default in _run.sh (#10028) add 9231c1c6ba9 Merge remote-tracking branch 'origin/4.19' into 4.20 add e57a82a4f52 UI: Fixes in the Usage UI (#1) add 48767611546 ui: Allow font-awesome icon usage and optimise icon size inconsistency (#9744) add f9b176744e6 SAML2: add cookie with HttpOnly too #10013 (#10047) add 38c7c6e9865 UI: remove duplicated Instance Name in Public IP details page (#10087) add 14460f49e15 Merge remote-tracking branch 'apache/4.19' into 4.20 add ac19379c967 UI: create VPC network offering with conserve mode (#10082) add a278849507f server: fix typo removeaccessvpn in VirtualRouterElement (#10086) add 8639ba8b013 server: simplify role change validation (#9173) add a2f2e87c120 linstor: improve heartbeat check with also asking linstor (#10105) add b4ad04badfb Allow config drive deletion of migrated VM, on host maintenance (#10045) add a9587bfd2e3 kvm-storage: provide isVMMigrate information to storage plugins (#10093) add 0944fa1c9cf set ulimit for server according to redhat spec (#10040) add 188eacd9eb1 Certificate and VM hostname validation improvements (#10051) add ed1b145a3a0 VR: apply iptables rules when add/remove static routes (#10064) add b7f0aac5194 Merge branch '4.19' into 4.20 add cbac6cc05bd Add ownership selection to VPC form (#10124) add 330ed25a6c1 Support to enable/disable VM High Availability manager and related alerts (#10118) add 32af4a25d01 Update ownership selection component to be language independent (#10052) add 75eda38b6b8 UI: fix cannot open 'Edit tags' modal for static routes (#10065) add 5c01cff3043 VR: fix site-2-site VPN if split connections is enabled (#10067) add 41c27e116c6 Merge release branch 4.19 to 4.20 add 3d0b4fca847 UI: Add cluster arch type to the zone creation wizard (#10080) add d8c321d57ae check tags while fetching storage pool for importing vm (#9764) add 79316450d19 Merge release branch 4.19 to 4.20 add cfafcaeb01b log name change after merge forward add a4224e58ccf Improve logging to include more identifiable information (#9873) add 9bc283e5c26 Introducing granular command timeouts global setting (#9659) add bd488c4bba0 server, plugin: enhance storage stats for IOPS (#10034) add 21416cd4034 Restrict the migration of volumes attached to VMs in Starting state (#9725) add 4f9c3492ec9 Merge release branch 4.19 to 4.20 add ab76d3c9ccb merge errors fixed add afc95f1ccc5 CheckOnHostCommand: add missing timeout setting (#9677) add 7adc7329922 upgrade: consider multiple hypervisors and secondary storages (#10046) add fce77733a5d no retrieval of null hosts (#10175) add 35fe19f096d systemvm: fix keystore is reset when patch a systemvm (#9900) add e2cfddb1b6a Merge branch '4.19' into 4.20 add d9a7b6e511b Rollback of changes with errors during the VM assign (#7061) add cf5bd803110 consider a valid ipv4 address as a validish ipv4 /32 cidr (#10174) add e278bcd08ac [VMware] Consider CD/DVD drive when calculating next free unit number for volume attachment over IDE controller (#9644) add bf1ff10a906 Merge branch '4.19' into 4.20 add 2300c1caa3a Add project-user association normalization script to 4.20.1 upgrade (#10116) add 796bd4f72cc Clean up network permissions on account deletion (#10176) add 9967bb3fe89 fix slider component for global settings of the range type (#10187) add 9f594c96991 Merge branch '4.19' into 4.20 add a163831b7e8 Maintenance mode: Add host to deployment planner avoid list to fix local storage vm migration (#9892) add c5e8f63452a Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering (#9844) add 00c659b7a76 api: fix access for listSystemVmUsageHistory (#10032) add 0b8076c38cf Configure org.eclipse.jetty.server.Request.maxFormKeys from server.properties and increase the default value (#10214) add 70776b067a4 fix listing of VMs by network (#10204) add 1ff68cf9b10 linstor: Fix ZFS snapshot backup (#10219) add 5167c3b613f Merge branch '4.19' into 4.20 add 96b757c35bc packaging: have noarch defined for rpms (#10057) add 7e295ec4e19 [KVM] Add watchdog model none to disable use of watchdogs on KVM agent (#10203) add 91f1adab862 UI: set redundant state as N/A for n
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
Pearl1594 commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2654104543 @nvazquez Apologies for the confusion, I had put the wrong name in the PR description - the global setting name has been renamed to `kvm.host.auto.enable.disable`. I've updated the schema file and fixed merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (0a92cc03496 -> 0dcb8da03a2)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 0a92cc03496 UI: Add VM state to Volume list view (#10341) add c5afee21018 UI improvements (#9773) add 50a54dde5cc Make Description as optional in network acl list (#10343) add 5aa79a6e05d UI: Add offer ha column to system offerings table (#10297) add 60af31c9c0b Decrypt zone, cluster, storage details for configuration values (#10237) add fa5c11e6b2e UI: list backup offerings by zoneid when assign vm to backup offering (#10217) add c1bc57b844b List default network offerings when multiple physical networks for guest traffic type exists (#10222) add 238d0c5e30a Fix NPE while checking for user data provider (#10255) add 37c29f82eda server: fix snapshot physical size (#10216) add 1b2f6c99985 Hide register template, create/upload volume and create vpc buttons when zone is not created. (#10243) add 55e8eaab89c Linstor: encryption support (#10126) add 90c960eeed9 VPC VR: fix ACL between tier and private gateway (#10268) add df99a294832 linstor: Fix using multiple primary storage with same linstor-controller (#10280) add 802bf5fce7c Revert "server: fix attach uploaded volume (#10267)" (#10323) add a627ab67c29 server: fix pod retrieval during volume attach (#10324) add c09720a19a4 systemvm-registration: update seeded template_store_ref sizes (#10317) add 3337f425ffd Primera pure patches & various small fixes (#10132) add a1117acbdfb List only untagged offerings for Shared networks when tag isn't passed (#10320) add 58a63f64fd6 Fix VMWare leftovers when deleting VM without root disk (#9735) add d453c63848f cleanup VM IP after expunge in redundant VPC (#10183) add d920aba176c server: fix scale vm with same disk offering id (#10235) add d3170bfa165 UI: Fixup missing buttons (#10357) add 4f604c00b65 Support virtio-blk root disk controller (#10229) add aa6c581e405 Add the option to filter by host when retrieving of unregistered VMs (#9925) add ae1d7cc8609 Fix private gateway acl on static routes (#10262) add 4f3e8e8c5a6 Merge branch '4.19' into 4.20 add 0dcb8da03a2 Merge branch '4.20' No new revisions were added by this update. Summary of changes: .../cloud/exception/StorageAccessException.java| 4 +- api/src/main/java/com/cloud/storage/Storage.java | 141 ++--- .../org/apache/cloudstack/api/ApiConstants.java| 13 +- .../cloudstack/api/response/HostResponse.java | 8 +- .../api/response/ManagementServerResponse.java | 12 +- ...egisterVMCommand.java => CleanupVMCommand.java} | 19 +- .../engine/orchestration/VolumeOrchestrator.java | 6 +- .../main/java/com/cloud/dc/ClusterDetailsDao.java | 3 +- .../java/com/cloud/dc/ClusterDetailsDaoImpl.java | 16 +- .../main/java/com/cloud/dc/ClusterDetailsVO.java | 18 +- .../main/java/com/cloud/domain/DomainDetailVO.java | 18 +- .../com/cloud/domain/dao/DomainDetailsDao.java | 5 +- .../com/cloud/domain/dao/DomainDetailsDaoImpl.java | 26 +- .../storage/dao/StoragePoolDetailsDaoImpl.java | 2 +- .../upgrade/SystemVmTemplateRegistration.java | 33 +- .../main/java/com/cloud/user/AccountDetailVO.java | 18 +- .../java/com/cloud/user/AccountDetailsDao.java | 5 +- .../java/com/cloud/user/AccountDetailsDaoImpl.java | 28 +- .../resourcedetail/ResourceDetailsDao.java | 20 +- .../resourcedetail/ResourceDetailsDaoBase.java | 34 +- .../datastore/db/ImageStoreDetailsDaoImpl.java | 10 +- .../datastore/db/PrimaryDataStoreDaoImpl.java | 2 +- .../resources/META-INF/db/schema-42000to42010.sql | 8 + .../motion/StorageSystemDataMotionStrategy.java| 15 +- .../storage/volume/VolumeServiceImpl.java | 9 +- .../lifecycle/CloudStackExtendedLifeCycle.java | 21 +- .../lifecycle/registry/RegistryLifecycle.java | 17 +- .../acl/DynamicRoleBasedAPIAccessChecker.java | 4 +- .../kvm/resource/LibvirtComputingResource.java | 5 +- .../hypervisor/kvm/resource/LibvirtVMDef.java | 4 +- ...LibvirtGetUnmanagedInstancesCommandWrapper.java | 5 +- .../kvm/storage/KVMStorageProcessor.java | 51 +- .../kvm/storage/MultipathSCSIAdapterBase.java | 23 + .../kvm/resource/LibvirtComputingResourceTest.java | 10 + .../java/com/cloud/hypervisor/guru/VMwareGuru.java | 8 + .../hypervisor/vmware/VmwareDatacenterService.java | 7 +- .../vmware/manager/VmwareManagerImpl.java | 268 +--- .../hypervisor/vmware/resource/VmwareResource.java | 23 + .../api/command/admin/zone/AddVmwareDcCmd.java | 12 +- .../zone/ImportVsphereStoragePoliciesCmd.java | 13 +- ...wareDcVmsCmd.java => ListVmwareDcHostsCmd.java} | 55 +- .../api/command/admin/zone/ListVmwareDcItems.java | 12 +- .../api/command/admin/zone/ListVmwareDc
Re: [PR] Enable multiple services on configdrive network service provider [cloudstack]
DaanHoogland commented on PR #10372: URL: https://github.com/apache/cloudstack/pull/10372#issuecomment-2654141652 > code lgtm > > @DaanHoogland does 4.19 need this ? it could, but I do not want to block the release for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
weizhouapache commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654151917 @Pearl1594 @bernardodemarco thanks for your discussions. I verified the original issue in the title on QA, it looks ok now  should we merge this PR, address the issue (https://github.com/apache/cloudstack/pull/10365#issuecomment-2654089883) in another PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add IOPS and bytes preset variables to `VOLUME` usage type [cloudstack]
blueorangutan commented on PR #10326: URL: https://github.com/apache/cloudstack/pull/10326#issuecomment-2654158821 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] LinstorStorageAdaptor: fix lint error [cloudstack]
weizhouapache opened a new pull request, #10378:
URL: https://github.com/apache/cloudstack/pull/10378
This is found in some PRs
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:510:
poperties ==> properties
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
bernardodemarco commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654178042 > should we merge this PR, address the issue ([#10365 (comment)](https://github.com/apache/cloudstack/pull/10365#issuecomment-2654089883)) in another PR ? Ok, no problem for me. I'll open a new issue to address this bug and will try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] LinstorStorageAdaptor: fix lint error [cloudstack]
codecov[bot] commented on PR #10378: URL: https://github.com/apache/cloudstack/pull/10378#issuecomment-2654190557 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10378?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`ae1d7cc`)](https://app.codecov.io/gh/apache/cloudstack/commit/ae1d7cc86091ce1612dba9981c01d63544c5c426?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`badda01`)](https://app.codecov.io/gh/apache/cloudstack/commit/badda01c7e0b09fd38883ca4378a6378d0040968?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (ae1d7cc) and HEAD (badda01). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (ae1d7cc) | HEAD (badda01) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10378 +/- ## = - Coverage 15.15%4.29% -10.87% = Files 5413 367 -5046 Lines47467029627 -445043 Branches 57890 5199-52691 = - Hits 71943 1272-70671 + Misses 39468028210 -366470 + Partials 8047 145 -7902 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10378/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10378?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
sonarqubecloud[bot] commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654203568 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10365) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10365&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10365&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10365&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10365&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10365&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10365) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
weizhouapache merged PR #10365: URL: https://github.com/apache/cloudstack/pull/10365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]
weizhouapache commented on PR #10365: URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2654210694 > > should we merge this PR, address the issue ([#10365 (comment)](https://github.com/apache/cloudstack/pull/10365#issuecomment-2654089883)) in another PR ? > > Ok, no problem for me. I'll open a new issue to address this bug and will try to fix it. good, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r74870 - in /dev/cloudstack/4.19.2.0: apache-cloudstack-4.19.2.0-src.tar.bz2 apache-cloudstack-4.19.2.0-src.tar.bz2.asc apache-cloudstack-4.19.2.0-src.tar.bz2.sha512
Author: dahn Date: Wed Feb 12 16:17:10 2025 New Revision: 74870 Log: Committing release candidate artifacts for 4.19.2.0 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 (with props) dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 Removed: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 == Binary file - no diff available. Propchange: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 -- svn:mime-type = application/x-bzip2 Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 == --- dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 (added) +++ dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 Wed Feb 12 16:17:10 2025 @@ -0,0 +1 @@ +f423e6f569ad3cb085f2b5c4b22c0102c748def74dbd6b6f9d4f6eb0bdfbeb480ec4f9ec3733d148ff2e8fecfdd17ba0584d336353ac49f01159b97a6f3f2211 apache-cloudstack-4.19.2.0-src.tar.bz2
svn commit: r74871 - in /dev/cloudstack/4.19.2.0: apache-cloudstack-4.19.2.0-src.tar.bz2 apache-cloudstack-4.19.2.0-src.tar.bz2.asc apache-cloudstack-4.19.2.0-src.tar.bz2.sha512
Author: dahn Date: Wed Feb 12 16:22:59 2025 New Revision: 74871 Log: Committing release candidate artifacts for 4.19.2.0 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 (with props) dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc (with props) dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 == Binary file - no diff available. Propchange: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2 -- svn:mime-type = application/x-bzip2 Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc == Binary file - no diff available. Propchange: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc -- svn:mime-type = application/pgp-signature Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 == --- dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 (added) +++ dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 Wed Feb 12 16:22:59 2025 @@ -0,0 +1 @@ +070056495dbe414778d8635884d7464215e13b6ac87c1e8c4a355a867d28afaab999fb98b74cb7aa714f90487c3dd4a5e471413c2789297f07bbc48168a3fd6b apache-cloudstack-4.19.2.0-src.tar.bz2
Re: [PR] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
sonarqubecloud[bot] commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2655306394 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) **Quality Gate failed** Failed conditions  [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) (required ≥ B) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
harikrishna-patnala opened a new pull request, #10381:
URL: https://github.com/apache/cloudstack/pull/10381
### Description
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
rohityadavcloud merged PR #10332: URL: https://github.com/apache/cloudstack/pull/10332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
blueorangutan commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655668635 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack 4.18 HTTP 503 错误 （MySQL 8.0） [cloudstack]
tomorrrow666 commented on issue #10350: URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2655667227 "Error adding host agent" Could not add host at [http://192.168.1.20] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup keystore on the KVM host: 192.168.1.20 - Failed to setup keystore on the KVM host: 192.168.1.20]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
rohityadavcloud commented on PR #10332: URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2655666947 LGTM, thanks for the PR and testing @sureshanaparti @kiranchavala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
harikrishna-patnala commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655665734 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: Validate the direct downloaded template file format (QCOW2) if the template file exists (#10332)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 8c4a085a16d Validate the direct downloaded template file format
(QCOW2) if the template file exists (#10332)
8c4a085a16d is described below
commit 8c4a085a16d50f13222dd4c6d60731e7bd1e57e0
Author: Suresh Kumar Anaparti
AuthorDate: Thu Feb 13 12:08:57 2025 +0530
Validate the direct downloaded template file format (QCOW2) if the template
file exists (#10332)
* Validate the direct downloaded template file format (QCOW2) if the
template file exists
* string format not required
---
.../com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
index 5e62671dd22..0a2621b7bd4 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
@@ -2472,8 +2472,15 @@ public class KVMStorageProcessor implements
StorageProcessor {
template =
storagePoolMgr.createPhysicalDiskFromDirectDownloadTemplate(tempFilePath,
destTemplatePath, destPool, cmd.getFormat(), cmd.getWaitInMillSeconds());
-String templatePath = template.getPath();
-if (templatePath != null) {
+String templatePath = null;
+if (template != null) {
+templatePath = template.getPath();
+}
+if (StringUtils.isEmpty(templatePath)) {
+logger.warn("Skipped validation whether downloaded file is
QCOW2 for template {}, due to downloaded template path is empty",
template.getName());
+} else if (!new File(templatePath).exists()) {
+logger.warn("Skipped validation whether downloaded file is
QCOW2 for template {}, due to downloaded template path is not valid: {}",
template.getName(), templatePath);
+} else {
try {
Qcow2Inspector.validateQcow2File(templatePath);
} catch (RuntimeException e) {
Re: [PR] 4.19 fix saml account selector [cloudstack]
rohityadavcloud commented on PR #10311: URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2655701140 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
rohityadavcloud commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2655701587 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.19 fix saml account selector [cloudstack]
blueorangutan commented on PR #10311: URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2655702350 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
blueorangutan commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2655702264 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
codecov[bot] commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2655713291 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10376?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`ae1d7cc`)](https://app.codecov.io/gh/apache/cloudstack/commit/ae1d7cc86091ce1612dba9981c01d63544c5c426?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`76b34fb`)](https://app.codecov.io/gh/apache/cloudstack/commit/76b34fb30cd6579301ba3d1dbdee703a291a1b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (ae1d7cc) and HEAD (76b34fb). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (ae1d7cc) | HEAD (76b34fb) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10376 +/- ## = - Coverage 15.15%4.29% -10.87% = Files 5413 367 -5046 Lines47467029627 -445043 Branches 57890 5199-52691 = - Hits 71943 1272-70671 + Misses 39468028210 -366470 + Partials 8047 145 -7902 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10376/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10376?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
abh1sar commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2655411460 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
borisstoyanov closed pull request #10300: Support multi-scope configuration settings URL: https://github.com/apache/cloudstack/pull/10300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
blueorangutan commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655785304 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
harikrishna-patnala commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655468427 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
blueorangutan commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655469521 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
sureshanaparti commented on PR #10332: URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2655484365 > [SF] Trillian test result (tid-12369) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 62950 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12369-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: > > Test Result Time (s)Test File > test_11_isolated_network_with_dynamic_routed_mode `Error` 2.25 test_ipv4_routing.py > test_12_vpc_and_tier_with_dynamic_routed_mode `Error` 2.37 test_ipv4_routing.py > test_12_vpc_and_tier_with_dynamic_routed_mode `Error` 2.37 test_ipv4_routing.py > test_06_purge_expunged_vm_background_task `Failure` 388.54 test_purge_expunged_vms.py > test_12_start_vm_multiple_volumes_allocated`Error` 13.09 test_vm_life_cycle.py these failures are not related to this PR changes, same results in 4.20 health check as well here: https://github.com/apache/cloudstack/pull/10006#issuecomment-2655151510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2655412010 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introducing Storage Access Groups for better management for host and storage connections [cloudstack]
codecov[bot] commented on PR #10381: URL: https://github.com/apache/cloudstack/pull/10381#issuecomment-2655489690 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10381?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 3.98%. Comparing base [(`0dcb8da`)](https://app.codecov.io/gh/apache/cloudstack/commit/0dcb8da03a27fd86414c2bdc6b3abdd6d3ad0e37?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c60b3d7`)](https://app.codecov.io/gh/apache/cloudstack/commit/c60b3d72bf057f6ff72b1a0ebb81fbc31ed764ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (0dcb8da) and HEAD (c60b3d7). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (0dcb8da) | HEAD (c60b3d7) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10381 +/- ## = - Coverage 16.07%3.98% -12.10% = Files 5664 399 -5265 Lines49759932699 -464900 Branches 60214 5784-54430 = - Hits 79983 1302-78681 + Misses 40866631247 -377419 + Partials 8950 150 -8800 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10381/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.98% <ø> (-0.03%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10381?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2655494308 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix npe during start vr edge case [cloudstack]
shwstppr commented on PR #10366: URL: https://github.com/apache/cloudstack/pull/10366#issuecomment-2655514706 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix npe during start vr edge case [cloudstack]
blueorangutan commented on PR #10366: URL: https://github.com/apache/cloudstack/pull/10366#issuecomment-2655516151 @shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
abh1sar commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2655542257 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
blueorangutan commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2655543144 @abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Ubuntu KVM agent installation warnings [cloudstack]
rohityadavcloud opened a new issue, #10379:
URL: https://github.com/apache/cloudstack/issues/10379
### problem
This is seen when installing cloudstack-agent deb pkg on Ubuntu 24.04:
```
Setting up cloudstack-common (4.20.0.0-shapeblue0) ...
Listing '/usr/lib/python3/dist-packages/cloudutils'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/__init__.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/cloudException.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/configFileOps.py'...
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:71:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + ".*"
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:73:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *" + entry.value
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:73:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *" + entry.value
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:76:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *=\ *" + entry.value
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:76:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *=\ *" + entry.value
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:78:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *" + entry.value
/usr/lib/python3/dist-packages/cloudutils/configFileOps.py:78:
SyntaxWarning: invalid escape sequence '\ '
matchString = "^\ *" + entry.name + "\ *" + entry.value
Compiling '/usr/lib/python3/dist-packages/cloudutils/db.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/globalEnv.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/networkConfig.py'...
/usr/lib/python3/dist-packages/cloudutils/networkConfig.py:153:
SyntaxWarning: invalid escape sequence '\ '
m = re.search("addr:(.*)\ *Bcast:(.*)\ *Mask:(.*)", line)
Compiling '/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py'...
Compiling
'/usr/lib/python3/dist-packages/cloudutils/serviceConfigServer.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/syscfg.py'...
Compiling '/usr/lib/python3/dist-packages/cloudutils/utilities.py'...
Processing triggers for initramfs-tools (0.142ubuntu25.1) ...
```
Also installing iptables-persistent removed `cloudstack-agent` package :(
Further on host setup, I saw this in /var/log/cloudstack/agent/setup.log:
```
...
DEBUG:root:Failed to execute:Unit network-manager.service could not be found.
DEBUG:root:execute:route -n|awk '/^0.0.0.0/ {print $2,$8}'
DEBUG:root:list index out of range
File "/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py", line
38, in configuration
result = self.config()
^
File "/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py", line
211, in config
super(networkConfigUbuntu, self).cfgNetwork()
File "/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py", line
108, in cfgNetwork
device = self.netcfg.getDefaultNetwork()
^^^
File "/usr/lib/python3/dist-packages/cloudutils/networkConfig.py", line
51, in getDefaultNetwork
dev = result[1]
~~^^^
```
However, I was able to add the KVM host and it just worked.
### versions
ACS 4.20, with Ubuntu 24.04.1, on ARM64 host, typical adv zone configuration.
### The steps to reproduce the bug
_No response_
### What to do about it?
I'm wondering if these warning had any consequences or worth looking into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
blueorangutan commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2654512999 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Pearl1594 commented on PR #9561: URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2654513954 @vishesh92 could you please fix the merge conflicts. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) annotated tag 4.17.2.0-shapeblue2 deleted (was 65fcd1131d7)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to annotated tag 4.17.2.0-shapeblue2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.17.2.0-shapeblue2 was deleted! *** tag was 65fcd1131d7 This change permanently discards the following revisions: discard 9e006458ebe ui: Fix refresh and re-route behaviour (#7846)
Re: [PR] UI: Show applied search filters [cloudstack]
Pearl1594 commented on PR #9520: URL: https://github.com/apache/cloudstack/pull/9520#issuecomment-2654517683 @vishesh92 Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add cpu speed detection methods [cloudstack]
Pearl1594 commented on PR #9762: URL: https://github.com/apache/cloudstack/pull/9762#issuecomment-2654530206 @BartJM could you rebase this to 4.20. So that we could have this in the 4.20.1 release. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) tag 4.16.1.0-08shapeblue1 deleted (was 0db844f3362)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to tag 4.16.1.0-08shapeblue1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.16.1.0-08shapeblue1 was deleted! *** was 0db844f3362 Backport community fix for #210 (#222) The revisions that were on this tag are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack) tag 4.16.1.0-09shapeblue1 deleted (was 8483e8a77eb)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to tag 4.16.1.0-09shapeblue1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.16.1.0-09shapeblue1 was deleted! *** was 8483e8a77eb Apple FR68: modify "passphrase" column to varchar(255) (#227) The revisions that were on this tag are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack) annotated tag 4.18.0.0-shapeblue1 deleted (was da84290bb92)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to annotated tag 4.18.0.0-shapeblue1 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.18.0.0-shapeblue1 was deleted! *** tag was da84290bb92 This change permanently discards the following revisions: discard f253a2dbc27 server: Add check on host's status while deleting config drive on host cache (#7584)
(cloudstack) annotated tag mytag deleted (was d2086b42cf1)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to annotated tag mytag in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag mytag was deleted! *** tag was d2086b42cf1 This change permanently discards the following revisions: discard c708f5d186a dummy commit
(cloudstack) annotated tag dummy-tag deleted (was 79288772397)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to annotated tag dummy-tag in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag dummy-tag was deleted! *** tag was 79288772397 This change permanently discards the following revisions: discard f432c882791 test commit 2 discard 76a404edbb1 test commit
(cloudstack) tag brphase2-rc2 deleted (was c76c2908e39)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to tag brphase2-rc2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag brphase2-rc2 was deleted! *** was c76c2908e39 Fix CE-298 The revisions that were on this tag are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack) 01/01: Updating pom.xml version numbers for release 4.19.2.0
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19.2.0-RC20250212T1722 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7f0eed39419b6076eed8db39a8cd3be326a49a2d Author: Daan Hoogland AuthorDate: Wed Feb 12 17:22:19 2025 +0100 Updating pom.xml version numbers for release 4.19.2.0 Signed-off-by: Daan Hoogland --- agent/pom.xml | 2 +- api/pom.xml | 2 +- client/pom.xml | 2 +- core/pom.xml| 2 +- debian/changelog| 6 ++ developer/pom.xml | 2 +- engine/api/pom.xml | 2 +- engine/components-api/pom.xml | 2 +- engine/orchestration/pom.xml| 2 +- engine/pom.xml | 2 +- engine/schema/pom.xml | 2 +- engine/service/pom.xml | 2 +- engine/storage/cache/pom.xml| 2 +- engine/storage/configdrive/pom.xml | 2 +- engine/storage/datamotion/pom.xml | 2 +- engine/storage/image/pom.xml| 2 +- engine/storage/integration-test/pom.xml | 2 +- engine/storage/object/pom.xml | 2 +- engine/storage/pom.xml | 2 +- engine/storage/snapshot/pom.xml | 2 +- engine/storage/volume/pom.xml | 2 +- engine/userdata/cloud-init/pom.xml | 2 +- engine/userdata/pom.xml | 2 +- framework/agent-lb/pom.xml | 2 +- framework/ca/pom.xml| 2 +- framework/cluster/pom.xml | 2 +- framework/config/pom.xml| 2 +- framework/db/pom.xml| 2 +- framework/direct-download/pom.xml | 2 +- framework/events/pom.xml| 2 +- framework/ipc/pom.xml | 2 +- framework/jobs/pom.xml | 2 +- framework/managed-context/pom.xml | 2 +- framework/pom.xml | 2 +- framework/quota/pom.xml | 2 +- framework/rest/pom.xml | 2 +- framework/security/pom.xml | 2 +- framework/spring/lifecycle/pom.xml | 2 +- framework/spring/module/pom.xml | 2 +- plugins/acl/dynamic-role-based/pom.xml | 2 +- plugins/acl/project-role-based/pom.xml | 2 +- plugins/acl/static-role-based/pom.xml | 2 +- plugins/affinity-group-processors/explicit-dedication/pom.xml | 2 +- plugins/affinity-group-processors/host-affinity/pom.xml | 2 +- plugins/affinity-group-processors/host-anti-affinity/pom.xml| 2 +- plugins/affinity-group-processors/non-strict-host-affinity/pom.xml | 2 +- .../affinity-group-processors/non-strict-host-anti-affinity/pom.xml | 2 +- plugins/alert-handlers/snmp-alerts/pom.xml | 2 +- plugins/alert-handlers/syslog-alerts/pom.xml| 2 +- plugins/api/discovery/pom.xml | 2 +- plugins/api/rate-limit/pom.xml | 2 +- plugins/api/solidfire-intg-test/pom.xml | 2 +- plugins/api/vmware-sioc/pom.xml | 2 +- plugins/backup/dummy/pom.xml| 2 +- plugins/backup/networker/pom.xml| 2 +- plugins/backup/veeam/pom.xml| 2 +- plugins/ca/root-ca/pom.xml | 2 +- plugins/database/mysql-ha/pom.xml | 2 +- plugins/database/quota/pom.xml | 2 +- plugins/dedicated-resources/pom.xml | 2 +- plugins/deployment-planners
(cloudstack) branch ui-fix-duplicate-list-options deleted (was af24029c81c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch ui-fix-duplicate-list-options in repository https://gitbox.apache.org/repos/asf/cloudstack.git was af24029c81c fix duplicate option names on list filters The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Api keypair restructure [cloudstack]
github-actions[bot] commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2654765524 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2654764032 > I have no issues merging this into 4.20 - though I think it would be ideal in 4.21. ok @Pearl1594 retarget to main/4.21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]
github-actions[bot] commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-2654765374 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM incremental snapshot feature [cloudstack]
github-actions[bot] commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2654765438 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support multi-scope configuration settings [cloudstack]
github-actions[bot] commented on PR #10300: URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2654765587 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support of snapshot copy to StorPool primary storage in different zones [cloudstack]
github-actions[bot] commented on PR #9478: URL: https://github.com/apache/cloudstack/pull/9478#issuecomment-2654765492 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2654764176 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix comparison of Long objects to use primitives [cloudstack]
github-actions[bot] commented on PR #9079: URL: https://github.com/apache/cloudstack/pull/9079#issuecomment-2654765403 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
blueorangutan commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2654768334 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2654959026 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
shwstppr commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1952167700 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: @Pearl1594 maybe @nvazquez can comment but I think global setting is largely okay as it allows enabling or disabling a KVM host based on health check results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
nvazquez commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1953575334 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -28,15 +28,15 @@ > - + - +
Re: [PR] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
nvazquez commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1953579963 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -28,15 +28,15 @@ > - + - +
Re: [PR] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
Pearl1594 commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1953650212 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -28,15 +28,15 @@ > - + - +
(cloudstack) branch rename-ambiguous-globalsetting updated (517ba7c1e85 -> cf66aa2baf1)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch rename-ambiguous-globalsetting in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 517ba7c1e85 Merge branch '4.20' of https://github.com/apache/cloudstack into rename-ambiguous-globalsetting add cf66aa2baf1 Do not rename the setting No new revisions were added by this update. Summary of changes: .../src/main/java/com/cloud/agent/AgentManager.java | 4 ++-- .../main/java/com/cloud/agent/manager/AgentManagerImpl.java | 6 +++--- .../src/main/resources/META-INF/db/schema-42000to42010.sql | 2 -- .../main/java/com/cloud/resource/ResourceManagerImpl.java| 12 ++-- ui/src/views/infra/HostEnableDisable.vue | 2 +- 5 files changed, 12 insertions(+), 14 deletions(-)
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2655151510 [SF] Trillian test result (tid-12377) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57237 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10006-t12377-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.30 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.48 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.48 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 381.38 | test_purge_expunged_vms.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.84 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: UI: Fix all list items appearing twice in search view (#10365)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 59e054396a8 UI: Fix all list items appearing twice in search view
(#10365)
59e054396a8 is described below
commit 59e054396a8f23ed003ff276c784adc2ab1e1a92
Author: Pearl Dsilva
AuthorDate: Wed Feb 12 11:18:14 2025 -0500
UI: Fix all list items appearing twice in search view (#10365)
* UI: Fix all list items appearing twice in search view
* Revert "UI: Fix all list items appearing twice in search view"
This reverts commit 2739c0112c519406cc46394948fcad6020bcdb62.
* fix duplicate option names on list filters
-
Co-authored-by: Bernardo De Marco Gonçalves
---
ui/src/components/view/SearchView.vue | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/ui/src/components/view/SearchView.vue
b/ui/src/components/view/SearchView.vue
index d8cdf078e5c..d0e962c58e5 100644
--- a/ui/src/components/view/SearchView.vue
+++ b/ui/src/components/view/SearchView.vue
@@ -80,7 +80,7 @@
-
+
@@ -90,13 +90,6 @@
{{ $t((['storageid'].includes(field.name) ||
!opt.path) ? opt.name : opt.path) }}
-
-
-
-
-
-
-{{ $t(opt.path || opt.name) }}
Re: [PR] Make isAccountAllowedToCreateOfferingsWithTags API id parameter required [cloudstack]
blueorangutan commented on PR #10338: URL: https://github.com/apache/cloudstack/pull/10338#issuecomment-2654281937 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
