Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2644483554 [SF] Trillian test result (tid-12341) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48882 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10235-t12341-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_10_attachAndDetach_iso | `Error` | 12.60 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2644499506 [SF] Trillian test result (tid-12344) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 51406 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9925-t12344-kvm-ubuntu22.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Issue with VM Creation When Associating a New Network in Apache CloudStack 4.19.1.2 [cloudstack]
pankajfromcomhard closed issue #10345: Issue with VM Creation When Associating a New Network in Apache CloudStack 4.19.1.2 URL: https://github.com/apache/cloudstack/issues/10345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix private gateway acl on static routes [cloudstack]
blueorangutan commented on PR #10262: URL: https://github.com/apache/cloudstack/pull/10262#issuecomment-2644512764 [SF] Trillian test result (tid-12347) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53108 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10262-t12347-kvm-ol8.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_secure_vm_migration | `Error` | 326.77 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 3739.89 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 395.59 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 350.28 | test_vm_life_cycle.py test_04_deploy_vnf_appliance | `Error` | 143.70 | test_vnf_templates.py test_04_deploy_vnf_appliance | `Error` | 143.70 | test_vnf_templates.py test_05_delete_vnf_template | `Error` | 1.12 | test_vnf_templates.py ContextSuite context=TestVnfTemplates>:teardown | `Error` | 2.28 | test_vnf_templates.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
blueorangutan commented on PR #10183: URL: https://github.com/apache/cloudstack/pull/10183#issuecomment-2644136218 [SF] Trillian test result (tid-12338) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 43949 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10183-t12338-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
vishesh92 commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2644136653 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Cloudstack 4.18 HTTP 503 错误 （MySQL 8.0） [cloudstack]
tomorrrow666 opened a new issue, #10350: URL: https://github.com/apache/cloudstack/issues/10350 The operating system is Ubuntu 22.04, and the MySQL version is 8.0.41-0ubuntu0.22.04.1. idrl@management1:~$ sudo tail -F /var/log/cloudstack/management/management-server.log 2025-02-08 10:33:37,238 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Module Hierarchy: redfish 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-config-system-context.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-server-system-context.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-core-system-context.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-db-system-context.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-engine-schema-system-checkers-context.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-config-system-context-inheritable.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-core-system-context-inheritable.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-contrail-system-context-inheritable.xml] 2025-02-08 10:33:37,239 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack 4.18 HTTP 503 错误 （MySQL 8.0） [cloudstack]
boring-cyborg[bot] commented on issue #10350: URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-266512 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Unable to update the security groups of a VM [cloudstack]
eduardovra opened a new issue, #10347: URL: https://github.com/apache/cloudstack/issues/10347 ### problem I'm using the newly released feature that allows enabling security groups support in advanced zones, and I'm unable to change the security groups assigned to VMs in my shared network. This is the error returned: ``` (dev) 🐱 > update virtualmachine id=450bbfd5-55a7-44d3-966b-99772d50a405 securitygroupnames=default 🙈 Error: (HTTP 530, error code ) Cannot invoke "com.cloud.network.Network.getTrafficType()" because "network" is null ``` The problem seems to be related to a permissions check, it's possible to go around that error by manually inserting a record into the `network_permissions` table. ``` (dev) 🐱 > create networkpermissions accountids=7ad6fcd9-bb8b-48e0-83eb-01263c2907c6 networkid=aa67cbd3-4aae-4b7c-87cb-51b1f0605d8e 🙈 Error: (HTTP 431, error code 4350) network is already shared in domain ``` ``` MariaDB [cloud]> insert into network_permissions (network_id, account_id) values (228,2319); Query OK, 1 row affected (0.003 sec) ``` After this, the `update virtualmachine` call works and the SG is updated normally. Code reference: https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/network/NetworkModelImpl.java#L1727 ### versions Cloudstack 4.20. ### The steps to reproduce the bug 1. Enable security groups support in an advanced zone 2. Create a shared network that is accessible to all accounts (selected scope is ALL), the network offering selected enables SGs. 3. Stop a VM and try to change the security groups either using the UI or API, both won't work ### What to do about it? _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack 4.18 HTTP 503 Error on Ubuntu 22.04 [cloudstack]
tomorrrow666 commented on issue #7533: URL: https://github.com/apache/cloudstack/issues/7533#issuecomment-2644423217 HTTP ERROR 503 Service Unavailable The operating system is Ubuntu 22.04, and the MySQL version is 8.0.41-0ubuntu0.22.04.1. idrl@management1:~$ sudo tail -F /var/log/cloudstack/management/management-server.log [sudo] idrl 的密码： 2025-02-08 09:16:06,769 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Module Hierarchy: redfish 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-config-system-context.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-server-system-context.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-core-system-context.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-db-system-context.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-engine-schema-system-checkers-context.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-framework-config-system-context-inheritable.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-core-system-context-inheritable.xml] 2025-02-08 09:16:06,770 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/system/spring-contrail-system-context-inheritable.xml] 2025-02-08 09:16:06,771 INFO [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [system] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.18.2.5.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
blueorangutan commented on PR #10332: URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2644430193 [SF] Trillian test result (tid-12339) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57382 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12339-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.35 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.36 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 382.78 | test_purge_expunged_vms.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.88 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Unable to update the security groups of a VM [cloudstack]
eduardovra opened a new issue, #10348: URL: https://github.com/apache/cloudstack/issues/10348 ### problem I'm using the newly released feature that allows enabling security groups support in advanced zones, and I'm unable to change the security groups assigned to VMs in my shared network. This is the error returned: ``` (dev) 🐱 > update virtualmachine id=450bbfd5-55a7-44d3-966b-99772d50a405 securitygroupnames=default 🙈 Error: (HTTP 530, error code ) Cannot invoke "com.cloud.network.Network.getTrafficType()" because "network" is null ``` The problem seems to be related to a permissions check, it's possible to go around that error by manually inserting a record into the `network_permissions` table. ``` (dev) 🐱 > create networkpermissions accountids=7ad6fcd9-bb8b-48e0-83eb-01263c2907c6 networkid=aa67cbd3-4aae-4b7c-87cb-51b1f0605d8e 🙈 Error: (HTTP 431, error code 4350) network is already shared in domain ``` ``` MariaDB [cloud]> insert into network_permissions (network_id, account_id) values (228,2319); Query OK, 1 row affected (0.003 sec) ``` After this, the `update virtualmachine` call works and the SG is updated normally. Code reference: https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/network/NetworkModelImpl.java#L1727 ### versions Cloudstack 4.20. ### The steps to reproduce the bug 1. Enable security groups support in an advanced zone 2. Create a shared network that is accessible to all accounts (selected scope is ALL), the network offering selected enables SGs. 3. Stop a VM and try to change the security groups either using the UI or API, both won't work ### What to do about it? _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2644140346 @vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
lucas-a-martins commented on code in PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#discussion_r1946929673 ## ui/public/locales/en.json: ## @@ -2444,7 +2444,7 @@ "label.users": "Users", "label.usersource": "User type", "label.using.cli": "Using CLI", -"label.utilization": "Utilisation", +"label.utilization": "Utilization", Review Comment: The label is `utilization` with z, so I thought it was a typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2643619112 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2643623773 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make isAccountAllowedToCreateOfferingsWithTags API id parameter required [cloudstack]
DaanHoogland commented on PR #10338: URL: https://github.com/apache/cloudstack/pull/10338#issuecomment-2643624087 > @DaanHoogland could we run the CI here? yes, but I'll run the last 4.19.2 tests first. hopefully end of the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2644459584 [SF] Trillian test result (tid-12343) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 45678 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9925-t12343-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2644550286 [SF] Trillian test result (tid-12349) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 43927 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12349-kvm-ol8.zip Smoke tests completed. 128 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_ping_in_ssvm_success | `Failure` | 14.57 | test_diagnostics.py test_05_ping_in_cpvm_success | `Failure` | 14.57 | test_diagnostics.py test_04_deploy_vnf_appliance | `Error` | 312.03 | test_vnf_templates.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
li-liwen commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2644535250 I got it. Thanks for helping. I would just leave them inactive for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
lucas-a-martins commented on code in PR #10341:
URL: https://github.com/apache/cloudstack/pull/10341#discussion_r1947145291
##
ui/src/config/section/storage.js:
##
@@ -38,7 +38,7 @@ export default {
}
},
columns: () => {
-const fields = ['name', 'state', 'sizegb', 'type', 'vmname']
+const fields = ['name', 'state', 'type', 'vmname', 'vmstate', 'sizegb']
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix lint error coming up in main [cloudstack]
DaanHoogland merged PR #10342: URL: https://github.com/apache/cloudstack/pull/10342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Fix lint error coming up in main (#10342)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 648170cf9bb Fix lint error coming up in main (#10342)
648170cf9bb is described below
commit 648170cf9bb1dea924d40d6ba35cd0eebeccac5e
Author: Manoj Kumar
AuthorDate: Fri Feb 7 14:02:44 2025 +0530
Fix lint error coming up in main (#10342)
---
engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql | 1 -
1 file changed, 1 deletion(-)
diff --git
a/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql
b/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql
index 4a5a0203a15..340791f0cdb 100644
--- a/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql
+++ b/engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql
@@ -33,4 +33,3 @@ WHERE rp.rule = 'quotaStatement'
AND NOT EXISTS(SELECT 1 FROM cloud.role_permissions rp_ WHERE rp.role_id =
rp_.role_id AND rp_.rule = 'quotaCreditsList');
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.host', 'last_mgmt_server_id',
'bigint unsigned DEFAULT NULL COMMENT "last management server this host is
connected to" AFTER `mgmt_server_id`');
-
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2642329312 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow editting or removing "CIDR list" from Load Balancer rule [cloudstack]
DaanHoogland closed issue #9313: Allow editting or removing "CIDR list" from Load Balancer rule URL: https://github.com/apache/cloudstack/issues/9313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow editting or removing "CIDR list" from Load Balancer rule [cloudstack]
DaanHoogland commented on issue #9313: URL: https://github.com/apache/cloudstack/issues/9313#issuecomment-2642383476 thanks closing as unplanned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
DaanHoogland commented on PR #10332: URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2642401747 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
blueorangutan commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2642200160 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Don't add empty iso while starting a VM [cloudstack]
vishesh92 commented on PR #10322: URL: https://github.com/apache/cloudstack/pull/10322#issuecomment-2642198070 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
DaanHoogland commented on PR #10183: URL: https://github.com/apache/cloudstack/pull/10183#issuecomment-2642218819 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
DaanHoogland commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2642217703 @li-liwen If I read the changes in #8821 correctly it only changes the behaviour of the updateOffering commands. So you should still be able to call the deleteServiceOffering API, for instance using cmk. cc @vishesh92 ?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup VM IP after expunge in redundant VPC [cloudstack]
blueorangutan commented on PR #10183: URL: https://github.com/apache/cloudstack/pull/10183#issuecomment-264276 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]
blueorangutan commented on PR #10332: URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2642403400 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Reserve IP address for out of bounds machines [cloudstack]
DaanHoogland commented on issue #4542: URL: https://github.com/apache/cloudstack/issues/4542#issuecomment-2642408248 @wido, adding this as well to your scope (feel free to reject btw). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Ability to add custom disk offer to data disk (created from multi-disk template) [cloudstack]
DaanHoogland closed issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template) URL: https://github.com/apache/cloudstack/issues/3341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow editting or removing "CIDR list" from Load Balancer rule [cloudstack]
hrak commented on issue #9313: URL: https://github.com/apache/cloudstack/issues/9313#issuecomment-2642424879 @DaanHoogland @NuxRo What a strange decision. Deleting and recreating a LB rule also involves having to reattach any VMs that were attached to the LB rule. When using the API programmatically (not for UI use, but for a Kubernetes cloud provider f.e.), it would make a lot more sense to have the ability to update the CIDR list with one call, as opposed to at least 4. - get list of vms associated with rule - delete the rule (detaches the VMs). In the mean time whatever service is exposed here will be unreachable. - recreate rule with new CIDR list - reattach the VMs acquired in step 1 Even from a UI perspective being able to update the list would be an improvement. Please reconsider this decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] DNS records for additional local IP addresses [cloudstack]
DaanHoogland commented on issue #2865: URL: https://github.com/apache/cloudstack/issues/2865#issuecomment-2642287494 @wido , in you design for plugable dns #9958, does this old issue fit in? (I added it to that to make sure to implement or close/deny it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add snapshots-related limits returned in capabilties [cloudstack]
DaanHoogland closed issue #3035: Add snapshots-related limits returned in capabilties URL: https://github.com/apache/cloudstack/issues/3035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] usage: use runtime scope when running maven usage profile [cloudstack]
blueorangutan commented on PR #10331: URL: https://github.com/apache/cloudstack/pull/10331#issuecomment-2642435787 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow editting or removing "CIDR list" from Load Balancer rule [cloudstack]
DaanHoogland commented on issue #9313: URL: https://github.com/apache/cloudstack/issues/9313#issuecomment-2642454760 > [@DaanHoogland](https://github.com/DaanHoogland) [@NuxRo](https://github.com/NuxRo) What a strange decision. Deleting and recreating a LB rule also involves having to reattach any VMs that were attached to the LB rule. When using the API programmatically (not for UI use, but for a Kubernetes cloud provider f.e.), it would make a lot more sense to have the ability to update the CIDR list with one call, as opposed to at least 4. > > * get list of vms associated with rule > > * delete the rule (detaches the VMs). In the mean time whatever service is exposed here will be unreachable. > > * recreate rule with new CIDR list > > * reattach the VMs acquired in step 1 > > > Even from a UI perspective being able to update the list would be an improvement. > > Please reconsider this decision. @hrak , it is closed as not planned, it is not refused, so if you wish to implement it anyway your code won't be refused. Please note that there are more than 400 issues open so and everybody working on the code has their own priorities. We will be very selective about what we address. Sorry to disappoint you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
DaanHoogland commented on code in PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#discussion_r1946401520 ## ui/public/locales/en.json: ## @@ -2444,7 +2444,7 @@ "label.users": "Users", "label.usersource": "User type", "label.using.cli": "Using CLI", -"label.utilization": "Utilisation", +"label.utilization": "Utilization", Review Comment: i got taught 'Utilisation' in English class back in the day (Utilization being considered a dutchism) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: server: fix pod retrieval during volume attach (#10324)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new a627ab67c29 server: fix pod retrieval during volume attach (#10324)
a627ab67c29 is described below
commit a627ab67c298345e92da013ebc0b786918a85f96
Author: Abhishek Kumar
AuthorDate: Fri Feb 7 17:29:23 2025 +0530
server: fix pod retrieval during volume attach (#10324)
Signed-off-by: Abhishek Kumar
---
.../com/cloud/storage/VolumeApiServiceImpl.java| 125 +
.../cloud/storage/VolumeApiServiceImplTest.java| 280 +
2 files changed, 363 insertions(+), 42 deletions(-)
diff --git a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
index 7f867eb01a9..3ea8116764a 100644
--- a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
+++ b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
@@ -133,7 +133,9 @@ import com.cloud.dc.ClusterDetailsDao;
import com.cloud.dc.DataCenter;
import com.cloud.dc.DataCenterVO;
import com.cloud.dc.Pod;
+import com.cloud.dc.dao.ClusterDao;
import com.cloud.dc.dao.DataCenterDao;
+import com.cloud.dc.dao.HostPodDao;
import com.cloud.domain.Domain;
import com.cloud.domain.dao.DomainDao;
import com.cloud.event.ActionEvent;
@@ -153,6 +155,7 @@ import com.cloud.hypervisor.Hypervisor.HypervisorType;
import com.cloud.hypervisor.HypervisorCapabilitiesVO;
import com.cloud.hypervisor.dao.HypervisorCapabilitiesDao;
import com.cloud.offering.DiskOffering;
+import com.cloud.org.Cluster;
import com.cloud.org.Grouping;
import com.cloud.projects.Project;
import com.cloud.projects.ProjectManager;
@@ -323,6 +326,8 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
@Inject
private VmWorkJobDao _workJobDao;
@Inject
+ClusterDao clusterDao;
+@Inject
private ClusterDetailsDao _clusterDetailsDao;
@Inject
private StorageManager storageMgr;
@@ -346,6 +351,8 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
protected ProjectManager projectManager;
@Inject
protected StoragePoolDetailsDao storagePoolDetailsDao;
+@Inject
+HostPodDao podDao;
protected Gson _gson;
@@ -2380,17 +2387,10 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
return attachVolumeToVM(command.getVirtualMachineId(),
command.getId(), command.getDeviceId());
}
-private Volume orchestrateAttachVolumeToVM(Long vmId, Long volumeId, Long
deviceId) {
-VolumeInfo volumeToAttach = volFactory.getVolume(volumeId);
-
-if (volumeToAttach.isAttachedVM()) {
-throw new CloudRuntimeException("This volume is already attached
to a VM.");
-}
-
-UserVmVO vm = _userVmDao.findById(vmId);
+protected VolumeVO getVmExistingVolumeForVolumeAttach(UserVmVO vm,
VolumeInfo volumeToAttach) {
VolumeVO existingVolumeOfVm = null;
VMTemplateVO template = _templateDao.findById(vm.getTemplateId());
-List rootVolumesOfVm = _volsDao.findByInstanceAndType(vmId,
Volume.Type.ROOT);
+List rootVolumesOfVm =
_volsDao.findByInstanceAndType(vm.getId(), Volume.Type.ROOT);
if (rootVolumesOfVm.size() > 1 && template != null &&
!template.isDeployAsIs()) {
throw new CloudRuntimeException("The VM " + vm.getHostName() + "
has more than one ROOT volume and is in an invalid state.");
} else {
@@ -2398,7 +2398,7 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
existingVolumeOfVm = rootVolumesOfVm.get(0);
} else {
// locate data volume of the vm
-List diskVolumesOfVm =
_volsDao.findByInstanceAndType(vmId, Volume.Type.DATADISK);
+List diskVolumesOfVm =
_volsDao.findByInstanceAndType(vm.getId(), Volume.Type.DATADISK);
for (VolumeVO diskVolume : diskVolumesOfVm) {
if (diskVolume.getState() != Volume.State.Allocated) {
existingVolumeOfVm = diskVolume;
@@ -2407,45 +2407,91 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
}
}
}
-if (s_logger.isTraceEnabled()) {
-String msg = "attaching volume %s/%s to a VM (%s/%s) with an
existing volume %s/%s on primary storage %s";
-if (existingVolumeOfVm != null) {
-s_logger.trace(String.format(msg,
-volumeToAttach.getName(), volumeToAttach.getUuid(),
+if (existingVolumeOfVm == null) {
+if (s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("No existing volume found for VM
(%s/%s) to
Re: [PR] server: fix pod retrieval during volume attach [cloudstack]
DaanHoogland merged PR #10324: URL: https://github.com/apache/cloudstack/pull/10324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create new Instance from VM backup [cloudstack]
github-actions[bot] commented on PR #10140: URL: https://github.com/apache/cloudstack/pull/10140#issuecomment-2642759729 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
DaanHoogland commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2642761744 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2642762949 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
li-liwen commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2642524261 @DaanHoogland Yes, I'm able to call the deleteServiceOffering API using cmk. But the API just makes the offering inactive instead of deleting it. I think this is probably the intended behavior, but I just would like to know if there's a way to actually delete the offerings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
blueorangutan commented on PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#issuecomment-2642526287 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10341 (QA-JID-544) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2642634723 [SF] Trillian test result (tid-12336) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 74041 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12336-xcpng82.zip Smoke tests completed. 131 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 169.12 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 182.27 | test_cluster_drs.py test_01_non_strict_host_anti_affinity | `Error` | 215.26 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 130.37 | test_nonstrict_affinity_group.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
vishesh92 commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2642666037 it's been some time, but AFAIR it's kind of complicated and would require a lot of changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2642678891 [SF] Trillian test result (tid-12335) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 74524 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12335-vmware-70u3.zip Smoke tests completed. 128 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py test_list_system_vms_metrics_history | `Failure` | 0.29 | test_metrics_api.py test_01_restore_vm | `Error` | 3605.15 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 8.85 | test_restore_vm.py test_01_deploy_vm_on_specific_host | `Error` | 19.86 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 3605.40 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 4.45 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.40 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.39 | test_vm_deployment_planner.py test_09_expunge_vm | `Failure` | 424.64 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (648170cf9bb -> a7beaaf73b8)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 648170cf9bb Fix lint error coming up in main (#10342) add a7beaaf73b8 Add Resource Limits to Backups and Object Storage (#10017) No new revisions were added by this update. Summary of changes: .../java/com/cloud/configuration/Resource.java | 12 +- api/src/main/java/com/cloud/event/EventTypes.java | 3 + .../java/com/cloud/storage/VolumeApiService.java | 2 + .../org/apache/cloudstack/api/ApiConstants.java| 21 +- .../api/command/user/backup/CreateBackupCmd.java | 19 +- .../user/backup/CreateBackupScheduleCmd.java | 10 + .../api/command/user/bucket/CreateBucketCmd.java | 2 +- .../api/command/user/bucket/UpdateBucketCmd.java | 2 +- .../cloudstack/api/response/AccountResponse.java | 108 ++ .../api/response/BackupScheduleResponse.java | 14 +- .../cloudstack/api/response/BucketResponse.java| 2 +- .../cloudstack/api/response/DomainResponse.java| 108 ++ .../cloudstack/api/response/ProjectResponse.java | 108 ++ .../response/ResourceLimitAndCountResponse.java| 24 ++ .../java/org/apache/cloudstack/backup/Backup.java | 22 ++ .../apache/cloudstack/backup/BackupManager.java| 84 - .../apache/cloudstack/backup/BackupProvider.java | 15 +- .../apache/cloudstack/backup/BackupSchedule.java | 1 + .../storage/object/BucketApiService.java | 51 ++- .../main/java/com/cloud/storage/dao/BucketDao.java | 4 + .../java/com/cloud/storage/dao/BucketDaoImpl.java | 35 ++ .../apache/cloudstack/backup/BackupScheduleVO.java | 14 +- .../org/apache/cloudstack/backup/BackupVO.java | 11 + .../apache/cloudstack/backup/dao/BackupDao.java| 5 + .../cloudstack/backup/dao/BackupDaoImpl.java | 50 +++ .../backup/dao/BackupScheduleDaoImpl.java | 1 + .../resources/META-INF/db/schema-42010to42100.sql | 4 + .../META-INF/db/views/cloud.account_view.sql | 32 ++ .../META-INF/db/views/cloud.domain_view.sql| 36 +- .../cloudstack/backup/DummyBackupProvider.java | 24 +- .../cloudstack/backup/NASBackupProvider.java | 27 +- .../cloudstack/backup/NetworkerBackupProvider.java | 138 +++- .../cloudstack/backup/VeeamBackupProvider.java | 102 ++ .../cloudstack/backup/veeam/VeeamClient.java | 4 +- .../driver/CephObjectStoreDriverImpl.java | 2 +- .../main/java/com/cloud/api/ApiResponseHelper.java | 2 +- .../com/cloud/api/query/ViewResponseHelper.java| 28 ++ .../cloud/api/query/dao/AccountJoinDaoImpl.java| 38 ++- .../com/cloud/api/query/dao/DomainJoinDaoImpl.java | 36 ++ .../java/com/cloud/api/query/vo/AccountJoinVO.java | 56 .../java/com/cloud/api/query/vo/DomainJoinVO.java | 69 +++- .../main/java/com/cloud/configuration/Config.java | 2 +- .../resourcelimit/ResourceLimitManagerImpl.java| 74 - .../com/cloud/storage/VolumeApiServiceImpl.java| 19 +- .../cloudstack/backup/BackupManagerImpl.java | 246 +- .../storage/object/BucketApiServiceImpl.java | 38 ++- .../ResourceLimitManagerImplTest.java | 121 ++- .../cloudstack/backup/BackupManagerTest.java | 365 - .../storage/object/BucketApiServiceImplTest.java | 182 ++ ui/public/locales/en.json | 12 +- ui/src/components/view/ListResourceTable.vue | 2 +- ui/src/components/view/ResourceCountUsage.vue | 2 +- ui/src/components/view/ResourceLimitTab.vue| 6 +- ui/src/views/compute/backup/BackupSchedule.vue | 5 + ui/src/views/compute/backup/FormSchedule.vue | 13 + ui/src/views/dashboard/UsageDashboard.vue | 32 +- ui/src/views/storage/CreateBucket.vue | 5 +- ui/src/views/storage/UpdateBucket.vue | 2 +- 58 files changed, 2182 insertions(+), 270 deletions(-) create mode 100644 server/src/test/java/org/apache/cloudstack/storage/object/BucketApiServiceImplTest.java
Re: [PR] Add Resource Limits to Backups and Object Storage [cloudstack]
rohityadavcloud merged PR #10017: URL: https://github.com/apache/cloudstack/pull/10017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
DaanHoogland commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2642691337 I think for now setting the `removed` field to `now()` is the best workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
blueorangutan commented on PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#issuecomment-2642491373 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
shwstppr commented on PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#issuecomment-2642490430 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
github-actions[bot] commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2642619168 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
github-actions[bot] commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2642619137 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Implement Object Storage Limit for Users/Projects and Default Quota Preset [cloudstack]
rohityadavcloud closed issue #8638: Implement Object Storage Limit for Users/Projects and Default Quota Preset URL: https://github.com/apache/cloudstack/issues/8638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2642774584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2642778165 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make Description as optional in network acl list [cloudstack]
blueorangutan commented on PR #10343: URL: https://github.com/apache/cloudstack/pull/10343#issuecomment-2642807068 @sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (c09720a19a4 -> 3337f425ffd)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c09720a19a4 systemvm-registration: update seeded template_store_ref sizes (#10317) add 3337f425ffd Primera pure patches & various small fixes (#10132) No new revisions were added by this update. Summary of changes: .../cloud/exception/StorageAccessException.java| 4 +- .../engine/orchestration/VolumeOrchestrator.java | 6 +-- .../motion/StorageSystemDataMotionStrategy.java| 15 ++- .../storage/volume/VolumeServiceImpl.java | 6 +-- .../lifecycle/CloudStackExtendedLifeCycle.java | 9 +++- .../lifecycle/registry/RegistryLifecycle.java | 13 -- .../hypervisor/kvm/resource/LibvirtVMDef.java | 5 ++- ...LibvirtGetUnmanagedInstancesCommandWrapper.java | 5 ++- .../kvm/storage/KVMStorageProcessor.java | 28 +--- .../kvm/storage/MultipathSCSIAdapterBase.java | 23 ++ .../KubernetesClusterActionWorker.java | 5 +++ .../cluster/utils/KubernetesClusterUtil.java | 2 +- .../datastore/adapter/primera/PrimeraAdapter.java | 51 ++ scripts/storage/multipath/cleanStaleMaps.sh| 10 - scripts/storage/multipath/disconnectVolume.sh | 3 ++ .../java/com/cloud/user/AccountManagerImpl.java| 6 ++- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 8 +++- .../resource/LocalNfsSecondaryStorageResource.java | 4 +- 18 files changed, 163 insertions(+), 40 deletions(-)
Re: [PR] systemvm-registration: update seeded template_store_ref sizes [cloudstack]
DaanHoogland merged PR #10317: URL: https://github.com/apache/cloudstack/pull/10317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated (a627ab67c29 -> c09720a19a4)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from a627ab67c29 server: fix pod retrieval during volume attach (#10324) add c09720a19a4 systemvm-registration: update seeded template_store_ref sizes (#10317) No new revisions were added by this update. Summary of changes: .../upgrade/SystemVmTemplateRegistration.java | 33 ++ .../java/com/cloud/storage/StorageManagerImpl.java | 4 +-- 2 files changed, 30 insertions(+), 7 deletions(-)
Re: [PR] xenserver: do not destroy halted hypervisor vm [cloudstack]
DaanHoogland commented on PR #9175: URL: https://github.com/apache/cloudstack/pull/9175#issuecomment-2642776364 moving this forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (040e31ad968 -> a648b6c3c96)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 040e31ad968 DO NOT MERGE add a627ab67c29 server: fix pod retrieval during volume attach (#10324) add c09720a19a4 systemvm-registration: update seeded template_store_ref sizes (#10317) add 3337f425ffd Primera pure patches & various small fixes (#10132) add a648b6c3c96 DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (040e31ad968) \ N -- N -- N refs/heads/healthcheck-4.19 (a648b6c3c96) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../cloud/exception/StorageAccessException.java| 4 +- .../engine/orchestration/VolumeOrchestrator.java | 6 +- .../upgrade/SystemVmTemplateRegistration.java | 33 ++- .../motion/StorageSystemDataMotionStrategy.java| 15 +- .../storage/volume/VolumeServiceImpl.java | 6 +- .../lifecycle/CloudStackExtendedLifeCycle.java | 9 +- .../lifecycle/registry/RegistryLifecycle.java | 13 +- .../hypervisor/kvm/resource/LibvirtVMDef.java | 5 +- ...LibvirtGetUnmanagedInstancesCommandWrapper.java | 5 +- .../kvm/storage/KVMStorageProcessor.java | 28 ++- .../kvm/storage/MultipathSCSIAdapterBase.java | 23 ++ .../KubernetesClusterActionWorker.java | 5 + .../cluster/utils/KubernetesClusterUtil.java | 2 +- .../datastore/adapter/primera/PrimeraAdapter.java | 51 +++- scripts/storage/multipath/cleanStaleMaps.sh| 10 +- scripts/storage/multipath/disconnectVolume.sh | 3 + .../java/com/cloud/storage/StorageManagerImpl.java | 4 +- .../com/cloud/storage/VolumeApiServiceImpl.java| 125 + .../java/com/cloud/user/AccountManagerImpl.java| 6 +- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 8 +- .../cloud/storage/VolumeApiServiceImplTest.java| 280 + .../resource/LocalNfsSecondaryStorageResource.java | 4 +- 22 files changed, 556 insertions(+), 89 deletions(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2642784967 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `Hypervisor default` as cache mode for disk offerings [cloudstack]
github-actions[bot] commented on PR #10282: URL: https://github.com/apache/cloudstack/pull/10282#issuecomment-2642785011 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2642789026 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Make Description as optional in network acl list [cloudstack]
sudo87 opened a new pull request, #10343:
URL: https://github.com/apache/cloudstack/pull/10343
### Description
This PR makes Description as optional field in ACL list additional screen,
which is optional in API.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested on QA server.
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Make Description as optional in network acl list [cloudstack]
DaanHoogland commented on PR #10343: URL: https://github.com/apache/cloudstack/pull/10343#issuecomment-2642807343 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make Description as optional in network acl list [cloudstack]
sudo87 commented on PR #10343: URL: https://github.com/apache/cloudstack/pull/10343#issuecomment-2642805129 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
github-actions[bot] commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2642785042 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2642902332 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Best Way to Restore a Specific VM from Hourly Snapshots in Apache CloudStack 4.19.1.2 [cloudstack]
boring-cyborg[bot] commented on issue #10344: URL: https://github.com/apache/cloudstack/issues/10344#issuecomment-2642906540 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Issue with VM Creation When Associating a New Network in Apache CloudStack 4.19.1.2 [cloudstack]
pankajfromcomhard opened a new issue, #10345: URL: https://github.com/apache/cloudstack/issues/10345 We are facing an issue in Apache CloudStack 4.19.1.2 where we can successfully create a virtual machine (VM) using an existing guest network. However, when we try to create a new network and associate it with the same VM during creation, the process fails. Here’s what happens: VM Creation with an Existing Network Works Fine – When selecting an already available guest network, the VM is deployed without any issues. Issue When Creating a New Network with the VM – If we create a new network while deploying the VM and tag it with the VM: The new network gets stuck in the 'Implementing' state. The virtual router for the network remains stuck in the 'Starting' state. After some time, the VM creation fails with an error. Has anyone else encountered this issue? Are there any recommended troubleshooting steps or configuration changes that can help resolve this problem? Looking forward to insights from the community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `Hypervisor default` as cache mode for disk offerings [cloudstack]
JoaoJandre commented on code in PR #10282:
URL: https://github.com/apache/cloudstack/pull/10282#discussion_r1946626235
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##
@@ -708,7 +708,7 @@ public String toString() {
}
public enum DiskCacheMode {
-NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+HYPERVISOR_DEFAULT("default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
same here
##
plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/adapter/ProviderAdapterDiskOffering.java:
##
@@ -166,7 +166,7 @@ enum State {
}
enum DiskCacheMode {
-NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Why do we have this enum multiple times? Maybe we could extract it to a
common place?
##
api/src/main/java/com/cloud/offering/DiskOffering.java:
##
@@ -37,7 +37,7 @@ enum State {
State getState();
enum DiskCacheMode {
-NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Although there shouldn't be any issue with changing the order of the enum. I
would put the new value at the end of the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Primera pure patches & various small fixes [cloudstack]
DaanHoogland merged PR #10132: URL: https://github.com/apache/cloudstack/pull/10132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GUI whitelabel runtime system [cloudstack]
hsato03 commented on code in PR #8942:
URL: https://github.com/apache/cloudstack/pull/8942#discussion_r1946501216
##
ui/src/store/modules/user.js:
##
@@ -231,6 +235,10 @@ const user = {
commit('SET_LATEST_VERSION', latestVersion)
notification.destroy()
+ await api('listUsers', { userid: result.userid }).then(async
response => {
+await
applyCustomGuiTheme(response.listusersresponse.user[0].accountid,
result.domainid)
+ })
Review Comment:
@BryanMLima The `applyCustomGuiTheme` function should be moved to the
`GetInfo` action as it is blocking users from logging in with 2FA due to an
authorized call to the `listUsers` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2642957533 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (a648b6c3c96 -> 6a5e12a87fd)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit a648b6c3c96 DO NOT MERGE add a1117acbdfb List only untagged offerings for Shared networks when tag isn't passed (#10320) add 6a5e12a87fd DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a648b6c3c96) \ N -- N -- N refs/heads/healthcheck-4.19 (6a5e12a87fd) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: ui/src/views/network/CreateSharedNetworkForm.vue | 4 1 file changed, 4 insertions(+)
Re: [PR] Make Description as optional in network acl list [cloudstack]
DaanHoogland merged PR #10343: URL: https://github.com/apache/cloudstack/pull/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Best Way to Restore a Specific VM from Hourly Snapshots in Apache CloudStack 4.19.1.2 [cloudstack]
pankajfromcomhard opened a new issue, #10344: URL: https://github.com/apache/cloudstack/issues/10344 We are using SAN storage as the primary NFS storage in our Apache CloudStack 4.19.1.2 environment. To ensure data safety and quick recovery, we take hourly snapshots of our NFS storage. In case of an issue, we restore the snapshot and mount it as a new NFS share within Apache CloudStack. This allows us to browse files as they were one hour earlier. Is there any efficient method to restore a specific VM without restoring the entire NFS mount? Any best practices or automation suggestions from the community would be highly appreciated.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: Make Description as optional in network acl list (#10343)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 50a54dde5cc Make Description as optional in network acl list (#10343)
50a54dde5cc is described below
commit 50a54dde5ccd9c9fe0a2dd4b067843712a6b8de5
Author: Manoj Kumar
AuthorDate: Fri Feb 7 19:10:06 2025 +0530
Make Description as optional in network acl list (#10343)
---
ui/src/views/network/VpcTab.vue | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/src/views/network/VpcTab.vue b/ui/src/views/network/VpcTab.vue
index 9090654b183..5c0838ff7e0 100644
--- a/ui/src/views/network/VpcTab.vue
+++ b/ui/src/views/network/VpcTab.vue
@@ -727,8 +727,7 @@ export default {
break
case 'networkAcl':
this.rules = {
-name: [{ required: true, message: this.$t('label.required') }],
-description: [{ required: true, message: this.$t('label.required')
}]
+name: [{ required: true, message: this.$t('label.required') }]
}
this.modals.networkAcl = true
break
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
DaanHoogland commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2642978979 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Best Way to Restore a Specific VM from Hourly Snapshots in Apache CloudStack 4.19.1.2 [cloudstack]
DaanHoogland closed issue #10344: Best Way to Restore a Specific VM from Hourly Snapshots in Apache CloudStack 4.19.1.2 URL: https://github.com/apache/cloudstack/issues/10344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2642982713 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Snapshot defaulting to Physical Size 0 [cloudstack]
DaanHoogland closed issue #9660: Snapshot defaulting to Physical Size 0 URL: https://github.com/apache/cloudstack/issues/9660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Snapshot defaulting to Physical Size 0 [cloudstack]
DaanHoogland commented on issue #9660: URL: https://github.com/apache/cloudstack/issues/9660#issuecomment-2642985838 fixed in #10216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2642991037 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make isAccountAllowedToCreateOfferingsWithTags API id parameter required [cloudstack]
JoaoJandre commented on PR #10338: URL: https://github.com/apache/cloudstack/pull/10338#issuecomment-2643057934 @DaanHoogland could we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
JoaoJandre commented on code in PR #10341:
URL: https://github.com/apache/cloudstack/pull/10341#discussion_r1946593479
##
ui/src/config/section/storage.js:
##
@@ -38,7 +38,7 @@ export default {
}
},
columns: () => {
-const fields = ['name', 'state', 'sizegb', 'type', 'vmname']
+const fields = ['name', 'state', 'type', 'vmname', 'vmstate', 'sizegb']
Review Comment:
I preferred the size after the state, rather than at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI: Add VM state to Volume list view [cloudstack]
JoaoJandre commented on code in PR #10341: URL: https://github.com/apache/cloudstack/pull/10341#discussion_r1946584909 ## ui/public/locales/en.json: ## @@ -2444,7 +2444,7 @@ "label.users": "Users", "label.usersource": "User type", "label.using.cli": "Using CLI", -"label.utilization": "Utilisation", +"label.utilization": "Utilization", Review Comment: Apparently, it depends if you're using the US or UK writing: https://dictionary.cambridge.org/dictionary/english/utilization. I'm not sure which writing is usually used in ACS, but it might actually be interesting to one day normalize it to either UK or US. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
JoaoJandre commented on code in PR #10325:
URL: https://github.com/apache/cloudstack/pull/10325#discussion_r1946614185
##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -5493,4 +5500,24 @@ public void setLockControllerListener(final
LockControllerListener lockControlle
_lockControllerListener = lockControllerListener;
}
+@Override
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_MANAGEMENT_SERVER_REMOVE,
eventDescription = "removing Management Server")
+public boolean removeManagementServer(RemoveMgmtCmd cmd) {
+final Long id = cmd.getId();
+ManagementServerJoinVO managementServer =
_managementServerJoinDao.findById(id);
+
+if (managementServer == null) {
+throw new InvalidParameterValueException(String.format("Unable to
find a Management Server with ID equal to [%s]", managementServer.getUuid()));
+}
+
+if (ManagementServerHost.State.Up.equals(managementServer.getState()))
{
Review Comment:
```suggestion
if
(!ManagementServerHost.State.Down.equals(managementServer.getState())) {
```
If it should only be removed in the Down state ( as said in the logging
message below ) this condition doesn't cover all cases, as we have more states
than Up and Down.
##
api/src/main/java/org/apache/cloudstack/api/command/admin/management/RemoveMgmtCmd.java:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.management;
+
+import com.cloud.event.EventTypes;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.response.ManagementServerResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+
+@APICommand(name = "removeManagementServer", description = "Removes a
Management Server.", responseObject = SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = RoleType.Admin)
+public class RemoveMgmtCmd extends BaseCmd {
Review Comment:
I would use the name of the class equal to the name of the API + cmd. This
is more or less the default.
```suggestion
public class RemoveManagementServerCmd extends BaseCmd {
```
##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -1011,6 +1015,8 @@ public class ManagementServerImpl extends ManagerBase
implements ManagementServe
UserDataManager userDataManager;
@Inject
StoragePoolTagsDao storagePoolTagsDao;
+@Inject
+protected ManagementServerJoinDao _managementServerJoinDao;
Review Comment:
```suggestion
protected ManagementServerJoinDao managementServerJoinDao;
```
The underscore at the start is a legacy naming "convention" that is not used
by the project anymore. The current convention is to use plain camelCase
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2643103803 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add offer ha column to system offerings table [cloudstack]
boring-cyborg[bot] commented on PR #10297: URL: https://github.com/apache/cloudstack/pull/10297#issuecomment-2643103960 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: UI: Add offer ha column to system offerings table (#10297)
This is an automated email from the ASF dual-hosted git repository.
joao pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 5aa79a6e05d UI: Add offer ha column to system offerings table (#10297)
5aa79a6e05d is described below
commit 5aa79a6e05d04440587ab26da70c1b3fae6e3a20
Author: erik-bock-silva
AuthorDate: Fri Feb 7 11:31:14 2025 -0300
UI: Add offer ha column to system offerings table (#10297)
* add offer ha column to system offerings table
* fix identation
---
ui/src/components/view/ListView.vue | 3 +++
ui/src/config/section/offering.js | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/src/components/view/ListView.vue
b/ui/src/components/view/ListView.vue
index 4541e1687ea..9b5d226289b 100644
--- a/ui/src/components/view/ListView.vue
+++ b/ui/src/components/view/ListView.vue
@@ -250,6 +250,9 @@
+
+{{ text ? $t('state.enabled') : $t('state.disabled')}}
+
{{ text }}
diff --git a/ui/src/config/section/offering.js
b/ui/src/config/section/offering.js
index e542f3d8df3..09a0919d860 100644
--- a/ui/src/config/section/offering.js
+++ b/ui/src/config/section/offering.js
@@ -142,7 +142,7 @@ export default {
permission: ['listServiceOfferings', 'listInfrastructure'],
searchFilters: ['name', 'zoneid', 'domainid', 'cpunumber', 'cpuspeed',
'memory'],
params: { issystem: 'true', isrecursive: 'true' },
- columns: ['name', 'state', 'systemvmtype', 'cpunumber', 'cpuspeed',
'memory', 'storagetype', 'order'],
+ columns: ['name', 'state', 'systemvmtype', 'cpunumber', 'cpuspeed',
'memory', 'storagetype', 'offerha', 'order'],
filters: ['active', 'inactive'],
details: ['name', 'id', 'displaytext', 'systemvmtype',
'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber',
'cpuspeed', 'memory', 'storagetags', 'hosttags', 'tags', 'domain', 'zone',
'created', 'dynamicscalingenabled', 'diskofferingstrictness'],
resourceType: 'ServiceOffering',
Re: [PR] UI: Add offer ha column to system offerings table [cloudstack]
JoaoJandre merged PR #10297: URL: https://github.com/apache/cloudstack/pull/10297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add offer ha column to system offerings table [cloudstack]
JoaoJandre commented on PR #10297: URL: https://github.com/apache/cloudstack/pull/10297#issuecomment-2643103489 Merging based on the author's and @lucas-a-martins' tests, the CI does not have any tests regarding the UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
