JoaoJandre commented on code in PR #10282:
URL: https://github.com/apache/cloudstack/pull/10282#discussion_r1946626235
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -708,7 +708,7 @@ public String toString() {
}
public enum DiskCacheMode {
- NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+ HYPERVISOR_DEFAULT("default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
same here
##########
plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/adapter/ProviderAdapterDiskOffering.java:
##########
@@ -166,7 +166,7 @@ enum State {
}
enum DiskCacheMode {
- NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+ HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Why do we have this enum multiple times? Maybe we could extract it to a
common place?
##########
api/src/main/java/com/cloud/offering/DiskOffering.java:
##########
@@ -37,7 +37,7 @@ enum State {
State getState();
enum DiskCacheMode {
- NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+ HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Although there shouldn't be any issue with changing the order of the enum. I
would put the new value at the end of the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
