Re: [PR] api/ui: add specifyvlan to network response [cloudstack]
codecov[bot] commented on PR #10236: URL: https://github.com/apache/cloudstack/pull/10236#issuecomment-2606673352 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`d053bb9`)](https://app.codecov.io/gh/apache/cloudstack/commit/d053bb97ecf14ad85f9af2fe6dd521e80117165a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d2e38fb`)](https://app.codecov.io/gh/apache/cloudstack/commit/d2e38fb05a602aa52d180fa4e5f9153c328c6458?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ##4.19 #10236 +/- ## == Coverage 4.30%4.30% == Files366 366 Lines 2957029570 Branches5180 5180 == Hits1272 1272 Misses 2815428154 Partials 144 144 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10236/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10236?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
harikrishna-patnala opened a new pull request, #10237:
URL: https://github.com/apache/cloudstack/pull/10237
### Description
This PR addresses the issue #9891 extending the PR
https://github.com/apache/cloudstack/pull/9088 which decrypts the configuration
values in the details tables of the resources.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Autoscale VMs do not follow ScaleDown Rules after a Node Failure [cloudstack]
DaanHoogland commented on issue #9336: URL: https://github.com/apache/cloudstack/issues/9336#issuecomment-2606824171 @btzq , I've not been able to reproduce this reliably with the caveat that it might temporarily exceed the number of max VMs. But in all my experiments it normalises again. Shall we put this on hold to see if #9574 aliviates the issue? I can not reliably reproduce this, and what I have looks good. PS maybe we can arrange for you to do some testing based on packages suplied to you? (cc @Pearl1594 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
blueorangutan commented on PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2606932339 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
shwstppr commented on PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2606929230
@abh1sar API was allowing empty cidr as it takes List as input,
```
(qaserver) 🐱 > create firewallrule cidrlist= protocol=tcp
ipaddressid=e7314c68-c570-42c5-939e-e61f5b30cb4b startport=22 endport=22
{
"firewallrule": {
"cidrlist": "",
"destcidrlist": "",
"endport": 22,
"fordisplay": true,
"id": "2a0c6f0f-bb4c-4f2d-9c2d-1129b523f584",
"ipaddress": "192.168.1.173",
"ipaddressid": "e7314c68-c570-42c5-939e-e61f5b30cb4b",
"networkid": "00089a57-3cc1-4ddc-973c-251a6f097372",
"protocol": "tcp",
"startport": 22,
"state": "Active",
"tags": [],
"traffictype": "Ingress"
}
}
```
I've added a check
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]
blueorangutan commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606675461 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]
abh1sar commented on code in PR #10232:
URL: https://github.com/apache/cloudstack/pull/10232#discussion_r1925031221
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) {
public boolean deleteAccount(AccountVO account, long callerUserId, Account
caller) {
long accountId = account.getId();
+if (account.getState() != State.DISABLED) {
Review Comment:
@weizhouapache understood, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]
weizhouapache commented on code in PR #10232:
URL: https://github.com/apache/cloudstack/pull/10232#discussion_r1925096091
##
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##
@@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) {
public boolean deleteAccount(AccountVO account, long callerUserId, Account
caller) {
long accountId = account.getId();
+if (account.getState() != State.DISABLED) {
Review Comment:
thanks @abh1sar
The changes on unit tests are not needed
is it applicable for 4.19 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]
blueorangutan commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607068996 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10239 (QA-JID-520) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage deletion cases [cloudstack]
harikrishna-patnala commented on code in PR #10231:
URL: https://github.com/apache/cloudstack/pull/10231#discussion_r1925209654
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteStoragePoolCommandWrapper.java:
##
@@ -39,6 +47,34 @@ public Answer execute(final DeleteStoragePoolCommand
command, final LibvirtCompu
final KVMStoragePoolManager storagePoolMgr =
libvirtComputingResource.getStoragePoolMgr();
storagePoolMgr.deleteStoragePool(pool.getType(),
pool.getUuid());
+if (Storage.StoragePoolType.Filesystem.equals(pool.getType())
&& !libvirtComputingResource.DEFAULT_LOCAL_STORAGE_PATH.equals(pool.getPath()))
{
+String localStoragePath =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.LOCAL_STORAGE_PATH);
+String localStorageUuid =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.LOCAL_STORAGE_UUID);
+
+String uuidToRemove = pool.getUuid();
+String pathToRemove = pool.getPath();
+
+if (localStorageUuid != null && uuidToRemove != null) {
+localStorageUuid =
Arrays.stream(localStorageUuid.split(","))
+.filter(uuid -> !uuid.equals(uuidToRemove))
+.collect(Collectors.joining(","));
+}
+
+if (localStoragePath != null && pathToRemove != null) {
+localStoragePath =
Arrays.stream(localStoragePath.split(","))
+.filter(path -> !path.equals(pathToRemove))
+.collect(Collectors.joining(","));
+}
+
+PropertiesStorage agentProperties = new
PropertiesStorage();
+agentProperties.configure("AgentProperties", new
HashMap());
+if (localStorageUuid != null) {
+
agentProperties.persist(AgentProperties.LOCAL_STORAGE_UUID.getName(),
localStorageUuid);
+}
+if (localStoragePath != null) {
+
agentProperties.persist(AgentProperties.LOCAL_STORAGE_PATH.getName(),
localStoragePath);
+}
+}
Review Comment:
addressed, thanks. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix local storage deletion cases [cloudstack]
harikrishna-patnala commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607073438 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: server: Fix host CPU number (#10218)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 09f154796a2 server: Fix host CPU number (#10218)
09f154796a2 is described below
commit 09f154796a2a10f1c74d6f2087d1a3fe86694fb4
Author: Wei Zhou
AuthorDate: Wed Jan 22 15:44:54 2025 +0100
server: Fix host CPU number (#10218)
---
.../api/response/HostForMigrationResponse.java | 431 +
.../com/cloud/api/query/dao/HostJoinDaoImpl.java | 121 +-
2 files changed, 8 insertions(+), 544 deletions(-)
diff --git
a/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java
b/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java
index 41a0fdc4567..b4de48baec4 100644
---
a/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java
+++
b/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java
@@ -16,449 +16,20 @@
// under the License.
package org.apache.cloudstack.api.response;
-import java.util.Date;
-
-import org.apache.cloudstack.api.ApiConstants;
-import org.apache.cloudstack.api.BaseResponse;
import org.apache.cloudstack.api.EntityReference;
import com.cloud.host.Host;
-import com.cloud.host.Status;
import com.cloud.serializer.Param;
import com.google.gson.annotations.SerializedName;
@EntityReference(value = Host.class)
-public class HostForMigrationResponse extends BaseResponse {
-@SerializedName(ApiConstants.ID)
-@Param(description = "the ID of the host")
-private String id;
-
-@SerializedName(ApiConstants.NAME)
-@Param(description = "the name of the host")
-private String name;
-
-@SerializedName(ApiConstants.STATE)
-@Param(description = "the state of the host")
-private Status state;
-
-@SerializedName("disconnected")
-@Param(description = "true if the host is disconnected. False otherwise.")
-private Date disconnectedOn;
-
-@SerializedName(ApiConstants.TYPE)
-@Param(description = "the host type")
-private Host.Type hostType;
-
-@SerializedName("oscategoryid")
-@Param(description = "the OS category ID of the host")
-private String osCategoryId;
-
-@SerializedName("oscategoryname")
-@Param(description = "the OS category name of the host")
-private String osCategoryName;
-
-@SerializedName(ApiConstants.IP_ADDRESS)
-@Param(description = "the IP address of the host")
-private String ipAddress;
-
-@SerializedName(ApiConstants.ZONE_ID)
-@Param(description = "the Zone ID of the host")
-private String zoneId;
-
-@SerializedName(ApiConstants.ZONE_NAME)
-@Param(description = "the Zone name of the host")
-private String zoneName;
-
-@SerializedName(ApiConstants.POD_ID)
-@Param(description = "the Pod ID of the host")
-private String podId;
-
-@SerializedName("podname")
-@Param(description = "the Pod name of the host")
-private String podName;
-
-@SerializedName("version")
-@Param(description = "the host version")
-private String version;
-
-@SerializedName(ApiConstants.HYPERVISOR)
-@Param(description = "the host hypervisor")
-private String hypervisor;
-
-@SerializedName("cpunumber")
-@Param(description = "the CPU number of the host")
-private Integer cpuNumber;
-
-@SerializedName("cpuspeed")
-@Param(description = "the CPU speed of the host")
-private Long cpuSpeed;
-
-@Deprecated
-@SerializedName("cpuallocated")
-@Param(description = "the amount of the host's CPU currently allocated")
-private String cpuAllocated;
-
-@SerializedName("cpuallocatedvalue")
-@Param(description = "the amount of the host's CPU currently allocated in
MHz")
-private Long cpuAllocatedValue;
-
-@SerializedName("cpuallocatedpercentage")
-@Param(description = "the amount of the host's CPU currently allocated in
percentage")
-private String cpuAllocatedPercentage;
-
-@SerializedName("cpuallocatedwithoverprovisioning")
-@Param(description = "the amount of the host's CPU currently allocated
after applying the cpu.overprovisioning.factor")
-private String cpuAllocatedWithOverprovisioning;
-
-@SerializedName("cpuused")
-@Param(description = "the amount of the host's CPU currently used")
-private String cpuUsed;
-
-@SerializedName("cpuwithoverprovisioning")
-@Param(description = "the amount of the host's CPU after applying the
cpu.overprovisioning.factor ")
-private String cpuWithOverprovisioning;
-
-@Deprecated
-@SerializedName("memorytotal")
-@Param(description = "the memory total of the host, this parameter is
deprecated use memorywithoverprovisioning")
-private Long memoryTotal;
-
-@SerializedName("memorywithoverprovisioning")
-@Param(description = "the amoun
Re: [PR] server: Fix host CPU number [cloudstack]
DaanHoogland merged PR #10218: URL: https://github.com/apache/cloudstack/pull/10218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607416684 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]
blueorangutan commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607469723 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]
weizhouapache commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607478709 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]
weizhouapache opened a new pull request, #10241:
URL: https://github.com/apache/cloudstack/pull/10241
### Description
This PR re-applies #9374
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]
blueorangutan commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607484925 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]
codecov[bot] commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607497883 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.02%. Comparing base [(`96b757c`)](https://app.codecov.io/gh/apache/cloudstack/commit/96b757c35bc7d1f0da1d03d7df7cbf094b5bb385?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a1daf60`)](https://app.codecov.io/gh/apache/cloudstack/commit/a1daf60e0e70b4765db35a2e3dc7c8826bef1431?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (96b757c) and HEAD (a1daf60). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (96b757c) | HEAD (a1daf60) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #10241 +/- ## = - Coverage 16.13%4.02% -12.12% = Files 5639 394 -5245 Lines49429732346 -461951 Branches 59908 5714-54194 = - Hits 79773 1301-78472 + Misses 40569830897 -374801 + Partials 8826 148 -8678 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10241/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10241/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.02% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10241/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10241?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to delete failed VM snapshot [cloudstack]
harikrishna-patnala closed issue #9369: Unable to delete failed VM snapshot URL: https://github.com/apache/cloudstack/issues/9369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
borisstoyanov commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2606964956 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2606967656 @borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (1f21d0f531c -> 4747283d992)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 1f21d0f531c DO NOT MERGE add d053bb97ecf Fix to allow actions on the network if it belongs to a project (#9550) add 4747283d992 DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1f21d0f531c) \ N -- N -- N refs/heads/healthcheck-4.19 (4747283d992) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: ui/src/config/section/network.js | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606976926 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow delete account only once it is disabled. Extra checks in UI. [cloudstack]
DaanHoogland commented on PR #10232: URL: https://github.com/apache/cloudstack/pull/10232#issuecomment-2606979079 @abh1sar ,can you rebase on 4.19, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606980426 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to delete failed VM snapshot [cloudstack]
harikrishna-patnala commented on issue #9369: URL: https://github.com/apache/cloudstack/issues/9369#issuecomment-2606972781 I'm closing the issue as I could not reproduce it. Please feel free to reopen if this issue reproduces again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (4747283d992 -> 3f668a23abb)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 4747283d992 DO NOT MERGE add b186272f687 kvm: add SCSI controllers based on the number of virtio-SCSI disks (#9823) add 3f668a23abb DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (4747283d992) \ N -- N -- N refs/heads/healthcheck-4.19 (3f668a23abb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../kvm/resource/LibvirtComputingResource.java | 17 ++--- .../kvm/resource/LibvirtComputingResourceTest.java | 5 - 2 files changed, 18 insertions(+), 4 deletions(-)
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607220584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607224489 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 2FA is enabled even if User fails to verify with TOTP code [cloudstack]
DaanHoogland commented on issue #9308: URL: https://github.com/apache/cloudstack/issues/9308#issuecomment-2607237911 @scottsignal , closing based on @shwstppr 's findings, please reopen or create a new issue if this perists after upgrading to 4.19.1 or above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Data Disks get unavailable when VM is shut down [cloudstack]
weizhouapache closed issue #7490: Data Disks get unavailable when VM is shut down URL: https://github.com/apache/cloudstack/issues/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added displaynetwork option in filters for listnetwork only for admin [cloudstack]
DaanHoogland commented on PR #10209: URL: https://github.com/apache/cloudstack/pull/10209#issuecomment-2607242441 > Code LGTM but for such networks opened from other than listview it would still return 404. Others can advise. Maybe in future we improve this API parameter which somehow allows list a network irrespective of network's displaynetwork value for admins I had the same finding @shwstppr but agree this is another issue (UI polish). At least now the network can be viewed in the UI at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]
weizhouapache commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607245509 > the usage error is failed to download iso, which is not related. the life-cyle ones are intermitted errors thanks @vladimirpetrov @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added displaynetwork option in filters for listnetwork only for admin [cloudstack]
DaanHoogland commented on PR #10209: URL: https://github.com/apache/cloudstack/pull/10209#issuecomment-2607243663 @harikrishna-patnala do you want to polish this more now or merge and postpone further enhancements? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607639556 Did some more research, @harikrishna-patnala . at least these changes are needed as well (still looking) ``` diff --git a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java index 70aaf91c6ae..37e10910978 100644 --- a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java @@ -43,11 +43,11 @@ public class ClusterDetailsDaoImpl extends ResourceDetailsDaoBase
Re: [PR] Fix local storage deletion cases [cloudstack]
DaanHoogland commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607642446 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage deletion cases [cloudstack]
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607644337 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: apply network ACL even if there is no network ACLs in the ACL list (#9374) [cloudstack]
blueorangutan commented on PR #10241: URL: https://github.com/apache/cloudstack/pull/10241#issuecomment-2607664191 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]
weizhouapache commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607668100 @DaanHoogland Actually there are only 5 default shared network offerings will be listed. ``` mysql> select id,unique_name from network_offerings where `default`=1 and guest_type='Shared'; ++---+ | id | unique_name | ++---+ | 7 | DefaultSharedNetworkOfferingWithSGService | | 8 | DefaultSharedNetworkOffering | | 9 | DefaultTungstenSharedNetworkOfferingWithSGService | | 12 | DefaultSharedNetscalerEIPandELBNetworkOffering| | 20 | QuickCloudNoServices | ++---+ 5 rows in set (0.00 sec) ``` not a big deal I think. my only concern is, do they work with both tagged and untagged physical networks (without more code changes) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]
Pearl1594 commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607651790 @DaanHoogland I am not sure what copyDefaultOfferings() is supposed to do. CloudStack forces a tag for any additional physical (guest) network added. Which should not render the default (shared) offerings unusable for this newly added phy net. It does not list all shared network offerings that have no tags, just those that are provided by CloudStack by default, i.e., If a user creates a shared network offering with no tags, this will not be listed for the a tagged phy net. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-documentation) branch 4.19 updated: Fix Adding a zone documentation (#472)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.19 by this push: new e3fda2f Fix Adding a zone documentation (#472) e3fda2f is described below commit e3fda2fa3eb403d6e997dbb755bfd7604808918d Author: Nicolas Vazquez AuthorDate: Wed Jan 22 06:03:18 2025 -0300 Fix Adding a zone documentation (#472) --- source/installguide/configuration.rst | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/source/installguide/configuration.rst b/source/installguide/configuration.rst index 5d11da5..b69bde0 100644 --- a/source/installguide/configuration.rst +++ b/source/installguide/configuration.rst @@ -264,7 +264,13 @@ and secondary storage. #. Click Add Zone. The zone creation wizard will appear. -#. Choose one of the following network types: +#. Choose one of the following zone types: + + - **Core.** Core Zones are intended for Datacenter based deployments and allow the full range of Networking and other functionality in Apache CloudStack. Core zones have a number of prerequisites and rely on the presence of shared storage and helper Instances. For more information see :ref:`core-zone`. + + - **Edge.** Edge Zones are lightweight zones, designed for deploying in edge computing scenarios. They are limited in functionality but have far fewer prerequisites than core zones. Please refer to :ref:`edge-zone`. + +#. If Core Zone is selected, choose one of the following network types: - **Basic.** For AWS-style networking. Provides a single network where each instance is assigned an IP directly from the @@ -526,6 +532,8 @@ Advanced Zone Configuration For Advanced zone, you may chose to select Edge which will allow creating an Edge Zone. If Edge is not selected then wizard will continue creating a Core zone. +.. _core-zone: + Core Zone * @@ -776,6 +784,8 @@ Core Zone #. Click Launch. +.. _edge-zone: + Edge Zone *
[PR] api/ui: add specifyvlan to network response [cloudstack]
weizhouapache opened a new pull request, #10236:
URL: https://github.com/apache/cloudstack/pull/10236
### Description
This PR fixes
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Unable to migrate VM between new host and older hosts , running same versions [cloudstack]
abh1sar commented on issue #9768: URL: https://github.com/apache/cloudstack/issues/9768#issuecomment-2606790448 Hi @hmadra Any update on this? > [@hmadra](https://github.com/hmadra) what's the output of command `stat -fc %T /sys/fs/cgroup/` ? > > also, what's the error message in agent.log on source host ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]
blueorangutan commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607055945 [SF] Trillian test result (tid-12158) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46520 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9823-t12158-kvm-ol8.zip Smoke tests completed. 109 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_migrate_VM_and_root_volume | `Error` | 83.54 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 51.94 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 0.07 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607056737 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607062153 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607687141 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]
Pearl1594 commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607668695 > @Pearl1594 thanks for the update I think the default shared network offerings will be listed, that's good > > Can you test the creation of shared networks with > > * default share network offering (untagged) > > * on tagged physical network ? I was able to deploy a VM on a shared network that was created on Physical network 2 (newly added phy net with tag: phy2) using the default offering "QuickCloudNoServices" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607716226 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
shwstppr commented on code in PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925267671
##
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
##
@@ -103,14 +105,13 @@ public String getProtocol() {
@Override
public List getSourceCidrList() {
-if (cidrlist != null) {
+if (CollectionUtils.isNotEmpty(cidrlist) && (cidrlist.size() == 1 &&
StringUtils.isNotBlank(cidrlist.get(0 {
Review Comment:
Thanks @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
shwstppr commented on code in PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925270112
##
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
##
@@ -103,14 +105,13 @@ public String getProtocol() {
@Override
public List getSourceCidrList() {
-if (cidrlist != null) {
+if (CollectionUtils.isNotEmpty(cidrlist) && (cidrlist.size() == 1 &&
StringUtils.isNotBlank(cidrlist.get(0 {
Review Comment:
I'll add some unit tests to not make a mess of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]
DaanHoogland commented on PR #9823: URL: https://github.com/apache/cloudstack/pull/9823#issuecomment-2607186252 the usage error is failed to download iso, which is not related. the life-cyle ones are intermitted errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage deletion cases [cloudstack]
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607185667 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: add SCSI controllers based on the number of virtio-SCSI disks [cloudstack]
DaanHoogland merged PR #9823: URL: https://github.com/apache/cloudstack/pull/9823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support virtio-blk root disk controller [cloudstack]
blueorangutan commented on PR #10229: URL: https://github.com/apache/cloudstack/pull/10229#issuecomment-2607191986 [SF] Trillian test result (tid-12159) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44051 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10229-t12159-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
DaanHoogland commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607212392 no idea how these are related, @harikrishna-patnala but the build consistently fails :( : ``` 13:14:15 [ERROR] Errors: 13:14:15 [ERROR] SecurityGroupManagerImplTest.CidrCompareTest ? IllegalState Failed to load App... 13:14:15 [ERROR] SecurityGroupManagerImplTest.emptyCidrCompareTest ? IllegalState Failed to loa... 13:14:15 [ERROR] SecurityGroupManagerImplTest.faultyCidrCompareTest ? IllegalState Failed to lo... 13:14:15 [ERROR] SecurityGroupManagerImplTest.sameCidrCompareTest ? IllegalState Failed to load... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix local storage deletion cases [cloudstack]
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607614608 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ui: fix passing vlan while creating vpc tier [cloudstack]
shwstppr opened a new pull request, #10239:
URL: https://github.com/apache/cloudstack/pull/10239
### Description
Currently VLAN was not getting added to API call when offering has
specifyVlan as true
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Error before the fix,
https://github.com/user-attachments/assets/0b7a2579-b1e9-4ff6-a656-1a8bc99aca0c
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]
blueorangutan commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607032035 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]
DaanHoogland commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607029682 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]
codecov[bot] commented on PR #10239: URL: https://github.com/apache/cloudstack/pull/10239#issuecomment-2607040157 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`9967bb3`)](https://app.codecov.io/gh/apache/cloudstack/commit/9967bb3fe899f82ce5fc83da5eba0d278a2df70a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f3eef99`)](https://app.codecov.io/gh/apache/cloudstack/commit/f3eef993c2b3a345d304c9d669c9ed6b8684a3e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 7 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (9967bb3) and HEAD (f3eef99). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (9967bb3) | HEAD (f3eef99) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10239 +/- ## = - Coverage 15.13%4.30% -10.84% = Files 5408 366 -5042 Lines47397429570 -04 Branches 57813 5180-52633 = - Hits 71730 1272-70458 + Misses 39422728154 -366073 + Partials 8017 144 -7873 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10239?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list disk offerings by tags [cloudstack]
blueorangutan commented on PR #10228: URL: https://github.com/apache/cloudstack/pull/10228#issuecomment-2607079669 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
blueorangutan commented on PR #10208: URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2607087850 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
sonarqubecloud[bot] commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607097110 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=9315&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=9315&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=9315&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=9315) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Network rate on VPC tier network offering are ignored [cloudstack]
shwstppr commented on issue #9763:
URL: https://github.com/apache/cloudstack/issues/9763#issuecomment-2607105387
@rajujith I tested this with a 4.19 env and I can see network rate is taken
from the network offering. I used offering with network rate as 350
```
(localcloud) 🐱 > list networkofferings
id=b41609ee-3531-445a-b017-3e6ce975d4e0 filter=id,name,networkrate
{
"count": 1,
"networkoffering": [
{
"id": "b41609ee-3531-445a-b017-3e6ce975d4e0",
"name": "350vpctier",
"networkrate": 350
}
]
}
(localcloud) 🐱 > list networks id=e4603017-5e49-49aa-9e5f-1036d2fef59f
filter=id,networkofferingid,networkofferingname,broadcasturi,
{
"count": 1,
"network": [
{
"broadcasturi": "vlan://1122",
"id": "e4603017-5e49-49aa-9e5f-1036d2fef59f",
"networkofferingid": "b41609ee-3531-445a-b017-3e6ce975d4e0",
"networkofferingname": "350vpctier"
}
]
}
(localcloud) 🐱 > list routers networkid=e4603017-5e49-49aa-9e5f-1036d2fef59f
{
"count": 1,
"router": [
{
"account": "admin",
"created": "2025-01-22T11:27:26+",
"dns1": "8.8.8.8",
"domain": "ROOT",
"domainid": "1be25da3-d6f0-11ef-9850-525400f6925d",
"gateway": "172.120.0.1",
"guestipaddress": "10.1.1.1",
"guestmacaddress": "02:01:00:cf:00:02",
"guestnetmask": "255.255.255.0",
"guestnetworkid": "e4603017-5e49-49aa-9e5f-1036d2fef59f",
"guestnetworkname": "tier1",
"hasannotations": false,
"healthchecksfailed": false,
"hostcontrolstate": "Enabled",
"hostid": "2b8189b2-f5f6-44f3-96f3-a01afb545c37",
"hostname": "qa1-cs419-k-7772c1e9-kvm-host1",
"hypervisor": "KVM",
"id": "99d00d9f-5764-4d72-932d-e69a88fd9990",
"isredundantrouter": false,
"linklocalip": "169.254.242.142",
"linklocalmacaddress": "0e:00:a9:fe:f2:8e",
"linklocalnetmask": "255.255.0.0",
"linklocalnetworkid": "5e76d9dd-29fb-48b4-a724-f498a99370ff",
"name": "r-11-VM",
"networkdomain": "cs2test.domain",
"nic": [
{
"gateway": "169.254.0.1",
"id": "1291fb89-2de6-4986-a475-8a8304d2c247",
"ipaddress": "169.254.242.142",
"isdefault": false,
"macaddress": "0e:00:a9:fe:f2:8e",
"netmask": "255.255.0.0",
"networkid": "5e76d9dd-29fb-48b4-a724-f498a99370ff",
"traffictype": "Control"
},
{
"broadcasturi": "vlan://untagged",
"gateway": "172.120.0.1",
"id": "c20626b9-c1c5-44fc-8f41-37c5b0327edb",
"ipaddress": "172.120.1.3",
"isdefault": true,
"isolationuri": "vlan://untagged",
"macaddress": "1e:00:9a:00:00:80",
"mtu": 1500,
"netmask": "255.255.0.0",
"networkid": "8c077ab0-077a-4de1-82b5-8a45709f8f29",
"traffictype": "Public"
},
{
"broadcasturi": "vlan://1122",
"gateway": "10.1.1.1",
"id": "f21655ce-d21f-486c-9c28-4f6349a2eb8c",
"ipaddress": "10.1.1.1",
"isdefault": false,
"isolationuri": "vlan://1122",
"macaddress": "02:01:00:cf:00:02",
"mtu": 1500,
"netmask": "255.255.255.0",
"networkid": "e4603017-5e49-49aa-9e5f-1036d2fef59f",
"networkname": "tier1",
"traffictype": "Guest",
"type": "Isolated"
}
],
"podid": "c2e28003-3a21-4d4d-8718-fda5422fffd9",
"podname": "Pod",
"publicip": "172.120.1.3",
"publicmacaddress": "1e:00:9a:00:00:80",
"publicnetmask": "255.255.0.0",
"publicnetworkid": "8c077ab0-077a-4de1-82b5-8a45709f8f29",
"redundantstate": "UNKNOWN",
"requiresupgrade": false,
"role": "VIRTUAL_ROUTER",
"scriptsversion": "806566f9bd39aab1932d4c8f9ea98b6e\n",
"serviceofferingid": "6d2c4dab-0eca-467a-9b99-7985b7ccae07",
"serviceofferingname": "System Offering For Software Router",
"softwareversion": "4.19.0.0",
"state": "Running",
"templateid": "1be78aa3-d6f0-11ef-9850-525400f6925d",
"templatename": "SystemVM Template (KVM)",
"version": "4.19.0",
"vpcid": "b43b7a80-10c8-4d8f-8ccf-c933bd760b6d",
"vpcname": "testvpc",
"zoneid": "41ea0c91-725f-419e-9f8d-abcea1ae3bbd",
"zonename": "DC"
}
]
}
```
On the VR VM definition and tc output,
```
[root@qa1-cs419-k-7772c1e9-kvm-host1 ~]# tc -p class show dev vnet4
class htb 1:1 root leaf 2: prio 0 rate 358400Kbit ceil 358400Kbit burst
1523b cburst 1523b
[root@qa1-cs419-k-7772c1e9-kvm-host1 ~]# virs
Re: [PR] Fix local storage deletion cases [cloudstack]
blueorangutan commented on PR #10231: URL: https://github.com/apache/cloudstack/pull/10231#issuecomment-2607075503 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2607116796 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607116797 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (3f668a23abb -> ca472393aec)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 3f668a23abb DO NOT MERGE add 09f154796a2 server: Fix host CPU number (#10218) add 1e59f5cd0cd ui: fix passing vlan while creating vpc tier (#10239) add ca472393aec DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3f668a23abb) \ N -- N -- N refs/heads/healthcheck-4.19 (ca472393aec) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../api/response/HostForMigrationResponse.java | 431 + .../com/cloud/api/query/dao/HostJoinDaoImpl.java | 121 +- ui/src/views/network/VpcTiersTab.vue | 2 +- 3 files changed, 9 insertions(+), 545 deletions(-)
Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]
DaanHoogland commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607538635 @Pearl1594 @weizhouapache , I know I am a bit of a functional hork, but I really think no offerings should be shown if the tags do not match, for any type of network. For any physnet for which tags are being said we could implement some kind of `copyDefaultOfferings()`. Would that make sense? /me not to happy with the conditional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]
sonarqubecloud[bot] commented on PR #10223: URL: https://github.com/apache/cloudstack/pull/10223#issuecomment-2607556534 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10223) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10223&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10223&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10223&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10223&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10223&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10223) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]
DaanHoogland commented on code in PR #10223:
URL: https://github.com/apache/cloudstack/pull/10223#discussion_r1925536402
##
engine/schema/src/main/resources/META-INF/db/schema-41910to41920.sql:
##
@@ -22,5 +22,20 @@
-- Add last_id to the volumes table
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'last_id', 'bigint(20)
unsigned DEFAULT NULL');
-ALTER TABLE `cloud`.`counter` DROP KEY `uc_counter__provider__source__value`;
-CALL `cloud`.`IDEMPOTENT_ADD_UNIQUE_KEY`('cloud.counter',
'uc_counter__provider__source__value_removed', '(provider, source, value,
removed)');
+SELECT
Review Comment:
good call @weizhouapache that will help with a lot of these parallel upgrade
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [API] Incorrect listing of VMs with previous NICs on networks [cloudstack]
DaanHoogland commented on issue #10188: URL: https://github.com/apache/cloudstack/issues/10188#issuecomment-2606735695 fixed in #10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [API] Incorrect listing of VMs with previous NICs on networks [cloudstack]
DaanHoogland closed issue #10188: [API] Incorrect listing of VMs with previous NICs on networks URL: https://github.com/apache/cloudstack/issues/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606733448 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
blueorangutan commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607116790 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,ui: fix empty source cidr value for firewall rule [cloudstack]
weizhouapache commented on code in PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925242694
##
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
##
@@ -103,14 +105,13 @@ public String getProtocol() {
@Override
public List getSourceCidrList() {
-if (cidrlist != null) {
+if (CollectionUtils.isNotEmpty(cidrlist) && (cidrlist.size() == 1 &&
StringUtils.isNotBlank(cidrlist.get(0 {
Review Comment:
I wonder if the check is correct
maybe like
```
if (CollectionUtils.isNotEmpty(cidrlist) && !(cidrlist.size() == 1
&& StringUtils.isBlank(cidrlist.get(0 {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Cloudstack doesn't check availability of Secondary Storage [cloudstack]
vishesh92 commented on issue #9730: URL: https://github.com/apache/cloudstack/issues/9730#issuecomment-2607129158 @top-secrett I was able to reproduce the scenario by removing the SSVM and then deleting the snapshot. This resulted in snapshot not getting deleted from the storage. In this case, the state of the snapshot in `snapshot_store_ref` is in `Destroying` state. We have a storage garbage collector running which checks the `snapshot_store_ref` table where state is `Destroying` and removes the snapshot from the secondary storage. By default, this runs once a day. You can configure it using the following global settings - `storage.cleanup.enabled`, `storage.cleanup.interval` https://github.com/apache/cloudstack/blob/81e052cfebf5bcdb09e1922393a1753eb6707dae/server/src/main/java/com/cloud/storage/StorageManagerImpl.java#L1766 @top-secrett Can you check if the storage garbage collector is enabled in your environment and the stale snapshots on disk gets deleted once it runs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 2FA is enabled even if User fails to verify with TOTP code [cloudstack]
shwstppr commented on issue #9308: URL: https://github.com/apache/cloudstack/issues/9308#issuecomment-2607140588 @scottsignal cc @harikrishna-patnala @borisstoyanov @kiranchavala @vladimirpetrov I've tested this with 4.19.1.3 and could not reproduce it. It must have been solved by https://github.com/apache/cloudstack/commit/ef742210b5d05c064253eb6b0bcf76d282572a33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch list-default-offerings updated (ae061d80529 -> d4b721e9b71)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch list-default-offerings in repository https://gitbox.apache.org/repos/asf/cloudstack.git from ae061d80529 List default network offerings when multiple physical networks for guest traffic type exists add d4b721e9b71 list default offerings only for shared net else old behaviour No new revisions were added by this update. Summary of changes: .../com/cloud/configuration/ConfigurationManagerImpl.java| 12 1 file changed, 8 insertions(+), 4 deletions(-)
Re: [PR] List default network offerings when multiple physical networks for guest traffic type exists [cloudstack]
weizhouapache commented on PR #10222: URL: https://github.com/apache/cloudstack/pull/10222#issuecomment-2607513955 @Pearl1594 thanks for the update I think the default shared network offerings will be listed, that's good Can you test the creation of shared networks with - default share network offering (untagged) - on tagged physical network ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix passing vlan while creating vpc tier [cloudstack]
DaanHoogland merged PR #10239: URL: https://github.com/apache/cloudstack/pull/10239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: ui: fix passing vlan while creating vpc tier (#10239)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 1e59f5cd0cd ui: fix passing vlan while creating vpc tier (#10239) 1e59f5cd0cd is described below commit 1e59f5cd0cd5e6622bee06000512059a656456ae Author: Abhishek Kumar AuthorDate: Wed Jan 22 20:44:04 2025 +0530 ui: fix passing vlan while creating vpc tier (#10239) Signed-off-by: Abhishek Kumar --- ui/src/views/network/VpcTiersTab.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/views/network/VpcTiersTab.vue b/ui/src/views/network/VpcTiersTab.vue index 402f9f06115..ad06e3bdf0b 100644 --- a/ui/src/views/network/VpcTiersTab.vue +++ b/ui/src/views/network/VpcTiersTab.vue @@ -213,7 +213,7 @@ @change="updateMtu()"/> - +
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
codecov[bot] commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606746046 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`d053bb9`)](https://app.codecov.io/gh/apache/cloudstack/commit/d053bb97ecf14ad85f9af2fe6dd521e80117165a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7093406`)](https://app.codecov.io/gh/apache/cloudstack/commit/709340623a353c076c28919f63d5b93d6a2a1393?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ##4.19 #10237 +/- ## == Coverage 4.30%4.30% == Files366 366 Lines 2957029570 Branches5180 5180 == Hits1272 1272 Misses 2815428154 Partials 144 144 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10237/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10237?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Fix to allow actions on the network if it belongs to a project (#9550)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new d053bb97ecf Fix to allow actions on the network if it belongs to a
project (#9550)
d053bb97ecf is described below
commit d053bb97ecf14ad85f9af2fe6dd521e80117165a
Author: Harikrishna
AuthorDate: Wed Aug 21 12:07:31 2024 +0530
Fix to allow actions on the network if it belongs to a project (#9550)
---
ui/src/config/section/network.js | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ui/src/config/section/network.js b/ui/src/config/section/network.js
index 5a3221810be..72eb17e0ae9 100644
--- a/ui/src/config/section/network.js
+++ b/ui/src/config/section/network.js
@@ -140,7 +140,9 @@ export default {
icon: 'edit-outlined',
label: 'label.update.network',
dataView: true,
- disabled: (record, user) => { return (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype)) },
+ disabled: (record, user) => {
+return !record.projectid && (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype))
+ },
popup: true,
component: shallowRef(defineAsyncComponent(() =>
import('@/views/network/UpdateNetwork.vue')))
},
@@ -150,7 +152,9 @@ export default {
label: 'label.restart.network',
message: 'message.restart.network',
dataView: true,
- disabled: (record, user) => { return (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype)) },
+ disabled: (record, user) => {
+return !record.projectid && (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype))
+ },
args: (record, store, isGroupAction) => {
var fields = []
if (isGroupAction || record.vpcid == null) {
@@ -189,7 +193,9 @@ export default {
label: 'label.action.delete.network',
message: 'message.action.delete.network',
dataView: true,
- disabled: (record, user) => { return (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype)) },
+ disabled: (record, user) => {
+return !record.projectid && (record.account !==
user.userInfo.account && !['Admin',
'DomainAdmin'].includes(user.userInfo.roletype))
+ },
groupAction: true,
popup: true,
groupMap: (selection) => { return selection.map(x => { return { id:
x } }) }
Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]
blueorangutan commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606683170 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM cross cluster migration not working [cloudstack]
weizhouapache commented on issue #10078: URL: https://github.com/apache/cloudstack/issues/10078#issuecomment-2606680174 @ahmedali6 I am able to reproduce the issue  I will work on the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
harikrishna-patnala commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606729632 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Decrypt zone, cluster, storage details for configuration values [cloudstack]
blueorangutan commented on PR #10237: URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2606866947 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2606873481 [SF] Trillian test result (tid-12155) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 65736 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12155-xcpng82.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 170.59 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 176.50 | test_cluster_drs.py test_14_retrieve_vr_one_file | `Failure` | 4.19 | test_diagnostics.py test_15_retrieve_ssvm_default_files | `Failure` | 4.22 | test_diagnostics.py test_16_retrieve_ssvm_single_file | `Failure` | 3.18 | test_diagnostics.py test_17_retrieve_cpvm_default_files | `Failure` | 4.21 | test_diagnostics.py test_18_retrieve_cpvm_single_file | `Failure` | 3.18 | test_diagnostics.py test_01_non_strict_host_anti_affinity | `Error` | 239.49 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 117.77 | test_nonstrict_affinity_group.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix scale vm with same disk offering id [cloudstack]
weizhouapache commented on PR #10235: URL: https://github.com/apache/cloudstack/pull/10235#issuecomment-2607414902 thanks @borisstoyanov if there is no smoke test failures, let's merge @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch fix-create-counters-dup updated (fdb9a717b99 -> 7a1e54d3154)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch fix-create-counters-dup in repository https://gitbox.apache.org/repos/asf/cloudstack.git from fdb9a717b99 fix api response add 7a1e54d3154 drop unique key only if it exists No new revisions were added by this update. Summary of changes: .../resources/META-INF/db/schema-41910to41920.sql | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-)
Re: [PR] Allow counters to be created with same name, provider and source as a deleted one [cloudstack]
weizhouapache commented on code in PR #10223:
URL: https://github.com/apache/cloudstack/pull/10223#discussion_r1925433477
##
engine/schema/src/main/resources/META-INF/db/schema-41910to41920.sql:
##
@@ -22,5 +22,20 @@
-- Add last_id to the volumes table
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'last_id', 'bigint(20)
unsigned DEFAULT NULL');
-ALTER TABLE `cloud`.`counter` DROP KEY `uc_counter__provider__source__value`;
-CALL `cloud`.`IDEMPOTENT_ADD_UNIQUE_KEY`('cloud.counter',
'uc_counter__provider__source__value_removed', '(provider, source, value,
removed)');
+SELECT
Review Comment:
@Pearl1594
maybe we can add a procedure similar as
https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/resources/META-INF/db/procedures/cloud.idempotent_drop_foreign_key.sql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS: use --delete-emptydir-data instead of deprecated --delete-local-data [cloudstack]
weizhouapache commented on PR #10234: URL: https://github.com/apache/cloudstack/pull/10234#issuecomment-2606682110 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] list disk offerings by tags [cloudstack]
blueorangutan commented on PR #10228: URL: https://github.com/apache/cloudstack/pull/10228#issuecomment-2606845146 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]
sureshanaparti commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607329531 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]
blueorangutan commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607330784 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]
sureshanaparti opened a new pull request, #10240:
URL: https://github.com/apache/cloudstack/pull/10240
### Description
This PR improves listing of HA and non-HA hosts when ha.tag setting is
defined and hosts have multiple tags along with ha tag.
Fixes #10070
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag [cloudstack]
codecov[bot] commented on PR #10240: URL: https://github.com/apache/cloudstack/pull/10240#issuecomment-2607345484 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`91f1ada`)](https://app.codecov.io/gh/apache/cloudstack/commit/91f1adab862e3be5ee9931ca97b9eac920550757?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cd2cfa1`)](https://app.codecov.io/gh/apache/cloudstack/commit/cd2cfa1f635e858b9e2daa9f637dade8e6cb6c83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (91f1ada) and HEAD (cd2cfa1). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (91f1ada) | HEAD (cd2cfa1) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10240 +/- ## = - Coverage 15.13%4.30% -10.84% = Files 5408 366 -5042 Lines47400729570 -37 Branches 57822 5180-52642 = - Hits 71745 1272-70473 + Misses 39424128154 -366087 + Partials 8021 144 -7877 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10240/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10240/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10240/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10240?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
