Re: [PR] Bump ip from 1.1.8 to 1.1.9 in /ui [cloudstack]

2024-02-22 Thread via GitHub


dependabot[bot] commented on PR #8693:
URL: https://github.com/apache/cloudstack/pull/8693#issuecomment-1959224713

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch dependabot/npm_and_yarn/ui/ip-1.1.9 deleted (was c8d974abe0a)

2024-02-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch dependabot/npm_and_yarn/ui/ip-1.1.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


 was c8d974abe0a Bump ip from 1.1.8 to 1.1.9 in /ui

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



Re: [PR] Linstor: add HA support and small cleanups [cloudstack]

2024-02-22 Thread via GitHub


rohityadavcloud commented on PR #8407:
URL: https://github.com/apache/cloudstack/pull/8407#issuecomment-1959224441

   Hi @rp- @Philipp-Reisner quick question - does Linstor currently support VM 
HA with ACS 4.18/4.19? cc @harikrishna-patnala @borisstoyanov @NuxRo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ip from 1.1.8 to 1.1.9 in /ui [cloudstack]

2024-02-22 Thread via GitHub


rohityadavcloud closed pull request #8693: Bump ip from 1.1.8 to 1.1.9 in /ui
URL: https://github.com/apache/cloudstack/pull/8693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Linstor: add HA support and small cleanups [cloudstack]

2024-02-22 Thread via GitHub


rp- commented on PR #8407:
URL: https://github.com/apache/cloudstack/pull/8407#issuecomment-1959253089

   @rohityadavcloud
   Not in any released version, this patchset here is needed and also this fix 
here to get it working with larger setups:
   https://github.com/apache/cloudstack/pull/8670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ip from 1.1.8 to 1.1.9 in /ui [cloudstack]

2024-02-22 Thread via GitHub


rohityadavcloud commented on PR #8693:
URL: https://github.com/apache/cloudstack/pull/8693#issuecomment-1959259181

   @dependabot ignore this major version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ip from 1.1.8 to 1.1.9 in /ui [cloudstack]

2024-02-22 Thread via GitHub


dependabot[bot] commented on PR #8693:
URL: https://github.com/apache/cloudstack/pull/8693#issuecomment-1959259328

   OK, I won't notify you about version 1.x.x again, unless you re-open this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


vladimirpetrov commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1959790938

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


blueorangutan commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1959793064

   @vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


blueorangutan commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1959900717

   Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) 01/01: NSX: Cleanup PF rule associated to an expunged VM

2024-02-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-cleanup-PF
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 3c2bf12a930b19e3a8ea4cf9f2e130d7436883c2
Author: Pearl Dsilva 
AuthorDate: Thu Feb 22 11:40:30 2024 -0500

NSX: Cleanup PF rule associated to an expunged VM
---
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java| 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
index 571e68496d6..40e4a5d2e44 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
@@ -509,8 +509,7 @@ public class NsxElement extends AdapterBase implements  
DhcpServiceProvider, Dns
 for (PortForwardingRule rule : rules) {
 IPAddressVO publicIp = 
ApiDBUtils.findIpAddressById(rule.getSourceIpAddressId());
 UserVm vm = ApiDBUtils.findUserVmById(rule.getVirtualMachineId());
-if ((vm == null && (rule.getState() != FirewallRule.State.Revoke)) 
||
-(vm != null && networkModel.getNicInNetwork(vm.getId(), 
network.getId()) == null)) {
+if (vm == null && rule.getState() != FirewallRule.State.Revoke) {
 continue;
 }
 NsxOpObject nsxObject = getNsxOpObject(network);



(cloudstack) branch fr03-cleanup-PF created (now 3c2bf12a930)

2024-02-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch fr03-cleanup-PF
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at 3c2bf12a930 NSX: Cleanup PF rule associated to an expunged VM

This branch includes the following new commits:

 new 3c2bf12a930 NSX: Cleanup PF rule associated to an expunged VM

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack) branch fr03-cleanup-PF-udp-lb created (now 702a2cb2d4b)

2024-02-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch fr03-cleanup-PF-udp-lb
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at 702a2cb2d4b NSX: Cleanup PF rule associated to an expunged VM

This branch includes the following new commits:

 new 70c0a40a814 FR03: Add UDP LB rules
 new 702a2cb2d4b NSX: Cleanup PF rule associated to an expunged VM

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack) 01/02: FR03: Add UDP LB rules

2024-02-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-cleanup-PF-udp-lb
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 70c0a40a8142a4b8f3f8f0f6bb134c86cba35940
Author: Pearl Dsilva 
AuthorDate: Thu Feb 22 13:11:46 2024 -0500

FR03: Add UDP LB rules
---
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java   | 2 ++
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java
index fe02948b989..6091130c476 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java
@@ -629,6 +629,8 @@ public class NsxApiClient {
 LBUdpMonitorProfile lbUdpMonitorProfile = new 
LBUdpMonitorProfile.Builder(UDP_MONITOR_PROFILE)
 .setDisplayName(lbMonitorProfileId)
 .setMonitorPort(Long.parseLong(port))
+.setSend("")
+.setReceive("")
 .build();
 lbActiveMonitor.patch(lbMonitorProfileId, lbUdpMonitorProfile);
 }
diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
index ce27a7ddd24..76e28d59c9f 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
@@ -664,7 +664,7 @@ public class NsxElement extends AdapterBase implements  
DhcpServiceProvider, Dns
 
.setPublicPort(String.valueOf(loadBalancingRule.getSourcePortStart()))
 
.setPrivatePort(String.valueOf(loadBalancingRule.getDefaultPortStart()))
 .setRuleId(loadBalancingRule.getId())
-
.setProtocol(loadBalancingRule.getProtocol().toUpperCase(Locale.ROOT))
+
.setProtocol(loadBalancingRule.getLbProtocol().toUpperCase(Locale.ROOT))
 .setAlgorithm(loadBalancingRule.getAlgorithm())
 .build();
 if (loadBalancingRule.getState() == FirewallRule.State.Add) {



(cloudstack) 02/02: NSX: Cleanup PF rule associated to an expunged VM

2024-02-22 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-cleanup-PF-udp-lb
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 702a2cb2d4b2f666e2b64c33f7d2ad612ff6f82f
Author: Pearl Dsilva 
AuthorDate: Thu Feb 22 11:40:30 2024 -0500

NSX: Cleanup PF rule associated to an expunged VM
---
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java| 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
index 76e28d59c9f..f69cc0d1bef 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
@@ -535,8 +535,7 @@ public class NsxElement extends AdapterBase implements  
DhcpServiceProvider, Dns
 for (PortForwardingRule rule : rules) {
 IPAddressVO publicIp = 
ApiDBUtils.findIpAddressById(rule.getSourceIpAddressId());
 UserVm vm = ApiDBUtils.findUserVmById(rule.getVirtualMachineId());
-if ((vm == null && (rule.getState() != FirewallRule.State.Revoke)) 
||
-(vm != null && networkModel.getNicInNetwork(vm.getId(), 
network.getId()) == null)) {
+if (vm == null && rule.getState() != FirewallRule.State.Revoke) {
 continue;
 }
 NsxOpObject nsxObject = getNsxOpObject(network);



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


vladimirpetrov commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1960432127

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


blueorangutan commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1960432435

   @vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added JS Script to pick Favicon, Title from config file [cloudstack]

2024-02-22 Thread via GitHub


blueorangutan commented on PR #7418:
URL: https://github.com/apache/cloudstack/pull/7418#issuecomment-1960507814

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8740


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] CKS Dashboard Issue [cloudstack]

2024-02-22 Thread via GitHub


th3cod3r commented on issue #8684:
URL: https://github.com/apache/cloudstack/issues/8684#issuecomment-1960776945

   @weizhouapache 
   
   Thanks for the suggestion, It is resolved now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] CKS Dashboard Issue [cloudstack]

2024-02-22 Thread via GitHub


th3cod3r closed issue #8684: CKS Dashboard Issue
URL: https://github.com/apache/cloudstack/issues/8684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] max connection problem on haproxy acs 4.17.2 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland closed issue #8571: max connection problem on haproxy acs 4.17.2
URL: https://github.com/apache/cloudstack/issues/8571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] max connection problem on haproxy acs 4.17.2 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland commented on issue #8571:
URL: https://github.com/apache/cloudstack/issues/8571#issuecomment-1960857575

   @meisammaleki , I am closing this, please reopen or create a new issue if 
you feel there is still a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Kubernetes scale up on 4.17.2.0 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland closed issue #7504: Kubernetes scale up on 4.17.2.0
URL: https://github.com/apache/cloudstack/issues/7504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Kubernetes scale up on 4.17.2.0 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland commented on issue #7504:
URL: https://github.com/apache/cloudstack/issues/7504#issuecomment-1960859651

   @tuanhoangth1603 , as it seems to work on current environement, I am closing 
this issue. Please reopen or open a new one if you feel there is still a 
problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Error when deleting former 4.16.1 volume snapshot from 4.17.1 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland commented on issue #6804:
URL: https://github.com/apache/cloudstack/issues/6804#issuecomment-1960863375

   @levindecaro , as there is a workaround and this seems to be an old issue, I 
am closing it. Please reopen or create a new one if there still is a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Error when deleting former 4.16.1 volume snapshot from 4.17.1 [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland closed issue #6804: Error when deleting former 4.16.1 volume 
snapshot from 4.17.1
URL: https://github.com/apache/cloudstack/issues/6804


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Version 4.18 uses glusterfs10.4 as the primary storage and cannot create VM [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland closed issue #7596: Version 4.18 uses glusterfs10.4 as the primary 
storage and cannot create VM
URL: https://github.com/apache/cloudstack/issues/7596


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Version 4.18 uses glusterfs10.4 as the primary storage and cannot create VM [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland commented on issue #7596:
URL: https://github.com/apache/cloudstack/issues/7596#issuecomment-1960870527

   @maic closing this as a work around has been provided. Please reopen or 
create a new one of you feel this is still a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Linstor 4.19 fix script alllines [cloudstack]

2024-02-22 Thread via GitHub


DaanHoogland commented on code in PR #8670:
URL: https://github.com/apache/cloudstack/pull/8670#discussion_r1500311341


##
utils/src/test/java/com/cloud/utils/ScriptTest.java:
##
@@ -111,6 +111,20 @@ public String interpret(BufferedReader reader) throws 
IOException {
 Assert.assertNotNull(value);
 }
 
+@Test
+public void executeWithOutputInterpreterAllLinesParserLargeOutput() {
+Assume.assumeTrue(SystemUtils.IS_OS_LINUX);
+OutputInterpreter.AllLinesParser parser = new 
OutputInterpreter.AllLinesParser();
+Script script = new Script("seq");
+script.add("-f");
+script.add("my text to test cloudstack %g");
+script.add("4096"); // AllLinesParser doesn't work with that amount of 
data
+String value = script.execute(parser);
+// it is a stack trace in this case as string
+Assert.assertNull(value);
+Assert.assertEquals(129965, parser.getLines().length());

Review Comment:
   @rp- how can you be sure of this value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org