(cloudstack) 01/01: NSX: Cleanup PF rule associated to an expunged VM

[pearl11594]

This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch fr03-cleanup-PF
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 3c2bf12a930b19e3a8ea4cf9f2e130d7436883c2
Author: Pearl Dsilva <pearl1...@gmail.com>
AuthorDate: Thu Feb 22 11:40:30 2024 -0500

    NSX: Cleanup PF rule associated to an expunged VM
---
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
index 571e68496d6..40e4a5d2e44 100644
--- 
a/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
+++ 
b/plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java
@@ -509,8 +509,7 @@ public class NsxElement extends AdapterBase implements  
DhcpServiceProvider, Dns
         for (PortForwardingRule rule : rules) {
             IPAddressVO publicIp = 
ApiDBUtils.findIpAddressById(rule.getSourceIpAddressId());
             UserVm vm = ApiDBUtils.findUserVmById(rule.getVirtualMachineId());
-            if ((vm == null && (rule.getState() != FirewallRule.State.Revoke)) 
||
-                    (vm != null && networkModel.getNicInNetwork(vm.getId(), 
network.getId()) == null)) {
+            if (vm == null && rule.getState() != FirewallRule.State.Revoke) {
                 continue;
             }
             NsxOpObject nsxObject = getNsxOpObject(network);