[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name
eric_niebler added a comment. > It seems to me like the warning is valid, even though we use precompiled > headers. Agreed. Repository: rC Clang https://reviews.llvm.org/D48903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame
eric_niebler accepted this revision. eric_niebler added a comment. This revision is now accepted and ready to land. Looks ok to me. https://reviews.llvm.org/D39768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D7573: [libc++] Fix PR20084 - std::is_function failed.
eric_niebler added a comment.
I just ran into this problem while trying to get range-v3 working on clang-3.6.
This `is_function` implementation //probably// instantiates fewer templates
than the version currently shipping with libc++. Disclaimer: I haven't tested
it exhaustively yet.
template
struct priority_tag
: priority_tag
{};
template<>
struct priority_tag<0>
{};
// Function types here:
template
char (&is_function_impl_(priority_tag<0>))[1];
// Array types here:
template
char (&is_function_impl_(priority_tag<1>))[2];
// Anything that can be returned from a function here (including
// void and reference types):
template
char (&is_function_impl_(priority_tag<2>))[3];
// Classes and unions (including abstract types) here:
template
char (&is_function_impl_(priority_tag<3>))[4];
template
struct is_function
: integral_constant(priority_tag<3>{}))
== 1>
{};
https://reviews.llvm.org/D7573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D41820: [coroutines] Pass coro func args to promise ctor
eric_niebler added a comment. > Is this behavior specified somewhere? Or are we simply adding an extension to > Clang? It is not specified anywhere //yet// but Gor has promised a paper for Jacksonville. > If so I would really prefer to add my co_promise solution (but I need to > write a paper in favor of it first). I have no problem with you making a separate proposal. I don't consider this an either/or thing. Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters
eric_niebler added a subscriber: karies.
eric_niebler added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1983
+ isLeadingSeparator = false;
+else
+ Path.append(Component);
What happens on Windows for an absolute path like "C:/hello/world.h", I wonder?
Does this correctly generate the fixit? @karies?
Comment at: test/Lexer/case-insensitive-include-pr31836.sh:8
+// CHECK: warning: non-portable path to file
+// CHECK-NOT: Ccase-insensitive-include-pr31836.h
+// CHECK: {{$}}
@twoh I'm curious why you chose to check that the output was not a specific
incorrect answer instead of checking that the output was the correct answer.
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters
eric_niebler added a comment. My question was more about whether the code is correct for absolute paths on Windows, not about whether this particular test would pass or fail. Have you tested an incorrectly-cased absolute path on a Windows machine? https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters
eric_niebler accepted this revision. eric_niebler added a comment. This revision is now accepted and ready to land. Nope looks good. https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps
eric_niebler added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:401 + } + /// \brief Look up a subframework for the specified \#include file. Why not just add a `, bool *IsMapped = nullptr` parameter to the existing `LookupFile`? https://reviews.llvm.org/D32263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
