[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-18 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

Nick Clifton  changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Nick Clifton  ---
(In reply to David Blaikie from comment #12)
Hi David,

> > One question - what is the .addrsig directive ?  It is in the foo.s file
> > that you uploaded (near the end) but gas does not recognise it.
> 
> Here's the documentation for the addrsig LLVM extension:
> https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-
> significance-table

Thanks for the reference.  This is obviously a new feature, so it will
need a new PR being filed.  Ideally of course someone from the LLVM
community will offer a patch to add the feature, but if that does not
happen then I will put it on my (long) list of things to do.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25673] strip-new: SIGSEGV in _bfd_elf_write_secondary_reloc_section (elf.c:12676)

2020-03-18 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25673

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ac4bf06ca22b641b10fe37763bf57e177ee22864

commit ac4bf06ca22b641b10fe37763bf57e177ee22864
Author: Nick Clifton 
Date:   Wed Mar 18 12:12:07 2020 +

Fix seg-fault in strip when copying a file containing corrupt secondary
relocs.

PR 25673
* elf.c (_bfd_elf_write_secondary_reloc_section): Fix illegal
memory access when processing a corrupt secondary reloc section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25673] strip-new: SIGSEGV in _bfd_elf_write_secondary_reloc_section (elf.c:12676)

2020-03-18 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25673

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Nick Clifton  ---
Hi Chien,

  Thanks for reporting this problem.  I have checked in a patch to fix the bug.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25681] aarch64: -q option cause assertion fail in elf.c:6233

2020-03-18 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25681

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #2 from Nick Clifton  ---
Created attachment 12387
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12387&action=edit
Proposed patch

Hi baratharon,

  I have uploaded a small fix for the problem.  Please try it out
  and see if the results are what you need.

  The solution is not perfect, but I do not have time at the moment
  to track down the true cause of the problem.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25681] aarch64: -q option cause assertion fail in elf.c:6233

2020-03-18 Thread baratharon at caesar dot elte.hu
https://sourceware.org/bugzilla/show_bug.cgi?id=25681

--- Comment #3 from baratharon at caesar dot elte.hu ---
Hi Nick,
it works now, the assert is gone.

Thanks,
Aron

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/25676] binutils can't handle the split/linked nature of the debug-records for variables whose (separate) extern-decl and definition are found in the same compilation unit

2020-03-18 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25676

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #1 from Nick Clifton  ---
Created attachment 12388
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12388&action=edit
Proposed patch

Hi cialdi,

  I think that this problem is occuring because of the use of the
  DW_AT_specification attribute in the DWARF info for the global
  external variable.  At the moment, this attribute is not supported.

  Please could you try the uploaded patch which should add support
  for this attribute.  I am still running tests locally, but the
  results so far look good.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 19577 in oss-fuzz: binutils:fuzz_bfd: Out-of-memory in fuzz_bfd

2020-03-18 Thread sheriffbot via monorail
Updates:
Labels: -restrict-view-commit

Comment #4 on issue 19577 by sheriffbot: binutils:fuzz_bfd: Out-of-memory in 
fuzz_bfd
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19577#c4

This bug has exceeded our disclosure deadline. It has been opened to the public.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug gas/25614] dwarf-5 allows for .file 0

2020-03-18 Thread dblaikie at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=25614

--- Comment #14 from David Blaikie  ---
(In reply to Nick Clifton from comment #13)
> (In reply to David Blaikie from comment #12)
> Hi David,
> 
> > > One question - what is the .addrsig directive ?  It is in the foo.s file
> > > that you uploaded (near the end) but gas does not recognise it.
> > 
> > Here's the documentation for the addrsig LLVM extension:
> > https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-
> > significance-table
> 
> Thanks for the reference.  This is obviously a new feature, so it will
> need a new PR being filed.  Ideally of course someone from the LLVM
> community will offer a patch to add the feature, but if that does not
> happen then I will put it on my (long) list of things to do.
> 
> Cheers
>   Nick

*nod* seems unlikely it'd be a high priority for participants either project,
unless GCC folks find the feature itself to be valuable, want to implement it
in gold/binutils ld, etc.

Arguably LLVM/Clang could probably use a mode (& probably should be the default
behavior for -fno-integrated-as, though overridable) that produces binutils
as-compatible assembly & skip features like this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25694] New: R_RISCV_TPREL_HI20 relocations cause riscv64 to add TEXTREL bit on executables

2020-03-18 Thread slyfox at inbox dot ru
https://sourceware.org/bugzilla/show_bug.cgi?id=25694

Bug ID: 25694
   Summary: R_RISCV_TPREL_HI20 relocations cause riscv64 to add
TEXTREL bit on executables
   Product: binutils
   Version: 2.34
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: slyfox at inbox dot ru
  Target Milestone: ---
  Host: x86_64-pc-linux-gnu
Target: riscv64-unknown-linux-gnu
 Build: x86_64-pc-linux-gnu

Initial bug is reported as a https://bugs.gentoo.org/713082 where gdb-9.1 was
observed to be complied with TEXTRELs. Here is the minimal reproducer:

// $ cat a.cc
static int a () { return 1; }

static thread_local int (*tlf) () = &a;

int main(void) { return tlf(); }
[sf] /tmp/z:cat a.cc
static int a () { return 1; }

static thread_local int (*tlf) () = &a;

int main(void) { return tlf(); }

$ riscv64-unknown-linux-gnu-g++ a.cc -o a -Wl,-z,text -pie -fPIE
/usr/libexec/gcc/riscv64-unknown-linux-gnu/ld: read-only segment has dynamic
relocations
collect2: error: ld returned 1 exit status

$ riscv64-unknown-linux-gnu-g++ -S a.cc -o a.S -Wl,-z,text -pie -fPIE
$ cat a.S
...
main:
...
lui a5,%tprel_hi(_ZL3tlf)
add a5,a5,tp,%tprel_add(_ZL3tlf)
ld  a5,%tprel_lo(_ZL3tlf)(a5)
jalra5
...


I assume it's a binutils deficiency as I see no relocations in read-only
sections:

$ riscv64-unknown-linux-gnu-g++ a.cc -o a -pie -fPIE
/usr/libexec/gcc/riscv64-unknown-linux-gnu/ld: warning: creating a DT_TEXTREL
in object
$ LANG=C objdump -D -R a | egrep 'R_RISC|section ' | egrep -A2 'section '
Disassembly of section .interp:
Disassembly of section .note.ABI-tag:
Disassembly of section .gnu.hash:
Disassembly of section .dynsym:
Disassembly of section .dynstr:
Disassembly of section .gnu.version:
Disassembly of section .gnu.version_r:
Disassembly of section .rela.dyn:
Disassembly of section .rela.plt:
Disassembly of section .plt:
Disassembly of section .text:
Disassembly of section .rodata:
Disassembly of section .eh_frame_hdr:
Disassembly of section .eh_frame:
Disassembly of section .tdata:
1da0: R_RISCV_RELATIVE  *ABS*+0x72a
Disassembly of section .preinit_array:
1da8: R_RISCV_RELATIVE  *ABS*+0x68e
Disassembly of section .init_array:
1db0: R_RISCV_RELATIVE  *ABS*+0x728
Disassembly of section .fini_array:
1db8: R_RISCV_RELATIVE  *ABS*+0x6ee
Disassembly of section .dynamic:
Disassembly of section .data:
2000: R_RISCV_RELATIVE  *ABS*+0x2000
Disassembly of section .got:
2018: R_RISCV_JUMP_SLOT __libc_start_main@GLIBC_2.27
2020: R_RISCV_JUMP_SLOT __stack_chk_fail@GLIBC_2.27
--
Disassembly of section .bss:
Disassembly of section .comment:
0: R_RISCV_NONE *ABS*


riscv_elf_check_relocs() is probably too conservative at attributing
thread_local relocations in PIEs as TEXTRELs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25694] R_RISCV_TPREL_HI20 relocations cause riscv64 to add TEXTREL bit on executables

2020-03-18 Thread slyfox at inbox dot ru
https://sourceware.org/bugzilla/show_bug.cgi?id=25694

Sergei Trofimovich  changed:

   What|Removed |Added

 CC||palmer at dabbelt dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25694] R_RISCV_TPREL_HI20 relocations cause riscv64 to add TEXTREL bit on executables

2020-03-18 Thread slyfox at inbox dot ru
https://sourceware.org/bugzilla/show_bug.cgi?id=25694

Sergei Trofimovich  changed:

   What|Removed |Added

 CC||andrew at sifive dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.