Re: [PATCH 2/2] tpm: Implement tpm_auto_start() for TPMv1.2

2023-02-21 Thread Simon Glass
Hi Ilias, On Tue, 21 Feb 2023 at 06:03, Ilias Apalodimas wrote: > > Hi Simon, > > On Mon, Feb 20, 2023 at 02:27:36PM -0700, Simon Glass wrote: > > Add an implementation of this, moving the common call to tpm_init() up > > into the common API implementation. > > >

Re: [PATCH 2/2] tpm: Implement tpm_auto_start() for TPMv1.2

2023-02-21 Thread Simon Glass
230218152741.528191-4-ilias.apalodi...@linaro.org/ > > Thanks > /Ilias > > On Tue, 21 Feb 2023 at 15:08, Simon Glass wrote: > > > > Hi Ilias, > > > > On Tue, 21 Feb 2023 at 06:03, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > >

[PATCH v2 2/2] tpm: Implement tpm_auto_start() for TPMv1.2

2023-02-21 Thread Simon Glass
Add an implementation of this, moving the common call to tpm_init() up into the common API implementation. Add a test. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to master - Drop unnecessary if...return include/tpm-common.h | 2 +- include/tpm-v1.h | 11 +++ lib/tpm

[PATCH v2 1/2] tpm: Separate out the TPM tests for v1 and v2

2023-02-21 Thread Simon Glass
report_state feature. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/test.dts | 4 +++ test/dm/tpm.c | 60 +-- 2 files changed, 55 insertions(+), 9 deletions(-) diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts

Re: [PATCH v2] tpm: Allow committing non-volatile data

2023-02-21 Thread Simon Glass
Hi Ilias, On Tue, 21 Feb 2023 at 06:58, Ilias Apalodimas wrote: > > Hi Simon, > > On Mon, Feb 20, 2023 at 09:31:24AM -0700, Simon Glass wrote: > > Add an option to tell the TPM to commit non-volatile data immediately it > > is changed, rather than waiting until later

Re: [PATCH v2] tpm: Allow committing non-volatile data

2023-02-21 Thread Simon Glass
Hi Ilias, On Tue, 21 Feb 2023 at 07:18, Ilias Apalodimas wrote: > > Hi Simon, > > We had that discussion in the past. > > > On Tue, 21 Feb 2023 at 16:09, Simon Glass wrote: > > > > Hi Ilias, > > > > On Tue, 21 Feb 2023 at 06:58, Ilias Apalodimas >

Re: [PATCH v5 1/1] video console: refactoring and optimization

2023-02-21 Thread Simon Glass
_normal.c | 150 -- > drivers/video/console_rotate.c | 308 > drivers/video/vidconsole_internal.h | 95 + > 5 files changed, 324 insertions(+), 376 deletions(-) > create mode 100644 drivers/video/console_core.c > create mode 100644 drivers/video/vidconsole_internal.h Reviewed-by: Simon Glass

Re: [PATCH v2 9/9] usb: xhci: Fix root hub descriptor

2023-02-21 Thread Simon Glass
Hi Mark, On Tue, 21 Feb 2023 at 02:28, Mark Kettenis wrote: > > > Date: Tue, 21 Feb 2023 01:46:22 +0100 > > From: Marek Vasut > > Hi Marek, > > > On 2/21/23 00:45, Simon Glass wrote: > > > On Sat, 21 Jan 2023 at 12:28, Mark Kettenis wrote: > &

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

2023-02-21 Thread Simon Glass
Hi Vagrant, On Mon, 20 Feb 2023 at 09:21, Simon Glass wrote: > > Hi Vagrant, > > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: > > > > On 2022-12-07, Simon Glass wrote: > > > Drop the use of scripts and rely on standard boot for all operatio

Re: [PATCH v2] binman: bintool: Add support for tool directories

2023-02-21 Thread Simon Glass
Hi Neha, On Fri, 17 Feb 2023 at 04:46, Neha Malcom Francis wrote: > > Currently, bintool supports external compilable tools as single > executable files. Adding support for git repos that can be used to run > non-compilable scripting tools that cannot otherwise be present in > binman. > > Signed-

Re: [PATCH] binman: Avoid requiring a home directory on startup

2023-02-21 Thread Simon Glass
Hi Quentin, On Mon, 20 Feb 2023 at 04:15, Quentin Schulz wrote: > > Hi Simon, > > On 2/18/23 00:49, Simon Glass wrote: > > Hi Quentin, > > > > On Fri, 17 Feb 2023 at 05:21, Quentin Schulz > > wrote: > >> > >> Hi all, > >> > &g

Re: [PATCH 3/9] binman: Use correct argument name in docstrings

2023-02-21 Thread Simon Glass
changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/9] binman: Remove redundant SetAllowFakeBlob from blob-ext entry

2023-02-21 Thread Simon Glass
> 1 file changed, 8 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 3/4 v4] tpm: sandbox: Change the return code when device is already open

2023-02-21 Thread Simon Glass
; --- > Changes since v3: > - New patch. Required for [4/4] > > drivers/tpm/tpm2_tis_sandbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Simon Glass
Hi Tom, On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > This converts 1 usage of this option to the non-SPL form, since there is > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > &

Re: [PATCH 4/9] binman: Override CheckOptional in fit entry

2023-02-21 Thread Simon Glass
ff-by: Jonas Karlman > --- > tools/binman/etype/fit.py | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Simon Glass Do we need a test for this?

Re: [PATCH 1/1] sandbox: allow building sandbox_spl with CONFIG_DEBUG

2023-02-21 Thread Simon Glass
-off-by: Heinrich Schuchardt > --- > configs/sandbox_spl_defconfig | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 1/1] sandbox: fix building with CONFIG_SPL_TIMER=y

2023-02-21 Thread Simon Glass
Hi Heinrich, On Sat, 18 Feb 2023 at 02:34, Heinrich Schuchardt wrote: > > Building sandbox_defconfig with CONFIG_SPL_TIMER=y results in an error > > include/dm/platdata.h:63:33: error: static assertion failed: > "Cannot use U_BOOT_DRVINFO with of-platdata. > Please use devicetree inst

Re: [PATCH 3/3] remoteproc: Remove legacy probing method

2023-02-21 Thread Simon Glass
teproc-framework.rst | 29 --- > drivers/remoteproc/rproc-uclass.c | 18 +--- > drivers/remoteproc/sandbox_testproc.c | 10 --- > include/remoteproc.h | 2 -- > 4 files changed, 1 insertion(+), 58 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-02-21 Thread Simon Glass
l # HTC One X T30 > Signed-off-by: Svyatoslav Ryhel > --- > drivers/input/Kconfig | 2 +- > drivers/input/button_kbd.c | 10 -- > 2 files changed, 5 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 2/9] binman: Fix spelling of nodes in code comments

2023-02-21 Thread Simon Glass
+- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 4/4 v4] test: add a test for the new tpm_auto_start() function

2023-02-21 Thread Simon Glass
h > > test/dm/tpm.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Simon Glass (with my patches on top)

Re: [PATCH 1/1] dm: core: revert "Don't inline dev_read...() calls with of-platdata"

2023-02-21 Thread Simon Glass
Hi Heinrich, On Sat, 18 Feb 2023 at 02:17, Heinrich Schuchardt wrote: > > Compiling sandbox_defconfig with CONFIG_SPL_MMC=y results in > > drivers/mmc/mmc-uclass.c:211: > undefined reference to `dev_read_u32_default' > > Revert the fraudulent patch. > > Fixes: ef79ef21a852 ("dm: core: Don

Re: [PATCH 1/4 v4] tpm: add a function that performs selftest + startup

2023-02-21 Thread Simon Glass
--- > Changes since v3: > - Limit comments to 80 columns > - drop extra lines from comments > include/tpm-v2.h | 16 > include/tpm_api.h | 8 > lib/tpm-v2.c | 25 +++++ > lib/tpm_api.c | 8 > 4 files changed, 57 insertions(+) Reviewed-by: Simon Glass (with my two patches on top)

Re: [PATCH 1/3] remoteproc: Move rproc_cfg_arr out of the uclass header

2023-02-21 Thread Simon Glass
changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

[PATCH v2 1/4] buildman: Add a note about the out-env file

2023-02-21 Thread Simon Glass
This file holds the environment used when doing a build. Add a note about it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/buildman.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/buildman/buildman.rst b/tools/buildman/buildman.rst index 2a83cb7e4f8

[PATCH v2 2/4] buildman: Write out the build command used

2023-02-21 Thread Simon Glass
It is sometimes useful to see the exact 'make' command used by buildman for a commit. Add an output file for this. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 13 + tools/buildman/buildman.rst | 8 tool

[PATCH v2 4/4] buildman: Add a flag for reproducible builds

2023-02-21 Thread Simon Glass
This is quite a useful thing to use when building since it avoids small size changes between commits. Add a -r flag for it. Also undefine CONFIG_LOCALVERSION_AUTO since this appends the git hash to the version string, causing every build to be slightly different. Signed-off-by: Simon Glass

[PATCH v2 3/4] buildman: Support disabling LTO

2023-02-21 Thread Simon Glass
This cuts down build performance considerably and is not always needed, when checking for build errors, etc. Add a flag to disable it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 5 - tools/buildman/builderthread.py | 2 ++ tools/buildman

Re: [PATCH v2 1/1] spl: allow loading via partition type GUID

2023-02-21 Thread Simon Glass
Hi Heinrich, On Thu, 16 Feb 2023 at 23:56, Heinrich Schuchardt wrote: > > > > On 2/17/23 03:55, Simon Glass wrote: > > " properHi Heinrich, > > > > On Thu, 16 Feb 2023 at 14:31, Heinrich Schuchardt > > wrote: > >> > >> >

Re: [PATCH 5/9] binman: Implement missing check functions in mkimage entry

2023-02-21 Thread Simon Glass
On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > The mkimage entry is working like a section entry but inherits from > Entry not Entry_section. Copy implementations of missing Check-functions > from Entry_section and adopt to Entry_mkimage. > > Signed-off-by: Jonas Karlman > --- > tools/bi

Re: [PATCH 7/9] binman: Fix blank line usage for invalid images warning text

2023-02-21 Thread Simon Glass
adable. > > Signed-off-by: Jonas Karlman > --- > tools/binman/control.py | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 8/9] binman: Show filename in missing blob help message

2023-02-21 Thread Simon Glass
s/binman/control.py | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass Test?

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-21 Thread Simon Glass
SSING),--allow-missing > --ignore-missing) \ > + --allow-missing $(if > $(BINMAN_ALLOW_MISSING),--ignore-missing) \ > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ > -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \ > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > -- > 2.39.2 > I agree this is better, but we should see what Tom thinks. Reviewed-by: Simon Glass Regards, Simon

Re: [PATCH 2/2] cmd: introduce 'write' command

2023-02-21 Thread Simon Glass
Hi Rasmus, On Fri, 17 Feb 2023 at 17:59, Rasmus Villemoes wrote: > > It's almost no extra code to hook up a buddy to the 'read' command. In > fact, since the command is passed its own 'struct cmd_tbl', we can use > the exact same callback, and let it figure out for itself whether it > was invoked

Re: [PATCH 1/2] cmd: read: use part_get_info_by_dev_and_name_or_num() instead of open-coded dev_part parsing

2023-02-21 Thread Simon Glass
g the dev#partname > syntax as well, for accessing raw partitions by name. > > Signed-off-by: Rasmus Villemoes > --- > cmd/read.c | 32 > 1 file changed, 8 insertions(+), 24 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v3 58/76] Drop ubsha1 tool

2023-02-21 Thread Simon Glass
Hi Peter, On Mon, 20 Feb 2023 at 03:16, Peter Robinson wrote: > > On Wed, Feb 1, 2023 at 8:46 PM Simon Glass wrote: > > > > This seems to have been used by ppc4xx which was removed a while back. > > The Kconfig does not exist so it is never built. Drop it. > >

Re: [PATCH v3 2/3] kconfig: new macro IF_ENABLED()

2023-02-21 Thread Simon Glass
Hi Heinrich, On Mon, 20 Feb 2023 at 10:15, Andre Przywara wrote: > > On Sun, 19 Feb 2023 12:36:28 +0100 > Heinrich Schuchardt wrote: > > Hi, > > > We want to move from using #ifdef to using if in our code. A lot of our > > code using #ifdef is structured like: > > > > #ifdef CONFIG_FOO > >

Re: [PATCH 6/9] binman: Mark mkimage entry missing when its subnodes is missing

2023-02-21 Thread Simon Glass
hanged, 37 insertions(+), 1 deletion(-) > create mode 100644 tools/binman/test/278_mkimage_missing_multiple.dts > Reviewed-by: Simon Glass

[PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-21 Thread Simon Glass
This board has moved to standard boot but the old 'distro_bootcmd' command is still active. Disable DISTRO_DEFAULTS to fix this. Signed-off-by: Simon Glass --- configs/rockpro64-rk3399_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rockpro64-rk3399_defconfig

[PATCH 3/3] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-02-21 Thread Simon Glass
This is needed to enable the boot command used to start standard boot. Enable it by default. This brings in quite a few features, mostly in common with DISTRO_DEFAULTS Signed-off-by: Simon Glass --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig

[PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL

2023-02-21 Thread Simon Glass
standard passage[1] which should not be too far away. For now, disable it in TPL and SPL. [1] https://patchwork.ozlabs.org/project/uboot/cover/ 20220117150428.1580273-1-...@chromium.org/ Signed-off-by: Simon Glass --- configs/rockpro64-rk3399_defconfig | 5 - 1 file changed, 5 deletions

Re: [PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

2023-02-21 Thread Simon Glass
+++ > 3 files changed, 33 insertions(+), 11 deletions(-) Yippee! Reviewed-by: Simon Glass

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

2023-02-21 Thread Simon Glass
Hi Vagrant, On Tue, 21 Feb 2023 at 13:32, Vagrant Cascadian wrote: > > On 2023-02-20, Simon Glass wrote: > > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: > >> On 2022-12-07, Simon Glass wrote: > >> > Drop the use of scripts and rely on standard boot

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Simon Glass
Hi Tom, On Tue, 21 Feb 2023 at 16:02, Tom Rini wrote: > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wr

Re: [PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-02-21 Thread Simon Glass
t; Svyatoslav R. > > вт, 21 лют. 2023 р. о 21:37 Simon Glass пише: > > > > On Mon, 20 Feb 2023 at 10:41, Svyatoslav Ryhel > wrote: > > > > > > Remove need of dts binding for button keyboard since it reuses > > > gpio-keys binding. Select gpio-keys driver

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Simon Glass
Hi Tom, On Tue, 21 Feb 2023 at 16:09, Simon Glass wrote: > > Hi Tom, > > On Tue, 21 Feb 2023 at 16:02, Tom Rini wrote: > > > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 14 Feb 2023 at 09:

[PATCH v5 03/44] sh4: Drop unused twl6030 driver

2023-02-22 Thread Simon Glass
This is not used. Drop the driver and Kconfig option. Signed-off-by: Simon Glass --- (no changes since v1) drivers/input/Makefile | 1 - drivers/input/twl6030.c | 47 - 2 files changed, 48 deletions(-) delete mode 100644 drivers/input/twl6030.c diff

[PATCH v5 02/44] mtd: Drop unused CONFIG_ONENAND_U_BOOT

2023-02-22 Thread Simon Glass
This option does not exist, so the Makefile rule does nothing. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 54f894dab84..20608b6a800 100644 --- a/Makefile +++ b/Makefile @@ -956,7 +956,6

[PATCH v5 01/44] mtd: Drop unused kb9202_nand driver

2023-02-22 Thread Simon Glass
This is not used since time out of mind. Drop the driver and Kconfig option. Signed-off-by: Simon Glass Acked-by: Michael Trimarchi --- (no changes since v1) drivers/mtd/nand/raw/Makefile | 1 - drivers/mtd/nand/raw/kb9202_nand.c | 134 - 2 files changed

[PATCH v5 06/44] Correct SPL uses of ARCH_MVEBU

2023-02-22 Thread Simon Glass
This converts 2 usages of this option to the non-SPL form, since there is no SPL_ARCH_MVEBU defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) drivers/mmc/mv_sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/mv_sdhci.c b/drivers

[PATCH v5 10/44] Correct SPL uses of PHY_FIXED

2023-02-22 Thread Simon Glass
This converts 3 usages of this option to the non-SPL form, since there is no SPL_PHY_FIXED defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) drivers/net/mvneta.c | 4 ++-- net/mdio-uclass.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v5 09/44] Correct SPL use of PG_WCOM_UBOOT_UPDATE_SUPPORTED

2023-02-22 Thread Simon Glass
This converts 1 usage of this option to the non-SPL form, since there is no SPL_PG_WCOM_UBOOT_UPDATE_SUPPORTED defined in Kconfig Signed-off-by: Simon Glass Aleksandar Gerasimovski --- (no changes since v1) board/keymile/common/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v5 11/44] boot: Add Kconfigs for BOOTMETH_VBE_REQUEST

2023-02-22 Thread Simon Glass
Allow this to be enabled separately in U-Boot proper and in SPL, since it is not needed in SPL. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Avoid use of def_bool boot/Kconfig | 20 boot/Makefile | 3 ++- 2 files changed, 22 insertions(+), 1

[PATCH v5 12/44] Correct SPL use of DM_RNG

2023-02-22 Thread Simon Glass
This converts 1 usage of this option to the non-SPL form, since there is no SPL_DM_RNG defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) boot/vbe_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/vbe_request.c b/boot/vbe_request.c index

[PATCH v5 13/44] lib: Add a Kconfig for SPL_BZIP2

2023-02-22 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) lib/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index 83e5edd73b0..1c93f523b3a 100644 --- a/lib/Kconfig +++ b/lib/Kconfig

[PATCH v5 14/44] moveconfig: Various minor improvements

2023-02-22 Thread Simon Glass
). Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 91 + 1 file changed, 43 insertions(+), 48 deletions(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index b3ac2672737..ec2afa92e46 100755 --- a/tools/moveconfig.py

[PATCH v5 20/44] lib: Add VPL options for SHA1 and SHA256

2023-02-22 Thread Simon Glass
Add these options so these algorithms can be used in VPL. Signed-off-by: Simon Glass --- (no changes since v1) lib/Kconfig | 20 1 file changed, 20 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index 1c93f523b3a..08318843231 100644 --- a/lib/Kconfig +++ b/lib

[PATCH v5 19/44] env: Allow VPL environment to be nowhere

2023-02-22 Thread Simon Glass
Add an option to put the VPL environment nowhere (not in storage). Signed-off-by: Simon Glass --- (no changes since v1) env/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/env/Kconfig b/env/Kconfig index 6e24eee55f2..2bbe4c466a6 100644 --- a/env/Kconfig +++ b/env

[PATCH v5 16/44] event: Add Kconfig options for SPL

2023-02-22 Thread Simon Glass
Add options to enable events in SPL. This is mostly so the code can be excluded from SPL builds. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Modify to get rid of def_bool - Adjust Kconfig ordering common/Kconfig | 20 1 file changed, 20

[PATCH v5 30/44] lib: Add an SPL config for LIB_UUID

2023-02-22 Thread Simon Glass
This is selected by PARTITION_UUIDS which has a separate option for SPL. Add an SPL option for LIB_UUID also, so that we can keep them consistent. Also add one for PARTITION_TYPE_GUID to avoid a build error in part_efi.c which wants to call a uuid function in SPL. Signed-off-by: Simon Glass

[PATCH v5 15/44] sandbox: Expand size for VPL image

2023-02-22 Thread Simon Glass
Allow this to get larger to accommodate more test code with LTO disabled. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox_vpl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sandbox/dts/sandbox_vpl.dtsi b/arch/sandbox/dts

[PATCH v5 22/44] lib: Fix build condition for tiny-printf

2023-02-22 Thread Simon Glass
This should be checking for any SPL build. Drop the use of SPL_TPL_ since it is not necessary and will not work with split config. Signed-off-by: Simon Glass --- (no changes since v1) lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile b/lib/Makefile

[PATCH v5 25/44] sandbox: Tidy up I2C options

2023-02-22 Thread Simon Glass
At present we enable the sandbox I2C driver for all builds. Add a separate Kconfig option to control this, so that it can be disabled in TPL, where it is not needed. Signed-off-by: Simon Glass --- (no changes since v1) drivers/i2c/Kconfig | 20 1 file changed, 20

[PATCH v5 28/44] fixdep: Add some tests for parse_config_line()

2023-02-22 Thread Simon Glass
Add tests for this code to cover the basic cases. Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 73 ++ 1 file changed, 73 insertions(+) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index a49d35ba5f6

[PATCH v5 29/44] test: Add SPL versions of the TEST_KCONFIG options

2023-02-22 Thread Simon Glass
These are needed since we need a separate value in SPL and Proper. Signed-off-by: Simon Glass --- (no changes since v1) test/lib/Kconfig | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/test/lib/Kconfig b/test/lib/Kconfig index dbb03e4a36f..134cbb85b83

[PATCH v5 27/44] fixdep: Refactor to make testing easier

2023-02-22 Thread Simon Glass
Move the config parsing into a separate function so that it is possible to write tests for the function. Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 87 ++ 1 file changed, 54 insertions(+), 33 deletions(-) diff --git a

[PATCH v5 32/44] x86: Fix up use of X86_32BIT_INIT and X86_64 options

2023-02-22 Thread Simon Glass
Drop the invalid SPL_ in a CONFIG_IS_ENABLED() usage. Use the correct X86_64 option in msr.h since SPL may be 32-bit when U-Bout proper is not. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Reduce and rename commit arch/x86/cpu/qemu/qemu.c | 2 +- arch/x86/include

[PATCH v5 21/44] x86: Use string functions for all 32-bit builds

2023-02-22 Thread Simon Glass
At present these are not included in SPL. They do add to code size but are a bit faster, so adjust the setting to add them. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/include/asm/string.h | 2 +- arch/x86/lib/Makefile | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH v5 37/44] net: Add an SPL config for atheros

2023-02-22 Thread Simon Glass
Add a new SPL_PHY_ATHEROS to avoid a build error on am335x_evm with split config. Signed-off-by: Simon Glass Reviewed-by: Ramon Fried --- (no changes since v1) drivers/net/phy/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig

[PATCH v5 36/44] imx: Use SATA instead of CMD_SATA

2023-02-22 Thread Simon Glass
This causes a build failure on mx6cuboxi with split config, since CMD_SATA shows up as enabled in SPl (because there is no SPL_CMD_SATA). The condition is wrong anyway, so change it to use SATA instead. Signed-off-by: Simon Glass --- (no changes since v1) board/solidrun/mx6cuboxi/mx6cuboxi.c

[PATCH v5 35/44] freescale: Drop old pre-DM_ETH code

2023-02-22 Thread Simon Glass
This is used by ls1021atwr_sdcard_ifc_SECURE_BOOT with split config, but is not needed anymore, since Ethernet migration is complete. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/cpu/armv7/ls102xa/fdt.c | 12 1 file changed, 12 deletions(-) diff --git a

[PATCH v5 34/44] rockchip: Avoid checking environment without ENV_SUPPORT

2023-02-22 Thread Simon Glass
With split config, this causes a build error in SPL where the environment may not be enabled. It affects two rk3399 boards. Add a condition. Signed-off-by: Simon Glass --- (no changes since v1) board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- board/theobroma-systems/ringneck_px30

[PATCH v5 40/44] dm: Add a TPL symbol for simple-bus

2023-02-22 Thread Simon Glass
This is used in some x86 code, so add a symbol for it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index 6fc8854b574..0f755aa702e 100644 --- a/drivers/core

[PATCH v5 41/44] x86: coral: Add missing TPL options

2023-02-22 Thread Simon Glass
Some options should be enabled which are missing. Fix this. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Reduce and rename commit configs/chromebook_coral_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/chromebook_coral_defconfig b/configs

[PATCH v5 43/44] venice: Simplify conditions for network init

2023-02-22 Thread Simon Glass
The conditions in this code do not align when doing an SPL build with split config. Use __maybe_unused to avoid needing to be so explicit. Of course a better solution would be to refactor all of this to avoid using #ifdef. Signed-off-by: Simon Glass --- (no changes since v1) board/gateworks

[PATCH v5 31/44] test: Tidy up sandbox handling in test-main

2023-02-22 Thread Simon Glass
This is pretty messy at present since it relies on a SPL_SANDBOX option that does not exist. Use the normal options instead, so that it will work with split config. Signed-off-by: Simon Glass --- (no changes since v1) test/test-main.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v5 26/44] fixdep: Add support for VPL

2023-02-22 Thread Simon Glass
Add VPL files into the mix so that we can fix up the dependencies there. Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 5ced0f6b069..3d40bd7ee25 100644

[PATCH v5 44/44] command: Don't allow commands in SPL

2023-02-22 Thread Simon Glass
At present we compile commands into U-Boot SPL even though they cannot be used. This wastes space. Adjust the condition to avoid this. Signed-off-by: Simon Glass --- Changes in v5: - Drop FSL_ISBC_KEY_EXT patch as it changes the size - Drop PHY_CADENCE_SIERRA patch as it changes the size

[PATCH v5 42/44] power: wandboard: Add a missing CONFIG

2023-02-22 Thread Simon Glass
We should enable pmic in SPL since it is used. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Fix 'wanderboard' typo - Reduce and rename commit configs/wandboard_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/wandboard_defconfig

[PATCH v5 39/44] serial: Support ns16550 driver in TPL

2023-02-22 Thread Simon Glass
Add options for this since they are needed by P1020RDB-PC_NAND. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index bb5083201b3..6f40c051604 100644 --- a

[PATCH v5 33/44] Add VPL options for BLOBLIST

2023-02-22 Thread Simon Glass
We can use this feature in VPL, so add some options for it. Also fix a typo in the SPL help while we are here. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/common/Kconfig

[PATCH v5 24/44] sandbox: Use the generic VPL option to enable VPL

2023-02-22 Thread Simon Glass
Avoid using CONFIG_SANDBOX_VPL since we have a generic option which works just as well. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts

[PATCH v5 04/44] moveconfig: Update to detect / correct missing SPL Kconfigs

2023-02-22 Thread Simon Glass
IS_ENABLED() and CONFIG_$(SPL)_FOO to CONFIG_FOO, creating commits automatically if requested. These features are only useful for code clean-up, not for normal development. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rebase to previous series tools/moveconfig.py | 599

[PATCH v5 07/44] Correct SPL uses of DISPLAY_AER_FULL

2023-02-22 Thread Simon Glass
This converts 2 usages of this option to the non-SPL form, since there is no SPL_DISPLAY_AER_FULL defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) drivers/sysreset/sysreset_mpc83xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v5 23/44] sandbox: Tidy up RTC options

2023-02-22 Thread Simon Glass
At present we enable the sandbox RTC driver for all builds. Add a separate Kconfig option to control this, so that it can be disabled in TPL, where it is not needed. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix a transitory build error with sandbox_spl arch

[PATCH v5 18/44] env: Avoid checking ENV_IS_IN when env disabled

2023-02-22 Thread Simon Glass
This check is not needed when the environment is not enabled, e.g. in SPL. Add a condition to handle this. Signed-off-by: Simon Glass --- (no changes since v1) cmd/nvedit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 7cbc3fd573a..277293679df 100644

[PATCH v5 05/44] bootstd: Disable QFW bootmeth in SPL

2023-02-22 Thread Simon Glass
Move this Makefile line into the non-SPL area so we don't have to repy on the SPL_TPL_ macro. Signed-off-by: Simon Glass --- Changes in v5: - Fix reply typo Changes in v3: - Add new patch to disable QFW bootmeth in SPL boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v5 38/44] freescale: Fix odd use of ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE

2023-02-22 Thread Simon Glass
matches the behaviour in fsl_esdhc_mmc.c which seem to have a similar problem. This fixes a build error with split config on T2080QDS. Note: This should be handled in the devicetree. Signed-off-by: Simon Glass --- No size changes on affected boards: aarch64: w+ ls1088aqds ls1088aqds_qspi

[PATCH v5 17/44] bootstd: Correct 'VPL' typo

2023-02-22 Thread Simon Glass
Correct a 'VPL' typo in the Kconfig. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Just fix the typo Changes in v3: - Correct 'VPL' typo - Use a consistent format for the comment boot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v5 08/44] Correct SPL uses of MULTIPLEXER

2023-02-22 Thread Simon Glass
This converts 3 usages of this option to the non-SPL form, since there is no SPL_MULTIPLEXER defined in Kconfig Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v3) Changes in v3: - Move the option down to the non-SPL part of drivers/Makefile drivers/Makefile | 2

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-22 Thread Simon Glass
Hi, On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wrote: > > On 2023-02-22 19:24, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian wrote: > >> On 2023-02-21, Vagrant Cascadian wrote: > >>> On 2023-02-21, Simon Glass wrote: > >&g

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-22 Thread Simon Glass
Hi Tom, On Wed, 22 Feb 2023 at 12:01, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > > Hi, > > > > On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wrote: > > > > > > On 2023-02-22 19:24, Tom Rini wrote: > > >

[PATCH v2 00/13] video: efi: Improve the EFI-app video console

2023-02-22 Thread Simon Glass
- Dropping debugging printf() - use new bootph-xxx tag - Add new patch to show the size of the copy framebuffer with bdinfo Simon Glass (13): efi: video: Move payload code into a function efi: video: Return mode info for app also efi: Support a 64-bit frame buffer address x86: Add a few

[PATCH v2 02/13] efi: video: Return mode info for app also

2023-02-22 Thread Simon Glass
The mode info is currently not initialised for the app. Fix this by returning it from the function. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/efi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/video/efi.c b/drivers/video/efi.c

[PATCH v2 01/13] efi: video: Move payload code into a function

2023-02-22 Thread Simon Glass
Put this into a function, as we have done for the app implementation. Comment both functions. FOr now the app still does not access it correctly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/efi.c | 83 +++-- 1 file changed, 57

[PATCH v2 03/13] efi: Support a 64-bit frame buffer address

2023-02-22 Thread Simon Glass
. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/fsp/fsp_graphics.c | 2 +- drivers/pci/pci_rom.c | 10 ++ drivers/video/coreboot.c| 2 +- drivers/video/efi.c | 34 + include/vesa.h | 16

[PATCH v2 04/13] x86: Add a few more items to bdinfo

2023-02-22 Thread Simon Glass
Add the timer and vendor/model information. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/bdinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/lib/bdinfo.c b/arch/x86/lib/bdinfo.c index 0cb79b01bd3..896de37dce4 100644 --- a/arch/x86/lib/bdinfo.c +++ b

[PATCH v2 05/13] efi: Use a fixed value for the timer clock

2023-02-22 Thread Simon Glass
It is not yet clear how to read the timer via EFI. The current value seems much too high on a Framework laptop I tried. Adjust it to a lower hard-coded value for now. Signed-off-by: Simon Glass --- (no changes since v1) drivers/timer/tsc_timer.c | 4 1 file changed, 4 insertions(+) diff

[PATCH v2 06/13] efi: Support copy framebuffer

2023-02-22 Thread Simon Glass
Add support for this to EFI in case it becomes useful. At present it just slows things down. You can enable CONFIG_VIDEO_COPY to turn it on. Signed-off-by: Simon Glass --- Changes in v2: - Obtain copy framebuffer size from EFI instead of using a fixed value - Dropping debugging printf() - use

  1   2   3   4   5   6   7   8   9   10   >