Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-23 Thread Thomas Lamprecht
Am 22/10/2024 um 17:46 schrieb Christian Ebner: > I refrained from doing so as I saw that typically fixes to mainline are > back-ported to stable, but since this is already fixed in the latest > version, I was hoping for upstream guidance on how to proceed > (unfortunately without reply). Hmm,

[pve-devel] Unable to connect from Guest VM running on Proxmox to connect to internet via wireguard

2024-10-23 Thread Christian Moser
Hello, I have setup wireguard on my Proxmox KVM host system and I have verified the connectivity to the remote internet node (10.10.100.9 in my case). This is working fine. But I fail to setup a network interface on the Guest VM to allow to connect from the Guest VM to this 10.10.100.9 node. I h

Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-23 Thread Christian Ebner
On 10/23/24 10:28, Thomas Lamprecht wrote: Am 22/10/2024 um 17:46 schrieb Christian Ebner: I refrained from doing so as I saw that typically fixes to mainline are back-ported to stable, but since this is already fixed in the latest version, I was hoping for upstream guidance on how to proceed (u

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-23 Thread Fabian Grünbichler
some high level comments: I am not sure how much we gain here with the raw support? it's a bit confusing to have a volid ending with raw, with the current volume and all but the first snapshot actually being stored in qcow2 files, with the raw file being the "oldest" snapshot in the chain.. if

Re: [pve-devel] [PATCH v2 pve-storage 2/2] add lvmqcow2 plugin: (lvm with external qcow2 snapshot)

2024-10-23 Thread Fabian Grünbichler
I am not yet convinced this is somehow a good idea, but maybe you can convince me otherwise ;) variant A: this is just useful for very short-lived snapshots variant B: these snapshots are supposed to be long-lived A is not something we want. we intentionally don't have non-thin LVM snapshots fo

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread Fabian Grünbichler
> Alexandre Derumier via pve-devel hat am > 30.09.2024 13:31 CEST geschrieben: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 108 -- > 1 file changed, 95 insertions(+), 13 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/Qemu

[pve-devel] [PATCH qemu-server v2] vm_start: add syslog info with which PID a VM was started

2024-10-23 Thread Daniel Kral
Adds a syslog entry to log the process id that has been given to the QEMU VM process at start. This is helpful debugging information if the pid shows up at other places, like a kernel stack trace, while the VM has been running, but cannot be retrieved anymore (e.g. the pidfile has been deleted or o

Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES

2024-10-23 Thread Fiona Ebner
Am 22.10.24 um 15:35 schrieb Thomas Lamprecht: > Am 22/10/2024 um 14:15 schrieb Maximiliano Sandoval: >> Thomas Lamprecht writes: >> >>> And even then, would this still break restoring backups made before that >>> change? >>> If, this would fall under the changes that need versioning the guest >>>

Re: [pve-devel] [PATCH qemu-server] vm_start: add syslog info with which PID a VM was started

2024-10-23 Thread Daniel Kral
On 10/22/24 13:13, Fiona Ebner wrote: Am 26.09.24 um 10:36 schrieb Daniel Kral: Adds a syslog entry to log the process id that has been given to the QEMU VM process at start. This is helpful debugging information if the pid shows up at other places, like a kernel stack trace, while the VM has be

Re: [pve-devel] Unable to connect from Guest VM running on Proxmox to connect to internet via wireguard

2024-10-23 Thread Andreas Steinel via pve-devel
--- Begin Message --- Hi Christian, On Wed, Oct 23, 2024 at 11:39 AM Christian Moser wrote: > Any thoughts? any help or pointers? This is the development mailing list, there is a user mailing list [1] and a forum [2] which are both better suited for your question. [1] https://lists.proxmox.co

Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES

2024-10-23 Thread Thomas Lamprecht
Am 23/10/2024 um 11:56 schrieb Fiona Ebner: > Maybe we could have (datacenter-wide?) default profiles (one for > containers, one for VMs) whose values are used for new guest creation? > Users could modify them if desired and they could also be used to > pre-fill values in the UI. Could then be ship

[pve-devel] [PATCH manager v2 5/6] ui: vm: make cloudinit drive editable

2024-10-23 Thread Daniel Kral
Implements the functionality to allow changes to the CloudInit drive under the VM "Hardware" tab after it has already been created by the user. Signed-off-by: Daniel Kral --- www/manager6/qemu/CIDriveEdit.js | 63 +-- www/manager6/qemu/HardwareView.js | 4 +- 2 file

[pve-devel] [PATCH manager v2 3/6] ui: vm: factor out async I/O type selector

2024-10-23 Thread Daniel Kral
Factors out the combo box used for the Async I/O combo box selector, which is used in the Disk Edit modal window in the VM "Hardware" tab and the "Disks" tab in the Create Wizard, to reuse it in a future commit. Signed-off-by: Daniel Kral --- www/manager6/Makefile| 1 + www/

[pve-devel] [PATCH manager v2 1/6] ui: vm: change var to let in CDROM and CloudInit edit modals

2024-10-23 Thread Daniel Kral
Signed-off-by: Daniel Kral --- www/manager6/qemu/CDEdit.js | 35 +--- www/manager6/qemu/CIDriveEdit.js | 20 ++ 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index 3cc1620

[pve-devel] [PATCH manager v2 6/6] fix #5430: ui: vm: allow editing cloudinit aio and cache options

2024-10-23 Thread Daniel Kral
Adds cache and async I/O selectors to the CloudInit Drive Edit modal window in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. Signed-off-by: Daniel Kral

[pve-devel] [PATCH manager v2 4/6] fix #5430: ui: vm: allow editing cdrom aio and cache options

2024-10-23 Thread Daniel Kral
Adds cache and async I/O selectors to the CDROM Drive Edit modal in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. To accommodate the new fields in the mo

[pve-devel] [PATCH manager v2 2/6] ui: vm: improve code readability of CDROM and CloudInit edit modals

2024-10-23 Thread Daniel Kral
Improves the readability of the CDROM and CloudInit edit modals by making them consistent with each other, i.e. having more readable variable names and storing significant subcomponents in variables. This does not intend any functional changes in the behavior or appearance of either component. Si

[pve-devel] [PATCH manager v2 0/6] fix #5430: ocfs2 io_uring read write

2024-10-23 Thread Daniel Kral
Since around Linux kernel version 6.7 [0], and as reported by users kernel version `6.8.4-2-pve`, a bug was introduced by a refactoring of the io_read function in the io_uring subsystem. This causes any VM to fail to start, when io_uring is used for CDROM drives (including CloudInit drives) and VM

Re: [pve-devel] [PATCH manager 3/5] fix #5430: ui: vm: allow editing cdrom aio and cache options

2024-10-23 Thread Daniel Kral
On 10/18/24 09:42, Lukas Wagner wrote: @@ -125,7 +151,7 @@ Ext.define('PVE.qemu.CDInputPanel', { Ext.define('PVE.qemu.CDEdit', { extend: 'Proxmox.window.Edit', -width: 400, +width: 550, This change is not mentioned in the commit message and should probably be split out into

Re: [pve-devel] [PATCH v2 pve-storage 2/2] add lvmqcow2 plugin: (lvm with external qcow2 snapshot)

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>I am not yet convinced this is somehow a good idea, but maybe you can >>convince me otherwise ;) >> >>variant A: this is just useful for very short-lived snapshots >>variant B: these snapshots are supposed to be long-lived Can you defined "short "/ "long" ? and the differe

[pve-devel] applied: [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-23 Thread Thomas Lamprecht
Am 02/10/2024 um 16:36 schrieb Christian Ebner: > Fixes rare read corruption issues using the in kernel ceph client. > > On incomplete read requests, the clean tail flag should make sure to > zero fill the remaining bytes for the subrequest. > If the iov iterator is not at the correct position, th

[pve-devel] [PATCH manager v3 4/6] fix #5430: ui: vm: allow editing cdrom aio and cache options

2024-10-23 Thread Daniel Kral
Adds cache and async I/O selectors to the CDROM Drive Edit modal in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. To accommodate the new fields in the mo

[pve-devel] [PATCH manager v3 3/6] ui: vm: factor out async I/O type selector

2024-10-23 Thread Daniel Kral
Factors out the combo box used for the Async I/O combo box selector, which is used in the Disk Edit modal window in the VM "Hardware" tab and the "Disks" tab in the Create Wizard, to reuse it in a future commit. Signed-off-by: Daniel Kral --- www/manager6/Makefile| 1 + www/

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi Fabian, thanks for the review ! >> Message initial >>De: Fabian Grünbichler >>À: Proxmox VE development discussion >>Cc: Alexandre Derumier >>Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external >>snasphot support >>Date: 23/10/2024 12:12:46

[pve-devel] [PATCH manager v3 6/6] fix #5430: ui: vm: allow editing cloudinit aio and cache options

2024-10-23 Thread Daniel Kral
Adds cache and async I/O selectors to the CloudInit Drive Edit modal window in the "Hardware" tab. This allows users to set these options in the WebGUI when the VM fails to start because the underlying storage (driver) does not support a specific set of configurations. Signed-off-by: Daniel Kral

[pve-devel] [PATCH manager v3 0/6] fix #5430: ocfs2 io_uring read write

2024-10-23 Thread Daniel Kral
Since around Linux kernel version 6.7 [0], and as reported by users kernel version `6.8.4-2-pve`, a bug was introduced by a refactoring of the io_read function in the io_uring subsystem. This causes any VM to fail to start, when io_uring is used for CDROM drives (including CloudInit drives) and VM

[pve-devel] [PATCH manager v3 5/6] ui: vm: make cloudinit drive editable

2024-10-23 Thread Daniel Kral
Implements the functionality to allow changes to the CloudInit drive under the VM "Hardware" tab after it has already been created by the user. Signed-off-by: Daniel Kral --- www/manager6/qemu/CIDriveEdit.js | 63 +-- www/manager6/qemu/HardwareView.js | 4 +- 2 file

[pve-devel] [PATCH manager v3 2/6] ui: vm: improve code readability of CDROM and CloudInit edit modals

2024-10-23 Thread Daniel Kral
Improves the readability of the CDROM and CloudInit edit modals by making them consistent with each other, i.e. having more readable variable names and storing significant subcomponents in variables. This does not intend any functional changes in the behavior or appearance of either component. Si

[pve-devel] [PATCH manager v3 1/6] ui: vm: change var to let in CDROM and CloudInit edit modals

2024-10-23 Thread Daniel Kral
Signed-off-by: Daniel Kral --- www/manager6/qemu/CDEdit.js | 35 +--- www/manager6/qemu/CIDriveEdit.js | 20 ++ 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index 3cc1620

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>if we want the current volume to keep its name, and the snapshot >>volume to actually contain *that* snapshot's data, we need some sort >>of rename dance here as well.. i.e., rename the current volume to >>have the snapshot volume name, then snapshot it back into the >>"curr

Re: [pve-devel] [PATCH v2 qemu-server 1/1] implement external snapshot

2024-10-23 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- ok, I think it could be possible to use blockdev-reopen to rename current filename https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg04455.html example: take snapshot : snap1 on vm-disk-100-disk-0.qcow2 - create a hardlink: ln vm-disk-100-disk-0.qcow2 vm-disk-100-disk

Re: [pve-devel] [PATCH manager v2 0/6] fix #5430: ocfs2 io_uring read write

2024-10-23 Thread Daniel Kral
On 10/23/24 13:22, Daniel Kral wrote: - Change "widget.AsyncIOTypeSelector" to "widget.pveAsyncIoTypeSelector" Unfortunately missed to change the usages of the component accordingly (in patch #3, #4 and #6) when sending the patches, therefore sent a v3 [0]. [0] https://lore.proxmox.com/pve-

[pve-devel] [PATCH common 1/1] fix #5623: ovs other_config set to 0 not saved in network config

2024-10-23 Thread Tiomet Pelston via pve-devel
--- Begin Message --- When configuring an OVS network device via web interface, any OVS option set to value=0 is ignored upon saving. This happens because value=0 is evaluated as false in $parse_ovs_option. Signed-off-by: Tiomet Pelston --- src/PVE/INotify.pm | 2 +- 1 file changed, 1 insertion(

[pve-devel] [PATCH common 0/1] fix #5623: ovs other_config set to 0 not saved in network config

2024-10-23 Thread Tiomet Pelston via pve-devel
--- Begin Message --- When configuring an OVS network device via web interface, setting an OVS option with value=0 will be disregarded on save. Example: Create an OVS Bond with the following OVS option: other_config:bond-rebalance-interval=0 This will be purged from the config although it is a

Re: [pve-devel] [PATCH SERIES v2 pve-storage/qemu-server] add external qcow2 snapshot support

2024-10-23 Thread Esi Y via pve-devel
--- Begin Message --- Thank you, Alexandre, for the background / historical information. On Tue, Oct 22, 2024 at 4:54 PM DERUMIER, Alexandre wrote: > > Message initial > De: Esi Y via pve-devel > Répondre à: Proxmox VE development discussion de...@lists.proxmox.com> > À: Proxm