[pve-devel] [PATCH qemu-server 1/4] usb: fix undef error on string match

2024-03-18 Thread Dominik Csapak
'$entry->{host}' can be empty, so we have to check for that before doing a regex check, otherwise we get ugly errors in the log Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8d0e

[pve-devel] [PATCH qemu-server 2/4] pci: set 'enable-migration' to on for live-migration marked mapped devices

2024-03-18 Thread Dominik Csapak
the default is 'auto', but for those which are marked as capable for live migration, we want to explicitly enable that, so we get an early error on start if the driver does not support that. Signed-off-by: Dominik Csapak --- PVE/QemuServer/PCI.pm | 8 +++- 1 file changed, 7 insertions(+), 1

[pve-devel] [PATCH docs 2/2] qm: resource mapping: document `live-migration-capable` setting

2024-03-18 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- qm.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qm.adoc b/qm.adoc index c146ce9..c77cb7b 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1746,6 +1746,12 @@ Currently there are the following options: the mapping, the mediated device will be create on t

[pve-devel] [PATCH qemu-server 4/4] api: enable live migration for marked mapped pci devices

2024-03-18 Thread Dominik Csapak
They have to be marked as 'live-migration-capable' in the mapping config, and the driver and qemu must support it. For the gui checks, we now return a list of 'mapped-with-live-migration' entries in the migration preflight api call too. Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 5

[pve-devel] [PATCH docs 1/2] qm: resource mapping: add description for `mdev` option

2024-03-18 Thread Dominik Csapak
in a new section about additional options Signed-off-by: Dominik Csapak --- qm.adoc | 13 + 1 file changed, 13 insertions(+) diff --git a/qm.adoc b/qm.adoc index 1170dd1..c146ce9 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1734,6 +1734,19 @@ To create mappings `Mapping.Modify` on `/mapp

[pve-devel] [PATCH manager 1/1] ui: allow configuring and live migration of mapped pci resources

2024-03-18 Thread Dominik Csapak
if the hardware/driver is capable, the admin can now mark a pci device as 'live-migration-capable', which then tries enabling live migration for such devices. mark it as experimental when configuring and in the migrate window Signed-off-by: Dominik Csapak --- www/manager6/window/Migrate.js|

[pve-devel] [PATCH guest-common 2/2] mapping: pci: optionally return the config in 'find_on_current_node'

2024-03-18 Thread Dominik Csapak
this is useful to get to the config without having to parse it again Signed-off-by: Dominik Csapak --- src/PVE/Mapping/PCI.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/PVE/Mapping/PCI.pm b/src/PVE/Mapping/PCI.pm index 0866175..9d8a4a7 100644 --- a/src/PVE/Map

[pve-devel] [PATCH guest-common 1/2] mapping: pci: add 'live-migration-capable' flag to mappings

2024-03-18 Thread Dominik Csapak
so that we can decide in qemu-server to allow live-migration. the driver and qemu must be capable of that, and it's the admins responsibility to know and configure that Mark the option as experimental in the description. Signed-off-by: Dominik Csapak --- src/PVE/Mapping/PCI.pm | 9 + 1

[pve-devel] [PATCH guest-common/qemu-server/manager/docs] enable experimental support for pci live migration

2024-03-18 Thread Dominik Csapak
for mapped resources. This requires driver and hardware support, but aside from nvidia vgpus there don't seem to be many drivers (if any) that do support that. qemu already supports that for vfio-pci devices, so nothing to be done there besides actively enabling it. Since we currently can't prope

[pve-devel] [PATCH qemu-server 3/4] check_local_resources: add more info per mapped device

2024-03-18 Thread Dominik Csapak
such as the mapping name and if it's marked for live-migration (pci only) Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 2 +- PVE/QemuMigrate.pm | 5 +++-- PVE/QemuServer.pm | 10 ++ 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Q

Re: [pve-devel] [PATCH pve-network 0/8] SDN Vnet blackbox testing

2024-03-18 Thread Max Carrara
On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote: > Add several tests for Vnets. State setup as well as testing results is > done only via the API to test on the API boundaries not not against the > internal state. Internal state is mocked to avoid requiring access to > system files or pmxcfs.

Re: [pve-devel] [PATCH pve-network 8/8] test(vnets): add test_vnets_blackbox

2024-03-18 Thread Max Carrara
On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote: > Add several tests for Vnets. State setup as well as testing results is > done only via the API to test on the API boundaries not not against the > internal state. Internal state is mocked to avoid requiring access to > system files or pmxcfs.

[pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout

2024-03-18 Thread Dominik Csapak
since some time (not sure when exactly), the 'load()' method of the edit window did not correctly mask the window anymore the reason seems to be that the API2Request tries to mask the component before it's rendered, and that did never work correctly judging from the existing comment. Instead of s

Re: [pve-devel] [PATCH pve-network 8/8] test(vnets): add test_vnets_blackbox

2024-03-18 Thread Stefan Lendl
"Max Carrara" writes: > On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote: >> Add several tests for Vnets. State setup as well as testing results is >> done only via the API to test on the API boundaries not not against the >> internal state. Internal state is mocked to avoid requiring access

Re: [pve-devel] [PATCH pve-network 8/8] test(vnets): add test_vnets_blackbox

2024-03-18 Thread Max Carrara
On Mon Mar 18, 2024 at 3:14 PM CET, Stefan Lendl wrote: > "Max Carrara" writes: > > > On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote: > >> Add several tests for Vnets. State setup as well as testing results is > >> done only via the API to test on the API boundaries not not against the > >>

Re: [pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout

2024-03-18 Thread Thomas Lamprecht
On 18/03/2024 14:44, Dominik Csapak wrote: > since some time (not sure when exactly), the 'load()' method of the edit > window did not correctly mask the window anymore > > the reason seems to be that the API2Request tries to mask the component > before it's rendered, and that did never work corre

Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

2024-03-18 Thread Thomas Lamprecht
On 12/03/2024 12:59, Christoph Heiss wrote: > Otherwise, when using the serial debug shell, the console size will be > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > properly. That's ok, but... > > It also adjust the size to the proper 80x24 instead of 80x25, as > adv

Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

2024-03-18 Thread Christoph Heiss
On Mon, Mar 18, 2024 at 04:55:20PM +0100, Thomas Lamprecht wrote: > On 12/03/2024 12:59, Christoph Heiss wrote: > > Otherwise, when using the serial debug shell, the console size will be > > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > > properly. > > That's ok, but...